[00:00:05] I was thinking we should probably split the approvePayment method out of the IPaymentProvider interface since in general we only do it for CC [00:01:06] anyway, it's super late for you! [00:02:19] ha yeah I'm good. I wanted to get this finish as I'm out tomorrow. that flow was the last step so now it's just tidy up and then taking the patch out of WIP [00:02:37] cool cool [00:03:51] I have wheat beer and https://en.wikipedia.org/wiki/In_Search_of_Sunrise_4:_Latin_America on so it's a nice vibe [00:09:36] nice [00:15:33] ejegg|food: I'm gonna u-turn on the Authorized flow for non-cc payments. I don't think it's needed now so I'll abandon that patch and remove the test for it on the cash payment DI patch [00:15:43] and we can ask dlocal on the next call just to confirm [00:15:44] k, sounds good [00:16:39] (03Abandoned) 10Jgleeson: Move approvePayment() up to PaymentProvider class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889895 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [00:27:53] jgleeson: would you sign up for a server-powered water heater? https://www.tomshardware.com/news/heata-server-hot-water-trial-uk [00:43:31] ejegg: interesting! I think my hot water comes directly from the combo boiler and we don't use a tank anymore. That does sound neat though [00:48:21] (03PS4) 10Ejegg: Initiate recurring profiles in PayPal resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/886129 (https://phabricator.wikimedia.org/T324642) [00:49:49] (03CR) 10Ejegg: "Thanks for the review wfan - I've made that string configurable." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/886129 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [01:01:20] (03CR) 10Wfan: [C: 03+1] "Thanks for the translation, looks good, just a question" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/886129 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [01:01:30] argh [01:02:04] performed the final smoke test and realised the country-specific cash payment method isn't being set on the final API call to dlocal [01:02:33] so it's being treated as the catch-all [01:02:41] damn [01:14:17] (03PS22) 10Jgleeson: WIP: Handle submission for DLocal REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) [01:15:47] (03CR) 10CI reject: [V: 04-1] WIP: Handle submission for DLocal REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [01:17:27] ok I guess it's time to throw in the towel and figure out that last bit on Monday [01:17:36] have a great weekend fr-tech [02:59:18] (03PS5) 10Ejegg: Initiate recurring profiles in PayPal resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/886129 (https://phabricator.wikimedia.org/T324642) [04:22:04] (03CR) 10Ejegg: [C: 03+1] "+1 for all of Jack's work on this. Jack, if you're OK with the small changes I made in PS3 I'm happy to C+2 this." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/888077 (https://phabricator.wikimedia.org/T324302) (owner: 10Jgleeson) [04:28:31] (03CR) 10Ejegg: Initiate recurring profiles in PayPal resolver (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/886129 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [14:35:49] 10Fundraising-Backlog, 10FR-dlocal: Refactor the current dLocal StatusNormalizers. - https://phabricator.wikimedia.org/T329838 (10SuvamManna) Ok, thanks! [17:01:21] (03CR) 10Wfan: [C: 03+2] "Thanks Elliott looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/886129 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [17:02:52] (03CR) 10CI reject: [V: 04-1] Initiate recurring profiles in PayPal resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/886129 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [17:07:15] 10fundraising-tech-ops: reimage fundraising queue role servers to Bullseye - https://phabricator.wikimedia.org/T327453 (10Dwisehaupt) [17:15:49] 10Fundraising-Backlog, 10Product-Analytics, 10Research, 10Wikimedia-CentralNotice-Administration, 10Wiki-Loves-Monuments (FY 2021-2022): Conduct research on WLM centralnotice banners - https://phabricator.wikimedia.org/T290387 (10Ciell) @Effeietsanders am I correct that the paper on this research is now... [17:16:48] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ewilson - https://phabricator.wikimedia.org/T329651 (10Dwisehaupt) 05Open→03Resolved No longer with the foundation. Revoked the cert. [17:37:03] 10fundraising-tech-ops: Deactivate fundraising accounts for ewilson - https://phabricator.wikimedia.org/T329965 (10Dwisehaupt) [17:41:32] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: It should not be possible to run a banner campaign with a syntax error - https://phabricator.wikimedia.org/T268792 (10Ciell) [17:43:57] 10fundraising-tech-ops: Deactivate fundraising accounts for ewilson - https://phabricator.wikimedia.org/T329965 (10Dwisehaupt) [19:48:16] 10Fundraising-Backlog, 10Product-Analytics, 10Research, 10Wikimedia-CentralNotice-Administration, 10Wiki-Loves-Monuments (FY 2021-2022): Conduct research on WLM centralnotice banners - https://phabricator.wikimedia.org/T290387 (10Effeietsanders) No, this is unrelated. [20:52:26] 10Fundraising-Backlog: Is JCB supported on Gpay in Japan? - https://phabricator.wikimedia.org/T329676 (10EMartin) Adyen investigated JCB support on Gpay and had this to say: // JCB is actually still negotiating with Google Pay to be fully implemented. As of right now, there is no support for JCB with Google Pay... [22:39:58] (03PS1) 10Eileen: Update phpunit/phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/890055 [22:46:57] (03CR) 10CI reject: [V: 04-1] Update phpunit/phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/890055 (owner: 10Eileen) [22:54:36] (03PS2) 10Eileen: Update phpunit/phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/890055 [23:02:06] (03CR) 10CI reject: [V: 04-1] Update phpunit/phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/890055 (owner: 10Eileen) [23:05:57] (03PS3) 10Eileen: Update phpunit/phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/890055 [23:12:53] (03CR) 10CI reject: [V: 04-1] Update phpunit/phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/890055 (owner: 10Eileen) [23:14:24] (03PS4) 10Eileen: Update phpunit/phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/890055 [23:17:26] (03CR) 10Ejegg: [C: 03+2] "Re-applying wfan's C+2 for transient failure in gate-and-submit" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/886129 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [23:28:39] (03CR) 10CI reject: [V: 04-1] Update phpunit/phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/890055 (owner: 10Eileen) [23:32:37] (03Merged) 10jenkins-bot: Initiate recurring profiles in PayPal resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/886129 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [23:33:55] (03CR) 10Ejegg: [C: 04-1] "This looks great! Just one thing we can't use till PHP 8, and an interface we can now add." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889629 (https://phabricator.wikimedia.org/T324727) (owner: 10Wfan) [23:37:12] (03PS5) 10Wfan: Add cancel payment for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889629 (https://phabricator.wikimedia.org/T324727) [23:52:39] (03PS6) 10Ejegg: Add cancel payment for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889629 (https://phabricator.wikimedia.org/T324727) (owner: 10Wfan) [23:52:49] (03CR) 10Ejegg: [C: 03+2] "Thanks, this looks great!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889629 (https://phabricator.wikimedia.org/T324727) (owner: 10Wfan) [23:53:18] (03PS2) 10Ejegg: Add unit test for cancelPayment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889824 (https://phabricator.wikimedia.org/T324727) (owner: 10Wfan) [23:53:23] (03CR) 10Ejegg: [C: 03+2] Add unit test for cancelPayment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889824 (https://phabricator.wikimedia.org/T324727) (owner: 10Wfan) [23:53:30] (03Merged) 10jenkins-bot: Add cancel payment for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889629 (https://phabricator.wikimedia.org/T324727) (owner: 10Wfan) [23:54:00] (03Merged) 10jenkins-bot: Add unit test for cancelPayment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889824 (https://phabricator.wikimedia.org/T324727) (owner: 10Wfan) [23:54:50] thanks for the CR on that paypal resolver patch, wfan! [23:55:06] I'm half tempted to just turn it on and go on vacation :) [23:57:50] (03CR) 10Wfan: [C: 03+2] "Tested with php PaymentProviders/dlocal/Maintenance/TestAuthorizeRedirectPayment.php, dose see the x-idempotency-key and less than max 42" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889861 (https://phabricator.wikimedia.org/T326772) (owner: 10Ejegg) [23:58:23] (03Merged) 10jenkins-bot: Add idempotency headers to dlocal request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889861 (https://phabricator.wikimedia.org/T326772) (owner: 10Ejegg)