[00:01:55] 10Fundraising-Backlog, 10DNS, 10Infrastructure-Foundations, 10Mail, and 3 others: Consider if to support BIMI for wiki mail - https://phabricator.wikimedia.org/T311685 (10BCornwall) p:05Medium→03Low [00:18:43] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10FR-dlocal: Investigate potential temporary code solution for receiving old and new data formats from dlocal - https://phabricator.wikimedia.org/T329289 (10Cstone) a:03Cstone [01:25:15] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Civi security update (minor) due out - https://phabricator.wikimedia.org/T329681 (10Eileenmcnaughton) 05Open→03Resolved [01:25:24] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Civi security update (minor) due out - https://phabricator.wikimedia.org/T329681 (10Eileenmcnaughton) [01:26:50] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Importing Activity Updates - https://phabricator.wikimedia.org/T219191 (10Eileenmcnaughton) I'm gonna close this cos I'm pretty sure it got fixed along the line- the main issue... [01:27:00] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Importing Activity Updates - https://phabricator.wikimedia.org/T219191 (10Eileenmcnaughton) 05Open→03Resolved [01:58:11] Would someone be able to +2 this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/890136 [07:43:06] 10Fundraising Tech - Chaos Crew, 10MediaWiki-extensions-CLDR, 10Language-Team (Language-2023-January-March), 10ci-test-error (WMF-deployed Build Failure): quibble-fundraising-cldr-REL1_39-php74-docker failure on CLDR master - https://phabricator.wikimedia.org/T328240 (10hashar) The job `quibble-fundraising... [13:02:47] (03PS1) 10Jgleeson: Use consistent names for the methods that turn our params into dLocal API request params. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891538 [13:54:54] hey damilare [13:55:14] I just noticed this change breaks your dlocal card tests over in donation interface https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/889860 [13:55:24] hi jgleeson how's it going? [13:55:35] ohh cgecking [13:59:19] (03CR) 10Jgleeson: Add error handling to backend SmashPig API calls (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889860 (https://phabricator.wikimedia.org/T324691) (owner: 10Damilare Adedoyin) [13:59:39] Dami I just added the tests that need updating on the ticket to make it easier [14:00:22] tnx for spotting that, I'm updating the tests now [14:01:08] np [14:01:13] I thought I'd broken something [14:01:28] but couldn't for the life of me work out where I'd added '300' [14:03:10] hmm that fix might need a smashpig tag and version bump in payments [14:03:58] which might be a bit of a pain [14:04:38] 10Fundraising Tech - Chaos Crew: Acoustic Import: Job Status Failed - https://phabricator.wikimedia.org/T330403 (10LMedley-WMF) [14:05:27] 10Fundraising Tech - Chaos Crew: Acoustic Import: Job Status Failed - https://phabricator.wikimedia.org/T330403 (10LMedley-WMF) p:05Triage→03High [14:05:34] hmm yh, we don't need to merge the DI patch till the bump is done. Why do you think it'd be a pain though? [14:06:49] I was thinking it might stop it passing on CI for you [14:09:35] ohh yh, there's that. It has to be done anyway [14:32:01] hiii fr-tech damilare jgleeson :) [14:32:56] hii AndyRussG [14:33:23] :) [14:35:12] damilare: so I'm just thinking through https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/889588 some more... I'm definitely still leaning towards preferring that the API methods be separated, as was the case in patch set 3, and also towards making the recurring charge do both the authorize and capture in a single step [14:35:27] hey AndyRussG [14:35:32] :) :) [14:36:25] damilare: I was thinking of putting my thoughts in another comment on Gerrit... does that sound right? or if you'd prefer to discuss elsewhere also fine ofc :) [14:36:27] AndyRussG: cool thanks, I'd move that out as I also agree it should be a single step [14:36:42] ah oki [14:37:14] gerrit is fine, just so I can be sure I've got it all covered incase there's any other recommendation [14:38:01] okii cool :) yeah also Gerrit might be a good place to note stuff also so that when ej egg returns it'll be easier for him to follow the discussion, or same for any of us sometime in the future [14:38:40] thx!!! [14:39:05] yep! [14:41:35] damilare: I'm curious why we'd use a 2-step process for collecting recurring payments [14:42:25] ^ yeah also happy to hear if there were further arguments for either of the possible approaches [14:42:54] i think one of the main benefit of the 2-step flow for standard card payments is it allows us to follow up on flagged payments that fall into the pending transaction flow [14:43:06] but the recurring charges will be called from civicrm [14:43:20] jgleeson damilare am I remembering correctly that at least Adyen, unlike dLocal, doesn't have an API call that can do both authorize and capture in a single call? [14:43:42] we authorize in the JS for Adyen I think Andy [14:43:53] jgleeson: I mean only for recurring [14:44:06] jgleeson: for the payments front-end, yes we should keep the 2-step process [14:44:19] so to be very clear, only for recurring charges after the first initial donation [14:44:21] jgleeson: I initially thought it was a 1-step process as well, but given ejegg|away's comment I figured it may be 2 step. And I also misunderstood Andy's comment as well. [14:44:33] ahh hehe sorry I was unclear :) [14:46:04] for the recurring charge job, which is what this back-end call would be for, I don't think we currently have any significant logic between the two steps on other processors? gonna check [14:46:47] I'm actually trying to debug through that for this spike task T324298 [14:46:48] T324298: Ensure DLocal recurring card payments can be charged via Civi SmashPig recurring charge job - https://phabricator.wikimedia.org/T324298 [14:47:33] oh cool! [14:48:18] I'm just looking at the code in smashpig and it looks like it can handle both flows [14:48:29] sorry, civicrm smashpig extension [14:48:48] hmm [14:49:20] gotta shovel more coal into the steam engine boiler to keep the train going [14:50:41] hmm i guess I can't see an obvious benefit to either approach, 1-step or 2-step [14:50:49] for recurring [14:51:20] damilare: did dlocal allow you to make a non-captured payment using a card_id [14:51:50] yep! it does [14:54:53] I'm not sure how we'd handle the non-pending-poke flows [14:55:07] https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/f73d04b10cc1b8602ac670965972a86cb7746c96/PaymentProviders/dlocal/CreatePaymentStatusNormalizer.php#L27 [14:55:24] if we get a pending result back from a recurring createPayment call it might be lost [14:56:06] although I'm not close enough to know if PENDING is possible for card_id payments [14:56:11] something to consider though [14:56:47] so far I've only seen AUTHORIZED and PAID in the response [14:57:01] we might be ok then [14:57:30] maybe we should log it in the event an unexpected status comes back [14:57:57] CANCELLED looks like it might be useful too [14:58:13] jgleeson: there's a flag parameter you send on the dlocal API call to tell it whether to capture right away or not [14:58:15] I'm not sure if we're using a similar response from other gateways to close down the recurring charge [14:58:22] yeah AndyRussG [14:58:24] capture [14:58:36] yep yep sorry wasn't sure if you'd seen it [14:58:50] yeah good question about whether that can ever return a PENDING status [14:58:57] we could ask Sebastian [15:09:23] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Email: Acoustic Import: Job Status Failed - https://phabricator.wikimedia.org/T330403 (10LMedley-WMF) p:05Triage→03High [15:17:02] damilare jgleeson what's the difference between recurring_smashpig_charge.yaml and recurring_queue_consume.yaml jobs? [15:17:53] it feels like the new dLocal flow is most similar to Adyen among our current processors [15:18:18] and for that reason, and also since Adyen's the most recent, it feels like that should be our primary reference for how to do stuff? what do you think? [15:22:12] yeah it does feel the same. [15:23:00] I know the recurring_queue_consume handles notifications related to subscriptions [15:31:09] AndyRussG: I'd rather make decision on what results in less code and more benefits. I see what you mean but using previous recent precedent is how we ended up with the implementations of previous too [15:31:15] the* [15:31:50] jgleeson: oki yes also good point [15:32:05] mabybe we could discuss it on a call to see if there are pros & cons to both approaches [15:32:24] I've gotta head out now [15:32:36] also, don't let this block anything damilare [15:32:42] I'm just thinking out loud! [15:33:16] sure, no p. [15:33:19] thanks [15:34:34] jgleeson: damilare: almost anytime also works for me... I was thinking of going to the Advancement salon for at least part of the time tho [15:35:07] https://wikitech.wikimedia.org/wiki/Fundraising/Data_and_flow/PSP_integrations/Adyen_Checkout#Recurring says, "Recurring Adyen donations are tokenized and are charged on our schedule by the SmashPig Civi extension's recurring payment charge jo" [15:35:16] (03PS23) 10Jgleeson: Handle submission for DLocal REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) [15:36:44] (03PS1) 10Damilare Adedoyin: Update Dlocal CardPaymentTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/891573 [15:36:56] (03CR) 10CI reject: [V: 04-1] Handle submission for DLocal REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [15:37:38] (03PS2) 10Damilare Adedoyin: Update Dlocal CardPaymentTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/891573 [15:39:33] (03CR) 10CI reject: [V: 04-1] Update Dlocal CardPaymentTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/891573 (owner: 10Damilare Adedoyin) [15:40:06] back later! [15:47:09] damilare: ok so the recurring_queue_consume doesn't actually charge recurring payments, but rather handles changes to subscriptions, including the creation of subscriptions, cancellation, etc [15:47:11] https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/fundraising/crm/+/refs/heads/master/drupal/sites/all/modules/queue2civicrm/recurring/RecurringQueueConsumer.php#278 [15:47:27] so rather it looks like it's the SmashPig job that's of interest here, no? [15:48:53] Yeah recurring queue consume is for PayPal recurring and monthly convert starts [15:49:17] Smashpig is the one that charges recurrings we have control over [15:51:58] yep it is AndyRussG [15:53:10] sorry I'm working on the smashpig version bump because of some changes I made that's breaking some tests in DI [15:54:36] oki thanks damilare cstone :) [15:56:39] reading the backscroll and sorry coming at this with being out a bunch of days but for the 1 vs 2 step, i feel like the stuff we'd fail the auth on is already handled the first time? and then we can just capture ones we have tokens of? (if it does work like how adyen is set up) [15:57:05] cstone: yes that sounds right, no worries and thx ofc :) [15:57:06] https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/fundraising/crm/+/refs/heads/master/drupal/sites/default/civicrm/extensions/org.wikimedia.smashpig/CRM/Core/Payment/SmashPig.php#57 [15:57:13] ^ looks like that's where the core logic is [15:58:07] so we just check for FinalStatus::PENDING_POKE and run approvePayemnt immediately if that's what we get [15:58:44] the only change I can see that we might want to make is to move add another isSuccessful() check outside the PENDING_POKE conditional [15:59:11] oh wait no, there's already one earlier in the method, oops [15:59:45] i dont think we changed that code much for the last couple of recurring implementations (at least I didn't touch it on what i did) [16:00:26] looks like the normal recurring charge method is indeed createPayment() [16:07:59] (03PS1) 10Damilare Adedoyin: Update Smash-pig to v0.8.3.18 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/891580 [16:09:25] (03Abandoned) 10Damilare Adedoyin: Update Smash-pig to v0.8.3.18 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/891580 (owner: 10Damilare Adedoyin) [16:11:52] (03PS1) 10Damilare Adedoyin: Update Smash-pig to v0.8.3.18 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/891581 [16:13:43] (03CR) 10CI reject: [V: 04-1] Update Smash-pig to v0.8.3.18 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/891581 (owner: 10Damilare Adedoyin) [16:25:34] (03PS3) 10Damilare Adedoyin: Update Smash-pig to v0.8.3.18 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/891573 [16:28:04] (03Abandoned) 10Damilare Adedoyin: Update Smash-pig to v0.8.3.18 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/891581 (owner: 10Damilare Adedoyin) [16:29:02] 10Fundraising-Backlog: Self service portal for recurring donor support - https://phabricator.wikimedia.org/T330415 (10EMartin) [16:31:07] 10Fundraising-Backlog, 10fr-donorservices: How can we enable upselling of existing recurring donation amount? - https://phabricator.wikimedia.org/T325317 (10EMartin) [16:38:31] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Parsoid, 10Parsoid-Read-Views, 10Parsoid-Rendering: Make CentralNotice extension compatible with Parsoid - https://phabricator.wikimedia.org/T272936 (10JMcLeod_WMF) [16:43:12] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Email: Acoustic Import: Job Status Failed - https://phabricator.wikimedia.org/T330403 (10KHaggard) Thank you @LMedley-WMF ! Also adding here the Civi FailMail subject line I saw this morning: "Silverpop emails - Upload files failed with code 1" [17:10:45] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ylavappa - https://phabricator.wikimedia.org/T329337 (10Dwisehaupt) SSL certificate renewed and sent via email. Password will be sent via SMS. [17:15:15] 10Fundraising-Backlog, 10fr-donorservices: How can we enable upselling of existing recurring donation amount? - https://phabricator.wikimedia.org/T325317 (10EMartin) Adding Mariana's/Fundraising's desired workflow here: {F36866871} [17:19:13] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sbaruchel - https://phabricator.wikimedia.org/T328378 (10Dwisehaupt) SSL certificate renewed and sent via email. Password sent via SMS. [19:05:58] (03CR) 10AndyRussG: "Heyy just noting down some thoughts so far, following discussions on IRC and elsewhere:" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889588 (https://phabricator.wikimedia.org/T324296) (owner: 10Damilare Adedoyin) [19:06:27] thanks AndyRussG [19:06:28] ^ hope that sort of makes sense and is helpful! [19:06:31] damilare: thank u :) [19:12:07] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jgleeson - https://phabricator.wikimedia.org/T329338 (10Dwisehaupt) SSL certificate renewed. Files placed in user homedir on frpm1002. [19:18:42] hmm [19:18:56] AndyRussG: do you feel like it's worth making the additional API call if we don't need to? [19:19:56] jgleeson: no [19:19:59] that's not what I'm saying [19:20:14] jgleeson: I'm saying the opposite? aaah sorry if it's not clear? [19:20:17] oh so we just make the authorize call [19:20:33] jgleeson: no we make a single call that does authorize and capture in one go [19:20:42] but we *name the method* differently in the Api class [19:21:05] so that would be a single authorize call with capture=true [19:21:19] sorry it's confusing because there's Api (the SmashPig class), API (the way we interact with dLocal) and API (a class's outward facing interface) [19:21:25] jgleeson: yes exactly [19:21:31] gotcha [19:21:43] yeah I also think that would be worth aiming for [19:21:50] and call the method that does that that does that makeRecurringPayment() [19:21:53] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Email: Acoustic Import: Job Status Failed - https://phabricator.wikimedia.org/T330403 (10LMedley-WMF) Greetings @Ejegg! I hope your day is going well! I kindly believe you've helped in the past with this error. May you have a quick moment to take a... [19:23:20] so the dLocal\Api class would have distinct methods, the existing authorizePayment(), and a new one, very similar to what existed in PatchSet3, possibly called makeRecurringPayment() [19:23:26] is that clearer? [19:23:46] hmm [19:23:57] I think that will make reading the code easier [19:24:21] and will also allow us to have cleaner logic with in the dLocal\Api class [19:24:41] I hadn't looked at the combined method stuff, I was more concerned about the 2-step capture process [19:24:47] but now that's got me curious [19:25:53] so on top of the card_id and the capture=true, is there other param difference between recurring and non-recurring card payments? [19:26:58] jgleeson: ah right yeah I think we're pretty clear on the 2-step process [19:27:16] not much, see mapParamsToApiAuthorizeRequestParams() and the last bullet point on my comment [19:27:38] gotta do a quick errand, apologies, I'll have IRC on my phone tho :) [19:27:39] ah that is one of the ones I changed earlier [19:27:50] there's no difference jgleeson just that we want to capture in a single step [19:28:11] so capture=true and card_id like you said [19:28:11] damilare: checkout https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/891538/ [19:28:26] we've got a mix of names for mapping/transforming stuff [19:29:42] oh hey I hadn't seen that one :) [19:29:48] I'll check it out in a bit! [19:30:01] sorry that was for damilare [19:30:05] I thought you'd left [19:30:07] ha [19:30:31] it might be useless to get that merged before adding the new breakout [19:30:39] useful ha [19:30:45] sorry slightly distracted [19:32:53] jgleeson: this function names are a bit confusing mapParamsToCaptureRequestParams... Capture there feels like a verb [19:33:23] maybe mapParamsCapturePaymentParams [19:33:36] sorry it might be just me also [19:33:41] I think it was originally the same I just removed API [19:33:54] that patch was getting rid of the new "get" prefixed one [19:34:07] I figured the API was a noise word [19:34:11] since it's in the API class [19:35:35] how about [19:36:13] https://phabricator.wikimedia.org/P44755 [19:36:39] the more I look at these mappers/translators the more I want to put them in their own class [19:37:20] +1 ^ [19:37:23] then we could do something like [19:37:23] mapParamsToCapturePaymentRequestParams [19:37:43] mapParamsToCapturePaymentRequestParams feels more appropriate to me [19:37:54] +1 to moving out of the API class [19:38:26] ok I'll update it now [19:38:36] let's make a ticket for moving the mapping stuff into another class [19:38:54] thanks, and the auth too [19:39:04] sure I'd make that ticket now [19:39:14] I like the idea of something like `$api->capturePayment(new CapturePaymentRequestParams($params))` maybe [19:41:09] encapsulation right, I think that's a good idea. [19:41:15] jgleeson: sorry im like way out of the loop here but those are broken down so much for testability? [19:42:07] yeah pretty much cstone and better encapsulation [19:42:23] although it would be different to what we usually do [19:43:49] i dont think there is a usually its just what we did last time [19:43:56] 10Fundraising-Backlog: Refactor Dlocal API class - https://phabricator.wikimedia.org/T330425 (10Damilare) [19:43:58] and i think its all been different which is hard for me when I want them all to match :P [19:44:23] yeah I feel ya [19:45:31] I like standardising although the current design does have some gaps. params mapping is one and we've typically just bundled it in wherever it looks the least ugly [19:45:31] idono if this would even make sense to put in a comment like at the top explaining the method behind the structuring? [19:46:24] return mapping too. we recently added the factory classes dlocalcreateyadayda::fromRawResponse()... but those also look misplaced to me now [19:48:05] (03PS2) 10Jgleeson: Use consistent names for the methods that turn our params into dLocal API request params. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891538 [19:48:39] damilare: I've made those mapper method names more explicit ^ [19:48:46] I just wanna run something by you [19:49:01] is this method specifically for card? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/891538/1/PaymentProviders/dlocal/Api.php#319 [19:49:13] the constant val made me think so [19:49:54] yh it is, only card payments have the token [19:50:01] awesome [19:50:42] (03CR) 10Damilare Adedoyin: [C: 03+2] Use consistent names for the methods that turn our params into dLocal API request params. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891538 (owner: 10Jgleeson) [19:51:18] ty damilare ! [19:51:26] Also jgleeson for the failing tests you mentioned earlier today: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/891573 [19:51:28] np [19:52:29] nice! [19:53:25] (03Merged) 10jenkins-bot: Use consistent names for the methods that turn our params into dLocal API request params. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891538 (owner: 10Jgleeson) [20:02:38] (03CR) 10Jgleeson: [C: 03+2] "LGTM! thanks Dami" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/891573 (owner: 10Damilare Adedoyin) [20:10:01] thank you ^^ [20:16:34] (03Merged) 10jenkins-bot: Update Smash-pig to v0.8.3.18 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/891573 (owner: 10Damilare Adedoyin) [20:39:44] (03PS6) 10Wfan: only show direct flow for dlical cc payment method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/874932 (https://phabricator.wikimedia.org/T324276) [20:39:52] (03PS7) 10Wfan: only show direct flow for dlical cc payment method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/874932 (https://phabricator.wikimedia.org/T324276) [20:44:00] (03CR) 10Cstone: [C: 03+2] Add dlocal india bank transfer recurring payment link [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/891327 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [20:44:02] (03CR) 10Jgleeson: [V: 03+2 C: 03+2] "LGTM" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/891327 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [20:54:14] (03PS5) 10Damilare Adedoyin: Implement backend for DLocal recurring card payments in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889588 (https://phabricator.wikimedia.org/T324296) [20:55:30] (03PS6) 10Damilare Adedoyin: Implement backend for DLocal recurring card payments in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889588 (https://phabricator.wikimedia.org/T324296) [21:01:36] (03PS7) 10Damilare Adedoyin: Implement backend for DLocal recurring card payments in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889588 (https://phabricator.wikimedia.org/T324296) [21:05:13] (03CR) 10Damilare Adedoyin: "Thanks AndyRussG for the notes. I've updated the changes as discussed." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889588 (https://phabricator.wikimedia.org/T324296) (owner: 10Damilare Adedoyin) [21:20:17] ug sorry I didn't check my calendar earlier - I understand I wasn't the only one who wasn't there though [21:20:43] (03PS1) 10Wfan: Payment provider for bank transfer dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891650 (https://phabricator.wikimedia.org/T328976) [21:23:57] FYI - I'm starting to try to get wmff phpunit up to 8 - I occassionally get into a bit of a version mismatch - this gets some of the way there - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/890136 [21:25:23] nice eileen [21:26:09] also thanks for the heads up about the webinar [21:26:45] jgleeson: the other thing is I think we can probably nerge the patch with the new activity type wfan created - it won't 'do anything' yet - but if we start getting it onto our systems it might create less confusion when trying to test the behaviour [21:33:17] yeah that sounds good to me eileen. I haven't had a chance to test it but I did watch most of the tech-talk recording [21:33:36] I've been consumed with dlocal of late [21:42:55] fr-tech, I just updated the Callback URL in the dlocal sandbox console to paymentstest2 just so I can perform a final end to end test on the redirect stuff before pushing it up for review. I won't need it for long! [21:44:30] thx for the heads-up jgleeson :) [21:58:00] hmm it looks like we can't listen for traffic at the same time on the fr-tech-dev box [21:59:31] wfan: I can see your sshed in. I'm guessing you've got the ssh tunnel active? [21:59:55] Yes [22:00:12] Let me exit it [22:00:30] wait a sec [22:00:37] Out now [22:00:49] sorry that was me [22:00:55] I didn't have the docker stack running [22:00:59] Lol [22:01:34] yeah it was failing to to connect to the internal port ha [22:01:38] helps if it's on [22:11:43] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for lschreibstein - https://phabricator.wikimedia.org/T329547 (10Dwisehaupt) SSL certificate renewed and sent via email. Password sent via SMS. [22:18:48] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jgleeson - https://phabricator.wikimedia.org/T329338 (10jgleeson) This is done! thanks [22:26:54] (03PS24) 10Jgleeson: Handle submission for DLocal REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) [22:29:05] (03CR) 10CI reject: [V: 04-1] Handle submission for DLocal REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [22:42:17] (03CR) 10Cstone: [C: 03+2] Payment provider for bank transfer dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891650 (https://phabricator.wikimedia.org/T328976) (owner: 10Wfan) [22:44:21] (03Merged) 10jenkins-bot: Payment provider for bank transfer dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891650 (https://phabricator.wikimedia.org/T328976) (owner: 10Wfan) [22:46:04] (03PS25) 10Jgleeson: Handle submission for DLocal REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) [22:48:52] fr-tech does someone have that cpf generator link handy [22:49:27] nevermind found it https://theonegenerator.com/generators/documents/cpf-generator/ [22:51:40] I have that bookmarked under my dlocal new integration folder ha [22:53:15] (03PS26) 10Jgleeson: Handle submission for DLocal cash REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) [22:54:28] i had it on the mac but not on linux [23:00:42] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, and 3 others: Handle submission for DLocal Cash REDIRECT methods in DonationInterface - https://phabricator.wikimedia.org/T324291 (10jgleeson) To test... [23:01:02] (03PS27) 10Jgleeson: Handle submission for DLocal cash REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) [23:03:50] (03PS8) 10Wfan: only show direct flow for dlocal cc payment method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/874932 (https://phabricator.wikimedia.org/T324276) [23:04:34] (03CR) 10Jgleeson: [C: 03+1] "As discussed, this is fine to merge before the cash redirect stuff." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/874932 (https://phabricator.wikimedia.org/T324276) (owner: 10Wfan) [23:07:44] (03CR) 10Cstone: [C: 03+2] "Looks good, see continue button for bt and donate button appears for cc" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/874932 (https://phabricator.wikimedia.org/T324276) (owner: 10Wfan) [23:08:04] Thanks Jack and Christine [23:08:13] ty! [23:08:20] thanks!! [23:09:39] (03Merged) 10jenkins-bot: only show direct flow for dlocal cc payment method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/874932 (https://phabricator.wikimedia.org/T324276) (owner: 10Wfan) [23:22:29] (03PS3) 10Wfan: Add bank transfer submethods that supported by dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/889188 (https://phabricator.wikimedia.org/T328976) [23:22:43] (03PS10) 10Cstone: WIP: Create IPN listener for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) [23:23:11] (03CR) 10CI reject: [V: 04-1] WIP: Create IPN listener for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [23:25:45] (03PS11) 10Cstone: WIP: Create IPN listener for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) [23:26:16] (03CR) 10CI reject: [V: 04-1] WIP: Create IPN listener for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [23:27:10] (03PS12) 10Cstone: WIP: Create IPN listener for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) [23:27:20] apparently the linter doesn't want more spaces before the closing ) [23:48:31] (03CR) 10Cstone: [C: 03+2] "Nice to see these outside of a test script!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/889188 (https://phabricator.wikimedia.org/T328976) (owner: 10Wfan) [23:48:59] thanks Christine ~ [23:50:13] (03Merged) 10jenkins-bot: Add bank transfer submethods that supported by dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/889188 (https://phabricator.wikimedia.org/T328976) (owner: 10Wfan) [23:53:32] thanks wfan !