[07:52:10] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: ipset_error 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [07:57:10] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [10:54:34] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Reverify payments.wikimedia.org for ApplePay (Production) - https://phabricator.wikimedia.org/T329723 (10jgleeson) a:03jgleeson [11:10:54] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Reverify payments.wikimedia.org for ApplePay (Production) - https://phabricator.wikimedia.org/T329723 (10jgleeson) This has been done. https://payments.wikimedia.org/ is now valid up to Feb 29, 2024. {F36874293} [11:18:45] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Investigate 'AstroPay response missing one or more required keys.' errors in the logs - https://phabricator.wikimedia.org/T330646 (10jgleeson) [12:12:25] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-dlocal, 10Recurring-Donations: Ensure DLocal recurring card payments can be charged via Civi SmashPig recurring charge job - https://phabricator.wikimedia.org/T324298 (10Damilare) Having set up the... [14:29:06] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Investigate 'AstroPay response missing one or more required keys.' errors in the logs - https://phabricator.wikimedia.org/T330646 (10jgleeson) Ok, this is a problem. According to the [[ https://phabricator.wikimedia.org/P44856 | logs ]], this started happ... [14:31:56] fr-tech I'm gonna move https://phabricator.wikimedia.org/T330646 on the chaos crew board to high-priority. It looks like we might be serving a fail page for some donors who successfully donated with dLocal. [14:32:48] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Investigate 'AstroPay response missing one or more required keys.' errors in the logs - https://phabricator.wikimedia.org/T330646 (10jgleeson) p:05Triage→03High [14:38:10] jgleeson: argh, they're doing that again? [14:38:22] wb ejegg ! [14:38:27] yep :( [14:38:27] hi jgleeson ! [14:38:44] I was hoping we would avoid that with the extra account :( [14:39:36] ejegg: didn't they fix it for IPNs? [14:39:55] I remember you sending an email last month about something related [14:41:33] jgleeson: they fixed it for the return URL after I sent that email [14:41:39] but I guess it broke again [14:41:41] ah [14:41:59] so yeah, we are showing fail pages to successful donors [14:44:18] ejegg: I'm just popping out to pick the kids up from school but will be back in about 45 minutes. Would you mind replying to your original email on this to dlocal lettimg them know it's broke again pls? it saves me trying to redescribe the issue and us losing time with me being afk. thanks in advance! [14:44:39] also, I just posted a message on #fundraising-donorrelations on slack [14:44:44] be back soon! [14:44:47] will do [14:44:57] ty! [15:39:18] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Email: Civi to Acoustic Export: Job Status Failed - https://phabricator.wikimedia.org/T330403 (10LMedley-WMF) 05Open→03Resolved a:03LMedley-WMF Greetings FR-Tech, Confirming that the contacts are importing correctly. Thank you. [15:58:17] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Investigate 'AstroPay response missing one or more required keys.' errors in the logs - https://phabricator.wikimedia.org/T330646 (10jgleeson) @Ejegg has emailed dLocal, and they are investigating the issue at their end. [16:06:42] /nick ejegg|afk [16:25:38] !log payments-wiki updated from c13b8d26 to 871c4e5c [16:25:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:54:52] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: GatewayChooser: No supported gateway for parameters - https://phabricator.wikimedia.org/T326666 (10Pcoombe) Thanks @AnnWF. I switched both to the non-fundraising page. Honestly I was a bit surprised AF wasn't already, and AX is a region of Finland where w... [17:02:58] (03PS1) 10Jgleeson: WIP: add test for new dLocal bank code staging helper [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/892500 (https://phabricator.wikimedia.org/T324291) [17:05:10] (03CR) 10CI reject: [V: 04-1] WIP: add test for new dLocal bank code staging helper [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/892500 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [17:25:39] (03PS28) 10Jgleeson: Handle submission for DLocal cash REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) [17:25:41] (03PS2) 10Jgleeson: WIP: add test for new dLocal bank code staging helper [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/892500 (https://phabricator.wikimedia.org/T324291) [17:27:23] (03CR) 10CI reject: [V: 04-1] WIP: add test for new dLocal bank code staging helper [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/892500 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [17:28:26] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Investigate 'AstroPay response missing one or more required keys.' errors in the logs - https://phabricator.wikimedia.org/T330646 (10MBeat33) [17:29:11] back later [18:29:07] (03PS1) 10Cstone: Removing the example fiscal number as it's not working for testing [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/892527 [18:29:34] (03PS2) 10Cstone: Removed the example fiscal number as it's not working for testing [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/892527 [18:40:01] (03PS3) 10Cstone: Add ReferenceData [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891930 (https://phabricator.wikimedia.org/T324293) [19:32:58] (03CR) 10Ejegg: "Could we delete the AstroPay version and have the AstroPay audit code just call this version in the dlocal namespace?" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891930 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [19:35:26] (03CR) 10Cstone: Add ReferenceData (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891930 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [19:46:50] (03CR) 10Ejegg: Add ReferenceData (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891930 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [19:47:50] ejegg: for that reference data do we basically duplicate it in DI and in smashpig? [19:51:49] cstone it would be nicer to be able to call the SmashPig functions from DI [19:52:07] so maybe we want a lookup function going the other way [19:52:44] though we would need a bit more context like the recurring flag in the case of upi [20:01:45] cstone: but yeah, till now we have basically duplicated it in DI by having the lookup from our code to their code depend on payment_submethods.yaml [20:02:32] yeah I guess I just kept forgetting about referencedata until i was like how does this ipn know what IR is [20:18:33] (03CR) 10Ejegg: "Just a few comments from a look over the code. Soon I'll try running through it too." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891328 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [20:58:54] (03PS1) 10Eileen: Replace watchdog with Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892554 (https://phabricator.wikimedia.org/T288585) [20:59:26] 10Fundraising-Backlog: Missing primary address fields in Search Kit - https://phabricator.wikimedia.org/T330700 (10LeanneS) [21:15:59] (03PS1) 10Eileen: Reformat code to civi-style (before actual change) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892557 (https://phabricator.wikimedia.org/T288585) [21:16:01] (03PS1) 10Eileen: Replace watchdog with Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892558 [21:16:03] (03PS1) 10Eileen: Reformat code, preliminary to code fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892559 (https://phabricator.wikimedia.org/T288585) [21:16:07] (03PS1) 10Eileen: Replace watchdog calls in exchange_rates_module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892560 (https://phabricator.wikimedia.org/T288585) [21:21:59] (03PS1) 10Eileen: Replace watchdog calls in FinanceInstrument helper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892562 (https://phabricator.wikimedia.org/T288585) [21:22:01] (03PS1) 10Eileen: Minor code quality fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892563 (https://phabricator.wikimedia.org/T288585) [22:54:07] oh dang, that 3dsecure patch needs another manual rebase [22:54:22] I'll try doing that if you don't mind jgleeson [23:00:54] sure thing ejegg thanks for that [23:03:31] (03PS4) 10Ejegg: Implement 3DSecure for DLocal cards [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/888077 (https://phabricator.wikimedia.org/T324302) (owner: 10Jgleeson) [23:03:46] (03CR) 10Ejegg: "PS4: rebase" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/888077 (https://phabricator.wikimedia.org/T324302) (owner: 10Jgleeson) [23:07:17] (03PS1) 10Jgleeson: Add dLocal callback_url and notification_url to config. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/892572 [23:07:28] cstone: ^ [23:07:43] I think XenoRyet said that pair programming counts as live review too [23:07:47] which makes sense [23:10:35] Indeed, I think that can be our new team norm. [23:11:22] i did see it work! [23:16:10] ejegg: if you're still happy with https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/888077/ I can +2 that and add the test as a follow on [23:21:31] (03CR) 10Cstone: [C: 03+2] "thanks!!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/892572 (owner: 10Jgleeson) [23:22:04] (03Merged) 10jenkins-bot: Add dLocal callback_url and notification_url to config. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/892572 (owner: 10Jgleeson) [23:22:36] (03CR) 10Jgleeson: [C: 03+2] "LGTM. thanks for the updates!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/888077 (https://phabricator.wikimedia.org/T324302) (owner: 10Jgleeson) [23:22:56] thanks for the review cstone! [23:23:09] (03Merged) 10jenkins-bot: Implement 3DSecure for DLocal cards [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/888077 (https://phabricator.wikimedia.org/T324302) (owner: 10Jgleeson) [23:36:55] (03CR) 10Jgleeson: "LGTM! thanks" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/892527 (owner: 10Cstone) [23:55:05] there's a small point release in MW 1.39 - I'll just pull that in to keep us up to date