[00:01:36] (03PS1) 10Ejegg: Merge branch 'REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/892577 [00:02:12] (03PS2) 10Ejegg: Merge branch 'REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/892577 [00:02:23] let's see if that fixes the flapping core tests [00:03:02] ack right, automatic submodule updates [00:05:19] (03CR) 10CI reject: [V: 04-1] Merge branch 'REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/892577 (owner: 10Ejegg) [00:07:24] (03PS3) 10Ejegg: Merge branch 'REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/892577 [00:07:55] boo, nope, test still broken [00:08:02] ok, I'mma just remove it on our branch [00:10:36] (03PS1) 10Ejegg: Delete failing test on deprecated function [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/892578 (https://phabricator.wikimedia.org/T328612) [00:11:16] (03CR) 10Ejegg: [C: 03+2] Delete failing test on deprecated function [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/892578 (https://phabricator.wikimedia.org/T328612) (owner: 10Ejegg) [00:12:13] (03CR) 10CI reject: [V: 04-1] Merge branch 'REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/892577 (owner: 10Ejegg) [00:12:35] (03PS4) 10Ejegg: Merge branch 'REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/892577 [00:13:43] ooh, that gets us phpunit 9.5 [00:13:57] i think that's needed for PHP 8 [00:14:52] well, forms looks fine locally [00:15:15] and I don't see anything worrying in the diff: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/892577/-1..4 [00:16:12] mostly i18n and a teeny bit of oojs changes (that we're not using) [00:16:44] (03CR) 10Ejegg: [C: 03+2] "Merging code already reviewed upstream" [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/892577 (owner: 10Ejegg) [00:17:28] k, that probably does merit its own deploy though [00:20:22] (03Merged) 10jenkins-bot: Delete failing test on deprecated function [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/892578 (https://phabricator.wikimedia.org/T328612) (owner: 10Ejegg) [00:20:50] 10Fundraising-Backlog, 10Patch-For-Review: MWTimestampTest::testHumanTimestamp is failing in mediawiki/core tests on fundraising/REL1_39 branch - https://phabricator.wikimedia.org/T328612 (10Ejegg) [00:21:38] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10Patch-For-Review: MWTimestampTest::testHumanTimestamp is failing in mediawiki/core tests on fundraising/REL1_39 branch - https://phabricator.wikimedia.org/T328612 (10Ejegg) [00:21:58] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10Patch-For-Review: MWTimestampTest::testHumanTimestamp is failing in mediawiki/core tests on fundraising/REL1_39 branch - https://phabricator.wikimedia.org/T328612 (10Ejegg) 05Open→03Resolved a:03Ejegg [00:25:52] (03Merged) 10jenkins-bot: Merge branch 'REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/892577 (owner: 10Ejegg) [00:37:16] PROBLEM - check_puppetrun on frdev1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[aide-common] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1002&service=check_puppetrun [00:42:16] RECOVERY - check_puppetrun on frdev1002 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1002&service=check_puppetrun [01:09:58] (03PS1) 10Eileen: Update monolog extension boilerplate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892588 [01:10:00] (03PS1) 10Eileen: Convert WMFSave to use Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892589 (https://phabricator.wikimedia.org/T288585) [01:10:37] (03PS2) 10Eileen: Convert WMFSave to use Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892589 (https://phabricator.wikimedia.org/T288585) [01:11:23] ejegg|food: when you get back I just want to check in with you on https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/892589 & specifically the link in the comments re debug levels (since I'm converting them I want to be sure I'm using the right levels) [01:20:36] actually I also want to talk about ripping some code out rather than fixing it up... [01:23:08] (03PS3) 10Eileen: Convert WMFSave to use Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892589 (https://phabricator.wikimedia.org/T288585) [01:23:25] (03CR) 10CI reject: [V: 04-1] Convert WMFSave to use Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892589 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [01:28:37] (03PS4) 10Eileen: Convert WMFSave to use Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892589 (https://phabricator.wikimedia.org/T288585) [01:36:26] (03PS1) 10Eileen: Update OptInQueueConsumer to use Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892591 (https://phabricator.wikimedia.org/T288585) [02:34:52] (03PS1) 10Eileen: Reformat code prior to any actual changes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892592 (https://phabricator.wikimedia.org/T288585) [02:34:54] (03PS1) 10Eileen: Replace watchdog calls in refund_batch_process [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892593 (https://phabricator.wikimedia.org/T288585) [02:55:07] (03PS1) 10Eileen: Remove, rather than upgrade, script to restore addresses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892594 (https://phabricator.wikimedia.org/T288585) [02:55:09] (03PS1) 10Eileen: Fix some of the watchdogs in thank_you to Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892595 (https://phabricator.wikimedia.org/T288585) [02:59:07] hi eileen, sorry, I had to help out with some other stuff after |food [02:59:10] looking now [02:59:27] no worries - it must be late for you now - I figured you were gone [03:00:04] ejegg what I found is there are so many I can't think about the level for each one anyway - but I think so code can just be ripped out [03:00:45] ejegg: for example https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/892594 [03:01:53] yep, if we've fixed the code that led to the bollixed data, no need to keep the script to fix it [03:02:34] cool - so I'm also thinking death to exchange_rates_backfill & wmf_civicrm_recalculate_contributions might be possible? [03:03:52] hmm, the backfill script seems potentially generally useful [03:04:04] dang - it's full of old code [03:04:20] ok, let me see [03:04:41] so I guess the new command to fetch updated rates for today would be an API action [03:04:53] whereever I see `civicrm_api_classapi` I think ug [03:04:55] that could potentially take any past date as well [03:05:13] and people could do their own backfilling with that [03:05:59] ejegg: I did do the update on it - but you can see from my code comments... https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/892560 [03:06:25] oh hah, yeah, we certainly haven't been using it [03:06:39] so from a `watchdog` pov that is kinda 'done' - but then it calls `wmf_civicrm_recalculate_contributions` which is a dog [03:06:56] looking [03:08:21] I like the example [03:08:25] ``` [03:08:25] 'examples' => [ [03:08:25] 'drush recalculate-contributions 2014-06-20 2014-09-30', [03:08:25] ``` [03:08:46] eileen: oh yeah, that also uses our custom wmf_contribution_extra table [03:09:00] so not especially helpful for general distribution [03:09:17] sure, let's omit those two functions from the Civi version [03:09:22] I think we would substantially re-write for that purpose [03:09:47] I'll put up patches to remove (there are quite a few up there but the 'chain' is not really depending on the rest of the chain [03:10:48] would be nice to kill those original_xxx fields and just put the real currency in the contribution table, assuming we have a more modern place to put the USD converted totals in the financial trxn tables [03:12:42] oh i see, the bug in exchange_rates_backfill just isn't hit when you send in a $start value [03:13:05] we did run that once! [03:15:02] (03PS2) 10Eileen: Reformat code, preliminary to code fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892559 (https://phabricator.wikimedia.org/T288585) [03:15:04] (03PS1) 10Eileen: Remove old exchange_rates_backfill function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892596 (https://phabricator.wikimedia.org/T288585) [03:15:23] ejegg: well ^^ removes it [03:19:40] (03PS1) 10Eileen: Remove recalculate_contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892597 (https://phabricator.wikimedia.org/T288585) [03:19:58] & there goes recalculate_contributions [03:22:58] (03PS2) 10Eileen: Replace watchdog calls in FinanceInstrument helper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892562 (https://phabricator.wikimedia.org/T288585) [03:23:00] (03PS2) 10Eileen: Minor code quality fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892563 (https://phabricator.wikimedia.org/T288585) [03:23:02] (03PS2) 10Eileen: Update monolog extension boilerplate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892588 [03:23:04] (03PS5) 10Eileen: Convert WMFSave to use Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892589 (https://phabricator.wikimedia.org/T288585) [03:23:06] (03PS2) 10Eileen: Update OptInQueueConsumer to use Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892591 (https://phabricator.wikimedia.org/T288585) [03:23:08] (03PS2) 10Eileen: Reformat code prior to any actual changes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892592 (https://phabricator.wikimedia.org/T288585) [03:23:10] (03PS2) 10Eileen: Replace watchdog calls in refund_batch_process [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892593 (https://phabricator.wikimedia.org/T288585) [03:23:12] (03PS2) 10Eileen: Remove, rather than upgrade, script to restore addresses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892594 (https://phabricator.wikimedia.org/T288585) [03:23:14] (03PS2) 10Eileen: Fix some of the watchdogs in thank_you to Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892595 (https://phabricator.wikimedia.org/T288585) [03:23:16] (03PS1) 10Eileen: Replace watchdog with info, report message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892598 (https://phabricator.wikimedia.org/T288585) [03:23:53] hmmm many PS2s [03:28:33] AndyRussG: that's a rebase - removed something from the chain [03:28:34] For the Final Fantasy XI LAN party [03:28:58] eileen: yes hehe that's what I imagined [03:29:15] but now I can never rebase again cos I'll ruin all your PS2 Lan parties [03:29:49] lol, I better get CRing those then [03:30:40] (03CR) 10Ejegg: [C: 03+2] Replace watchdog with Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892554 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:30:42] although the real goal here is PS(r)3 - https://docs.civicrm.org/dev/en/latest/framework/logging/ [03:31:06] hehe, nice [03:34:13] (03PS1) 10Eileen: Watchdog -> Civi::log in thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892599 (https://phabricator.wikimedia.org/T288585) [03:34:42] man this is getting to be a real slog - in thank_you.module there are sooo many & a lot of them require some tweaking to the paramters [03:34:52] (03CR) 10Ejegg: [C: 03+2] Reformat code to civi-style (before actual change) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892557 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:37:10] (03CR) 10Ejegg: [C: 03+2] Replace watchdog with Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892558 (owner: 10Eileen) [03:39:04] (03CR) 10Ejegg: [C: 03+2] Replace watchdog calls in FinanceInstrument helper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892562 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:39:34] (03CR) 10Ejegg: [C: 03+2] Minor code quality fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892563 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:42:31] eileen so that _monolog_civix_civicrm_entityTypes can be deleted because the core extension mechanism now handles the entityType.php files? [03:42:52] it's the mixin mechanism = but yeah it's handling it now [03:43:01] ah nice [03:43:21] ah right i see that in info.xml [03:43:57] (03CR) 10Ejegg: [C: 03+2] "Slimming!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892588 (owner: 10Eileen) [03:44:14] (03PS1) 10Eileen: Replace watchdog with Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892600 (https://phabricator.wikimedia.org/T288585) [03:44:45] (03Merged) 10jenkins-bot: Replace watchdog with Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892554 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:45:40] (03CR) 10Ejegg: [C: 03+2] "Agreed that non-supported contact type is not just ->info" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892589 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:48:57] (03Merged) 10jenkins-bot: Reformat code to civi-style (before actual change) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892557 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:48:59] (03CR) 10Ejegg: [C: 03+2] Update OptInQueueConsumer to use Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892591 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:51:10] (03Merged) 10jenkins-bot: Replace watchdog with Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892558 (owner: 10Eileen) [03:53:02] (03CR) 10Ejegg: [C: 03+2] Reformat code prior to any actual changes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892592 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:54:04] (03CR) 10Ejegg: [C: 03+2] Replace watchdog calls in refund_batch_process [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892593 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:54:07] (03Merged) 10jenkins-bot: Replace watchdog calls in FinanceInstrument helper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892562 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:54:09] (03Merged) 10jenkins-bot: Minor code quality fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892563 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:55:35] (03CR) 10Ejegg: [C: 03+2] Remove, rather than upgrade, script to restore addresses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892594 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:57:39] (03PS1) 10Eileen: More watchdog to Civi::log in thankyou module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892601 (https://phabricator.wikimedia.org/T288585) [03:58:13] (03Merged) 10jenkins-bot: Update monolog extension boilerplate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892588 (owner: 10Eileen) [03:58:15] (03CR) 10Ejegg: [C: 03+2] Fix some of the watchdogs in thank_you to Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892595 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:59:11] (03CR) 10Ejegg: [C: 03+2] Replace watchdog with info, report message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892598 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:59:44] (03Merged) 10jenkins-bot: Convert WMFSave to use Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892589 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [04:00:16] ok, I need to head to bed. I'll look at the rest in the morning [04:02:22] (03Merged) 10jenkins-bot: Update OptInQueueConsumer to use Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892591 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [04:04:37] when you go to run consume-queues but accidentally run clear queues [04:06:49] (03PS16) 10Cstone: Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) [04:07:25] (03Merged) 10jenkins-bot: Reformat code prior to any actual changes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892592 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [04:08:31] (03Merged) 10jenkins-bot: Replace watchdog calls in refund_batch_process [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892593 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [04:08:53] farewell watchdog [04:09:40] (03Merged) 10jenkins-bot: Remove, rather than upgrade, script to restore addresses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892594 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [04:11:27] cstone: it's still watching you [04:11:43] forever watching [04:12:19] (03Merged) 10jenkins-bot: Fix some of the watchdogs in thank_you to Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892595 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [04:13:20] (03Merged) 10jenkins-bot: Replace watchdog with info, report message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892598 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [04:13:41] (03CR) 10Cstone: "This might be how it's supposed to work but when I was testing the IPNs with rejecting a payment I saw this in the logs:" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [04:17:31] 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Handle Refund/Chargeback IPNS for Dlocal - https://phabricator.wikimedia.org/T330723 (10Cstone) [04:19:05] 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Handle recurring IPNs for Dlocal - https://phabricator.wikimedia.org/T330724 (10Cstone) [04:20:44] 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Handle Refund/Chargeback IPNS for Dlocal - https://phabricator.wikimedia.org/T330723 (10Cstone) [04:26:28] (03PS4) 10Cstone: Add ReferenceData [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891930 (https://phabricator.wikimedia.org/T324293) [04:26:30] (03PS17) 10Cstone: Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) [04:36:04] (03PS1) 10Eileen: Watchdog to Civi::log in thank_you module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892603 [04:36:06] (03PS1) 10Eileen: Fix recurring queue consumer to call Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892604 (https://phabricator.wikimedia.org/T288585) [04:36:08] (03PS1) 10Eileen: More watchdog to Civi:log changes in RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892605 (https://phabricator.wikimedia.org/T288585) [07:31:38] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/892849 (owner: 10L10n-bot) [08:01:57] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/892849 (owner: 10L10n-bot) [12:55:09] (03CR) 10Damilare Adedoyin: [C: 03+1] "LGTM, +1'ing because of the comment inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [12:59:35] (03PS3) 10Jgleeson: Update status list in PaymentStatusNormalizer [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889804 (https://phabricator.wikimedia.org/T324291) [13:00:01] thanks damilare [13:00:16] np [13:01:21] I'm a bit confused by the comment [13:01:41] do you mean the callback_url? [13:02:20] yhh that's the one [13:02:36] check out https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/892572 [13:02:43] we can set that now in config [13:02:44] on Adyen var_map it was called the redirect_url and there's a staging helper class for it too [13:02:46] in smashpig [13:04:44] oh hmm, why don't we set it in the request params from DI [13:05:14] so if there's any additional query param we can attach dynamically, for example wmf_token [13:08:11] we were discussing this last night and it felt like smashpig was the right place to put it [13:08:29] as it's dlocal api config I guess [13:08:43] i don't think we're sending over any query strings [13:08:51] from payments [13:09:50] having it in config means we can manage the two-account setup that we're planning to use [13:10:46] I just realised you added returl_url https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/889605 [13:10:57] we hadn't seen that [13:11:55] yh I did, was thinking wfan would be needing it for one of her patches. [13:13:31] her patch is merged [13:14:32] yea [13:14:48] I should take it out then? [13:16:58] I'm curious now about this token and why we're only using it with some processors [13:19:23] I can't see wenjun using the return_url in here code [13:19:54] so maybe we should take it out for now although I am curious whether this wmf_token thing might be causing the dead session issue [13:20:14] it looks like it's an edit token [13:20:26] potentially use to prevent CSRF [13:20:48] used* [13:20:58] yes it's the edit token from the session, not sure how it's used [13:21:14] just felt dlocal shouldn't be an exception [13:21:32] I'd take it out now [13:21:58] it looks like it's only used in adyen for applepay [13:22:20] I don't see it in ingenico, braintree or astropay [13:22:56] ah it's also in paypal_ec [13:23:09] the old code [13:23:45] I think it's used beyond applepay for adyen [13:24:09] Ideal and 3ds callback url have the wwf_token appended to the string [13:24:30] yeah i wonder if it's a query string specific thing [13:24:41] and it's been left out of astropay because it's a POST requst [13:24:44] request [13:25:02] it's not been used consistently it seems [13:25:06] probably [13:27:37] which has got me curious about the dead session stuff [13:27:45] although if that was the issue it should never work right [13:28:06] were you able to put through a successful payment using https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/884899 ? [13:28:19] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 9575 9500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 11 keys, up 33 days 12 hours - memory use is 7.57M (peak 106.04M, 0.17% of max, fragmentation 1.89%), connected_slaves is 3, donations is 46, jobs is 0, jobs-adyen is 54, jobs-paypal is 145, payments-antifraud is 2, payments-init is 5, pending is 0, refund is 0, unsubscribe is 0 https://icinga.wik [13:28:19] g/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [13:29:48] yes, had the session dead issue some times [13:31:16] so for astropay, we don't send a return url from donation interface [13:32:04] so we probably don't need that [13:32:17] although we can manage it at the smashpig layer [13:34:48] sure np, also maybe we didn't have that option with astropay [13:34:59] (03CR) 10Damilare Adedoyin: [C: 03+2] Handle submission for DLocal cash REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [13:35:18] (03CR) 10Jgleeson: [C: 04-1] Handle submission for DLocal cash REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [13:36:21] uhh did you give yourself a -1 [13:36:49] or is gerrit flipping? [13:36:50] thanks damilare, sorry, I wanted to dig into the comment Christine added last night. I wanted to try and replicate it [13:37:19] oh ok, I thought that was marked as resolved [13:38:19] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 10019 9500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 12 keys, up 33 days 12 hours - memory use is 7.99M (peak 106.04M, 0.18% of max, fragmentation 1.79%), connected_slaves is 3, donations is 6, jobs is 0, jobs-adyen is 0, jobs-paypal is 130, payments-antifraud is 3, payments-init is 7, pending is 1, refund is 0, unsubscribe is 1 https://icinga.wiki [13:38:19] /cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [13:38:40] I think it might be due to this patch not being merged yet https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/889804 but I haven't had a chance to test it. I'm now really curious about this wmf_token thing just to see if it could explain why the session is being reset [13:38:58] that's an one to +2 I think [13:40:52] I didn't mark cstone's comment resolved. maybe she did [13:41:05] but I don't think it should showing that error [13:41:18] unless it's related to that other status patch and she was on master [13:41:27] that also makes me think I need to update smashpig with this patch [13:41:30] yh most likely [13:43:19] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 9816 9500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 9 keys, up 33 days 12 hours - memory use is 7.73M (peak 106.04M, 0.17% of max, fragmentation 1.87%), connected_slaves is 3, donations is 61, jobs is 0, jobs-adyen is 74, jobs-paypal is 129, payments-antifraud is 0, payments-init is 0, pending is 0, refund is 0, unsubscribe is 1 https://icinga.wiki [13:43:19] /cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [13:44:11] it seems as though the CreatePaymentStatusNormalizer and PaymentStatusNormalizer are similar [13:44:30] can we have the CreatePaymentNormalizer extend the PaymentStatusNormalizer [13:44:44] check the cmt message [13:44:56] we've got a ticket to refactor all four of 'em [13:45:12] although our volunteer is working on that, i hope! [13:45:42] ok [13:45:43] nice! [13:46:49] (03CR) 10Damilare Adedoyin: [C: 03+2] Update status list in PaymentStatusNormalizer [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889804 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [13:47:13] thanks damilare [13:47:22] (03Merged) 10jenkins-bot: Update status list in PaymentStatusNormalizer [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889804 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [13:47:40] np [13:48:19] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 10359 9500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 12 keys, up 33 days 12 hours - memory use is 8.11M (peak 106.04M, 0.18% of max, fragmentation 1.84%), connected_slaves is 3, donations is 20, jobs is 0, jobs-adyen is 20, jobs-paypal is 124, payments-antifraud is 3, payments-init is 8, pending is 0, refund is 0, unsubscribe is 1 https://icinga.wi [13:48:19] rg/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [13:48:33] lots of recurring today! [13:53:19] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 10177 9500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 33 days 12 hours - memory use is 8.03M (peak 106.04M, 0.17% of max, fragmentation 1.81%), connected_slaves is 3, donations is 9, jobs is 0, jobs-adyen is 0, jobs-paypal is 125, payments-antifraud is 2, payments-init is 0, pending is 0, refund is 0, unsubscribe is 1 https://icinga.wiki [13:53:19] /cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [13:55:33] (03CR) 10Jgleeson: "Thanks for the review Dami!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [13:58:19] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 10730 9500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 12 keys, up 33 days 12 hours - memory use is 8.15M (peak 106.04M, 0.18% of max, fragmentation 1.83%), connected_slaves is 3, donations is 54, jobs is 0, jobs-adyen is 53, jobs-paypal is 99, payments-antifraud is 2, payments-init is 7, pending is 0, refund is 0, unsubscribe is 1 https://icinga.wik [13:58:19] g/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [13:58:32] (03CR) 10Jgleeson: "thanks for the review! I left a response inline about the unknown status error" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [14:03:19] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 10542 9500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 11 keys, up 33 days 12 hours - memory use is 8.25M (peak 106.04M, 0.18% of max, fragmentation 1.80%), connected_slaves is 3, donations is 50, jobs is 0, jobs-adyen is 48, jobs-paypal is 129, payments-antifraud is 12, payments-init is 3, pending is 0, refund is 0, unsubscribe is 0 https://icinga.w [14:03:19] org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [14:08:19] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 11106 9500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 33 days 12 hours - memory use is 8.46M (peak 106.04M, 0.18% of max, fragmentation 1.77%), connected_slaves is 3, donations is 19, jobs is 0, jobs-adyen is 0, jobs-paypal is 104, payments-antifraud is 12, payments-init is 15, pending is 0, refund is 0, unsubscribe is 0 https://icinga.w [14:08:19] org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [14:13:19] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 10842 9500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 12 keys, up 33 days 12 hours - memory use is 8.29M (peak 106.04M, 0.18% of max, fragmentation 1.80%), connected_slaves is 3, donations is 66, jobs is 0, jobs-adyen is 101, jobs-paypal is 117, payments-antifraud is 18, payments-init is 1, pending is 1, refund is 0, unsubscribe is 0 https://icinga. [14:13:19] .org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [14:18:19] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 11385 9500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 12 keys, up 33 days 12 hours - memory use is 8.52M (peak 106.04M, 0.18% of max, fragmentation 1.79%), connected_slaves is 3, donations is 25, jobs is 0, jobs-adyen is 48, jobs-paypal is 114, payments-antifraud is 8, payments-init is 23, pending is 1, refund is 0, unsubscribe is 0 https://icinga.w [14:18:19] org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [14:23:19] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 11144 9500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 33 days 12 hours - memory use is 8.26M (peak 106.04M, 0.18% of max, fragmentation 1.80%), connected_slaves is 3, donations is 0, jobs is 0, jobs-adyen is 0, jobs-paypal is 49, payments-antifraud is 13, payments-init is 1, pending is 1, refund is 0, unsubscribe is 0 https://icinga.wiki [14:23:19] /cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [14:25:01] ACKNOWLEDGEMENT - check_redis on frqueue1003 is CRITICAL: CRITICAL: recurring is 11144 9500 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 33 days 12 hours - memory use is 8.26M (peak 106.04M, 0.18% of max, fragmentation 1.80%), connected_slaves is 3, donations is 0, jobs is 0, jobs-adyen is 0, jobs-paypal is 49, payments-antifraud is 13, payments-init is 1, pending is 1, refund is 0, unsubscribe is 0 Jeff_Green [14:25:01] queue bloat https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [14:29:16] (03PS29) 10Jgleeson: Handle submission for DLocal cash REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) [14:29:54] damilare: that patch now pulls in the latest on smashpig ^ [14:30:06] (03PS30) 10Jgleeson: Handle submission for DLocal cash REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) [14:30:25] which should fix the issue cstone mentioned [14:31:58] ok checking [14:57:48] (03CR) 10Damilare Adedoyin: [C: 03+1] "+1'ing to allow for cstone's feedback" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [15:13:17] RECOVERY - check_redis on frqueue1003 is OK: OK: REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 12 keys, up 33 days 13 hours - memory use is 6.36M (peak 106.04M, 0.16% of max, fragmentation 2.02%), connected_slaves is 3, donations is 58, jobs is 0, jobs-adyen is 79, jobs-paypal is 9, payments-antifraud is 11, payments-init is 0, pending is 1, recurring is 7699, refund is 0, unsubscribe is 1 https://icinga.wikimedia.org/cgi-bin [15:13:17] xtinfo.cgi?type=2&host=frqueue1003&service=check_redis [15:20:26] thanks damilare|brb! [16:02:38] fr-tech I'm going to deploy the MW core point upgrade to payments-wiki (without deploying any DonationInterface changes) [16:02:52] thanks ejegg [16:05:43] Jeff_Green: I'm unable to update payments-wiki on frpm1002 - when I run f_c_u in debug mode I'm seeing a lot of exec_git stderr: fatal: path '.gitmodules' does not exist in [16:05:56] I'm looking back over the actual patches [16:06:10] ejegg: do you remember why we don't use the wmf_token CSRF stuff with Astropay? [16:06:11] ejegg: huh, ok, looking [16:06:26] jgleeson: no, I don't remember [16:06:38] do you see any issues with us doing that? [16:07:16] should be fine as far as I know [16:12:49] ejegg: I wanna try and get out all the dlocal stuff in pending deployment today [16:12:52] Jeff_Green: it appears to be looking for .gitmodules files inside each submodule directory [16:13:25] I'll wait until you finish with the point release but it would be good to get your visual +2 on everything going out [16:13:27] jgleeson: I like that goal, how can I help? Any patch in particular to review first? [16:13:47] ejegg: yep, I see what you mean. I'm trying it in vb to see if it behaves the same way there, or maybe the checkout on frpm1002 got messed up somehow [16:14:48] Jeff_Green: ohhhh, those are a red herring [16:15:03] oh? [16:15:04] After I type the 3 letter confirmation code the real error comes up [16:15:18] exec_git stderr: error: Your local changes to the following files would be overwritten by checkout: [16:15:21] exec_git stderr: resources/lib/ooui/AUTHORS.txt [16:15:23] exec_git stderr: Please commit your changes or stash them before you switch branches. [16:15:26] exec_git stderr: Aborting [16:15:32] ahhh [16:16:01] that sounds like cruft left behind by the script due to some git corner case [16:16:09] yep, ok, git status shows a bunch of modified files [16:16:44] yeah [16:16:47] ejegg: there's a bunch of stuff merged. this one is being reviewed https://phabricator.wikimedia.org/T324291 but I'd love to get your feedback also in case there's anything out of place. It's been a disjointed task with lots of stopping and starting so it's possible stuff got missed along the way [16:17:41] ejegg: I thought I had built some logic into the script to handle this scenario... [16:17:58] looking jgleeson [16:22:27] ejegg: ok I ran a "git reset --hard" and "git clean -fd" so it should have cleared the logjam [16:22:43] I grabbed a copy of the pre-state tree so I can try to figure out what happened [16:22:51] thanks Jeff_Green [16:23:22] np [16:24:28] Jeff_Green: well I tried again and it's back in the same state [16:24:37] i just forgot to use the -d flag [16:24:42] interesting [16:25:05] you're just trying to update it to branch head right? [16:25:39] ejegg: ^^ [16:28:38] yep [16:28:53] it was locked so I had to use the =head argument [16:55:47] ejegg: I've just added some test instructions for putting through cash payments locally which includes updating the callback_url to come back to localhost. it looks like we can do that via the callback_url even thought we couldn't do it via the dlocal console! https://phabricator.wikimedia.org/T324291#8642573 [16:57:03] jgleeson: trying to test your updated patch but the dlocal redirect is timing out for me have you seen this before? [16:57:41] or maybe i lost my return url actually [16:57:48] hmmz not that I can remember cstone. I just put a couple through when writing that guide [16:57:51] and they seems ok [16:57:55] ok lemme try some things [16:58:07] cstone: I added the callback_url to config-private [16:58:13] so if you pull on that it should be there [16:58:35] I left the notification_url blank because i figure that couldn't be localhost and it might confuse folks if it was [16:59:23] !log payments-wiki upgraded from 871c4e5c to b9ea2130 [16:59:27] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:59:30] i also saw a bunch of dead session things last night but just moved to incognito window cause i wanted to compare your queue message to the ipn one [16:59:40] I've had two today [16:59:47] I'm gonna debug it now again [17:00:10] it's a bit easier with the localhost callback_url [17:00:52] ok cool see the rejected behaving now [17:00:54] I see* [17:01:43] (03CR) 10Cstone: [C: 03+1] "Yep rejected is behaving for me with that missing patch" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [17:02:23] awesome [17:07:50] (03CR) 10Damilare Adedoyin: [C: 03+2] Handle submission for DLocal cash REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [17:08:11] thanks damilare|brb and cstone ! [17:08:19] thanks jgleeson ! [17:09:12] I'm gonna grab some food. When I get back it would be great to start getting all this stuff out together. That unless ejegg picks up on anything that needs additional work. back soon! [17:09:24] np jgleeson|food [17:12:02] (03Merged) 10jenkins-bot: Handle submission for DLocal cash REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) (owner: 10Jgleeson) [17:34:54] 10Fundraising-Backlog, 10FR-dlocal: Add 'wmf_token' CSRF protection to dLocal forms - https://phabricator.wikimedia.org/T330778 (10jgleeson) [17:38:56] damilare ^^^ [17:39:24] cool tnx! [17:39:44] right let's start pushing some of this out shall we? [17:40:02] woohoo [17:42:08] I cut a new tag of smashpig earlier today. v0.8.4 has the lastest from today [17:42:33] so I'll start the patch to bring that into payments [17:42:54] ejegg: I see you fixed the timestamp unit test bug! thanks for that [17:47:30] jgleeson: heh, yeah, if it was just testing a deprecated function we might as well delete the test on our branch [17:48:16] so far the patches look fine [17:49:24] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/893032 [18:02:44] (03CR) 10Jgleeson: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/893032 (owner: 10Jgleeson) [18:03:28] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/893032 (owner: 10Jgleeson) [18:08:17] (03PS1) 10Jgleeson: Update DonationInterface, vendor and composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/893035 [18:09:52] fr-tech, the deploy is ready. that last patch pulls in the updated donation-interface, vendor submodule and composer changes related to the dlocal work. [18:10:36] I've updated https://wikitech.wikimedia.org/wiki/Fundraising/Cluster/Deployments to now refer to the fundraising/REL1_39 branch [18:16:36] thanks jgleeson, seems I may have missed this conversations but why are we using the REL1_39 branch [18:18:01] (03CR) 10Jgleeson: [C: 03+2] Update DonationInterface, vendor and composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/893035 (owner: 10Jgleeson) [18:18:44] damilare: ejegg|afk recently upgraded payments to fundraising/REL1_39 [18:19:21] I've forgotten a few times already ha [18:19:31] ohh ok is that the mediawiki upgrade [18:19:40] yep! that's it [18:19:57] we also upgrade the branch for mediawiki/vendor to match [18:20:14] you can see that here https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/892623 [18:24:14] cool tnx [18:24:54] np! [18:25:02] cstone: can I run something by you [18:25:21] I'm looking at the changes here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/888280/ [18:25:40] which would shortly be pushed out with the prepped deployment [18:25:52] however I think we might break things [18:26:29] (03Merged) 10jenkins-bot: Update DonationInterface, vendor and composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/893035 (owner: 10Jgleeson) [18:31:29] ejegg|afk: already deployed that and set things up I think but also yes we should check [18:31:31] jgleeson: [18:31:33] ^ [18:31:55] or maybe he just set things up [18:32:32] oh nice [18:34:56] ok yeah he copied over the dlocal into a new astropay folder on the 16th but we should also test after deploying to make sure its behaving [18:35:40] so I don't think the DlocalListener mentioned in https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/888280/4/config/dlocal/main.yaml#12 is merged yet [18:36:19] but I guess we expected that so it's not too much of a problem [18:36:22] yeah thats fine [18:36:32] the old one is called astropay listener [18:37:09] ok I feel better about that then [18:41:53] fr-tech has anyone found a way to test an old style astropay payment on live? [18:42:20] I guess I could just try my card [18:42:21] jgleeson: what's the impediment? would a MX location be helpful? [18:42:34] I also have a MX debit card in MXN currency [18:42:55] heheh and many Oxxos within walking distance [18:44:44] No impediment as such AndyRussG. I just wanted to test the current Astropay forms after the deployment. That would be great if you could use a real MX-based card just to confirm things work as expected post the deployment if that's ok! [18:46:32] i think elliott has a colombian card he has used before too [18:48:11] https://payments.wikimedia.org/index.php?title=Special:AstroPayGateway&appeal=JimmyQuote&country=MX¤cy=MXN&payment_method=cc&recurring=0&uselang=en-gb&amount=40&opt_in=0&utm_medium=spontaneous&utm_campaign=spontaneous&utm_source=fr-redir.default%7Edefault%7Edefault%7Edefault%7Econtrol.cc&utm_key=vw_1920%7Evh_975%7EotherAmt_0%7EvalidateError_1%7Etime_18 [18:48:24] that's an astropay form for $40 MXN [18:48:29] ~£1.81 [18:49:06] I'll try that too but if I get declined due to the country paranoia by the card it would be great is you could also try pls AndyRussG [18:49:19] ok let's send it out! [18:49:47] jgleeson: ok thanks! so I should try now, or after you send stuff out? [18:52:59] AndyRussG: the astropay logs are a bit of a mess due to to the ongoing bug in https://phabricator.wikimedia.org/T330646 so I'd say let's hold out until we push the new code out. [18:53:21] jgleeson: oki got it, thanks so much! [18:53:39] fr-tech, if anyone else wants to follow along, I'm watching the logs on frlog1002 using: [18:53:41] frlog1002:/var/log/remote$ tail -f payments-astropay payments.error [18:55:58] ok that has been deployed! [18:57:08] AndyRussG: there's a good chance you will get redirected to a fail page sadly due to the ongoing bug [18:57:17] bug we should be able to confirm the success of your trxn in the logs [18:58:56] ok thx much trying now [19:01:02] I'm not seeing any failmails [19:02:16] just trying now, after having changed the amount to 21 MXN instead of 40 [19:03:19] AndyRussG: it looks like it worked! [19:03:24] although I see the following [19:03:26] jgleeson: I got an error page though [19:03:28] moving to priv chan [19:25:21] fr-tech I've moved all the tickets we pushed out to done on the sprint. I'm gonna have a break before our next call. back later [19:26:02] 10Fundraising-Backlog, 10MediaWiki-extensions-Other, 10Documentation, 10Quality-and-Test-Engineering-Team (QTE) (Test engineering): [FundraisingTranslateWorkflow] Create https://www.mediawiki.org/wiki/Extension:FundraisingTranslateWorkflow - https://phabricator.wikimedia.org/T167996 (10TAdeleye_WMF) [19:27:34] Fr-tech: The school hasn't called yet, but the snow is coming down pretty good again. Might have to bounce out at any moment to get the kids home. If I disappear, that's what happened. [19:28:54] XenoRyet: have fun, hope the bouncing out involves snowpeople and snow forts [19:29:39] Heh, unfortunately it doesn't look that deep. [19:30:27] awww [19:30:53] hmmm maybe tiny snowpeople? [19:33:29] yeah im very glad i was in vancouver last weekend theyve gotten like 6+ inches twice now [20:05:30] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet) [20:05:32] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10FR-dlocal: Add error handling to backend SmashPig API calls - https://phabricator.wikimedia.org/T324691 (10XenoRyet) 05Open→03Resolved [20:06:06] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Implement cancelPayment for DLocal - https://phabricator.wikimedia.org/T324727 (10XenoRyet) 05Open→03Resolved [20:06:30] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet) [20:06:33] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Add Idempotency headers to DLocal API calls - https://phabricator.wikimedia.org/T326772 (10XenoRyet) 05Open→03Resolved [20:06:59] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10FR-dlocal: Separate astropay (old dlocal) config from dlocal config - https://phabricator.wikimedia.org/T328701 (10XenoRyet) 05Open→03Resolved [20:08:00] 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10FR-dlocal, and 2 others: Add config to determine which DLocal payment methods use DIRECT or REDIRECT integration - https://phabricator.wikimedia.org/T324276 (10XenoRyet) 05Open→03Resolved [20:08:02] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet) [20:08:10] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Investigate 'AstroPay response missing one or more required keys.' errors in the logs - https://phabricator.wikimedia.org/T330646 (10jgleeson) It looks like donors are still getting the thank you emails. [20:08:12] 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.40-notes (1.40.0-wmf.25; 2023-02-27): Handle submission for DLocal Bank Transfer REDIRECT methods in DonationInterface - https://phabricator.wikimedia.org/T328976 (10XenoRyet)... [20:08:15] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet) [20:08:33] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet) [20:08:39] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, and 3 others: Handle card submission in DLocal in DonationInterface - https://phabricator.wikimedia.org/T324290 (10XenoRyet) 05Open→03Resolved [20:09:01] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet) [20:09:05] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal, 10Recurring-Donations: Implement backend for DLocal recurring card payments in SmashPig - https://phabricator.wikimedia.org/T324296 (10XenoRyet) 05Open→03Resolved [20:09:23] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, and 4 others: Handle submission for DLocal Cash REDIRECT methods in DonationInterface - https://phabricator.wikimedia.org/T324291 (10XenoRyet) [20:09:40] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, and 4 others: Handle submission for DLocal Cash REDIRECT methods in DonationInterface - https://phabricator.wikimedia.org/T324291 (10XenoRyet) 05Open... [20:09:42] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet) [20:10:04] 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10FR-Smashpig, and 2 others: Implement 3DSecure for DLocal cards - https://phabricator.wikimedia.org/T324302 (10XenoRyet) 05Open→03Resolved [20:10:07] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet) [20:10:31] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10FR-dlocal: Investigate potential temporary code solution for receiving old and new data formats from dlocal - https://phabricator.wikimedia.org/T329289 (10XenoRyet) 05Open→03Resolved [20:19:22] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Reverify payments.wikimedia.org for ApplePay (Production) - https://phabricator.wikimedia.org/T329723 (10XenoRyet) 05Open→03Resolved [20:19:42] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Revalidate the paymentstest*.wmcloud.org ApplePay dev Merchant Domains - https://phabricator.wikimedia.org/T328700 (10XenoRyet) 05Open→03Resolved [20:20:24] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Dedupe query under certain rules no longer generating queries - https://phabricator.wikimedia.org/T326605 (10XenoRyet) 05Open→03Resolved [21:18:13] Params [21:18:16] oops [21:22:01] 10Fundraising-Backlog, 10fr-donorservices: Civi not keeping the mailing address attached to the active recurring donation after merging - https://phabricator.wikimedia.org/T330231 (10Eileenmcnaughton) @shust I looked a little into this & the issue is largely non-technical. When we implemented the dedupe handli... [21:22:05] 10Fundraising-Backlog: Refactor Dlocal API class - https://phabricator.wikimedia.org/T330425 (10jgleeson) Discussion from IRC: ` 19:36 the more I look at these mappers/translators the more I want to put them in their own class 19:37 +1 ^ 19:37 then we could do something like 19:... [21:24:16] 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Handle Refund/Chargeback IPNS for Dlocal - https://phabricator.wikimedia.org/T330723 (10Cstone) a:05Cstone→03None [21:31:11] 10Fundraising-Backlog, 10FR-India, 10FR-dlocal, 10Recurring-Donations: Support India Network Tokenization (recurring credit cards) for DLocal - https://phabricator.wikimedia.org/T324304 (10AKanji-WMF) Have determined we can't enable recurring on credit cards in India [21:34:30] 10Fundraising Sprint E 2023, 10Fundraising-Backlog, 10FR-dlocal: Add customer text hint for India UPI recurring that we only charge monthly with ondemand method - https://phabricator.wikimedia.org/T330530 (10XenoRyet) [21:34:33] 10Fundraising Sprint E 2023, 10Fundraising-Backlog: Refactor Dlocal API class - https://phabricator.wikimedia.org/T330425 (10XenoRyet) [21:34:35] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint E 2023, 10Fundraising-Backlog, 10FR-dlocal: Investigate why new dLocal REDIRECT payments are falling into the "dead session" category - https://phabricator.wikimedia.org/T330308 (10XenoRyet) [21:34:39] 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint E 2023, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-PayPal-ExpressCheckout: Update Pending Transaction Resolver to handle PayPal - https://phabricator.wikimedia.org/T324642 (10XenoRyet) [21:34:41] 10Fundraising Sprint E 2023, 10Fundraising-Backlog, 10FR-dlocal: Refactor the current dLocal StatusNormalizers. - https://phabricator.wikimedia.org/T329838 (10XenoRyet) [21:34:43] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint E 2023, 10Fundraising-Backlog, 10FR-dlocal: Enable DLocal on production - https://phabricator.wikimedia.org/T324501 (10XenoRyet) [21:34:46] 10Fundraising Sprint E 2023, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-India, and 2 others: Support DLocal recurring UPI payments in Civi SmashPig recurring charge job - https://phabricator.wikimedia.org/T324301 (10XenoRyet) [21:34:48] 10Fundraising Sprint E 2023, 10Fundraising-Backlog, 10FR-India, 10FR-dlocal, and 2 others: Support DLocal recurring UPI payments in DonationInterface - https://phabricator.wikimedia.org/T324300 (10XenoRyet) [21:34:53] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint E 2023, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Ensure DLocal recurring card payments can be charged via Civi SmashPig recurring charge job - https://phabricator.wikimedia.org/T324298 (10XenoRyet) [21:34:55] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint E 2023, 10Fundraising-Backlog, 10FR-India, and 4 others: Implement backend for DLocal recurring UPI payments in SmashPig - https://phabricator.wikimedia.org/T324299 (10XenoRyet) [21:34:57] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint E 2023, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Support DLocal recurring cards in DonationInterface - https://phabricator.wikimedia.org/T324297 (10XenoRyet) [21:35:07] 10Fundraising Sprint E 2023, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Implement one-time UPI / DIRECT payments for DLocal in DonationInterface - https://phabricator.wikimedia.org/T324295 (10XenoRyet) [21:35:11] 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint E 2023, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Update DLocal createPayment for UPI / DIRECT method - https://phabricator.wikimedia.org/T324294 (10XenoRyet) [21:35:15] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Bee Wheel, 10Fundraising Sprint Cheese String Theory, and 49 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10XenoRyet) [21:35:19] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint E 2023, and 9 others: Creating New Matching Gift Import - https://phabricator.wikimedia.org/T303986 (10XenoRyet) [21:35:23] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint E 2023, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Swap all our process logging to Civi::log('wmf') from watchdog() - https://phabricator.wikimedia.org/T288585 (10XenoRyet) [21:35:27] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint E 2023, and 4 others: Handle IPNs from DLocal payins - https://phabricator.wikimedia.org/T324293 (10XenoRyet) [22:10:25] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-dlocal: Plan dLocal testing rollout - https://phabricator.wikimedia.org/T330801 (10jgleeson) [22:22:31] 10Fundraising-Backlog, 10fr-donorservices: Civi not keeping the mailing address attached to the active recurring donation after merging - https://phabricator.wikimedia.org/T330231 (10SHust) @Eileenmcnaughton Correct, but the actual problem is that Civi isn’t keeping the latest donor's address for recurring don... [22:39:14] 10Fundraising-Backlog, 10fr-email-preference-center: Self service portal for recurring donor support - https://phabricator.wikimedia.org/T330415 (10AKanji-WMF) [22:42:45] Fr-tech I'm going to miss tech talk fighting a headache right now, I might show up halfway through if I can beat it [22:50:13] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Try creating a new activity_type_id for Thank yous & see if the UI is still fine - if so switch - https://phabricator.wikimedia.org/T327963 (10jgleeson) a:03jgleeson [22:56:51] hope you feel better soon cstone :) [22:57:03] really sorry to hear that [22:58:53] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/893070 [23:01:43] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/893070 (owner: 10Eileen) [23:02:33] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/893070 (owner: 10Eileen) [23:09:42] (03PS4) 10Ejegg: Some test cleanups to support updating phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/890136 (owner: 10Eileen) [23:09:46] (03CR) 10Ejegg: [C: 03+2] Some test cleanups to support updating phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/890136 (owner: 10Eileen) [23:20:01] (03PS1) 10Eileen: Composer update, remove finediff [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/893077 [23:22:39] (03PS2) 10Ejegg: Composer update, remove finediff [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/893077 (owner: 10Eileen) [23:22:47] (03CR) 10Ejegg: [C: 03+2] Composer update, remove finediff [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/893077 (owner: 10Eileen) [23:24:08] (03Merged) 10jenkins-bot: Some test cleanups to support updating phpunit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/890136 (owner: 10Eileen) [23:32:20] (03PS1) 10Eileen: Composer updates, remove finediff [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/893079 [23:32:32] (03CR) 10Eileen: [C: 03+2] Composer updates, remove finediff [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/893079 (owner: 10Eileen) [23:37:07] (03Merged) 10jenkins-bot: Composer update, remove finediff [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/893077 (owner: 10Eileen) [23:45:36] !log civicrm upgraded from ffc16d2d to d199694e [23:45:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:46:01] (03Merged) 10jenkins-bot: Composer updates, remove finediff [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/893079 (owner: 10Eileen) [23:53:34] (03PS9) 10Eileen: Update phpunit/phpunit to 8 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/890055 [23:58:14] and back after swapdeath