[07:00:22] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/894277 (owner: 10L10n-bot) [07:12:16] (03PS3) 10AndyRussG: dLocal: Add response data for recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) [07:13:44] (03CR) 10AndyRussG: dLocal: Add response data for recurring (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [07:14:05] (03CR) 10CI reject: [V: 04-1] dLocal: Add response data for recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [07:29:42] (03PS4) 10AndyRussG: dLocal: Add response data for recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) [10:56:04] (03PS5) 10Jgleeson: dLocal: Add response data for recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [11:17:11] (03CR) 10Jgleeson: "Thanks for adding these!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894131 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [11:30:58] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Ensure DLocal recurring card payments can be charged via Civi SmashPig recurring charge job - https://phabricator.wikimedia.org/T324298... [12:11:59] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add fiscal_number to Civi Smashpig extension parameter mapping for Dlocal - https://phabricator.wikimedia.org/T331288 (10Damilare) [12:13:03] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add fiscal_number to Civi Smashpig extension parameter mapping for Dlocal - https://phabricator.wikimedia.org/T331288 (10Damilare) [12:27:00] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Ensure DLocal recurring card payments can be charged via Civi SmashPig recurring charge job - https://phabricator.wikimedia.org/T324298... [12:28:35] (03CR) 10Jgleeson: [C: 03+1] "Thanks, Andy! I tested this and can see the new fields are being added to the queue message as expected. I had a quick look over the queue" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [12:30:14] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-dlocal: Refactor the current dLocal StatusNormalizers. - https://phabricator.wikimedia.org/T329838 (10Damilare) a:03Damilare [12:36:34] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-dlocal: Refactor the current dLocal StatusNormalizers. - https://phabricator.wikimedia.org/T329838 (10Damilare) Hi @SuvamManna, I'd have to complete this task as it's an impediment for some other tasks and the team has a dea... [12:41:43] (03CR) 10Jgleeson: [C: 03+1] dLocal: Add response data for recurring (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [13:25:17] (03CR) 10Jgleeson: [C: 03+2] "LGTM! Tested a pix payment after changes and it worked as expected." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893800 (owner: 10Ejegg) [13:27:02] (03Merged) 10jenkins-bot: Format payment_submethods.yaml and fix Pix case [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893800 (owner: 10Ejegg) [13:54:45] (03PS3) 10Jgleeson: India recurring di configs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/890364 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [14:31:48] (03PS6) 10Jgleeson: Add bank transfer for india recurring subscription request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891328 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [14:42:54] (03CR) 10Ejegg: Add bank transfer for india recurring subscription request (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891328 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [14:58:38] (03CR) 10Ejegg: [C: 03+1] "Looks pretty good to me too! I agree with jgleeson about the comment and moving that placeholder generator." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [15:04:22] 10Wikimedia-Fundraising-Banners, 10MediaWiki-extensions-CentralNotice: Find and remove unneeded sitenotice rules from local CSS - https://phabricator.wikimedia.org/T247244 (10Pcoombe) Wonderful, thank you @matmarex! [15:34:59] (03CR) 10Ejegg: Add ReferenceData (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891930 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [15:38:27] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-India, and 2 others: Support DLocal recurring UPI payments in Civi SmashPig recurring charge job - https://phabricator.wikimedia.org/T324301 (10jgleeson) a:03jgleeson [15:41:22] (03CR) 10Ejegg: "The jobs-dlocal queue seems not to be used, but maybe we do want to use it to combine pending table data with the IPN info? That would mea" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [15:49:30] (03CR) 10Jgleeson: [C: 03+1] dLocal: Add response data for recurring (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [15:55:59] fr-tech, how do folks feel about throwing out all non-dlocal and non-civicrm tickets this sprint to give us a better shot closing out the dlocal delivery? I feel like the UPI flow introduces a considerable amount of complexity on top of the existing in flux dLocal work and focusing on that and the one or two other dLocal tickets would give us the best shot at hitting tuesday? [15:57:48] ejegg: that would impact your Paypal PTR ticket. I'd also throw out a civicrm ticket I picked up after discussing it with Eileen [15:59:14] we've got three 4-pointers in blacklog and doing. there's probably anothe two tickets that are likely 4-pointers also in doing that don't have points [16:00:34] I think we're gonna have to add a new ticket for the CiviCRM bit to compliment AndyRussG's recurring patch [16:01:24] it's a lot for one week with review on top [16:02:27] heyy fr-tech! thx so much for the review jgleeson and ejegg ;) and yeah agreed about the new ticket and focusing the sprint jgleeson :) [16:02:41] hey AndyRussG ! [16:02:59] :) [16:08:00] AndyRussG fr-tech: one other option is that if we think the India UPI stuff is still too much to do this sprint by tomorrow's midsprint check-in, we could ask for that to be dropped and sound out just letting the stakeholders run tests with non-UPI India, Mexico and Brazil dLocal payment methods. [16:08:44] hmmm [16:09:00] anilk ^ ? [16:09:39] (03PS1) 10Ejegg: Add card type warning for recurring Brazil donors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/894692 (https://phabricator.wikimedia.org/T324297) [16:10:19] jgleeson: I think they won't want to do India without UPI [16:10:57] I'd be happy to focus on just getting that merged for now, though [16:11:04] ejegg: do we support it with astropay currently? [16:11:22] jgleeson: yep, just one-time donations, through a full redirect [16:12:36] I was wondering if we could as a worst case scenario get parity with existing astropay in India but then still roll out all the other dLocal stuff that is done [16:12:38] AndyRussG: I added a follow-on patch for an up-front warning about Brazil recurring card types. Still no handling for the case where we try to save a card and get no card_id back though [16:13:07] jgleeson: ah, we do have one-time UPI in dlocal ready, don't we? [16:13:22] I'm not sure ejegg. I haven't tested the UPI stuff much [16:13:41] ejegg coool thx for that :) [16:14:21] I did some coreview with damilare today on Wenjun's patch and it seemed like a pretty complicated flow [16:26:52] (03CR) 10Damilare Adedoyin: [C: 03+1] "Looks like the payment failed because we may need some additional API access privilege from Dlocal for Wallet transactions on the Staging " [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891328 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [16:30:25] ejegg: I think this might be the one-time UPI ticket https://phabricator.wikimedia.org/T324294 [16:32:04] jgleeson: thanks! [16:32:29] I guess we should update that to reflect that we're going to start with the REDIRECT flavor [16:32:36] 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Update DLocal createPayment for UPI / DIRECT method - https://phabricator.wikimedia.org/T324294 (10jgleeson) Hi @Wfan Is this ticket being worked on as par... [16:32:42] ha. check that comment [16:33:12] heh, yep [16:34:26] (03PS1) 10Ejegg: Save fiscal_number and use for SmashPig recurring [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894693 (https://phabricator.wikimedia.org/T324298) [16:35:18] damilare: I just noticed you had that ticket assigned to you ^^^ I hope I didn't just duplicate anything you were working on [16:36:01] 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Update DLocal createPayment for UPI / REDIRECT method - https://phabricator.wikimedia.org/T324294 (10jgleeson) [16:36:07] ohh I created another task for that ejegg [16:36:18] but no I haven't started working on that [16:36:31] 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Update DLocal createPayment for UPI / REDIRECT method - https://phabricator.wikimedia.org/T324294 (10jgleeson) I've updated the the title for this to switch... [16:36:52] ah thanks, I'll re-associate that patch [16:37:00] here's the ticket: T331288 [16:37:00] T331288: Add fiscal_number to Civi Smashpig extension parameter mapping for Dlocal - https://phabricator.wikimedia.org/T331288 [16:37:02] and attach the new ticket to the epic [16:37:20] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add fiscal_number to Civi Smashpig extension parameter mapping for Dlocal - https://phabricator.wikimedia.org/T331288 (10Ejegg) [16:37:24] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10Ejegg) [16:37:42] (03PS2) 10Ejegg: Save fiscal_number and use for SmashPig recurring [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894693 (https://phabricator.wikimedia.org/T331288) [16:38:32] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Add fiscal_number to Civi Smashpig extension parameter mapping for Dlocal - https://phabricator.wikimedia.org/T331288 (10Ejegg) p:05Triage→03Medium a:03Ejegg [16:40:59] ejegg: should we split that patch up? even though they deal with the same thing the review and test process will be in different parts of the stack [16:41:20] the import addition is a pretty easy +2 with Andy's patch [16:41:33] the recurring extension feels trickier [16:42:13] and would likely get +2ed quicker with test instructions [16:42:36] I always forget the setup steps needed to get the recurring charge extension to work [16:43:35] I can test the recurring part [16:44:02] or help with instructions if others want to [16:44:23] ^ instructions sound great! [16:44:31] sure cstone if you'd like. it would be great to have those somewhere [16:44:39] thanks! [16:44:40] tnx cstone [16:45:00] thanks all. I'm first just going to smoke test the patch as is and see if it works [16:45:42] so the full test will at least need AndyRussG's in-review DI patch to get the fiscal_number on to the queue [16:46:13] right [16:46:47] ok, I seem to have that on the queue locally, now running the consumer [16:46:47] I was gonna suggest a depends-on but then thought it could be merged without [16:48:11] ah okay I was thinking hack it on but nice if Andy's patch gets it on the queue [16:48:45] side note: seeing some "wmf_civicrm: No credit card submethod given" warnings - it'll be nice to map the card type back to the payment_submethod for the queue message if we can [16:49:11] cstone: I'm gonna try and close out that test patch for the IPN stuff. it took way longer than I'd expected to see the raw headers in a format I could build a mock response from when testing. [16:49:25] oh yeah sorry jgleeson I should have had better notes about the headers [16:49:29] cause I went through the same thing [16:49:35] also that getallheaders() method doesn't work with phpunit [16:49:41] boo [16:49:43] I think it needs superglobals present [16:49:48] so I needed to figure that out [16:50:30] what a funny name, super globals [16:52:32] (03CR) 10CI reject: [V: 04-1] Save fiscal_number and use for SmashPig recurring [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894693 (https://phabricator.wikimedia.org/T331288) (owner: 10Ejegg) [16:54:53] (03PS5) 10Cstone: Add ReferenceData [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891930 (https://phabricator.wikimedia.org/T324293) [16:55:00] ok, tests need updates. Will split out [16:55:33] (03CR) 10Cstone: Add ReferenceData (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891930 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [16:55:39] adyen failmail fr-tech [16:55:56] looks like timeouts [16:56:08] thats the i- spelled right dont duplicate stuff right? [16:56:13] jgleeson looks like we need to quiet down the failmail on the idempotency response 'this is already done' [16:56:29] that word hah [16:56:37] yep yep cstone [16:56:52] so I think we want to treat this like a successful response [16:57:18] oh is it that [16:57:50] huh [16:57:53] I saw this [16:57:59] 2023-03-06T16:55:21+00:00 [WARNING] cURL transaction to https://7816c1e8e6da0afe-WikimediaFoundation-checkout-live.adyenpayments.com/checkout/v67/payments failed: (28) Operation timed out after 30001 milliseconds with 0 bytes received. cURL verbose logging: * Trying 135.84.148.130:443... [16:58:08] Request returned (409) CONFLICT: {"status":409,"errorCode":"704","message":"request already processed or in progress","errorType":"validation"} [16:58:29] but then I also see a bunch of idempotency failures too [16:59:12] (my spell checker thinks idempotency isn't a word) [16:59:15] Hmm, so I guess we want to just silently drop a response that has no new info and just says "we're working on it" [16:59:44] but I thought at some point the extra request would get back the successful response [16:59:55] ah [17:00:02] so the first request is timing out [17:00:33] and then out retries are getting the idempotency response [17:00:37] our* [17:00:50] huh, so idempotency doesn't quite work for us if we don't eventually get the response we need to proceed [17:01:36] and that particular terse response isn't it [17:01:52] (03PS6) 10Cstone: Add ReferenceData [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891930 (https://phabricator.wikimedia.org/T324293) [17:01:54] (03PS20) 10Cstone: Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) [17:02:10] so when we get an "in process" response should we just wait a few seconds before retrying? [17:02:36] Might merit an email to Asyen [17:02:40] *Adyen [17:02:59] ejegg: it looks like adyen was timing out for about 10 minutes [17:03:02] i just made an adyen test donation that looked fine from the donors end [17:03:37] we just got another failure cstone [17:05:01] in the console theres some volume so i dont think everything is timing out based on the number of failmails [17:05:18] yeah it seems like a select few [17:05:38] JP and SK [17:06:11] Acquirer Error (NO_RESPONSE_FROM_ACM) [17:06:18] it might be JCB lemme look at another [17:06:59] yeah looks like JCB was/is having issues [17:07:04] ah [17:07:10] i see one that erroed then 3 minutes later was sucessful [17:07:13] 174036245.1 [17:07:55] I guess we could give it a bit more time to fix itself before needing to email 'em [17:08:44] did i make a ticket that we werent getting that error out, or just look into why we werent getting that error out hmm [17:09:01] oh i just meant we could email 'em about the way to handle the terse idempotency response [17:10:13] cstone I couldn't find it when i searched for adyen idempotency [17:10:21] maybe it's got different words [17:11:11] I'm trying to imagine the donor flow in this scenario. They try to donate and it times out / throws the idempotency exception which I think shows an error on payment forms? Then later on, Adyen confirm the successful trxn via IPN? is that right ejegg cstone ? [17:12:07] ejegg: I was referring to emailing them about the timeouts [17:12:18] or the JCB-specific outage [17:12:59] got dinner and homework duties. back later [17:15:15] yeah i dont know where in the flow the response of the card issuer itself happens [17:15:39] ejegg: I was talking about how we have a like a very specific error in the console but our failmail never sees it [17:15:57] i had seen it before once at least [17:19:38] sorry cstone, i don't exactly follow - you mean the js console in the donor's browser? [17:20:01] ahh sorry no the error that makes it time out [17:20:24] is in adyens console like Acquirer Error (NO_RESPONSE_FROM_ACM) [17:20:40] but we dont see that we see the timeout then follow on idempotency [17:20:53] ah I see [17:21:42] ok, so even if we increased our own timeout wait time, we might not get anything back from adyen? [17:22:20] yeah im not sure there [17:22:34] just would be helpful for us to get that error into the failmail too [17:23:22] i think this same Error state (the status of these in the adyen console) happened when amex broke in novemeber too [17:25:55] yeah it was the same style of failmail then too 11/19 [17:27:28] ok, I'll make a ticket to figure out the right response here [17:30:34] (03PS6) 10AndyRussG: dLocal: Add response data for recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) [17:31:13] 10Fundraising-Backlog, 10FR-Adyen: Handle issuer timeouts via Adyen - https://phabricator.wikimedia.org/T331317 (10Ejegg) [17:33:50] (03PS7) 10AndyRussG: dLocal: Add response data for recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) [17:34:26] 10Fundraising-Backlog, 10FR-Adyen: Better handle terse Adyen idempotency result - https://phabricator.wikimedia.org/T331319 (10Ejegg) [17:53:38] (03CR) 10AndyRussG: "Hi, thanks so much! Please see inline notes. Also, regarding the moving PlaceholderFiscalNumber to gateway_common, I'll do that in a separ" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [17:57:22] 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Update DLocal createPayment for UPI / REDIRECT method - https://phabricator.wikimedia.org/T324294 (10AnnWF) UPI direct as UD is been blocked since we do not... [17:57:34] 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Update DLocal createPayment for UPI / DIRECT method - https://phabricator.wikimedia.org/T324294 (10AnnWF) [18:02:38] (03PS1) 10Damilare Adedoyin: Refactor the current dLocal StatusNormalizers. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894706 (https://phabricator.wikimedia.org/T329838) [18:03:09] (03CR) 10CI reject: [V: 04-1] Refactor the current dLocal StatusNormalizers. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894706 (https://phabricator.wikimedia.org/T329838) (owner: 10Damilare Adedoyin) [18:03:59] (03PS2) 10Damilare Adedoyin: Refactor the current dLocal StatusNormalizers. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894706 (https://phabricator.wikimedia.org/T329838) [18:36:06] (03PS3) 10Damilare Adedoyin: WIP: Refactor Dlocal API class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894053 (https://phabricator.wikimedia.org/T330425) (owner: 10Jgleeson) [18:49:30] hmm, lots of 'no submethod' noise in the tests with the updated logging [18:49:36] we should fix those [18:55:35] (03PS3) 10Ejegg: Save fiscal_number to recurring invoice id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894693 (https://phabricator.wikimedia.org/T331288) [19:00:42] huh, lots more crm test failures locally [19:05:57] (03PS21) 10Cstone: Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) [19:06:20] (03CR) 10CI reject: [V: 04-1] Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [19:06:53] hmm [19:08:19] (03PS22) 10Cstone: Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) [19:08:44] (03CR) 10CI reject: [V: 04-1] Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [19:09:03] (03CR) 10Jgleeson: dLocal: Add response data for recurring (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [19:09:51] heheh can you ever have too much hackery? [19:10:12] the more hackery the merrier? [19:10:45] I think hackery should be a giant strawberry-chocolate cupcake [19:10:47] just sayin' [19:10:52] lol [19:10:55] :) [19:11:38] damilare|brb: now THAT is a refactor! [19:12:14] I just glanced over it but wow. nice work [19:15:25] (03CR) 10Cstone: dLocal: Add response data for recurring (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [19:16:41] even invoice_id feels wrong cstone [19:16:59] yep [19:17:01] when this is a financial id [19:17:05] it was a hack to begin with [19:17:14] for how we use it with adyen with the processor_contact_id [19:17:16] kill them with fire [19:17:41] so was invoice_id an unused field on the db [19:17:44] yep [19:17:48] ok that makes sense [19:18:16] hmm [19:18:32] do we have the notion of custom fields for that table? [19:19:04] i dont think there are any custom fields we are using for recurring [19:20:40] gerrit really hates starlink [19:21:28] (03PS23) 10Cstone: Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) [19:21:36] (03CR) 10Jgleeson: dLocal: Add response data for recurring (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [19:22:04] (03CR) 10CI reject: [V: 04-1] Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [19:22:48] (03PS24) 10Cstone: Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) [19:30:32] jgleeson: are you free for a quick call on the right way to set up that provider configuration in the ipn patch? [19:30:44] sure [19:31:12] do you want to go into backlog? [19:31:20] yup [19:33:59] (03PS4) 10Jgleeson: WIP: tests for IPN patch [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894064 (https://phabricator.wikimedia.org/T324293) [19:34:43] (03CR) 10CI reject: [V: 04-1] WIP: tests for IPN patch [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894064 (https://phabricator.wikimedia.org/T324293) (owner: 10Jgleeson) [19:42:16] PROBLEM - check_ipsec on frban1001 is CRITICAL: Strongswan CRITICAL - ok: 1 not-conn: frdev1002_v4 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_ipsec [19:42:16] PROBLEM - check_puppetrun on frdev1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 4 minutes ago with 1 failures. Failed resources (up to 3 shown): Mount[/srv/archive/banner_logs] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1002&service=check_puppetrun [19:47:10] PROBLEM - check_ipsec on frban1001 is CRITICAL: Strongswan CRITICAL - ok: 1 not-conn: frdev1002_v4 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_ipsec [19:47:16] RECOVERY - check_puppetrun on frdev1002 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1002&service=check_puppetrun [19:49:22] (03PS25) 10Cstone: Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) [19:49:52] (03CR) 10CI reject: [V: 04-1] Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [19:52:05] (03PS26) 10Cstone: Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) [19:52:16] RECOVERY - check_ipsec on frban1001 is OK: Strongswan OK - 1 ESP OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_ipsec [19:52:33] (03PS5) 10Jgleeson: WIP: tests for IPN patch [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894064 (https://phabricator.wikimedia.org/T324293) [19:53:00] (03CR) 10CI reject: [V: 04-1] WIP: tests for IPN patch [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894064 (https://phabricator.wikimedia.org/T324293) (owner: 10Jgleeson) [19:54:03] thanks jgleeson [20:08:16] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-India, 10FR-dlocal, and 2 others: Support DLocal recurring UPI payments in DonationInterface - https://phabricator.wikimedia.org/T324300 (10AnnWF) The additional UI is to let the client knows that we only charge monthly wi... [20:10:32] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-dlocal: Add customer text hint for India UPI recurring that we only charge monthly with ondemand method - https://phabricator.wikimedia.org/T330530 (10AnnWF) a:03AnnWF [20:11:46] 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Update DLocal createPayment for UPI / DIRECT method - https://phabricator.wikimedia.org/T324294 (10AnnWF) a:05AnnWF→03None [20:13:50] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-India, 10FR-dlocal, and 2 others: Support DLocal recurring UPI payments in DonationInterface - https://phabricator.wikimedia.org/T324300 (10AnnWF) I think this additional DI level design could be coved by T330530, and the... [20:20:08] 10Fundraising-Backlog: Superset/Civi discrepancy in January 2022 reporting - https://phabricator.wikimedia.org/T331165 (10EMartin) 05Open→03Resolved a:03EMartin I am pursuing another avenue to resolve this. Closing this task and will open another if I need FRTech assistance. [20:26:48] (03PS4) 10Damilare Adedoyin: WIP: Refactor Dlocal API class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894053 (https://phabricator.wikimedia.org/T330425) (owner: 10Jgleeson) [20:31:21] (03CR) 10Jgleeson: [C: 04-1] "Thanks Dami! This looks much cleaner. I just had one ask regarding the $successStatus property." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894706 (https://phabricator.wikimedia.org/T329838) (owner: 10Damilare Adedoyin) [20:32:39] (03CR) 10Jgleeson: [C: 03+1] "Sorry that should have been +1" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894706 (https://phabricator.wikimedia.org/T329838) (owner: 10Damilare Adedoyin) [20:34:57] (03CR) 10Eileen: Save fiscal_number to recurring invoice id (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894693 (https://phabricator.wikimedia.org/T331288) (owner: 10Ejegg) [20:45:59] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Civi Staging: grant select on contribution_tracking to civi dev read-only user - https://phabricator.wikimedia.org/T327736 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt [20:47:14] (03PS3) 10Damilare Adedoyin: Refactor the current dLocal StatusNormalizers. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894706 (https://phabricator.wikimedia.org/T329838) [20:56:08] 10Fundraising-Backlog, 10FR-Adyen: Handle issuer timeouts via Adyen - https://phabricator.wikimedia.org/T331317 (10Ejegg) Related: T331319 [21:21:54] 10Fundraising-Backlog: Citibank Individuals Import not working - https://phabricator.wikimedia.org/T331139 (10Eileenmcnaughton) @MDemosWMF those imports work under the assumption the headers will be exactly the same each time - in this case `Posted dt.` is not the normal - `Posted Dt.` is the expected column n... [21:24:42] 10Fundraising-Backlog: Citibank Individuals Import not working - https://phabricator.wikimedia.org/T331139 (10Eileenmcnaughton) OK - it looks like `Txn Amt`, `Posted Dt.` and `Doc Dt` all need to be adjusted to have the second word capitalised [21:27:49] (03PS8) 10AndyRussG: dLocal: Add response data for recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) [21:28:41] (03PS2) 10Eileen: Port upstream PR for better dedupe load performance [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/887874 (https://phabricator.wikimedia.org/T328369) [21:28:58] (03Abandoned) 10Eileen: Port upstream PR for better dedupe load performance [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/887874 (https://phabricator.wikimedia.org/T328369) (owner: 10Eileen) [21:29:32] (03CR) 10CI reject: [V: 04-1] dLocal: Add response data for recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [21:30:43] (03PS9) 10AndyRussG: dLocal: Add response data for recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) [21:35:17] (03PS4) 10Ejegg: Save fiscal_number to recurring invoice id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894693 (https://phabricator.wikimedia.org/T331288) [21:35:19] (03PS1) 10Ejegg: Send recurring invoice id as fiscal_number [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894731 (https://phabricator.wikimedia.org/T331288) [21:36:30] (03CR) 10Eileen: [C: 03+2] Save fiscal_number to recurring invoice id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894693 (https://phabricator.wikimedia.org/T331288) (owner: 10Ejegg) [21:44:22] (03CR) 10Damilare Adedoyin: "Thanks for the suggestion jgleeson, I've made the relevant changes." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894706 (https://phabricator.wikimedia.org/T329838) (owner: 10Damilare Adedoyin) [21:48:00] (03PS4) 10Damilare Adedoyin: Refactor the current dLocal StatusNormalizers. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894706 (https://phabricator.wikimedia.org/T329838) [21:49:44] damilare: I think there's an extra tab [21:49:46] argh [21:49:47] (03CR) 10CI reject: [V: 04-1] Send recurring invoice id as fiscal_number [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894731 (https://phabricator.wikimedia.org/T331288) (owner: 10Ejegg) [21:49:57] I'll fix it and +2 [21:50:03] thanks for the updates! [21:51:21] (03Merged) 10jenkins-bot: Save fiscal_number to recurring invoice id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894693 (https://phabricator.wikimedia.org/T331288) (owner: 10Ejegg) [21:52:04] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Adyen: Better handle terse Adyen idempotency result - https://phabricator.wikimedia.org/T331319 (10AKanji-WMF) [21:52:13] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Adyen: Handle issuer timeouts via Adyen - https://phabricator.wikimedia.org/T331317 (10AKanji-WMF) [21:52:28] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Citibank Individuals Import not working - https://phabricator.wikimedia.org/T331139 (10AKanji-WMF) [21:52:31] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Citibank Individuals Import not working - https://phabricator.wikimedia.org/T331139 (10MDemosWMF) Thanks so much, Eileen! I completed the import with those changes. I'll also flag this to Finance so they know this has to stay static in the future. [21:57:40] (03PS2) 10AndyRussG: Add card type warning for recurring Brazil donors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/894692 (https://phabricator.wikimedia.org/T324297) (owner: 10Ejegg) [21:57:58] ejegg: just reabsed that one ^ [21:58:58] great! [22:24:05] (03PS10) 10Ejegg: dLocal: Add response data for recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [22:24:15] (03CR) 10Ejegg: [C: 03+2] "Looks good to me!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [22:26:35] thanks for the test AndyRussG [22:27:09] jgleeson: thank u for suggesting it :) [22:27:20] and thx ejegg for the +2 ^ [22:28:24] :) [22:29:14] (03CR) 10AndyRussG: [C: 03+1] "Cool, looks good! Just a small question inline. :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/894692 (https://phabricator.wikimedia.org/T324297) (owner: 10Ejegg) [22:30:20] fr-tech im going to afk for a bit until the chainsaws stop (hopefully) I'll be back in like an hour [22:30:56] (03CR) 10Jgleeson: [C: 03+1] "Thanks for the updates Dami. I was gonna quickly fix the indents and +2 but then thought maybe we should turn the parent class into an abs" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894706 (https://phabricator.wikimedia.org/T329838) (owner: 10Damilare Adedoyin) [22:31:21] sorry to hear that your hearing cstone :) [22:33:01] the RV park's trees are all orange trees and they are trimming htem [22:37:04] (03Merged) 10jenkins-bot: dLocal: Add response data for recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/893275 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [22:38:35] I hope it settles down soon! [22:38:39] bye for now [22:42:14] ok, so the recurring processor needs to send country too now [22:53:06] hmm, I can get the donor's country, but if that doesn't match the country of the initial recurring donation we get an error message [22:53:19] I guess that's not a super common case in real life [22:54:18] i'd hate to have to store the country somewhere on the contributionRecur record too [22:55:19] just shout at them "there are no chainsaws in disneyland!" [22:55:22] :) [22:55:56] of course they may tell you to go to disneyland instead. [23:06:10] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for abeckford - https://phabricator.wikimedia.org/T329649 (10Dwisehaupt) 05Open→03Resolved Certificate renewed and sent via email. Password sent via signal. Verified working. [23:07:20] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for nnichols - https://phabricator.wikimedia.org/T329650 (10Dwisehaupt) 05Open→03Resolved Certificate expired. Will reopen if access is required again. [23:07:47] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for lmedley - https://phabricator.wikimedia.org/T328986 (10Dwisehaupt) 05Open→03Resolved Certificate expired. Will reopen if access is required again. [23:08:07] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sredkina - https://phabricator.wikimedia.org/T328064 (10Dwisehaupt) 05Open→03Resolved Certificate expired. Will reopen if access is required again. [23:17:56] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Traffic, 10User-Dereckson: Create /community-beacon alternative entry point - https://phabricator.wikimedia.org/T155929 (10BCornwall) 05Open→03Declined I'm BOLDly closing this as I came to the same conclusions as @Pcoombe. [23:32:19] (03PS1) 10Ejegg: Add country to recurring charge calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894743 (https://phabricator.wikimedia.org/T324298) [23:35:21] (03CR) 10Ejegg: "eileen This is failing tests locally and I'm confused as to why I don't see any results of the new API4 contact lookup when I debug into t" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894743 (https://phabricator.wikimedia.org/T324298) (owner: 10Ejegg) [23:35:56] I guess I could try with an api3 lookup to get the country ISO code, but I'd rather go forward... [23:38:45] ok, let me try using API4 calls to create the test data [23:45:55] (03CR) 10CI reject: [V: 04-1] Add country to recurring charge calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894743 (https://phabricator.wikimedia.org/T324298) (owner: 10Ejegg)