[00:13:45] (03PS27) 10Cstone: Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) [00:21:42] (03Abandoned) 10Eileen: Add phpunit polyfills [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/890506 (owner: 10Eileen) [00:23:45] (03Abandoned) 10Eileen: Replace watchdog calls in exchange_rates_module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892560 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [00:59:22] (03PS2) 10Ejegg: Add country to recurring charge calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894743 (https://phabricator.wikimedia.org/T324298) [01:11:18] (03PS1) 10Eileen: Do not log all context to syslog, cli [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894753 (https://phabricator.wikimedia.org/T288585) [01:13:12] (03CR) 10CI reject: [V: 04-1] Add country to recurring charge calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894743 (https://phabricator.wikimedia.org/T324298) (owner: 10Ejegg) [01:13:12] ejegg: I just put up a patch that stops it from var dumping the context for each log line. In local testing it is doing context replacement already in the places I'm seeing but will look in logs to test that. [01:13:12] But, one other thing - in the tests it dumps a load of warnings about "wmf_civicrm: No credit card submethod given" [01:13:12] - is this really a warning - in which case we should provide it in the test unless we specifically don't want to - or is it just info? [01:13:43] eileen: yeah, we should fix the test data [01:13:49] ok cool [01:14:14] for cc or cash we just about always send a submethod [01:14:19] (in practice) [01:14:41] also, it kinda makes sense to dump the context when doing debug level but not info I guess [01:15:34] hmm, let me test that locally [01:16:10] on prod it didn't seem to be replacing the parameters inline though - it was leaving the {placeholder} [01:17:51] yeah - I'm not seeing that locally yet [01:19:38] k, one sec [01:26:35] (03PS3) 10Ejegg: Add country to recurring charge calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894743 (https://phabricator.wikimedia.org/T324298) [01:40:30] (03CR) 10CI reject: [V: 04-1] Add country to recurring charge calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894743 (https://phabricator.wikimedia.org/T324298) (owner: 10Ejegg) [01:52:09] (03PS1) 10Eileen: Update ImportMessageTest to pass valid submethods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894756 (https://phabricator.wikimedia.org/T288585) [02:09:31] (03CR) 10Ejegg: [C: 03+2] "Let's try it in production!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894753 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:11:58] (03CR) 10Ejegg: [C: 03+2] "Thanks so much for the cleanup!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894756 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:15:48] damn, that testRecurringChargeNonUsd is working for me locally [02:17:39] ejegg: I can pull it down. [02:17:55] hmm, maybe it's bad cleanup [02:18:04] let me see what might be left behind [02:18:33] It and one of the other failing tests on that patch are passing when I run them in isolation [02:18:59] Just testRecurringChargeWithPreviousFailedAttempts fails when I run it solo [02:19:12] and after so many tries locally that still might be dirty data [02:21:40] oh hmm, existing contribution records have a matching txn id or invoice id [02:23:42] (03Merged) 10jenkins-bot: Do not log all context to syslog, cli [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894753 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:24:36] (03PS1) 10Eileen: Convert merge to Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894759 (https://phabricator.wikimedia.org/T288585) [02:26:22] (03Merged) 10jenkins-bot: Update ImportMessageTest to pass valid submethods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894756 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:26:49] ok, so maybe that one just fails after a previous bad cleanup [02:27:46] let's try just killing that date comparison in the first failing test [02:28:05] ejegg: I put up the merge patch (894756) - cos that provides a really easy way of testing the logging [02:29:02] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/894760 [02:29:17] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/894760 (owner: 10Eileen) [02:30:27] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/894760 (owner: 10Eileen) [02:32:31] (03PS4) 10Ejegg: Add country to recurring charge calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894743 (https://phabricator.wikimedia.org/T324298) [02:34:02] alright, I'm going to rebuild civi locally to start with a clean slate [02:34:07] !log civicrm upgraded from fe2c06f6 to dbe3b716 [02:34:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:39:13] looks good so far! [02:39:37] k, I should review some more of those patches then [02:43:36] I [02:43:58] 'm going to clean up a few more of those 'no submethod' warnings, unless you're already on the hunt for those [02:46:52] (03CR) 10CI reject: [V: 04-1] Add country to recurring charge calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894743 (https://phabricator.wikimedia.org/T324298) (owner: 10Ejegg) [02:51:52] (03PS1) 10Ejegg: Fix more missing submethod warnings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894761 [02:52:06] eileen: there's a bit more test spam cleanup ^^^ [03:00:52] (03PS5) 10Ejegg: Add country to recurring charge calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894743 (https://phabricator.wikimedia.org/T324298) [03:05:24] and of course the problem with my tests was the obvious - forgot to update a few expectations on calls to include the new param I'm adding [03:06:06] (03CR) 10Eileen: [C: 03+2] Fix more missing submethod warnings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894761 (owner: 10Ejegg) [03:06:12] just hard to tell from the test output [03:06:52] ejegg: nice one on the submethods - I was expecting them to fail cos it changed the payment_instrument_id in the one I did - but that must not be checked in those ones so jenkins & I ar ehappy [03:07:15] (03PS2) 10Eileen: Remove old exchange_rates_backfill function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892596 (https://phabricator.wikimedia.org/T288585) [03:07:32] I guess not! [03:08:18] (03Abandoned) 10Eileen: [WIP] exception for civiimport [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/883674 (owner: 10Eileen) [03:09:25] just wonder where all those 'cash' ones are coming from [03:10:46] (03PS2) 10Eileen: Remove recalculate_contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892597 (https://phabricator.wikimedia.org/T288585) [03:12:12] ejegg: I'm just looking at these remove ones - that just remove old code - I thought they were merged but this isn't https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/892597 [03:12:43] & this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/892596 [03:12:46] ok, i'll +2 em [03:13:15] (03CR) 10Ejegg: [C: 03+2] Remove recalculate_contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892597 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:13:27] cool [03:13:31] (03PS3) 10Ejegg: Remove old exchange_rates_backfill function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892596 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:14:14] (03CR) 10Ejegg: [C: 03+2] Remove old exchange_rates_backfill function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892596 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:16:36] (03PS6) 10Ejegg: Add country to recurring charge calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894743 (https://phabricator.wikimedia.org/T324298) [03:16:47] woo, ^^^ passed tests [03:16:58] (03CR) 10Eileen: Add country to recurring charge calls (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894743 (https://phabricator.wikimedia.org/T324298) (owner: 10Ejegg) [03:17:42] ejegg: nice - I took a look & the changes make sense - it's not code I normally touch too much but the api call change seems right & that is all there really is [03:17:58] (03CR) 10Ejegg: "well spotted - we should use that to localize the recurring charge description, but we don't yet." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894743 (https://phabricator.wikimedia.org/T324298) (owner: 10Ejegg) [03:19:06] thanks eileen [03:20:43] (03Merged) 10jenkins-bot: Fix more missing submethod warnings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894761 (owner: 10Ejegg) [03:24:32] ejegg: I'm OK to +2 it based on stepping through the test & ccccccjelcgbibeltdvlcbjteccgcetveiifubfnrele [03:24:46] looking at the code if you want me to - it is pretty straight forward [03:24:49] thanks! [03:26:23] (03PS2) 10Ejegg: Send recurring invoice id as fiscal_number [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894731 (https://phabricator.wikimedia.org/T331288) [03:27:01] (03CR) 10Eileen: [C: 03+2] "Code change looks good, has test cover" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894743 (https://phabricator.wikimedia.org/T324298) (owner: 10Ejegg) [03:28:12] (03Merged) 10jenkins-bot: Remove recalculate_contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892597 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:28:14] (03Merged) 10jenkins-bot: Remove old exchange_rates_backfill function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892596 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:35:24] k, I should get to bed [03:35:45] (03PS7) 10Ejegg: Add country to recurring charge calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894743 (https://phabricator.wikimedia.org/T324298) [03:35:53] (03PS3) 10Ejegg: Send recurring invoice id as fiscal_number [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894731 (https://phabricator.wikimedia.org/T331288) [03:36:18] oh derp, that rebase during gate-and-submit will probably bork the submit [03:38:10] (03PS2) 10Eileen: Add new acitvity type as Thank you email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/891361 (https://phabricator.wikimedia.org/T327963) (owner: 10Wfan) [03:40:37] (03CR) 10Eileen: [C: 03+1] "I made some minor changes" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/891361 (https://phabricator.wikimedia.org/T327963) (owner: 10Wfan) [03:46:17] (03PS3) 10Eileen: Add new acitvity type as Thank you email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/891361 (https://phabricator.wikimedia.org/T327963) (owner: 10Wfan) [03:47:37] (03CR) 10Eileen: [C: 03+1] "OK 2 further changes" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/891361 (https://phabricator.wikimedia.org/T327963) (owner: 10Wfan) [03:48:04] (03CR) 10Eileen: [C: 03+1] "wfan - if you are happy with the changes I added in please upgrade to +2" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/891361 (https://phabricator.wikimedia.org/T327963) (owner: 10Wfan) [03:51:48] (03PS1) 10Eileen: Remove action from user available actions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894764 [03:53:55] (03CR) 10Eileen: [C: 03+1] "Also - I put up a similar fix for the corrected email address activity here - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/891361 (https://phabricator.wikimedia.org/T327963) (owner: 10Wfan) [04:01:14] (03PS2) 10Eileen: Remove action from user available actions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894764 [04:03:46] (03CR) 10CI reject: [V: 04-1] Remove action from user available actions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894764 (owner: 10Eileen) [05:29:10] (03PS3) 10Eileen: Remove action from user available actions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894764 [05:32:16] (03PS4) 10Eileen: Add new acitvity type as Thank you email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/891361 (https://phabricator.wikimedia.org/T327963) (owner: 10Wfan) [06:54:51] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/894846 (owner: 10L10n-bot) [12:53:07] (03CR) 10Damilare Adedoyin: [C: 03+2] India recurring di configs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/890364 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [12:55:29] (03PS6) 10Jgleeson: WIP: tests for IPN patch [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894064 (https://phabricator.wikimedia.org/T324293) [12:55:48] (03CR) 10CI reject: [V: 04-1] WIP: tests for IPN patch [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894064 (https://phabricator.wikimedia.org/T324293) (owner: 10Jgleeson) [12:55:52] (03CR) 10Damilare Adedoyin: [C: 03+1] "LGTM. +1'ing to allow the Smashpig patch to be merged first. Or we could add a Depends-On, then I can +2 as it wouldn't be merged till the" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/890364 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [13:53:26] (03CR) 10Jgleeson: "I'm running into a problem early on, which is preventing me from testing this. It looks like the JSON string being sent over from dLocal i" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [14:04:23] (03CR) 10Jgleeson: [C: 03+1] "From IRC:" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894706 (https://phabricator.wikimedia.org/T329838) (owner: 10Damilare Adedoyin) [14:32:14] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1001:down, kafka-jumbo1002:down https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_kafkatee [14:36:39] (03PS5) 10Damilare Adedoyin: Refactor the current dLocal StatusNormalizers. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894706 (https://phabricator.wikimedia.org/T329838) [14:37:16] RECOVERY - check_kafkatee on frban1001 is OK: OK: brokers:9 topics:1 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_kafkatee [14:41:13] (03CR) 10Damilare Adedoyin: "Thanks jgleeson, I've made the recommended changes. Changed the $successStatus instance variable from protected from public as I don't thi" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894706 (https://phabricator.wikimedia.org/T329838) (owner: 10Damilare Adedoyin) [15:38:17] (03CR) 10Jgleeson: [C: 03+2] "Awesome! thanks for this refactor, the code looks much cleaner." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894706 (https://phabricator.wikimedia.org/T329838) (owner: 10Damilare Adedoyin) [15:38:59] (03Merged) 10jenkins-bot: Refactor the current dLocal StatusNormalizers. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894706 (https://phabricator.wikimedia.org/T329838) (owner: 10Damilare Adedoyin) [15:39:55] tnx jgleeson [15:40:51] thank you! [15:56:35] (03CR) 10Ejegg: [C: 04-1] "Just need to add order_id" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [15:57:15] nice damilare and jgleeson, I'm glad we didn't leave that till the distant future [15:57:39] jgleeson: I was able to successfully test an IPN from dlocal just now [15:57:54] using a Pix payment [15:58:03] were you seeing malformed JSON come from dlocal? [15:58:24] the json looked valid to me ejegg [15:58:39] One thing - I did have to use the full smashpig_http_.... URL because the /dlocal alias wasn't working [15:58:44] i should look into that [15:59:07] I'm using the /dlocal alias [15:59:11] or was [15:59:26] do you have charset in your local config? [15:59:37] charset: iso-8859-1 [15:59:57] ooh, dang [16:00:01] still not utf-8? [16:00:12] maybe we don't need that [16:00:21] let's see what happens without that [16:00:38] and test with a bunch of accents [16:01:47] found another cpf generator with a bit fewer ads: https://www.freetool.dev/cpf-generator-validator?tp=age [16:01:51] ha [16:03:30] (03CR) 10Damilare Adedoyin: [C: 03+2] Send recurring invoice id as fiscal_number [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894731 (https://phabricator.wikimedia.org/T331288) (owner: 10Ejegg) [16:04:42] damilare: we should probably test that one with a real charge to sandbox [16:04:51] I think cstone was gonna write some instructions [16:04:56] or did you figure it out [16:05:39] I've gotta head out. parents evening. back later [16:06:24] ohh ok, I'd remove the +2 then [16:07:00] I was going to test it with the country patch that was just merged using the drush command in the process control job [16:07:29] I had ran a test before by backdating the adyen entry in the contribution_recur table [16:08:12] Hey yeah don't let that stop you damilare I totally forgot I said I would write those [16:08:33] It was going to be something like you did anyway [16:09:40] ohh ok, thanks cstone, I'd do that and if it works I'd +2 this patch and also share the test instructions. [16:11:05] jgleeson|away: cstone: I tried some non-ascii characters in a Pix payment name and with no charset in the dlocal config [16:11:08] it seemed to work [16:11:21] oh wait, let me make sure it doesn't have a charset in the parent config yaml [16:11:46] ah, it did [16:11:54] ok, let me try again with the charset gone in both [16:15:12] ahh, I seem not to have rebuilt the smashpig container since updating the fd patch with the image switch [16:15:26] well that explains the lack of /dlocal alias [16:52:43] sorry damilare that wasn't meant to say dont +2 it [16:53:05] I should have been more clear. I was suggesting an end-to-end test [16:53:25] just cause the smashpig extension side of things tends to get tested less [16:53:35] even though it runs through SmashPig [16:54:57] cstone: is it just a case of putting through a recurring donation and updatng the next_scheduled date for the contribution_recur row? [16:55:40] and also updating the receive_date on the contribution table [16:55:56] ah nice spot [16:56:21] no p jgleeson, my comment on this T324298 should cover the e2e tests as well [16:56:22] T324298: Ensure DLocal recurring card payments can be charged via Civi SmashPig recurring charge job - https://phabricator.wikimedia.org/T324298 [16:57:13] I'd write a detailed instructions once I'm done testing and debugging through the SmashPig class [16:58:02] thanks so much! [17:00:01] oh interesting [17:00:18] sebastian is suggesting we're not setting the callback_url in the requests [17:00:32] did I break my environment? I thought we had that one nailed [17:00:46] jgleeson: i removed the charset from both dlocal main.yamls and it still accept the accented characters on the IPN JSON [17:01:06] do you want to try with those removed? [17:01:21] ejegg: have you not encountered the issue I mentioned on cstone's patch? [17:01:40] what's confusing is that it used to work [17:01:46] No, it seems to be parsing anything I throw at it just fine [17:02:26] ok cool I'll try it again now, just gonna put the heating on as it's freezing [17:05:29] sorry was half awake when i started responding to people [17:05:30] oh I just realised [17:05:45] we don't have a callback_url in the console for the new sandbox account [17:05:51] because we don't have a console [17:05:54] jgleeson: to your recurring question if its already in the db you can pass through an id to charge again [17:06:11] so I wonder why my config isn't sending it [17:06:21] jgleeson: ah yeah, that's the much better way to run the recurring charge job [17:06:46] drush @wmff cvapi job.process_smashpig_recurring contribution_recur_id=5 [17:06:48] thanks cstone [17:06:51] damilare: ^ [17:06:57] thanks ejegg [17:06:58] https://wikitech.wikimedia.org/wiki/Fundraising/SmashPig [17:06:58] ohh cool [17:07:03] thanks [17:07:07] that also skips the check for a second charge too soon after the last one [17:07:08] instrcutrions there damilare jgleeson [17:07:12] imagine its spelled right [17:07:21] ooh ejegg got it too sorry not awake [17:07:36] good to have the link to bookmark in any case cstone [17:09:41] looks like ejegg's link might be easier to run outside the drush dir [17:09:46] drush @wmff -vv cvapi job.process_smashpig_recurring contribution_recur_id=5 [17:09:56] should I update the doc to show that? [17:10:24] yes please! [17:10:28] oh yeah the doc is old [17:17:23] looks like we may not be saving the country from DI [17:17:41] so Civi is using the default US and it's breaking the recurring charge [17:19:06] (03CR) 10Wfan: [C: 03+2] "Thanks Eileen, for finding the bug and fix it :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/891361 (https://phabricator.wikimedia.org/T327963) (owner: 10Wfan) [17:19:51] or never mind, might be weird setup. Trying again with a new charge [17:20:56] the contact_id that mapped to the recur contribution didn't have a country setup. I just deleted it and I'm doing a new import now. [17:21:51] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks for working on this ejegg. Tested and looks good to me." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894731 (https://phabricator.wikimedia.org/T331288) (owner: 10Ejegg) [17:24:13] ah ok ejegg and cstone it looks like that error I was seeing with the callback_url was on my side. The UPI patch I was reviewing didn't have the callback_url stuff in it [17:24:18] I'll let Sebastian know [17:24:38] also ejegg cstone I think this parse_str() bug has always been a bug maybe but we don't see it [17:24:53] as it's trying to parse_str() a json string and not a query string [17:27:58] we can probably ignore it for now [17:28:14] (03PS28) 10Cstone: Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) [17:28:16] (03CR) 10Wfan: [C: 03+2] "LGTM, all fields do not want customer to alter, thanks for finding them :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894764 (owner: 10Eileen) [17:28:40] thanks jgleeson ejegg for the review ^ that has the two missing queue params [17:29:02] and jgleeson I wasn't seeing the same error you were on the new account even though it was sending me to our live ty page instead of the callback one [17:29:27] the callback one was my side [17:29:48] the upi patch I was reviewing was on an older version of master [17:29:51] is it actually sending you to the local page? [17:29:55] maybe mine is messed up too [17:29:57] it's fixed now [17:30:03] I just needed to use master [17:31:36] (03CR) 10Ejegg: "Do we need a way to map the upi submethod to either UI or IR depending on whether it is recurring?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/890364 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [17:32:17] (03PS7) 10Ejegg: Add ReferenceData [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891930 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [17:32:26] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891930 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [17:33:16] ejegg: cstone I never got round to finishing review on that but did you both see a message pushed to the queue at the end? [17:34:10] on the ipn one jgleeson ? [17:34:17] ya [17:34:37] false alarm, it was the contact that was saved weirdly on my db afterall. The recurring charge was successful [17:34:57] (03CR) 10Wfan: India recurring di configs (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/890364 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [17:35:18] yeah jgleeson I was seeing two basically with a pix donation, one from the front end and one from the listener and then can compare them [17:36:03] 10Fundraising-Backlog, 10FR-Japan: Make the Japan "V1" payment wiki variant the new control - https://phabricator.wikimedia.org/T329807 (10HNordeenWMF) @spatton @TSkaff hi! Could one of you update me on this one, since Japan email started this week, are we delaying making Variant 1 the default so they can do m... [17:36:14] ok cstone I'll give it another run [17:37:38] (03CR) 10Ejegg: [C: 03+1] "This all looks good to me! It seems like jgleeson's specific code comments have been addressed. I haven't been able to replicate the parse" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [17:38:20] ejegg: the parse_str was a bit of a blind alley [17:38:24] although I think it is a bug [17:38:53] when live debugging yesterday with cstone we noticed it but it looks like that isn't affecting the dlocallistener code [17:39:03] I can show you if you like [17:39:16] Sure, want to hop on a call? [17:39:21] sure [17:39:25] today's something [17:39:34] analytics call? [17:39:37] sure [17:39:49] do you want me to join too jgleeson ? [17:40:04] sure the more the merrier! [17:40:47] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Ensure DLocal recurring card payments can be charged via Civi SmashPig recurring charge job - https://phabricator.wikimedia.org/T324298... [17:45:09] 10Fundraising-Backlog, 10FR-Japan: Make the Japan "V1" payment wiki variant the new control - https://phabricator.wikimedia.org/T329807 (10TSkaff) @HNordeenWMF We are sending Japan email donors to the existing control payments form--Sam wants to test more V1 when it's time for banners (get more input on V1) an... [17:47:31] (03PS1) 10Ejegg: Remove charset from dlocal config [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/895335 [17:58:21] (03Merged) 10jenkins-bot: Send recurring invoice id as fiscal_number [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894731 (https://phabricator.wikimedia.org/T331288) (owner: 10Ejegg) [18:00:45] (03Merged) 10jenkins-bot: Remove action from user available actions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894764 (owner: 10Eileen) [18:00:47] (03Merged) 10jenkins-bot: Add ReferenceData [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891930 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [18:07:28] (03CR) 10Jgleeson: Create IPN listener for dlocal for PAID messages (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [18:13:46] cstone: re:callback_url. clicking return is sending me back to me [18:14:15] hmm ok thanks! [18:16:24] (03CR) 10Jgleeson: [C: 03+2] "Works for me! thanks" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/895335 (owner: 10Ejegg) [18:17:02] (03Merged) 10jenkins-bot: Remove charset from dlocal config [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/895335 (owner: 10Ejegg) [18:19:30] (03CR) 10Jgleeson: [C: 03+2] "I just pushed up an update to config-private removing this there too." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/895335 (owner: 10Ejegg) [18:23:08] (03CR) 10Jgleeson: [C: 03+1] "This is also working for me! thanks so much for helping me test it. happy to +2!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [18:23:54] thanks jgleeson [18:24:09] I'll just sum those together to make the C+2 then [18:24:13] (03Abandoned) 10Jgleeson: WIP: tests for IPN patch [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894064 (https://phabricator.wikimedia.org/T324293) (owner: 10Jgleeson) [18:24:20] thanks ejegg [18:24:25] (03PS29) 10Ejegg: Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [18:24:33] (03CR) 10Ejegg: [C: 03+2] Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [18:25:11] (03Merged) 10jenkins-bot: Create IPN listener for dlocal for PAID messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [18:25:25] ejegg: I wondered if the lowercaseness mattered with the 'authorization' header [18:25:33] I think you posted a link but I missed it [18:25:51] oh I don't know [18:26:01] it shouldn't [18:26:35] thanks ejegg jgleeson ! [18:27:44] oh the mdn link: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Authorization [18:28:33] so it looks like it's just UPI to get over the hill and we're there [18:28:43] yay! [18:29:22] gonna grab dinner. will read that when I get back. thanks! [18:30:42] (03PS4) 10Wfan: India recurring di configs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/890364 (https://phabricator.wikimedia.org/T324299) [18:33:05] (03PS5) 10Wfan: Add new acitvity type as Thank you email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/891361 (https://phabricator.wikimedia.org/T327963) [18:44:19] (03PS2) 10Ejegg: Watchdog -> Civi::log in thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892599 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [18:44:22] (03CR) 10Ejegg: [C: 03+2] Watchdog -> Civi::log in thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892599 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [18:51:36] (03CR) 10Ejegg: [C: 04-1] "just one key name off" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892600 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [18:51:57] (03PS2) 10Ejegg: Replace watchdog with Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892600 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [18:52:10] (03PS3) 10Ejegg: Replace watchdog with Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892600 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [18:52:29] (03CR) 10Ejegg: [C: 03+2] "I just fixed the 'elapsed' key. All good besides that!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892600 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [19:02:41] (03Merged) 10jenkins-bot: Watchdog -> Civi::log in thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892599 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [19:10:04] (03Merged) 10jenkins-bot: Replace watchdog with Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892600 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [19:17:31] (03PS2) 10Ejegg: More watchdog to Civi::log in thankyou module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892601 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [19:17:34] (03CR) 10Ejegg: [C: 03+2] More watchdog to Civi::log in thankyou module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892601 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [19:19:11] (03PS2) 10Ejegg: Watchdog to Civi::log in thank_you module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892603 (owner: 10Eileen) [19:19:15] (03CR) 10Ejegg: [C: 03+2] Watchdog to Civi::log in thank_you module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892603 (owner: 10Eileen) [19:26:11] (03PS1) 10Wfan: Add exmpalination for only charge monthly for india recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/894583 (https://phabricator.wikimedia.org/T330530) [19:35:27] (03Merged) 10jenkins-bot: More watchdog to Civi::log in thankyou module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892601 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [19:37:32] (03Merged) 10jenkins-bot: Watchdog to Civi::log in thank_you module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892603 (owner: 10Eileen) [19:40:02] !log payments-wiki upgraded from 346e6f61 to 05a5e09a [19:40:05] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:45:34] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Investigate why new dLocal REDIRECT payments are falling into the "dead session" category - https://phabricator.wikimedia.org/T330308 (10Ejegg) OK... [20:00:51] (03PS3) 10Ejegg: Assign upi to payment_method for india recurring [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/891736 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [20:01:10] (03CR) 10Ejegg: [C: 03+2] Assign upi to payment_method for india recurring [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/891736 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [20:01:15] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Assign upi to payment_method for india recurring [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/891736 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [20:09:31] (03CR) 10AndyRussG: [C: 03+2] "Cool beans, thanks so much!!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/894692 (https://phabricator.wikimedia.org/T324297) (owner: 10Ejegg) [20:16:36] 10Fundraising-Backlog, 10FR-Smashpig, 10MediaWiki-extensions-DonationInterface: Move DLocal submethod -> bank_code mapping down into SmashPig - https://phabricator.wikimedia.org/T331475 (10Ejegg) [20:17:06] 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Move DLocal submethod -> bank_code mapping down into SmashPig - https://phabricator.wikimedia.org/T331475 (10Ejegg) p:05Triage→03Low [20:17:26] 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Move DLocal submethod -> bank_code mapping down into SmashPig - https://phabricator.wikimedia.org/T331475 (10Ejegg) [20:17:29] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10Ejegg) [20:42:12] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Handle recurring IPNs for Dlocal - https://phabricator.wikimedia.org/T330724 (10XenoRyet) [20:44:33] 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Implement one-time UPI / DIRECT payments for DLocal in DonationInterface - https://phabricator.wikimedia.org/T324295 (10XenoRyet) [20:44:56] 10Fundraising Sprint Can't touch $this, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Update DLocal createPayment for UPI / DIRECT method - https://phabricator.wikimedia.org/T324294 (10XenoRyet) [20:46:06] 10Fundraising-Backlog, 10FR-dlocal: DLocal sandbox/production account setup - https://phabricator.wikimedia.org/T324499 (10greg) (is this actually done or should it go in one-hour test?) [20:49:55] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-dlocal: Plan dLocal testing rollout - https://phabricator.wikimedia.org/T330801 (10Cstone) [21:00:06] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Adyen: Better handle terse Adyen idempotency result - https://phabricator.wikimedia.org/T331319 (10greg) p:05Triage→03Medium [21:00:17] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Adyen: Handle issuer timeouts via Adyen - https://phabricator.wikimedia.org/T331317 (10greg) p:05Triage→03Medium [21:00:47] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Citibank Individuals Import not working - https://phabricator.wikimedia.org/T331139 (10greg) p:05Triage→03Medium [21:01:40] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Citibank Individuals Import not working - https://phabricator.wikimedia.org/T331139 (10greg) a:03Eileenmcnaughton [21:08:13] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Add customer text hint for India UPI recurring that we only charge monthly with ondemand method - https://phabricator.wikimedia.org/T330530 (10AnnWF) Emailed Evelyn about the explanation place a... [21:09:08] 10Fundraising-Backlog, 10FR-dlocal: DLocal sandbox/production account setup - https://phabricator.wikimedia.org/T324499 (10greg) (also, we should probably not have a "done" column in the #fr-dlocal board, status is tracked in sprints) [21:33:26] (03PS3) 10Ejegg: Add card type warning for recurring Brazil donors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/894692 (https://phabricator.wikimedia.org/T324297) [21:36:21] (03PS7) 10Jgleeson: Add bank transfer for india recurring subscription request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891328 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [21:36:29] (03PS5) 10Jgleeson: India recurring di configs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/890364 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [21:55:23] huh, every time I try to make an IR payment I get a status_code=300, status_detail="The payment was rejected" [21:55:59] fr-tech can any of you successfully make India recurring payments with the updated SmashPig and DonationInterface code (and the new login?) [21:58:08] I've tried varying the PAN [21:59:04] i was getting someones sucessful ipns but that would be with the old creds [21:59:13] ejegg: I got that error on the new creds [21:59:26] ah so it's likely account-related [21:59:28] and after switching to the old I was able to go through the UPi flow [21:59:38] although the payment was rejected in the final step [22:00:04] shoot, I hope he can get the new account to parity with the old one [22:00:05] wfan: when I do the UPI form step, do I keep UPI payment method selected or select payTM [22:00:28] ejegg: I might email sebastian now. it would be good to have that in place for tomorrow morning my time [22:00:38] thanks! [22:01:50] paytm here is the doc [22:01:59] https://docs.google.com/document/d/192XebJIjFJexnKqO0j6bu_wt9z5iJwxJY-yg2lsg2jY/edit [22:02:22] "In sandbox, use Paytm and OTP 489871 to complete the payment. With phone number 7777777777" [22:02:47] ah thanks. I must have messed that step up [22:10:34] np~ this doc is quite helpful with all sample data [22:17:43] ok that email is sent [22:17:48] lemme retry that flow [22:17:49] thanks jgleeson [22:17:55] np [22:18:38] ah man [22:22:59] wfan: that was odd. I started a a new payment and got redirect straight to the redirect URL [22:23:04] redirected [22:23:43] ? what do you mean with the new credential? which means working now? [22:23:53] whereas first time around, I had to get the redirect URL from the smashpig maintenance script output and navigate to it in the browser [22:24:03] no, still old API credentials [22:24:07] I am going to find the ondemand screenshot for evelyn, and think Sebastian just replied [22:24:33] oh great [22:25:23] the new credential is working now, I can make the payment [22:27:22] ok I'll swtich back to them and try again [22:28:21] hey i dont know whos ipns im still getting but i just got one with a token [22:28:42] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-India, and 4 others: Implement backend for DLocal recurring UPI payments in SmashPig - https://phabricator.wikimedia.org/T324299 (10AnnWF) Add bank transfer for India recurring... [22:28:45] "wallet":{"token":"2167bd17-70eb-4e4f-86e0-0ccdd001f380"},"recurring_info":{"prenotify_approved":true} [22:28:59] That's me~ [22:29:43] but still with old credentials then? [22:29:46] wfan: [22:30:20] it seems like I'm doing step one on your instructions here and being forwarded straight to the redirect URL in step 3 now, https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/891328 [22:30:28] hmm, hold on, the new cre do not return token for me [22:30:32] let me double check [22:30:32] does that happen for you? [22:30:54] oh right sorry [22:31:06] the second step is not second, just some validation hint [22:31:07] new credentials shouldnt send me any ipns cause its mine in the old cred console right now [22:31:16] should be step 1 and then step 3 [22:31:31] while the second step is just some other method you can use to replace the step 1 [22:31:32] so I didn't need to run the CreateIRRecurringSubscription.php script [22:31:38] not at all [22:31:48] I did the very first time [22:31:50] it's the same thing as you did from the web [22:32:05] but subsequent attempts just take me straight the the UPI web forms [22:32:12] to* [22:32:24] wanna do a quick call and I can show you? [22:36:54] (03PS8) 10Wfan: Add bank transfer for india recurring subscription request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891328 (https://phabricator.wikimedia.org/T324299) [22:37:39] sure, let's use our mid-spring link? [22:38:03] sure [22:40:09] i need to cancel these test adyen recurrings we have hah they keep sending ipns [22:40:42] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sredkina - https://phabricator.wikimedia.org/T328064 (10Dwisehaupt) Certificate renewed and sent via email. Password sent via SMS. [22:55:57] cstone: are you paymenttest4? [22:56:50] i am [23:14:05] hi Christine, can we join the mid-spring to the token ipn, I do not get it for the new cre [23:15:27] cstone: seems like we are using another channel haha [23:15:49] hah convos in all the channels at aonce [23:16:23] https://meet.google.com/aio-mocx-ggt?authuser=0 [23:25:14] (03PS2) 10Eileen: More watchdog to Civi:log changes in RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892605 (https://phabricator.wikimedia.org/T288585) [23:25:46] (03PS2) 10Eileen: Fix recurring queue consumer to call Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892604 (https://phabricator.wikimedia.org/T288585) [23:27:20] 10Fundraising-Backlog, 10Recurring-Donations, 10fr-donorservices: Ingenico recurrings stopped at status 600 March 5th - https://phabricator.wikimedia.org/T331490 (10MBeat33) [23:32:52] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Handle recurring IPNs for Dlocal - https://phabricator.wikimedia.org/T330724 (10Ejegg) [23:33:12] There are 4 more of those watchdog changes in review & I was gonna do a bit more but wondering if it is easier to have them in a chain or not - they are not co-dependent but you can 'follow' chains https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/893095 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/894759 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/892605 [23:33:12] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/892604 [23:35:47] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Fundraising access request for Salvatore Borriello - https://phabricator.wikimedia.org/T331491 (10MBeat33) [23:41:20] (03CR) 10Ejegg: Add bank transfer for india recurring subscription request (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891328 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [23:50:41] (03PS2) 10Eileen: Convert merge to Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894759 (https://phabricator.wikimedia.org/T288585) [23:50:43] (03PS1) 10Eileen: Remove call to watchdog by removing call to legacy civicrm_api_class() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895372 (https://phabricator.wikimedia.org/T288585)