[00:34:03] 10Fundraising-Backlog, 10FR-Japan: Make the Japan "V1" payment wiki variant the new control - https://phabricator.wikimedia.org/T329807 (10HNordeenWMF) thanks @TSkaff! Just confirmed with Sam, we'll test V1 again during the Japan banner campaign. [00:56:11] (03PS9) 10Wfan: Add bank transfer for india recurring subscription request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891328 (https://phabricator.wikimedia.org/T324299) [01:05:59] (03PS2) 10Wfan: Add unit test for upi recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894131 (https://phabricator.wikimedia.org/T324299) [02:55:16] (03CR) 10Ejegg: [C: 04-1] "Looks like a debug-level line got promoted to info here" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894759 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:57:54] (03PS2) 10Ejegg: Remove call to watchdog by removing call to legacy civicrm_api_class() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895372 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:58:00] (03CR) 10Ejegg: [C: 03+2] Remove call to watchdog by removing call to legacy civicrm_api_class() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895372 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:01:08] (03PS3) 10Ejegg: Fix recurring queue consumer to call Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892604 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:01:18] (03CR) 10Ejegg: [C: 03+2] Fix recurring queue consumer to call Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892604 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:02:55] (03PS3) 10Ejegg: More watchdog to Civi:log changes in RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892605 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:03:10] (03CR) 10Ejegg: [C: 03+2] More watchdog to Civi:log changes in RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892605 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:06:55] (03CR) 10Ejegg: [C: 03+2] "re-applying C+2 initially applied by AndyRussG" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/894692 (https://phabricator.wikimedia.org/T324297) (owner: 10Ejegg) [03:08:47] (03Merged) 10jenkins-bot: Add card type warning for recurring Brazil donors [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/894692 (https://phabricator.wikimedia.org/T324297) (owner: 10Ejegg) [03:12:06] (03Merged) 10jenkins-bot: Remove call to watchdog by removing call to legacy civicrm_api_class() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895372 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:16:33] (03Merged) 10jenkins-bot: Fix recurring queue consumer to call Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892604 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:18:20] (03Merged) 10jenkins-bot: More watchdog to Civi:log changes in RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/892605 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:22:33] (03CR) 10Ejegg: "This is an interesting refactor. I like the simplification of the Api class, but the nested constructor calls with the parent call at the " [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894053 (https://phabricator.wikimedia.org/T330425) (owner: 10Jgleeson) [03:47:43] (03CR) 10Ejegg: "One parameter we need to rename, and a couple minor comments." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891328 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [05:04:32] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Handle recurring IPNs for Dlocal - https://phabricator.wikimedia.org/T330724 (10AndyRussG) a:03AndyRussG [07:04:49] 10Fundraising-Backlog, 10fr-donorservices: Civi not keeping the mailing address attached to the active recurring donation after merging - https://phabricator.wikimedia.org/T330231 (10Eileenmcnaughton) @SHust maybe we can go over this on the screen at Civi fortnightly - I just merged the contacts you gave and... [07:07:21] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/895421 (owner: 10L10n-bot) [13:23:37] cstone: it looks like the IPNs for UPI are working as expected. I managed to recreate one just now [13:48:16] fr-tech is someone testing out UPI payments? I keep getting IPNs for transactions with the amount of 505 which is different to the amount I was trying earlier [14:44:35] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-India, and 2 others: Support DLocal recurring UPI payments in Civi SmashPig recurring charge job - https://phabricator.wikimedia.org/T324301 (10jgleeson) We need to trigger the prenotificat... [14:55:41] jgleeson|away: I put in one test transaction earlier today. [14:57:20] (03PS5) 10Damilare Adedoyin: Refactor Dlocal API class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894053 (https://phabricator.wikimedia.org/T330425) (owner: 10Jgleeson) [17:07:01] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-India, and 2 others: Support DLocal recurring UPI payments in Civi SmashPig recurring charge job - https://phabricator.wikimedia.org/T324301 (10Ejegg) Good point - we should clarify whether... [17:11:18] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint Everything I Merge I Merge For You, and 3 others: Handle IPNs from DLocal payins - https://phabricator.wikimedia.org/T324293 (10Cstone) a:05Cstone→03... [17:18:32] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-dlocal: Add 'wmf_token' CSRF protection to dLocal forms - https://phabricator.wikimedia.org/T330778 (10XenoRyet) [17:31:09] hmm ejegg|away rethinking what I said about the jobs queue for the one time vs recurring. I'm having a hard time separating the soapness of the adyen jobs queue from what its actually doing. Do we just not want to do the pending lookup in the ipn listener code, that is why things get sent to another queue? [17:59:33] ah cool damilare. maybe it was that one. I wasn't sure how it was hitting my address tho [18:08:15] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Add customer text hint for India UPI recurring that we only charge monthly with ondemand method - https://phabricator.wikimedia.org/T330530 (10AnnWF) Newest Update, Evelyn said the donor team op... [18:10:40] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Fundraising access request for Salvatore Borriello - https://phabricator.wikimedia.org/T331491 (10Dwisehaupt) [18:52:08] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Fundraising access request for Salvatore Borriello - https://phabricator.wikimedia.org/T331491 (10Dwisehaupt) Initial email sent with instructions on ssh key generation and to find out if a yubikey needs to be ordered. [18:57:32] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Fundraising access request for Salvatore Borriello - https://phabricator.wikimedia.org/T331491 (10Dwisehaupt) [19:02:49] cstone: oh right, so the issue is that the IPN listener doesn't have db access [19:02:55] it can just send stuff to the queues [19:03:07] then the jobs run on the civi box, which does have DB access [19:04:10] fr-tech are we just letting the fortnightly/tech talk overlap stand so we can switch to TT whenever fortnightly is done? [19:04:36] ah hahh [19:05:08] thats what we have been doing ejegg [19:05:45] cool cool [19:05:54] I think so [19:07:17] cstone: ejegg it sounded like we'd need the additional job functionality for the unhappy path [19:07:48] jgleeson: I can picture that being added to the recurring queue consumer [19:07:56] oh I guess we'd need to also mark retry attempts async as we get those via IPN [19:08:12] the prenotification status results [19:08:17] yeah i think at least two jobs or one that does two things? [19:08:27] man this is complicated [19:09:38] So I think this is going to mean taking a bit of failure handling logic that's in the nightly charge job, and implementing that in the recurring queue consumer [19:10:01] then the dlocal IPN listener will send a payment_failed notification to the recurring queue [19:10:19] ah ok [19:10:22] i guess that wouldnt need a job then [19:10:26] and the recurring queue will increment the failure count and the retry date [19:11:21] The other special handling is that for other methods, a retry is basically identical to the first attempt, while for UPI the retry needs to send slightly different parameters (prenotify=false) [19:11:50] So I think we can tell whether we are retrying just by looking at the failure count [19:12:14] if it's zero, we are on the first attempt so send prenotify=true [19:12:21] if it's >0 we are retrying [19:12:50] (when we get a successful payment we should reset failure count to 0) [19:12:55] hmm, what else? [19:13:00] if 1 then stop retry since only allow one retry [19:13:21] Oh right, we need to know how to associate a successful payment IPN with the correct contribution_recur row [19:13:25] and if failed, might be lower balance or donor decline, should we stop retry next month? [19:13:31] shoot, I wish I had thought of that while we were still in the call [19:14:02] also true wfan, we have a variable for retry limit for other methods, but for this method we can only retry once [19:14:14] so I guess we need another ticket or two for this work [19:14:42] was it only retry once or only retry one per prenotification? [19:14:54] per prenotification I think? [19:15:12] good question, let's check the doc [19:15:56] ah, as to associating the successful payment with the recurring record, I think we can do that via the token (assuming we get that on each IPN) [19:16:12] yeah it would be good to get some of these ipns [19:16:24] https://docs.dlocal.com/docs/india-recurring-payments#retry-payments [19:16:37] it's kind outdated, it said two retry and 48 hrs... [19:16:41] agreed cstone [19:17:03] is there a way to trigger those? [19:17:26] he said we have to wait 24 hours for those [19:17:28] ejegg: that retry logic sounds good [19:17:32] those ones [19:20:57] 10Fundraising-Backlog: Create a UML diagrams for dLocal India Recurring - https://phabricator.wikimedia.org/T331555 (10jgleeson) [19:21:08] 10Fundraising-Backlog: Create a UML diagram for dLocal India Recurring - https://phabricator.wikimedia.org/T331555 (10jgleeson) [19:21:10] oops [19:21:26] 10Fundraising-Backlog: Create UML diagrams for dLocal India Recurring - https://phabricator.wikimedia.org/T331555 (10jgleeson) [19:21:51] fr-tech we can probably leave that till after tuesday ^ [19:22:07] but it would be nice to have when we starting thinking about the more complicated follow-on stuff [19:22:18] start* [19:22:35] jgleeson I'll add some more detail to T324301 [19:22:35] T324301: Support DLocal recurring UPI payments in Civi SmashPig recurring charge job - https://phabricator.wikimedia.org/T324301 [19:22:45] thanks ejegg [19:22:58] 10Fundraising-Backlog, 10FR-dlocal: Create UML diagrams for dLocal India Recurring - https://phabricator.wikimedia.org/T331555 (10jgleeson) [19:23:06] Btw, I do not need to update the ondemand until next Tuesday right? Should I create a ticket for the future change? [19:23:20] oh I think we're doing that now [19:23:27] hmm I might be wrong [19:23:35] fr-tech? [19:24:05] wfan: maybe create the ticket and if it's now we can pull it n [19:24:07] in* [19:24:14] I think dylan said we will use ondemand for internal test then switch back to monthly? ok [19:24:44] I guess that decides when we get strict with the India dates [19:25:01] and the adjustments needed [19:25:36] XenoRyet: is it ondemand for tuesday? [19:26:44] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-India, and 3 others: Update the frequency back to Monthly from ondemand - https://phabricator.wikimedia.org/T331556 (10AnnWF) [19:30:35] jgleeson|dinner, yea, let's stick with on demand for Tuesday. [19:31:08] wfan, let's do create a ticket for the future change to monthly [19:31:23] We won't pull it in sprint, but it'll be good to track it. [19:34:28] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-India, and 2 others: Support DLocal recurring UPI payments in Civi SmashPig recurring charge job - https://phabricator.wikimedia.org/T324301 (10Ejegg) [19:41:56] https://phabricator.wikimedia.org/T331556 created [19:42:00] cant even escape leafblowers at the RV block (neighbor is leafblower (dusting?) their RV) [19:44:43] oh hmm, I'm getting errors on latest DI when I attempt to go to a dlocal form with no submethod [19:45:05] looks like that bank code staging class [19:49:29] (03PS1) 10Ejegg: Don't error on payment_submethod="" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895851 [19:51:55] (03CR) 10Wfan: [C: 03+2] "LGTM, actually changed the same for UPI dl patch yesterday at my local and forget to submit, thanks" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895851 (owner: 10Ejegg) [19:54:26] thanks wfan [19:56:45] ejegg: [19:56:59] hmm is the error being throw in that transformer? [19:57:10] seems odd to allow it to proceed with an empty value [19:57:20] the $meta lookup will fail then no? [19:59:21] India is UTC +5:30 [19:59:38] it's the 9th in India now right [20:00:28] (03PS3) 10Eileen: Convert merge to Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894759 (https://phabricator.wikimedia.org/T288585) [20:01:06] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Fundraising access request for Salvatore Borriello - https://phabricator.wikimedia.org/T331491 (10Dwisehaupt) Tech support request made for the yubikey. [20:01:13] ohh I see what's happening [20:01:21] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Fundraising access request for Salvatore Borriello - https://phabricator.wikimedia.org/T331491 (10Dwisehaupt) [20:01:23] it's an empty string so it DOES get in [20:01:30] (03CR) 10Eileen: "I fixed it - I also did a couple more & fixed on catch (the CiviCRM_Api3_Exception is now an alias for CRM_Core_Excdeption)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894759 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [20:09:08] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-India, 10FR-Smashpig, and 2 others: Update the frequency back to Monthly from ondemand - https://phabricator.wikimedia.org/T331556 (10AnnWF) [20:14:43] (03Merged) 10jenkins-bot: Don't error on payment_submethod="" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895851 (owner: 10Ejegg) [21:21:21] (03PS1) 10Ejegg: WIP changes for UPI in Smashpig recur processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895862 [21:22:42] (03PS2) 10Jgleeson: WIP changes for UPI in Smashpig recur processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895862 (https://phabricator.wikimedia.org/T324301) (owner: 10Ejegg) [21:25:36] (03CR) 10CI reject: [V: 04-1] WIP changes for UPI in Smashpig recur processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895862 (https://phabricator.wikimedia.org/T324301) (owner: 10Ejegg) [21:49:30] (03PS1) 10Eileen: Replace more watchdogs, add a couple of type hints [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895866 (https://phabricator.wikimedia.org/T288585) [22:05:30] (03PS1) 10Eileen: Remove watchdog, legacy function calls in normalize message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895870 (https://phabricator.wikimedia.org/T288585) [22:16:31] (03PS2) 10Eileen: Remove watchdog, legacy function calls in normalize message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895870 (https://phabricator.wikimedia.org/T288585) [22:16:33] (03PS1) 10Eileen: Cleanup to remove call to wmf_civicrm_get_civi_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895871 (https://phabricator.wikimedia.org/T288585) [22:25:10] (03PS1) 10Eileen: Fully remove wmf_get_civi_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895873 (https://phabricator.wikimedia.org/T288585) [22:31:50] (03CR) 10CI reject: [V: 04-1] Cleanup to remove call to wmf_civicrm_get_civi_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895871 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [22:32:29] (03CR) 10CI reject: [V: 04-1] Remove watchdog, legacy function calls in normalize message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895870 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [22:40:09] (03CR) 10CI reject: [V: 04-1] Fully remove wmf_get_civi_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895873 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [22:46:12] (03PS3) 10Eileen: Remove watchdog, legacy function calls in normalize message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895870 (https://phabricator.wikimedia.org/T288585) [23:00:43] (03CR) 10CI reject: [V: 04-1] Remove watchdog, legacy function calls in normalize message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895870 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [23:24:19] (03PS4) 10Eileen: Remove watchdog, legacy function calls in normalize message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895870 (https://phabricator.wikimedia.org/T288585) [23:35:50] (03PS2) 10Wfan: Add explanation for india recurring ondemand only charge monthly [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/894583 (https://phabricator.wikimedia.org/T330530) [23:35:58] (03CR) 10CI reject: [V: 04-1] Add explanation for india recurring ondemand only charge monthly [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/894583 (https://phabricator.wikimedia.org/T330530) (owner: 10Wfan) [23:37:01] (03PS3) 10Wfan: Add explanation for india recurring ondemand only charge monthly [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/894583 (https://phabricator.wikimedia.org/T330530) [23:37:11] (03CR) 10CI reject: [V: 04-1] Add explanation for india recurring ondemand only charge monthly [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/894583 (https://phabricator.wikimedia.org/T330530) (owner: 10Wfan) [23:38:26] (03CR) 10CI reject: [V: 04-1] Remove watchdog, legacy function calls in normalize message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895870 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [23:47:40] (03PS6) 10Wfan: India recurring di configs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/890364 (https://phabricator.wikimedia.org/T324299)