[00:02:55] (03PS4) 10Wfan: Add explanation for india recurring ondemand only charge monthly [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/894583 (https://phabricator.wikimedia.org/T330530) [00:06:48] (03PS5) 10Eileen: Remove watchdog, legacy function calls in normalize message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895870 (https://phabricator.wikimedia.org/T288585) [00:10:09] (03PS6) 10Eileen: Remove watchdog, legacy function calls in normalize message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895870 (https://phabricator.wikimedia.org/T288585) [00:15:46] (03PS1) 10Cstone: WIP: Create dlocal-jobs and move PAID messages there [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/895887 [00:16:22] (03CR) 10CI reject: [V: 04-1] WIP: Create dlocal-jobs and move PAID messages there [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/895887 (owner: 10Cstone) [00:17:30] (03PS5) 10Wfan: Add explanation for india recurring ondemand only charge monthly [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/894583 (https://phabricator.wikimedia.org/T330530) [00:40:19] (03PS2) 10Eileen: Cleanup to remove call to wmf_civicrm_get_civi_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895871 (https://phabricator.wikimedia.org/T288585) [00:40:26] (03PS2) 10Eileen: Fully remove wmf_get_civi_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895873 (https://phabricator.wikimedia.org/T288585) [00:44:50] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Add customer text hint for India UPI recurring that we only charge monthly with ondemand method - https://phabricator.wikimedia.org/T330530 (10AnnWF) Newest update, we will use "we **will** onl... [00:46:01] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-India, 10FR-Smashpig, and 2 others: (undecided yet) Update the frequency back to Monthly from ondemand - https://phabricator.wikimedia.org/T331556 (10AnnWF) [00:46:17] 10Fundraising-Backlog, 10FR-India, 10FR-Smashpig, 10FR-dlocal, 10Recurring-Donations: (undecided yet) Update the frequency back to Monthly from ondemand - https://phabricator.wikimedia.org/T331556 (10AnnWF) [01:36:59] (03PS10) 10Wfan: Add bank transfer for india recurring subscription request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/891328 (https://phabricator.wikimedia.org/T324299) [01:45:42] (03PS3) 10Wfan: Add unit test for upi recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894131 (https://phabricator.wikimedia.org/T324299) [01:46:08] (03CR) 10CI reject: [V: 04-1] Add unit test for upi recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894131 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [01:50:38] (03PS2) 10Cstone: WIP: Create dlocal-jobs and move PAID messages there [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/895887 (https://phabricator.wikimedia.org/T330724) [02:00:07] (03PS4) 10Wfan: Add unit test for upi recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894131 (https://phabricator.wikimedia.org/T324299) [02:25:49] (03PS1) 10Wfan: Add amount limitation for dlocal [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/895895 (https://phabricator.wikimedia.org/T324299) [02:26:15] (03PS2) 10Wfan: Add amount limitation for dlocal [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/895895 (https://phabricator.wikimedia.org/T324299) [02:29:48] (03PS6) 10Wfan: Add explanation for india recurring ondemand only charge monthly [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/894583 (https://phabricator.wikimedia.org/T330530) [02:37:02] (03PS7) 10Wfan: Add explanation for india recurring ondemand only charge monthly [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/894583 (https://phabricator.wikimedia.org/T330530) [02:40:52] (03PS1) 10Wfan: Add recurring amount validation to DI for UPI [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895731 (https://phabricator.wikimedia.org/T324299) [03:23:12] (03PS1) 10Ejegg: UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) [03:35:54] (03PS2) 10Ejegg: UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) [03:36:08] oh dang it's late [11:40:13] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10jgleeson) [11:40:15] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-India, 10FR-dlocal, and 2 others: Support DLocal recurring UPI payments in DonationInterface - https://phabricator.wikimedia.org/T324300 (10jgleeson) 05Open→03Declined Agreed. Let's close it [12:31:13] (03PS3) 10Jgleeson: WIP changes for UPI in Smashpig recur processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895862 (https://phabricator.wikimedia.org/T324301) (owner: 10Ejegg) [12:45:39] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-dlocal: Add 'wmf_token' CSRF protection to dLocal forms - https://phabricator.wikimedia.org/T330778 (10Damilare) a:03Damilare [14:44:26] (03PS1) 10Damilare Adedoyin: Add 'wmf_token' CSRF protection to dLocal forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/896106 (https://phabricator.wikimedia.org/T330778) [14:44:57] (03PS4) 10Jgleeson: WIP: Smashpig Extension: UPI Recurring [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895862 (https://phabricator.wikimedia.org/T324301) (owner: 10Ejegg) [14:46:07] (03CR) 10CI reject: [V: 04-1] Add 'wmf_token' CSRF protection to dLocal forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/896106 (https://phabricator.wikimedia.org/T330778) (owner: 10Damilare Adedoyin) [14:49:28] (03PS2) 10Damilare Adedoyin: Add 'wmf_token' CSRF protection to dLocal forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/896106 (https://phabricator.wikimedia.org/T330778) [14:50:12] (03CR) 10Tacsipacsi: "Can I get a review on this? It’s been waiting for over half a year." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/808391 (https://phabricator.wikimedia.org/T262722) (owner: 10Tacsipacsi) [14:59:18] (03CR) 10CI reject: [V: 04-1] WIP: Smashpig Extension: UPI Recurring [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895862 (https://phabricator.wikimedia.org/T324301) (owner: 10Ejegg) [15:28:41] (03CR) 10Ejegg: "On the right track! A couple of initial observations." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/895887 (https://phabricator.wikimedia.org/T330724) (owner: 10Cstone) [15:38:40] damilare: is it snowing where you are? [15:40:14] yh a lot jgleeson [15:40:31] how about yours? [15:40:44] yeah and it's freezing cold too [15:41:15] I feel like scrooge saying this but I don't like it! [15:41:39] The snow is about 5cm high on the terrace [15:42:02] sounds about the right height to make snowballs with :) [15:42:37] lol exactly, we had our fair share of snow ball fights this morning [15:43:06] nice ha! [15:50:02] (03PS6) 10Damilare Adedoyin: Refactor Dlocal API class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894053 (https://phabricator.wikimedia.org/T330425) (owner: 10Jgleeson) [15:50:28] (03CR) 10CI reject: [V: 04-1] Refactor Dlocal API class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894053 (https://phabricator.wikimedia.org/T330425) (owner: 10Jgleeson) [15:54:55] (03CR) 10Jgleeson: "Thanks for this. I can see it's WIP, so my notes are just questions, really. I'm looking at https://phabricator.wikimedia.org/F36899625, s" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/895887 (https://phabricator.wikimedia.org/T330724) (owner: 10Cstone) [16:20:21] (03CR) 10Damilare Adedoyin: "Recheck" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894053 (https://phabricator.wikimedia.org/T330425) (owner: 10Jgleeson) [16:43:16] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q1:rack/setup/install frbast1002, frmon1002, frpig1002 - https://phabricator.wikimedia.org/T319460 (10Cmjohnson) I received an idrac error on 3 of these hosts, I confirmed with Jeff that he is not able to access the host. I am going to try and update t... [16:43:29] (03PS1) 10Ejegg: Add more queue consumers [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/896132 [16:45:36] hmm, errors on both of the new queue runs in that fr-dev patch ^^. let's see [16:46:57] ok right, I need to initialize the smashpig context for the Upi donations qc [16:50:04] ah [16:50:28] gotta double-check the command for the preferences queue consumer [16:50:31] will C-1 for now [16:50:54] (03CR) 10Ejegg: [C: 04-1] "Errors on the new queue run still, will investigate" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/896132 (owner: 10Ejegg) [17:02:37] hmm, that extra 14 lines of 'Box Requirements Checker' for each drush command isn't exactly helpful either [17:12:45] (03PS3) 10Ejegg: UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) [17:19:29] (03CR) 10CI reject: [V: 04-1] UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg) [18:18:12] (03PS2) 10Ejegg: Add more queue consumers [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/896132 [18:25:54] 10fundraising-tech-ops: encrypt fundraising database client->server communication - https://phabricator.wikimedia.org/T170321 (10Jgreen) 05Open→03Resolved DjangoBannerStats and corresponding mysql user now require SSL [18:33:45] (03PS7) 10Ejegg: India recurring di configs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/890364 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [18:33:50] (03PS7) 10Damilare Adedoyin: Refactor Dlocal API class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894053 (https://phabricator.wikimedia.org/T330425) (owner: 10Jgleeson) [18:33:57] (03CR) 10Ejegg: [C: 03+2] India recurring di configs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/890364 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [18:35:50] (03Merged) 10jenkins-bot: India recurring di configs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/890364 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [18:36:34] (03PS8) 10Wfan: Add explanation for india recurring ondemand only charge monthly [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/894583 (https://phabricator.wikimedia.org/T330530) [18:46:31] 10fundraising-tech-ops: encrypt fundraising database client->server communication - https://phabricator.wikimedia.org/T170321 (10Jgreen) 05Resolved→03Open [18:46:59] 10fundraising-tech-ops: encrypt fundraising database client->server communication - https://phabricator.wikimedia.org/T170321 (10Jgreen) 05Open→03In progress Reopening because we haven't switched over individual (non-service) users yet. [19:01:26] (03CR) 10Damilare Adedoyin: "Thanks ejegg for the initial review, sorry I missed it and mistakenly marked as resolved. I did some additional refactoring and removed th" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894053 (https://phabricator.wikimedia.org/T330425) (owner: 10Jgleeson) [19:02:35] anilk: that survey draft looks great. I just read it and it sounds like a great way to introduce the stakeholders to user stories and pave the foundations for a user story pipeline! nice job man [19:03:44] Thanks so much jgleeson! that means a lot- I hope we get something workable out of it - someone else made the flag to me about a survey like this in that folks may not know what they actually could be helped by... [19:14:19] Yeah definitely anilk. A few months back we had a kick-off session with Dana over in Architecture to see if he could help us with our plans to rearchitect the stack. One of the steps he advocates is a Stakeholder interviews to better understand their goals and objectives relative to the systems we provide them. There's some slides from that discussion for context that you might like to check [19:14:21] out as they are aligned with your survey approach. https://docs.google.com/presentation/d/1GFKfocJ78OgjXy0DEeOBODvqVFlRRMFiSQq6HNf71iY/edit#slide=id.g1702cc3f82d_0_1303 [19:34:00] Snow is once again sending the UK into meltdown. https://www.bbc.co.uk/news/live/uk-64883505 [19:34:12] 10Fundraising-Backlog: Please turn on Monthly Convert in Czech (csCZ) - https://phabricator.wikimedia.org/T331665 (10TSkaff) [19:39:57] Awesome, thanks again jgleeson [19:52:12] (03CR) 10Ejegg: "Just needed a casing change for the prefs queue, and the other queue was failing because of problems in the WIP patch's code which are fix" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/896132 (owner: 10Ejegg) [19:54:15] 10Fundraising-Backlog: Please turn on Monthly Convert in Czech (csCZ) - https://phabricator.wikimedia.org/T331665 (10AnnWF) Will needs to add CZ to the list of wgDonationInterfaceMonthlyConvertCountries from config/payments/LocalSettings.php [19:59:26] cstone: ahh, I just realized your new job will definitely want to send the IPN to the upi-donations queue even when there's no pending message, because second + further installment payments will never have a pending message [20:00:06] yeah was just going to comment that i think we should send them to both queues if there isnt a pending message incase some front end issue? [20:00:11] since we do have a lot of info [20:00:24] yep, sounds good [20:02:58] Oh I need a micropatch to add a upi-donations default + test queue. I'll do that on top of your patch that adds the jobs-dlocal so as not to conflict [20:09:40] (03PS3) 10Cstone: WIP: Create dlocal-jobs and move PAID messages there [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/895887 (https://phabricator.wikimedia.org/T330724) [20:10:08] (03CR) 10CI reject: [V: 04-1] WIP: Create dlocal-jobs and move PAID messages there [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/895887 (https://phabricator.wikimedia.org/T330724) (owner: 10Cstone) [20:12:38] fr-tech when testing upi recurring has anyone seen the form go right to the thank you page without loading the upi parts [20:13:29] or paytm part, basically skipping the redirect [20:16:28] nope [20:18:34] hah okay maybe just me but its weird id say it happens 1/6ish tries [20:19:17] I'll try one at my end now [20:22:21] I just got the paytm forms [20:22:34] although it does save a bunch of data from previous sessions [20:24:21] cstone: I tried three times and got redirected [20:24:49] ok yeah maybe just me [20:25:24] i know ive done this before but does anyone remember how to get just a test message (i dont think this is the right redis word) onto a queue there [20:25:33] im not using the right words to google it [20:26:24] via RPUSH? [20:26:34] that sounds familiar [20:26:49] that pushed a queue message on [20:26:52] pushes [20:27:41] and we use LPOP to take em off [20:27:47] ok cool now just need to figure out why it hates the json im trying ot put on there [20:28:12] oh it might need escaping [20:28:32] hmm [20:28:36] or unescaping [20:28:55] hah okay [20:28:57] i think i got it [20:29:29] thanks [20:29:52] I think I used to use this to strip the backslashes from our queue messages https://www.commandlinefu.com/commands/view/24108/escape-quotes-strip-newlines-tabs-and-spaces-from-json [20:30:28] or https://www.commandlinefu.com/commands/view/24625/pretty-print-json-block-that-has-quotes-escaped [20:30:39] without the final bit [20:31:02] yeah I thought i had to pass in the unescaped but i just grabbed the escape from a previous redis print out [20:31:05] d [20:31:34] I think we send them in unescaped [20:35:35] cstone: we have a script to do it [20:35:50] in the SmashPig/Maintenance folder [20:36:01] PopulateQueueFromDump I think [20:43:29] cstone: yeah once it just sent me straight to the TY page too - I thought I was doing something really weird [20:43:48] when i tried again with browser tools on it was the expected flow [20:46:54] sometimes im randomly getting Missing required parameters in request but i keep using the same url [20:48:32] (03CR) 10Ejegg: [C: 03+2] Convert merge to Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894759 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [20:49:01] thanks ejegg [20:49:35] fr-tech does upi == IR or should I pass through IR and check for that? [20:51:01] wait i wrote that code haha [20:51:47] (03PS2) 10Ejegg: Replace more watchdogs, add a couple of type hints [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895866 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [20:52:13] oops, that was the wrong kind of rebase [20:52:22] let's get it back on top of the parent patch [20:52:33] (03PS3) 10Ejegg: Replace more watchdogs, add a couple of type hints [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895866 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [20:52:40] (03CR) 10Ejegg: [C: 03+2] Replace more watchdogs, add a couple of type hints (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895866 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [20:53:34] cstone heh, yeah, I guess IR is the only one that needs the special extra queue though [20:53:56] since UI (one-time UPI via redirect) is also mapped to upi, right? [20:59:11] ah okay and UD too [20:59:41] ah ok, though I guess we aren't using UD for this iteration at least [20:59:50] UD? [21:00:00] guessing UPI direct? [21:00:35] ah cool [21:01:25] Bedtime stories seems like the most effective use of ChatGPT at the moment [21:01:41] "give me a kids bedtime story using the following storyline, princess tilly and rapunzel are flying around space in a princess spaceship trying to reach a blue giant star after their home, a red giant star, was destroyed by a giant black hole. the black hole will pull them in if they don't move fast" [21:02:01] Tilly picked the characters whilst Oscar picked the setting [21:02:45] it wasn't bad either to be fair [21:03:09] (03Merged) 10jenkins-bot: Convert merge to Civi::log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/894759 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [21:06:46] (03Merged) 10jenkins-bot: Replace more watchdogs, add a couple of type hints [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895866 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [21:17:29] haha cat jumped on the keyboard and got me an error page that way too! [21:18:48] (03PS4) 10Cstone: Create dlocal-jobs and move PAID messages there [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/895887 (https://phabricator.wikimedia.org/T330724) [21:18:59] hmm in the smashpig extension tests, it looks like the payment_instrument is defaulting to "Check" and then being mapped to "cc" here https://github.com/wikimedia/wikimedia-fundraising-crm/blob/master/drupal/sites/default/civicrm/extensions/org.wikimedia.smashpig/CRM/Core/Payment/SmashPig.php#L252 [21:19:13] (03CR) 10CI reject: [V: 04-1] Create dlocal-jobs and move PAID messages there [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/895887 (https://phabricator.wikimedia.org/T330724) (owner: 10Cstone) [21:19:21] but i can't see where we'd change the payment_instrument to bank transfer [21:19:25] any ideas eileen ejegg ? [21:20:34] (03PS5) 10Cstone: Create dlocal-jobs and move PAID messages there [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/895887 (https://phabricator.wikimedia.org/T330724) [21:20:35] one day ill learn these space rules [21:20:36] is the cat your tester cstone ? [21:20:43] ejegg: so FinanceInstrument class will handle payment method of 'bt' [21:20:45] cat was adding to the chaos [21:21:03] (03CR) 10CI reject: [V: 04-1] Create dlocal-jobs and move PAID messages there [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/895887 (https://phabricator.wikimedia.org/T330724) (owner: 10Cstone) [21:21:09] chaos cat [21:21:25] eileen: do I set the instrument when creating the contribution> [21:21:26] it doesnt want a space but also wants a spacee [21:21:26] ? [21:21:42] cstone: that's the cat? [21:21:56] looks like it's a property of the contribution [21:22:02] (03PS6) 10Cstone: Create dlocal-jobs and move PAID messages there [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/895887 (https://phabricator.wikimedia.org/T330724) [21:22:12] jgleeson: I'm coming to this a bit cold - but I think you set the method as soon as you 'know' it - as 'payment_method' [21:23:07] I kinda hate that we use 'handy' abbreviations like 'bt' - but I can understand it if it is coming in the url - otherwise I think we should use the 'real' name - but that is probably outta scope [21:23:09] sorry eileen [21:23:14] I think I've found it [21:23:58] jgleeson: ejegg https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/895887/ is now grabbing the ipn, adding it with pending info, and sending either to donations (one time) or upi-donations (if IR) [21:24:09] cstone: maybe we need Cat GPT [21:24:13] im going to afk for like an hour to go to the beach while its actually warm out for once but I'll be back [21:24:27] eileen: CatGPT would just be like dgfklsjg94855tdg fgsfg;;;;;;;;;;;; [21:25:22] perfect - the perenial sprint name ... [21:25:22] eregsgkhjer says CatGPT [21:25:22] fejwkehrkwaerwe says CatGPT [21:25:22] gwererwerew says CatGPT..... [21:25:38] ninja [21:25:50] nice cstone [21:42:12] Hi Seddon - Is FR-team still taking care of CentralNotice code? [21:43:21] Hi herzog, we have been looking to hand off its care to a different team for a while now, but we still make emergency fixes now and then [21:43:58] herzog: is this regarding https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/808391/ ? I did see the request for review this morning [21:44:03] Hi ejegg :-) Well, not an emergency but it looks like the impression diet //might// be somewhat broken [21:44:16] herzog: hmm what makes you say that? [21:44:17] https://phabricator.wikimedia.org/T331671 [21:44:22] AndyRussG: ^ [21:44:32] oho, that might merit attention soon-ish [21:44:44] just reporting, as I wasn't sure who is the code stewards for CN [21:45:16] in any case, if I may, please reconsider not leaving CN code or it'll probably just end in the basket of unmaintained by deployed extensions :-) [21:45:18] herzog: ok I can take a look in a couple hours [21:45:52] thanks AndyRussG - I thought I should ask here before adding the fr-team tag [21:45:55] herzog: indeed it can't leave fr-tech without being owned elsewhere. it's a complicated story, though. recently other teams have done tons of maintenance work, which is hugely appreciated [21:46:21] there are certainly features that are only used by fundraising also [21:46:36] and CN is terribly complex too (CN Admin speaking :-) ) [21:46:37] herzog: thanks so much for checking and for flagging the bug!! [21:47:08] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CentralNotice banners being shown too many times - https://phabricator.wikimedia.org/T331671 (10AndyRussG) [21:47:37] herzog: yeah definitely a UI overhaul has been needed... mmm well, really forever :) [21:48:51] In any case, thanks for the help and apologies for the inconvenience [21:53:12] herzog: thank u, and of course no bother at all :) [21:53:28] pls don't hesitate to reach out anytime [21:54:26] I didn't know who to ask, and since I worked on Meta with Seddo-n re CentralNotice I ended here :) [21:54:56] * herzog back to spambot blocking [22:01:40] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CentralNotice banners being shown too many times - https://phabricator.wikimedia.org/T331671 (10TheresNoTime) > deactivating certain/all banner types at https://meta.wikimedia.org/wiki/Special:Preferences#mw-prefsection-centralnotice-banners doesn't... [22:07:33] (03CR) 10Ejegg: "Looking really good! Couple more suggestions inline." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/895887 (https://phabricator.wikimedia.org/T330724) (owner: 10Cstone) [22:09:16] (03PS2) 10Ejegg: Add same-site and secure attributes to MW cookie [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/893573 (https://phabricator.wikimedia.org/T330308) [22:09:18] (03CR) 10Ejegg: [V: 03+2] Add same-site and secure attributes to MW cookie [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/893573 (https://phabricator.wikimedia.org/T330308) (owner: 10Ejegg) [22:09:57] (03PS3) 10Ejegg: Add more queue consumers [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/896132 [22:57:09] (03PS1) 10Ejegg: Default and test settings for upi-donations queue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/896192 [23:01:34] ejegg: the where is the UpiDonationsQueue, do we want to add a depends-on for this https://gerrit.wikimedia.org/r/896132? [23:31:51] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CentralNotice banners being shown too many times - https://phabricator.wikimedia.org/T331671 (10DerHexer)