[00:00:49] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Add recurring amount validation to DI level for dlocal IN bt recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895731 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan)
[00:02:37] <wikibugs>	 (03PS5) 10Wfan: Add recurring amount validation to DI level for dlocal IN bt recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895731 (https://phabricator.wikimedia.org/T324299)
[00:26:30] <ejegg>	 k, i need to get that new QC passing tests
[00:30:33] <wikibugs>	 (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.39.0 [extensions/CentralNotice] (REL1_39) - 10https://gerrit.wikimedia.org/r/898105
[00:31:07] <wikibugs>	 (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.39.0 [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/898120
[00:32:23] <wikibugs>	 (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.39.0 [extensions/FundraiserLandingPage] (REL1_39) - 10https://gerrit.wikimedia.org/r/898135
[00:32:27] <wikibugs>	 (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.39.0 [extensions/FundraisingTranslateWorkflow] (REL1_39) - 10https://gerrit.wikimedia.org/r/898136
[00:33:39] <wikibugs>	 (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.39.0 [extensions/LandingCheck] (REL1_39) - 10https://gerrit.wikimedia.org/r/898154
[00:39:29] <wikibugs>	 (03PS1) 10Wfan: Only convert to subscription if upi also set a default phone for india in cc [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/898234
[00:39:41] <wikibugs>	 (03PS2) 10Wfan: Only convert to subscription if upi also set a default phone for india in cc [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/898234 (https://phabricator.wikimedia.org/T324298)
[00:52:39] <wikibugs>	 (03CR) 10Wfan: [C: 03+2] "before we have" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/885454 (owner: 10Ejegg)
[00:53:22] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Only convert to subscription if upi also set a default phone for india in cc [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/898234 (https://phabricator.wikimedia.org/T324298) (owner: 10Wfan)
[01:07:07] <wikibugs>	 (03Merged) 10jenkins-bot: Fix test CVV score mismatch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/885454 (owner: 10Ejegg)
[01:20:46] <wikibugs>	 (03PS3) 10Wfan: Only convert to subscription if upi, only set wiki phone as default for india cc [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/898234 (https://phabricator.wikimedia.org/T324298)
[01:23:45] <eileen>	 ejegg: did you see I fixed the one you gave a +1 to?
[01:40:36] <wikibugs>	 (03PS1) 10AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/898236
[01:44:33] <wikibugs>	 (03CR) 10Cstone: "Hmm I'm not seeing a warning, would it be in the form? Or is it somewhere I am not looking for it." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895731 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan)
[01:44:43] <wikibugs>	 (03CR) 10AndyRussG: [C: 03+2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/898236 (owner: 10AndyRussG)
[01:57:10] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/898236 (owner: 10AndyRussG)
[01:57:43] <AndyRussG>	 hahaha merged 3 minutes before the train deadline
[01:57:54] * AndyRussG runs away
[01:59:43] <ejegg>	 sorry eileen, was about to +2 that
[02:00:00] <ejegg>	 and got called away
[02:00:25] <eileen>	 thanks ejegg there is a tonne there - which is kinda crazy- but at least it would be nice to merge the one you already did the work on 
[02:00:54] <ejegg>	 oh man, that's quite a stack
[02:01:27] <ejegg>	 oh wait, I did merge this one: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/895870/
[02:04:22] <eileen>	 ejegg: nice.
[02:04:36] <eileen>	 Yeah it's a huge stack - but each one is very snackable
[02:05:00] <eileen>	 & they will happily rebase out of the chain if done our of order
[02:05:33] <eileen>	 with the exception that the odd formatting one like this will have dependencies https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/897985/1
[02:06:17] <eileen>	 sadly - it doesn't quite get us to the end but I thought it was enough to queue up
[02:18:38] <wikibugs>	 (03PS8) 10Ejegg: UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724)
[02:18:46] <AndyRussG>	 a snack stack?
[02:20:14] <wikibugs>	 (03PS9) 10Ejegg: UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724)
[02:20:29] <ejegg>	 oreos up to the sky
[02:23:48] <ejegg>	 ok, that queue consumer should be passing tests
[02:32:33] <anilk>	 congrats ejegg 
[02:34:10] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg)
[02:36:56] <ejegg>	 ugh, i thought i had that passing tests
[02:37:06] <ejegg>	 thanks anilk 
[02:40:39] <wikibugs>	 (03PS10) 10Ejegg: UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724)
[02:40:51] <ejegg>	 ahh, looks like the merge order broke an unrelated test
[02:40:57] <ejegg>	 I folded the fix in there
[02:42:11] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.40-notes (1.40.0-wmf.27; 2023-03-13): CentralNotice banners being shown too many times - https://phabricator.wikimedia.org/T331671 (10AndyRussG) Heyyy here are some quick notes: - I was able to reproduce th...
[02:42:32] <wikibugs>	 (03PS11) 10Ejegg: UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724)
[02:44:45] <wikibugs>	 (03CR) 10Cstone: [C: 03+2] "Looks good! Test passing again" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898043 (https://phabricator.wikimedia.org/T324301) (owner: 10Jgleeson)
[02:50:02] <eileen>	 AndyRussG: a stack of hot diggity watchdogs
[02:56:24] <wikibugs>	 10fundraising-tech-ops: reimage fundraising_database role servers to Bullseye - https://phabricator.wikimedia.org/T315601 (10Dwisehaupt)
[02:57:17] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg)
[02:59:02] <wikibugs>	 (03Merged) 10jenkins-bot: Fix test for Smashpig Extension: UPI Recurring [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898043 (https://phabricator.wikimedia.org/T324301) (owner: 10Jgleeson)
[03:32:44] <wikibugs>	 (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.40.0 [extensions/CentralNotice] (REL1_40) - 10https://gerrit.wikimedia.org/r/898263
[03:34:41] <wikibugs>	 (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.40.0 [extensions/DonationInterface] (REL1_40) - 10https://gerrit.wikimedia.org/r/898288
[03:35:33] <wikibugs>	 (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.40.0 [extensions/FundraiserLandingPage] (REL1_40) - 10https://gerrit.wikimedia.org/r/898301
[03:35:37] <wikibugs>	 (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.40.0 [extensions/FundraisingTranslateWorkflow] (REL1_40) - 10https://gerrit.wikimedia.org/r/898302
[03:37:21] <wikibugs>	 (03PS1) 10Jforrester: build: Update MediaWiki requirement to 1.40.0 [extensions/LandingCheck] (REL1_40) - 10https://gerrit.wikimedia.org/r/898328
[06:32:42] <wikibugs>	 (03CR) 10AndyRussG: "Thanks so much for this!! Works great. See inline for a couple notes. :)" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/898234 (https://phabricator.wikimedia.org/T324298) (owner: 10Wfan)
[07:21:33] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/898511 (owner: 10L10n-bot)
[08:23:26] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.40-notes (1.40.0-wmf.27; 2023-03-13): CentralNotice banners being shown too many times - https://phabricator.wikimedia.org/T331671 (10Ciell) Thanks for the work Andy!
[08:44:23] <wikibugs>	 (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/895421 (owner: 10L10n-bot)
[08:45:15] <wikibugs>	 (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/897500 (owner: 10L10n-bot)
[08:53:43] <wikibugs>	 (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/898511 (owner: 10L10n-bot)
[09:11:46] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.40-notes (1.40.0-wmf.27; 2023-03-13): CentralNotice banners being shown too many times - https://phabricator.wikimedia.org/T331671 (10DerHexer) Thanks @AndyRussG for fixing the preference bug!  However, it'...
[10:42:19] <wikibugs>	 (03CR) 10Jgleeson: "I this might be failing on CI due to the other test issue I ran into yesterday." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg)
[10:43:11] <wikibugs>	 (03CR) 10Jgleeson: "I'll see if I can resolve the merge conflict and rebase over master to pull in the test fix" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg)
[10:48:33] <wikibugs>	 (03PS12) 10Jgleeson: UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg)
[11:02:54] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg)
[11:18:31] <wikibugs>	 (03Abandoned) 10Nikerabbit: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/894277 (owner: 10L10n-bot)
[11:18:49] <wikibugs>	 (03Abandoned) 10Nikerabbit: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/894846 (owner: 10L10n-bot)
[11:28:00] <wikibugs>	 (03CR) 10Jgleeson: Only convert to subscription if upi, only set wiki phone as default for india cc (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/898234 (https://phabricator.wikimedia.org/T324298) (owner: 10Wfan)
[12:55:14] <wikibugs>	 (03CR) 10Jgleeson: "Ok, that didn't fix it. Instead, It looks like the new tests are failing due to no db fixture cleanup. I can recreate it locally, so I'll " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg)
[13:42:51] <wikibugs>	 (03PS13) 10Jgleeson: UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg)
[13:57:33] <jgleeson>	 ok that's now passing
[13:57:57] <jgleeson>	 hmm lemme just get rid of that needless comment
[13:58:17] <wikibugs>	 (03PS14) 10Jgleeson: UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg)
[13:59:02] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] "No CI for release branches other than fundraising here." [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/898120 (owner: 10Jforrester)
[13:59:04] <wikibugs>	 (03CR) 10Jforrester: [V: 03+2 C: 03+2] build: Update MediaWiki requirement to 1.39.0 [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/898120 (owner: 10Jforrester)
[13:59:07] <wikibugs>	 (03CR) 10Jforrester: [V: 03+2 C: 03+2] "No CI for release branches other than fundraising here." [extensions/DonationInterface] (REL1_40) - 10https://gerrit.wikimedia.org/r/898288 (owner: 10Jforrester)
[14:15:22] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] build: Update MediaWiki requirement to 1.40.0 [extensions/CentralNotice] (REL1_40) - 10https://gerrit.wikimedia.org/r/898263 (owner: 10Jforrester)
[14:20:47] <wikibugs>	 (03Merged) 10jenkins-bot: build: Update MediaWiki requirement to 1.40.0 [extensions/CentralNotice] (REL1_40) - 10https://gerrit.wikimedia.org/r/898263 (owner: 10Jforrester)
[14:33:37] <wikibugs>	 (03CR) 10Jgleeson: [C: 04-1] "I'm not great with time math, but I think you need to flip the current India adjustment to add 5h30m and not subtract it, after the prenot" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg)
[14:41:06] <wikibugs>	 (03CR) 10Jgleeson: [C: 04-1] UPI donations queue consumer (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg)
[14:42:18] <wikibugs>	 (03CR) 10Jgleeson: [C: 04-1] "Other than those two small things already mentioned. I've tested this and it looks good to me!!! Nice work" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg)
[14:43:11] <jgleeson>	 back soon
[15:46:16] <wikibugs>	 (03PS9) 10Damilare Adedoyin: Refactor Dlocal API class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894053 (https://phabricator.wikimedia.org/T330425) (owner: 10Jgleeson)
[15:46:17] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe, 10FR-Email: Civi dedupe: automatically dedupe alternate family names - https://phabricator.wikimedia.org/T280696 (10AKanji-WMF) @XenoRyet In talking to @SHust  the team has been able to find a workaround! I think we're good to close...
[15:46:43] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Refactor Dlocal API class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894053 (https://phabricator.wikimedia.org/T330425) (owner: 10Jgleeson)
[15:49:20] <wikibugs>	 (03PS10) 10Damilare Adedoyin: Refactor Dlocal API class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/894053 (https://phabricator.wikimedia.org/T330425) (owner: 10Jgleeson)
[15:50:52] <jgleeson>	 today's album recommendation fr-tech is GTA: Vice City full soundtrack :) https://music.youtube.com/playlist?list=PLffQpMcmLcI-3REhsGllOcwoAsYrQ9bra&feature=share
[15:53:36] <wikibugs>	 10Fundraising Sprint Git Rebase Jump, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Dedupe - document for DS the various bits of handling that are in the dedupe code - https://phabricator.wikimedia.org/T276392 (10AKanji-WMF) @XenoRyet - in talking to @SHust seems like @Eileenmcn...
[16:08:54] <wikibugs>	 (03CR) 10Jgleeson: "Some late feedback on this one" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/895895 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan)
[16:11:02] <wikibugs>	 (03CR) 10Ejegg: "Thanks for the review, jgleeson! Responses inline." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg)
[16:12:34] <wikibugs>	 (03CR) 10Jgleeson: [C: 04-1] UPI donations queue consumer (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg)
[16:12:38] <ejegg>	 that's a heck of a soundtrack!
[16:12:53] <jgleeson>	 ejegg: the date math still sounds off to me
[16:13:39] <wfan>	 Thanks Andy and Jack for the review :)
[16:13:47] <jgleeson>	 if it's 4pm here now and it's 9:30pm in India. Shouldn't we be triggered the prenotification +1 month - 24hours at 9:30pm
[16:14:10] <jgleeson>	 so it's exactly 24h before the donors time
[16:14:28] <jgleeson>	 np wfan !
[16:14:43] <jgleeson>	 hmm actually after rubber ducking that sounds wrong
[16:15:05] <wikibugs>	 (03CR) 10Wfan: Add amount limitation for dlocal (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/895895 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan)
[16:15:14] <jgleeson>	 oh actually 
[16:15:37] <jgleeson>	 so a better example would be, it's 10pm here but in india it's the next day
[16:15:39] <ejegg>	 jgleeson: so let's see, we set the date stamp to India time when we do the initial charge. Say 4 pm here, 9:30 pm in india, we set the time of the start to 9:30 pm
[16:17:04] <jgleeson>	 ok so it's the crossing of midnight that's the problem I think
[16:17:18] <ejegg>	 ok, let's use your example, so we start the subscription in UTC time on the 2nd of the month at 10PM
[16:17:35] <ejegg>	 and we send the datestamp for the 3rd of the month at 3:30 AM
[16:17:44] <ejegg>	 (to dlocal)
[16:17:57] <ejegg>	 but to our queue, we send 2nd 10pm UTC
[16:18:27] <ejegg>	 so ok, maybe we don't need to do any more time zone adjustments at all in the new QC?
[16:18:32] <ejegg>	 just the one day for prenotification
[16:18:48] <ejegg>	 because we'll prenotify the next month on the 1st at 10pm UTC
[16:19:25] <ejegg>	 ahhh or will we?
[16:19:38] <ejegg>	 the date math in the scheduler truncates the hours
[16:20:02] <wikibugs>	 (03PS2) 10Wfan: Add amount limitation for dlocal certain payment method [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/898041 (https://phabricator.wikimedia.org/T324299)
[16:20:03] <ejegg>	 ok, so what we SHOULD do is prenotify the next month on the 1st at 10pm UTC
[16:20:22] <jgleeson>	 ejegg: I don't see the point in the current code where we move forward for the next month
[16:20:49] <ejegg>	 jgleeson ah right, that part is now just in the SmashPig extension
[16:21:09] <ejegg>	 I took that out of the new QC in the latest patch set
[16:21:21] <jgleeson>	 oh yeah that makes sense
[16:21:38] <ejegg>	 but even for the initial setup, I think we want to stick with the same UTC hour as we did the initial charge
[16:21:41] <jgleeson>	 but I'm not sure why we'd subtract 5h:30 at the start
[16:21:50] <ejegg>	 yeah, I'll take that out
[16:21:57] <ejegg>	 and just advance the one day for prenotification
[16:21:59] <jgleeson>	 hang on
[16:22:05] <jgleeson>	 I think there is a gotcha here
[16:22:13] <ejegg>	 the hour truncation?
[16:22:45] <jgleeson>	 let's ignore the prenotificaton adjustment for now it confuses things
[16:22:52] <jgleeson>	 lemme sound this out
[16:23:06] <jgleeson>	 so I'm in india and it's 2:30am on the 15th
[16:23:25] <wikibugs>	 (03PS6) 10Wfan: Add recurring amount validation to DI level for dlocal IN bt recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895731 (https://phabricator.wikimedia.org/T324299)
[16:23:40] <jgleeson>	 I subscribe to a monthly donation which looks like the 14th @ 10pm UTC 
[16:24:27] <jgleeson>	 our systems either subtract 5h:30m (or leave alone), then move the next_sched_date +1 month
[16:25:38] <jgleeson>	 that means my expected payment date is theoretically earlier on the 14th keeping it on the and not the 15th
[16:25:49] <jgleeson>	 (with the subtraction)
[16:26:09] <jgleeson>	 if we leave it alone, yeah, I think it stays the 15th
[16:27:37] <ejegg>	 ok, yeah, so we shouldn't adjust the 5:30
[16:27:51] <jgleeson>	 oh but it's the message to dlocal that needs to be India time right?
[16:27:53] <ejegg>	 but let's also try to keep it at the same hour rather than setting it to midnight UTC
[16:28:09] <ejegg>	 jgleeson: yep, that message time is being adjusted in the SmashPig code
[16:28:22] <jgleeson>	 lemme check that
[16:28:30] <wikibugs>	 (03CR) 10Wfan: Add recurring amount validation to DI level for dlocal IN bt recurring (032 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895731 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan)
[16:28:32] <ejegg>	 does the prenotification need a time too?
[16:28:34] <wikibugs>	 (03PS7) 10Wfan: Add recurring amount validation to DI level for dlocal IN bt recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895731 (https://phabricator.wikimedia.org/T324299)
[16:37:59] <jgleeson>	 OK ejegg I see it! https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/f410adc229ca18441bac9cdcdb1b22bffdd909e7/PaymentProviders/dlocal/Api.php#L402
[16:38:12] <jgleeson>	 so we are moving the date to the future
[16:38:19] <jgleeson>	 or to India Time
[16:39:08] <jgleeson>	 so now I think you are right to subtract 5h30m FROM that if that's what your patch is doing
[16:39:46] <jgleeson>	 I'll add the time adjustment detail to the sequence diagram 
[16:39:50] <jgleeson>	 in payments
[16:40:10] <ejegg>	 jgleeson: so that date adjustment only applies to that one API call, not to the date we send to the queue
[16:40:49] <ejegg>	 I think the queue date should stay as is
[16:41:07] <jgleeson>	 do we not want to use that date as the anchor point
[16:41:34] <jgleeson>	 I guess it looks like with ONDEMAND we don't really need to 
[16:41:58] <ejegg>	 right, we have some wiggle room, but it would be nice to get it right if we have to go to monthly for whatever reason
[16:42:03] <jgleeson>	 but if it's stricter with RECURRING we might need to to make sure all future dates work from that
[16:42:58] <ejegg>	 yeah yeah, so we should ideally send the prenotification at the same time UTC as the initial setup (just one day earlier in the month)
[16:44:04] <ejegg>	 (however all of this is a bit moot since we have a zillion things with next_sched_date of midnight that take us until late morning to get to because of the backlog)
[16:46:15] <wikibugs>	 (03PS15) 10Ejegg: UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724)
[16:46:32] <ejegg>	 OK, that has the extra 5:30 adjustment removed ^^^
[16:46:32] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg)
[16:46:38] <ejegg>	 oops
[16:46:49] <ejegg>	 oh dang, needs rebase
[16:47:14] <jgleeson>	 ejegg: I pushed up some changes so you might need to rebase over that patches latest
[16:47:40] <ejegg>	 oh i see, that test fix
[16:47:58] <ejegg>	 yeah, i had rolled that in to mine just to pass, but it's cleaner separate
[16:48:15] <wikibugs>	 (03PS16) 10Ejegg: UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724)
[16:48:19] <jgleeson>	 you'd already done that?
[16:48:30] <jgleeson>	 (test fixeS)
[16:48:33] <ejegg>	 it was in PS15, but I just took it out
[16:48:42] <ejegg>	 and rebased over your fix
[16:48:48] <jgleeson>	 ah ok
[16:49:12] <jgleeson>	 sorry it was failing on CI today so I figured it would be quicker to just add it
[16:49:21] <jgleeson>	 whilst the US was in bed
[16:50:09] <jgleeson>	 hmm I don't see the test fix in PS16 ejegg 
[16:50:31] <jgleeson>	 I'm not talking about the source headers btw
[16:51:09] <jgleeson>	 I'm talking about this one https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/895897/12..14/drupal/sites/default/civicrm/extensions/wmf-civicrm/tests/phpunit/Civi/Queue/UpiDonationsQueueConsumerTest.php
[16:52:37] <ejegg>	 no, you were totally right to do it as a separate patch!
[16:52:54] <ejegg>	 I just rolled it in yesterday cause I was in a rush
[16:53:01] <ejegg>	 so after yours merged I took it back out
[16:53:02] <jgleeson>	 it's on the same patch
[16:53:22] <jgleeson>	 are we talking about the same thing. the test data clean up?
[16:53:35] <jgleeson>	 deleting contact/token/recur records added by the test?
[16:53:53] <ejegg>	 ohh, that should happen with the TransactionalInterface
[16:54:32] <ejegg>	 Hmm, or does that not work because we have some of our own transactional code somewhere committing things?
[16:54:57] <jgleeson>	 https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm-docker/9469/console
[16:54:58] <ejegg>	 no, I was talking about the unrelated fix to your code in the SmashPig extension
[16:55:13] <jgleeson>	 that's the CI failure from before that text fix
[16:55:15] <ejegg>	 so I'll redo that rebase 
[16:55:18] <ejegg>	 based on PS14
[16:55:43] <jgleeson>	 it was trying to send failmail due to being unable to create a record due to a unique key I think
[16:55:56] <jgleeson>	 I recreated it locally and clearing out the test data in teardown fixed it
[16:58:24] <jgleeson>	 *  - With TransactionalInterface, any data changes made by setUp() or test****() functions will
[16:58:26] <jgleeson>	  *    rollback automatically
[16:58:50] <ejegg>	 i'll just reorder those deletes
[16:58:53] <jgleeson>	 I wonder if it's because the test was creating the records and they weren't added in the pre/post methods 
[16:59:15] <ejegg>	 hmm, but it says test**** methods too
[16:59:28] <jgleeson>	 oh yeah you're right
[16:59:51] <jgleeson>	 maybe checkout PS11 and try it locally
[17:00:01] <wikibugs>	 (03PS17) 10Ejegg: UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724)
[17:00:04] <jgleeson>	 sorry, PS12
[17:00:17] <ejegg>	 oh right, now I want to get rid of the extra 5:30 again
[17:00:25] <jgleeson>	 it was failing on CI, after rebasing over the fiscal number fix
[17:01:20] <wikibugs>	 (03PS18) 10Ejegg: UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724)
[17:01:34] <ejegg>	 ok, let's see if that works
[17:02:06] <ejegg>	 I guess the extra deletes can't hurt
[17:02:20] <jgleeson>	 I'm curious now. try them without
[17:03:13] <jgleeson>	 I'll pull down that patch and comment out the $this->deleteTestData()
[17:03:23] <ejegg>	 it was working locally without them when I pushed it up last night
[17:03:34] <ejegg>	 no idea why it failed on CI
[17:04:16] <ejegg>	 yeah, i'll comment that out too and see if PS18 passes locally without
[17:04:48] <ejegg>	 actually I was only running the tests filtered to that one file locally
[17:05:13] <ejegg>	 running them all this time
[17:06:08] <jgleeson>	 they fail for me without it
[17:06:37] <jgleeson>	 ejegg: https://phabricator.wikimedia.org/F36911365
[17:06:55] <ejegg>	 k, let's leave it in
[17:07:05] <ejegg>	 too bad that TransactionInterface doesn't work - that would be nice
[17:07:09] <jgleeson>	 got me curious why the transaction thing doesn't work
[17:07:12] <jgleeson>	 yeah
[17:07:21] <ejegg>	 heh, that's a rabbit hole for another day
[17:09:22] <jgleeson>	 indeed
[17:10:20] <jgleeson>	 wfan: thanks for the review btw!
[17:10:43] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.40-notes (1.40.0-wmf.27; 2023-03-13): CentralNotice banners being shown too many times - https://phabricator.wikimedia.org/T331671 (10AndyRussG) >>! In T331671#8690787, @DerHexer wrote: > Thanks @AndyRussG...
[17:14:43] <wfan>	 Actually I am a bit confused, since Mandatory for Wallets in India so is city, so from donor relation's perspective, we want less info from donor to make them easy to donate. so our wikimedia's phone number is good enough? Let's confirm this tomorrow's meeting. Also since I see the error by manually update the url param to get india cc recurring, should we prevent this kind of param update, or return some error as we did for amount?
[17:15:01] <wikibugs>	 (03CR) 10Jgleeson: Add amount limitation for dlocal (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/895895 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan)
[17:16:21] <jgleeson>	 wfan: we should email on that asap I think
[17:16:43] <jgleeson>	 if we need a real phone number with an Indian area code to sending to PayTM then the WMF number might not cut it
[17:17:39] <wfan>	 UPI bt recurring do not need phone at this phase, this is trigger by the cc payment, not limit to paytm
[17:18:04] <wfan>	 https://localhost:9001/index.php?title=Special:DlocalGateway&appeal=JimmyQuote&payment_method=cc&recurring=1&uselang=en&language=en&currency=INR&amount=5005&country=IN&first_name=Jimmy&last_name=Wales&fiscal_number=AAAAA9999C&email=jwales%40example.com&debug=true 
[17:18:22] <wfan>	 I will write a email to Sebastian then~
[17:18:26] <AndyRussG>	 ah I see wfan thanks!
[17:19:19] <AndyRussG>	 right, if we can confirm that it doesn't have to be the real city or the real phone number, then I think that's great!
[17:20:30] <AndyRussG>	 I guess also we need to ask about whether we need to store the PAN document number (fiscal number) and use that when we charge recurring? since the messaging on the form now says it's optional and never stored
[17:21:21] <wfan>	 Ok, if fiscal number is not needed, then we can have lesser info shown on the form.
[17:21:58] <AndyRussG>	 wfan: the message said we're required to request it, so I think we still need it on the form? but it also says it's optional and never stored
[17:22:21] <jgleeson>	 hmm I found something in the docs about them needing either a real phone number or email
[17:22:25] <AndyRussG>	 no idea how accurate the message is on any of those points
[17:23:08] <jgleeson>	 https://docs.dlocal.com/docs/india-payouts#mandatory-parameters---bank-transfer-and-upi-address
[17:23:13] <AndyRussG>	 hmmm also I wonder if an inaccurate phone number and city might increase false positives on dlocal's internal fraud scoring?
[17:23:18] <wfan>	 yeah if never store we can mock it too, but I see cpf needs to be new after many tried, otherwise got an error as blocked user
[17:23:39] <jgleeson>	 wfan: it looks like the email might be enough https://docs.dlocal.com/docs/india-payouts#mandatory-parameters---paytm-wallet-transfer
[17:23:54] <jgleeson>	 depending on how they are registered 
[17:24:22] <ejegg>	 oh jeez, so we can't really validate that well on our side
[17:24:34] <ejegg>	 I guess we always want email
[17:24:51] <wfan>	 yeah we needs email for civi 
[17:25:01] <jgleeson>	 yeah I'm guessing we've been getting away with it in sandbox 
[17:25:06] <AndyRussG>	 "If the user is register with email, phone is not mandatory" registered on their end, when they registered with payTM, no?
[17:25:07] <jgleeson>	 but things might be stricter in prod
[17:25:24] <ejegg>	 but we have to add a phone field now and explain that it's just for the case when they registered for PayTM with a phone number
[17:25:39] <AndyRussG>	  so there may well be users who registered their PayTM wallet with the phone number, so we need to send their real phone number
[17:25:42] <ejegg>	 (even though they clicked a UPI icon to get to the form, not a PayTM icon)
[17:25:43] <AndyRussG>	 ejegg: yeah sounds right?
[17:26:08] <ejegg>	 just going to be some confusing messaging to bring PayTM into it
[17:26:21] <jgleeson>	 yeah we should ask Sebastian to confirm 
[17:26:23] <AndyRussG>	 hmmm I'm already confused
[17:26:28] <jgleeson>	 but it looks like we might need it
[17:26:39] <AndyRussG>	 yeah some extra banner/donate wiki logic will be important too
[17:26:47] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Civi: restore Find Matches using Fishing Net to pre-September update - https://phabricator.wikimedia.org/T232534 (10SHust) This issue has been solved, the ticket can be closed. TY!
[17:27:28] <jgleeson>	 hmmm yeah ejegg I guess the user might not even be expecting to see payTM
[17:27:49] <jgleeson>	 there's no PayTM branding on the form
[17:28:50] <jgleeson>	 ejegg: is the UPI consumer ready for another pass?
[17:29:02] <jgleeson>	 we've got 2 hours before retro
[17:29:08] <wfan>	 Also, I forgot that we can only do india recurring via IR, that https://docs.dlocal.com/docs/india#alternative-payment-method, so probably no needs to ask this question only needs to return error message if other payment methods want to do recurring?
[17:29:31] <jgleeson>	 so it would be good to get what we need for today merged before then?
[17:29:39] <jgleeson>	 and maybe deploy afterwards
[17:32:01] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Dedupe exception search field keeps adding the text "test" to searches - https://phabricator.wikimedia.org/T225670 (10SHust) This issue still remains.
[17:32:40] <wfan>	 So the test link I manually updated should get error and prevent the continue button. and then we can use our current form (default city, no phone) to process to next step
[17:33:17] <wfan>	 but still, the ondemand still get rejected immediately~
[17:34:00] <ejegg>	 jgleeson|brb: yep the UPI stuff is ready for review
[17:34:36] <ejegg>	 wfan we don't usually worry about people manually manipulating the URL
[17:35:05] <ejegg>	 we generally rely on the donatewiki form or the banners to offer recurring only when it's available
[17:36:03] <wfan>	 ejegg: ok, if so then I can actually abandon the patch, since no needs to check upi, as long as it's recurring india, it's ir, and then if cc is not allowed, the phone is not needed based on our test before.
[17:36:20] <ejegg>	 ok, great
[17:36:49] <wikibugs>	 (03Abandoned) 10Wfan: Only convert to subscription if upi, only set wiki phone as default for india cc [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/898234 (https://phabricator.wikimedia.org/T324298) (owner: 10Wfan)
[17:36:51] <ejegg>	 so let's see, is there anything else we need to merge in smashpig?
[17:37:27] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Fail mails on dedupe job - https://phabricator.wikimedia.org/T226345 (10SHust) No longer an issue, ok to solve this ticket. TY! @AKanji-WMF
[17:37:28] <ejegg>	 or should we focus on the DonationInterface stuff now?
[17:45:18] <wikibugs>	 10Fundraising-Backlog, 10FR-Civi-Dedupe, 10Fr-CiviCRM-dedupe-FY2017/18: Civi dedupe: make sure Endowment contribs display in merge interface - https://phabricator.wikimedia.org/T227596 (10SHust) The issue has already been solved, this ticket can be closed. TY! @AKanji-WMF
[17:48:52] <jgleeson>	 ejegg: fr-tech, let's track our todo list for the deployment https://etherpad.wikimedia.org/p/dlocal-deployment-todo
[17:48:55] <wikibugs>	 10Fundraising-Backlog, 10FR-Civi-Dedupe, 10Fr-CiviCRM-dedupe-FY2017/18: Civi: deduper shows too few results sometimes - https://phabricator.wikimedia.org/T230079 (10SHust) This issue has been solved, the ticket can be closed. @AKanji-WMF
[17:50:27] <jgleeson>	 I added some initial categories 
[17:55:05] <jgleeson>	 wfan: I guess we need this before going live right? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/895731/
[17:55:26] <wfan>	 yes
[17:55:36] <wfan>	 this is prevent more than 5000k for recurring
[17:56:25] <jgleeson>	 thanks. just added it 
[17:56:30] <cstone>	 wfan: I thnk that tiny patch I missed it tied to the cz monthly convert patch
[17:56:32] <jgleeson>	 I was also reviewing that
[17:56:46] <jgleeson>	 and noticed the recurring_only thing
[17:56:51] <jgleeson>	 thanks for updating that
[17:57:03] <wfan>	 np thanks for the review 
[17:57:46] <wfan>	 cstone: the tiny patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/898041 is this one 
[17:58:00] <wikibugs>	 (03PS3) 10Wfan: Add amount limitation for dlocal certain payment method [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/898041 (https://phabricator.wikimedia.org/T324299)
[17:58:15] <wfan>	 cstone: no it rebased to master
[17:58:27] <cstone>	 ahh okay its dev i guess its fine if its stacked on the cz one
[17:59:45] <cstone>	 oh did you update it or is gerrit being weird for me
[18:00:10] <jgleeson>	 ejegg: re: merging in smashpig. I think we'll need to mrge the recurring extension stuff we added yesterday
[18:00:40] <ejegg>	 jgleeson: in the crm codebase, right?
[18:00:55] <jgleeson>	 sorry
[18:01:00] <jgleeson>	 yeah that is not smashpig
[18:01:02] <jgleeson>	 my bad
[18:01:08] <jgleeson>	 crm*
[18:01:17] <ejegg>	 ok, cool
[18:01:39] <ejegg>	 as soon as the UPI queue patch merges I'll deploy civi then
[18:05:57] <wikibugs>	 (03CR) 10Ejegg: "Maybe better in the dlocal_gateway? That's the only place we'll be using this when astropay_gateway goes away. This is really only needed " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/897901 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG)
[18:06:22] <ejegg>	 i feel like we might need a DonationInterfae patch to avoid sending the recurring UPI message from the front end
[18:06:37] <ejegg>	 (or we will when they fix the redirect back to us to use the standard parameters
[18:08:15] <cstone>	 oh yeah did we never make a ticket for that? the ideal code has an if where it skips the queue if we are waiting for the token
[18:09:14] <greg-g>	 is the dlocal test infra still returning rejected or is it working again?
[18:09:17] <jgleeson>	 yeah good call ejegg 
[18:09:45] <wikibugs>	 (03CR) 10Ejegg: [C: 04-1] "So we need to be able to accomodate one rule for india-non-recurring and another rule for india-recurring. I think we'll need a different " [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/898041 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan)
[18:09:59] <greg-g>	 s/testing/staging/
[18:10:02] <jgleeson>	 still failing for me greg-g 
[18:10:09] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] build: Update MediaWiki requirement to 1.39.0 [extensions/LandingCheck] (REL1_39) - 10https://gerrit.wikimedia.org/r/898154 (owner: 10Jforrester)
[18:10:39] <jgleeson>	 still being rejected that is
[18:10:45] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] build: Update MediaWiki requirement to 1.39.0 [extensions/FundraiserLandingPage] (REL1_39) - 10https://gerrit.wikimedia.org/r/898135 (owner: 10Jforrester)
[18:10:46] <wfan>	 ejegg: there is no limit for india-non-recurring, but I see what you mean
[18:11:00] <greg-g>	 jgleeson: thanks, just let Evelyn know in the office hours call
[18:11:14] <jgleeson>	 we're tracking that here greg-g https://etherpad.wikimedia.org/p/dlocal-deployment-todo
[18:11:22] <greg-g>	 thanks!
[18:11:54] <wikibugs>	 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-dlocal: Plan dLocal testing rollout - https://phabricator.wikimedia.org/T330801 (10jgleeson) tracking this here https://etherpad.wikimedia.org/p/dlocal-deployment-todo
[18:13:40] <wikibugs>	 (03Merged) 10jenkins-bot: build: Update MediaWiki requirement to 1.39.0 [extensions/LandingCheck] (REL1_39) - 10https://gerrit.wikimedia.org/r/898154 (owner: 10Jforrester)
[18:14:13] <wikibugs>	 (03Merged) 10jenkins-bot: build: Update MediaWiki requirement to 1.39.0 [extensions/FundraiserLandingPage] (REL1_39) - 10https://gerrit.wikimedia.org/r/898135 (owner: 10Jforrester)
[18:15:44] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "This looks good to me! let's give it a whirl. thanks for all the work on it." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg)
[18:18:24] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.40-notes (1.40.0-wmf.27; 2023-03-13): CentralNotice banners being shown too many times - https://phabricator.wikimedia.org/T331671 (10DerHexer) @AndyRussG Thanks for the helpful explanations! :) Do you have...
[18:23:59] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] build: Update MediaWiki requirement to 1.39.0 [extensions/CentralNotice] (REL1_39) - 10https://gerrit.wikimedia.org/r/898105 (owner: 10Jforrester)
[18:26:31] <ejegg>	 thanks jgleeson !
[18:27:00] <ejegg>	 wfan oh I thought we had a lower limit for india transactions
[18:27:33] <ejegg>	 yep, max 225000 INR
[18:27:39] <ejegg>	 in the settings folder on frpm
[18:28:21] <ejegg>	 So let's make the amount rules just as flexible as the gateway chooser rules
[18:28:57] <ejegg>	 I'll put up a proposed format
[18:29:15] <jgleeson>	 np
[18:29:32] <wfan>	 ejegg: ok thanks
[18:29:46] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] build: Update MediaWiki requirement to 1.39.0 [extensions/FundraisingTranslateWorkflow] (REL1_39) - 10https://gerrit.wikimedia.org/r/898136 (owner: 10Jforrester)
[18:29:58] <wikibugs>	 (03Merged) 10jenkins-bot: build: Update MediaWiki requirement to 1.39.0 [extensions/CentralNotice] (REL1_39) - 10https://gerrit.wikimedia.org/r/898105 (owner: 10Jforrester)
[18:30:59] <wikibugs>	 (03Merged) 10jenkins-bot: UPI donations queue consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895897 (https://phabricator.wikimedia.org/T330724) (owner: 10Ejegg)
[18:32:09] <wikibugs>	 10Fundraising-Backlog, 10FR-Civi-Dedupe, 10Fr-CiviCRM-dedupe-FY2017/18: Civi: deduper shows too few results sometimes - https://phabricator.wikimedia.org/T230079 (10Eileenmcnaughton) 05Open→03Resolved a:03Eileenmcnaughton
[18:34:43] <wikibugs>	 (03PS1) 10Ejegg: Proposed extended format for donation_rules [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/898827
[18:34:55] <ejegg>	 ok wfan, how does that look? ^^
[18:35:28] <ejegg>	 that should also accommodate for example different min and max for different payment_method
[18:35:55] <ejegg>	 I'mma just prep the CRM deploy now
[18:38:52] <wfan>	 ejegg: ah ok will update this way
[18:39:39] <wikibugs>	 (03PS1) 10Ejegg: Update libraries [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/898828
[18:39:41] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Update libraries [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/898828 (owner: 10Ejegg)
[18:40:03] <wikibugs>	 (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/898829
[18:40:29] <wikibugs>	 (03PS2) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/898829
[18:41:11] <jgleeson>	 ejegg: does step 17 look right to you now? https://phab.wmfusercontent.org/file/data/k2vh4sqvrmzuqpbvbt7p/PHID-FILE-zkxsammhqzo5blz2kkyq/india-recurring-active.png
[18:41:20] <ejegg>	 hmm, should we deploy a temporary workaround for the donors coming back from India Recurring with bad redirect params?
[18:41:32] <jgleeson>	 maybe ejegg 
[18:41:41] <jgleeson>	 dead session behaviour?
[18:41:46] <ejegg>	 yep jgleeson that's good
[18:42:07] <ejegg>	 jgleeson: just sending 'em directly to the TY page, right?
[18:42:13] <jgleeson>	 ya
[18:42:22] <ejegg>	 sure, I'll code that up quick
[18:46:16] <wikibugs>	 (03Merged) 10jenkins-bot: build: Update MediaWiki requirement to 1.39.0 [extensions/FundraisingTranslateWorkflow] (REL1_39) - 10https://gerrit.wikimedia.org/r/898136 (owner: 10Jforrester)
[18:51:29] <jgleeson>	 retrowave bomb - https://www.youtube.com/watch?v=JQqFeCCuwW0
[18:52:59] <jgleeson>	 right sorry wfan I'll try and finish review on your patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/895731/
[18:53:18] <jgleeson>	 also I see cstone is already reviewing it but I figure the more eyes the better
[18:53:49] <cstone>	 oh whoops jgleeson i got distracted trying to add in that catch for recurring in DI 
[18:54:10] <wikibugs>	 (03Merged) 10jenkins-bot: Update libraries [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/898828 (owner: 10Ejegg)
[18:55:21] <wikibugs>	 (03PS1) 10Ejegg: Workaround for UPI recurring return values [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/898834
[18:55:52] <ejegg>	 jgleeson: cstone: I suggested a different format for wfan's amount validation, since we still need to apply a different India-specific min/max to non-recurring donations
[18:56:11] <ejegg>	 so maybe hold off on that review till she's got a new PS up
[18:56:30] <cstone>	 oh and ejegg ahead of me on that catch too
[18:56:32] <ejegg>	 cstone: ohhh were you doing something for the bad return values too?
[18:56:36] <cstone>	 no worries
[18:56:40] <ejegg>	 sorry, I should have read more backscroll
[18:56:51] <cstone>	 nah its fine
[18:57:43] <ejegg>	 so... that monthly/ondemand thing is ugh
[18:57:58] <cstone>	 I can just test yours ejegg hah
[18:58:01] <ejegg>	 i really don't want to tag another smashpig version just to temporarily work around and send the other value
[18:58:15] <ejegg>	 but I guess if we want to demo UPI we need to
[19:00:14] <jgleeson>	 :(
[19:00:32] <ejegg>	 ah dang, meeting time
[19:00:39] <jgleeson>	 ok I'll hold off on the other patch
[19:00:44] <jgleeson>	  already!
[19:00:54] <jgleeson>	 did time move forward again?!?1
[19:01:01] <ejegg>	 jgleeson: in the US yes
[19:01:04] <cstone>	 on sunday yeah
[19:01:10] <jgleeson>	 sorry that was a bad joke
[19:01:14] <jgleeson>	 I meant again, again
[19:01:16] <jgleeson>	 :)
[19:01:36] <ejegg>	 it just keep on slippin towards the future!
[19:01:41] <ejegg>	 *keeps
[19:02:25] <ejegg>	 ah even that's not quite right
[19:02:55] <ejegg>	 time keeps on slippin' slippin' slippin' INTO the future
[19:02:58] <greg-g>	 slippin, slippin, slippin, into the fuuuturrre
[19:03:05] <greg-g>	 :)
[19:04:31] <dwisehaupt>	 /ac/ac
[19:06:00] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/898829 (owner: 10Ejegg)
[19:07:20] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/898829 (owner: 10Ejegg)
[19:08:42] <wikibugs>	 (03CR) 10AndyRussG: Move PlaceholderFiscalNumber to gateway_common (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/897901 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG)
[19:10:25] <wikibugs>	 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-dlocal, and 3 others: Support DLocal recurring cards in DonationInterface - https://phabricator.wikimedia.org/T324297 (10XenoRyet) 05Open→03Resolved
[19:10:27] <wikibugs>	 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet)
[19:10:33] <wikibugs>	 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-dlocal: Investigate why new dLocal REDIRECT payments are falling into the "dead session" category - https://phabricator.wikimedia.org/T330308 (10XenoRyet) 05Open→03Resolved
[19:11:43] <wikibugs>	 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Missing primary address fields in Search Kit - https://phabricator.wikimedia.org/T330700 (10XenoRyet) 05Open→03Resolved
[19:12:04] <wikibugs>	 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-dlocal: Refactor the current dLocal StatusNormalizers. - https://phabricator.wikimedia.org/T329838 (10XenoRyet) 05Open→03Resolved
[19:12:47] <wikibugs>	 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet)
[19:12:50] <wikibugs>	 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint Everything I Merge I Merge For You, and 3 others: Handle IPNs from DLocal payins - https://phabricator.wikimedia.org/T324293 (10XenoRyet) 05Open→03Re...
[19:13:09] <ejegg>	 !log civicrm upgraded from dbe3b716 to 68fa85cf
[19:13:12] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[19:22:37] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Batch deduping not working in legacy merge ui - error about q - https://phabricator.wikimedia.org/T243474 (10SHust) Issue resolved, this ticket can be closed. @AKanji-WMF
[19:24:25] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Citibank Individuals Import not working - https://phabricator.wikimedia.org/T331139 (10XenoRyet) 05Open→03Resolved
[19:25:07] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe, 10fr-donorservices: Civi: enable all DS agents to delete smart groups - https://phabricator.wikimedia.org/T249153 (10SHust) This request is no longer relevant. This ticket can be closed. @AKanji-WMF
[19:25:14] <wikibugs>	 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Create a new activity type for thank-yous - https://phabricator.wikimedia.org/T332071 (10Eileenmcnaughton)
[19:26:24] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: implement the links hook to alter the links available for our new activity types - https://phabricator.wikimedia.org/T332072 (10Eileenmcnaughton)
[19:26:33] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: implement the links hook to alter the links available for our new activity types - https://phabricator.wikimedia.org/T332072 (10Eileenmcnaughton)
[19:26:48] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: implement the links hook to alter the links available for our new activity types - https://phabricator.wikimedia.org/T332072 (10Eileenmcnaughton)
[19:27:12] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-BigBundle, 10FR-Civi-Dedupe: Domain task - script fix to bulk update emails from Belgium - https://phabricator.wikimedia.org/T250320 (10SHust) This is no longer needed. This ticket can be closed. TY! @AKanji-WMF
[19:27:33] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Update our code to use the new activity type for thank yous - https://phabricator.wikimedia.org/T332073 (10Eileenmcnaughton)
[19:27:38] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Update SmashPig currency rates - https://phabricator.wikimedia.org/T326671 (10XenoRyet) 05Open→03Resolved
[19:28:06] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Add check to pending transaction resolver to not resolve more than one donation per donor per run - https://phabricator.wikimedia.org/T326361 (10XenoRyet) 05Open→03Resolved
[19:28:29] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Update SmashPig currency rates - https://phabricator.wikimedia.org/T326671 (10XenoRyet)
[19:28:31] <wikibugs>	 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Update triggers to not save details for thank you letters - https://phabricator.wikimedia.org/T332074 (10Eileenmcnaughton)
[19:28:43] <wikibugs>	 10Wikimedia-Fundraising-CiviCRM: Update triggers to not save details for thank you letters - https://phabricator.wikimedia.org/T332074 (10Eileenmcnaughton)
[19:29:52] <wikibugs>	 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Try creating a new activity_type_id for Thank yous & see if the UI is still fine - if so switch - https://phabricator.wikimedia.org/T327963 (10XenoRyet) 05Open→03Resolved
[19:34:56] <wikibugs>	 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Create a new activity type for thank-yous - https://phabricator.wikimedia.org/T332071 (10Eileenmcnaughton) 05Open→03Resolved
[19:34:59] <wikibugs>	 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Try creating a new activity_type_id for Thank yous & see if the UI is still fine - if so switch - https://phabricator.wikimedia.org/T327963 (10Eileenmcnaughton)
[19:36:02] <wikibugs>	 (03PS8) 10Wfan: Add recurring amount validation to DI level for dlocal IN bt recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895731 (https://phabricator.wikimedia.org/T324299)
[19:39:53] <wikibugs>	 (03PS9) 10Wfan: Add recurring amount validation to DI level for dlocal IN bt recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895731 (https://phabricator.wikimedia.org/T324299)
[19:41:21] <wikibugs>	 (03PS4) 10Wfan: Add condition for dlocal donation rules [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/898041 (https://phabricator.wikimedia.org/T324299)
[19:41:31] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Add recurring amount validation to DI level for dlocal IN bt recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895731 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan)
[19:41:48] <wikibugs>	 (03PS5) 10Wfan: Add condition for dlocal donation rules [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/898041 (https://phabricator.wikimedia.org/T324299)
[19:44:07] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe, 10FR-Email: Civi dedupe: automatically dedupe alternate family names - https://phabricator.wikimedia.org/T280696 (10SHust) Looking at this again, the JP doc shared by David would be a great addition to an automated script, should thi...
[19:48:38] <wikibugs>	 (03PS10) 10Wfan: Add recurring amount validation to DI level for dlocal IN bt recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895731 (https://phabricator.wikimedia.org/T324299)
[19:52:00] <wikibugs>	 (03CR) 10Wfan: [C: 04-1] "Maybe we can abandon this patch and use this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/898041" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/898827 (owner: 10Ejegg)
[19:57:27] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Dedupe resolvable conflict  resolve misspellings where email disambiguates - https://phabricator.wikimedia.org/T242303 (10SHust) I believe this issue has already been addressed!
[19:58:47] <wikibugs>	 10Fundraising Sprint F 2023, 10Fundraising-Backlog, 10Patch-For-Review: Please turn on Monthly Convert in Czech (csCZ) - https://phabricator.wikimedia.org/T331665 (10AKanji-WMF)
[20:01:39] <wikibugs>	 (03CR) 10Ejegg: "sounds good wfan, will abandon" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/898827 (owner: 10Ejegg)
[20:01:49] <wikibugs>	 (03Abandoned) 10Ejegg: Proposed extended format for donation_rules [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/898827 (owner: 10Ejegg)
[20:20:51] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Recurring-Donations, 10fr-donorservices: Ingenico recurrings stopped at status 600 March 5th - https://phabricator.wikimedia.org/T331490 (10MBeat33) Nothing similar at Ingenico between Mar 8-14, but I will monitor periodically.
[20:25:56] <wikibugs>	 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint Everything I Merge I Merge For You, and 3 others: Handle IPNs from DLocal payins - https://phabricator.wikimedia.org/T324293 (10XenoRyet)
[20:26:18] <wikibugs>	 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal, 10Patch-For-Review: Handle recurring IPNs for Dlocal - https://phabricator.wikimedia.org/T330724 (10XenoRyet) 05Open→03Resolved
[20:32:01] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: implement the links hook to alter the links available for our new activity types - https://phabricator.wikimedia.org/T332072 (10Eileenmcnaughton) a:05jgleeson→03None
[20:42:44] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Ensure caches, include smarty, are flushed when message templates are edited - https://phabricator.wikimedia.org/T325694 (10Cstone) Would be fixed as a part of {T325698}
[20:43:27] <ejegg>	 !log payments-wiki upgraded from 61c30a4f to 1532b107
[20:43:29] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[20:43:57] <wikibugs>	 10Fundraising Sprint Amazing grep, 10Fundraising Sprint F 2023, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Decommission `civi-data-translate` extension - https://phabricator.wikimedia.org/T325698 (10AKanji-WMF)
[20:55:14] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Update triggers to not save details for thank you letters - https://phabricator.wikimedia.org/T332074 (10Eileenmcnaughton)
[20:55:38] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Update triggers to not save details for thank you letters - https://phabricator.wikimedia.org/T332074 (10Eileenmcnaughton) a:05jgleeson→03None
[20:56:02] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Update our code to use the new activity type for thank yous - https://phabricator.wikimedia.org/T332073 (10Eileenmcnaughton) a:05jgleeson→03None
[21:05:31] <wikibugs>	 10Fundraising Sprint F 2023, 10Fundraising-Backlog, 10FR-dlocal: DLocal sandbox/production account setup - https://phabricator.wikimedia.org/T324499 (10AKanji-WMF)
[21:07:08] <wikibugs>	 10Fundraising Sprint F 2023, 10Fundraising-Backlog, 10FR-dlocal: DLocal Audit - Test with new integration - https://phabricator.wikimedia.org/T324347 (10AKanji-WMF)
[21:08:34] <wikibugs>	 10Fundraising-Backlog, 10FR-India, 10FR-dlocal, 10Recurring-Donations: Support India Network Tokenization (recurring credit cards) for DLocal - https://phabricator.wikimedia.org/T324304 (10XenoRyet) 05Open→03Declined
[21:08:36] <wikibugs>	 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet)
[21:14:51] <wikibugs>	 10Fundraising Sprint F 2023, 10Fundraising-Backlog: Ingenico/Worldline addition of Initial Scheme Transaction ID to avoid recurring declines - https://phabricator.wikimedia.org/T331754 (10XenoRyet)
[21:14:54] <wikibugs>	 10Fundraising Sprint F 2023, 10Fundraising-Backlog, 10FR-dlocal: Document the dLocal UPI Recurring for the sake of our future selves. - https://phabricator.wikimedia.org/T331717 (10XenoRyet)
[21:15:00] <wikibugs>	 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising Sprint F 2023, 10Fundraising-Backlog, 10FR-dlocal: Create UML diagrams for dLocal India Recurring - https://phabricator.wikimedia.org/T331555 (10XenoRyet)
[21:15:04] <wikibugs>	 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising Sprint F 2023, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Add UPI donations queue consumer - https://phabricator.wikimedia.org/T331851 (10XenoRyet)
[21:18:46] <wfan>	 fr-tech happy pi day today
[21:19:08] <AndyRussG>	 ahh yes thanks wfan! same :)
[21:19:26] <AndyRussG>	 I should make a pie for my kids tomorrow
[21:19:34] <jgleeson>	 :)
[21:19:54] <cstone>	 wfan: happy 🥧
[21:20:08] <cstone>	 hah that turned from a slice when typing to a full pie
[21:21:00] <wfan>	 I got one from MC, blueberry and cream pie tasty
[21:42:27] <wfan>	 btw the amount ready for review again based on elliott's suggestion, they are https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/898041 & https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/895731~
[21:42:52] <ejegg>	 thanks wfan, looking
[22:05:51] <ejegg>	 wfan I just made it: https://phabricator.wikimedia.org/T332091
[22:06:22] <wfan>	 thx, are we going to have tech talk today?
[22:06:29] <ejegg>	 hah, wikibugs banned from the channel for flooding due to XenoRyet's mass-unscheduled-ing
[22:06:41] <ejegg>	 yes i think we do have tech talk
[22:06:56] <XenoRyet>	 lol, I didn't know it alerted here
[22:07:30] <XenoRyet>	 I'll try to finish up before it rejoins
[22:08:00] <ejegg>	 fr-tech I have one more frpm patch up - this one to make a queue consumer for the new upi-donations queue
[22:08:33] <ejegg>	 oops, trailing spaces, lemme fix that
[22:09:25] <ejegg>	 fixed
[22:09:44] <AndyRussG>	 ejegg: we're in tech-talk btw
[22:10:07] <ejegg>	 ohhh that's right now? oops, be there in a sec
[22:10:34] <ejegg>	 sorry, I was looking at the time on my IRC box and not on my local clock. Had gotten used to them being in sync
[23:35:26] <cstone>	 hah does wikibugs come back XenoRyet I didn't realize how much I relied on it until it was gone
[23:53:28] <XenoRyet>	 cstone, I think it should.  I've seen it kicked for flooding before.