[00:00:22] 10Fundraising Sprint Fish HEAD^, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: rejected_other_reason not mapped for dlocal non-recurring redirect and not logged - https://phabricator.wikimedia.org/T332095 (10AnnWF) @AndyRussG this is another mocked transaction response: 100 is pending, so do not... [00:07:47] (03CR) 10Cstone: [C: 03+2] Remove more watchdogs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897978 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [00:13:12] (03PS2) 10Wfan: Remove mapping for 100 use fall back to other error [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/899882 (https://phabricator.wikimedia.org/T332095) [00:24:09] thanks cstone [01:16:15] ah whoops should I have rebased it first eileen? and being distracted but I can get some of this review done [01:16:55] they can be rebased out at any point & they will merge [01:17:46] (03PS2) 10Cstone: Remove more watchdogs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897978 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [01:35:10] (03CR) 10Cstone: [C: 03+2] Remove more watchdogs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897978 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [01:49:05] (03Merged) 10jenkins-bot: Remove more watchdogs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897978 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [01:51:06] (03PS2) 10Cstone: Remove more watchdogs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897979 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:07:06] (03CR) 10Cstone: [C: 03+2] Remove more watchdogs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897979 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:10:04] ok, finally back. will smoke test that amount patch [02:19:40] (03PS15) 10Ejegg: Add recurring amount validation to DI level for dlocal IN bt recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895731 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [02:19:51] (03CR) 10Ejegg: [C: 03+2] "Looks good, works in local testing!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895731 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [02:21:14] (03Merged) 10jenkins-bot: Remove more watchdogs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897979 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:22:04] (03CR) 10Ejegg: [C: 03+2] Remove mapping for 100 use fall back to other error [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/899882 (https://phabricator.wikimedia.org/T332095) (owner: 10Wfan) [02:22:37] (03Merged) 10jenkins-bot: Remove mapping for 100 use fall back to other error [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/899882 (https://phabricator.wikimedia.org/T332095) (owner: 10Wfan) [02:22:53] ok, I will tag another version. Thanks for that fix wfan! [02:26:24] thanks ejegg :) [02:28:54] oh I should merge that fr-dev patch at the same time [02:30:17] gonna make one lil fix before merge [02:30:23] (03PS2) 10Cstone: Remove watchdogs, wmf_audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897983 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:30:41] (03PS6) 10Ejegg: Add condition for dlocal donation rules [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/898041 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [02:31:05] (03CR) 10Ejegg: [C: 03+2] "Thanks! I just put the default rule for astropay at the end." [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/898041 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [02:31:13] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Add condition for dlocal donation rules [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/898041 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [02:34:34] //Maybe explode good comment [02:47:16] (03PS1) 10Ejegg: Round maximum USD amount for display [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/899951 [02:47:27] (03CR) 10Ejegg: [C: 03+2] "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895731 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [02:49:14] (03Merged) 10jenkins-bot: Add recurring amount validation to DI level for dlocal IN bt recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/895731 (https://phabricator.wikimedia.org/T324299) (owner: 10Wfan) [02:52:08] (03CR) 10Cstone: [C: 03+2] Remove watchdogs, wmf_audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897983 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:06:13] (03Merged) 10jenkins-bot: Remove watchdogs, wmf_audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897983 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:10:49] (03PS1) 10Ejegg: Update SmashPig lib version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/899960 [03:10:52] (03CR) 10Ejegg: [C: 03+2] Update SmashPig lib version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/899960 (owner: 10Ejegg) [03:11:26] (03PS2) 10Cstone: Remove watchdogs, wmf_than_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897984 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:11:54] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/899961 [03:12:07] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/899961 (owner: 10Ejegg) [03:25:38] (03Merged) 10jenkins-bot: Update SmashPig lib version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/899960 (owner: 10Ejegg) [03:25:40] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/899961 (owner: 10Ejegg) [03:26:04] (03PS1) 10Ejegg: Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/899966 [03:26:13] (03CR) 10Ejegg: [C: 03+2] Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/899966 (owner: 10Ejegg) [03:26:52] wfan I have the donation_rules update in the settings repo to deploy along with that change [03:27:07] cool [03:27:17] it'll have to be the same rules for astropay as for dlocal adapters but I think that's OK [03:27:42] (right now the astropay folder is just a symlink to dlocal) [03:28:05] we can split out those folders tomorrow but it'll need fr-tech-ops [03:28:44] (03CR) 10Cstone: [C: 03+2] Remove watchdogs, wmf_than_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897984 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:29:56] !log payments-wiki upgraded from 1532b107 to 0fd66b1f [03:29:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:33:44] (03Merged) 10jenkins-bot: Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/899966 (owner: 10Ejegg) [03:42:29] 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-dlocal: frlog syslog filter for payments-dlocal - https://phabricator.wikimedia.org/T332092 (10Ejegg) Thanks, @dwisehaupt! [03:42:43] (03Merged) 10jenkins-bot: Remove watchdogs, wmf_than_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897984 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:43:46] (03PS2) 10Cstone: Code reformat to Civi stds [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897985 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [03:59:08] (03CR) 10Cstone: [C: 03+2] Code reformat to Civi stds [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897985 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [04:13:03] (03Merged) 10jenkins-bot: Code reformat to Civi stds [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897985 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [04:14:11] (03PS2) 10Eileen: Remove watchdog from BannerHistoryQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897986 (https://phabricator.wikimedia.org/T288585) [12:06:39] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Wikimedia-CentralNotice-Administration: Allow users to deactivate `no type` campaigns via local/global preferences, and consider the same for maintenance and/or special banners - https://phabricator.wikimedia.org/T332306 (10MarcoAurelio) [13:10:27] (03CR) 10Jforrester: [C: 03+2] build: Updating npm dependencies [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/897245 (owner: 10Umherirrender) [13:34:10] (03Merged) 10jenkins-bot: build: Updating npm dependencies [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/897245 (owner: 10Umherirrender) [13:49:00] 10Fundraising-Backlog, 10Wikimedia-CentralNotice-Administration: CentralNotice banner display issues - https://phabricator.wikimedia.org/T236782 (10MarcoAurelio) 05Open→03Declined Self-close. Old task/campaign. [13:51:12] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Wikimedia-CentralNotice-Administration: Provide a way to display of a banner only to users who reach a certain number of edits - https://phabricator.wikimedia.org/T269758 (10MarcoAurelio) If we could do not only edits but other "API-queriable" pr... [14:19:11] (03PS2) 10Damilare Adedoyin: Remove watchdog from AntiFraudConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898032 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [14:25:34] (03CR) 10Damilare Adedoyin: [C: 03+2] Add cz to wgDonationInterfaceMonthlyConvertCountries [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/897982 (https://phabricator.wikimedia.org/T331665) (owner: 10Wfan) [14:38:38] (03CR) 10Damilare Adedoyin: [C: 03+2] Remove watchdog from AntiFraudConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898032 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [14:38:51] (03PS2) 10Damilare Adedoyin: Apply CiviCRM code formatting (no other change) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898033 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [14:39:41] (03PS2) 10Damilare Adedoyin: Remove watchdog from banner_history_queue_consume [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898034 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [14:53:13] (03Merged) 10jenkins-bot: Remove watchdog from AntiFraudConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898032 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [14:58:52] (03CR) 10Damilare Adedoyin: [C: 03+2] Apply CiviCRM code formatting (no other change) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898033 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [15:13:52] (03Merged) 10jenkins-bot: Apply CiviCRM code formatting (no other change) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898033 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [15:36:54] (03CR) 10Damilare Adedoyin: [C: 03+2] Remove watchdog from banner_history_queue_consume [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898034 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [15:51:00] (03PS2) 10Damilare Adedoyin: Remove watchdog from wmf_optin [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898035 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [15:51:18] (03Merged) 10jenkins-bot: Remove watchdog from banner_history_queue_consume [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898034 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [16:14:54] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising Sprint Fibonachos, and 17 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10XenoRyet) [16:18:19] 10Fundraising-Backlog, 10fundraising-tech-ops: Switch-over from civi1001 to civi1002 - https://phabricator.wikimedia.org/T329882 (10Jgreen) [16:19:33] 10Fundraising-Backlog, 10fundraising-tech-ops: Switch-over from civi1001 to civi1002 - https://phabricator.wikimedia.org/T329882 (10Jgreen) [16:21:10] 10Fundraising-Backlog, 10fundraising-tech-ops: Switch-over from civi1001 to civi1002 - https://phabricator.wikimedia.org/T329882 (10Jgreen) [16:22:50] 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Update DLocal createPayment for UPI / DIRECT method - https://phabricator.wikimedia.org/T324294 (10XenoRyet) [16:23:11] 10Fundraising-Backlog, 10fundraising-tech-ops: Switch-over from civi1001 to civi1002 - https://phabricator.wikimedia.org/T329882 (10Jgreen) [16:24:10] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising Sprint Fibonachos, and 17 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10XenoRyet) [16:38:52] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Fundraising access request for Salvatore Borriello - https://phabricator.wikimedia.org/T331491 (10SBorriello) Hello Dallas! The public side of the Yubikey is as follows: cccccbghjvrh. Also, find the contents of the public side of the key to... [16:46:24] 10Fundraising-Backlog, 10fundraising-tech-ops: Switch-over from civi1001 to civi1002 - https://phabricator.wikimedia.org/T329882 (10Jgreen) [16:55:35] 10Fundraising-Backlog, 10IP Masking, 10MediaWiki-extensions-CentralNotice: Update Fundraising Tech-owned products that may be affected by IP Masking - https://phabricator.wikimedia.org/T326943 (10Ejegg) Post-meeting notes: Andrew suggests that we just treat temp accounts like anon, and show fundraising bann... [16:56:26] AndyRussG and anilk I just updated that ticket with some recollections of the meeting. LMK if you think it needs anything more ^^^ [16:56:49] cool beans, thanks so much ejegg :) [16:56:57] I guess we could solicit input from the wider fundraising non-tech people on that same ticket, or we could circulate an email or something [17:01:12] Thanks ejegg - if it helps I can ask online fundraising if they have an opinion (show banners or don't to temp users) [17:02:59] what's the definition of "temp user"? [17:03:16] there's probably a project wiki page with that info..... [17:03:45] greg-g: it's the new "anonymous editor" [17:03:56] yeah, but what is "temp" about it [17:04:02] https://office.wikimedia.org/wiki/Product/IP_Masking [17:04:09] see FAQ [17:04:27] they don't log in or get a user name, and it disappears after the related browser cookie goes away [17:04:56] thanks anilk, I went to mediawiki.org first and this was the only page about ip masking, which didn't help :) https://www.mediawiki.org/wiki/Core_Platform_Team/Initiatives/IP_Masking [17:05:00] so basically their anonymous edits are still anonymous, just not publicly displaying an IP [17:05:20] yeah not sure why it's on Office wiki [17:05:51] I guess one thing ejegg is that Niharika said that their reco to teams is to treat temp users as annon - however you're right that's it's up to us/fundraising [17:06:15] the FAQ is helping to answer my question, thanks [17:12:14] (03CR) 10Damilare Adedoyin: [C: 03+2] Remove watchdog from wmf_optin [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898035 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [17:12:39] (03PS2) 10Damilare Adedoyin: Remove watchdog from unsubscribe [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898036 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [17:13:28] (03CR) 10Cstone: [C: 03+2] Remove watchdog from BannerHistoryQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897986 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [17:14:14] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Fundraising access request for Salvatore Borriello - https://phabricator.wikimedia.org/T331491 (10Dwisehaupt) @SBorriello Thanks. I have added your yubikey info. For the ssh key, I need the contents of your public key. You should be able to g... [17:23:23] oh right anilk, I'll add that [17:23:41] and the fact that none of the backend webrequest data stores are affected [17:26:20] (03Merged) 10jenkins-bot: Remove watchdog from wmf_optin [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898035 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [17:27:43] (03Merged) 10jenkins-bot: Remove watchdog from BannerHistoryQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897986 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [17:28:06] 10Fundraising Sprint Fish HEAD^, 10Fundraising-Backlog, 10FR-dlocal: DLocal sandbox/production account setup - https://phabricator.wikimedia.org/T324499 (10Cstone) This is done, we have a separate testing account now. [17:31:18] (03PS2) 10Cstone: Remove watchdog from PaymentsInitQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897987 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [17:41:30] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10fr-email-preference-center: Exception loading Email Preferences opt-in form - https://phabricator.wikimedia.org/T332338 (10Ejegg) [17:43:43] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Fundraising access request for Salvatore Borriello - https://phabricator.wikimedia.org/T331491 (10SBorriello) Hello Dallas, When I do it, it gives me the following response: {F36914721} [17:47:44] 10Fundraising Sprint Fish HEAD^, 10Fundraising-Backlog, 10FR-dlocal: Document the dLocal UPI Recurring for the sake of our future selves. - https://phabricator.wikimedia.org/T331717 (10Cstone) Will go here: https://wikitech.wikimedia.org/wiki/Fundraising/Data_and_flow/PSP_integrations/dLocal [17:48:03] (03CR) 10Cstone: [C: 03+2] Remove watchdog from PaymentsInitQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897987 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [17:48:46] (03CR) 10Damilare Adedoyin: [C: 03+2] Remove watchdog from unsubscribe [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898036 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [17:54:37] (03PS2) 10Ejegg: Add cz to wgDonationInterfaceMonthlyConvertCountries [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/897982 (https://phabricator.wikimedia.org/T331665) (owner: 10Wfan) [17:54:39] (03CR) 10Ejegg: [V: 03+2] Add cz to wgDonationInterfaceMonthlyConvertCountries [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/897982 (https://phabricator.wikimedia.org/T331665) (owner: 10Wfan) [17:56:05] 10Fundraising Sprint Fish HEAD^, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Move DLocal submethod -> bank_code mapping down into SmashPig - https://phabricator.wikimedia.org/T331475 (10Ejegg) [17:56:19] 10Fundraising Sprint Fish HEAD^, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Move DLocal submethod -> bank_code mapping down into SmashPig - https://phabricator.wikimedia.org/T331475 (10Ejegg) a:03Ejegg [18:01:57] Thanks ejegg [18:02:34] (03Merged) 10jenkins-bot: Remove watchdog from PaymentsInitQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897987 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [18:02:37] (03Merged) 10jenkins-bot: Remove watchdog from unsubscribe [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898036 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [18:07:28] wfan do you want to deploy that same settings change in production? Sounds like there's no need to wait, and the code change with the amounts is live [18:15:27] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Fundraising access request for Salvatore Borriello - https://phabricator.wikimedia.org/T331491 (10Dwisehaupt) Oh, looking at the initial screenshot, I think I see what has happened. Somehow it has a space in the file name. If you run the foll... [18:26:00] the same settings change you mean cz? [18:28:11] yep wfan, just adding that to the list like you did for fr-dev [18:28:23] sure [18:36:30] (03PS2) 10Cstone: Remove watchdog from drush script + reformat [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897990 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [18:41:13] !log enable monthlyconvert for cz [18:41:16] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:52:34] 10Fundraising Sprint Fish HEAD^, 10MW-1.41-notes (1.41.0-wmf.1; 2023-03-20): Please turn on Monthly Convert in Czech (csCZ) - https://phabricator.wikimedia.org/T331665 (10AnnWF) Added cz to wgDonationInterfaceMonthlyConvertCountries at production [18:53:38] (03CR) 10Cstone: [C: 03+2] Remove watchdog from drush script + reformat [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897990 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [18:54:08] It brings me joy to see notifications about sprint "Fish HEAD^" - the song automatically comes to mind [18:54:28] I mean it starts playing in my head [19:08:02] (03Merged) 10jenkins-bot: Remove watchdog from drush script + reformat [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897990 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [19:08:59] (03PS2) 10Cstone: Remove some watchdogs from drush scripts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897991 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [19:09:05] oops, what's taht UPI failmail about? [19:09:52] ah wfan I see, the time_limit thing. Yep, we forgot to add taht [19:10:02] ok, let's disable the job for now [19:10:16] or rather, let's just remove the time_limit [19:10:35] it shouldn't need one till we get a crazy amount of signups [19:13:08] ok, I just deployed that change. I'll have a code patch up to add support for those options soon [19:21:38] Ok, just off meeting, thanks ejegg !!! [19:26:28] (03CR) 10Cstone: [C: 03+2] Remove some watchdogs from drush scripts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897991 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [19:26:45] 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices: EoY receipt email donation format issue 2023 - https://phabricator.wikimedia.org/T332232 (10AMJohnson) Thank you for submitting this for us @MBeat33! I thought it may be helpful to provide a few more details around what we're seeing in Civi. In... [19:30:06] greg-g: I found this deck helpful re: IP masking: https://docs.google.com/presentation/d/1CnWTI2LqSZJ0TwbSL428RY84drB6WYqQmaFeg7ky-yc/edit#slide=id.g1a709014f11_0_328 [19:30:28] oh boy, more adyen timeouts / retry failures [19:35:47] anilk: aha, nice, ty! [19:41:04] (03Merged) 10jenkins-bot: Remove some watchdogs from drush scripts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897991 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [19:44:35] 10Fundraising-Backlog, 10FR-Email: Click-tracking in Acoustic - https://phabricator.wikimedia.org/T316573 (10BCornwall) [19:44:38] 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising Sprint Undefined, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, and 5 others: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561 (10BCornw... [19:45:02] (03PS1) 10Ejegg: Map payment_submethod to payment_method_id [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/900429 (https://phabricator.wikimedia.org/T331475) [19:45:38] (03CR) 10Ejegg: "TODO: matching DonationInterface patch to start using this mapping" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/900429 (https://phabricator.wikimedia.org/T331475) (owner: 10Ejegg) [19:47:08] whew, I'm tired. Might go for a quick bike ride to wake up [19:47:50] guh, should we just extend that adyen timeout to a minute and see if those clear up? [19:47:52] (03CR) 10Umherirrender: [V: 03+2] build: Updating dependencies [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/899210 (owner: 10Libraryupgrader) [19:48:32] AndyRussG or jgleeson|away are you chaos-crewing the current failmail spasm? [19:54:12] ok, let's see if that timeout increase helps [19:56:30] oh wfan the code does support timeLimit and batch, we just needed to rename the parameters [19:56:37] in the process_control yaml file [19:56:43] I'll go ahead and do that [19:57:01] also I'll update the DonationInterface and SmashPig libraries in crm [19:59:23] cool thanks for the update ejegg [19:59:58] (03PS1) 10Ejegg: Update SmashPig and DI libs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/900433 [20:00:01] (03CR) 10Ejegg: [C: 03+2] Update SmashPig and DI libs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/900433 (owner: 10Ejegg) [20:01:41] (03PS1) 10Ejegg: Update SmashPig and DonationInterface [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/900434 [20:01:44] (03CR) 10Ejegg: [C: 03+2] Update SmashPig and DonationInterface [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/900434 (owner: 10Ejegg) [20:02:18] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/900435 [20:02:22] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/900435 (owner: 10Ejegg) [20:09:34] darn, we're still getting lots of timeouts [20:10:46] I pinged Evelyn on slack so she's aware - and thanks for pinging Haley ejegg. [20:11:24] thanks anilk - I didn't get a response here so maybe I should look for banner folks on slack too [20:11:52] I can ping Haley there too [20:12:28] oh you got it - tx [20:13:20] (03Abandoned) 10Kosta Harlan: [WIP] Remove UnitTestsList hook [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/761894 (https://phabricator.wikimedia.org/T298509) (owner: 10Kosta Harlan) [20:13:47] (03Merged) 10jenkins-bot: Update SmashPig and DI libs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/900433 (owner: 10Ejegg) [20:14:24] ok, with the timeout increased we're at least getting a response from adyen, but it's a lot of 'Acquirer Error' [20:15:27] (03Merged) 10jenkins-bot: Update SmashPig and DonationInterface [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/900434 (owner: 10Ejegg) [20:15:29] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/900435 (owner: 10Ejegg) [20:22:24] 10Fundraising-Backlog: Public malicious domain posing as Adyen - request to block domain - https://phabricator.wikimedia.org/T332354 (10EMartin) [20:33:14] 10Fundraising-Backlog: Public malicious domain posing as Adyen - request to block domain - https://phabricator.wikimedia.org/T332354 (10AKanji-WMF) @EMartin had a chat with Greg and we're not sure there's much we can do to block this site internally for teams/staff. I think best we can collectively do is to war... [20:34:27] 10Fundraising-Backlog: Public malicious domain posing as Adyen - request to block domain - https://phabricator.wikimedia.org/T332354 (10EMartin) @AKanji-WMF Thank you. @mbeattie has notified Donor Relations who are the primary users. [20:47:11] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Fundraising access request for Salvatore Borriello - https://phabricator.wikimedia.org/T331491 (10Dwisehaupt) [20:47:49] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Fundraising access request for Salvatore Borriello - https://phabricator.wikimedia.org/T331491 (10Dwisehaupt) mysql accounts created and grants applied. .my.cnf file created on frdev1001 and basic connections and selects tested. [21:01:36] 10Fundraising-Backlog, 10User-greg: Public malicious domain posing as Adyen - request to block domain - https://phabricator.wikimedia.org/T332354 (10greg) 05Open→03Resolved a:03greg Per Anil's comment and Evelyn already engaging with DR, I think this is safe to close for us for now. Thanks for the heads up! [21:03:47] gonna try out the new paypal pending resolver on prod [21:05:36] welp, that's an exception [21:05:45] ok, turning the old one back on [21:08:20] (03PS1) 10Ejegg: Dlocal: Stop mapping submethod to payment_method_id [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/900450 (https://phabricator.wikimedia.org/T331475) [21:09:26] huh, POST request to https://api.paypal.com/nvp failed 7 times [21:10:39] (03CR) 10CI reject: [V: 04-1] Dlocal: Stop mapping submethod to payment_method_id [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/900450 (https://phabricator.wikimedia.org/T331475) (owner: 10Ejegg) [21:11:23] ohh, it's a credentials thing I guess [21:20:32] 10Fundraising Sprint Fish HEAD^, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Implement one-time UPI / DIRECT payments for DLocal in DonationInterface - https://phabricator.wikimedia.org/T324295 (10AnnWF) a:03AnnWF [21:27:18] (03Abandoned) 10Umherirrender: Avoid passing null to str_replace [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/899787 (owner: 10Umherirrender) [21:37:29] (03PS2) 10Ejegg: Dlocal: Stop mapping submethod to payment_method_id [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/900450 (https://phabricator.wikimedia.org/T331475) [21:44:30] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Next regular CiviCRM point release - https://phabricator.wikimedia.org/T332357 (10Eileenmcnaughton) [21:48:12] 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising Sprint Fibonachos, and 17 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10Dwisehaupt) [21:54:43] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Fundraising access request for Salvatore Borriello - https://phabricator.wikimedia.org/T331491 (10SBorriello) Although I could not resolve the issue by using the command you provided earlier (it gave me the same result), I could retrieve the... [21:57:12] fr-tech should we turn the delete_deleted_contacts job back on? [21:57:37] it seems to only have gotten up to October 2019 and has been off for a few months [22:00:03] woot, successful slow-start run [22:00:15] i'll turn that all the way on [22:04:57] dwisehaupt: where would we have to update config to swap out the old p-c job name 'paypal_orphan_slayer' for the new 'paypal_pending_resolver' in any statistics? [22:05:23] oh hey, looks like the new one showed up automatically on the 'Process Control Jobs' board [22:07:35] yeah. i'm pretty sure the p-c jobs board grabs everything that is there at that time. [22:07:42] nice [22:08:02] i'm not sure if it is referenced in any other boards, but my guess is it isn't. [22:08:12] 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising Sprint Fish HEAD^, 10Fundraising-Backlog, and 2 others: Update Pending Transaction Resolver to handle PayPal - https://phabricator.wikimedia.org/T324642 (10Ejegg) I got this working on a single-do... [22:08:27] let me see if there is something on the filesystem to query that would give that info. [22:10:10] yeah. nothing on the filesystem so we'd have to dig into the sqlite db or browse through the dashboards. [22:10:41] hey, if it's showing up automatically that's great [22:10:56] I didn't see the old name anywhere in puppet [22:11:06] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface: Remove old PayPal EC orphan rectifier - https://phabricator.wikimedia.org/T332358 (10Ejegg) [22:14:29] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Fundraising access request for Salvatore Borriello - https://phabricator.wikimedia.org/T331491 (10Dwisehaupt) @SBorriello Thanks. That works and verifies to the same file consistency hash. I have added it to our system. For ssh to work in a... [22:16:47] (03PS2) 10Ejegg: Remove orphan_slayer and DonationInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/886207 (https://phabricator.wikimedia.org/T332358) [22:17:00] fr-tech we can kill the donation-interface dependency now ^^^ [22:17:38] awesome! been a long time coming! [22:17:58] :) :) :) :) :) [22:22:12] ok, let's deploy some of those watchdog patches (and the drupal phpinfo patch) [22:24:08] !log civicrm upgraded from 68fa85cf to 672950d9 [22:24:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:30:35] wohoo! good to know that no di dependency in the future~ [22:31:57] et's update it here https://wikitech.wikimedia.org/wiki/Fundraising/Cluster/Deployments [22:32:20] heh, after someone reviews that patch! [22:32:46] I'm just reviewing the process-control logs before and after that deploy of all the watchdog patches [22:33:58] not seeing much difference in donation queue consume [22:34:18] not getting failmails [22:34:43] so that's good [22:41:30] ok, watchdog patches seem fine from what I can tell [22:41:56] lemme smoke-test those two submethod mapping patches together [22:44:32] 10fundraising-tech-ops: Deactivate fundraising accounts for ['fr-tech-testuser'] - https://phabricator.wikimedia.org/T332359 (10Dwisehaupt) [22:46:49] 10fundraising-tech-ops: Deactivate fundraising accounts for ['fr-tech-testuser'] - https://phabricator.wikimedia.org/T332359 (10Dwisehaupt) 05Open→03Invalid Test of scripting to create offboarding tasks. Declining. [22:48:23] k, that's looking good [22:48:44] Oh damilare I just noticed a couple things that we might want to move in HostedPaymentApiRequestMapper::setCustomParameters [22:49:03] that prenotify thing should probably be in the isRecurring block [22:49:37] hmm, and maybe we only add it if there's a recurring_payment_token [22:49:41] I'll put up a lil patch [22:50:25] ejegg: since we removed paypal ec, for donation-interface packagist, we no longer needs to update it for smashpig and for civi, is that right? [22:51:05] ohh if it's only for the recurring charge, there's the RecurringChargeHostedPaymentApiRequestMapper that's responsible for that ejegg [22:51:21] wfan once that patch merges, we shouldn't need to maintain the donation-interface package, right [22:51:31] just the smash-pig package [22:51:38] oh ok damilare, I'll look more closely [22:52:18] gotcha, will update the doc accordingly, thanks!!!!! that's a huge time saver~ [22:52:58] wfan: would you like to review the patch before you update the doc? THe current state of the code still has the dependency [22:54:03] https://gerrit.wikimedia.org/r/886207 [22:54:06] sure, https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/886207 this right [22:54:10] yep [22:54:16] ok [22:55:45] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising Sprint Fish HEAD^, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add fiscal_number to Civi Smashpig extension parameter mapping for Dlocal - https://phabricator.wikimedia.org/T331288 (10Ejegg) 05Open→03Resolved [22:55:47] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10Ejegg) [22:57:39] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising Sprint Fish HEAD^, 10Fundraising-Backlog, 10FR-dlocal: Enable DLocal on production - https://phabricator.wikimedia.org/T324501 (10Ejegg) This is enabled in production, and DLocal have conf... [22:57:54] :w [23:01:27] ^x^c [23:23:50] (03CR) 10Wfan: [C: 03+1] "I disabled orphan_slayer, searched keyword that no orphan_slayer or DonationInterface exist, my civi works fine, and the drush queue consu" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/886207 (https://phabricator.wikimedia.org/T332358) (owner: 10Ejegg) [23:35:16] e_jegg|afk: we'll also want to look at the civi2001 process control jobs for name cleanups and such (thinking of orphan slayer). since it tends to have correspondig jobs but with the schedule commented out.