[00:12:36] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.40-notes (1.40.0-wmf.27; 2023-03-13): CentralNotice banners being shown too many times - https://phabricator.wikimedia.org/T331671 (10DerHexer) @AndyRussG Well, I haven't worked for years on SUL finalizatio... [00:53:47] 10Fundraising Sprint Fish HEAD^, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Implement one-time UPI / DIRECT payments for DLocal in DonationInterface - https://phabricator.wikimedia.org/T324295 (10AnnWF) According to the email thread with Sebastian: 1: we have the UD enab... [01:13:30] 10Fundraising Sprint Fish HEAD^, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Braintree-Integration, and 2 others: Remove old PayPal EC orphan rectifier - https://phabricator.wikimedia.org/T332358 (10Ejegg) [01:15:19] oh hmm, is that really only resolving one txn per run? [01:16:58] seems a bit low [01:29:54] (03CR) 10Ejegg: [C: 04-1] Remove watchdog from Oanda retriever (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898001 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [01:35:22] (03PS1) 10Ejegg: Log why we exit the run loop in pending resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/900516 [01:35:36] fr-tech could someone take a quick look at that? ^^^ [01:36:13] (03PS2) 10Ejegg: Log why we exit the run loop in pending resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/900516 [01:36:33] I can't understand why the paypal pending resolver isn't resolving more than 1 per run [01:37:08] oh crap, are the other pending resolvers doing the same thing??? [01:37:16] ah no, adyen is bigger [01:53:13] ahh, I spotted it [01:54:41] (03PS1) 10Ejegg: Use correct method types for pending select [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/900518 [01:54:44] (03CR) 10Ejegg: [C: 03+2] Use correct method types for pending select [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/900518 (owner: 10Ejegg) [01:54:54] (. (. [01:54:58] .) .) [01:56:02] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/900519 [01:56:05] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/900519 (owner: 10Ejegg) [02:00:27] (03PS2) 10Ejegg: Remove watchdogs from wmf_ct_qc.module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897995 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:00:31] (03CR) 10Ejegg: [C: 03+2] Remove watchdogs from wmf_ct_qc.module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897995 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:01:59] (03PS2) 10Ejegg: Remove watchdog from matching_gifts drush [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897996 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:02:06] (03CR) 10Ejegg: [C: 03+2] Remove watchdog from matching_gifts drush [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897996 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:02:58] (03PS2) 10Ejegg: Reformat code (only) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898000 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:03:07] (03CR) 10Ejegg: [C: 03+2] Reformat code (only) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898000 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:09:11] (03Merged) 10jenkins-bot: Use correct method types for pending select [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/900518 (owner: 10Ejegg) [02:09:13] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/900519 (owner: 10Ejegg) [02:10:39] !log civicrm upgraded from 672950d9 to 5dd37c9c [02:10:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:10:58] ok, now we should get some more paypal pending txns resolved [02:14:21] (03Merged) 10jenkins-bot: Remove watchdogs from wmf_ct_qc.module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897995 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:16:55] (03Merged) 10jenkins-bot: Remove watchdog from matching_gifts drush [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/897996 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:16:57] (03Merged) 10jenkins-bot: Reformat code (only) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898000 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [02:21:44] nice, it's running through a good lot of txns [02:27:16] (03CR) 10Ejegg: "Looks pretty good, just one worry about that extra freshGateway call in the tests" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/896106 (https://phabricator.wikimedia.org/T330778) (owner: 10Damilare Adedoyin) [02:33:15] (03PS3) 10Ejegg: Log why we exit the run loop in pending resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/900516 [03:55:07] (03PS2) 10Eileen: CiviCRM 5.61.alpha [not for merge] [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/899187 (https://phabricator.wikimedia.org/T303986) [04:42:20] (03PS2) 10Eileen: [Not for merge] import config code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/899188 (https://phabricator.wikimedia.org/T303986) [04:49:50] (03PS2) 10Eileen: Apply CiviCRM formatting standard to offline2civicrm.common.inc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898003 (https://phabricator.wikimedia.org/T288585) [06:28:01] (03PS3) 10Eileen: [Not for merge] import config code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/899188 (https://phabricator.wikimedia.org/T303986) [07:04:41] (03PS4) 10Eileen: [Not for merge] import config code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/899188 (https://phabricator.wikimedia.org/T303986) [09:38:40] (03PS5) 10Eileen: [Not for merge] import config code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/899188 (https://phabricator.wikimedia.org/T303986) [12:12:28] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Wikimedia-CentralNotice-Administration: Allow users to deactivate `no type` campaigns via local/global preferences, and consider the same for maintenance and/or special banners - https://phabricator.wikimedia.org/T332306 (10MarcoAurelio) [13:09:57] i'll look at the pending txn errors in a lil bit [13:11:55] ejegg|away: if it's early for you I can look too. I've only just caught the email [13:17:38] Return value of Civi\Api4\Action\PendingTransaction\Resolve::startRecurringPaymentAndReturnStatus() must be of the type string, null returned [13:17:49] Undefined index: date [13:23:30] interesting because I see a date on the message being processed [13:31:48] hmm, must be missing a mapping down in the paypal smashpig classes [13:33:40] looks like we're not sending over the data here ejegg|away https://github.com/wikimedia/wikimedia-fundraising-crm/blob/44cb04e0233f846b56ad9b58bfbfaa62f3f0d00b/drupal/sites/default/civicrm/extensions/wmf-civicrm/Civi/Api4/Action/PendingTransaction/Resolve.php#L646 [13:33:45] date* [13:33:54] want me to add a patch for that? [13:34:50] actually ejegg|away I just realised today is your day off! [13:35:07] we will fix that. you go enjoy your day off [13:50:59] hmm I don't think we can just pass in the date as the current value is a unix timestamp but the internal expect a string which is then converted to a timestamp and then back to a real date .. [13:51:22] based on this https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/2e331abfad41160e96cc3cec538556f49bd7fdee/PaymentProviders/PayPal/Api.php#L138 [13:51:42] I don't think strtotime plays nice with timestamps [14:03:10] ok I guess we could fix this two ways [14:04:03] we could update the calling code in the civi extension to send in the expected date format of a string [14:05:51] or we could update both the civi extension to send over the date param verbatim as a timestamp, and smashpig to expect a timestamp [14:08:33] hmm I might go with option one even though it's ugly. the latter would require a smashpig verson bump and an update to civi to pull in the library updates alongside the new date param so I'll defer that for now and add a ticket to follow on with the more complete fix [14:19:55] 10Fundraising-Backlog: Paypal EC Pending Transaction Resolver failed - https://phabricator.wikimedia.org/T332396 (10jgleeson) [14:20:09] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Paypal EC Pending Transaction Resolver failed - https://phabricator.wikimedia.org/T332396 (10jgleeson) [14:21:09] (03PS3) 10Damilare Adedoyin: Add 'wmf_token' CSRF protection to dLocal forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/896106 (https://phabricator.wikimedia.org/T330778) [14:22:54] (03CR) 10CI reject: [V: 04-1] Add 'wmf_token' CSRF protection to dLocal forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/896106 (https://phabricator.wikimedia.org/T330778) (owner: 10Damilare Adedoyin) [14:23:02] (03PS1) 10Jgleeson: PayPal Pending Trxn Resolver Fix: missing 'date' param [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/900660 (https://phabricator.wikimedia.org/T332396) [14:40:18] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Paypal EC Pending Transaction Resolver failed - https://phabricator.wikimedia.org/T332396 (10jgleeson) Let's refactor the calling and library code related to this. Currently, the calling code in CiviCRM is picking up a timestamp fro... [14:44:37] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Paypal EC Pending Transaction Resolver failed - https://phabricator.wikimedia.org/T332396 (10jgleeson) Let's refactor the calling and library code related to this. Currently, the calling code in CiviCRM is picking up a timestamp fro... [14:47:42] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Recurring-Donations, 10fr-donorservices: Ingenico recurrings stopped at status 600 March 5th - https://phabricator.wikimedia.org/T331490 (10jgleeson) a:03jgleeson [15:11:23] (03PS4) 10Damilare Adedoyin: Add 'wmf_token' CSRF protection to dLocal forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/896106 (https://phabricator.wikimedia.org/T330778) [15:13:05] (03CR) 10CI reject: [V: 04-1] Add 'wmf_token' CSRF protection to dLocal forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/896106 (https://phabricator.wikimedia.org/T330778) (owner: 10Damilare Adedoyin) [15:13:57] (03PS5) 10Damilare Adedoyin: Add 'wmf_token' CSRF protection to dLocal forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/896106 (https://phabricator.wikimedia.org/T330778) [15:43:52] (03CR) 10Damilare Adedoyin: "Thanks Elliott for the catch, this has been fixed." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/896106 (https://phabricator.wikimedia.org/T330778) (owner: 10Damilare Adedoyin) [15:55:57] (03PS38) 10AndyRussG: IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) [16:17:44] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Paypal EC Pending Transaction Resolver failed - https://phabricator.wikimedia.org/T332396 (10jgleeson) p:05Triage→03High [17:00:03] jgleeson: oops, yeah, best to be consistent about expecting timestamps, but whatever lets us keep it running for now is great! I'll take another look monday [17:06:03] thanks for finding that error! [17:30:05] (03CR) 10Wfan: [C: 03+2] Lint braintree.js, make it pass [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/899871 (owner: 10Ejegg) [17:31:37] thanks ejegg|away! I think we're gonna try and push that one out today as it's a small change with low risk and feels like a nice one to get out before the weekend [17:37:30] (03Merged) 10jenkins-bot: Lint braintree.js, make it pass [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/899871 (owner: 10Ejegg) [17:56:19] 10Fundraising-Backlog: Document on wikitech the inputs behind our grafana graphs - https://phabricator.wikimedia.org/T332421 (10jgleeson) [17:56:29] greg-g: https://phabricator.wikimedia.org/T332421 [17:56:39] (03CR) 10Damilare Adedoyin: [C: 03+2] Round maximum USD amount for display [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/899951 (owner: 10Ejegg) [17:58:34] 10Fundraising-Backlog: Document on wikitech the inputs behind our grafana graphs - https://phabricator.wikimedia.org/T332421 (10jgleeson) [17:59:00] 10Fundraising-Backlog: Document on wikitech the inputs behind our grafana graphs - https://phabricator.wikimedia.org/T332421 (10jgleeson) [18:00:14] 10Fundraising-Backlog: Document on wikitech the inputs behind our grafana graphs - https://phabricator.wikimedia.org/T332421 (10jgleeson) [18:00:37] I guess it helps if you link to the right graph in the first example ha! [18:00:41] ok now really dinner time [18:11:59] jgleeson|dinner: sweet, thanks! [18:18:09] (03Merged) 10jenkins-bot: Round maximum USD amount for display [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/899951 (owner: 10Ejegg) [18:43:47] (03CR) 10Cstone: [C: 03+2] Apply CiviCRM formatting standard to offline2civicrm.common.inc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898003 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [18:56:21] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Paypal EC Pending Transaction Resolver failed - https://phabricator.wikimedia.org/T332396 (10AndyRussG) Thanks so much for this @jgleeson! The attached patch looks great. Just trying to understand the root cause here: as far as I ca... [18:57:32] (03CR) 10AndyRussG: [C: 03+1] "Looks great! Before merging, I just thought I'd inquire if we've smoke tested, or if you have notes on how to do so?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/900660 (https://phabricator.wikimedia.org/T332396) (owner: 10Jgleeson) [18:57:50] (03Merged) 10jenkins-bot: Apply CiviCRM formatting standard to offline2civicrm.common.inc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898003 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [18:58:51] jgleeson|dinner: in case you'll be back today... see above comment on task and Gerrit ^ wondering how to smoke test a PayPal recurring transaction that requires resolving? thx much!!! [18:59:25] fr-tech ^ also if anyone else has notes on how to smoke test? thx in advance :) [18:59:44] (03PS2) 10Cstone: Swap out watchdog from offline2civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898004 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [19:15:47] (03CR) 10Cstone: [C: 03+2] Swap out watchdog from offline2civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898004 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [19:29:36] (03Merged) 10jenkins-bot: Swap out watchdog from offline2civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898004 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [19:30:37] (03PS2) 10Cstone: Remove watchdog from checks file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898005 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [19:47:29] hey AndyRussG there's a unit test update on that patch that you can debug through to see it go through the code paths impacted by the bug. I used that to confirm the behaviour locally. there's also a corresponding unit test over on the smashpig library code which tests the library code that I used to confirm that adding the 'date' param didn't breaking anything [19:47:31] https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/0ce080bbe1e3eb8592aed80fff112ea0e5b548cc/PaymentProviders/PayPal/PaymentProvider.php#L71 [19:48:17] ah great good point jgleeson :) [19:48:55] there's also opportunities to add more test coverage to the internal api calls that we should probably add when we do the more comprehensive refactored outlined in the ticket [19:49:33] yea [19:49:35] I'm logging off for now. feel free to leave any more questions on the patch or IRC and I'll check in a bit later as I usually do :) [19:49:47] have a great weekend fr-tech! [19:49:59] jgleeson thought on why this wasn't seen before ? [19:50:06] ah ok cya! [19:50:08] oh sorry [19:50:22] umm my best guess Andy is that it only went live last night I think [19:50:23] as in why the bug wasn't noticed? [19:50:38] I wasn't around but that was the impressed I got from ejegg|away's EOD email [19:50:44] impression* [19:50:59] i folks, [19:51:01] hmmm but does that mean it wasn't ever fully smoke tested? [19:51:01] I put the new PayPal pending txn resolver into production today and disabled the old one [19:51:21] hmmm [19:51:22] yeah it looks that way AndyRussG [19:51:28] k thx [19:52:10] if you feel like there's risk deploying then we can delay till Monday. I don't think many will be affected and I'm pretty sure we can manually rerun 'em [19:52:20] sorry to keep u... also ok if I suggest putting the date format refactor in a separate task? [19:52:22] do whatever feels right [19:52:48] nah I'll deploy for sure if that's ok :) [19:52:58] AndyRussG: checkout https://phabricator.wikimedia.org/T332396#8705337 [19:53:12] we could create the refactor ticket with that as the desc [19:53:20] sure sounds like a good idea! [19:53:56] ok signing off. I'll check-in later. bye for now [19:55:40] thx!! :) [20:05:11] (03CR) 10Cstone: [C: 03+2] Remove watchdog from checks file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898005 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [20:19:06] (03Merged) 10jenkins-bot: Remove watchdog from checks file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898005 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [20:24:39] (03PS2) 10Cstone: Remove watchdog from orphan_slayer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/898026 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [21:29:07] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Next regular CiviCRM point release - https://phabricator.wikimedia.org/T332357 (10Eileenmcnaughton) [22:31:03] 10Fundraising Sprint Fish HEAD^, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Implement one-time UPI / DIRECT payments for DLocal in DonationInterface - https://phabricator.wikimedia.org/T324295 (10AnnWF) [23:10:32] (03CR) 10AndyRussG: [C: 03+2] "As per IRC discussion. Thanks again!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/900660 (https://phabricator.wikimedia.org/T332396) (owner: 10Jgleeson) [23:24:17] (03Merged) 10jenkins-bot: PayPal Pending Trxn Resolver Fix: missing 'date' param [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/900660 (https://phabricator.wikimedia.org/T332396) (owner: 10Jgleeson) [23:29:48] fr-tech ok gonna deploy that update to the Paypal ptr ^ [23:31:38] (03PS1) 10Wfan: Use new mediawiki-apache2 image for email-pref-ctr [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/900745 [23:39:15] (03PS1) 10AndyRussG: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/900746 [23:39:30] (03CR) 10AndyRussG: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/900746 (owner: 10AndyRussG) [23:39:45] (03CR) 10Wfan: [C: 03+2] Log why we exit the run loop in pending resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/900516 (owner: 10Ejegg) [23:40:14] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/900746 (owner: 10AndyRussG) [23:54:01] (03Merged) 10jenkins-bot: Log why we exit the run loop in pending resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/900516 (owner: 10Ejegg)