[11:44:19] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Paypal EC Pending Transaction Resolver failed - https://phabricator.wikimedia.org/T332396 (10jgleeson) a:03jgleeson [13:59:00] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Paypal EC Pending Transaction Resolver failed (missing 'date' param) - https://phabricator.wikimedia.org/T332396 (10jgleeson) [14:13:44] hi jgleeson! shall we deploy your paypal pending fix? [14:16:31] 10Fundraising Sprint Fish HEAD^, 10Fundraising-Backlog, 10FR-dlocal: Document the dLocal UPI Recurring for the sake of our future selves. - https://phabricator.wikimedia.org/T331717 (10Damilare) a:03Damilare [14:19:34] ah i see it's merged to deployment already [14:19:43] so there was another issue? [14:19:54] looks like maybe missing a mapped status [14:23:17] guessing the PROFILESTATUS wasn't set on the response [14:27:16] https://phabricator.wikimedia.org/diffusion/WFSP/browse/master/PaymentProviders/PayPal/PaymentProvider.php$82 [14:27:34] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Paypal EC Pending Transaction Resolver failed (weekend failure) - https://phabricator.wikimedia.org/T332599 (10jgleeson) [14:27:56] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Paypal EC Pending Transaction Resolver failed (weekend failure) - https://phabricator.wikimedia.org/T332599 (10jgleeson) p:05Triage→03High [14:29:10] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Paypal EC Pending Transaction Resolver failed (weekend failure) - https://phabricator.wikimedia.org/T332599 (10Ejegg) we should get the email from our status lookup API call [14:31:14] sorry ejegg I had IRC minimised [14:31:23] proof reading that ticket 78 times [14:31:28] hehe [14:31:39] ah ok so that email missing isn't a big issue [14:31:57] so I think we just need an else clause on that if down in the smashpig fn [14:32:22] to fall back to failure status when that's not set [14:34:55] hmm, but we could also change the logic up in Resolve.php to deal with a successful capture then a failed profile creation [14:35:40] ejegg: do you have access to the prod paypal account to see if the user related does indeed have a valid recurring subscription? [14:36:03] (03PS1) 10Ejegg: Always return a status for pp profile creation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901223 [14:36:30] i might jgleeson - might be expired [14:36:43] In civicrm things looks good [14:36:49] https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=3880738 [14:36:58] look* [14:37:17] so it was a race condition that made us process it in the first place though? [14:37:51] we should delete the pending message when we ge a real donation into civi [14:39:23] gotta pop out to pick up the kids. back soon [14:41:14] (03PS2) 10Ejegg: Always return a status for PayPal profile creation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901223 (https://phabricator.wikimedia.org/T332599) [14:42:56] oh i misread the logic - there's no flow in Resolve.php with a successful one-time charge followed by a failed recurring [14:43:02] so no change needed ther [14:43:14] we could update that date format though [15:01:13] (03PS1) 10Damilare Adedoyin: Add tests for new methods in PaymentProvider class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901231 [15:03:51] (03CR) 10Jforrester: [C: 03+2] build: Updating composer dependencies [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/900780 (owner: 10Umherirrender) [15:05:44] (03PS1) 10Ejegg: Expect timestamp for PP profile start date [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901232 (https://phabricator.wikimedia.org/T332396) [15:08:36] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Paypal EC Pending Transaction Resolver failed (weekend failure) - https://phabricator.wikimedia.org/T332599 (10Ejegg) ah, so we could potentially delete pending messages in the recurring queue consumer too, not just in the one-time... [15:20:29] (03Merged) 10jenkins-bot: build: Updating composer dependencies [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/900780 (owner: 10Umherirrender) [15:49:04] (03CR) 10Jgleeson: [C: 04-1] "Thanks for this. These looks great. Just one change required for a test that I think we already have covered." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901231 (owner: 10Damilare Adedoyin) [15:53:34] (03PS2) 10Damilare Adedoyin: Add tests for new methods in PaymentProvider class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901231 [15:54:40] (03CR) 10Damilare Adedoyin: "Thanks for catching that jgleeson, that test shouldn't have been there as the method it mocks had been tested in the previous test." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901231 (owner: 10Damilare Adedoyin) [16:02:01] (03CR) 10Jgleeson: [C: 03+2] "LGTM! thanks for the fix." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901223 (https://phabricator.wikimedia.org/T332599) (owner: 10Ejegg) [16:02:36] (03Merged) 10jenkins-bot: Always return a status for PayPal profile creation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901223 (https://phabricator.wikimedia.org/T332599) (owner: 10Ejegg) [16:04:18] damilare: did you catch my comment about the @group dlocal annotation? [16:04:47] no I didn't see that [16:05:53] (03PS3) 10Damilare Adedoyin: Add tests for new methods in PaymentProvider class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901231 [16:06:10] yeah I noticed some of the other test suites use it so figured we'd missed it on that one and be nice to add [16:06:10] done jgleeson, sorry I missed that [16:06:14] jgleeson: shall we fix that timestamp format too before tagging a SmashPig version? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/901232/1 [16:06:14] thanks much! [16:06:23] (03CR) 10CI reject: [V: 04-1] Add tests for new methods in PaymentProvider class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901231 (owner: 10Damilare Adedoyin) [16:06:23] btw we have Joaquin Ginzo , who can reply dlocal email now~ [16:06:29] i'll make the matching patch in CRM [16:07:24] thanks wfan! [16:07:29] checking ejegg [16:07:58] (03PS4) 10Damilare Adedoyin: Add tests for new methods in PaymentProvider class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901231 [16:11:19] (03CR) 10Jgleeson: [C: 03+2] "LGTM. Thanks for this refactor!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901232 (https://phabricator.wikimedia.org/T332396) (owner: 10Ejegg) [16:11:29] thanks! [16:11:31] ty [16:11:59] (03Merged) 10jenkins-bot: Expect timestamp for PP profile start date [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901232 (https://phabricator.wikimedia.org/T332396) (owner: 10Ejegg) [16:12:15] I guess we can tag the version before merging those new tests probably [16:12:27] +2ing them now [16:12:33] oh great! [16:13:14] (03CR) 10Jgleeson: [C: 03+2] "thanks for the updates. these look great!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901231 (owner: 10Damilare Adedoyin) [16:13:34] I wanted to try out the `--filter PaymentProviderTest --group Dlocal` params :) [16:13:58] (03Merged) 10jenkins-bot: Add tests for new methods in PaymentProvider class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901231 (owner: 10Damilare Adedoyin) [16:14:09] I've gotta get an early start on dinner. back soon [16:19:11] ah, need to do one more donation-interface version bump too [16:21:55] (03CR) 10Wfan: [C: 03+2] Move PlaceholderFiscalNumber to gateway_common [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/897901 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [16:22:21] (03PS1) 10Ejegg: Update SmashPig dependency and own version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/901243 [16:22:23] (03CR) 10Ejegg: [C: 03+2] Update SmashPig dependency and own version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/901243 (owner: 10Ejegg) [16:23:52] (03Merged) 10jenkins-bot: Move PlaceholderFiscalNumber to gateway_common [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/897901 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [16:24:02] (03Merged) 10jenkins-bot: Update SmashPig dependency and own version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/901243 (owner: 10Ejegg) [16:29:15] (03PS1) 10Ejegg: Update SmashPig + DonationInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901244 (https://phabricator.wikimedia.org/T332396) [16:33:04] (03CR) 10Ejegg: Move PlaceholderFiscalNumber to gateway_common (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/897901 (https://phabricator.wikimedia.org/T324297) (owner: 10AndyRussG) [16:34:34] Ah sorry did not see that comments think we might need in other gateway and dlocal is using that now [16:35:14] Probably safe to keep in gateway_common if other gateway also needs the document somehow? [16:35:40] safe either way, just gateway_common is crowded [16:35:54] we should really break stuff out of that folder rather than adding more [16:36:49] Oh I see will keep that in mind next time. [16:38:16] Then should we move that back to dlocal folder, or keep until we delete astropay? [16:39:49] let's move it to dlocal so we don't forget later [16:40:37] Sounds good [16:43:20] (03CR) 10CI reject: [V: 04-1] Update SmashPig + DonationInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901244 (https://phabricator.wikimedia.org/T332396) (owner: 10Ejegg) [16:45:35] (03PS2) 10Ejegg: Update SmashPig + DonationInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901244 (https://phabricator.wikimedia.org/T332396) [17:30:58] (03PS1) 10Wfan: Move PlaceholderFiscalNumber to dlocal_gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/900717 (https://phabricator.wikimedia.org/T324297) [17:32:22] (03CR) 10CI reject: [V: 04-1] Move PlaceholderFiscalNumber to dlocal_gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/900717 (https://phabricator.wikimedia.org/T324297) (owner: 10Wfan) [17:49:13] (03CR) 10Ejegg: "maybe we should hold off namespacing this for now. I think we'll want different namespaces and folder structure when we finally get around" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/900717 (https://phabricator.wikimedia.org/T324297) (owner: 10Wfan) [17:52:43] (03CR) 10Ejegg: [C: 03+2] Update SmashPig + DonationInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901244 (https://phabricator.wikimedia.org/T332396) (owner: 10Ejegg) [18:06:44] (03Merged) 10jenkins-bot: Update SmashPig + DonationInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901244 (https://phabricator.wikimedia.org/T332396) (owner: 10Ejegg) [18:08:36] (03PS1) 10Ejegg: Update donation-interface and smash-pig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/901256 [18:08:38] (03CR) 10Ejegg: [C: 03+2] Update donation-interface and smash-pig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/901256 (owner: 10Ejegg) [18:09:18] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/901257 [18:10:07] (03PS2) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/901257 [18:11:22] (03PS2) 10Wfan: [Do not merge] Move PlaceholderFiscalNumber to dlocal_gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/900717 (https://phabricator.wikimedia.org/T324297) [18:12:47] (03CR) 10CI reject: [V: 04-1] [Do not merge] Move PlaceholderFiscalNumber to dlocal_gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/900717 (https://phabricator.wikimedia.org/T324297) (owner: 10Wfan) [18:18:19] (03CR) 10AndyRussG: "Hmm just a quick not-very-important note... Thinking this over some more, I feel there might still be some justification for keeping this " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/900717 (https://phabricator.wikimedia.org/T324297) (owner: 10Wfan) [18:20:42] (03PS3) 10Wfan: [Do not merge] Move PlaceholderFiscalNumber to dlocal_gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/900717 (https://phabricator.wikimedia.org/T324297) [18:22:04] (03CR) 10CI reject: [V: 04-1] [Do not merge] Move PlaceholderFiscalNumber to dlocal_gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/900717 (https://phabricator.wikimedia.org/T324297) (owner: 10Wfan) [18:22:58] (03Merged) 10jenkins-bot: Update donation-interface and smash-pig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/901256 (owner: 10Ejegg) [18:26:05] (03PS4) 10Wfan: [Do not merge] Move PlaceholderFiscalNumber to dlocal_gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/900717 (https://phabricator.wikimedia.org/T324297) [18:33:24] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/901257 (owner: 10Ejegg) [18:34:07] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/901257 (owner: 10Ejegg) [18:42:09] !log civicrm upgraded from 3d3606f1 to 09373b9d [18:42:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:56:52] !log switched back to new PayPal pending transaction resolver [18:56:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:19:30] 10Fundraising-Backlog, 10fundraising-tech-ops: Switch-over from civi1001 to civi1002 - https://phabricator.wikimedia.org/T329882 (10Jgreen) a:03Jgreen [19:20:52] 10Fundraising-Backlog, 10fundraising-tech-ops: Switch-over from civi1001 to civi1002 - https://phabricator.wikimedia.org/T329882 (10Jgreen) [19:22:45] (03CR) 10Ejegg: [Do not merge] Move PlaceholderFiscalNumber to dlocal_gateway (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/900717 (https://phabricator.wikimedia.org/T324297) (owner: 10Wfan) [19:23:49] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, and 2 others: Figure out storage implications of varchar vs text in possible logging solution - https://phabricator.wikimedia.org/T325789 (10Jgreen) @Eileenmcnaughton... [19:38:56] ejegg: meets [20:03:32] 10Fundraising-Backlog, 10fundraising-tech-ops: Migrate process-control jobs from civi1001 to civi1002 - https://phabricator.wikimedia.org/T332632 (10Jgreen) [20:10:12] PROBLEM - check_puppetrun on frlog2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 2 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[bat] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frlog2001&service=check_puppetrun [20:11:41] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Scrolling up on reports menu broken - https://phabricator.wikimedia.org/T229113 (10AKanji-WMF) 05Open→03Resolved [20:15:12] PROBLEM - check_puppetrun on frlog2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 4 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[bat] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frlog2001&service=check_puppetrun [20:17:08] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.40-notes (1.40.0-wmf.27; 2023-03-13): CentralNotice banners being shown too many times - https://phabricator.wikimedia.org/T331671 (10AndyRussG) Just to confirm, the issue with user preferences not correctl... [20:20:12] RECOVERY - check_puppetrun on frlog2001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frlog2001&service=check_puppetrun [20:24:37] 10Fundraising Sprint Fish HEAD^, 10Fundraising-Backlog: Ingenico/Worldline addition of Initial Scheme Transaction ID to avoid recurring declines - https://phabricator.wikimedia.org/T331754 (10Ejegg) p:05Triage→03High a:03Ejegg [20:36:27] 10Fundraising-Backlog: Handle REJECTED IPNS for Dlocal - https://phabricator.wikimedia.org/T332637 (10Cstone) [20:38:03] 10Fundraising-Backlog, 10FR-dlocal: Handle REJECTED IPNS for Dlocal - https://phabricator.wikimedia.org/T332637 (10Cstone) [21:41:41] So Ram Ram has arrived - yes - that is his name [21:41:56] although it could be Ramram? or RamRam? [21:52:03] new bunny? [21:52:10] who runs into things [21:52:12] ... [21:58:36] no ... its a ... ram [22:00:15] this morning Richard & the boys found a random sheep in our drive when heading off to school. They stuck it in the front paddock & emailed the farmer they thought might own it. She came round while we had our meeting & while chatting she said her ram was out too. I said the ram was welcome to stay to .... do the business here as we needed more stock. Anyway, she brought back Ram Ram who will be on vacation here .... [22:13:36] LOL [22:14:39] so many NSFW replies rushing through my head [22:14:50] I'll refrain [22:19:45] my family wants pictures of ramram [22:31:31] lol - I will try to sort some. Although I think they will find the evidence of his visit in 5 months time rather cuter [22:38:30] eileen: everything about that is awesome :) [22:39:46] yeah - Ram Ram is pretty much a pet ram but he normally has to live a lonely life because all the sheep the farmer (Beth) has are his offspring - so it's Weekend at Bernies for him now [22:42:49] years ago when we first moved here we had a ram visit this time of year & then later for a while we had our own ram - it is way more fun when they visit cos all the lambs are born really close together & they are way sillier when there are more of them [22:47:38] very interesting! [22:51:12] (03PS1) 10Ejegg: Handle initial scheme transaction ID [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901316 (https://phabricator.wikimedia.org/T331754) [22:51:54] (03CR) 10CI reject: [V: 04-1] Handle initial scheme transaction ID [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901316 (https://phabricator.wikimedia.org/T331754) (owner: 10Ejegg) [23:00:08] (03PS2) 10Ejegg: Handle initial scheme transaction ID [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901316 (https://phabricator.wikimedia.org/T331754) [23:00:34] (03CR) 10CI reject: [V: 04-1] Handle initial scheme transaction ID [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901316 (https://phabricator.wikimedia.org/T331754) (owner: 10Ejegg) [23:00:52] (03PS3) 10Ejegg: Handle initial scheme transaction ID [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901316 (https://phabricator.wikimedia.org/T331754) [23:01:18] (03CR) 10CI reject: [V: 04-1] Handle initial scheme transaction ID [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901316 (https://phabricator.wikimedia.org/T331754) (owner: 10Ejegg) [23:10:40] (03PS4) 10Ejegg: Handle initial scheme transaction ID [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901316 (https://phabricator.wikimedia.org/T331754) [23:11:11] (03CR) 10CI reject: [V: 04-1] Handle initial scheme transaction ID [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901316 (https://phabricator.wikimedia.org/T331754) (owner: 10Ejegg) [23:15:18] (03PS5) 10Ejegg: Handle initial scheme transaction ID [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901316 (https://phabricator.wikimedia.org/T331754)