[01:17:12] (03PS4) 10Eileen: Cleanup to remove call to wmf_civicrm_get_civi_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895871 (https://phabricator.wikimedia.org/T288585) [01:17:14] (03PS4) 10Eileen: Fully remove wmf_get_civi_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/895873 (https://phabricator.wikimedia.org/T288585) [01:17:16] (03PS1) 10Eileen: Remove more watchdogs in wmf_civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902217 (https://phabricator.wikimedia.org/T288585) [01:17:18] (03PS1) 10Eileen: Remove more watchdogs from civicrm_module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902218 (https://phabricator.wikimedia.org/T288585) [01:17:20] (03PS1) 10Eileen: Remove more watchdogs from civicrm_module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902219 (https://phabricator.wikimedia.org/T288585) [01:17:22] (03PS1) 10Eileen: Remove usage of nasty api class rather than cleanup watchdog [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902220 (https://phabricator.wikimedia.org/T288585) [01:17:24] (03PS1) 10Eileen: Remove watchdog from failmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902221 (https://phabricator.wikimedia.org/T288585) [01:22:43] (03PS1) 10Eileen: Move Organization name resolver to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902223 (https://phabricator.wikimedia.org/T303986) [01:36:24] (03CR) 10CI reject: [V: 04-1] Move Organization name resolver to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902223 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [01:44:15] 10Fundraising Sprint Fish HEAD^, 10MW-1.41-notes (1.41.0-wmf.1; 2023-03-20): Please turn on Monthly Convert in Czech (csCZ) - https://phabricator.wikimedia.org/T331665 (10TSkaff) Roger that @HNordeenWMF, I ran some tests and all is looking good! @CDenes_WMF flagging you too, in case you want to run any tests... [01:47:05] (03PS2) 10Eileen: Move Organization name resolver to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902223 (https://phabricator.wikimedia.org/T303986) [02:00:49] (03CR) 10CI reject: [V: 04-1] Move Organization name resolver to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902223 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [03:05:22] (03PS3) 10Eileen: Move Organization name resolver to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902223 (https://phabricator.wikimedia.org/T303986) [03:15:37] (03PS1) 10Eileen: Move Organization name resolver to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902230 (https://phabricator.wikimedia.org/T303986) [03:16:22] (03Abandoned) 10Eileen: Move Organization name resolver to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902223 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [03:26:26] (03PS2) 10Eileen: Move Organization name resolver to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902230 (https://phabricator.wikimedia.org/T303986) [03:39:54] (03CR) 10CI reject: [V: 04-1] Move Organization name resolver to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902230 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [04:09:44] (03PS3) 10Eileen: Move Organization name resolver to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902230 (https://phabricator.wikimedia.org/T303986) [04:46:44] (03PS1) 10Eileen: Move anonymousContact retrieval to extension helper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902231 (https://phabricator.wikimedia.org/T303986) [05:01:02] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint Everything I Merge I Merge For You, and 11 others: Creating New Matching Gift Import - https://phabricator.wikimedia.org/T303986 (10Eileenmcnaughton) [05:01:16] (03PS1) 10Eileen: Simplify create contact [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902232 (https://phabricator.wikimedia.org/T303986) [08:28:58] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/902262 (owner: 10L10n-bot) [08:48:12] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/902262 (owner: 10L10n-bot) [12:45:09] hey damilare. I was gonna add the india recurring diagrams to https://wikitech.wikimedia.org/wiki/Fundraising/Data_and_flow/PSP_integrations/dLocal but just wanted to make sure your not making updates that cause you to lose anything [12:46:49] hi jgleeson, 'm working on the documentation for those and I'd add them alongside. It would have been there today but for an issue I had yesterday that made me lose all my edits. [12:47:47] ok cool thanks [12:48:43] if you check this link, you'd find the images. https://wikitech.wikimedia.org/wiki/Special:Log?type=&user=Damilare_Adedoyin&page=&wpdate=&tagfilter=&wpfilters%5B%5D=newusers&wpFormIdentifier=logeventslist [12:56:22] thanks damilare [13:29:21] (03CR) 10Jforrester: [C: 03+2] build: Updating npm dependencies [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/901702 (owner: 10Libraryupgrader) [13:39:52] (03CR) 10Jforrester: [V: 03+2 C: 03+2] "Force merging whilst we wait for FR to fix this breakage." [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/900711 (https://phabricator.wikimedia.org/T220036) (owner: 10Zoranzoki21) [14:13:43] 10Fundraising-Backlog, 10FR-dlocal: Add smashpig listener server config to allow Authorization header - https://phabricator.wikimedia.org/T332891 (10jgleeson) [14:13:45] 10Fundraising-Backlog, 10FR-dlocal, 10fr-donorservices: mask CVV digits on dLocal donation form - https://phabricator.wikimedia.org/T332890 (10MBeat33) [14:14:51] 10Fundraising-Backlog, 10FR-dlocal: Add smashpig listener server config to allow Authorization header - https://phabricator.wikimedia.org/T332891 (10jgleeson) [14:15:32] 10Fundraising-Backlog, 10FR-dlocal: Add smashpig listener server config to allow Authorization header - https://phabricator.wikimedia.org/T332891 (10jgleeson) [14:18:08] ejegg|away: cstone I wasn't happy burying that apache-specific headers method in the internals of smashpig so I did a bit of digging and it looks like we can get the Authorization header after all. The reason we can't see it is that Apache doesn't send it to scripts by default as it's commonly used for basic auth. I added notes here https://phabricator.wikimedia.org/T332891. I managed to get it [14:18:10] working after enabling that directive. [14:28:28] 10Fundraising-Backlog, 10FR-dlocal: Add smashpig listener server config to allow Authorization header - https://phabricator.wikimedia.org/T332891 (10jgleeson) To get this working on fundraising-dev, I did the following: - **Local Docker Update**: -- `docker-compose exec -u root smashpig bash` // you need to... [14:34:07] (03PS1) 10Jgleeson: Refactor how we get HTTP headers in the dLocal Listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902405 (https://phabricator.wikimedia.org/T332637) [14:34:49] 10Fundraising-Backlog, 10FR-dlocal: Add smashpig listener server config to allow Authorization header - https://phabricator.wikimedia.org/T332891 (10jgleeson) [14:34:51] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Handle REJECTED IPNS for Dlocal - https://phabricator.wikimedia.org/T332637 (10jgleeson) [14:43:18] (03PS2) 10Jgleeson: WIP: add rejected IPN handling to dlocal listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901701 (https://phabricator.wikimedia.org/T332637) [14:43:44] (03CR) 10CI reject: [V: 04-1] WIP: add rejected IPN handling to dlocal listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901701 (https://phabricator.wikimedia.org/T332637) (owner: 10Jgleeson) [14:56:25] (03PS3) 10Jgleeson: WIP: add rejected IPN handling to dlocal listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901701 (https://phabricator.wikimedia.org/T332637) [14:56:51] (03CR) 10CI reject: [V: 04-1] WIP: add rejected IPN handling to dlocal listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901701 (https://phabricator.wikimedia.org/T332637) (owner: 10Jgleeson) [15:23:47] heyyy fr-tech [15:24:05] jgleeson|skrun: I'm starting on review of patches linked to https://phabricator.wikimedia.org/T332637 [15:35:17] (03CR) 10AndyRussG: Refactor how we get HTTP headers in the dLocal Listener (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902405 (https://phabricator.wikimedia.org/T332637) (owner: 10Jgleeson) [15:35:28] ^ just an initial drive-by comment [15:51:16] dwisehaupt Jeff_Green have you seen this task? https://phabricator.wikimedia.org/T332891 [15:51:36] also tiny unimportant question, I didn't see batcat on civi1001? [15:51:50] nope [15:52:13] batcat is only on the loggers since that's where it was requested. we could put it on other roles if needed. [15:52:43] afaik there's no buster package for it, but we can put it on civi1002 for the near future [15:55:04] ah thanks dwisehaupt Jeff_Green yeah I just was poking at some logs on civi1001, yeah not urgent [15:55:16] (wrt batcat) [15:55:59] the linked task however does seem urgent, at least to evaluate if it's something you'd be ok with? [15:56:09] since it impacts code for dlocal currently in review [15:56:18] *somewhat urgent [15:56:47] (sorry not really for me to say if it's urgent or not like that, just a thought) [16:04:09] the concept seems fine to me [16:06:57] AndyRussG: I don't think they're ready for review just yet [16:09:15] 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog (Android Release FY2022-23): Japan fundraising messages in Android app - https://phabricator.wikimedia.org/T332230 (10Dbrant) Reminder for testing: to see this announcement, you must override your GeoIP country to be Japan: * Go to Developer Set... [16:11:29] 10Fundraising Sprint Fish HEAD^, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Testing: Card tests in India and in Brazil are paused at pending for 3DS authorization - https://phabricator.wikimedia.org/T332831 (10XenoRyet) p:05Triage→03High [16:14:34] 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-dlocal: Add smashpig listener server config to allow Authorization header - https://phabricator.wikimedia.org/T332891 (10Jgreen) [16:20:54] (03PS2) 10Ejegg: Make subscription frequency configurable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) [16:31:37] 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog (Android Release FY2022-23): Japan fundraising messages in Android app - https://phabricator.wikimedia.org/T332230 (10Pcoombe) @Dbrant @Seddon The correct ISO country code for Japan is JP, so looks like that will need to be changed. Sorry, I shou... [16:48:57] 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog (Android Release FY2022-23): Japan fundraising messages in Android app - https://phabricator.wikimedia.org/T332230 (10Dbrant) [facepalm] Don't know how that slipped past us all! [18:14:31] dwisehaupt: Jeff_Green AndyRussG. that ticket wasn't urgent. sorry if it was confusing dwisehaupt. I only made it an hour before AndyRussG mentioned it. It would be great to get next week but we don't need it to make progress locally. AndyRussG I've added instructions for folks to use and test it locally https://phabricator.wikimedia.org/T332891#8721401 [18:15:17] fr-tech anyone want to review the 3ds patches or the config-for-monthly patch? [18:15:27] sure [18:15:35] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/902200 [18:15:38] on your EOD? [18:15:42] ah, thanks [18:15:44] yep yep, there too [18:16:03] thanks jgleeson [18:16:18] yes, thanks! [18:19:57] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Fundraising access request for Salvatore Borriello - https://phabricator.wikimedia.org/T331491 (10Dwisehaupt) [18:20:21] jgleeson: sounds good, it looks straightforward, the only thing that will take more than a minute is making sure we fully understand what the apache directive does, but at first glance it looks pretty simple [18:22:22] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Fundraising access request for Salvatore Borriello - https://phabricator.wikimedia.org/T331491 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt Worked through a config and key naming issue this morning and we were able to get he connecti... [18:24:50] 10Fundraising-Backlog: Update fundraising analysis tools to use Python 3 - https://phabricator.wikimedia.org/T213949 (10Pcoombe) 05Open→03Resolved [18:39:13] ejegg: [18:39:43] did you consider putting the UPI stuff in the HostedPaymentApiRequestMapper [18:43:58] jgleeson: so that's where it will get mapped [18:44:10] oh you mean to have that read the config directly? [18:44:34] I am hoping to contain config access to as few points as possible [18:45:36] ah I guess I should only map that if it's recurring [18:46:19] and i guess do the validation there too [18:46:22] ejegg: I'm talking about the decision making about which one to use if it's not set and validating it's a valid selection [18:46:54] ok, i can try to move most of it down there [18:46:58] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/902200/2/PaymentProviders/dlocal/Api.php#104 [18:47:04] just pass in the raw configged value in the params [18:47:34] also do other payment methods come through redirectedHostedPayment? .https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/902200/2/PaymentProviders/dlocal/Api.php#191 [18:49:46] (03CR) 10Jgleeson: "Review from IRC:" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) (owner: 10Ejegg) [18:57:22] jgleeson: yes, maybe we should strengthen that if condition to only add those params when country is 'IN' as well [19:12:59] hmm, we could make that end date configurable as well [19:13:25] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for lnavarro - https://phabricator.wikimedia.org/T301701 (10Dwisehaupt) Certificate renewed and sent via email. Password sent via SMS. [19:14:50] (03PS3) 10Ejegg: Make subscription frequency configurable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) [19:15:21] (03PS2) 10Jgleeson: Dlocal: set use_3d_secure when configured [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/902204 (https://phabricator.wikimedia.org/T332831) (owner: 10Ejegg) [19:16:07] (03PS4) 10Ejegg: Make subscription frequency configurable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) [19:16:12] (03CR) 10CI reject: [V: 04-1] Make subscription frequency configurable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) (owner: 10Ejegg) [19:17:03] (03CR) 10CI reject: [V: 04-1] Make subscription frequency configurable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) (owner: 10Ejegg) [19:19:05] (03PS5) 10Ejegg: Make subscription frequency configurable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) [19:22:12] fr-tech since that 2099 date was looking sus, we should probably make that configurable too, huh? We could experiment with 5 or 10 yrs [19:23:00] so should the config val be just a date, or a time interval (i.e 10 years)? [19:29:22] (03CR) 10Ejegg: "thanks for the review jgleeson. I've moved that logic in the latest PS, and limited those extra params to just UPI recurring" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) (owner: 10Ejegg) [19:39:00] jgleeson: thanks for starting on the review with https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/902200 ... quick question: if you have to drop off before review is completed, would you be ok with me continuing with the review and in that case potentially +2'ing if everything looks good? [19:42:34] I would think interval for the date config value. 10 years is probably a good place to start as well, but we should maybe ask someone on the stakeholder side what they want. [19:46:05] (03CR) 10Jgleeson: [C: 04-1] "This didn't work as is. I got it redirecting with the following changes:" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/902204 (https://phabricator.wikimedia.org/T332831) (owner: 10Ejegg) [19:47:08] (03CR) 10Ejegg: "thanks jgleeson! I'll add those fixes" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/902204 (https://phabricator.wikimedia.org/T332831) (owner: 10Ejegg) [19:49:28] ust gonna rereview the ejegg's updates AndyRussG but will let you know if it looks like more than I can do before hopping off [19:49:31] just* [19:50:06] (03PS3) 10Ejegg: Dlocal: set use_3d_secure when configured [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/902204 (https://phabricator.wikimedia.org/T332831) [19:50:22] cool thanks much jgleeson! [19:50:33] looks like there's a few other good ones in ejegg's EOD to review AndyRussG particularly 'Remove orphan_slayer and DonationInterface' https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/886207 [19:50:43] (03CR) 10Ejegg: "ok jgleeson, fixed in PS3" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/902204 (https://phabricator.wikimedia.org/T332831) (owner: 10Ejegg) [19:50:46] that would be a nice one to get over the line [19:50:53] ejegg: read the last bit [19:51:07] or did you fix the return URL too [19:51:19] might be worth a smoke test your side [19:51:25] ahh, nope, will look at that now [19:51:34] (03CR) 10CI reject: [V: 04-1] Dlocal: set use_3d_secure when configured [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/902204 (https://phabricator.wikimedia.org/T332831) (owner: 10Ejegg) [19:51:40] heh, yeah, sorry to be so lazy [19:52:07] jgleeson: yeah for sure [19:52:11] and thanks! [19:52:22] (wrt EOD notes) [19:52:32] oh, needs test update too [20:01:23] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10SRE, 10netops: Please update bootp helper on pfw3-eqiad to point to frpm1002 for fundraising subnets - https://phabricator.wikimedia.org/T332939 (10Dwisehaupt) [20:08:58] wat, no POST value at all when they redirect us back after 3DS? [20:11:24] 10Fundraising-Backlog, 10FR-dlocal: dLocal audit file check - https://phabricator.wikimedia.org/T332943 (10MBeat33) [20:29:20] (03CR) 10Jgleeson: "Thanks for the updates ejegg, they're great. I tested this by adding 'upi_subscription_frequency: MONTH' to the API constructor params and" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) (owner: 10Ejegg) [20:31:15] (03CR) 10Ejegg: Make subscription frequency configurable (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) (owner: 10Ejegg) [20:32:22] ah so the params assignment is ephemeral ejegg ? [20:32:51] jgleeson: so it is just ignored by the mappers except for recurring upi [20:33:13] I guess when I look at that alone in the API method, it looks important [20:33:27] and not something that will be disregarded downstream [20:33:57] I can add a comment to that effect, or repeat the recurring upi test [20:35:03] so I'm annoyed at the 3ds redirect - looks like there are no parameters at all on the POST back to the callback URL [20:35:04] 10Fundraising-Backlog: UZS Donation Form Error - https://phabricator.wikimedia.org/T332945 (10AKanji-WMF) [20:35:37] 10Fundraising-Backlog: UZS Donation Form Error - https://phabricator.wikimedia.org/T332945 (10Cstone) This is the error from Ingenico 2023-03-23T19:39:40+00:00 [INFO] Initiating cURL 2023-03-23T19:39:40+00:00 [INFO] Preparing to send POST request to https://world.api-ingenico.com/v1/6570/hostedcheckouts 2... [20:36:10] I guess we need to do a status lookup to figure out whether the 3ds auth was successful? [20:36:18] or just blindly try to capture... [20:37:00] 10Fundraising-Backlog: UZS Donation Form Error - https://phabricator.wikimedia.org/T332945 (10AKanji-WMF) [20:37:07] yeah if don't mind. wrap it in something like $this->checkIfPaymentIsUPI($params['payment_submethod']) just so it's obvious why it's there [20:37:26] so also check for recurring there too? [20:39:17] I mean just checking if it's UPI in https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/902200/5/PaymentProviders/dlocal/Api.php#182 to save setting an unused $param value for non-upi calls [20:39:41] right, it's also unused for one-time UPI [20:39:50] so I'll check for recurring too [20:40:00] oh I see. I didn't think it through that far sorry [20:40:02] (03PS6) 10Ejegg: Make subscription frequency configurable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) [20:40:50] ejegg: I think the commit message needs a 's/subscription_frequency_unit: MONTHLY/upi_subscription_frequency: MONTHLY/' [20:40:54] oops [20:41:00] try that again [20:41:01] ah yeah [20:41:04] also just MONTH [20:41:04] ejegg: I think the commit message needs a 's/subscription_frequency_unit: MONTHLY/upi_subscription_frequency: MONTH/' [20:41:19] yep [20:41:39] (03PS7) 10Ejegg: Make subscription frequency configurable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) [20:41:43] good catch [20:42:55] so... how to deal with the no-params resultswitcher post for 3ds? [20:43:20] add another flag on the return_url? or a session flag? [20:43:56] hmm [20:45:53] ejegg: do we pick up the outcome of 3ds trxns via the IPN? [20:47:34] trying to work out how we know it was successful if we don't get a payload during the donor return https://docs.dlocal.com/docs/3d-secure#electronic-commerce-indicator-eci-value [20:48:15] drive by comment but as far as I know we don't get IPNS for cc transactions but maybe 3ds are special? [20:48:34] yeah I was wondering how we work that out otherwise [20:48:50] sounds like another qustion for docal if we don't get IPNs [20:49:23] Joaquin will be looking forward to Monday [20:51:52] jgleeson I guess we just have to do another status lookup? [20:52:32] would be nice to have more documentation of what to to after customer comes back to callback_url on this page: https://docs.dlocal.com/docs/3d-secure [20:52:44] 'Once the user completed the authentication successfully, the payment will be processed and the user will be redirected to the callback_url.' [20:53:04] damn I didn't get to the maxmind stuff. if anyone else wants to check up on those you can just search for 'MaxMind minFraud Alert' in emails and look into the 4-5 trxns relating to yesterdays revised scores. if not I'll pick it up tomorrow. thanks in advance! [20:56:48] sure checking jgleeson [20:58:01] ejegg: ok I see we get a payment_id back so we could keep hold of it and look it up on a return back to us. For the other flows we use the ID sent back I think but we might not need to [20:58:04] thanks damilare [20:59:33] 10Fundraising-Backlog, 10FR-dlocal: dLocal audit file check - https://phabricator.wikimedia.org/T332943 (10Cstone) Thanks for checking this @MBeat33 ! We don't have an audit file set up for this testing account yet, trying to get it working in {T324347} [21:13:02] 10Fundraising-Backlog, 10FR-dlocal: dLocal audit file check - https://phabricator.wikimedia.org/T332943 (10MBeat33) 05Open→03Resolved a:03MBeat33 Thanks, @Cstone for the info - I'll subscribe to that and close this as a duplicate [21:23:11] huh, i tried with all the test card numbers, doing a status lookup with e.g. php PaymentProviders/dlocal/Maintenance/TestGetPaymentStatus.php T-413092-34ccd114-407f-4705-a042-0de0cbb53416 [21:23:23] and all came back as status REJECTED [21:32:20] 10Fundraising-Backlog: Declines in Italy for no 3DS - https://phabricator.wikimedia.org/T332950 (10EMartin) [21:32:24] fr-tech anyone want to pick up on the review for the recurring unit configurability? I'd like to get that out today so rakhi can tell us what it looks like [21:33:46] https://gerrit.wikimedia.org/r/902200 [21:33:55] ejegg: yep sure :) [21:41:26] thanks! [21:41:45] I think I got everything he mentioned on gerrit + on IRC [21:42:03] (for that patch - i'm still working on the 3ds one) [21:55:23] I'm still about [21:55:39] was saying goodnight to the kids [21:55:51] did you update it ejegg ? [21:56:44] ps7 added that last check you asked for jgleeson [21:57:19] and the commit message update [21:57:27] (03CR) 10Jgleeson: "Thanks for the updates. One minor change and then it's +2able!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) (owner: 10Ejegg) [21:57:28] ah oki I'll look at other stuff meanwhile [21:58:13] 10Fundraising-Backlog: Missing authorization header from dlocal ipns in production - https://phabricator.wikimedia.org/T332951 (10Cstone) [21:58:24] 10Fundraising-Backlog, 10FR-dlocal: Missing authorization header from dlocal ipns in production - https://phabricator.wikimedia.org/T332951 (10Cstone) [22:01:04] (03PS8) 10Ejegg: Make subscription frequency configurable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) [22:01:23] ok jgleeson, methodized ^^^ [22:01:30] (03CR) 10CI reject: [V: 04-1] Make subscription frequency configurable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) (owner: 10Ejegg) [22:03:15] arrr [22:03:53] (03PS9) 10Ejegg: Make subscription frequency configurable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) [22:04:12] k, linted [22:07:37] ok I have to ask [22:07:51] how come the method is a public static, do you think it might be used elsewhere? [22:07:58] ejegg: [22:08:09] it's not blocking [22:12:46] to be super picky, I feel that if we were gonna have a general purpose static method for checking UPI recurringness then it probably shouldn't live in the API class as it doesn't feel like a responsibility of that class, but in the interests of getting it merged, we can live with it! :) [22:13:18] (03CR) 10Jgleeson: [C: 03+2] "Thanks for the work on this!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) (owner: 10Ejegg) [22:13:56] (03Merged) 10jenkins-bot: Make subscription frequency configurable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902200 (https://phabricator.wikimedia.org/T332828) (owner: 10Ejegg) [22:14:35] thanks! [22:14:56] ah i figured either there or the mapper [22:15:24] since the mapper does the same check [22:16:44] oh I see ejegg. I missed the call to it from the mapper also. I clicked view diff on the last PS uploaded and it didn't show it. Ok I see it now thanks [22:30:30] thanks ejegg jgleeson|away !!!!!! :) [22:30:58] 10Fundraising-Backlog: Declines in Italy for no 3DS - https://phabricator.wikimedia.org/T332950 (10EMartin) Note, I have found some functionality in the Adyen console and set some 3DS rules to see their impact. {F36925003} [23:09:57] (03PS3) 10Ejegg: Respect result.redirect in dlocal.js [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/902177 (https://phabricator.wikimedia.org/T324302) [23:09:59] (03PS4) 10Ejegg: Dlocal: set use_3d_secure when configured [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/902204 (https://phabricator.wikimedia.org/T332831) [23:20:12] (03PS1) 10Ejegg: DLocal: Allow configuring UPI subscription length [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902514 [23:20:38] (03CR) 10CI reject: [V: 04-1] DLocal: Allow configuring UPI subscription length [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902514 (owner: 10Ejegg) [23:22:02] (03PS2) 10Ejegg: DLocal: Allow configuring UPI subscription length [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902514 [23:23:20] fr-tech one more configurability patch (for the end date) ^^^ [23:23:35] 10Fundraising-Backlog: Declines in Italy for no 3DS - https://phabricator.wikimedia.org/T332950 (10AKanji-WMF) Thanks @EMartin - please let us know the outcome - otherwise @Ejegg mentioned this could be a settings change on our end. [23:23:55] ok ejegg|afk [23:26:27] damilare|away: thanks for the minfraud follow-up! (sorry for the late ping ;) ) [23:27:24] ejegg ^ will that one (for subscription length) require a DI patch too? [23:35:52] oh I see rather a config update [23:35:55] okii