[04:56:58] (03PS1) 10Ejegg: Update smash-pig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/902543 [04:57:01] (03CR) 10Ejegg: [C: 03+2] Update smash-pig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/902543 (owner: 10Ejegg) [04:57:23] ejegg|afk: ^ planning to do a deploy? [04:58:21] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/902544 [04:58:24] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/902544 (owner: 10Ejegg) [04:58:33] (03Merged) 10jenkins-bot: Update smash-pig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/902543 (owner: 10Ejegg) [04:58:45] hiiiiii [04:59:01] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/902544 (owner: 10Ejegg) [05:01:55] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/902546 [05:01:59] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/902546 (owner: 10Ejegg) [05:02:28] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/902546 (owner: 10Ejegg) [05:02:49] (03PS1) 10Ejegg: Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/902548 [05:02:52] (03CR) 10Ejegg: [C: 03+2] Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/902548 (owner: 10Ejegg) [05:04:24] !log payments-wiki upgraded from 4d0c90b4 to 4b0a71fa [05:04:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [05:04:29] hi AndyRussG [05:04:41] yep, deploying that monthlyness [05:05:04] so maybe rakhi can test and let us know if it still talks about the 5000 INR [05:05:35] and deploying the standalone listener to at least get the logging prefix [05:06:02] oh right, we can even see the first step of that ourselves [05:07:37] oops, we're mixing _ and - in the dlocal config now [05:07:49] why did we ever use - ??? [05:10:52] !log Standalone SmashPig upgraded from 3b84e4cb to 50139e82 [05:10:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [05:11:07] (03Merged) 10jenkins-bot: Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/902548 (owner: 10Ejegg) [05:11:29] so the other one is only for the subscription length, right? [05:11:59] argh, it still says 'Upto 5,000' on the PayTM site [05:12:18] so that's not much improvement [05:12:40] AndyRussG: right, the 2099 expiration date looked pretty bad to her [05:13:11] so it would be nice to be able to set that to something more reasonable [05:13:56] ehh, I guess I don't need to ask her to test again if it says it right there [05:14:12] I'm going to sign back off, then [05:15:36] ejegg thanks!!! [06:50:34] (03CR) 10AndyRussG: [C: 03+2] "LGTM! Thanks for this! Also pushed a related config-private update." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902514 (owner: 10Ejegg) [06:51:06] (03Merged) 10jenkins-bot: DLocal: Allow configuring UPI subscription length [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902514 (owner: 10Ejegg) [06:57:47] (03PS1) 10AndyRussG: dlocal API constructor params for UPI recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902569 [11:53:58] np greg-g [12:34:10] (03CR) 10Jgleeson: "Thanks. I left some comments inline on the default value you've gone with and whether we need a default at all." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902569 (owner: 10AndyRussG) [13:36:47] 10Fundraising-Backlog: Add multi-byte support when checking field name lengths in CiviCRM. - https://phabricator.wikimedia.org/T332991 (10jgleeson) [13:37:05] 10Fundraising-Backlog: Add multi-byte support when checking max field lengths in CiviCRM. - https://phabricator.wikimedia.org/T332991 (10jgleeson) [13:38:07] (03PS1) 10Jgleeson: Add multi-byte support when checking max field lengths [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902708 (https://phabricator.wikimedia.org/T332991) [13:39:48] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Add multi-byte support when checking max field lengths in CiviCRM. - https://phabricator.wikimedia.org/T332991 (10jgleeson) [13:40:06] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Add multi-byte support when checking max field lengths in CiviCRM. - https://phabricator.wikimedia.org/T332991 (10jgleeson) a:03jgleeson [13:51:26] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Add multi-byte support when checking max field lengths in CiviCRM. - https://phabricator.wikimedia.org/T332991 (10jgleeson) When the associated patch gets merged, we should requeue https://civicrm.wikimedia.org/damaged/529084 [13:52:40] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Add multi-byte support when checking max field lengths in CiviCRM. - https://phabricator.wikimedia.org/T332991 (10jgleeson) [14:10:54] Today's music recommendation fr-tech is Coldplay - Parachutes. That album is 23 years old now, crazy. I remember buying it at 16 and listenng to it on repeat and loving it :) There's also a great video for the song Shiver from the album, showing some archive footage of the band before they made it big https://www.youtube.com/watch?v=u8XFFTWwSvY Good memories! [14:11:30] Thanks for making me feel old 🥲 [14:11:38] ha sorry! [14:11:54] It's okay, all my fave music does that [16:01:27] 10Fundraising-Backlog: Add new dLocal UPI field 'subscription_max_amount' - https://phabricator.wikimedia.org/T333014 (10jgleeson) [16:25:29] 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Update DLocal createPayment for UPI / DIRECT method - https://phabricator.wikimedia.org/T324294 (10AnnWF) [16:25:51] 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Update DLocal createPayment for UPI / DIRECT method - https://phabricator.wikimedia.org/T324294 (10AnnWF) a:03AnnWF [16:39:52] wfan: checkout https://phabricator.wikimedia.org/T333014 [16:41:08] oh nice so we can control the text from dlocal with subscription_max_amount [16:41:15] thanks jegleeson [16:41:19] yep! [16:42:26] while I think we might still want that text from DI level to prevent larger amount from frontend? [16:43:44] 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-dlocal: Add smashpig listener server config to allow Authorization header - https://phabricator.wikimedia.org/T332891 (10Dwisehaupt) This has been added. Please feel free to test more. `[frack::puppet] 7e9c02cf Adding "CGIPassAuth On" to payments-listener... [16:44:10] 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-dlocal: Add smashpig listener server config to allow Authorization header - https://phabricator.wikimedia.org/T332891 (10jgleeson) Thanks @Dwisehaupt ! [17:47:21] 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-dlocal: Add smashpig listener server config to allow Authorization header - https://phabricator.wikimedia.org/T332891 (10jgleeson) I just checked the production logs, and I can see we're still getting the '//INVALID dlocal IPN message with no authorization... [17:48:29] fr-tech I have an idea regarding the missing Auth header on dlocal IPNs. I'm going to send a simulated dLocal IPN to our production listener endpoint with an Authorization header and then see what happens in the logs. If we get the same error, then it's likely we are, in fact, stripping it at the web server layer, but if we don't, it gives us something to go back to dLocal with. [17:51:48] jgleeson|brb: i'm continuing on with testing the nginx options too. [17:53:59] 10Fundraising-Backlog: Declines in Italy for no 3DS - https://phabricator.wikimedia.org/T332950 (10EMartin) I spot checked the within the 1000 available rows of data in the Adyen console today. I did not find any declines for 3DS in that sample, since invoking the 3DS rules. It appears the 3DS rules had a posi... [18:39:16] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising Sprint Fish HEAD^, 10Fundraising-Backlog, and 4 others: Ensure DLocal recurring card payments can be charged via Civi SmashPig recurring charge job - https://phabricator.wikimedia.org/T324298... [18:41:03] (03CR) 10Wfan: [C: 03+2] Remove watchdog from failmail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902221 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [18:47:53] oh man [18:48:12] dwisehaupt: Jeff_Green you can stop looking a the nginx stuff to figure out that authorizaton header bug [18:48:25] cstone: you will laugh when you see this [18:48:51] (03PS1) 10Jgleeson: dLocal IPN fix: switch to $headers['Authorization'] [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902765 [18:49:43] We are checking for $headers['authorization'] but they are sending $headers['Authorization'] ha [18:50:05] I just tested it and it works with the fix [18:50:16] fr-tech ^ [18:50:59] aaaa [18:51:21] sorry I meant, Aaaa [18:52:01] nice catch eh!!! [18:54:22] Omg what [18:54:23] 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Missing authorization header from dlocal ipns in production - https://phabricator.wikimedia.org/T332951 (10jgleeson) Ok it looks like this was just a casing issue. We were checking for the header using: ` if ( !isset( $headers['authorization'] ) ) {... [18:54:33] ha [18:54:36] And their sandbox sent authorization??? [18:54:48] (03CR) 10Wfan: [C: 04-1] "https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-3-logger-interface.md#12-message context val should be able to convert t" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902218 (https://phabricator.wikimedia.org/T288585) (owner: 10Eileen) [18:54:52] maybe cstone [18:55:45] we can deploy that code Monday to confirm but it does look wrong based on the docs [18:55:49] jgleeson: did we need CGIPassAuth or should we back that out? [18:56:00] yes we still need that one dwisehaupt [18:56:16] ok cool. just checking. :) [18:57:01] jgleeson: we should make it case insensative cause sandbox has lower a also im passing it through later on [18:57:04] ill comment on the patch [18:57:06] funny but fitting for how things go. :) [18:57:07] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Missing authorization header from dlocal ipns in production - https://phabricator.wikimedia.org/T332951 (10jgleeson) [18:57:18] cstone: feel free to update the patch [18:57:34] I'm wrapping up for today [18:57:38] thanks jgleeson [18:57:45] and much easier to fix than some chaos lost header hah [18:58:05] yes it was! I only realised when I was testing with postman to the live endpoint [18:58:10] I wish I'd seen it earlier [18:58:21] have a good weekend all! [19:37:25] of course xdebug decides to misbehave [20:02:48] (03PS2) 10Cstone: dLocal IPN fix: set the headers all to lowercase [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902765 (owner: 10Jgleeson) [20:04:01] 10Fundraising-Backlog: Declines in Italy for no 3DS - https://phabricator.wikimedia.org/T332950 (10EMartin) @AKanji-WMF Hi Anil, I was able to connect with Adyen on the stat of the situation in Italy. They further advise that while I have initiated the 3DS logic, it is NOT WORKING due to a configuration on the... [20:06:10] 10Fundraising-Backlog: Add new dLocal UPI field 'subscription_max_amount' - https://phabricator.wikimedia.org/T333014 (10AnnWF) a:03AnnWF [20:30:51] that lower case fix seems like it should dtrt. and the other header check for x-date is already all lower case so it shouldn't have knock on effects there. [20:31:42] oh, but it's referenced in a different way so isn't covered by the lowering. [20:31:54] yeah it tested fine with the sandbox ipns so if we just force it all to be the same [20:31:59] ooh is it coming from symfony [20:33:03] x-date is coming from $request->headers->get( 'x-date' ); as compared to the $headers = getallheaders() for the other. [20:33:07] bah they are all capital on the live I bet [20:33:08] yeah [20:33:13] hmmmmm [20:33:44] cause jack has other code to get rid of getallheaders [20:34:40] sorry, don't want to confuse things. just checking to make sure it passed my sniff test and that nothing else was needed from us. [20:35:15] yeah i dont think from you the refactor of getallheaders is a related but separate issue [20:37:26] but for just testing next week ill swap them out [20:43:20] (03PS3) 10Cstone: dLocal IPN fix: set the headers to lowercase [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902765 (owner: 10Jgleeson) [20:50:05] Hi folks - I don't know if you've seen Evelyn's update above to https://phabricator.wikimedia.org/T332950 - sounds like there may be a setting on our end we need to enable? If we have time to look that would be great; it impacts an Italy campaign live right now. [20:52:13] hmm [20:55:56] elliott said yesterday it should be a quick settings change lets see if i can find them hha [20:57:45] 🙏🏽 thank you cstone [21:00:42] I think I found it anilk just aware its friday afternoon and if we can even test it without having an italy card [21:01:00] im going to try and test my card with sweden to see if that triggers the 3ds flow there [21:02:17] ok cool my card does trigger it for sweden [21:03:33] Should I ask for an Italy card? [21:03:40] no i think I can test it [21:03:46] i see the flow is different for sweden [21:03:49] 💳 [21:10:28] fr-tech is anyone around to review turning on 3DS in Italy [21:10:36] I added IT to the countries array in localsettings [21:11:33] cstone I can look in 10 min [21:18:56] hah the tabbening is happening im losing favicons [21:19:12] ohhhh [21:19:50] oh. i should eat lunch. i keep forgetting to do that. [21:20:52] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Parsoid, 10Parsoid-Rendering: Make CentralNotice extension compatible with Parsoid - https://phabricator.wikimedia.org/T272936 (10ssastry) For now, we can continue to rely on the legacy parser for handling wikitext in banners. No need to block... [21:21:48] cstone: looks good to me! [21:21:59] ok im going to deploy that and test with my card [21:22:00] dwisehaupt: same happened to me and I haven't noticed yet [21:22:15] i just ate a bunch of slightly stale cheezits so hope both your lunches are better [21:23:48] ok cool see 3ds redirect [21:24:43] 10Fundraising-Backlog: Declines in Italy for no 3DS - https://phabricator.wikimedia.org/T332950 (10Cstone) I just turned 3DS on for Italy and saw the redirect with a test payment. [21:24:43] 💥 [21:24:46] that's a firework [21:24:59] looks more like an explosion :P [21:25:13] so says the emoji gods [21:25:40] let me look on the linux laptop [21:25:49] still explosion haha [21:26:16] to be fair when i hover over it it says boom, I just thought it was a firework [21:27:25] huh is there no firework emoji then?? [21:27:36] 🎆 hmm [21:27:42] looks the same hah [21:28:04] 🎆 [21:28:07] oh yeahhh! [21:57:29] lunch of champions: a bagel with cream cheese, an orange, and a few pieces of chocolate. [21:59:57] Orange! you remind me a youtube video that an influencer recommend everyone try to eat an orange when you are taking shower haha [22:00:36] ha! [22:00:48] nope, just finishing up the fruit from the sunday market [22:01:04] https://www.youtube.com/watch?v=F60S2z58lxk [22:04:27] the internet is weird [22:05:32] lol [22:15:37] of course, i am also a person that says "i should learn another song on the piano" and chooses the Wii Shop Channel song. [22:15:59] so.... [22:25:25] 10Fundraising-Backlog: Declines in Italy for no 3DS - https://phabricator.wikimedia.org/T332950 (10EMartin) I see transactions not authenticated after 2:24 when you posted @cstone: {F36926267} [22:27:23] 10Fundraising-Backlog: Declines in Italy for no 3DS - https://phabricator.wikimedia.org/T332950 (10Cstone) Hmm I saw the redirect on my own test transaction and saw a couple of EUR IT donations with them in the console, is there some that don't support it somehow? [22:27:28] 10Fundraising-Backlog: Declines in Italy for no 3DS - https://phabricator.wikimedia.org/T332950 (10EMartin) @cstone: see another example. Above Adyen states that we have to send the browser info if that is relevant to us turning on the rules for 3DS to work.... {F36926272}. [22:28:29] 10Fundraising-Backlog: Declines in Italy for no 3DS - https://phabricator.wikimedia.org/T332950 (10EMartin) yes, possibly. Let me keep an eye on it over the weekend and hopefully things improve with what you did @Cstone [22:51:42] (03PS1) 10Wfan: Add test link for direct upi [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/902824 (https://phabricator.wikimedia.org/T324295) [22:55:13] (03PS1) 10Wfan: Add upi id field for direct upi [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/902609 (https://phabricator.wikimedia.org/T324295) [22:57:01] (03CR) 10CI reject: [V: 04-1] Add upi id field for direct upi [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/902609 (https://phabricator.wikimedia.org/T324295) (owner: 10Wfan) [22:58:44] (03PS2) 10Wfan: Add upi id field for direct upi [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/902609 (https://phabricator.wikimedia.org/T324295) [23:34:29] (03PS3) 10Wfan: Add upi id field for direct upi [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/902609 (https://phabricator.wikimedia.org/T324295) [23:59:49] (03CR) 10Eileen: [C: 03+2] Add multi-byte support when checking max field lengths [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/902708 (https://phabricator.wikimedia.org/T332991) (owner: 10Jgleeson)