[00:26:35] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Can we speed up deduper query? - https://phabricator.wikimedia.org/T333909 (10Eileenmcnaughton) [00:35:36] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Can we speed up deduper query? - https://phabricator.wikimedia.org/T333909 (10Eileenmcnaughton) [01:55:48] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe, 10Documentation: Update deduper documentation to explain the critieria better - https://phabricator.wikimedia.org/T327727 (10Eileenmcnaughton) @shust I added a section to the documentation here... [02:02:51] (03PS1) 10Cstone: Add eftpos_australia [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905334 [02:10:54] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, 10fr-donorservices: dLocal audit file: some recent refunds not reaching Civi - https://phabricator.wikimedia.org/T333247 (10Cstone) [02:15:57] (03PS1) 10Eileen: Additional deduper documentation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905335 (https://phabricator.wikimedia.org/T327727) [02:16:53] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe, 10Documentation: Update deduper documentation to explain the critieria better - https://phabricator.wikimedia.org/T327727 (10Eileenmcnaughton) a:03Eileenmcnaughton [02:17:01] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe, 10Documentation: Update deduper documentation to explain the critieria better - https://phabricator.wikimedia.org/T327727 (10Eileenmcnaughton) [02:18:55] (03CR) 10Ejegg: "Maybe a different setting for the non-variant? Also I wonder if we really need to nest variants under the parent payment method, as I coul" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905334 (owner: 10Cstone) [02:19:23] thanks ejegg|food my eod was about how I thought I might have done that wrong haha [02:19:29] I dont know why its still so confusing to me [02:20:23] oh dang I forgot to un-|food myself all this time [02:20:34] maybe just eating a very long meal [02:20:36] cstone no you did it right [02:21:07] i mean, if the only one we've ever seen from them is a googlepay it's a valid guess [02:21:23] but I looked at their website and I think they do card stuff too [02:21:42] so maybe if we get another one with that brand code and no variant it would be a card [02:21:42] yeah I guess I get confused between submethod and variant [02:21:53] cause they all have a variant in the audit [02:22:07] or it would be the variant = method then? [02:22:41] honestly it's all kind of mushy [02:22:42] (03PS2) 10Cstone: Add eftpos_australia [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905334 [02:23:08] for the old visa 'variants' it's just a submethod [02:23:29] but the google/apple ones change what we've decided to call method [02:23:56] ah okay walletness [02:24:03] awight was planning to do away with the strict two-part method/submethod in favor of something better, but I never quite understood what the better thing was [02:24:22] i dont know why the comment at the top has an edit its not there in my ide [02:24:45] oh, random extra tab [02:24:50] ehh, it's in a comment [02:25:27] but the tab isnt there locally?? haha [02:25:29] ghost tab [02:25:41] (03CR) 10Ejegg: [C: 03+2] Add eftpos_australia [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905334 (owner: 10Cstone) [02:25:47] thanks ejegg [02:26:16] (03Merged) 10jenkins-bot: Add eftpos_australia [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905334 (owner: 10Cstone) [02:26:21] cstone if you're about to tag a version [02:26:30] want to take a quick look at this phone mapping? [02:26:41] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/905255 [02:27:04] (03PS3) 10Ejegg: Map phone number to payer when sent [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905255 (https://phabricator.wikimedia.org/T333857) [02:27:07] hah i can maybe handle this [02:27:38] i came back to finish these refunds but adyen console was broken now doesnt show anything past 22:16 [02:27:48] (03CR) 10Cstone: [C: 03+2] Map phone number to payer when sent [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905255 (https://phabricator.wikimedia.org/T333857) (owner: 10Ejegg) [02:28:15] thanks! [02:28:24] (03Merged) 10jenkins-bot: Map phone number to payer when sent [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905255 (https://phabricator.wikimedia.org/T333857) (owner: 10Ejegg) [02:29:24] (03CR) 10CI reject: [V: 04-1] Additional deduper documentation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905335 (https://phabricator.wikimedia.org/T327727) (owner: 10Eileen) [02:30:31] CI reject because it doesn't like the tone of the documentation? [03:57:37] lol [04:05:22] (03PS2) 10Eileen: Additional deduper documentation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905335 (https://phabricator.wikimedia.org/T327727) [10:44:30] (03PS12) 10Damilare Adedoyin: Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) [10:45:21] (03CR) 10Damilare Adedoyin: "Thanks jgleeson for the CR, I've made one of the changes and dropped a note on the other." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) (owner: 10Damilare Adedoyin) [12:22:19] 10Fundraising-Backlog, 10FR-Adyen: Turn on monthly convert for Adyen - https://phabricator.wikimedia.org/T252248 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF Confirmed with @EMartin that this is turned on for most markets now. Closing. [12:35:46] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), 10User-notice: CentralNotice banners being shown too many times - https://phabricator.wikimedia.org/T331671 (10Trizek-WMF) [12:56:40] (03PS13) 10Damilare Adedoyin: Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) [12:56:42] (03PS2) 10Damilare Adedoyin: Handle dLocal Fiscal Number errors [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905258 (https://phabricator.wikimedia.org/T333725) [12:59:46] (03PS14) 10Damilare Adedoyin: Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) [13:05:20] (03PS15) 10Damilare Adedoyin: Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) [13:05:22] (03PS3) 10Damilare Adedoyin: Handle dLocal Fiscal Number errors [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905258 (https://phabricator.wikimedia.org/T333725) [13:08:02] (03CR) 10Damilare Adedoyin: Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) (owner: 10Damilare Adedoyin) [13:10:18] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Handle dLocal Fiscal Number errors - https://phabricator.wikimedia.org/T333725 (10Damilare) a:03Damilare [13:22:26] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1005:down, kafka-jumbo1004:down, kafka-jumbo1007:down https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_kafkatee [13:27:26] RECOVERY - check_kafkatee on frban1001 is OK: OK: brokers:9 topics:1 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_kafkatee [13:50:54] (03PS4) 10Damilare Adedoyin: Handle dLocal Fiscal Number errors [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905258 (https://phabricator.wikimedia.org/T333725) [15:31:47] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Add IN-specific error page text with appropriate payment methods - https://phabricator.wikimedia.org/T333455 (10Damilare) a:03Damilare [15:33:31] (03CR) 10Jgleeson: "Thanks for this. I think this is ok, as I can see the new field on the form when I add it to the config. However, I don't see it being pus" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905290 (https://phabricator.wikimedia.org/T333857) (owner: 10Ejegg) [15:47:29] (03CR) 10Damilare Adedoyin: [C: 03+2] Remove upi_id from di log [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904592 (https://phabricator.wikimedia.org/T324294) (owner: 10Wfan) [15:52:04] oh man [15:52:16] closing chrome loses all draft gerrit review comments [15:52:27] I just closed it to open the JS debugger :( [15:52:59] well that sucks [15:56:20] (03PS16) 10Damilare Adedoyin: Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) [15:56:52] (03Merged) 10jenkins-bot: Remove upi_id from di log [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904592 (https://phabricator.wikimedia.org/T324294) (owner: 10Wfan) [15:57:07] (03PS5) 10Damilare Adedoyin: Handle dLocal Fiscal Number errors [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905258 (https://phabricator.wikimedia.org/T333725) [16:10:31] (03CR) 10Jgleeson: "Thanks for the refactoring here! Can we decompose further to help simplify our conditional blocks within the new method?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905318 (owner: 10Ejegg) [16:15:53] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10Patch-For-Review: Add Online Banking for Czech Republic - https://phabricator.wikimedia.org/T328717 (10HNordeenWMF) @EMartin It's too close now to the pre-test for completing this work with enough time for QA and proofing. We can try to work on... [16:34:08] ejegg: I'm not seeing the phone number being sent to the queue or to dlocal with the phone number patches [16:34:28] I just tested the tip of the patch chain https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/905291/5 [16:34:51] once I enable the field in country fields I can see it but it doesn't seem to go anywhere if populated [16:36:47] oh wait a minute, I see there is a depends-on flag [16:36:55] lemme pull that down [16:39:54] (03CR) 10Wfan: [C: 03+2] Oops, needs href not src [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/903744 (owner: 10Ejegg) [16:41:18] (03CR) 10Wfan: [C: 03+2] "Let's also update the src/payments/extensions/DonationInterface/adyen_gateway/adyen_checkout_gateway.body.php line 40~" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/903744 (owner: 10Ejegg) [16:41:36] (03Merged) 10jenkins-bot: Oops, needs href not src [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/903744 (owner: 10Ejegg) [16:47:49] (03CR) 10Jgleeson: Add handling for phone number to generic form (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905290 (https://phabricator.wikimedia.org/T333857) (owner: 10Ejegg) [16:48:19] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10Patch-For-Review: Add Online Banking for Czech Republic - https://phabricator.wikimedia.org/T328717 (10EMartin) @HNordeenWMF Thanks Haley. Adyen is trying to get me the verbiage as recent at this morning. I'll add it here when I have it. [16:50:03] (03CR) 10Jgleeson: [C: 03+2] "In light of new understandings, this looks good to me! thanks" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905290 (https://phabricator.wikimedia.org/T333857) (owner: 10Ejegg) [16:51:51] (03Merged) 10jenkins-bot: Add handling for phone number to generic form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905290 (https://phabricator.wikimedia.org/T333857) (owner: 10Ejegg) [16:53:54] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10Patch-For-Review: Add Online Banking for Czech Republic - https://phabricator.wikimedia.org/T328717 (10EMartin) @HNordeenWMF Haley, here is Adyen's response alas! For CZ, you can use "Online Banking CZ" . I am confirming what the Czech langua... [17:01:49] (03CR) 10Jgleeson: [C: 03+2] "Working well for me. Nice field injection! thanks" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905291 (https://phabricator.wikimedia.org/T333857) (owner: 10Ejegg) [17:08:27] thanks for the CR, jgleeson and wfan [17:08:50] jgleeson: ah right, we intentionally don't send it to the queue [17:09:13] let's see, I think cstone might have tagged a new smashpig version last night [17:09:41] I didnt ejegg [17:09:43] it was late hah [17:11:12] (03PS2) 10Jgleeson: What fails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905305 (https://phabricator.wikimedia.org/T333340) (owner: 10Eileen) [17:12:06] (03CR) 10Jgleeson: [C: 03+2] "Thanks for this!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905305 (https://phabricator.wikimedia.org/T333340) (owner: 10Eileen) [17:12:28] no worries cstone, I just tagged it [17:12:33] thanks ejegg [17:13:21] jgleeson: I'll do that functional decomposition on the JS and add the smash-pig version bump to the phone patch [17:14:28] thanks ejegg. Also, while testing I was getting error using the latest on config-private with the latest smashpig that payments is using. I'm guess you're version bump will fix that too? [17:15:49] your* [17:23:33] (03Merged) 10jenkins-bot: What fails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905305 (https://phabricator.wikimedia.org/T333340) (owner: 10Eileen) [17:59:28] (03PS3) 10Ejegg: Dlocal: do form manipulation onPageReady [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905318 [17:59:30] (03PS1) 10Ejegg: Dlocal js: decompose card setup function [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905697 [17:59:54] jgleeson|brb: yep, the version bump will fix that [18:00:26] jgleeson|brb: the functional decomposition was a pretty huge change, so I did it in a different patch [18:01:07] (03CR) 10CI reject: [V: 04-1] Dlocal js: decompose card setup function [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905697 (owner: 10Ejegg) [18:09:54] (03PS2) 10Ejegg: Dlocal js: decompose card setup function [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905697 [18:14:03] (03PS1) 10Ejegg: Dlocal js: decompose non-card setup function [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905698 [18:23:27] (03PS2) 10Ejegg: Dlocal js: decompose non-card setup function [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905698 [18:26:34] (03PS6) 10Ejegg: Add optional phone to dlocal UPI non-recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905291 (https://phabricator.wikimedia.org/T333857) [18:27:33] (03CR) 10CI reject: [V: 04-1] Add optional phone to dlocal UPI non-recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905291 (https://phabricator.wikimedia.org/T333857) (owner: 10Ejegg) [18:35:51] (03CR) 10Ejegg: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905291 (https://phabricator.wikimedia.org/T333857) (owner: 10Ejegg) [18:37:11] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface, 10Recurring-Donations: Enable Monthly Convert for DLocal in all markets that support recurring cards - https://phabricator.wikimedia.org/T324624 (10AnnWF) [18:58:48] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface, 10Recurring-Donations: Enable Monthly Convert for DLocal in all markets that support recurring cards - https://phabricator.wikimedia.org/T324624 (10AnnWF) [19:27:39] (03PS17) 10Damilare Adedoyin: Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) [19:28:03] (03CR) 10CI reject: [V: 04-1] Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) (owner: 10Damilare Adedoyin) [19:28:25] (03PS18) 10Damilare Adedoyin: Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) [19:28:53] (03CR) 10CI reject: [V: 04-1] Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) (owner: 10Damilare Adedoyin) [19:30:07] (03PS19) 10Damilare Adedoyin: Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) [19:30:51] (03CR) 10CI reject: [V: 04-1] Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) (owner: 10Damilare Adedoyin) [19:33:57] 10Fundraising-Backlog: Move Wikimedia store domain from store.wikimedia.org - https://phabricator.wikimedia.org/T333591 (10greg) We put this into our "blocked/no fr-tech" column because the fr-tech team won't be doing anything directly on this task. I will be helping @SHust myself though. [19:34:08] (03PS20) 10Damilare Adedoyin: Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) [19:37:41] (03CR) 10Jgleeson: Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) (owner: 10Damilare Adedoyin) [19:38:25] just spotted one thing damilare ^ [19:39:48] (03PS21) 10Damilare Adedoyin: Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) [19:39:49] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog: Add image to email feature potentially hidden in WYSWYG editor in Civi - https://phabricator.wikimedia.org/T333404 (10Eileenmcnaughton) 05Open→03Resolved We chatted in sprint & there isn't an ongoing stateholder request on this at this stage [19:39:58] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog: Add image to email feature potentially hidden in WYSWYG editor in Civi - https://phabricator.wikimedia.org/T333404 (10Eileenmcnaughton) [19:40:00] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10FR-Japan: Make the Japan "V1" payment wiki variant the new control - https://phabricator.wikimedia.org/T329807 (10XenoRyet) a:05XenoRyet→03None [19:40:02] 10Fundraising-Backlog: Cancel Recurring script for credit card - https://phabricator.wikimedia.org/T334009 (10AnnWF) [19:40:19] (03CR) 10CI reject: [V: 04-1] Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) (owner: 10Damilare Adedoyin) [19:40:26] 10Fundraising-Backlog, 10FR-dlocal: Cancel Recurring script for credit card - https://phabricator.wikimedia.org/T334009 (10AnnWF) [19:40:40] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog: SmashPig Adapter Layer - https://phabricator.wikimedia.org/T332236 (10jgleeson) a:05jgleeson→03None [19:41:05] 10Fundraising-Backlog, 10FR-dlocal: Cancel Recurring script for credit card - https://phabricator.wikimedia.org/T334009 (10AnnWF) [19:41:08] (03PS22) 10Damilare Adedoyin: Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) [19:42:52] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Enable sending Civi contact hashes in Acoustic emails - https://phabricator.wikimedia.org/T333182 (10XenoRyet) [19:43:01] (03CR) 10Damilare Adedoyin: "done, thanks jgleeson" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) (owner: 10Damilare Adedoyin) [19:44:34] 10Fundraising-Backlog, 10FR-Japan: Make the Japan "V1" payment wiki variant the new control - https://phabricator.wikimedia.org/T329807 (10XenoRyet) [19:45:16] 10Fundraising-Backlog: Update config for Payments Staging - https://phabricator.wikimedia.org/T327855 (10XenoRyet) [19:45:24] (03CR) 10Damilare Adedoyin: Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) (owner: 10Damilare Adedoyin) [19:45:51] (03CR) 10Jgleeson: [C: 03+2] "Thanks for the work on this and the comprehensive restructure. It's great and will make our adapter layer work much easier I think!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) (owner: 10Damilare Adedoyin) [19:46:28] (03Merged) 10jenkins-bot: Handle REJECT and other failure responses with http response status code 200 in ApprovePayment and CancelPayment methods for Dlocal. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904513 (https://phabricator.wikimedia.org/T328082) (owner: 10Damilare Adedoyin) [19:47:25] 10Fundraising-Backlog: Issue testing Gpay and PayTM through in India - confusing donation amounts and trx remaining in pending status - https://phabricator.wikimedia.org/T332828 (10XenoRyet) [19:48:04] 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Fish HEAD^, 10Fundraising-Backlog, 10FR-Docker: Docker dev setup: scope out use cases, requirements and command-line UI to replace setup.sh - https://phabricator.wikimedia.org/T287028 (10XenoRyet) [20:00:14] (03PS6) 10Damilare Adedoyin: Handle dLocal Fiscal Number errors [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905258 (https://phabricator.wikimedia.org/T333725) [20:27:22] (03CR) 10Jgleeson: [C: 03+2] "LGTM! I can see the updates suggested in the follow-on patches." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905318 (owner: 10Ejegg) [20:27:59] (03CR) 10Jgleeson: [C: 03+2] "This is great and so much easier to read through. Thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905697 (owner: 10Ejegg) [20:29:06] (03Merged) 10jenkins-bot: Dlocal: do form manipulation onPageReady [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905318 (owner: 10Ejegg) [20:29:31] (03Merged) 10jenkins-bot: Dlocal js: decompose card setup function [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905697 (owner: 10Ejegg) [20:32:33] thanks jgleeson ! [20:33:26] (03CR) 10Jgleeson: [C: 03+2] "Thanks again! Tested with a handful of card and non-card payments and nothing broken. Reads much better!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905698 (owner: 10Ejegg) [20:36:53] np [20:37:09] fr-tech what's the paytm recurring one-time-password [20:37:16] the test one [20:39:00] found it [20:43:00] (03PS3) 10Ejegg: Additional deduper documentation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905335 (https://phabricator.wikimedia.org/T327727) (owner: 10Eileen) [20:43:15] (03CR) 10Ejegg: [C: 03+2] "Thanks! Fixes and doc look good." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905335 (https://phabricator.wikimedia.org/T327727) (owner: 10Eileen) [20:46:32] (03PS4) 10Ejegg: Move contribution pre hook to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904317 (owner: 10Eileen) [20:46:40] (03CR) 10Ejegg: [C: 03+2] Move contribution pre hook to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904317 (owner: 10Eileen) [20:48:19] (03Abandoned) 10Ejegg: dlocal API constructor params for UPI recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/902569 (owner: 10AndyRussG) [20:50:34] (03CR) 10Jgleeson: [C: 03+2] "This is working great for me. The smashpig bump also fixes the issue I had using the latest config." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905291 (https://phabricator.wikimedia.org/T333857) (owner: 10Ejegg) [20:50:49] thanks jgleeson ! I'll deploy that once it merges [20:51:22] (03Merged) 10jenkins-bot: Dlocal js: decompose non-card setup function [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905698 (owner: 10Ejegg) [20:51:25] thanks for turning that new field around so quickly! [20:58:50] (03Merged) 10jenkins-bot: Additional deduper documentation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905335 (https://phabricator.wikimedia.org/T327727) (owner: 10Eileen) [20:59:30] (03Merged) 10jenkins-bot: Move contribution pre hook to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904317 (owner: 10Eileen) [21:05:05] (03PS6) 10Ejegg: Handle initial scheme transaction ID [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/901316 (https://phabricator.wikimedia.org/T331754) [21:10:54] (03PS1) 10Cstone: Update SmashPig to v0.8.4.9 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905725 [21:13:49] (03Merged) 10jenkins-bot: Add optional phone to dlocal UPI non-recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/905291 (https://phabricator.wikimedia.org/T333857) (owner: 10Ejegg) [21:24:36] (03CR) 10Ejegg: [C: 03+2] Update SmashPig to v0.8.4.9 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905725 (owner: 10Cstone) [21:27:02] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/905747 [21:27:05] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/905747 (owner: 10Ejegg) [21:33:19] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10Patch-For-Review: Add Online Banking for Czech Republic - https://phabricator.wikimedia.org/T328717 (10EMartin) @HNordeenWMF @annWF. Here is the Czech language for Online Banking in Czech: Internetové Bankovnictví. In English: Online Banki... [21:36:46] (03Merged) 10jenkins-bot: Update SmashPig to v0.8.4.9 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905725 (owner: 10Cstone) [21:39:18] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/905747 (owner: 10Ejegg) [21:40:05] deleting the following from DNS as we speak: frdata1001.mgmt.frack.eqiad.wmnet. [21:40:18] I had to merge it because I got blocked when doing completely unrelated stuff. [21:40:41] but because it was mgmt and eventually I found https://phabricator.wikimedia.org/T333971#8755580 and read the comments [21:41:04] I decided to do it to unblock other DNS changes. [21:41:34] seems like that issue needs more discussion, access for fr-tech or something [21:44:29] dwisehaupt: ^ [21:47:06] (03PS2) 10Ejegg: Add new custom field for initial scheme txn ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904385 (https://phabricator.wikimedia.org/T331754) [21:47:08] (03PS1) 10Ejegg: Use API4 for inserting ContributionRecur records [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905752 [21:48:03] AndyRussG|ish: yeah. thanks. we are discussing. :) [21:54:37] ah cool thank u dwisehaupt mutante !! :) [21:57:12] it's handled short term and we are also discussing the _actual fix_ :) [21:57:19] how to fix the access etc [21:57:22] cheers all [21:58:41] (03CR) 10CI reject: [V: 04-1] Use API4 for inserting ContributionRecur records [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905752 (owner: 10Ejegg) [22:10:04] eileen: Im going to do a civi deploy to get the smashpig version updated for the audit are these all okay to go out 7a17f57f3 Move Organization name resolver to extension [22:10:04] 5c2ea3712 Move anonymousContact retrieval to extension helper [22:10:04] 6324ab5de Simplify create contact [22:10:04] d9d271ba2 Reduce logging noise generated by AstroPayAuditTests [22:10:04] 61d9b4073 Refactor Benevity employer finder to new WMFHelpers location [22:10:05] ce180ffe5 What fails [22:10:05] e6a9423bc Additional deduper documentation [22:10:06] ca7369ed4 Move contribution pre hook to the extension [22:10:06] c851a3e75 Update SmashPig to v0.8.4.9 [22:10:22] cstone: yep - all good [22:10:25] thanks! [22:11:15] (03PS1) 10Cstone: Update SmashPig to v0.8.4.9 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/905755 [22:13:06] (03CR) 10Cstone: [C: 03+2] Update SmashPig to v0.8.4.9 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/905755 (owner: 10Cstone) [22:16:05] (03PS1) 10Ejegg: Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/905756 [22:16:07] (03CR) 10Ejegg: [C: 03+2] Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/905756 (owner: 10Ejegg) [22:19:48] !log payments-wiki upgraded from 49a2e104 to 75b068a1 [22:19:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:23:37] have a good one, i'll sneak outagain [22:24:01] (03Merged) 10jenkins-bot: Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/905756 (owner: 10Ejegg) [22:26:12] (03Merged) 10jenkins-bot: Update SmashPig to v0.8.4.9 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/905755 (owner: 10Cstone) [22:29:25] (03PS1) 10Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/905758 [22:30:05] (03CR) 10Cstone: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/905758 (owner: 10Cstone) [22:31:11] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/905758 (owner: 10Cstone) [22:31:20] ??? when did that get fixed [22:31:51] nice thuogh [22:33:23] !log civicrm upgraded from 4231191f to 223f655a [22:33:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:53:51] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Fix redis related bug in local dev environment - https://phabricator.wikimedia.org/T334036 (10Eileenmcnaughton) [22:56:42] (03PS2) 10Ejegg: Use API4 for inserting ContributionRecur records [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905752 (https://phabricator.wikimedia.org/T331754) [23:04:12] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.41-notes (1.41.0-wmf.4; 2023-04-10): Add optional phone number field for DLocal one-time UPI - https://phabricator.wikimedia.org/T333857 (10Ejegg) @EMartin @RKumar_WMF this is now deployed - the phone input on our form is sent... [23:04:40] (03PS2) 10Wfan: Rename Ideal classes, add handling for CZ bank transfer [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904618 (https://phabricator.wikimedia.org/T328717) (owner: 10Ejegg) [23:08:17] (03CR) 10CI reject: [V: 04-1] Use API4 for inserting ContributionRecur records [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905752 (https://phabricator.wikimedia.org/T331754) (owner: 10Ejegg) [23:09:43] (03PS3) 10Ejegg: Use API4 for inserting ContributionRecur records [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905752 (https://phabricator.wikimedia.org/T331754) [23:14:59] (03CR) 10Wfan: [C: 03+2] Rename Ideal classes, add handling for CZ bank transfer [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904618 (https://phabricator.wikimedia.org/T328717) (owner: 10Ejegg) [23:15:32] (03Merged) 10jenkins-bot: Rename Ideal classes, add handling for CZ bank transfer [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904618 (https://phabricator.wikimedia.org/T328717) (owner: 10Ejegg) [23:15:50] thanks wfan [23:17:38] Seems like Evelyn just add a new online banking translation for onlineBanking_CZ, also could we add a test link to main page once onlineBanking_CZ enabled? thanks :) [23:18:11] oh sure, I actually have a test link locally already - i'll push that up [23:19:17] (03PS1) 10Ejegg: Add test link for CZ bank transfer [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/905762 [23:19:24] there it is wfan [23:20:24] haha nice~ [23:26:28] (03CR) 10Wfan: [V: 03+2 C: 03+2] "Thx for adding this for test ticket T328717" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/905762 (owner: 10Ejegg) [23:28:18] (03PS2) 10Wfan: Add test link for CZ bank transfer [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/905762 (https://phabricator.wikimedia.org/T328717) (owner: 10Ejegg) [23:28:24] (03CR) 10Wfan: [V: 03+2] Add test link for CZ bank transfer [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/905762 (https://phabricator.wikimedia.org/T328717) (owner: 10Ejegg)