[00:00:00] (03CR) 10Cstone: [C: 03+2] CiviCRM 5.61 rc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/899187 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [00:00:14] ahh i did it before your comment [00:00:20] thanks [00:00:24] haha [00:00:26] you were on it eileen !! [00:00:32] to be clear with this, since it's just a civi outage i do not plan to take payments into maint mode. stopping the queues and all should be sufficient. [00:00:52] i'm going to start that as the puppet runs can take a little to fully roll out. [00:01:08] recurring charge job starts in 21 minutes i think thats the main thing to worry about at this time [00:01:16] and will be fine with queue stoppage [00:02:00] yeah, i'll force the puppet run on civi and frdev. we'll only really need to worry about jobs currently in flight there. [00:02:06] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/907549 [00:02:46] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/907549 (owner: 10Eileen) [00:04:08] ok - that is merging through - if someone +2s https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/904049 I'll pick it up for a second round [00:05:18] I'll disable process-control now [00:05:18] there is no need to do 2.9.x in the checklist since i'm stopping p-c fully on the host. i'll remove those steps from the checklist for this. [00:05:29] eileen: ^^ no need to. [00:05:33] cool [00:05:42] I was just about to set up a new checklist for today [00:06:20] it's in the other channel. [00:06:24] (03CR) 10Cstone: [C: 03+2] Adapt to change in form property on upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904049 (owner: 10Eileen) [00:07:54] we could do it if we needed to turn some jobs back on, but when we are doing all of them and have the ability to slow start individual jobs, it's easier to just shut it off on the host. [00:08:34] dwisehaupt: OK - I'll turn on mtce mode - I don't think I need to email again [00:09:30] am I up to deploying the code then? [00:11:31] 10Fundraising-Backlog, 10FR-dlocal: Update the PAN field label on the dLocal India recurring form. - https://phabricator.wikimedia.org/T334103 (10AnnWF) a:03AnnWF [00:11:32] I'm ready to hit go ... [00:11:56] let me make sure there aren't any lagging p-c jobs running. [00:13:22] looks good. [00:13:55] !log civicrm upgraded from 223f655a to 001e156a [00:13:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:15:19] looks like the upgrade script is nearly done [00:16:01] yep - it ran [00:16:08] (03PS1) 10Wfan: Update the PAN field label on the dLocal India recurring form. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/907551 (https://phabricator.wikimedia.org/T334103) [00:16:22] (03PS2) 10Wfan: Update the PAN field label on the dLocal India recurring form. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/907551 (https://phabricator.wikimedia.org/T334103) [00:19:16] cool. i'll just await the trigger file for when it is generated and ready for swapping. [00:21:59] (03PS1) 10Eileen: Update triggers for upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907552 (https://phabricator.wikimedia.org/T332357) [00:22:55] dwisehaupt: there it is ^^ [00:23:08] looking. [00:23:30] I had wondered about getting ejegg's custom field in the same triggers update - but I did want to check something on that patch & I think he is not about [00:24:24] (03Merged) 10jenkins-bot: Adapt to change in form property on upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904049 (owner: 10Eileen) [00:24:49] triggers look good. need me to +2 it? [00:25:14] (03PS8) 10Eileen: Additional merge patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907526 (https://phabricator.wikimedia.org/T332357) [00:25:16] (03PS15) 10Eileen: Enable Civi-import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901739 [00:25:18] (03PS20) 10Eileen: Add hooks to import to do organization lookup from nick-name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901734 (https://phabricator.wikimedia.org/T303986) [00:25:20] (03PS2) 10Eileen: E-notice fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907540 [00:25:22] (03PS8) 10Eileen: Add hook support to look up individual and handle soft credits during import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904380 (https://phabricator.wikimedia.org/T303986) [00:25:24] (03PS4) 10Eileen: Remove custom code that is obsolete [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904948 (https://phabricator.wikimedia.org/T332357) [00:25:26] (03PS4) 10Eileen: Fix to match individual on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904954 [00:28:53] (03PS1) 10Eileen: Upgrade Symfony [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/907553 [00:29:15] (03CR) 10Eileen: [C: 03+2] Upgrade Symfony [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/907553 (owner: 10Eileen) [00:29:39] 10Fundraising-Backlog: Wikimedia not accepting webhook events in live production - https://phabricator.wikimedia.org/T334436 (10EMartin) [00:30:35] 10Fundraising-Backlog: Wikimedia not accepting webhook events in live production - https://phabricator.wikimedia.org/T334436 (10EMartin) @fr-tech. I think we should be treating this as urgent. [00:33:24] (03CR) 10Eileen: [C: 03+2] Update triggers for upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907552 (https://phabricator.wikimedia.org/T332357) (owner: 10Eileen) [00:33:55] dwisehaupt: sorry I didn't see that was a question - yeah I just did the _2 [00:34:50] cool. [00:35:04] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/907555 [00:35:14] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/907555 (owner: 10Eileen) [00:35:42] (03CR) 10CI reject: [V: 04-1] Additional merge patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907526 (https://phabricator.wikimedia.org/T332357) (owner: 10Eileen) [00:36:28] (03CR) 10jenkins-bot: Enable Civi-import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901739 (owner: 10Eileen) [00:36:35] (03CR) 10jenkins-bot: Add hooks to import to do organization lookup from nick-name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901734 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [00:36:53] (03CR) 10jenkins-bot: E-notice fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907540 (owner: 10Eileen) [00:36:56] (03CR) 10jenkins-bot: Add hook support to look up individual and handle soft credits during import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904380 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [00:37:31] is smashpig in maintmode right now dwisehaupt I assume its from the civi upgrade but just want to make sure (evelyns ticket about adyen endpoint) [00:37:35] (03CR) 10jenkins-bot: Fix to match individual on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904954 (owner: 10Eileen) [00:37:37] !log civicrm upgraded from 001e156a to bc2f5ccc [00:37:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:37:41] (03CR) 10jenkins-bot: Remove custom code that is obsolete [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904948 (https://phabricator.wikimedia.org/T332357) (owner: 10Eileen) [00:37:50] cstone: yes. smashpig is in maint mode. [00:37:53] dwisehaupt: I think the triggers are deployed now [00:37:57] ok thanks! [00:38:12] eileen: ok. i'll pull them and do the dance. [00:38:18] 10Fundraising-Backlog: Wikimedia not accepting webhook events in live production - https://phabricator.wikimedia.org/T334436 (10Cstone) @EMartin our endpoints are in maintenance mode right now for the civi upgrade [00:38:43] dwisehaupt: yeah - the right triggers will start tracking that extra frontend_title field on payment processor table [00:40:16] (03PS9) 10Eileen: Additional merge patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907526 (https://phabricator.wikimedia.org/T332357) [00:40:18] (03PS16) 10Eileen: Enable Civi-import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901739 [00:40:20] (03PS21) 10Eileen: Add hooks to import to do organization lookup from nick-name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901734 (https://phabricator.wikimedia.org/T303986) [00:40:22] (03PS3) 10Eileen: E-notice fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907540 [00:40:24] (03PS9) 10Eileen: Add hook support to look up individual and handle soft credits during import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904380 (https://phabricator.wikimedia.org/T303986) [00:40:27] (03PS5) 10Eileen: Remove custom code that is obsolete [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904948 (https://phabricator.wikimedia.org/T332357) [00:40:29] (03PS5) 10Eileen: Fix to match individual on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904954 [00:41:49] (03Merged) 10jenkins-bot: Upgrade Symfony [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/907553 (owner: 10Eileen) [00:41:59] so there is one more patch we would ideally get merged - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/907526 - it has a lot of test cover (hence my big fight with it) - but the issue is the employer_id doesn't seem to be carried over on merge and I don't know if it is a regression upstream or a bug that has been around for a bit [00:43:23] hmmm... i got an error when updating the triggers. checking. [00:44:10] happens when trying to reload the old triggers too. [00:45:04] (03Abandoned) 10Eileen: Fix to match individual on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905148 (owner: 10Eileen) [00:45:16] (03PS6) 10Eileen: Fix to match individual on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904954 [00:45:57] what is the error [00:46:38] it's in the civicrm_custom_field_after_insert trigger [00:46:50] Unknown column 'mask' in 'NEW' [00:47:13] line 1869 of triggers.mysql [00:47:14] hmm - that got dropped I think [00:47:39] unless the trigger files didn't update before i pulled them. [00:47:41] repulling. [00:48:14] pulling civi1001:/srv/org.wikimedia.civicrm/drupal/sites/all/modules/wmf_civicrm/scripts/ and no diffs via rsync. [00:48:40] Jan 25 04:01 triggers.mysql [00:48:53] i'm not sure it got updated. [00:48:54] Yeah - I don't see any ref to that field... [00:49:08] the trigger file still has the dated of jan 25. [00:50:17] I don't think I see it in CiviCRM.trigger6434a728503a2q3jU7702126718965e4a41105a08d6202e60.sql [00:50:22] (in ConfigAndLog) [00:50:27] gonna regenerate them [00:51:29] cool. thanks. [00:54:02] hmm - I'm not finding the field 'mask' in them [00:54:24] (03CR) 10CI reject: [V: 04-1] Fix to match individual on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904954 (owner: 10Eileen) [00:54:56] the latest file civicrm-files/civicrm/ConfigAndLog/CiviCRM.trigger6434a728503a2q3jU7702126718965e4a41105a08d6202e60.sql [00:54:56] - is that the same as what you have? [00:56:26] ok - must not have deployed ? [00:57:16] that is different. [00:58:15] yeah & also what I have locally differs from prod [00:59:00] dang - rsync not done [00:59:21] now it is [00:59:31] ok. pulling again [01:00:10] ok. that new one loaded clean. checking the diff. [01:01:22] yep, diff matches what i saw in gerrit. all good now. [01:01:23] cool [01:01:40] we can start bringing it up [01:02:00] ok. i'll start up replication and revert the maint mode things. [01:02:59] cool [01:03:52] ok. civi should be out of maint mode now. [01:05:06] seems ok [01:07:27] i see adyen ipns coming in. [01:07:50] i just hit the endpoint too looks good [01:08:14] 10Fundraising-Backlog: Wikimedia not accepting webhook events in live production - https://phabricator.wikimedia.org/T334436 (10Cstone) The endpoints are out of maintenance mode and back up [01:09:41] wonder if the processors would listen to soft fail http codes. [01:10:06] of course, each would probably behave differently so maybe not worth the effort to customize. :) [01:12:19] icinga downtimes removed. we should be back in normal operation and monitoring. [01:15:47] cstone: so do we need to kick the recurring job or will it run again soon [01:15:56] itll run at :21 [01:16:04] it runs at :21 and :51 [01:17:18] cool [01:18:27] ok - so upgrade is done - ideally we would get this patch out in case the employer_id info is being lost https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/907526 [01:18:37] 10Fundraising-Backlog: Wikimedia not accepting webhook events in live production - https://phabricator.wikimedia.org/T334436 (10EMartin) 05Open→03Resolved a:03EMartin I see this was related to the Civi update - we are back in action. I'll close this case out. Thank you: LIVE: WikimediaDonations is a... [01:30:40] sorry eileen, i got roped into something [01:34:36] no worries ejegg we got it out although I'm a bit worried about that one last dedupe patch I put up [01:41:42] ejegg: I also wanted to check in with you on your field - I looked to review it but just had a couple of thoughts [01:42:43] oh thanks! [01:43:13] looking at the comments [01:43:59] yeah - my main thing is I feel like we can't always control custom field names - but where we can I think future us will thank us for using lower_case [01:44:20] Oh sure, sounds good to me [01:44:59] & then the other was just that I've come late to the rationale behind the field & just wanted to check that you have run that past someone in the team [01:45:00] I was just following the example in... some other module [01:45:19] yeah - I think we often have user-created fields - which we can't control [01:45:39] - did you specify field name & table name - I think you did [01:46:14] yep, I did [01:46:31] cool [01:46:31] so the rationale is this new requirement for sending yet another ID with recurring transactions [01:46:39] and perhaps it would be good to have it in core [01:46:40] of course! [01:46:43] but I'm not sure where [01:46:59] so I just decided on a ContributionRecur custom field for now [01:47:14] technically there is a scheme_transaction_id for each transaction [01:47:21] but they just want the first one over and over again [01:47:55] and it's less complicated to get something linked to the contribution recur record than to go fishing through the related contributions [01:49:01] ah ok - yeah - it looks like it is kinda the theory behind this https://github.com/civicrm/civicrm-core/pull/15468 - but then because they are just using the same one over & over it really is just another contribution recur reference [01:50:32] So I guess what we ideally want is somewhere on wikitech that explains how we use the fields - cos ContributionRecur has [01:50:32] invoice_id [01:50:32] trxn_id [01:50:32] processor_id [01:50:33] & then a reference to payment_token_id which has it [01:50:40] s own set of fields [01:51:06] - mostly 'token' [01:52:27] yeah, maybe they should go in https://wikitech.wikimedia.org/wiki/Fundraising/Normalized_donation_messages [01:52:48] (and that should be updated) [01:54:15] aha, https://www.mediawiki.org/wiki/Fundraising_tech/Transaction_IDs [01:54:17] yeah - I think a good principle is to use the name of the CiviCRM field where possible. I feel like we normalise to our special magic & then normalise back again sometimes & the reason might be more about apiv4 [01:54:19] it does exist [01:54:37] yay - go us [01:54:49] sorry apiv2 not apiv4 [01:55:07] I mean a lot of our wrangling is cos we started in the api-wild-west [01:55:44] partly that, I guess partly names of fields as transmitted to or received from processors [01:55:54] yeah - well that part makes sense [01:57:47] eileen: do you think it would make sense to create a read-only entity to mirror (via triggers) some fields from the contribution_tracking table? I really want to get that in front of people before there is a fully fledged 'source coding' work plan out there [01:58:03] sorry, total tangent [01:58:11] yeah but good tangent [01:58:32] what fields are you thinking? I mean we ideally want to move that table into Civi from drupal [01:59:10] the fields they want are kinda concantenated aren't they? [01:59:11] yeah, if we can wrangle the full move into the next sprint, I'd be up for that [01:59:33] it would be a great thing to tackle [01:59:35] ah yeah, there is a separate table that splits them out [02:00:12] doing the full move will require some coordination with analytics at the very least [02:00:16] are we more or less at the end of dlocal? I still need to get the import stuff through review & in place - but almost to the end of that [02:00:24] which might free up some space [02:00:37] eileen: crossing fingers that yes we're nearly done with dlocal [02:03:21] ok eileen so you suggest all of the 'name' bits should be lowercase for the custom field. Makes sense to me, so it fits with the standard field naming conventions [02:03:42] yeah - I just thought the risk of getting the casing wrong was really high [02:03:58] like I say we can't always control it but I think where we can... [02:04:18] (I'm just looking at an instance where I can't cos the user sees the name & there is no lable [02:20:17] (03PS6) 10Ejegg: Add new custom field for initial scheme txn ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904385 (https://phabricator.wikimedia.org/T331754) [02:20:19] (03PS5) 10Ejegg: Use API4 for inserting ContributionRecur records [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905752 (https://phabricator.wikimedia.org/T331754) [02:20:21] (03PS3) 10Ejegg: Add initial scheme id when present in message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905768 (https://phabricator.wikimedia.org/T331754) [02:20:23] (03PS3) 10Ejegg: Use API4 to get payments to charge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905772 (https://phabricator.wikimedia.org/T331754) [02:20:25] (03PS5) 10Ejegg: Send initial scheme transaction id with recur charge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905773 (https://phabricator.wikimedia.org/T331754) [02:20:29] ok, that's the whole chain of them rebased and updated with the correct casing [02:25:09] cool - just trying it out [02:28:01] ah, i suppose I should smoke test [02:28:23] I need to either just blitz that group or do a whole rebuild though [02:28:25] well I'm testing the field create - albeit via a rebuild as my site was a bit broke [02:35:32] (03PS3) 10Ejegg: Set dlocal/astropay gateway per cutoff date [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/907517 (https://phabricator.wikimedia.org/T324292) [02:36:01] (03CR) 10CI reject: [V: 04-1] Set dlocal/astropay gateway per cutoff date [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/907517 (https://phabricator.wikimedia.org/T324292) (owner: 10Ejegg) [02:36:58] (03PS4) 10Ejegg: Set dlocal/astropay gateway per cutoff date [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/907517 (https://phabricator.wikimedia.org/T324292) [02:40:13] (03PS1) 10Ejegg: AstroPay audit: use new ReferenceData [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/907559 [02:41:32] ejegg: so the other question is the table name - our other custom field tables start with wmf_ or civicrm_value - should we be following that (that one won't require other patches to change) [02:41:58] this one is starting with civicrm_ right? [02:42:05] or did I leave that off? [02:42:22] 'table_name' => 'civicrm_contribution_recur_smashpig', [02:42:50] I want to keep 'wmf' out of the SmashPig extension as far as possible [02:49:45] so those should be fine as-is [02:50:01] ejegg: ok [02:50:44] (03CR) 10Eileen: [C: 03+2] Add new custom field for initial scheme txn ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904385 (https://phabricator.wikimedia.org/T331754) (owner: 10Ejegg) [02:50:51] thanks! [02:51:35] eileen: which was the deduper patch you said you were worried about? Something I should review again? [02:51:44] err rather something I should review? [02:52:00] this one https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/907526 [02:52:13] looking [02:52:16] my testing of upstream is employer_id is not reliably transferred [02:52:34] oh jeez, more employer_id headaches? [02:53:56] (03CR) 10Eileen: [C: 03+2] "Yay for including a test" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905768 (https://phabricator.wikimedia.org/T331754) (owner: 10Ejegg) [02:56:33] woohoo [02:58:57] ejegg: so the get patch looks good - I'm just wondering whether I can rely on test cover on that function [03:02:50] (03Merged) 10jenkins-bot: Add new custom field for initial scheme txn ID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904385 (https://phabricator.wikimedia.org/T331754) (owner: 10Ejegg) [03:02:52] (03Merged) 10jenkins-bot: Use API4 for inserting ContributionRecur records [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905752 (https://phabricator.wikimedia.org/T331754) (owner: 10Ejegg) [03:05:37] aha - SmashPigTest [03:05:40] (03Merged) 10jenkins-bot: Add initial scheme id when present in message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905768 (https://phabricator.wikimedia.org/T331754) (owner: 10Ejegg) [03:06:53] (03CR) 10Eileen: [C: 03+2] "This looks good & SmashPigTest class has test cover" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905772 (https://phabricator.wikimedia.org/T331754) (owner: 10Ejegg) [03:07:38] weird, getting a monologger error on a rebuilt local wmff civi when I try to execute a merge [03:07:42] Class 'Monolog\Logger' not found in Civi\MonoLog\MonologManager->getLogger() (line 177 of /srv/civi-sites/wmff/drupal/sites/default/civicrm/extensions/monolog/Civi/MonoLog/MonologManager.php [03:08:12] `composer install` does nothing more, seems to all be there [03:08:38] will try a system.flush [03:10:16] (03PS3) 10Eileen: Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 [03:12:06] huh, still no dice [03:13:06] well, it's from the logging in wmf_civicrm_civicrm_merge [03:14:58] our custom logging was definitely working before I rebuilt [03:17:41] I'm having a heck of a time finding the config screen for the Monolog extension now... [03:18:11] ejegg: I keep hitting that [03:18:23] (03Merged) 10jenkins-bot: Use API4 to get payments to charge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905772 (https://phabricator.wikimedia.org/T331754) (owner: 10Ejegg) [03:18:25] it is losing require_once vendor/autoload.php from settings.php [03:18:34] ahhh [03:18:46] ok, so we need to fix the setup script [03:19:04] yeah [03:19:10] this is the other current gotcha https://phabricator.wikimedia.org/T334036 [03:19:23] -but not sure I logged a phab for the one you are hitting now [03:19:31] ah yeah, i had to clear redis [03:19:44] will add the autoload manually for now [03:19:53] yep - I can log a phab [03:21:14] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Local dev venvironment bug (recent?) - not including vendor/autoload.php - https://phabricator.wikimedia.org/T334440 (10Eileenmcnaughton) [03:21:18] ejegg: ^^ [03:21:29] thanks! [03:24:26] ok, i just tested locally and got the same result. The 'employee of' relationship was copied over, but the 'employer_id' seems to have been left out [03:24:43] (03CR) 10Eileen: [C: 03+2] "test cover seems good, merging" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905773 (https://phabricator.wikimedia.org/T331754) (owner: 10Ejegg) [03:24:57] so did this code you deleted make that employer_id thing work somehow? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/907526/9/drupal/sites/all/modules/civicrm/CRM/Dedupe/Merger.php#2123 [03:25:18] ejegg: switching to apiv4 made it work [03:25:33] it started to use employer_id instead of current_employer [03:25:38] the rest is flow on from that [03:25:47] oh ok [03:26:43] so the field contact_source becomes source etc [03:27:33] ok, let me set up another one and try to see where updateContact is skipping the employer_id [03:28:37] dang & that is after a git pull to get latest master? [03:28:58] oh i just snagged the patch as you have it there [03:29:15] yeah but you have the upgraded civicrm code under it? [03:29:31] yes, i have it right on top of Merge "Update triggers for upgrade" [03:29:39] and i did a fresh rebuild [03:29:44] ok [03:32:31] ok, so employer_id gets passed unchanged through the self::formatProfileContactParams and is just getting fed to CRM_Contact_BAO_Contact::create [03:32:44] yeah that should work... [03:34:31] hmm, this comment sounds a bit hairy: https://phabricator.wikimedia.org/diffusion/WFCG/browse/master/drupal/sites/all/modules/civicrm/CRM/Contact/BAO/Contact.php$191 [03:34:44] // Even if we don't need $employerId, it's important to call getFieldValue() before the contact is saved because we want the existing value to be cached. createCurrentEmployerRelationship() needs the old value not the updated one. CRM-10788 [03:36:14] (03Merged) 10jenkins-bot: Send initial scheme transaction id with recur charge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905773 (https://phabricator.wikimedia.org/T331754) (owner: 10Ejegg) [03:36:31] oh interesting, the contact->save() is called with the contact already having employer_id set [03:39:24] huh, even after stepping out of save() I don't see that employer_id on the target record in the db though [03:40:16] oh, the other new fields to overwrite aren't set either, maybe an uncommitted txn? [03:40:59] hmm - so it hit an error & rolled back? [03:41:20] ah no, i mean maybe I haven't gotten to the part of the code where it commits yet [03:41:28] and i'm doing my db queries on another connection [03:41:36] ah [03:41:43] just stepping into createCurrentEmployerRelationship now [03:42:55] ok, so that function short-circuits on line 293 because it finds the existing relationship [03:44:24] oh ok, I just got past a transaction->commit in the code and now the db row has all the updated values, including employer_id [03:44:30] whew [03:45:44] though back in the browser the summary page for the target contact (that the merger page redirected me to) has the Employer bit blank [03:46:06] as in organization_name didn't update but employer_id did? [03:46:15] ah i see, the 'Organization Name' didn't get carried over [03:46:19] yep exactly [03:46:41] yeah it should have - but as long as employer_id is going over we aren't losing data [03:47:12] so I can take another look at why - although it can be variable to replicate [03:47:26] it is in contact.create BAO that it calls that [03:48:07] i see a couple fns in contact utils [03:48:16] setCurrentEmployer and updateCurrentEmployer [03:48:39] guess we're just not hitting those in the merger [03:48:54] yeah - I think I did on the variant I tested [03:49:52] so I've got to head out soon, and I don't fully understand that patch, but I do see some obviously needed fixes like assigning the correct contact IDs [03:50:04] best to merge now and iterate? [03:50:08] I think so [03:50:14] ok, cool [03:50:25] it did get past a lot of tests [03:50:38] :) always reassuring [03:50:50] (03PS10) 10Ejegg: Additional merge patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907526 (https://phabricator.wikimedia.org/T332357) (owner: 10Eileen) [03:51:12] (03CR) 10Ejegg: [C: 03+2] "Definitely works better with this patch than without it!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907526 (https://phabricator.wikimedia.org/T332357) (owner: 10Eileen) [03:51:30] ok eileen, thanks again for the CR on those scheme id patches [03:51:46] and I'll try to remember to move + update that txn ID doc tomorrow [04:03:05] (03Merged) 10jenkins-bot: Additional merge patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907526 (https://phabricator.wikimedia.org/T332357) (owner: 10Eileen) [04:05:45] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Next regular CiviCRM point release - https://phabricator.wikimedia.org/T332357 (10Eileenmcnaughton) a:03Eileenmcnaughton [04:06:21] (03PS4) 10Eileen: Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) [04:08:24] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/907561 [04:08:48] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/907561 (owner: 10Eileen) [04:10:32] !log civicrm upgraded from bc2f5ccc to b573aee4 [04:10:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:17:17] (03PS4) 10Eileen: Duck failure [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/906800 (https://phabricator.wikimedia.org/T330231) [05:20:24] (03PS17) 10Eileen: Enable Civi-import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901739 [05:20:26] (03PS22) 10Eileen: Add hooks to import to do organization lookup from nick-name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901734 (https://phabricator.wikimedia.org/T303986) [05:20:28] (03PS4) 10Eileen: E-notice fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907540 [05:20:30] (03PS10) 10Eileen: Add hook support to look up individual and handle soft credits during import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904380 (https://phabricator.wikimedia.org/T303986) [05:20:32] (03PS6) 10Eileen: Remove custom code that is obsolete [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904948 (https://phabricator.wikimedia.org/T332357) [05:20:34] (03PS7) 10Eileen: Fix to match individual on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904954 [05:20:36] (03PS5) 10Eileen: Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) [05:24:49] (03CR) 10CI reject: [V: 04-1] Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [07:15:34] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/907759 (owner: 10L10n-bot) [11:30:52] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: GatewayChooser: No supported gateway for parameters - https://phabricator.wikimedia.org/T326666 (10Pcoombe) Okay, done: https://donate.wikimedia.org/?country=XK [11:34:48] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: UZS Donation Form Error - https://phabricator.wikimedia.org/T332945 (10Pcoombe) Okay I [removed](https://donate.wikimedia.org/w/index.php?title=Template:Ways_to_Give/CountrySelect&diff=prev&oldid=38178) both Uzbekistan and Turkmenistan from Ways to Give,... [12:03:23] (03PS13) 10Damilare Adedoyin: Handle dLocal Fiscal Number errors [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905258 (https://phabricator.wikimedia.org/T333725) [12:23:41] (03PS14) 10Damilare Adedoyin: Handle dLocal Fiscal Number errors [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905258 (https://phabricator.wikimedia.org/T333725) [12:41:19] (03PS15) 10Damilare Adedoyin: Handle dLocal Fiscal Number errors [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905258 (https://phabricator.wikimedia.org/T333725) [13:25:23] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: UZS Donation Form Error - https://phabricator.wikimedia.org/T332945 (10AMJohnson) Thank you @Pcoombe and all! :) [13:32:47] (03CR) 10Damilare Adedoyin: "Your patch looks good, I merged it in and added some updates to fix some of the ide errors (basically checking for instance). I also added" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905258 (https://phabricator.wikimedia.org/T333725) (owner: 10Damilare Adedoyin) [13:44:18] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/907759 (owner: 10L10n-bot) [14:04:11] (03CR) 10Damilare Adedoyin: "Thanks ejegg for the CR. Your patch looks good, I merged it in and added some updates to fix some of the ide errors (basically checking fo" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905258 (https://phabricator.wikimedia.org/T333725) (owner: 10Damilare Adedoyin) [14:13:21] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks for this, tested and worked well. LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/907502 (https://phabricator.wikimedia.org/T334416) (owner: 10Wfan) [15:09:50] (03CR) 10Damilare Adedoyin: [C: 03+2] Update the PAN field label on the dLocal India recurring form. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/907551 (https://phabricator.wikimedia.org/T334103) (owner: 10Wfan) [15:28:22] (03Merged) 10jenkins-bot: Update the PAN field label on the dLocal India recurring form. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/907551 (https://phabricator.wikimedia.org/T334103) (owner: 10Wfan) [15:57:49] thx dami :) [16:00:23] (03PS7) 10Wfan: Add default currency and fiscal number for dlocal MC [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/907502 (https://phabricator.wikimedia.org/T334416) [16:06:19] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.41-notes (1.41.0-wmf.5; 2023-04-17): Update the PAN field label on the dLocal India recurring form. - https://phabricator.wikimedia.org/T334103 (10AnnWF) [16:28:15] i just moved that transaction IDs doc page over and updated it a teeny bit: https://wikitech.wikimedia.org/wiki/Fundraising/Data_and_flow/Transaction_IDs [16:29:22] nice ejegg ! [16:35:52] the updated civi fa icon looks wired ~ [16:48:16] (03PS1) 10Wfan: wrap email pref center link at civi contact page [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907925 [16:49:16] nevermind, the civi fa back to normal now [16:55:41] already 70 out today is going to be warm [16:56:42] cstone: yeah! I heard 90F with 20mph winds in that area [16:59:09] probably will break the record high today and tomorrow [17:13:31] ingenico audit with its airline legs [17:14:50] np Wenjun [17:15:06] I had the ingenico console password reset while the payment console been blocked, do not remember what should I do https://wpc.gcsip.nl/wpc/login? [17:16:02] that reminder was for the nl one i think [17:16:26] yeah im blocked too i never log into that one [17:16:55] we have to email them and have them unblock our test accounts but theyll just get locked out again in a month if we dont log in [17:17:20] im in the production one if anyone needs that account reactivated [17:17:48] haha ok, so the reminder is only for the configuration center [17:18:06] you mean the https://wpc.gcsip.com/wpc/login ? [17:18:24] I got blocked too, if you can reactive mine's [17:19:24] yeah the .nl is the test and .com is live [17:20:04] ok, .com has username WFan [17:20:20] thanks :) [17:30:34] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10FR-dlocal: Ensure fiscal number for India (PAN) is not stored - https://phabricator.wikimedia.org/T333322 (10AnnWF) No need to handle this anymore after we have the label text updated from T334103, so dlocal will not mention that we are not stori... [17:39:54] 10Fundraising Tech - Chaos Crew, 10MW-1.40-notes (1.40.0-wmf.21; 2023-01-30): Name changes required for Ingenico 3DS2.0 - https://phabricator.wikimedia.org/T312877 (10Cstone) Okay in there is now a Test Name [17:54:52] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Handle Refund/Chargeback IPNS for Dlocal - https://phabricator.wikimedia.org/T330723 (10AnnWF) a:03AnnWF [18:04:23] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-codfw: Q3:rack/setup/install frmon2002 - https://phabricator.wikimedia.org/T334501 (10RobH) [18:04:33] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-codfw: Q3:rack/setup/install frmon2002 - https://phabricator.wikimedia.org/T334501 (10RobH) [18:06:02] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-codfw: Q3:rack/setup/install frmon2002 - https://phabricator.wikimedia.org/T334501 (10RobH) [18:07:15] 10Fundraising-Backlog, 10fr-donorservices: adjust audit to catch Adyen script refunds? - https://phabricator.wikimedia.org/T334503 (10MBeat33) [18:11:02] 10Fundraising-Backlog, 10fr-donorservices: adjust audit to catch Adyen script refunds? - https://phabricator.wikimedia.org/T334503 (10MBeat33) [18:11:09] 10Fundraising Tech - Chaos Crew, 10MW-1.40-notes (1.40.0-wmf.21; 2023-01-30): Name changes required for Ingenico 3DS2.0 - https://phabricator.wikimedia.org/T312877 (10Cstone) The name is also in the billing info now: Test Name 10Fundraising-Backlog, 10fr-donorservices: adjust audit to catch Adyen script refunds? - https://phabricator.wikimedia.org/T334503 (10Cstone) This is possibly related to {T325415} [18:14:19] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Investigate 'AstroPay response missing one or more required keys.' errors in the logs - https://phabricator.wikimedia.org/T330646 (10Cstone) Since we requested the switch to apiv2 on production, I'm going to move this one to done. If... [18:14:22] 10Fundraising Tech - Chaos Crew, 10MW-1.40-notes (1.40.0-wmf.21; 2023-01-30): Name changes required for Ingenico 3DS2.0 - https://phabricator.wikimedia.org/T312877 (10Ejegg) Hmm, but no unsplit cardholder name field? I bet those first and last names are from recurring donations where we have sent them separately. [18:15:30] oh ejegg I was checking on .1 donations [18:15:56] cstone: oh weird, I guess they're splitting on the space? [18:16:12] bah I think i got the files I was comparing backwards [18:16:18] what I wrote might be long let me double check this [18:18:36] complete opposite ejegg its not there at all bah lemme look at another random future date I was looking at the one in the comment [18:19:15] (03CR) 10Ejegg: [C: 03+2] "Wow, this /is/ confusing. Seems to fix the issue, though. One question inline." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/906800 (https://phabricator.wikimedia.org/T330231) (owner: 10Eileen) [18:19:33] ah dang cstone, ok [18:20:00] i was expecting they would add a new mononame field [18:21:14] (03PS18) 10Ejegg: Enable Civi-import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901739 (owner: 10Eileen) [18:21:21] (03CR) 10Ejegg: [C: 03+2] Enable Civi-import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901739 (owner: 10Eileen) [18:31:17] (03Merged) 10jenkins-bot: Duck failure [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/906800 (https://phabricator.wikimedia.org/T330231) (owner: 10Eileen) [18:31:44] 10Fundraising Tech - Chaos Crew, 10MW-1.40-notes (1.40.0-wmf.21; 2023-01-30): Name changes required for Ingenico 3DS2.0 - https://phabricator.wikimedia.org/T312877 (10Cstone) Here's an example of the files from a one time, from April 3rd file: 401... [18:32:24] ejegg: I pasted the fields they send now for a one time [18:32:49] (03PS23) 10Ejegg: Add hooks to import to do organization lookup from nick-name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901734 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [18:33:55] (03Merged) 10jenkins-bot: Enable Civi-import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901739 (owner: 10Eileen) [18:33:59] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: GatewayChooser: No supported gateway for parameters - https://phabricator.wikimedia.org/T326666 (10Cstone) Thanks so much @Pcoombe ! [18:34:05] (03CR) 10Ejegg: [C: 03+2] "The hook seems to do its job. I'm eager to see how we will differentiate the different behaviors for the different types of contribution i" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901734 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [18:37:08] (03PS5) 10Ejegg: E-notice fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907540 (owner: 10Eileen) [18:37:13] (03CR) 10Ejegg: [C: 03+2] E-notice fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907540 (owner: 10Eileen) [18:45:43] (03Merged) 10jenkins-bot: Add hooks to import to do organization lookup from nick-name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/901734 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [18:49:38] (03Merged) 10jenkins-bot: E-notice fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907540 (owner: 10Eileen) [18:50:31] (03PS16) 10Ejegg: Handle dLocal Fiscal Number errors [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905258 (https://phabricator.wikimedia.org/T333725) (owner: 10Damilare Adedoyin) [18:50:45] (03CR) 10Ejegg: [C: 03+2] "Thanks! Let's see how this works in production." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905258 (https://phabricator.wikimedia.org/T333725) (owner: 10Damilare Adedoyin) [18:51:02] (03Abandoned) 10Ejegg: WIP pare down dlocal response factory code [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/907512 (https://phabricator.wikimedia.org/T333725) (owner: 10Ejegg) [18:51:19] (03Merged) 10jenkins-bot: Handle dLocal Fiscal Number errors [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/905258 (https://phabricator.wikimedia.org/T333725) (owner: 10Damilare Adedoyin) [18:51:24] damilare: shall we deploy that in these last few minutes, then? [18:54:58] sure ejegg, thanks for the CR [18:56:14] (03PS1) 10Ejegg: Update smash-pig dependency [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907948 [18:58:48] (03PS2) 10Ejegg: Update smash-pig dependency [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907948 [18:58:51] (03CR) 10Ejegg: [C: 03+2] Update smash-pig dependency [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907948 (owner: 10Ejegg) [19:00:18] (03CR) 10CI reject: [V: 04-1] Update smash-pig dependency [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907948 (owner: 10Ejegg) [19:00:18] 10fundraising-tech-ops: Deactivate fundraising accounts for tskaff - https://phabricator.wikimedia.org/T334404 (10Dwisehaupt) [19:00:48] 10fundraising-tech-ops: Deactivate fundraising accounts for tskaff - https://phabricator.wikimedia.org/T334404 (10Dwisehaupt) 05Open→03Resolved Verified not on any exim lists. [19:01:00] (03PS1) 10Ejegg: Update smash-pig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/907950 [19:01:02] (03CR) 10Ejegg: [C: 03+2] Update smash-pig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/907950 (owner: 10Ejegg) [19:01:20] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/907951 [19:01:23] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/907951 (owner: 10Ejegg) [19:01:56] (03CR) 10CI reject: [V: 04-1] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/907951 (owner: 10Ejegg) [19:04:50] (03PS1) 10Ejegg: Update Smash-Pig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/907952 [19:05:12] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/907953 [19:05:27] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/907953 (owner: 10Ejegg) [19:06:03] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface, 10MW-1.41-notes (1.41.0-wmf.4; 2023-04-10): Add IN-specific error page text with appropriate payment methods - https://phabricator.wikimedia.org/T333455 (10XenoRyet) 05Open→03Resolved [19:06:31] (03PS1) 10Ejegg: Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/907954 [19:06:37] (03CR) 10Ejegg: [C: 03+2] Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/907954 (owner: 10Ejegg) [19:06:55] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising Sprint Fish HEAD^, 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, and 4 others: Add customer text hint for India UPI recurring that we only charge monthly with ondemand method - https://phabricator.wikimedia.org/T330530 (10... [19:07:19] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10FR-dlocal: Update error handling for approvePayment and cancelPayment to handle REJECTION responses - https://phabricator.wikimedia.org/T328082 (10XenoRyet) 05Open→03Resolved [19:07:46] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.41-notes (1.41.0-wmf.4; 2023-04-10): Remove netbanking from payment options for India recurring. - https://phabricator.wikimedia.org/T334097 (10XenoRyet) 05Open→03Resolved [19:08:22] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10FR-dlocal: Pending Transaction Resolver support for dLocal - https://phabricator.wikimedia.org/T333220 (10XenoRyet) 05Open→03Resolved [19:09:07] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Try creating a new activity_type_id for Thank yous & see if the UI is still fine - if so switch - https://phabricator.wikimedia.org/T327963 (10XenoRyet) [19:09:14] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Update our code to use the new activity type for thank yous - https://phabricator.wikimedia.org/T332073 (10Eileenmcnaughton) [19:09:18] 10Fundraising Sprint Everything I Merge I Merge For You, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Try creating a new activity_type_id for Thank yous & see if the UI is still fine - if so switch - https://phabricator.wikimedia.org/T327963 (10Eileenmcnaughton) [19:09:21] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Update our code to use the new activity type for thank yous - https://phabricator.wikimedia.org/T332073 (10Eileenmcnaughton) 05Open→03Resolved a:03Eileenmcnaughton [19:09:30] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.41-notes (1.41.0-wmf.4; 2023-04-10): Add optional phone number field for DLocal one-time UPI - https://phabricator.wikimedia.org/T333857 (10XenoRyet) [19:09:38] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: implement the links hook to alter the links available for our new activity types - https://phabricator.wikimedia.org/T332072 (10XenoRyet) 05Open→03Resolved [19:10:22] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface: Remove PayPal EC front-end and orphan rectifier - https://phabricator.wikimedia.org/T315375 (10XenoRyet) [19:10:28] 10Fundraising Sprint Fish HEAD^, 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Remove old PayPal EC orphan rectifier - https://phabricator.wikimedia.org/T332358 (10XenoRyet) 05Open→03Resolved [19:11:11] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe, 10Documentation: Update deduper documentation to explain the critieria better - https://phabricator.wikimedia.org/T327727 (10XenoRyet) 05Open→03Resolved [19:12:04] (03PS3) 10Ejegg: Update smash-pig dependency [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907948 [19:12:07] 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Next regular CiviCRM point release - https://phabricator.wikimedia.org/T332357 (10XenoRyet) 05Open→03Resolved [19:12:52] (03Merged) 10jenkins-bot: Update smash-pig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/907950 (owner: 10Ejegg) [19:13:17] (03CR) 10Ejegg: [C: 03+2] Update smash-pig dependency [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907948 (owner: 10Ejegg) [19:13:31] (03CR) 10CI reject: [V: 04-1] Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/907954 (owner: 10Ejegg) [19:14:17] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, and 3 others: Figure out storage implications of varchar vs text in possible logging solution - https://phabricator.wikimedia.org/T325789 (10XenoRyet) [19:15:43] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/907956 [19:15:58] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/907956 (owner: 10Eileen) [19:16:30] (03PS2) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/907951 [19:16:33] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/907951 (owner: 10Ejegg) [19:16:40] 10fundraising-tech-ops, 10Mail: DMarc Email Address for Wikimedia.org - https://phabricator.wikimedia.org/T316899 (10XenoRyet) [19:17:19] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: UZS Donation Form Error - https://phabricator.wikimedia.org/T332945 (10XenoRyet) 05Open→03Resolved [19:18:03] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: GatewayChooser: No supported gateway for parameters - https://phabricator.wikimedia.org/T326666 (10XenoRyet) 05Open→03Resolved [19:18:49] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Docker, 10MW-1.40-notes (1.40.0-wmf.23; 2023-02-13): fundraising-dev: email prefs showing internal error after fresh install - https://phabricator.wikimedia.org/T327480 (10XenoRyet) 05Open→03Resolved [19:19:32] !log civicrm upgraded from b573aee4 to e2fdb4a4 [19:19:35] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:19:36] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Stop AstroPay failmail related to dLocal test IPNs - https://phabricator.wikimedia.org/T333599 (10XenoRyet) 05Open→03Resolved [19:20:13] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Investigate 'AstroPay response missing one or more required keys.' errors in the logs - https://phabricator.wikimedia.org/T330646 (10XenoRyet) 05Open→03Resolved [19:21:09] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Adyen iframe config error messages Q2 2022: the sequel - https://phabricator.wikimedia.org/T324362 (10XenoRyet) 05Open→03Resolved [19:21:21] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Handle REJECTED IPNS for Dlocal - https://phabricator.wikimedia.org/T332637 (10XenoRyet) 05Open→03Resolved [19:21:51] (03PS1) 10Damilare Adedoyin: Update smashpig to v0.8.4.11 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/907957 [19:22:10] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Docker: Docker: make all MediaWiki services work with Fresh - https://phabricator.wikimedia.org/T326974 (10XenoRyet) 05Open→03Resolved [19:23:05] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Unresponsive donation form 11/24/22 - https://phabricator.wikimedia.org/T323895 (10XenoRyet) 05Open→03Resolved [19:23:56] 10Fundraising Sprint Fish HEAD^, 10Fundraising Sprint Go Your Own Pay, 10Fundraising-Backlog, 10fr-donorservices: Civi not keeping the mailing address attached to the active recurring donation after merging - https://phabricator.wikimedia.org/T330231 (10Eileenmcnaughton) @SHust I replicated the issue in th... [19:24:39] (03CR) 10Damilare Adedoyin: [C: 03+2] Update smashpig to v0.8.4.11 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/907957 (owner: 10Damilare Adedoyin) [19:24:53] (03Merged) 10jenkins-bot: Update smash-pig dependency [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907948 (owner: 10Ejegg) [19:25:16] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Translate: Review CentralNotice patch for Translate namespace change - https://phabricator.wikimedia.org/T327712 (10XenoRyet) 05Open→03Resolved [19:26:06] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/907951 (owner: 10Ejegg) [19:26:21] (03CR) 10Ejegg: [C: 03+2] Update Smash-Pig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/907952 (owner: 10Ejegg) [19:26:40] (03Merged) 10jenkins-bot: Update smashpig to v0.8.4.11 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/907957 (owner: 10Damilare Adedoyin) [19:26:55] (03Abandoned) 10Damilare Adedoyin: Check payment status on dead session [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/864786 (https://phabricator.wikimedia.org/T324478) (owner: 10Damilare Adedoyin) [19:27:22] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Check if payment is successful or failed even if Session is Unavailable - https://phabricator.wikimedia.org/T324478 (10XenoRyet) 05Open→03Resolved [19:27:59] (03Merged) 10jenkins-bot: Update Smash-Pig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/907952 (owner: 10Ejegg) [19:28:01] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/907953 (owner: 10Ejegg) [19:28:46] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, 10fr-donorservices: dLocal audit file: some recent refunds not reaching Civi - https://phabricator.wikimedia.org/T333247 (10XenoRyet) 05Open→03Resolved [19:29:01] !log civicrm upgraded from e2fdb4a4 to 0f37f981 [19:29:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:31:06] !log payments-wiki upgraded from ad6e5801 to 153bdf64 [19:31:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:32:02] 10fundraising-tech-ops, 10User-greg: Renew FR-Tech nessus license - https://phabricator.wikimedia.org/T332097 (10greg) p:05Triage→03Medium In Coupa, doing the machinations there. [19:35:47] (03PS2) 10Ejegg: Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/907954 [19:36:11] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/907962 [19:37:27] (03CR) 10Damilare Adedoyin: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/907962 (owner: 10Damilare Adedoyin) [19:38:31] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/907962 (owner: 10Damilare Adedoyin) [19:54:31] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert contribution tracking module to an extension - https://phabricator.wikimedia.org/T270665 (10Ejegg) Related: T158140 [19:57:59] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10MediaWiki-extensions-DonationInterface: Consolidate contribution_tracking code into a single library - https://phabricator.wikimedia.org/T120466 (10Ejegg) 05Open→03Resolved a:03Ejegg We've consolidated all the table writing to one place in CRM a... [19:58:01] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10MediaWiki-extensions-DonationInterface, 10Epic: [epic] SPOF: Use Redis as backend store for contribution_tracking - https://phabricator.wikimedia.org/T119556 (10Ejegg) [20:01:00] 10Fundraising-Backlog: Scope contribution tracking - https://phabricator.wikimedia.org/T182030 (10Eileenmcnaughton) [20:01:02] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert contribution tracking module to an extension - https://phabricator.wikimedia.org/T270665 (10Eileenmcnaughton) [20:01:04] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Make contribution tracking data visible in CiviCRM - https://phabricator.wikimedia.org/T158140 (10Eileenmcnaughton) [20:01:54] 10Fundraising-Backlog: Scope contribution tracking - https://phabricator.wikimedia.org/T182030 (10Ejegg) [20:02:26] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: adjust audit to catch Adyen script refunds? - https://phabricator.wikimedia.org/T334503 (10XenoRyet) [20:04:01] 10Fundraising-Backlog: Scope contribution tracking - https://phabricator.wikimedia.org/T182030 (10Eileenmcnaughton) [20:04:03] 10Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, 10Fundraising-Backlog: investigate: Record user agent in contribution_tracking - https://phabricator.wikimedia.org/T182039 (10Eileenmcnaughton) [20:04:05] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10MediaWiki-extensions-DonationInterface: Move contribution_tracking out of drupal db - https://phabricator.wikimedia.org/T158010 (10Eileenmcnaughton) [20:04:07] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10MediaWiki-extensions-DonationInterface: [Epic] Contribution tracking reform - https://phabricator.wikimedia.org/T158009 (10Eileenmcnaughton) [20:04:11] 10Fundraising-Backlog: Investigate and bring back data & functionality previously held in contribution tracking table - https://phabricator.wikimedia.org/T150055 (10Eileenmcnaughton) [20:04:59] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Donors seeing checkoutshopper-live-us.adyen.com error - https://phabricator.wikimedia.org/T334407 (10XenoRyet) [20:05:05] 10Fundraising-Backlog, 10MW-1.35-notes (1.35.0-wmf.37; 2020-06-16): Make Contribution Tracking not a SPOF - https://phabricator.wikimedia.org/T86253 (10Ejegg) 05Open→03Resolved a:03Ejegg [20:05:07] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10MediaWiki-extensions-DonationInterface: [Epic] Contribution tracking reform - https://phabricator.wikimedia.org/T158009 (10Ejegg) [20:06:31] (03CR) 10Eileen: [C: 03+2] wrap email pref center link at civi contact page [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907925 (owner: 10Wfan) [20:19:05] (03Merged) 10jenkins-bot: wrap email pref center link at civi contact page [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/907925 (owner: 10Wfan) [20:25:27] 10Fundraising Sprint H 2023, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Local dev venvironment bug (recent?) - not including vendor/autoload.php - https://phabricator.wikimedia.org/T334440 (10XenoRyet) [20:25:34] 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint H 2023, 10Fundraising-Backlog, 10FR-dlocal: dlocal MC with default country and fiscal number not working for multiple currencies - https://phabricator.wikimedia.org/T334416 (10XenoRyet) [20:25:39] 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint H 2023, 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.41-notes (1.41.0-wmf.5; 2023-04-17): Update the PAN field label on the dLocal India recurring form. - https://phabricator.wikimedia.org/T334103 (10XenoRyet) [20:25:44] 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint H 2023, 10Fundraising-Backlog, 10FR-dlocal: Ensure fiscal number for India (PAN) is not stored - https://phabricator.wikimedia.org/T333322 (10XenoRyet) [20:25:47] 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint H 2023, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Dlocal prod account switcheroo - https://phabricator.wikimedia.org/T334414 (10XenoRyet) [20:25:50] 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint H 2023, 10Fundraising-Backlog: SmashPig Adapter Layer - https://phabricator.wikimedia.org/T332236 (10XenoRyet) [20:25:52] 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint H 2023, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Handle dLocal Fiscal Number errors - https://phabricator.wikimedia.org/T333725 (10XenoRyet) [20:25:54] 10Fundraising Sprint Fish HEAD^, 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint H 2023, 10Fundraising-Backlog: Testing: Paytm recurring remains in pending status - https://phabricator.wikimedia.org/T332835 (10XenoRyet) [20:25:56] 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint H 2023, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Handle Refund/Chargeback IPNS for Dlocal - https://phabricator.wikimedia.org/T330723 (10XenoRyet) [20:25:58] 10Fundraising Sprint Fish HEAD^, 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint H 2023, 10Fundraising-Backlog, 10fr-donorservices: Civi not keeping the mailing address attached to the active recurring donation after merging - https://phabricator.wikimedia.org/T330231 (10XenoRyet) [20:26:05] 10Fundraising Sprint Fish HEAD^, 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint H 2023, 10Fundraising-Backlog, 10FR-dlocal: DLocal Audit - Test with new integration - https://phabricator.wikimedia.org/T324347 (10XenoRyet) [20:26:10] 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint H 2023, 10Fundraising-Backlog, 10FR-dlocal, and 4 others: Enable Monthly Convert for DLocal in all markets that support recurring cards - https://phabricator.wikimedia.org/T324624 (10XenoRyet) [20:26:14] 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint H 2023, 10Fundraising-Backlog, 10Patch-For-Review: Add Online Banking for Czech Republic - https://phabricator.wikimedia.org/T328717 (10XenoRyet) [20:26:24] 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint H 2023, 10Fundraising-Backlog, 10FR-Smashpig, and 3 others: Update DLocal createPayment for UPI / DIRECT method - https://phabricator.wikimedia.org/T324294 (10XenoRyet) [20:26:34] 10Fundraising Sprint H 2023, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Technical-Debt: Delete Globalcollect adapter, fold still-used code into Ingenico adapter - https://phabricator.wikimedia.org/T260725 (10XenoRyet) [20:26:38] 10Fundraising Sprint Fish HEAD^, 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint H 2023, 10Fundraising-Backlog, and 4 others: Update DLocal audit parsing to tag donations as 'dlocal' rather than 'astropay' when appropriate - https://phabricator.wikimedia.org/T324292 (10XenoRyet) [20:26:42] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint Can't touch $this, 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising Sprint Everything I Merge I Merge For You, and 13 others: Creating New Matching Gift Import - https://phabricator.wikimedia.org/T303986 (10XenoRyet) [20:26:46] 10Fundraising Sprint H 2023, 10Fundraising-Backlog: Scope contribution tracking - https://phabricator.wikimedia.org/T182030 (10XenoRyet) [20:26:50] 10Fundraising Sprint Fish HEAD^, 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint H 2023, 10Fundraising-Backlog, 10Patch-For-Review: Ingenico/Worldline addition of Initial Scheme Transaction ID to avoid recurring declines - https://phabricator.wikimedia.org/T331754 (10XenoRyet) [20:26:54] 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint H 2023, 10Fundraising Sprint Juggalology 2022, 10Fundraising Sprint Kermit hopping principle, and 6 others: Currency code/currency symbol in Thank You emails received by Donors issues - https://phabricator.wikimedia.org/T309349 (10XenoRyet) [20:26:58] 10Fundraising Sprint H 2023, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Make contribution tracking data visible in CiviCRM - https://phabricator.wikimedia.org/T158140 (10XenoRyet) [20:37:23] (03PS11) 10Eileen: Add hook support to look up individual and handle soft credits during import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904380 (https://phabricator.wikimedia.org/T303986) [20:37:25] (03PS7) 10Eileen: Remove custom code that is obsolete [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904948 (https://phabricator.wikimedia.org/T332357) [20:37:27] (03PS8) 10Eileen: Fix to match individual on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904954 [20:37:29] (03PS6) 10Eileen: Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) [20:40:29] (03CR) 10CI reject: [V: 04-1] Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [20:45:19] 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Handle Refund/Chargeback IPNS for Dlocal - https://phabricator.wikimedia.org/T330723 (10AnnWF) a:05AnnWF→03None [20:50:22] 10fundraising-tech-ops, 10SRE, 10SRE-Access-Requests: As an FR-Tech SRE, we want to be able to designate a host for decommissioning - https://phabricator.wikimedia.org/T334154 (10BCornwall) p:05Triage→03Medium [20:52:33] ejegg: are you trying to do the payments deploy also? [21:01:13] ohh ok I see the deployment has been done. thanks! [21:27:23] 10Fundraising Sprint Fish HEAD^, 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog, 10fr-donorservices: Civi not keeping the mailing address attached to the active recurring donation after merging - https://phabricator.wikimedia.org/T330231 (10SHust)... [21:39:35] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: Scope contribution tracking - https://phabricator.wikimedia.org/T182030 (10Ejegg) Places that refer to the table: * wmf_audit_get_contribution_tracking_data in wmf_audit.module * ContributionTrackingQueueConsumer * recurring_get_contribution_t... [21:40:08] eileen: do you have any thoughts as to the 'other challenges' I mentioned in that comment? ^^^ [21:40:29] damilare: yep, I tried to do it at the start of the meeting but it dragged on a little while [21:43:04] (03CR) 10Ejegg: "We could also just add these in the LocalSettings.php shipped with fundraising-dev" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/907500 (https://phabricator.wikimedia.org/T324624) (owner: 10Wfan) [21:46:45] ejegg: looking [21:47:35] ejegg: I guess I have to fully understand what is in the table - I'll see if we have documented on wikitech.... [21:48:33] well I found this https://wikitech.wikimedia.org/wiki/Fundraising/ContributionTracking [21:49:12] feels a bit outta date [21:50:49] ok this is better https://wikitech.wikimedia.org/wiki/Fundraising_Tracking [21:55:30] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: Scope contribution tracking - https://phabricator.wikimedia.org/T182030 (10Eileenmcnaughton) How about we 1) create a new table / entity in CiviCRM called ... contribution tracking 2) move the data there 3) drop the drupal table and replace... [21:58:18] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: Scope contribution tracking - https://phabricator.wikimedia.org/T182030 (10Eileenmcnaughton) to the challenges 1) can we make a civicrm entity that matches the exact table schema? - I think so 2) will it be easy to see the contribution_track... [22:00:06] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: Scope contribution tracking - https://phabricator.wikimedia.org/T182030 (10Eileenmcnaughton) Documentation links - I thinour subtasks should include a cleanup pass on these https://wikitech.wikimedia.org/wiki/Fundraising_Tracking https://wiki... [22:02:49] ejegg: can discuss in the tech talk now [23:08:09] I should have asked - if anyone wants to take on any of those tasks & I can help? or if people are working on other stuff & I should dive in ? https://etherpad.wikimedia.org/p/U4kN8qr7OPQbK3rciCSF [23:09:11] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: adjust audit to catch Adyen script refunds? - https://phabricator.wikimedia.org/T334503 (10Cstone) @MBeat33 I don't know why but the script refunds didn't get to refunded status until 4/10 as you saw. They were in the 4/10 audit file... [23:33:07] (03PS1) 10Wfan: Add mocked monthly convert amount suggestions to dlocal [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/907998 (https://phabricator.wikimedia.org/T324624) [23:34:01] (03Abandoned) 10Wfan: Add mocked monthly convert amount suggestions to dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/907500 (https://phabricator.wikimedia.org/T324624) (owner: 10Wfan) [23:39:24] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Monthly Convert Popup with Other amount error UI not working - https://phabricator.wikimedia.org/T334308 (10AnnWF) a:03AnnWF