[00:16:02] (03PS1) 10Eileen: Add vendor/autoload to pre.d settings.php [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/908003 (https://phabricator.wikimedia.org/T334440) [00:18:14] ejegg|afk: that error while demo-ing was the dreaded autoload.php ^^ works I think [00:20:53] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Local dev venvironment bug (recent?) - not including vendor/autoload.php - https://phabricator.wikimedia.org/T334440 (10Eileenmcnaughton) a:03Eileenmcnaughton [00:22:20] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: Scope contribution tracking - https://phabricator.wikimedia.org/T182030 (10Eileenmcnaughton) Just bringing notes from the etherpad.... Subtasks 1) create new entity 2 https://docs.civicrm.org/dev/en/latest/step-by-step/create-entity/ 1.1 - ex... [00:32:38] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: Scope contribution tracking - https://phabricator.wikimedia.org/T182030 (10Eileenmcnaughton) @JMando just pinging you in on this ticket. We are addressing a long-standing goal of moving the `contribution_tracking` and `contribution_source` o... [00:39:09] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity - https://phabricator.wikimedia.org/T334532 (10Eileenmcnaughton) [00:41:18] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1 - exclude new contribution tracking entity from logging - https://phabricator.wikimedia.org/T334533 (10Eileenmcnaughton) [00:41:26] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1 - exclude new contribution tracking entity from logging - https://phabricator.wikimedia.org/T334533 (10Eileenmcnaughton) [00:42:17] nice, it works for me too eileen [00:42:23] ejegg: phew [00:42:37] (03CR) 10Ejegg: [V: 03+2 C: 03+2] "Thanks!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/908003 (https://phabricator.wikimedia.org/T334440) (owner: 10Eileen) [00:42:46] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity - https://phabricator.wikimedia.org/T334532 (10Eileenmcnaughton) [00:43:08] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: Scope contribution tracking - https://phabricator.wikimedia.org/T182030 (10Eileenmcnaughton) @ejegg some questions I have 1) should we put the new entity in wmf_civicrm extension 2) should the schema accomodate extra fields per https://phabri... [00:44:33] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: give our vendor dir a thorough update, look at removing & ignoring composer.lock files from it - https://phabricator.wikimedia.org/T334515 (10Eileenmcnaughton) [00:46:27] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: Scope contribution tracking - https://phabricator.wikimedia.org/T182030 (10Ejegg) 1) Sure, seems fine to me. 2) Maybe not yet - if we want to start storing browser we might want to double check that nobody has a problem with it. We could updat... [00:47:31] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1 - populate the civi fields - https://phabricator.wikimedia.org/T334534 (10Eileenmcnaughton) [00:47:43] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1 - populate the civi fields - https://phabricator.wikimedia.org/T334534 (10Eileenmcnaughton) [00:48:51] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: Scope contribution tracking - https://phabricator.wikimedia.org/T182030 (10Eileenmcnaughton) @ejegg yeah we can add browser stuff later - it's only that the reason it didn't happen when requested was that it seems that adding the fields requir... [00:48:53] cstone I have two little audit patches that might stop the failmail: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/907559 [00:49:24] and https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/907517 [00:51:06] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1 Create a view to replace the drupal table - https://phabricator.wikimedia.org/T334535 (10Eileenmcnaughton) [00:53:08] ejegg: to the browser details question [00:53:08] 1) do we have that info to store & [00:53:08] 2) who would approve / disapprove it [00:53:08] - it feels like it might be technically trivial & the conversation is the main work involved - in which case maybe we should kick that off? [00:53:21] (technically trivial to do in the existing outage) [00:53:53] yeah, OK, let's see who we would consult about donor privacy things [00:54:42] so... to make it slightly less cross-referenceable we could just store browser family and maybe major version? [00:55:04] also maybe more useful that way [00:56:19] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1.5 - https://phabricator.wikimedia.org/T334537 (10Eileenmcnaughton) [00:56:53] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1.5 - https://phabricator.wikimedia.org/T334537 (10Eileenmcnaughton) [00:57:24] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1.5 - https://phabricator.wikimedia.org/T334537 (10Eileenmcnaughton) [00:57:42] ejegg: yeah the original phab seemed to settle on those 2 fields [00:58:11] this was it https://phabricator.wikimedia.org/T182039 [00:59:23] ok, let's add those fields then [00:59:32] looks like OS name and major version too [00:59:54] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: Scope contribution tracking - https://phabricator.wikimedia.org/T182030 (10Eileenmcnaughton) [01:00:22] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1.5 - Update code references to contribution_tracking - https://phabricator.wikimedia.org/T334537 (10Eileenmcnaughton) [01:00:34] ejegg: ok [01:02:34] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1.5 cleanup & update contribution_tracking documentation - https://phabricator.wikimedia.org/T334538 (10Eileenmcnaughton) [01:05:48] https://usercontent.irccloud-cdn.com/file/iS5XhagI/image.png [01:12:40] (03PS3) 10Ejegg: Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/907954 [01:24:58] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1.5 Go through phab tasks & clean up relating to contribution tracking - https://phabricator.wikimedia.org/T334539 (10Eileenmcnaughton) [01:37:27] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1 - expose in the UI - https://phabricator.wikimedia.org/T334540 (10Eileenmcnaughton) [01:37:39] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1 - expose in the UI - https://phabricator.wikimedia.org/T334540 (10Eileenmcnaughton) [01:39:12] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 2 - drop the interim drupal view - https://phabricator.wikimedia.org/T334542 (10Eileenmcnaughton) [01:39:54] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 2 Disable the module & delete the code - https://phabricator.wikimedia.org/T334543 (10Eileenmcnaughton) [01:40:05] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 2 Disable the module & delete the code - https://phabricator.wikimedia.org/T334543 (10Eileenmcnaughton) [01:41:06] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-tangent remove queue2civicrm_log tables & writing to them 2 - https://phabricator.wikimedia.org/T334544 (10Eileenmcnaughton) [01:50:44] (03PS1) 10Eileen: Remove references to queue2civicrm_log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908009 (https://phabricator.wikimedia.org/T334544) [01:51:41] 10Fundraising-Backlog: astropay audit parse failed due to error Unknown bank code: IR - https://phabricator.wikimedia.org/T334545 (10AnnWF) [01:52:25] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog, 10Patch-For-Review: CT-to-Civi-tangent remove queue2civicrm_log tables & writing to them 2 - https://phabricator.wikimedia.org/T334544 (10Eileenmcnaughton) I put up a patch to remove all references to queue2civicrm_log except the table. I'm... [01:57:54] (03PS1) 10Ejegg: WIP createPaymentSession for Ingenico HostedCheckoutProvider [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/908010 (https://phabricator.wikimedia.org/T260725) [01:58:21] (03CR) 10CI reject: [V: 04-1] WIP createPaymentSession for Ingenico HostedCheckoutProvider [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/908010 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [02:03:43] (03PS2) 10Ejegg: WIP createPaymentSession for Ingenico HostedCheckoutProvider [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/908010 (https://phabricator.wikimedia.org/T260725) [02:06:01] (03CR) 10Ejegg: Remove references to queue2civicrm_log (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908009 (https://phabricator.wikimedia.org/T334544) (owner: 10Eileen) [02:11:01] (03PS7) 10Eileen: Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) [02:11:03] (03PS1) 10Eileen: Do not create relationship for anonymous contact [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908011 [02:11:15] (03CR) 10Eileen: Remove references to queue2civicrm_log (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908009 (https://phabricator.wikimedia.org/T334544) (owner: 10Eileen) [02:13:22] 10Fundraising-Backlog: Contact been deleted from civicrm_contact - https://phabricator.wikimedia.org/T334548 (10AnnWF) [02:13:59] (03PS2) 10Eileen: Remove references to queue2civicrm_log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908009 (https://phabricator.wikimedia.org/T334544) [02:14:25] (03CR) 10CI reject: [V: 04-1] Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [02:14:33] 10Fundraising-Backlog: Contact been deleted from civicrm_contact - https://phabricator.wikimedia.org/T334548 (10Eileenmcnaughton) hmm - that feels more like a roll back than a delete [02:14:44] 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog, 10FR-dlocal: dlocal MC with default country and fiscal number not working for multiple currencies - https://phabricator.wikimedia.org/T334416 (10AnnWF) Only in ZA and IN you can send the default docume... [02:16:03] 10Fundraising-Backlog: Contact been deleted from civicrm_contact - https://phabricator.wikimedia.org/T334548 (10AnnWF) [02:17:16] (03PS8) 10Eileen: Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) [02:30:27] 10Fundraising-Backlog: Contact not exist from civicrm_contact - https://phabricator.wikimedia.org/T334548 (10AnnWF) [02:47:11] (03PS1) 10Eileen: Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) [02:56:30] (03PS8) 10Eileen: Remove custom code that is obsolete [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904948 (https://phabricator.wikimedia.org/T332357) [02:56:32] (03PS9) 10Eileen: Add import handling for individual look up and soft credits. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904954 (https://phabricator.wikimedia.org/T303986) [02:56:34] (03PS2) 10Eileen: Do not create relationship for anonymous contact [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908011 (https://phabricator.wikimedia.org/T303986) [02:56:36] (03PS9) 10Eileen: Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) [02:56:38] (03PS2) 10Eileen: Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) [02:56:59] (03Abandoned) 10Eileen: Add hook support to look up individual and handle soft credits during import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904380 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [02:59:12] (03CR) 10CI reject: [V: 04-1] Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [03:00:17] (03CR) 10CI reject: [V: 04-1] Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [03:00:54] (03CR) 10CI reject: [V: 04-1] Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [03:01:32] (03PS10) 10Eileen: Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) [03:01:34] (03PS3) 10Eileen: Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) [03:05:08] (03CR) 10CI reject: [V: 04-1] Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [03:05:10] (03CR) 10CI reject: [V: 04-1] Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [04:10:56] (03PS4) 10Eileen: Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) [04:10:58] (03PS11) 10Eileen: Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) [04:22:52] (03CR) 10CI reject: [V: 04-1] Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [04:23:10] (03CR) 10CI reject: [V: 04-1] Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [04:35:05] (03PS3) 10Eileen: Add import handling for individual look up and soft credits. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908011 (https://phabricator.wikimedia.org/T303986) [04:35:07] (03PS12) 10Eileen: Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) [04:35:09] (03PS5) 10Eileen: Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) [04:40:49] (03Abandoned) 10Eileen: Add import handling for individual look up and soft credits. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908011 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [04:41:13] (03Abandoned) 10Eileen: Add import handling for individual look up and soft credits. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/904954 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [04:41:46] (03PS13) 10Eileen: Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) [04:41:48] (03PS6) 10Eileen: Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) [04:41:50] (03PS1) 10Eileen: Add import handling for individual look up and soft credits. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908015 (https://phabricator.wikimedia.org/T303986) [04:53:47] (03CR) 10CI reject: [V: 04-1] Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [04:56:32] (03PS7) 10Eileen: Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) [05:08:04] (03CR) 10CI reject: [V: 04-1] Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [05:15:01] (03PS8) 10Eileen: Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) [05:32:43] (03PS1) 10Eileen: Add check for the contribution already existing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908050 (https://phabricator.wikimedia.org/T303986) [05:37:44] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/908074 (owner: 10L10n-bot) [05:43:50] (03CR) 10CI reject: [V: 04-1] Add check for the contribution already existing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908050 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [05:53:31] (03PS2) 10Eileen: Add check for the contribution already existing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908050 (https://phabricator.wikimedia.org/T303986) [06:05:48] (03CR) 10CI reject: [V: 04-1] Add check for the contribution already existing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908050 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [06:46:08] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908167 (owner: 10L10n-bot) [06:55:14] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908167 (owner: 10L10n-bot) [07:24:13] (03PS1) 10Amire80: Add a space in a recently updated message [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908194 [07:25:02] (03CR) 10Amire80: "If it was intentional not to write a space there, please abandon :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908194 (owner: 10Amire80) [11:49:22] cool ejegg, thanks for that [11:54:43] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity - https://phabricator.wikimedia.org/T334532 (10Damilare) a:03Damilare [13:12:11] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/908074 (owner: 10L10n-bot) [13:57:48] (03PS1) 10Damilare Adedoyin: CiviX upgrade. Creating a new entity in wmf-civicrm required an upgrade to civix (from 22.05.2 to 23.02.1), this upgrade led to changes in a number of files including the Upgrader. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908239 [13:59:28] (03PS1) 10Damilare Adedoyin: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) [14:00:15] (03PS2) 10Damilare Adedoyin: CiviX upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908239 [14:00:30] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [14:25:45] (03CR) 10Damilare Adedoyin: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [14:28:31] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [15:32:55] (03CR) 10Ejegg: [C: 03+2] Add a space in a recently updated message [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908194 (owner: 10Amire80) [15:47:13] (03Merged) 10jenkins-bot: Add a space in a recently updated message [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908194 (owner: 10Amire80) [16:41:34] (03PS2) 10Damilare Adedoyin: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) [16:45:29] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [16:55:10] (03PS3) 10Damilare Adedoyin: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) [16:58:57] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [17:06:22] !log payments-wiki upgraded from efe7e408 to 4dcba0a9 [17:06:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:06:53] ok pcoombe, that got all the latest translations out for FundraisingEmailUnsubscribe [17:18:55] tx ejegg [17:20:12] (03PS4) 10Ejegg: Enable CZ online banking for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904386 (https://phabricator.wikimedia.org/T328717) [17:20:14] (03PS2) 10Ejegg: DO NOT MERGE: paymentMethodResponse for testing CZ bt [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904657 (https://phabricator.wikimedia.org/T328717) [17:20:16] (03PS1) 10Ejegg: Use constant name for Adyen component container [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908307 [17:21:33] damilare: that's the CZ patch updated - I still can't get it to render anything in dev unfortunately [17:21:48] I haven't stepped into the adyen js to see where it stops [17:21:56] (03CR) 10CI reject: [V: 04-1] DO NOT MERGE: paymentMethodResponse for testing CZ bt [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904657 (https://phabricator.wikimedia.org/T328717) (owner: 10Ejegg) [17:22:00] I guess maybe just test that it doesn't break any other message? [17:22:11] err, any other method [17:22:48] ok, checking [17:26:32] hmm, smoke testing again locally and it's just an error page [17:26:36] let's see [17:27:02] oh just the comms failure [17:27:08] restarting the payments container [17:49:01] yes ejegg, I am getting a type error in jquery. Is that the same as what you have? [17:58:52] oh interesting damilare, are you testing with that DO NOT MERGE patch on top of it? [17:59:15] no I'm testing just this: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/904386/4 [17:59:28] but on a vpn [17:59:46] locally I'm seeing the fail page with no details [18:03:55] other methods are working fine including applepay and gpay [18:04:56] oh i see [18:05:34] I'm using this pach which pulls in the bank transfer config that we get in production from the CZ/CZK payment method lookup: https://gerrit.wikimedia.org/r/904657 [18:06:00] and I've just been stepping through the adyen JS code [18:06:33] inside of the component's mount function, it looks like the 'render' function is being skipped for some reason [18:07:10] so it doesn't throw any errors, but it doesn't render any bank list either [18:09:58] ok I just pulled that down, but I can't seem to be able to download the js [18:11:33] ah, i'm using firefox which seems to get the typescript files from a source.map [18:11:46] so it's showing me the unminified things [18:15:26] oh ok [18:18:19] ejegg could this be a version issue [18:18:46] I see we are using 4.3.0 locally but in the docs there's this line: "Components version 5.22.0 or later" [18:22:55] hmm, maybe [18:23:09] I'm afraid we will have to change our code a bit if we upgrade past version 5 [18:23:16] actually, let's see how big a change that is [18:29:02] ok, after upgrading to 5.39 it says 'checkout.create' is not a function [18:29:11] so yeah, that will be a bigger change [18:29:38] I updated to 5.22.0 and it shows the DI page for a few secs before crashing into the fail [18:29:59] here's the errror in the log: TypeError: Cannot read properties of null (reading 'script') [18:30:15] oh i see In Components versions 5.0.0 or later, the creation of AdyenCheckout is asynchronous: [18:31:35] so we need to handle that asynchrony [18:32:23] ohh ok [18:34:14] oho, just a couple lines and it works! [18:34:19] hmm hmm hmm [18:34:55] I guess we need to be pretty sure the cards don't break [18:35:04] let me make a separate patch for the version upgrade [18:36:04] nice! [18:37:01] (03PS1) 10Ejegg: Make Adyen setup function async [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908318 [18:37:18] damilare: OK, I /think/ that should work with either old or new JS [18:37:37] seen, I'd test it out too [18:37:47] thanks! [18:37:47] I can push a patch to config-private with the new versions and integrity hashes for the script and the css [18:38:00] sounds good [18:38:49] (03CR) 10CI reject: [V: 04-1] Make Adyen setup function async [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908318 (owner: 10Ejegg) [18:38:59] oops, let's see what that's about [18:39:29] oh no, eslint doesn't like it at all [18:39:43] might need to tell eslint to use a newer JS profile [18:39:55] haha finally! [18:40:32] because caniuse is pretty sure we can use async: https://caniuse.com/?search=await [18:42:07] hmm, I wonder if it's just using a promise under the hood - I could try with 'then()' syntax [18:42:18] yh that would work too [18:42:25] just not as beautiful [18:44:54] weird, it seems to still be breaking on my end.9 [18:45:03] I'll wait for the config push [18:48:35] ok, I pushed the 5.39 version to config-private [18:49:21] hmm, getting an error page now [18:49:27] velocity filter? [18:50:02] oh right, I'm still trying to load the CZ form off of the branch that actually adds that option [18:50:19] lemme try just a Card form with the .then() syntax [18:51:05] ok, that seems to work [18:51:19] but it adds some new card icons in the UI that I think we don't want [18:51:30] probably a new option to turn those off [18:59:10] 10Fundraising-Backlog, 10fundraising-tech-ops: [FR Analytics]: move frdev1001:/srv/br/analytics out to it's own directory - https://phabricator.wikimedia.org/T258601 (10Jgreen) >>! In T258601#8743405, @Pcoombe wrote: > Hi @Jgreen did anything change here? I don't see a directory at `/srv/analytics` Hey @Pcoom... [19:00:33] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Epic: Epic: Fundraising Analytics Tools - https://phabricator.wikimedia.org/T212796 (10Jgreen) 05Open→03Resolved a:03Jgreen Closing this Epic task, there are no remaining subtasks. [19:02:52] 10fundraising-tech-ops: encrypt fundraising database client->server communication - https://phabricator.wikimedia.org/T170321 (10Jgreen) p:05Triage→03Medium [19:06:49] I was trying to find a phab query to show me open tasks with (only) closed subtasks and... it's not cooperating [19:13:02] (03CR) 10Eileen: [C: 03+2] CiviX upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908239 (owner: 10Damilare Adedoyin) [19:16:28] (03CR) 10Eileen: "For the foreign key we want SET NULL I think" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [19:20:22] (03PS4) 10Damilare Adedoyin: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) [19:23:58] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [19:24:38] (03Merged) 10jenkins-bot: CiviX upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908239 (owner: 10Damilare Adedoyin) [19:25:53] greg-g: yeah. even looking at the conduit api the hasSubtasks constraint is listed as "Open Subtasks" and is a bool. so i don't think it's possible with a single query. [19:27:16] (03PS5) 10Damilare Adedoyin: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) [19:30:02] (03CR) 10jenkins-bot: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [19:30:17] (03PS6) 10Damilare Adedoyin: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) [19:33:28] if you used a conduit query to return the task ids for anything with an open parent and a state of (declined|invalid|resolved) and then iterated that list of parent tickets with a query without open subtasks. [19:34:01] probably doable without too much additional coding. [19:34:09] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [20:13:12] (03PS7) 10Eileen: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [20:17:01] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [20:22:38] (03PS2) 10Ejegg: Make Adyen setup function async [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908318 [20:24:16] (03CR) 10CI reject: [V: 04-1] Make Adyen setup function async [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908318 (owner: 10Ejegg) [20:25:30] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: adjust audit to catch Adyen script refunds? - https://phabricator.wikimedia.org/T334503 (10MBeat33) p:05Triage→03Medium Thank you, @Cstone for the info. I will queue that question for next week's Adyen call. [20:36:49] (03PS8) 10Eileen: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [20:40:54] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [20:41:28] (03PS3) 10Ejegg: Make Adyen setup function async [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908318 [20:41:30] (03PS5) 10Ejegg: Enable CZ online banking for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904386 (https://phabricator.wikimedia.org/T328717) [20:41:32] (03PS2) 10Ejegg: Use constant name for Adyen component container [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908307 [20:41:34] (03PS3) 10Ejegg: DO NOT MERGE: paymentMethodResponse for testing CZ bt [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904657 (https://phabricator.wikimedia.org/T328717) [20:43:37] (03CR) 10CI reject: [V: 04-1] Use constant name for Adyen component container [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908307 (owner: 10Ejegg) [20:43:44] (03CR) 10CI reject: [V: 04-1] Make Adyen setup function async [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908318 (owner: 10Ejegg) [20:43:50] (03CR) 10CI reject: [V: 04-1] DO NOT MERGE: paymentMethodResponse for testing CZ bt [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904657 (https://phabricator.wikimedia.org/T328717) (owner: 10Ejegg) [20:44:10] (03CR) 10CI reject: [V: 04-1] Enable CZ online banking for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904386 (https://phabricator.wikimedia.org/T328717) (owner: 10Ejegg) [20:47:15] (03PS9) 10Eileen: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [20:49:59] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [20:50:40] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail: Investigate in-house DMARC analysis tool options - https://phabricator.wikimedia.org/T317443 (10Jgreen) 05Open→03Declined Closing this task because it is no longer needed/relevant, since SRE is looking at a solution in T330944. [20:50:44] 10fundraising-tech-ops, 10Mail: DMarc Email Address for Wikimedia.org - https://phabricator.wikimedia.org/T316899 (10Jgreen) [20:52:59] (03PS10) 10Eileen: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [20:54:47] (03PS6) 10Ejegg: Enable CZ online banking for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904386 (https://phabricator.wikimedia.org/T328717) [20:54:48] (03PS3) 10Ejegg: Use constant name for Adyen component container [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908307 [20:54:51] (03PS4) 10Ejegg: DO NOT MERGE: paymentMethodResponse for testing CZ bt [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904657 (https://phabricator.wikimedia.org/T328717) [20:54:53] (03CR) 10Eileen: "Looking at the field causing the problems (form_amount) I wonder if we could split it in 2 ie original_currency & original_amount" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [20:56:12] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [20:56:38] (03CR) 10CI reject: [V: 04-1] Enable CZ online banking for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904386 (https://phabricator.wikimedia.org/T328717) (owner: 10Ejegg) [20:56:43] (03CR) 10CI reject: [V: 04-1] Use constant name for Adyen component container [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908307 (owner: 10Ejegg) [20:57:02] (03CR) 10CI reject: [V: 04-1] DO NOT MERGE: paymentMethodResponse for testing CZ bt [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904657 (https://phabricator.wikimedia.org/T328717) (owner: 10Ejegg) [21:05:09] (03PS11) 10Eileen: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [21:09:17] (03PS3) 10Eileen: Add check for the contribution already existing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908050 (https://phabricator.wikimedia.org/T303986) [21:10:07] (03PS1) 10Eileen: Fix another place with trxn_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908352 [21:10:47] 10Fundraising-Backlog, 10fundraising-tech-ops: Migrate process-control jobs from civi1001 to civi1002 - https://phabricator.wikimedia.org/T332632 (10Dwisehaupt) For the silverpop job, we also want to swap the db it is referencing. Currently it uses frdev1001 and we'll want it to use frdb1006 in the future config. [21:29:27] oops damilare I just saw those CI V-1s [21:35:14] (03PS4) 10Ejegg: Make Adyen setup function async [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908318 [21:35:16] (03PS7) 10Ejegg: Enable CZ online banking for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904386 (https://phabricator.wikimedia.org/T328717) [21:35:18] (03PS4) 10Ejegg: Use constant name for Adyen component container [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908307 [21:36:52] (03CR) 10CI reject: [V: 04-1] Enable CZ online banking for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904386 (https://phabricator.wikimedia.org/T328717) (owner: 10Ejegg) [21:36:54] (03CR) 10CI reject: [V: 04-1] Make Adyen setup function async [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908318 (owner: 10Ejegg) [21:37:01] (03CR) 10CI reject: [V: 04-1] Use constant name for Adyen component container [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908307 (owner: 10Ejegg) [21:37:42] no p ejegg, I had to go do dishes. I'd start reviewing while you fix those [21:38:58] thanks! [21:43:00] (03PS5) 10Ejegg: Make Adyen setup function async [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908318 [21:46:07] (03PS14) 10Eileen: Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) [21:47:57] ejegg: if you have already pulled those patches you might want to get that updated import templates one (assuming tests pass) - it just adds transation ID as a field in the sample csv [21:48:20] ok, thanks eileen [21:48:33] actually since I'm there I'll fix that commit issue I mentioned [21:49:22] (03PS2) 10Eileen: Add import handling for individual look up and soft credits. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908015 (https://phabricator.wikimedia.org/T303986) [21:51:46] (03PS15) 10Eileen: Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) [21:52:18] (03PS9) 10Eileen: Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) [21:52:20] (03PS4) 10Eileen: Add check for the contribution already existing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908050 (https://phabricator.wikimedia.org/T303986) [21:52:22] (03PS2) 10Eileen: Fix another place with trxn_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908352 [21:52:45] (03PS8) 10Ejegg: Enable CZ online banking for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904386 (https://phabricator.wikimedia.org/T328717) [21:52:47] (03PS5) 10Ejegg: Use constant name for Adyen component container [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908307 [21:54:44] ejegg: I seem to be getting an invalid token error with GooglePay on the new Adyen [21:55:13] oh dang, let me try [21:55:52] shoot, me too [21:56:06] let me try with the older script and see if that works [21:59:26] ok, with the old Adyen JS (and the same DonationInterface patches) the payment completes [21:59:30] darn [22:00:22] looks like the token is returning as a serialized object in this new Adyen [22:00:32] I'll switch to see if its same on the old [22:00:52] ah ok, nice find [22:02:36] (03PS1) 10Eileen: Add new table to exisiting installs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908360 (https://phabricator.wikimedia.org/T334532) [22:03:17] (03CR) 10Eileen: "It occurred to me we need a upgrade script too - something like https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/908360" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [22:04:08] (03PS2) 10Eileen: Add new table to exisiting installs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908360 (https://phabricator.wikimedia.org/T334532) [22:07:16] damilare: it does look like a big blob in the old script too [22:07:39] yeah I just saw that [22:12:54] I wonder where that could be from, is there any other config change we need to make? [22:13:27] I'm going to try changing the rest-base-url in the smashpig config to hit the /v68 endpoint [22:14:24] I just noticed this in the changelog for the Javascript: https://docs.adyen.com/online-payments/release-notes [22:14:29] This release requires Checkout API v68 or later. [22:17:03] oh ok [22:17:22] damn, that didn't do it either [22:17:35] well, this is definitely a bigger task than we'd hoped [22:18:04] I don't want to keep you up any later damilare [22:18:40] I'll try a bit longer, but we'll probably have to tell Evelyn that we can't do it this week [22:18:54] sure thanks, was hoping to get this across the line tonight. But good thing we caught this early. [22:19:01] sounds good