[08:07:09] 10fundraising-tech-ops, 10Infrastructure Security, 10Infrastructure-Foundations, 10SRE-Access-Requests: As an FR-Tech SRE, we want to be able to designate a host for decommissioning - https://phabricator.wikimedia.org/T334154 (10Clement_Goubert) [08:14:50] 10fundraising-tech-ops, 10Infrastructure Security, 10Infrastructure-Foundations, 10SRE, 10SRE-Access-Requests: As an FR-Tech SRE, we want to be able to designate a host for decommissioning - https://phabricator.wikimedia.org/T334154 (10Clement_Goubert) [11:23:03] 10Fundraising-Backlog: Recurring Donations in India failed during the Banner Pre-test - https://phabricator.wikimedia.org/T334835 (10RKumar_WMF) [16:54:16] (03PS1) 10Ejegg: Fix end-of-run message for pending resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909316 [17:51:17] fr-tech it's a good day to update Google Chrome if you use it: https://www.theregister.com/2023/04/17/chrome_emergency_patch/ [18:12:45] that's concerning ejegg [20:05:35] (03PS12) 10Wfan: Add cc as payment_method default in general for old gateway link that contains no payment_method. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/876044 (https://phabricator.wikimedia.org/T140269) [20:06:48] (03CR) 10CI reject: [V: 04-1] Add cc as payment_method default in general for old gateway link that contains no payment_method. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/876044 (https://phabricator.wikimedia.org/T140269) (owner: 10Wfan) [21:05:09] oh fun, the apple pay servers are getting java.lang.OutOfMemoryError [21:06:22] wfan I think we could keep this ticket open: https://phabricator.wikimedia.org/T260725 [21:06:26] I'm actively working on it [21:07:01] and I think the one you marked it as a duplicate of is more the front-end [21:07:04] oh ok I will mark as related sub ticket then [21:16:11] (03PS3) 10Eileen: Add import handling for individual look up and soft credits. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908015 (https://phabricator.wikimedia.org/T303986) [21:16:50] ejegg: I got an email from Melanie asking when she can start testing the import - they are showing conflicts now but I think they are ok.. https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/908015 [21:16:56] as in that one rebased fine [21:17:18] ah - I see you have done some review - checking [21:17:25] (still catching up with incoming) [21:22:46] oh I think it's actually fine, nothing serious in those comments [21:22:57] sorry, I'll switch back to that review [21:25:43] ejegg: ok - I'm checking - I don't think those changes you suggest will conflict too much with others later in the chain but just looking to see [23:06:38] eileen: should I wait for another PS then? [23:11:10] ejegg: sorry I thought you were looking at the patches so I switched to reviewing Damis [23:11:23] I can make a change now or we can do a cleanup pass at the end? [23:17:30] (I'm just testing the new table from Dami - it ran ok on staging & fields look good so am close to pressing go [23:25:00] (03CR) 10Eileen: [C: 03+2] "This installed correctly in a new dev build and via upgrade on staging." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [23:25:34] ok eileen, I'll keep going on the current patches then [23:26:24] thanks ejegg - then at the end I can address your readability comments - or you can push up a patch that enacts them & I can +2 them [23:26:38] btw - I just plus 2d the new table :-) [23:26:56] (03CR) 10Ejegg: [C: 03+2] Add import handling for individual look up and soft credits. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908015 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [23:27:43] oh boy! nice [23:27:49] oh i could rebase again then [23:28:11] lol - yeah it hasn;t merged yet [23:28:21] it annoys me that gerrit declares conflicts when there aren't any [23:28:29] ahh, it's saying there's a conflict in wmf_civicrm.php [23:28:40] ok ok - so there really is one this time [23:28:40] when I try to rebase over damilare's patch [23:29:14] oh because of the civix upgrade? [23:29:25] huh, weird [23:29:31] no, that was merged a while back [23:29:37] is that the patch I +2d? I don't see that fiel in it -https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/908241/16 [23:29:57] right i don't either [23:30:37] it's in this one - git fetch https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm refs/changes/84/908584/2 && git cherry-pick FETCH_HEAD [23:30:45] but I am about to review that [23:31:11] I'm pasting this sha in to the rebase dialog: f5bb92ad3044676723525c11657c087d54c25a06 [23:31:17] from the one you just C+2ed [23:31:46] and it's telling me there's a wmf_civicrm.php conflict.... [23:31:49] huh [23:32:09] well it's almost through gate+submit [23:32:14] let's see what it says after that [23:32:58] yeah - then you can just rebase on master [23:36:29] maybe we could set the default log threshold to 'alert' in tests [23:37:00] for the 'wmf' output channel [23:37:50] (03Merged) 10jenkins-bot: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908241 (https://phabricator.wikimedia.org/T334532) (owner: 10Damilare Adedoyin) [23:38:29] ejegg: yeah or perhaps just on known warning tests [23:39:46] (03PS3) 10Eileen: CT-to-Civi-Phase 1 - exclude new contribution tracking entity from logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908584 (https://phabricator.wikimedia.org/T334533) (owner: 10Damilare Adedoyin) [23:40:13] so that rebase worked [23:43:02] (03PS4) 10Ejegg: Add import handling for individual look up and soft credits. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908015 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [23:43:06] (03CR) 10Ejegg: [C: 03+2] Add import handling for individual look up and soft credits. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908015 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [23:43:11] (03CR) 10Ejegg: [C: 03+2] Add import templates (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [23:43:21] (03PS16) 10Ejegg: Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [23:43:34] (03CR) 10Ejegg: [C: 03+2] Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [23:54:46] (03Merged) 10jenkins-bot: Add import handling for individual look up and soft credits. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908015 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [23:55:17] (03Merged) 10jenkins-bot: Add import templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [23:56:19] (03CR) 10Eileen: Add import templates (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/905147 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen)