[00:00:38] (03PS1) 10Eileen: Exclude contribution tracking from log tables [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909400 (https://phabricator.wikimedia.org/T334533) [00:02:41] (03CR) 10Eileen: [C: 04-1] "I tested & this didn't work - I put up https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/909400 which did work in my tested & I" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908584 (https://phabricator.wikimedia.org/T334533) (owner: 10Damilare Adedoyin) [00:03:24] looking eileen [00:03:24] ejegg: I think we need to merge this one asap https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/909400 - to ensure we don't deploy the new table without it [00:09:23] eileen: that one looks good, i just realized we may want indexes on entity_id for some of the custom data tables [00:09:39] (03PS2) 10Ejegg: Exclude contribution tracking from log tables [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909400 (https://phabricator.wikimedia.org/T334533) (owner: 10Eileen) [00:09:46] (03CR) 10Ejegg: [C: 03+2] "looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909400 (https://phabricator.wikimedia.org/T334533) (owner: 10Eileen) [00:10:02] it seems like we're indexing on contact_id which makes sense [00:10:04] oh right - but I guess that index need hasn't reared it's head as yet [00:10:26] k, I guess no need to bloat it right now [00:10:40] if it's not slowing down the contact changelog [00:14:39] ejegg: yeah I think the change log might be a bit sluggish - but perhaps mostly used by us through mysql [00:14:47] now that I'm looking at tables I'm curious how we're going to conditionally omit that one column [00:15:30] do we need to disable the built-in logging for civicrm_activity and manage the trigger entirely by ourselves in the triggers hook? [00:18:10] (03CR) 10Eileen: "OK ejegg commit f25cb7cc1b5a97467b22aea064cbd against process control pushed - that needs review & then I can deploy & this is unblocked" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908009 (https://phabricator.wikimedia.org/T334544) (owner: 10Eileen) [00:18:43] ejegg: yeah possibly - I haven't dug into it yet - I hope not [00:19:41] it's this hook wmf_civicrm_civicrm_triggerInfo [00:19:48] yep [00:20:06] looks like logging also uses triggerInfo to add its own triggers [00:20:27] so if we can somehow make sure our code gets fired after, we might be able to alter the ones added by logging [00:21:20] yeah - I think we can just do a tweak to the sql in Civi\WMFHooks\TriggerHook class [00:21:28] I'll note that on the phab [00:22:47] (03Merged) 10jenkins-bot: Exclude contribution tracking from log tables [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909400 (https://phabricator.wikimedia.org/T334533) (owner: 10Eileen) [00:23:06] (03PS3) 10Ejegg: Remove references to queue2civicrm_log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908009 (https://phabricator.wikimedia.org/T334544) (owner: 10Eileen) [00:23:19] (03CR) 10Ejegg: [C: 03+2] "Sayonara!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908009 (https://phabricator.wikimedia.org/T334544) (owner: 10Eileen) [00:24:58] that process-control change looks fine [00:25:06] yay [00:25:11] I'll push it now [00:26:12] !log config revision changed from 7da418a4 to f25cb7cc [00:26:15] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:35:22] (03Merged) 10jenkins-bot: Remove references to queue2civicrm_log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908009 (https://phabricator.wikimedia.org/T334544) (owner: 10Eileen) [00:38:32] (03CR) 10Ejegg: CT-to-Civi-Phase 1 - populate the civi fields (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908626 (https://phabricator.wikimedia.org/T334534) (owner: 10Damilare Adedoyin) [00:39:34] (03Abandoned) 10Eileen: Add new table to exisiting installs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908360 (https://phabricator.wikimedia.org/T334532) (owner: 10Eileen) [00:39:49] (03PS10) 10Eileen: Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) [00:40:09] (03PS5) 10Eileen: Add check for the contribution already existing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908050 (https://phabricator.wikimedia.org/T303986) [00:40:18] (03PS3) 10Eileen: Fix another place with trxn_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908352 [00:40:48] ejegg: there are still 2 import patches (+1 cleanup) - I can keep looking at Dami's if you can look at those ones? [00:45:59] yep yep, sure thing eileen [00:59:08] (03CR) 10Ejegg: [C: 03+2] Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [01:07:36] (03CR) 10Ejegg: "Looks good, just a couple typehints could be updated" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908050 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [01:11:16] (03Merged) 10jenkins-bot: Further import updates gateway_trxn_id & no_thank_you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908013 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [01:13:48] (03PS6) 10Eileen: Add check for the contribution already existing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908050 (https://phabricator.wikimedia.org/T303986) [01:14:20] (03CR) 10Eileen: Add check for the contribution already existing (033 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908050 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [01:14:33] (03PS4) 10Eileen: Fix another place with trxn_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908352 [01:15:07] (03CR) 10Ejegg: [C: 03+2] Add check for the contribution already existing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908050 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [01:15:16] (03CR) 10Ejegg: [C: 03+2] Fix another place with trxn_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908352 (owner: 10Eileen) [01:15:54] yay ejegg - I will start deploying - there is one last change but it's just fixing a typo in a test [01:16:09] oh you did that one [01:16:25] heh, yeah, that was easy enough [01:16:30] thanks for all that work! [01:16:50] cool - will be nice to get Melanie testing [01:27:19] (03Merged) 10jenkins-bot: Add check for the contribution already existing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908050 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [01:27:51] (03Merged) 10jenkins-bot: Fix another place with trxn_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908352 (owner: 10Eileen) [01:32:13] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/909404 [01:34:34] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/909404 (owner: 10Eileen) [01:35:32] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/909404 (owner: 10Eileen) [01:38:41] !log civicrm upgraded from cd0f886d to 0b8e303d [01:38:44] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:28:08] ejegg: I've just spotted that payments_form isn't in the new table [02:28:08] - was that something we talked about breaking down & storing differently - or just overlooked. [02:28:08] eg. data - payments_form: paypal_ec.JimmyQuote [02:29:38] oh shoot, I guess we could split that out [02:31:01] yeah, we defeintely want to have the gateway on its own if possible [02:31:28] So unfortunately there are some conditional parameters [02:31:31] like the variant [02:32:00] which will make populating it a bit annoying in SQL [02:34:54] so what would the fields be? gateway & form? [02:35:06] & what are the conditional params [02:35:11] gateway, appeal, and variant [02:35:20] ingenico.JimmyQuote has gateway and appeal [02:35:36] adyen.v=ja_01A has gateway and variant [02:36:29] and we don't seem to have any with both variant and appeal :( [02:37:02] ok - but they are separate things - I'm gonna spin up a patch adding them [02:37:19] thanks! [02:37:22] they are all just text & maybe not indexed? [02:37:36] gateway would be nice to have indexed [02:37:58] gateway cardinality would be too low for indexing to work well I think [02:38:03] though it should be a small number of values [02:38:13] ah right, thanks! [02:38:21] ok - I'll just put in the fields [02:39:46] is it form_variant? [02:40:00] (I read variant & think variant of what) [02:40:48] also is JimmyQuote an appeal or a variant [02:41:04] hmm, I guess it could be, but the querystring parameter is always just passed around as 'variant' [02:41:34] let me just look at the code that populates that again [02:43:04] ok, yep, it's just those three things [02:43:46] not passing through processor_form, which is a way to a/b test different processor-hosted iframes (and only relevant for ingenico at this point so unlikely to be used much) [02:44:07] the historical data will have different values, but I guess we can dump those [02:44:30] once upon a time any variant form was a different hardcoded HTML template with a codename [02:44:38] and the gateway form chooser chose between those [02:45:04] anyway, the old c_t rows will have those old form codenames in payments_form [02:45:24] eileen: JimmyQuote is an appeal [02:45:55] regrettably only distinguishable by not having the v= prefix... [02:46:43] the 'appeal' is the text to the left of the input boxes (on desktop-size screens) [02:47:04] and a 'variant' generally changes something about the input boxes or their labels [02:47:12] we might need some explainer notes on https://phabricator.wikimedia.org/T334534 [02:48:32] (03PS1) 10Eileen: Re-add payments_form field, as 3 separate fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909405 (https://phabricator.wikimedia.org/T334532) [02:49:03] ejegg: I've pushed up to add those fields - still thinking about beefing up the comments [02:49:15] I mean I could crib what you wrote above? [02:49:45] be my guest! [02:50:14] I'm going to make a new ticket [02:50:32] to start sending and consuming the broken out values instead of the concatenated ones [02:52:58] (03PS2) 10Eileen: Re-add payments_form field, as 3 separate fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909405 (https://phabricator.wikimedia.org/T334532) [02:53:08] ejegg: ok - your words are now in there [02:54:54] thanks! [02:55:13] did you want to deploy that now-ish too? It's getting pretty late here [02:56:19] ok, that's not much to review actually [02:57:07] gateway could be shorter - let me see what we use in smashpig [02:58:06] ejegg: yeah - if you can review all good - but also ok to leave for Dami if you are done for the day - but yeah I did wonder about field lengths too... [02:58:45] oh dang, we're using 255 for SmashPig - that's way bigger than needed [02:59:52] I'd say 32 for gateway and 64 for the other two should be plenty [03:00:10] ok cool - will change [03:02:31] (03CR) 10Eileen: "This looks pretty cool." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) (owner: 10Damilare Adedoyin) [03:03:28] (03PS3) 10Eileen: Re-add payments_form field, as 3 separate fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909405 (https://phabricator.wikimedia.org/T334532) [03:03:40] ok done [03:05:24] (03CR) 10Ejegg: [C: 03+2] Re-add payments_form field, as 3 separate fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909405 (https://phabricator.wikimedia.org/T334532) (owner: 10Eileen) [03:05:28] looks good! [03:05:33] thanks ejegg [03:06:04] I guess the tricky part is gonna be understanding the rules around populating that [03:08:19] yep, for sure [03:08:22] (03PS6) 10Ejegg: createPaymentSession for Ingenico HostedCheckoutProvider [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/908010 (https://phabricator.wikimedia.org/T260725) [03:08:24] (03PS1) 10Ejegg: Add new properties to PaymentDetailResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909427 (https://phabricator.wikimedia.org/T260725) [03:08:26] (03PS1) 10Ejegg: Deprecate old getHostedPaymentStatus call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909428 (https://phabricator.wikimedia.org/T260725) [03:08:28] (03PS1) 10Ejegg: Map amount, currency, submethod in Ingenico status lookup [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909429 (https://phabricator.wikimedia.org/T260725) [03:08:30] (03PS1) 10Ejegg: Split out card-specific property mapping [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909430 (https://phabricator.wikimedia.org/T260725) [03:08:32] (03PS1) 10Ejegg: Add amount and currency to Paypal detail response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909431 [03:09:01] I'll just leave those there... [03:09:13] (03CR) 10CI reject: [V: 04-1] Map amount, currency, submethod in Ingenico status lookup [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909429 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [03:09:18] (03CR) 10CI reject: [V: 04-1] Split out card-specific property mapping [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909430 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [03:09:22] (03CR) 10CI reject: [V: 04-1] Add amount and currency to Paypal detail response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909431 (owner: 10Ejegg) [03:13:45] (03PS2) 10Ejegg: Map amount, currency, submethod in Ingenico status lookup [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909429 (https://phabricator.wikimedia.org/T260725) [03:14:17] (03CR) 10CI reject: [V: 04-1] Map amount, currency, submethod in Ingenico status lookup [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909429 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [03:17:01] (03PS3) 10Ejegg: Map amount, currency, submethod in Ingenico status lookup [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909429 (https://phabricator.wikimedia.org/T260725) [03:17:03] (03PS2) 10Ejegg: Split out card-specific property mapping [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909430 (https://phabricator.wikimedia.org/T260725) [03:17:05] (03PS2) 10Ejegg: Add amount and currency to Paypal detail response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909431 [03:17:13] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/909432 [03:17:22] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/909432 (owner: 10Eileen) [03:18:36] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/909432 (owner: 10Eileen) [03:24:17] (03PS4) 10Ejegg: Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/907954 [03:24:23] (03CR) 10Ejegg: [V: 03+2] Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/907954 (owner: 10Ejegg) [03:24:38] (03PS2) 10Ejegg: Fix bad constant in PayPal error mapper [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/907518 [03:24:48] (03PS3) 10Ejegg: Fix UtcDate FIXME, add return type [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/907516 [03:25:23] (03CR) 10CI reject: [V: 04-1] Fix UtcDate FIXME, add return type [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/907516 (owner: 10Ejegg) [03:28:05] (03PS4) 10Ejegg: Fix UtcDate FIXME, add return type [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/907516 [03:30:32] !log civicrm upgraded from 0b8e303d to dab8912d [03:30:35] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [05:26:01] (03CR) 10Eileen: "I played around with this quite a bit & got the followin sql working on staging" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908626 (https://phabricator.wikimedia.org/T334534) (owner: 10Damilare Adedoyin) [12:19:56] 10Fundraising-Backlog, 10FR-dlocal: Set error for Dlocal unsupported card types in India - https://phabricator.wikimedia.org/T334937 (10Damilare) [12:45:10] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: dlocal recurring issue: contribution_id is not being written to the contribution_tracking record following CiviCRM import - https://phabricator.wikimedia.org/T334942 (10jgleeson) [12:45:16] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: dlocal recurring issue: contribution_id is not being written to the contribution_tracking record following CiviCRM import - https://phabricator.wikimedia.org/T334942 (10jgleeson) a:03jgleeson [12:54:55] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q1:rack/setup/install frbast1002, frmon1002, frpig1002 - https://phabricator.wikimedia.org/T319460 (10Papaul) a:05Cmjohnson→03Jgreen @Jgreen All firmware up to date on servers. All yours [12:58:23] 10Fundraising-Backlog: Dlocal pending transaction resolver status call returning invalid credentials - https://phabricator.wikimedia.org/T334943 (10Damilare) [13:16:49] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: dLocal one-hour test failmail: "Merchant has no authorization to use this API" / "Token not found or inactive" - https://phabricator.wikimedia.org/T334945 (10jgleeson) [13:16:54] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: dlocal recurring issue: contribution_id is not being written to the contribution_tracking record following CiviCRM import - https://phabricator.wikimedia.org/T334942 (10jgleeson) [13:37:22] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1009:down, kafka-jumbo1008:down, kafka-jumbo1006:down https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_kafkatee [13:42:30] RECOVERY - check_kafkatee on frban1001 is OK: OK: brokers:9 topics:1 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_kafkatee [14:13:05] 10Fundraising-Backlog: Change language re phone number field for UPI - https://phabricator.wikimedia.org/T334952 (10EMartin) [14:26:29] Don't know if anyone else on the team knows the answer to this: Hello there I can't make Civi fortnightly tomorrow but had a Civi question related to Civimail [14:26:29] @emcnaughton [14:26:29] , we can currently send only 700 emails at a time through the Civimail function, is there a way to increase this limit? [14:40:25] anilk: I'm pretty sure we can adjust that setting [14:40:34] do they say how many they want? [14:44:32] Thanks ejegg - Rosie said 2000 [14:44:38] Also doesn't sound like a huge rush [14:51:02] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog, 10FR-dlocal: Dlocal pending transaction resolver status call returning invalid credentials - https://phabricator.wikimedia.org/T334943 (10Ejegg) [15:48:50] hi fr-tech, reminder that the Czech Republic banner campaign is starting in 10 minutes. [15:49:11] hi haley_, thanks for the heads up [16:13:58] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog, 10FR-dlocal: Dlocal pending transaction resolver status call returning invalid credentials - https://phabricator.wikimedia.org/T334943 (10Ejegg) I added the civi box's IP address to the allow list in the merchant console, which might fix thi... [16:18:34] 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint Highway to Hello World, 10Fundraising Sprint Juggalology 2022, 10Fundraising Sprint Kermit hopping principle, and 6 others: Currency code/currency symbol in Thank You emails received by Donors issues - https://phabricator.wikimedia.org/T309349 (10AM... [16:29:20] 10Fundraising-Backlog: Civi\Api4\Service\Spec\Provider\MappingCreationSpecProvider' not found in CachedCiviContainer - https://phabricator.wikimedia.org/T334966 (10AnnWF) [16:30:51] (03CR) 10Damilare Adedoyin: [C: 03+1] "Looks good thanks for adding those test as well. I added a suggestion to handle the API exceptions for better UX." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/908010 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [16:31:53] (03CR) 10Damilare Adedoyin: [C: 03+2] Add new properties to PaymentDetailResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909427 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [16:36:08] (03CR) 10Damilare Adedoyin: [C: 03+1] "Added a suggestion to handle ApiExceptions similar to the last reviewed patch" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909428 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [16:55:40] (03PS5) 10Damilare Adedoyin: CT-to-Civi-Phase 1 - populate the civi fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908626 (https://phabricator.wikimedia.org/T334534) [16:55:55] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 - populate the civi fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908626 (https://phabricator.wikimedia.org/T334534) (owner: 10Damilare Adedoyin) [16:58:22] (03Abandoned) 10Damilare Adedoyin: CT-to-Civi-Phase 1 - exclude new contribution tracking entity from logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908584 (https://phabricator.wikimedia.org/T334533) (owner: 10Damilare Adedoyin) [16:58:34] 10Fundraising-Backlog: We are not turn on the CLP in IN - https://phabricator.wikimedia.org/T334967 (10AnnWF) [17:24:29] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: We are not turn on the CLP in IN - https://phabricator.wikimedia.org/T334967 (10AnnWF) [17:24:54] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Dlocal donor have mismatch donation info CLP in IN - https://phabricator.wikimedia.org/T334967 (10AnnWF) [17:27:28] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog, 10Patch-For-Review: CT-to-Civi-Phase 1 Create a view to replace the drupal table - https://phabricator.wikimedia.org/T334535 (10Ejegg) [17:51:43] 10fundraising-tech-ops, 10User-greg: Renew FR-Tech nessus license - https://phabricator.wikimedia.org/T332097 (10Dwisehaupt) 05Open→03Resolved License has been purchased. Account created for my address. Activation code obtained from the nessus community site. Pulled the latest software update and applied t... [18:10:04] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: dlocal recurring issue: contribution_id is not being written to the contribution_tracking record following CiviCRM import - https://phabricator.wikimedia.org/T334942 (10XenoRyet) p:05Triage→03High [18:17:00] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q1:rack/setup/install frbast1002, frmon1002, frpig1002 - https://phabricator.wikimedia.org/T319460 (10Jgreen) [18:20:19] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q1:rack/setup/install frbast1002, frmon1002, frpig1002 - https://phabricator.wikimedia.org/T319460 (10Jgreen) [18:23:56] nice. just found an album called Booger Bear: https://listen.tidal.com/album/4268048 [18:24:14] pretty funky [18:24:52] ok, back to testing Adyen JS 5.39 [18:25:56] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: No images loaded for Payment Submethods in Brazil cash method (Boletos) - https://phabricator.wikimedia.org/T334737 (10AnnWF) a:03AnnWF [18:36:30] (03CR) 10Damilare Adedoyin: [C: 03+2] Enable CZ online banking for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904386 (https://phabricator.wikimedia.org/T328717) (owner: 10Ejegg) [18:37:39] (03PS1) 10Wfan: Add bank logo for dlocal boleto and pix [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/909424 (https://phabricator.wikimedia.org/T334737) [18:38:41] (03CR) 10CI reject: [V: 04-1] Add bank logo for dlocal boleto and pix [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/909424 (https://phabricator.wikimedia.org/T334737) (owner: 10Wfan) [18:38:54] (03CR) 10Damilare Adedoyin: "thanks ejegg and eileen for the CR, I pushed an update but I'm yet to test it. Still working on my setup." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908626 (https://phabricator.wikimedia.org/T334534) (owner: 10Damilare Adedoyin) [18:40:07] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: dlocal recurring issue: contribution_id is not being written to the contribution_tracking record following CiviCRM import - https://phabricator.wikimedia.org/T334942 (10jgleeson) [18:41:12] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: dlocal recurring issue: contribution_id is not being written to the contribution_tracking record following CiviCRM import - https://phabricator.wikimedia.org/T334942 (10jgleeson) Examples: CID: 59478704 and 59478705 [19:22:31] (03PS1) 10Jgleeson: Add upi-specific check to civicrm import ct update code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909742 (https://phabricator.wikimedia.org/T334942) [19:34:56] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: dlocal recurring issue: contribution_id is not being written to the contribution_tracking record following CiviCRM import - https://phabricator.wikimedia.org/T334942 (10jgleeson) We've found the issue and have a fix in... [19:40:10] 10Fundraising Sprint Fish HEAD^, 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog, 10FR-dlocal: DLocal Audit - Test with new integration - https://phabricator.wikimedia.org/T324347 (10Cstone) a:03Cstone [19:40:22] 10Fundraising-Backlog: dlocal refund could not find parent error - https://phabricator.wikimedia.org/T334989 (10AnnWF) [19:44:56] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-tangent remove queue2civicrm_log tables & writing to them 2 - https://phabricator.wikimedia.org/T334544 (10Eileenmcnaughton) I just moved this to done but the last step is to drop the table ` queue2civicrm_log` [19:45:23] 10Fundraising-Backlog, 10FR-Smashpig, 10Recurring-Donations: Stop hardcoding payment_method=cc in SmashPig recurring donation messages - https://phabricator.wikimedia.org/T334991 (10Ejegg) [19:47:06] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: PaymentsWiki Error: ResizeObserver loop limit exceeded - https://phabricator.wikimedia.org/T332693 (10Ejegg) We could stop logging these, maybe by sending a list of error patterns to ignore in ext.donationInterface.errorLog.js [19:51:12] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Recent donations not saved after merging of two CIDs - https://phabricator.wikimedia.org/T326583 (10Eileenmcnaughton) We could probably do a patch to wrap each dedupe in a transaction - it would need upstreaming so maybe a phab on th... [19:54:03] 10Fundraising Sprint Highway to Hello World, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: "Order id is duplicated" error from dlocal - https://phabricator.wikimedia.org/T334905 (10XenoRyet) [19:55:59] 10Fundraising-Backlog, 10FR-dlocal: dlocal refund could not find parent error - https://phabricator.wikimedia.org/T334989 (10Cstone) [19:58:59] 10Fundraising-Backlog, 10FR-dlocal: Change language re phone number field for UPI - https://phabricator.wikimedia.org/T334952 (10XenoRyet) [19:59:21] 10Fundraising-Backlog, 10FR-Smashpig, 10Recurring-Donations: Stop hardcoding payment_method=cc in SmashPig recurring donation messages - https://phabricator.wikimedia.org/T334991 (10AnnWF) [20:02:45] 10Fundraising-Backlog, 10FR-dlocal: Set error for Dlocal unsupported card types in India - https://phabricator.wikimedia.org/T334937 (10AnnWF) https://docs.dlocal.com/docs/india#cards seems support Amex, could just need to map the submethod? [20:04:50] (03PS1) 10Ejegg: Link UPI recurring to contribution_tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909748 (https://phabricator.wikimedia.org/T334942) [20:05:20] ok jgleeson I think that should do the trick ^^^ [20:08:20] thanks ejegg and thanks for fishing out where the problem was on the the call earlier [20:08:41] just gonna relocate and will review [20:08:50] sure thing ... and sorry I created the problem in the first place :P [20:09:02] how to de-complexify??? [20:11:01] (03PS5) 10Damilare Adedoyin: CT-to-Civi-Phase 1 Create a view to replace the drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) [20:11:21] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 Create a view to replace the drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) (owner: 10Damilare Adedoyin) [20:12:29] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: debmaster and debvisa not found in dlocal submethod config, and mc-debit not found for ingenico - https://phabricator.wikimedia.org/T334769 (10AnnWF) [20:14:25] (03CR) 10Ejegg: "Want to just add a code comment to the effect of "The UpiDonationsQueueConsumer creates the contribution_recur record for UPI initial recu" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909742 (https://phabricator.wikimedia.org/T334942) (owner: 10Jgleeson) [20:24:23] (03PS1) 10Ejegg: Dlocal: record capture ID not auth ID [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/909750 (https://phabricator.wikimedia.org/T334989) [20:24:52] (03PS2) 10Ejegg: Dlocal: record capture ID not auth ID [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/909750 (https://phabricator.wikimedia.org/T334989) [20:25:57] (03CR) 10CI reject: [V: 04-1] Dlocal: record capture ID not auth ID [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/909750 (https://phabricator.wikimedia.org/T334989) (owner: 10Ejegg) [20:26:51] weird failure [20:33:19] (03PS3) 10Wfan: Add missing submethods for gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908868 (https://phabricator.wikimedia.org/T334769) [20:34:18] (03CR) 10CI reject: [V: 04-1] Add missing submethods for gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908868 (https://phabricator.wikimedia.org/T334769) (owner: 10Wfan) [20:36:52] (03PS4) 10Wfan: Add missing submethods for gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908868 (https://phabricator.wikimedia.org/T334769) [20:37:51] (03CR) 10CI reject: [V: 04-1] Add missing submethods for gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908868 (https://phabricator.wikimedia.org/T334769) (owner: 10Wfan) [20:41:32] (03CR) 10Wfan: [C: 03+1] "LGMT! do we want to update the other patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/909742 first, then merge this late" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909748 (https://phabricator.wikimedia.org/T334942) (owner: 10Ejegg) [20:45:24] thanks for the review ejegg. will add that comment along with a slight refactor to break it out a bit more [20:55:22] ok, thanks! [20:56:46] (03PS6) 10Damilare Adedoyin: CT-to-Civi-Phase 1 - populate the civi fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908626 (https://phabricator.wikimedia.org/T334534) [20:57:02] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 - populate the civi fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908626 (https://phabricator.wikimedia.org/T334534) (owner: 10Damilare Adedoyin) [20:58:26] (03PS6) 10Damilare Adedoyin: CT-to-Civi-Phase 1 Create a view to replace the drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) [20:58:45] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 Create a view to replace the drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) (owner: 10Damilare Adedoyin) [21:01:50] (03PS7) 10Damilare Adedoyin: CT-to-Civi-Phase 1 Create a view to replace the drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) [21:02:04] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 Create a view to replace the drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) (owner: 10Damilare Adedoyin) [21:02:45] (03PS7) 10Damilare Adedoyin: CT-to-Civi-Phase 1 - populate the civi fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908626 (https://phabricator.wikimedia.org/T334534) [21:03:05] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 - populate the civi fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908626 (https://phabricator.wikimedia.org/T334534) (owner: 10Damilare Adedoyin) [21:10:37] (03PS5) 10Wfan: Add missing submethods for gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908868 (https://phabricator.wikimedia.org/T334769) [21:10:39] (03PS8) 10Damilare Adedoyin: CT-to-Civi-Phase 1 - populate the civi fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908626 (https://phabricator.wikimedia.org/T334534) [21:10:47] (03PS2) 10Wfan: Add bank logo for dlocal boleto and pix [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/909424 (https://phabricator.wikimedia.org/T334737) [21:11:37] (03PS8) 10Damilare Adedoyin: CT-to-Civi-Phase 1 Create a view to replace the drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) [21:11:41] (03CR) 10CI reject: [V: 04-1] Add missing submethods for gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908868 (https://phabricator.wikimedia.org/T334769) (owner: 10Wfan) [21:12:10] (03CR) 10CI reject: [V: 04-1] Add bank logo for dlocal boleto and pix [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/909424 (https://phabricator.wikimedia.org/T334737) (owner: 10Wfan) [21:13:08] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 - populate the civi fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908626 (https://phabricator.wikimedia.org/T334534) (owner: 10Damilare Adedoyin) [21:14:18] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 Create a view to replace the drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) (owner: 10Damilare Adedoyin) [21:16:24] (03PS9) 10Damilare Adedoyin: CT-to-Civi-Phase 1 - populate the civi fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908626 (https://phabricator.wikimedia.org/T334534) [21:16:49] 10Fundraising-Backlog, 10FR-Adyen: Adyen Checkout: Handle network error when loading Adyen JS - https://phabricator.wikimedia.org/T289525 (10Ejegg) 05Open→03Resolved a:03Ejegg We did this in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/881050 [21:17:53] 10Fundraising-Backlog, 10FR-Adyen: EPIC: Monthly convert for Adyen - https://phabricator.wikimedia.org/T290338 (10Ejegg) 05Open→03Resolved a:03Ejegg All subtasks are closed and we're using this in production [21:21:13] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: Upgrade to newer version of Adyen JS SDK - https://phabricator.wikimedia.org/T334999 (10Ejegg) [21:21:22] damilare: I think the bit in the upgrader for your update should come out & then I can work today on running the sql via drush & maybe even kick that off [21:21:51] ie I think we can't use upgrade to populate the table cos we can't manage that via cron [21:22:22] XenoRyet and anilk I split that JS upgrade task out from the CZ online banking because we'll want it even if we don't get CZ online banking this year, and because it's been taking a lot of my time today [21:22:33] ohh ok so you think I should pull that upgrade script out eileen from the patch, right? [21:22:36] T334999 [21:22:37] T334999: Upgrade to newer version of Adyen JS SDK - https://phabricator.wikimedia.org/T334999 [21:22:54] 10-4 [21:23:00] damilare: yep - I think we have to run via drush - that can be my today-job [21:23:13] 10Fundraising Sprint Fish HEAD^, 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog, 10FR-dlocal: DLocal Audit - Test with new integration - https://phabricator.wikimedia.org/T324347 (10Cstone) So it looks like dlocal is still sending their id (Refere... [21:23:25] to take what you have & get it running by drush [21:23:31] & then we will have kicked that off! [21:23:38] (03PS9) 10Damilare Adedoyin: CT-to-Civi-Phase 1 Create a view to replace the drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) [21:24:43] eileen: would it make sense to fill some new data for starters rather than going from the oldest rows? [21:25:03] the newer data would be more interesting and also have better formats for those concatenated columns [21:25:39] ejegg: yeah - check https://phabricator.wikimedia.org/T334534#8788140 [21:25:51] the stuff in there on staging starts from 'staging-new' [21:26:01] oh cool [21:26:15] ORDER BY ct.id DESC [21:26:16] LIMIT 10000 [21:26:19] sounds good [21:26:20] yep [21:26:20] (03PS10) 10Damilare Adedoyin: CT-to-Civi-Phase 1 - populate the civi fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908626 (https://phabricator.wikimedia.org/T334534) [21:26:26] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 Create a view to replace the drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) (owner: 10Damilare Adedoyin) [21:26:55] damilare: so how about I work on getting the population going underway & maybe getting your view out while you sleep & then hopefully tomorrow you can start playing with the UI aspects? [21:27:50] (03PS11) 10Damilare Adedoyin: CT-to-Civi-Phase 1 - populate the civi fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908626 (https://phabricator.wikimedia.org/T334534) [21:27:54] & I'll try to confirm the status of embedding search kits in the quick form pages in pop-up mode [21:29:56] Ok sure, I think that last patch should fix the merge conflicts. Ok certainly thanks, sorry I wasn't able to cover much ground today. I have my setup in a fairly stable state and I should be able to get to the UI stuff tomorrow [21:30:19] (03PS10) 10Damilare Adedoyin: CT-to-Civi-Phase 1 Create a view to replace the drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) [21:30:25] damilare: that's cool - I think you have been flying with this stuff so far [21:30:50] I'm keen to try to progress stuff while you are off line but obviously without doubling up [21:31:34] 10Fundraising Sprint Fish HEAD^, 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog, 10FR-dlocal: DLocal Audit - Test with new integration - https://phabricator.wikimedia.org/T324347 (10Ejegg) Shoot, are we creating duplicate donations then, if we're... [21:31:52] thanks eileen [21:34:06] (03PS11) 10Damilare Adedoyin: CT-to-Civi-Phase 1 Create a view to replace the drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) [21:35:00] (03CR) 10Damilare Adedoyin: "thanks for the review eileen, added the recommended changes." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) (owner: 10Damilare Adedoyin) [21:37:21] ejegg: I left some comments on your globalcollect to ingenico smashpig patches [21:37:44] ah thank you damilare|away [21:37:47] looks good to me, just a suggestion on handling exceptions. please let me know your thoughts [21:37:51] I'll get to those in a bit [21:38:06] sorry, I spent most of today on that Adyen JS update [21:38:10] tried a bunch of things [21:38:29] the live vs test environment changed nothing - it's exactly the same script (same sha and all) [21:39:04] so I tried updating our gpay component creds, removing the creds (as they are optional) [21:39:27] and then finally trying all the versions to see where it broke [21:39:37] so hopefully they get back to us on that one [21:41:05] I hope so too [21:41:36] (03PS6) 10Ejegg: Make Adyen setup function async [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908318 (https://phabricator.wikimedia.org/T334999) [21:42:39] (03CR) 10CI reject: [V: 04-1] Make Adyen setup function async [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908318 (https://phabricator.wikimedia.org/T334999) (owner: 10Ejegg) [21:45:11] (03PS2) 10Jgleeson: Add UPI initial recurring check to civicrm import logic. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909742 (https://phabricator.wikimedia.org/T334942) [21:45:18] (03PS13) 10Wfan: Add cc as payment_method default in general for old gateway link that contains no payment_method. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/876044 (https://phabricator.wikimedia.org/T140269) [21:46:15] (03CR) 10CI reject: [V: 04-1] Add cc as payment_method default in general for old gateway link that contains no payment_method. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/876044 (https://phabricator.wikimedia.org/T140269) (owner: 10Wfan) [21:49:38] (03PS3) 10Jgleeson: Add UPI initial recurring check to civicrm import logic. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909742 (https://phabricator.wikimedia.org/T334942) [21:49:53] ok wfan ejegg I think that's ready ^ [21:50:35] it took a bit longer to test locally and confirm I didn't break anything after a small refactor of the method [21:50:47] checking thx jack :P [21:50:49] 10Fundraising Sprint Fish HEAD^, 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog, 10FR-dlocal: DLocal Audit - Test with new integration - https://phabricator.wikimedia.org/T324347 (10Cstone) @Ejegg I don't think any of the ones from yesterday were... [21:54:28] (03CR) 10Ejegg: Add UPI initial recurring check to civicrm import logic. (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909742 (https://phabricator.wikimedia.org/T334942) (owner: 10Jgleeson) [21:54:46] just one possible change jgleeson but could be merged as-is [21:55:32] (03PS4) 10Jgleeson: Add UPI initial recurring check to civicrm import logic. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909742 (https://phabricator.wikimedia.org/T334942) [21:55:45] checking ejegg [21:57:40] I was gonna do that at first ejegg but decided to send in the specific properties as the risk of sending in a bunch of unneeded stuff. I do agree it makes the calling method nicer though extracting out those bits [21:58:02] at* [21:59:40] I guess the overhead is negligible [21:59:47] (03CR) 10Wfan: "Thanks for the extra major gift explanation! good to know" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909742 (https://phabricator.wikimedia.org/T334942) (owner: 10Jgleeson) [22:00:18] yeah, feels more readable to do all the upi-specific checks in the upi function [22:00:52] ok I'll rejig it [22:01:03] thanks also wfan for review. I'll address those points too [22:01:05] ugh donation interface tests are failing and I don't know why.... [22:01:20] looks like maybe CI is doing more aggressive composer updates? [22:04:41] (03PS5) 10Jgleeson: Add UPI initial recurring check to civicrm import logic. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909742 (https://phabricator.wikimedia.org/T334942) [22:05:08] ok, I'll explicitly lock the version to 1.x for now I guess [22:05:22] (03CR) 10Jgleeson: Add UPI initial recurring check to civicrm import logic. (034 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909742 (https://phabricator.wikimedia.org/T334942) (owner: 10Jgleeson) [22:07:39] (03PS6) 10Jgleeson: Add UPI initial recurring check to civicrm import logic. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909742 (https://phabricator.wikimedia.org/T334942) [22:07:57] (03PS1) 10Ejegg: Lock psr/http-message to 1.x [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/909759 [22:08:03] ok I'm wrapping up fr-tech. if anyone finds anything else wrong with that patch feel free to edit the patch while I'm out [22:08:08] hopefully that will pass [22:08:10] thanks jgleeson ! [22:09:13] (03CR) 10Wfan: [C: 03+2] "Thanks Jack :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909742 (https://phabricator.wikimedia.org/T334942) (owner: 10Jgleeson) [22:09:40] wfan: Ah i just saw your comment on the data-fix patch. Sure, let's deploy jgleeson's fix first [22:10:49] Thanks ejegg and jgleeson for helping out the chaos tickets~ [22:16:55] :) [22:17:24] heh, yeah, bugs on newly deployed code still feel like everyone's responsibility [22:18:20] ok fr-tech I think we need https://gerrit.wikimedia.org/r/909759 merged to get donation-interface tests passing again [22:18:41] can anyone give that a quick look? [22:21:15] looking ejegg [22:21:49] (03CR) 10Jgleeson: [C: 03+2] "LGTM!" [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/909759 (owner: 10Ejegg) [22:21:54] bye for now [22:22:32] thanks! [22:30:22] (03Merged) 10jenkins-bot: Lock psr/http-message to 1.x [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/909759 (owner: 10Ejegg) [22:55:10] I've realised that I have to go out for a bit so might not get that population script review ready by the end of your day ejegg - [23:26:22] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Do a prune on detail data for activity records of type thank you - https://phabricator.wikimedia.org/T325123 (10Dwisehaupt) Missed in last maint window. Moving to the upcoming one in T333485 [23:27:32] 10Fundraising-Backlog, 10fundraising-tech-ops: Fr-Tech 2022q4 maintenance window - https://phabricator.wikimedia.org/T333485 (10Dwisehaupt) [23:41:27] hi ejegg, I'm about to prep for the India pre-test tomorrow. I'll just do controls, unless this contribution_it task https://phabricator.wikimedia.org/T334942 is already resolved, then I'll continue Peter's monthly convert test. Do you think it'll be resolved/deployed by tomorrow 16 utc? (not adding more urgency, but if there's a good chance it'll get fixed soon anyways, it saves us some menial banner prep!) [23:45:50] (03CR) 10Wfan: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/909424 (https://phabricator.wikimedia.org/T334737) (owner: 10Wfan) [23:46:25] (03CR) 10Wfan: [C: 03+2] Add UPI initial recurring check to civicrm import logic. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909742 (https://phabricator.wikimedia.org/T334942) (owner: 10Jgleeson) [23:48:52] haley_: I think we have that fixed! [23:54:50] trying to figure out where these damaged message refund ids came from is melting my brain [23:55:06] cool, thanks ejegg! I'll prep on the MC test then and double check back tomorrow morning [23:55:41] says audit yet its not in any filess?? [23:57:37] (03CR) 10Wfan: [C: 03+2] Link UPI recurring to contribution_tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909748 (https://phabricator.wikimedia.org/T334942) (owner: 10Ejegg) [23:59:03] (03CR) 10Wfan: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/876044 (https://phabricator.wikimedia.org/T140269) (owner: 10Wfan)