[00:06:18] (03CR) 10Wfan: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908318 (https://phabricator.wikimedia.org/T334999) (owner: 10Ejegg) [00:16:51] ok i figured out those damaged messages they were casualties of the switch from dlocal to astropay [00:16:58] er astropay to dlocal [00:17:04] not ghost ipns [00:17:21] from the audit [00:28:13] 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: dlocal refund could not find parent error - https://phabricator.wikimedia.org/T334989 (10Cstone) Okay this is very confusing. So these errors are coming from the audit, they are casualties of the flip from astropay to dlocal. Not from IPNs at all. I re... [01:06:59] cstone ahh so they should have been tagged astropay? [01:07:08] yeah i just requued them [01:07:10] sorry, I'll read your comment [01:07:10] spelled right [01:07:25] i think we need to separate astropay audit into a dlocal audit [01:07:41] i havent 100% confirmed but it hink we dont have a ton of dupliocates because its looking in the astropay logs [01:07:50] oooh [01:07:53] damn, right [01:07:59] ok, let's do that work asap [01:08:13] so lets not rename it until we fix the id issue though haha [01:08:59] or just turn off the audit i guess? [01:09:06] hmm, could do [01:09:20] if it's not going to get the refunds right anyway [01:09:27] yeah its broken and just timing out now [01:10:09] well not broken just finding nothing [01:10:14] ok, let's turn it off then [01:10:29] ok im already on frpm [01:10:40] so I think we have some precedent for looking in two log files [01:10:55] i get that but dont we want to delete the astropay folder eventually? [01:11:01] I think at the globalcollect/ingenico switch we had to do that for a while [01:11:05] yep yep [01:11:41] im just going to comment out the parse part, still have it download [01:12:01] ah sorry i meant look in two sets of log files [01:12:11] oh yeah sorry talking about two different things [01:12:12] not two folders for the audit csvs [01:12:20] yeah i get that [01:12:22] I figure for the audit CSVs we would just move them all [01:12:48] so as not to complicate the sftp sync script [01:12:55] yeah yeah [01:13:08] im just going to comment out the parse part so well still download [01:13:22] ok, I'm going to look at dami's comments on those ingenico disentabnglement patches [01:13:28] ok cstone [01:13:38] its up on frpm if you want to look ejegg [01:14:23] sure, that should do it [01:14:32] ok ill deploy that [01:15:35] ill msg in the dlocal slack channel too so they know to not look for audit stuff [01:27:50] (03CR) 10Ejegg: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/909750 (https://phabricator.wikimedia.org/T334989) (owner: 10Ejegg) [01:33:42] ejegg: what was the command to regen just the wiki links on our dev homepage? [01:41:30] really need to figure out whats going on with my attempts [01:41:33] its up to .20 hah [01:41:51] cstone it's the ./payments-update-text.sh [01:41:56] ahh thanks [01:42:24] oh weird, so it just hasn't reset? [01:42:30] yeah ct id changes [01:42:33] I thought we had a hard limit of 3 somewhere [01:42:36] but the attempts just keep going up [01:42:56] ok, i wonder if that's related to our duplicate order id bug [01:43:15] im testing that patch to switch the id then ill hunt it down [01:52:22] bah cant test recurring upi locally anymore [02:03:23] (03CR) 10Cstone: [C: 03+2] "Looks good and keeps the one step ones the same, nice!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/909750 (https://phabricator.wikimedia.org/T334989) (owner: 10Ejegg) [02:05:02] (03Merged) 10jenkins-bot: Dlocal: record capture ID not auth ID [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/909750 (https://phabricator.wikimedia.org/T334989) (owner: 10Ejegg) [02:13:00] ejegg: I'm going to deploy that change ^ [02:13:22] thanks cstone! [02:14:43] (03PS1) 10Cstone: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/909797 [02:16:11] (03CR) 10Cstone: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/909797 (owner: 10Cstone) [02:16:20] all the fiscal number translations hah [02:16:50] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/909797 (owner: 10Cstone) [02:19:54] !log payments-wiki upgraded from c01a32c4 to a01e5ae8 [02:19:57] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:23:04] aw hah my test mxn payment got frauded! [02:23:11] right after i said i didnt get frauded :P [02:27:14] ugh, I squashed two patched together in rebase by mistake [02:27:58] no, more like 3... booooo! [02:28:53] (03CR) 10Ejegg: "OK damilare, I'll do that in a follow-on patch. I tried to do it on this one but it made the rest a rebase hell and I ended up destroying " [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/908010 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [02:30:38] aww the squashining [02:31:11] I should have just done a git commit [02:31:18] and I was doing git commit --amend [02:31:31] ah yeahh [02:31:47] I forgot how git rebase -i sets you up when you tell it you want to edit some of them [02:31:52] or when it has a merge conflict [02:34:43] im gona head out ejegg have a good night [02:35:43] you too cstone [02:36:34] wfan: OK, I'm going to deploy those crm patches [02:36:42] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/909798 [02:36:56] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/909798 (owner: 10Ejegg) [02:37:55] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/909798 (owner: 10Ejegg) [02:38:00] Ah thanks ejegg will check db after, then move the ticket accordingly~ [02:38:13] (03PS1) 10Ejegg: Catch exceptions in createPaymentSession [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909799 (https://phabricator.wikimedia.org/T260725) [02:38:47] (03CR) 10Ejegg: "The exception handling for this method is in https://gerrit.wikimedia.org/r/909799" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/908010 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [02:38:50] (03CR) 10CI reject: [V: 04-1] Catch exceptions in createPaymentSession [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909799 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [02:39:55] (03CR) 10Ejegg: "As with the previous one, I'll add the exception handling in a follow-on patch to avoid rebase ugliness." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909428 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [02:41:25] (03PS2) 10Ejegg: Catch exceptions in createPaymentSession [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909799 (https://phabricator.wikimedia.org/T260725) [02:45:20] 10Fundraising-Backlog: Civi\Api4\Service\Spec\Provider\MappingCreationSpecProvider' not found in CachedCiviContainer - https://phabricator.wikimedia.org/T334966 (10Ejegg) @annwf Was this just a transient error? That class was removed in a recent deploy and might have just been stuck in an old cached autoloader o... [02:47:13] !log civicrm upgraded from dab8912d to 39bbe8cc [02:47:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:48:26] argh, permission denied [02:48:48] the civi db user apparently doesn't have the perms to update drupal.contribution_tracking [02:48:55] wfan: ^^^ [02:50:03] I'm just going to run it under cli (in a transaction of course) [02:51:07] ok, committed [02:51:20] now I'm going to revert that patch [02:52:32] (03PS1) 10Ejegg: Revert "Link UPI recurring to contribution_tracking" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909800 [02:52:36] (03CR) 10Ejegg: [C: 03+2] Revert "Link UPI recurring to contribution_tracking" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909800 (owner: 10Ejegg) [02:52:54] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/909801 [02:52:56] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/909801 (owner: 10Ejegg) [02:53:11] ok, did not consider the permission thing, thanks ejegg~ [03:01:53] (03PS1) 10Ejegg: Change phone explanation wording [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/909802 (https://phabricator.wikimedia.org/T334952) [03:02:11] wfan that's a really tiny one to review if you have a sec ^^ [03:02:44] (03CR) 10Wfan: [C: 03+2] "LGMT!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/909802 (https://phabricator.wikimedia.org/T334952) (owner: 10Ejegg) [03:04:26] (03Merged) 10jenkins-bot: Change phone explanation wording [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/909802 (https://phabricator.wikimedia.org/T334952) (owner: 10Ejegg) [03:04:33] (03Merged) 10jenkins-bot: Revert "Link UPI recurring to contribution_tracking" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/909800 (owner: 10Ejegg) [03:04:35] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/909801 (owner: 10Ejegg) [03:08:21] thanks wfan [03:08:44] np ~ and have a good night ejegg :) [03:08:48] you too [03:08:58] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/909803 [03:10:55] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/909803 (owner: 10Ejegg) [03:11:33] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/909803 (owner: 10Ejegg) [03:11:44] !log civicrm upgraded from 39bbe8cc to efdf9434 [03:11:47] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:12:27] !log payments-wiki upgraded from a01e5ae8 to 66be66e0 [03:12:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:13:05] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Change language re phone number field for UPI - https://phabricator.wikimedia.org/T334952 (10Ejegg) [03:17:42] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: dLocal one-hour test failmail: "Merchant has no authorization to use this API" / "Token not found or inactive" - https://phabricator.wikimedia.org/T334945 (10Ejegg) @EMartin it looks like we are getting this error when donors try to donate... [04:09:32] (03PS1) 10Ejegg: Half-hearted Adyen Chargeback fixes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909804 [04:09:58] (03CR) 10CI reject: [V: 04-1] Half-hearted Adyen Chargeback fixes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909804 (owner: 10Ejegg) [04:10:58] (03PS2) 10Ejegg: Half-hearted Adyen Chargeback fixes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909804 [06:52:22] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity - https://phabricator.wikimedia.org/T334532 (10Eileenmcnaughton) After talking to @jmando we should add 3 more fields to the civicrm_contribution_tracking table... - variant_... [07:13:02] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q1:rack/setup/install frbast1002, frmon1002, frpig1002 - https://phabricator.wikimedia.org/T319460 (10ayounsi) [07:23:32] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1 - expose in the UI - https://phabricator.wikimedia.org/T334540 (10Eileenmcnaughton) I dug out the work I did on embedding the import view & tested and it DOES work in a popup (yay). I'm giving you some details about how that... [10:29:40] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: dlocal recurring issue: contribution_id is not being written to the contribution_tracking record following CiviCRM import - https://phabricator.wikimedia.org/T334942 (10Pcoombe) >>! In T334942#8791343, @jgleeson wrote: > We've found the iss... [10:49:16] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks for the follow on patch, lgtm." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/908010 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [10:49:52] (03Merged) 10jenkins-bot: createPaymentSession for Ingenico HostedCheckoutProvider [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/908010 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [10:49:55] (03Merged) 10jenkins-bot: Add new properties to PaymentDetailResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909427 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [10:51:26] (03CR) 10Damilare Adedoyin: [C: 03+2] "LGTM! In anticipation of the follow on patch." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909428 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [10:52:00] (03Merged) 10jenkins-bot: Deprecate old getHostedPaymentStatus call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909428 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [12:07:36] 10Fundraising-Backlog, 10FR-dlocal: Set error for Dlocal unsupported card types in India - https://phabricator.wikimedia.org/T334937 (10jgleeson) [12:07:38] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: dLocal one-hour test failmail: "Merchant has no authorization to use this API" / "Token not found or inactive" - https://phabricator.wikimedia.org/T334945 (10jgleeson) [12:07:58] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: Set error for Dlocal unsupported card types in India - https://phabricator.wikimedia.org/T334937 (10jgleeson) a:03jgleeson [13:01:14] it looks like it's not just amex that is affected [13:01:27] I saw this today: The payment submethod [diner] was not found [13:02:42] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: Set error for Dlocal unsupported card types in India - https://phabricator.wikimedia.org/T334937 (10jgleeson) [13:04:43] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: Set error for Dlocal unsupported card types in India - https://phabricator.wikimedia.org/T334937 (10jgleeson) [13:27:06] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: dLocal one-hour test failmail: "Merchant has no authorization to use this API" / "Token not found or inactive" - https://phabricator.wikimedia.org/T334945 (10EMartin) @Ejegg Elliott, Dlocal reported that AMEX is not supported in India. A... [13:31:39] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: Set error for Dlocal unsupported card types in India - https://phabricator.wikimedia.org/T334937 (10jgleeson) I noticed that we have submethod warnings in the logs for successful payments also. For 175310978, which was successful, the logs... [13:33:15] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: Set error for Dlocal unsupported card types in India - https://phabricator.wikimedia.org/T334937 (10jgleeson) [13:36:22] ohh jgleeson that sounds like a different error, can you share the invoice id related to that [13:37:00] looks you found another for discover [13:37:05] ya [13:37:24] amex and diners so far [13:37:30] lemme post some ids on the ticket [13:38:03] but dlocal doesn't return that error for amex [13:39:49] it looks like we've got a few card types that we don't support in our config. some fail with dlocal and others get through [13:42:13] interesting [13:45:03] 175291850 [13:45:06] that's a diners from today [13:45:36] brb skrun [13:45:52] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: Set error for Dlocal unsupported card types in India - https://phabricator.wikimedia.org/T334937 (10jgleeson) [13:47:43] thanks I also saw some from maestro [13:48:04] I saw a bunch of those for Brazil [13:48:32] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: Set error for Dlocal unsupported card types in India - https://phabricator.wikimedia.org/T334937 (10jgleeson) [13:50:33] yep but it's weird that we are making those api calls for submethods not listed in the countries [13:51:54] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Recent donations not saved after merging of two CIDs - https://phabricator.wikimedia.org/T326583 (10SHust) @Eileenmcnaughton would you like me to create the phab? [13:57:11] (03CR) 10Damilare Adedoyin: [C: 03+2] Add bank logo for dlocal boleto and pix [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/909424 (https://phabricator.wikimedia.org/T334737) (owner: 10Wfan) [14:13:19] (03Merged) 10jenkins-bot: Add bank logo for dlocal boleto and pix [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/909424 (https://phabricator.wikimedia.org/T334737) (owner: 10Wfan) [14:16:42] nice digging jgleeson|skrun [14:16:53] let's see if we already have a message for that [14:18:13] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: Set error for Dlocal unsupported card types in India - https://phabricator.wikimedia.org/T334937 (10Ejegg) >>! In T334937#8791446, @AnnWF wrote: > https://docs.dlocal.com/docs/india#cards seems support Amex, could just need to map the subme... [14:27:53] (03CR) 10Damilare Adedoyin: [C: 03+2] Map amount, currency, submethod in Ingenico status lookup [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909429 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [14:28:27] (03Merged) 10jenkins-bot: Map amount, currency, submethod in Ingenico status lookup [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/909429 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [14:40:48] 10Fundraising Sprint Fish HEAD^, 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog, 10FR-dlocal: DLocal Audit - Test with new integration - https://phabricator.wikimedia.org/T324347 (10MBeat33) I hope this is an appropriate place to note this, the dL... [14:57:36] thanks for the info ejegg [14:58:36] it looks like some donors are working out that we don't support certain card types and then following up with another payment method [14:59:54] 175241796 goes from amex to upi! [15:00:20] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: Set error for Dlocal unsupported card types in India - https://phabricator.wikimedia.org/T334937 (10jgleeson) [15:08:59] thanks for the CR, damilare ! [15:09:51] np ejegg, would get back to it soon as I figure out some issues with cv [15:10:09] on that note, please how can I test a patch from Civi [15:10:17] upstream [15:10:48] damilare: ah good question, I wonder if there is an easy way to change the root directory for a patch [15:11:11] is it something that's just in github right now? [15:11:19] pulling into this directory seems to be breaking the build for me:./src/civi-sites/wmff/drupal/sites/all/modules/civicrm/ [15:12:11] yh eileen shared this commit and I've been trying to pull it in: https://github.com/civicrm/civicrm-core/compare/master...eileenmcnaughton:civicrm-core:import_embedeed?expand=1 [15:12:34] but looks like there 's a difference in the files that wouldn't let it happen [15:12:35] ejegg: damilare, dmaster is a clean checkout of civi. could you use that? [15:13:09] ohh ok, let me try that [15:13:19] what port is dmaster on? [15:13:22] civi-sites/dmaster that is [15:13:25] ha good question [15:13:36] I'd check your .env file [15:13:37] I have one running on my vm though [15:14:01] hmm, something that size I might just copy and paste [15:14:36] right [15:15:10] https://dmaster.localhost:32353/ [15:15:39] otherwise you could download it in a fresh civi-core checkout and then use git format-patch to create a .patch file [15:16:06] then patch -p to apply it in the civicrm directory under the wmff site [15:16:38] ohh thanks jgleeson I'm just learning about this [15:16:46] right ejegg that makes sense too [15:21:02] (03PS1) 10Ejegg: PayPal: handle recurring_payment_outstanding_payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/910032 [15:24:06] jgleeson: I wonder if we should restore the brand_code to the dlocal payment_submethod.yaml [15:24:24] interesting idea [15:24:39] that way we could provide a map of brand_code => normalized submethod that includes just the codes supported for the current country [15:25:11] and use that instead of the hardcoded list in the cardField.on( 'brand' handler [15:25:21] oh wait, that gives us a different string [15:26:22] I guess we would have to use it on submit and run this dlocal.getBinInformation: https://docs.dlocal.com/reference/the-dlocal-object#dlocalgetbininformationfield [15:27:52] anyway, i should get back to the ingenico disentanglement if i want to finish it this sprint! [15:33:47] ejegg: are we doing anything on the frontend atm to validate submethods? [15:35:08] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/4e323734c81a4b9226aa9d0118103c8d5b4ae463/modules/js/ext.donationInterface.validation.js#L81 [15:36:17] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/99c8a00b3982263bf7a260397ffba3e37fd9328f/modules/validate_input.js#L4 [15:36:26] this stuff goes way back [15:56:39] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1 - expose in the UI - https://phabricator.wikimedia.org/T334540 (10Damilare) a:03Damilare [16:08:30] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: dlocal refund could not find parent error - https://phabricator.wikimedia.org/T334989 (10AnnWF) [16:14:50] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: Set error for Dlocal unsupported card types in India - https://phabricator.wikimedia.org/T334937 (10Ejegg) It would be nice to get the list of supported cards from the payment_submethods.yaml rather than hardcoding it in JS. I've just check... [16:15:18] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: Set error for Dlocal unsupported card types in India - https://phabricator.wikimedia.org/T334937 (10AnnWF) Ok related with T334769 [16:16:22] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: Set error for Dlocal unsupported card types in India - https://phabricator.wikimedia.org/T334937 (10jgleeson) useful greps ` grep 'Token not found or inactive' payments-dlocal | cut -d" " -f6 | grep -P '\d+' grep 'Token not found or inacti... [16:40:43] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1 - expose in the UI - https://phabricator.wikimedia.org/T334540 (10Damilare) Thanks @Eileenmcnaughton I was able to see the embedded Searchkit in the import view. I would follow a similar pattern to add the CT searchkit searc... [16:51:58] (03PS6) 10Wfan: Add missing submethods for gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908868 (https://phabricator.wikimedia.org/T334769) [17:51:26] cstone I'm looking in the queue consumer logs for that casing now [17:51:36] to see if we uppercase it on payments or in Civi [17:52:01] ok, looks like the correct case in the messages that come in to the queue consumer [17:52:04] let [17:52:09] s see if the normalize function is messing it up [17:53:41] 10Fundraising-Backlog, 10FR-dlocal: Don't strtoupper dlocal ids - https://phabricator.wikimedia.org/T335057 (10Cstone) [17:57:08] from the job PaymentsInitQueueConsumer we have the lowercase [17:57:32] DonationQueueConsumer also right case [18:05:29] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: dlocal Transaction ID shown all cap in CIVI - https://phabricator.wikimedia.org/T335060 (10AnnWF) [18:06:22] whoops wfan I already made one [18:06:59] yeah just realized that and merge as dup [18:07:02] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: dlocal Transaction ID shown all cap in CIVI - https://phabricator.wikimedia.org/T335060 (10AnnWF) [18:07:29] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: Don't strtoupper dlocal ids - https://phabricator.wikimedia.org/T335057 (10AnnWF) [18:07:51] wfan: theres also talk about it in the other channel [18:08:30] thx! [18:11:31] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: Don't strtoupper dlocal ids - https://phabricator.wikimedia.org/T335057 (10AnnWF) [18:25:20] (03PS1) 10Wfan: Do not convert txn uppercase for civi [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910062 (https://phabricator.wikimedia.org/T335057) [18:39:50] (03CR) 10CI reject: [V: 04-1] Do not convert txn uppercase for civi [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910062 (https://phabricator.wikimedia.org/T335057) (owner: 10Wfan) [18:48:43] (03PS2) 10Wfan: Do not convert txn uppercase for civi [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910062 (https://phabricator.wikimedia.org/T335057) [18:50:38] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Don't strtoupper dlocal ids - https://phabricator.wikimedia.org/T335057 (10AnnWF) a:03AnnWF [18:51:16] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q1:rack/setup/install frbast1002, frmon1002, frpig1002 - https://phabricator.wikimedia.org/T319460 (10Dwisehaupt) I just attempted to build frbast1002 and frpig1002 and neither got a dhcp offer. Could we please verify that all the hosts are in the corre... [18:58:15] (03PS3) 10Wfan: Do not convert txn uppercase for civi [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910062 (https://phabricator.wikimedia.org/T335057) [18:58:58] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q1:rack/setup/install frbast1002, frmon1002, frpig1002 - https://phabricator.wikimedia.org/T319460 (10Dwisehaupt) a:05Jgreen→03Cmjohnson [18:59:27] (03PS4) 10Wfan: Do not convert txn uppercase for civi [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910062 (https://phabricator.wikimedia.org/T335057) [19:48:30] hey fr-tech, just a heads up that the India low-traffic banner pre-test is starting in 10ish minutes. [19:48:39] thanks haley_ [20:05:52] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1 - expose in the UI - https://phabricator.wikimedia.org/T334540 (10Damilare) Hi @Eileenmcnaughton can you please help point out where the ImportSummary5 angular module was defined? I assumed with the created afform and search... [20:25:20] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Clean up old TY CiviMail records - https://phabricator.wikimedia.org/T335070 (10Ejegg) [20:25:29] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Bad query on civicrm mailing dash board - https://phabricator.wikimedia.org/T335071 (10Eileenmcnaughton) [20:27:15] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Clean up old TY CiviMail records - https://phabricator.wikimedia.org/T335070 (10Ejegg) [20:28:20] (03CR) 10Ejegg: [C: 03+2] "Yep, this looks like correct behavior. I can't find anywhere that we are relying on this being all uppercase." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910062 (https://phabricator.wikimedia.org/T335057) (owner: 10Wfan) [20:31:01] ejegg: can you see this ? https://docs.google.com/document/d/1oxtIfTHNwOzmsiogVZ9KkA-ghVLNsKKMiReSBJoGadQ/edit [20:34:35] I'm gonna take a shower & then try to process that - but might make sense to hang out& discuss? [20:40:26] (03PS1) 10Wfan: add getSimpleSubmethods for DI pair if valid submethod [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/910093 (https://phabricator.wikimedia.org/T334937) [20:41:13] (03Merged) 10jenkins-bot: Do not convert txn uppercase for civi [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910062 (https://phabricator.wikimedia.org/T335057) (owner: 10Wfan) [20:57:16] ejegg: cstone if anyone wants to talk fields with joseph on here now - https://meet.google.com/qsv-qmdy-buu [21:20:29] ejegg: so cstone & I caught up with joseph just now & it seems cool to add the additional fields he currently breaks out & it will save some brain-pain for anyone he ever has to explain it to - but he made a pretty good case for also keeping utm_key (which we currently are) and utm_source (which we currently aren't) - which is that as url strings compiled by people these are subject to human error [21:20:44] so if they make a mistake we would want to have captured the original [22:01:53] (03PS1) 10Wfan: Revert trxn_id to default case for dlocal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910099 (https://phabricator.wikimedia.org/T335057) [22:05:22] (03PS2) 10Wfan: Revert trxn_id to default case for dlocal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910099 (https://phabricator.wikimedia.org/T335057) [22:08:46] (03PS1) 10Eileen: Additional contribution_tracking fields proposed by analytics [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910100 (https://phabricator.wikimedia.org/T334532) [22:11:18] eileen: so utm_source is I think actually concatenated in code [22:11:25] at least those dotted parts [22:11:58] ejegg: ok - are you able to confirm that [22:12:52] so here's a place in DonationInterface that we assume it always has its dotted sections: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/gateway_common/DonationData.php$780 [22:12:56] ejegg: I put it into a patch - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/910100 but I was just about to email josephmando with my concern that we probably should use option values where there are only a couple of clearly defined uptions [22:13:03] ejegg: could a rogue . get in there from user data? [22:13:07] I guess the original concatenation does come from a string though [22:13:26] derp not from a string from banner or donatewiki js though [22:13:44] so that one is not a url parameter? [22:14:13] ah, it is a url_parameter, and a donor could stuff it with whatever [22:14:31] lemme just find the on-wiki js that populates it [22:16:08] https://meta.wikimedia.org/wiki/MediaWiki:FundraisingBanners/CoreJS-2018.js#L-267 [22:22:33] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog, 10Patch-For-Review: CT-to-Civi-Phase 1 Create new CiviCRM contribution tracking entity - https://phabricator.wikimedia.org/T334532 (10Eileenmcnaughton) @JMando I've translated your fields into a patch - https://gerrit.wikimedia.org/r/c/wik... [22:34:49] dwisehaupt: ejegg we no longer need the table drupal.queue2civicrm_log - I didn't write an upgrade script to drop it - am wondering about 'just doing it' in mysql [22:38:19] eileen: should be fine. i don't see any references to it specifically in the puppet repo. [22:39:01] if we have other upgrade scripts we could pop it in there, but if it's just a drop for this unused one, i'd say do it. [22:39:14] just make sure the table is spelled correctly, just in case. :) [22:39:19] ok - so I'm gonna run DROP TABLE queue2civicrm_log ..... once ejegg give the thumbs up [22:39:40] or maybe just for kicks I'll choose a random different table name... [22:44:24] haha [22:44:35] sure, I think we can get rid of it [22:55:28] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q1:rack/setup/install frbast1002, frmon1002, frpig1002 - https://phabricator.wikimedia.org/T319460 (10Papaul) @Dwisehaupt i checked on the switch all the interfaces are configured and up maybe the server were not added to DNS since we do not manage Frac... [22:58:24] I did it - that was scary! [23:00:20] ejegg: so just wanting to clarify what you are thinking re fields - should I write here or should we jump on a hangout? [23:07:22] (03PS1) 10Eileen: Populate contribution tracking fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910103 (https://phabricator.wikimedia.org/T334534) [23:08:46] (03PS2) 10Eileen: Populate contribution tracking fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910103 (https://phabricator.wikimedia.org/T334534) [23:09:28] sorry, just saw that eileen [23:09:36] hangout is fine [23:09:47] cool [23:10:03] https://meet.google.com/ygo-vibw-zan [23:32:06] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q1:rack/setup/install frbast1002, frmon1002, frpig1002 - https://phabricator.wikimedia.org/T319460 (10Dwisehaupt) @Papaul Thanks, I have verified they are in DNS. I think there may be some crossing in cables or vlans. When I try to build a host, I'm se... [23:47:38] eileen since nov 1 last year 99.49% of all utm_source fields have been three or four fields separated by dots [23:48:21] ejegg: so I guess the question is what implications does the last 0.5% have... [23:49:18] 10Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, 10Fundraising-Backlog: investigate: Record user agent in contribution_tracking - https://phabricator.wikimedia.org/T182039 (10Eileenmcnaughton) We are adding the fields os os_version,browser, browser version to the new civicrm_contributi... [23:50:36] yeah, I'm fine keeping utm_source for now at least