[00:08:39] (03PS1) 10Cstone: Add dlocal refund and chargeback ipn handling [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/910610 (https://phabricator.wikimedia.org/T330723) [00:09:15] (03CR) 10CI reject: [V: 04-1] Add dlocal refund and chargeback ipn handling [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/910610 (https://phabricator.wikimedia.org/T330723) (owner: 10Cstone) [00:10:15] (03PS2) 10Cstone: Add dlocal refund and chargeback ipn handling [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/910610 (https://phabricator.wikimedia.org/T330723) [00:40:01] (03PS1) 10Wfan: Add missing submethods pair for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/910611 (https://phabricator.wikimedia.org/T334937) [00:44:59] (03PS1) 10Eileen: Update PaymentIntruments Managed file to name=>label [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910612 (https://phabricator.wikimedia.org/T334534) [00:45:54] ejegg: did you create a phab to cleanup payment instruments or did I imagine that? [00:46:04] oh eileen no I didn't [00:46:08] I see your patch [00:46:50] I think a few of those you remove are supposedly available in dlocal countries but maybe we just haven't actually done much of a campaign there yet [00:47:12] so I'll review and mark the ones I know are obsolete [00:47:16] ejegg: ah ok - we don't need to remove [00:47:25] I'm more focused on the name field [00:47:36] ah yeah [00:47:47] I only found 3 payment submethods on staging - so as long as they match... [00:48:23] ah yeah, that sounds about right, most of the time we don't know submethod till well after sending the contribution_tracking row [00:48:49] but, also I wonder if the names should wind up as (e.g ) rtbt.rtbt_ideal - ie the last 2 values from the utm_source [00:49:23] - that's not what my script expects & I don't want to re-write my script so more spitballing on that right now [00:50:55] ahh yeah, that would solve the problem of the Apple visa vs Google visa vs CC visa [00:52:36] seems fine to me! [00:53:28] but again, that can change later [00:53:43] when we want to get rid of the big FinanceInstrument switch statement [00:54:53] ejegg: cool [00:55:32] I just tested & we can change 'name' pretty easily via the managed array [00:56:50] (03PS1) 10Eileen: Change name fields for the ones that we hit on tracking convert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910614 (https://phabricator.wikimedia.org/T334534) [01:05:40] (03PS2) 10Eileen: Change name fields for the ones that we hit on tracking convert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910614 (https://phabricator.wikimedia.org/T334534) [01:06:02] ok - I think we need to do that too if we update the names ^^ [01:15:14] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Reintegrate Ingenico rtbt_enets payment method - https://phabricator.wikimedia.org/T141989 (10MBeat33) Archeological - fine with me to close, thanks @Eileenmcnaughton [01:16:03] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Reintegrate Ingenico rtbt_enets payment method - https://phabricator.wikimedia.org/T141989 (10Eileenmcnaughton) 05Open→03Declined positively paleolithic [01:17:19] (03PS1) 10Wfan: WIP: check recurring cancel status [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910615 (https://phabricator.wikimedia.org/T335152) [01:18:32] (03CR) 10CI reject: [V: 04-1] Change name fields for the ones that we hit on tracking convert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910614 (https://phabricator.wikimedia.org/T334534) (owner: 10Eileen) [01:29:19] (03CR) 10CI reject: [V: 04-1] WIP: check recurring cancel status [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910615 (https://phabricator.wikimedia.org/T335152) (owner: 10Wfan) [01:30:35] eileen: seems we can leave the 'name' field as-is for now, no? And just hard-code the IDs for production in the ContributionTracking stuff [01:31:30] ejegg: yeah I guess - I did my testing so far with them re-named on staging - I was just looking into the fail there & we are using the label in our lookups I think [01:33:29] yesh, since it's been the same as the name till now [01:37:17] (03PS7) 10Eileen: Populate contribution tracking fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910103 (https://phabricator.wikimedia.org/T334534) [01:37:30] ejegg: ok ^^ just has the 4 I found hard-coded [01:41:58] ok, taking a look [02:02:30] (03PS2) 10Ejegg: Fill scheme ID for ingenico recurrings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910577 (https://phabricator.wikimedia.org/T331754) [02:03:29] sorry, just had to wrap up something with my scheme ID patch [02:12:54] (03PS3) 10Ejegg: Fill scheme ID for ingenico recurrings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910577 (https://phabricator.wikimedia.org/T331754) [02:14:50] (03PS4) 10Ejegg: Fill scheme ID for ingenico recurrings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910577 (https://phabricator.wikimedia.org/T331754) [02:17:50] (03PS5) 10Ejegg: Fill scheme ID for ingenico recurrings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910577 (https://phabricator.wikimedia.org/T331754) [02:36:25] eileen: it looks pretty good but it's confusing to have some inapplicable things populated [02:36:37] like baner_size_id defaulting to 3 for emails [02:36:54] just cause they don't have a _sm_ in the utm_source [02:37:25] hmm, locally my ..cc rows aren't being picked up as payment_method cc either for some reason [02:37:30] playing with that regex [02:37:33] (03PS1) 10Eileen: Fix typo in Import Mapping Managed entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910616 (https://phabricator.wikimedia.org/T303986) [02:38:12] ejegg: I think the 3 was for unspecified from Joseph's doc? But I could leave as Null [02:39:41] oh i see [02:44:59] (03CR) 10Ejegg: Populate contribution tracking fields (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910103 (https://phabricator.wikimedia.org/T334534) (owner: 10Eileen) [02:45:31] suggestion for the regex to pick up the really minimal cases with just payment_method [02:47:35] ok maybe a null in recurring_choice when it's not reurring? [02:47:44] (03PS1) 10Eileen: Avoid type error when organization_name is not set [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910617 (https://phabricator.wikimedia.org/T303986) [02:47:52] other than that I think it's great [02:48:00] nice SQL generation too [02:48:48] (03CR) 10Ejegg: [C: 03+2] Fix typo in Import Mapping Managed entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910616 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [02:49:01] (03CR) 10Ejegg: [C: 03+2] Avoid type error when organization_name is not set [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910617 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [02:50:12] ejegg: do you have an example row where your regex tweak would have made the difference? I thought the trailing |.* would have done that [02:50:28] oh I wasn't sure what that was [02:50:45] so the ones I was seeing it not work on were just '..cc' [02:52:07] select REGEXP_REPLACE('..cc', '([^\.]+)\.([^\.]+)\.([^\.]*)\.?([^\.]+)?|.*','\\3'); [02:52:12] returns an empty string [02:52:26] and select REGEXP_REPLACE('..cc', '([^\.]*)\.([^\.]*)\.([^\.]*)\.?([^\.]+)?|.*','\\3'); [02:52:30] returns 'cc' [02:52:37] hmm - do you want to push that tweak into it if it's working for you? [02:52:43] sure [02:54:56] so that trailing |.* isn't in any capture parens [02:55:11] that comes from the stack exchange link [02:55:29] commented in [02:55:42] I'm just gonna push to NULL recurring choice if not needed [02:55:50] oh ok [02:56:03] (03PS8) 10Eileen: Populate contribution tracking fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910103 (https://phabricator.wikimedia.org/T334534) [02:57:29] (03PS9) 10Ejegg: Populate contribution tracking fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910103 (https://phabricator.wikimedia.org/T334534) (owner: 10Eileen) [02:58:55] oh shoot, did I revert to the full submethod mess? [02:59:07] or, wait, did you mean to do that in PS8? [03:00:09] (03PS10) 10Eileen: Populate contribution tracking fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910103 (https://phabricator.wikimedia.org/T334534) [03:00:16] ejegg: I think I just put them back [03:00:41] (03Merged) 10jenkins-bot: Fix typo in Import Mapping Managed entity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910616 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [03:00:45] rockin, that's looking totally solid to me [03:01:04] (03Merged) 10jenkins-bot: Avoid type error when organization_name is not set [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910617 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [03:01:26] ejegg: cool [03:01:40] (03PS11) 10Ejegg: Populate contribution tracking fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910103 (https://phabricator.wikimedia.org/T334534) (owner: 10Eileen) [03:01:56] (03CR) 10Ejegg: [C: 03+2] "Let's see the data!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910103 (https://phabricator.wikimedia.org/T334534) (owner: 10Eileen) [03:02:16] I'll deploy once merged through & then haul some in [03:04:05] :) [03:05:07] hmm - it's not rattling as well as it did on staging [03:05:26] I'll do a truncate cos it might have slowed due to data [03:05:33] ahh [03:05:56] that'll be a couple of big tables to join I guess [03:06:19] it slows down as it goes - they are now flying in .... [03:06:45] ok there is 100k+ on staging now [03:07:38] looks ok [03:08:35] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/910618 [03:08:59] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/910618 (owner: 10Eileen) [03:09:34] I jumped the gun - it's not merged yet [03:11:48] !log civicrm upgraded from a2e7c079 to 5b63c2b2 [03:11:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:11:57] (that doesn't include THE patch) [03:13:06] (03Abandoned) 10Eileen: CT-to-Civi-Phase 1 - populate the civi fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908626 (https://phabricator.wikimedia.org/T334534) (owner: 10Damilare Adedoyin) [03:14:16] ejegg: so this view is probably still OK - but I think we need dallas of jeff to load it due to the permissions https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/908904/11/drupal/sites/default/civicrm/extensions/wmf-civicrm/sql/create_drupal_ct_view.sql [03:14:44] (03Merged) 10jenkins-bot: Populate contribution tracking fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910103 (https://phabricator.wikimedia.org/T334534) (owner: 10Eileen) [03:15:38] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/910619 [03:15:48] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/910619 (owner: 10Eileen) [03:16:33] ah yeah, the intact utm_source makes that view a lot simpler than otherwise :) [03:16:48] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/910619 (owner: 10Eileen) [03:17:18] payments_form is getting the appeal / variant stripped out there [03:17:48] oh i see, it is doing the concat [03:18:06] I think we should just select the untouched column there [03:18:33] since people do filters on that column, it would be best not to do them on a computed value, right? [03:18:52] sorry, last three comments were about utm_source [03:19:07] I'll put up a slight revision to that, one sec [03:19:11] !log civicrm upgraded from 5b63c2b2 to 0fad720a [03:19:14] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:19:37] ejegg: yeah the schema has changed slightly since damilare|awayish wrote that patch [03:19:52] yep, i figured that was the reason [03:21:06] ah, it's in review. I'll just comment [03:21:24] ejegg: we have some data https://civicrm.wikimedia.org/civicrm/contribution_tracking [03:23:18] woohoo! [03:23:43] (03PS1) 10Eileen: Add server route for contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910620 [03:23:51] pretty sweet [03:24:04] ejegg: ^^ just adds the url that I manually added on prod [03:24:09] so we could see it [03:24:16] (probably less confusing to merge asap) [03:24:27] (03CR) 10Ejegg: [C: 03+2] Add server route for contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910620 (owner: 10Eileen) [03:24:32] dot those js [03:25:41] (03CR) 10Ejegg: CT-to-Civi-Phase 1 Create a view to replace the drupal table (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) (owner: 10Damilare Adedoyin) [03:34:05] ok, i'm out of here for now [03:34:15] have a good rest of your day [03:39:46] 10Fundraising Sprint Highway to Hello World, 10Fundraising-Backlog: CT-to-Civi-Phase 1 - expose in the UI - https://phabricator.wikimedia.org/T334540 (10Eileenmcnaughton) @Damilare your display looks pretty cool on live now!!! https://civicrm.wikimedia.org/civicrm/contribution_tracking I've been trying (ami... [08:45:32] (03CR) 10Lucas Werkmeister (WMDE): Use IDatabase::setSessionOptions() to set group_concat_max_len (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/908572 (https://phabricator.wikimedia.org/T333688) (owner: 10Lucas Werkmeister (WMDE)) [23:47:05] I have a question - mostly for damilare|awayish who is not here - how do we spell the short version? I've been using Dami but I saw Damy from someone....