[00:00:38] yes, in that patch it would be better to just have the amex country list change to show it's not supported in India [00:01:08] Oh, I guess you were updating that in the patch to make sure we didn't block any valid card types? [00:02:12] maybe you could just update the country lists on the cc types then? [00:02:34] and it would be best not to change the order in the same patch - it makes it really hard to see what has changed [00:03:48] (03PS7) 10Wfan: Add DI error when dlocal smart field has unsupported card type [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/910079 (https://phabricator.wikimedia.org/T334937) [00:05:06] (03CR) 10Ejegg: Add DI error when dlocal smart field has unsupported card type (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/910079 (https://phabricator.wikimedia.org/T334937) (owner: 10Wfan) [00:08:33] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: clean dlocal submetods - https://phabricator.wikimedia.org/T335388 (10AnnWF) [00:10:23] (03CR) 10Ejegg: Add DI error when dlocal smart field has unsupported card type (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/910079 (https://phabricator.wikimedia.org/T334937) (owner: 10Wfan) [00:12:16] (03PS1) 10Wfan: Clean payment submethods and add missing payment images [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/911839 (https://phabricator.wikimedia.org/T335388) [00:12:19] (03PS1) 10Eileen: Fix type error when importing & id rather than name is present [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911955 (https://phabricator.wikimedia.org/T335384) [00:13:18] (03PS2) 10Wfan: Add missing submethods pair for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/910611 (https://phabricator.wikimedia.org/T335388) [00:13:24] (03CR) 10CI reject: [V: 04-1] Clean payment submethods and add missing payment images [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/911839 (https://phabricator.wikimedia.org/T335388) (owner: 10Wfan) [00:14:55] (03PS2) 10Wfan: Clean payment submethods and add missing payment images [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/911839 (https://phabricator.wikimedia.org/T335388) [00:24:50] (03CR) 10CI reject: [V: 04-1] Fix type error when importing & id rather than name is present [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911955 (https://phabricator.wikimedia.org/T335384) (owner: 10Eileen) [00:27:28] (03PS2) 10Eileen: Fix type error when importing & id rather than name is present [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911955 (https://phabricator.wikimedia.org/T335384) [00:30:27] (03PS8) 10Wfan: Add DI error when dlocal smart field has unsupported card type [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/910079 (https://phabricator.wikimedia.org/T334937) [00:39:08] (03PS9) 10Wfan: Add DI error when dlocal smart field has unsupported card type [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/910079 (https://phabricator.wikimedia.org/T334937) [00:40:23] (03CR) 10CI reject: [V: 04-1] Fix type error when importing & id rather than name is present [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911955 (https://phabricator.wikimedia.org/T335384) (owner: 10Eileen) [01:17:42] (03PS3) 10Eileen: Fix type error when importing & id rather than name is present [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911955 (https://phabricator.wikimedia.org/T335384) [01:17:44] (03PS1) 10Eileen: Fix Organization import template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911956 [01:21:47] (03CR) 10CI reject: [V: 04-1] Fix type error when importing & id rather than name is present [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911955 (https://phabricator.wikimedia.org/T335384) (owner: 10Eileen) [01:22:01] (03CR) 10CI reject: [V: 04-1] Fix Organization import template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911956 (owner: 10Eileen) [01:24:52] (03PS2) 10Eileen: Fix Organization import template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911956 [01:25:35] ejegg: I'm close to having a fix for Melanie which I hope she can fix tomorrow - are you able to review it today if I can get it wrapped up? [01:27:34] (03CR) 10CI reject: [V: 04-1] Fix Organization import template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911956 (owner: 10Eileen) [01:33:31] (03PS3) 10Eileen: Fix Organization import template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911956 [01:41:44] (03PS4) 10Eileen: Fix type error when importing & id rather than name is present [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911955 (https://phabricator.wikimedia.org/T335384) [01:45:41] yep eileen, i'm working another couple of hours [01:45:54] ejegg: cool - just having a wee fight but close now [01:45:57] I think... [01:48:14] (03PS4) 10Eileen: Fix Organization import template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911956 [02:00:17] (03PS1) 10Eileen: Fix Organization import template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911958 [02:05:17] (03PS5) 10Eileen: Fix type error when importing & id rather than name is present [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911955 (https://phabricator.wikimedia.org/T335384) [02:05:28] (03PS6) 10Ejegg: Override all global prefixes for test setup [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/911336 [02:06:24] (03PS6) 10Ejegg: Ingenico disentanglement: clean up doPayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908670 (https://phabricator.wikimedia.org/T260725) [02:08:00] (03CR) 10CI reject: [V: 04-1] Ingenico disentanglement: clean up doPayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908670 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [02:18:52] ejegg: yay - they are passing now - best all tested together with a civibuild first cos the first 2 are just to support testing the last one [02:20:30] Also - I feel like you check this one out but didn't +2 it https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/911415 [02:38:49] ah yeah, i was curious what the script was supposed to do [02:38:58] and how the heck it ends up making the api call [02:39:12] but the page seems to work fine without it [02:39:21] and from the name it sounds like it's just cosmetic [02:40:00] (03CR) 10Ejegg: [C: 03+2] "re-applying the C+2 originally applied by cstone, to kick zuul" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/911336 (owner: 10Ejegg) [02:40:22] yeah - it's a theming tweak [02:40:24] (03PS2) 10Ejegg: Remove broken ajax/js call in shoreditch theme [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911415 (owner: 10Eileen) [02:40:32] (03CR) 10Ejegg: [C: 03+2] Remove broken ajax/js call in shoreditch theme [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911415 (owner: 10Eileen) [02:41:43] (03Merged) 10jenkins-bot: Override all global prefixes for test setup [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/911336 (owner: 10Ejegg) [02:47:56] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: clean dlocal submethods - https://phabricator.wikimedia.org/T335388 (10AnnWF) [02:48:56] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: clean dlocal submethods - https://phabricator.wikimedia.org/T335388 (10AnnWF) https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/911839 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/910611 [02:52:24] (03Merged) 10jenkins-bot: Remove broken ajax/js call in shoreditch theme [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911415 (owner: 10Eileen) [03:01:22] (03PS7) 10Ejegg: Ingenico disentanglement: clean up doPayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908670 (https://phabricator.wikimedia.org/T260725) [03:02:45] well, that's just passing the one test that needs the smashPig patch ^^^ [03:02:56] (03CR) 10CI reject: [V: 04-1] Ingenico disentanglement: clean up doPayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908670 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [03:09:10] (03PS4) 10Ejegg: Make test helpers more flexible [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911942 (https://phabricator.wikimedia.org/T335384) (owner: 10Eileen) [03:09:13] (03CR) 10Ejegg: [C: 03+2] Make test helpers more flexible [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911942 (https://phabricator.wikimedia.org/T335384) (owner: 10Eileen) [03:13:50] (03PS1) 10Eileen: Improve test contribution source data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911961 (https://phabricator.wikimedia.org/T334537) [03:20:40] (03Merged) 10jenkins-bot: Make test helpers more flexible [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911942 (https://phabricator.wikimedia.org/T335384) (owner: 10Eileen) [03:38:41] (03CR) 10Ejegg: "This is looking really good! I think we just need some error handling for the getBinInformation call because I'm getting a bunch of 'Uncau" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/910079 (https://phabricator.wikimedia.org/T334937) (owner: 10Wfan) [03:39:00] 10Fundraising-Backlog, 10Documentation: Document Audit processes - https://phabricator.wikimedia.org/T253052 (10Cstone) 05Open→03Resolved a:03Cstone We have audit documentation now: https://wikitech.wikimedia.org/wiki/Fundraising/Data_and_flow/Audits [03:40:14] (03Abandoned) 10Eileen: Fix Organization import template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911958 (owner: 10Eileen) [03:45:01] double gerrit id on that [03:45:42] oh shoot, is it the same as the non-abandoned one? I just rebuilt my civi with that one [03:45:45] diffing [03:46:33] ok, looks identical. phew [03:52:56] trying the fixed import template with the test csv file I get some date format errors - is that expected? [03:53:16] oh i see you have an 'improve test data' patch later [03:55:17] nope, that's contribution tracking data [03:56:01] ahh, is that what the change from dateFormats 2 to dateFormats 4 did? [03:56:17] i'm starting to lose my faith in the 4! [03:58:35] anyway... that's not changed in this patch, and the way you build the returned value looks easier to extend than the previous way [03:59:23] 10Fundraising-Backlog: Ingenico audit: donation from 11/1 not in Civi - https://phabricator.wikimedia.org/T150212 (10Cstone) 05Open→03Resolved a:03Cstone From 2016 [04:01:38] phab searches are nice ways to find things to close [04:01:44] cant find what i want [04:01:51] but i can find bugs from 2016 haha [04:01:56] (03PS5) 10Ejegg: Fix Organization import template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911956 (owner: 10Eileen) [04:02:00] (03CR) 10Ejegg: [C: 03+2] Fix Organization import template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911956 (owner: 10Eileen) [04:02:47] oh now I see the test date fix. nice [04:02:48] ejegg: yeah the abandonned one was the same patch - there were two change-ids on it [04:12:39] 10Fundraising-Backlog, 10FR-dlocal: Audit file frequency of new integration to Dlocal - https://phabricator.wikimedia.org/T324634 (10Cstone) We are getting a nightly audit file from dlocal that we process the next day at UTC 20. For example on 2023-04-25 at 20:00 we would process the file from 2023-04-24 [04:13:48] (03PS9) 10Ejegg: Enable CZ online banking for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904386 (https://phabricator.wikimedia.org/T328717) [04:14:32] (03Merged) 10jenkins-bot: Fix Organization import template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911956 (owner: 10Eileen) [04:15:49] (03PS6) 10Ejegg: Fix type error when importing & id rather than name is present [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911955 (https://phabricator.wikimedia.org/T335384) (owner: 10Eileen) [04:16:02] (03CR) 10Ejegg: [C: 03+2] Fix type error when importing & id rather than name is present [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911955 (https://phabricator.wikimedia.org/T335384) (owner: 10Eileen) [04:16:10] ok, I have to get to bed! [04:16:19] have a good rest of your day all [04:16:23] night ejegg [04:28:10] (03Merged) 10jenkins-bot: Fix type error when importing & id rather than name is present [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911955 (https://phabricator.wikimedia.org/T335384) (owner: 10Eileen) [04:52:55] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/911964 [04:53:13] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/911964 (owner: 10Eileen) [04:53:44] (03PS2) 10Eileen: Improve test contribution source data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911961 (https://phabricator.wikimedia.org/T334537) [04:54:18] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/911964 (owner: 10Eileen) [04:55:37] !log civicrm upgraded from 2bc9f372 to 601d223e [04:55:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [05:13:14] (03PS7) 10Eileen: Insert into new contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911422 (https://phabricator.wikimedia.org/T334537) [05:25:14] (03CR) 10CI reject: [V: 04-1] Insert into new contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911422 (https://phabricator.wikimedia.org/T334537) (owner: 10Eileen) [12:36:08] (03PS1) 10Damilare Adedoyin: Expose the ContributionTracking table in the View Contribution UI [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/912280 (https://phabricator.wikimedia.org/T334540) [12:36:19] (03CR) 10CI reject: [V: 04-1] Expose the ContributionTracking table in the View Contribution UI [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/912280 (https://phabricator.wikimedia.org/T334540) (owner: 10Damilare Adedoyin) [12:37:12] (03PS2) 10Damilare Adedoyin: Expose the ContributionTracking table in the View Contribution UI [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/912280 (https://phabricator.wikimedia.org/T334540) [12:45:18] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising-Backlog, 10Patch-For-Review: CT-to-Civi-Phase 1 - expose in the UI - https://phabricator.wikimedia.org/T334540 (10Damilare) So I finally figured the issue with the url filtering. It seems to be tied to the `html` tag description. Adding the... [14:59:14] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Make contribution tracking data visible in CiviCRM - https://phabricator.wikimedia.org/T158140 (10Damilare) a:03Damilare [15:00:31] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising-Backlog: CT-to-Civi-Phase 1.5 cleanup & update contribution_tracking documentation - https://phabricator.wikimedia.org/T334538 (10Damilare) a:03Damilare [15:14:19] (03CR) 10Ejegg: [C: 04-1] "Exciting to be at this point already! Some comments inline" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911422 (https://phabricator.wikimedia.org/T334537) (owner: 10Eileen) [15:19:02] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Don't retry DLocal API calls on http error 403 - https://phabricator.wikimedia.org/T335419 (10Ejegg) [15:25:05] (03CR) 10Ejegg: [C: 03+2] "Re-applying C+2 originally applied by Damilare, in order to trigger zuul" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904386 (https://phabricator.wikimedia.org/T328717) (owner: 10Ejegg) [15:26:38] (03PS12) 10Damilare Adedoyin: CT-to-Civi-Phase 1 Create a view to replace the drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) [15:27:23] (03Merged) 10jenkins-bot: Enable CZ online banking for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904386 (https://phabricator.wikimedia.org/T328717) (owner: 10Ejegg) [15:28:20] (03CR) 10Damilare Adedoyin: "Hi ejegg, thanks for the feedback on this patch. I've updated the sql to reflect the recommended changes." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) (owner: 10Damilare Adedoyin) [15:33:11] (03PS6) 10Ejegg: Use constant name for Adyen component container [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908307 [15:39:18] (03CR) 10CI reject: [V: 04-1] CT-to-Civi-Phase 1 Create a view to replace the drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) (owner: 10Damilare Adedoyin) [15:40:57] (03PS13) 10Damilare Adedoyin: CT-to-Civi-Phase 1 Create a view to replace the drupal table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/908904 (https://phabricator.wikimedia.org/T334535) [15:41:57] (03PS1) 10Ejegg: Specify 'paywithgoogle' integration type for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/912323 (https://phabricator.wikimedia.org/T334999) [15:56:01] (03PS1) 10Ejegg: Default to newer Adyen API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/912329 (https://phabricator.wikimedia.org/T334999) [15:56:28] (03CR) 10CI reject: [V: 04-1] Default to newer Adyen API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/912329 (https://phabricator.wikimedia.org/T334999) (owner: 10Ejegg) [16:05:16] (03PS2) 10Ejegg: Default to newer Adyen API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/912329 (https://phabricator.wikimedia.org/T334999) [16:07:00] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: clean dlocal submethods - https://phabricator.wikimedia.org/T335388 (10AnnWF) a:03AnnWF [16:07:51] (03PS5) 10Wfan: Add unit test and add ud to getPaymentMethodId [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904870 [16:07:53] (03PS14) 10Wfan: Add validate and collect part for direct bt [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/903690 (https://phabricator.wikimedia.org/T324294) [16:08:15] (03CR) 10CI reject: [V: 04-1] Add unit test and add ud to getPaymentMethodId [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904870 (owner: 10Wfan) [16:20:29] (03PS1) 10Wfan: Stop hardcoding payment_method=cc in SmashPig recurring donation messages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/912334 (https://phabricator.wikimedia.org/T334991) [16:25:35] 10Fundraising Sprint Highway to Hello World, 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising-Backlog: CT-to-Civi-Phase 2 Disable the module & delete the code - https://phabricator.wikimedia.org/T334543 (10AKanji-WMF) [16:25:37] 10Fundraising Sprint Highway to Hello World, 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising-Backlog: CT-to-Civi-Phase 2 - drop the interim drupal view - https://phabricator.wikimedia.org/T334542 (10AKanji-WMF) [16:41:41] damilare: I just realized we'll want a second view to replace the utm_source table once we stop populating that [17:06:18] ohh hmm, not sure I follow ejegg. So a separate view for only utm_source columns? [17:23:52] damilare: there are currently two tables that jmando pulls analytics data from: contribution_tracking and contribution_source [17:24:15] contribution_source is a table with the three parts of utm_source split out into different columns [17:24:35] so the view for that table would just be selecting banner, landing page, and payment method [17:25:16] ohh ok that makes sense [17:54:13] (03PS8) 10Ejegg: Ingenico disentanglement: clean up doPayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908670 (https://phabricator.wikimedia.org/T260725) [17:55:52] (03CR) 10CI reject: [V: 04-1] Ingenico disentanglement: clean up doPayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908670 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [17:56:21] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen audit wobble: 3/16 refunds & chargeback not in Civi - https://phabricator.wikimedia.org/T190594 (10Cstone) 05Open→03Resolved a:03Cstone From 2018 [17:57:08] ah right, just needs that smashpig patch to actually make it pass tests [17:58:30] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen audit file? chargeback from 1/11 not in Civi on 2/5 - https://phabricator.wikimedia.org/T244418 (10Cstone) 05Open→03Resolved a:03Cstone From 2020 [18:21:41] 10Fundraising-Backlog, 10fundraising-tech-ops: Fr-Tech 2022q4 maintenance window - https://phabricator.wikimedia.org/T333485 (10Dwisehaupt) [19:02:56] 10Fundraising-Backlog, 10FR-Ingenico: Ingenico audit-file 2020-03-09 question - https://phabricator.wikimedia.org/T247345 (10Cstone) 05Open→03Resolved a:03Cstone From 2020 [19:19:05] 10fundraising-tech-ops: reimage fundraising data (frdata) role servers to Bullseye - https://phabricator.wikimedia.org/T335446 (10Dwisehaupt) [19:28:25] 10fundraising-tech-ops: reimage fundraising data (frdata) role servers to Bullseye - https://phabricator.wikimedia.org/T335446 (10Dwisehaupt) [20:03:17] ok, back, but I guess everyone left the meeting. [20:04:46] cstone: did that let you test apple pay with the proxy? [20:05:25] yep ejegg ! [20:07:15] great! [21:15:34] (03PS9) 10Ejegg: Ingenico disentanglement: clean up doPayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908670 (https://phabricator.wikimedia.org/T260725) [21:15:36] (03PS1) 10Ejegg: Ingenico disentanglement: modern processDonorReturn [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/912374 (https://phabricator.wikimedia.org/T260725) [21:17:13] (03CR) 10CI reject: [V: 04-1] Ingenico disentanglement: clean up doPayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908670 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [21:17:16] (03CR) 10CI reject: [V: 04-1] Ingenico disentanglement: modern processDonorReturn [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/912374 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [21:18:43] ejegg: you were wrong to mistrust dateFormats 4 - now it seems 2 is preferred again :-) [21:19:10] (At this stage not updating the code because it can be managed in the UI but if I have to code update again I will switch back...) [21:19:36] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Make contribution tracking data visible in CiviCRM - https://phabricator.wikimedia.org/T158140 (10Damilare) The Contribution Tracking view is currently visible on production in https://civicrm.wikime... [21:32:30] shifty lil digits... [21:35:44] (03PS8) 10Eileen: Insert into new contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911422 (https://phabricator.wikimedia.org/T334537) [21:36:28] (03CR) 10Eileen: "I've addressed the comments & moved the handling into the extension. I still need to figure out the test..." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911422 (https://phabricator.wikimedia.org/T334537) (owner: 10Eileen) [21:43:08] (03PS9) 10Eileen: Insert into new contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911422 (https://phabricator.wikimedia.org/T334537) [21:54:52] (03CR) 10CI reject: [V: 04-1] Insert into new contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911422 (https://phabricator.wikimedia.org/T334537) (owner: 10Eileen) [21:56:57] 10Wikimedia-Fundraising-Banners, 10Wikipedia-iOS-App-Backlog, 10Patch-For-Review, 10iOS Release FY2022-23: Japan fundraising messages in iOS app - https://phabricator.wikimedia.org/T332229 (10Tsevener) 05Open→03Resolved [22:02:47] (03PS10) 10Eileen: Insert into new contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911422 (https://phabricator.wikimedia.org/T334537) [22:14:21] (03CR) 10CI reject: [V: 04-1] Insert into new contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911422 (https://phabricator.wikimedia.org/T334537) (owner: 10Eileen) [22:17:03] (03PS11) 10Eileen: Insert into new contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911422 (https://phabricator.wikimedia.org/T334537) [22:17:47] (03PS10) 10Ejegg: Ingenico disentanglement: clean up doPayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908670 (https://phabricator.wikimedia.org/T260725) [22:17:54] (03PS2) 10Ejegg: Ingenico disentanglement: modern processDonorReturn [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/912374 (https://phabricator.wikimedia.org/T260725) [22:18:06] whew, it's a slog to get all those tests adapted to the new way [22:18:36] gonna ride a bike for a lil bit and pick this back up from elsewhere [22:18:45] have a nice ride [22:19:32] (03CR) 10CI reject: [V: 04-1] Ingenico disentanglement: clean up doPayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/908670 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [22:19:44] (03CR) 10CI reject: [V: 04-1] Ingenico disentanglement: modern processDonorReturn [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/912374 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [22:24:48] (03PS12) 10Eileen: Insert into new contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911422 (https://phabricator.wikimedia.org/T334537) [22:27:51] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: MG Import - type error on organization id but no name - https://phabricator.wikimedia.org/T335384 (10AnnWF) https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/910617/ [22:37:26] (03CR) 10CI reject: [V: 04-1] Insert into new contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911422 (https://phabricator.wikimedia.org/T334537) (owner: 10Eileen) [22:49:12] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q3:rack/setup/install frav1003 - https://phabricator.wikimedia.org/T334400 (10Jclark-ctr) a:03Jclark-ctr [22:58:53] 10fundraising-tech-ops: reimage fundraising data (frdata) role servers to Bullseye - https://phabricator.wikimedia.org/T335446 (10Dwisehaupt) [23:11:27] (03PS6) 10Wfan: Add unit test and add ud to getPaymentMethodId [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904870 (https://phabricator.wikimedia.org/T324294) [23:23:04] (03PS13) 10Eileen: Insert into new contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911422 (https://phabricator.wikimedia.org/T334537) [23:26:16] (03PS14) 10Eileen: Insert into new contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911422 (https://phabricator.wikimedia.org/T334537) [23:30:59] (03PS15) 10Eileen: Insert into new contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911422 (https://phabricator.wikimedia.org/T334537) [23:35:13] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising-Backlog, 10Patch-For-Review: CT-to-Civi-Phase 1 - expose in the UI - https://phabricator.wikimedia.org/T334540 (10Eileenmcnaughton) Super cool - I gave it a go on staging & it works with the magic URL https://civicrm.frdev.wikimedia.org/c... [23:42:49] (03CR) 10CI reject: [V: 04-1] Insert into new contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/911422 (https://phabricator.wikimedia.org/T334537) (owner: 10Eileen)