[00:09:25] (03PS2) 10Eileen: WIP Add donor_segment_id field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/915854 [00:19:15] (03CR) 10CI reject: [V: 04-1] WIP Add donor_segment_id field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/915854 (owner: 10Eileen) [01:09:40] (03PS3) 10Eileen: WIP Add donor_segment_id field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/915854 [01:13:11] (03PS19) 10Wfan: Add validate and collect part for direct upi bt [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/903690 (https://phabricator.wikimedia.org/T324294) [01:13:15] (03CR) 10Wfan: Add validate and collect part for direct upi bt (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/903690 (https://phabricator.wikimedia.org/T324294) (owner: 10Wfan) [01:28:10] (03PS5) 10Wfan: Update trigger [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/915007 (https://phabricator.wikimedia.org/T332074) [01:33:38] (03CR) 10CI reject: [V: 04-1] Update trigger [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/915007 (https://phabricator.wikimedia.org/T332074) (owner: 10Wfan) [01:36:22] (03PS6) 10Wfan: Update trigger [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/915007 (https://phabricator.wikimedia.org/T332074) [01:44:47] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising-Backlog: Investigation: Scope Segmentation in Civi & Acoustic - https://phabricator.wikimedia.org/T335376 (10Eileenmcnaughton) I just did a timing to see how long it would take to update a value for every contact in the database on staging - t... [02:08:17] i just don't understand how this test was passing before... [02:11:12] ohhhh it's that sneaky batch processor flag [02:11:19] well we should get rid of that too [02:22:04] (03CR) 10Eileen: Update trigger (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/915007 (https://phabricator.wikimedia.org/T332074) (owner: 10Wfan) [02:27:32] (03PS7) 10Wfan: Update trigger [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/915007 (https://phabricator.wikimedia.org/T332074) [02:29:50] wfan - that patch works - stylistically I would remove the space between if ( and the & and use activityTypeID rather than activityTypeId - but those are non-blocking [02:31:34] (03CR) 10Eileen: [C: 03+2] Update trigger [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/915007 (https://phabricator.wikimedia.org/T332074) (owner: 10Wfan) [02:32:18] Ah, thanks eileen :) I will use ID next time :) if you like [02:32:39] wfan: yeah - we haven't super consolidated on it - but that is what I try to consolidate on [02:32:59] Noted 😊 [02:35:54] ejegg: we probably need to chat about this ops request for segmentation - where they are thinking seems like a daily query to update the segment field for every contact based on calculations -see https://phabricator.wikimedia.org/T335376#8828453 - we probably want to set up a meeting I guess [02:40:12] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Technical-Debt: Remove isBatchProcessor from DonationInterface - https://phabricator.wikimedia.org/T336024 (10Ejegg) [02:40:27] whew, daily segment recalculation??? [02:40:42] I figured it would just be recalculated on value update [02:41:03] but I guess if they're constantly fiddling with the rules that wouldn't work [02:41:43] oh i see, there are also sliding time windows to consider [02:41:45] whew [02:43:29] (03Merged) 10jenkins-bot: Update trigger [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/915007 (https://phabricator.wikimedia.org/T332074) (owner: 10Wfan) [02:43:44] eileen: so a lot of those segment definitions are based on last donation date, huh? [02:44:15] yeah - so they are basically combining value + activeness for a lot of them [02:45:04] I wonder if we could do a bunch of queries targeting those transitions, shifting donors who have just passed one timespan into the next segment [02:45:37] oh maybe [02:45:50] so on first donation they're automatically 'new' [02:46:05] I don't think I fully understand the criteria - eg. Major Gifts,lapsed - what does that actually mean? [02:46:09] then we don't update 'em till last_donation_date is just over 6 months [02:46:23] if you look at https://docs.google.com/spreadsheets/d/1qM36MeKWyOENl-iR5umuLph5HLHG6W_6c46xJUdE3QY/edit#gid=1274967475 [02:46:41] yeah, there's overlap there [02:47:07] I guess I don't know what cumulative annual giving means [02:47:18] lifetime giving to non-endowment? [02:47:51] on the 'definitions' tab they seem to have updated that to 'Cumulative giving in the calendar year' [02:47:59] so that's straight from wmf_donor [02:48:12] but it could overlap with 'new' for instance [02:48:19] so these seem more like tags [02:48:43] (03CR) 10Eileen: [C: 03+2] "I put this on staging & it worked - I had to revert the form. We might choose to refine the forms but now we can do them separately with r" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/914309 (https://phabricator.wikimedia.org/T335717) (owner: 10Damilare Adedoyin) [02:49:22] ejegg: I don't think it's tags - I think they want each person to be in exactly one segment - so the first one they fall into from the top [02:49:39] cumulative giving in which calendar year? [02:49:53] oh i assumed it meant current [02:49:58] Thanks for thinking about this eileen ejegg - I can set up a meeting with Ops next week if that helps - I think the initiative comes from Sheetal ultimately [02:49:59] so they'd all be blank on Jan 1 [02:50:18] anilk: yeah - I think that would be great [02:50:32] so a new $20,000 donor and a new $1 donor are both just 'New' [02:50:34] ? [02:51:10] Let's chat with Sheetal & get her to explain it & we can also try to highlight what might be doable without a daily downtime.... [02:52:16] maybe just a Jan 1 downtime... [02:52:37] on the phab she said they wanted the 12 months before the day the query ran.... [02:53:27] oh yeah, that'll be expensive [02:54:31] right & potentially especially expensive during December... [02:55:05] could try to be clever about it and recalculate individually on new donations, then recalculate daily batches based on 'all donors with a donation that just slipped out of the 12 month window' [02:55:46] yeah I think triggers for new donations would be part of the mix [02:57:21] gonna be a real beauty of a case statement [02:57:25] there are a bunch of windows in there - 6 months, 12, 24, [02:57:26] Is it once a Major Gifts always a major gifts - even if you only give $1 per year for the next 10 years - so someone who gave 10k once & $1 for 10 years would be Major Gifts Active - feels like that would miss the chance to upsell them [02:58:19] ejegg: I think if the data is already in wmf_donor it might not make performance any worse (cross fingers) - but it's hard with 35 categories to know if there are any easter eggs in there [02:59:06] ohhhh i was just looking at the definitions tab, now I see the amount-based and the time-based are crossed with each other [02:59:09] whew [02:59:43] also this term "cumulative annual giving" really confuses me - cumulative withing a year or everything except endowment giving (in which case do we not recognise endowment at all in these critieria?) [03:00:08] and then this "Cumulative annual giving should be in the time frame specified " - huh? [03:00:33] yeah... that's unhelpful [03:01:04] (03Merged) 10jenkins-bot: ContributionTracking form - split into 2 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/914309 (https://phabricator.wikimedia.org/T335717) (owner: 10Damilare Adedoyin) [03:01:36] so in any case we would want to be able to do some queries specifically on the replica - I forget if the core team was going to make that a thing in core [03:02:24] looks like executeQuery has an options field [03:02:26] well it's tricky - cos you might do the SELECT on the replica - but then you need to do updates or create a temp table based on those... [03:03:29] oh i see, those are passed right to the pdo object [03:04:22] huh, i guess there's potential for mistagging if we hold lists in memory and do the update in a separate connection [03:04:40] yeah - if we are doing SELECT then process in php to insert then that would be non-locking [03:04:59] but yeah - might have to batch? [03:06:23] ini_set( 'memory_limit', '256 GB' ) [03:06:33] if we were updating by trigger on NEW then the script could just run in batches around the clock [03:12:08] maybe we could use redis - like the prevnext cache does [03:12:17] select from read only into there & process from there [03:17:00] (03PS4) 10Ejegg: WIP: Delete GlobalCollect [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/913977 (https://phabricator.wikimedia.org/T260725) [03:18:41] (03CR) 10CI reject: [V: 04-1] WIP: Delete GlobalCollect [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/913977 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [03:24:09] (03PS5) 10Ejegg: WIP: Delete GlobalCollect [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/913977 (https://phabricator.wikimedia.org/T260725) [03:24:40] chipping away at those errors. [03:24:56] still need to set up a whole bunch of mockery for a few tests [03:25:42] since i'm trying not to use the 'TestingAdapter' classes [03:25:47] (03CR) 10CI reject: [V: 04-1] WIP: Delete GlobalCollect [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/913977 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [03:30:33] (03PS6) 10Ejegg: WIP: Delete GlobalCollect [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/913977 (https://phabricator.wikimedia.org/T260725) [03:31:14] dang, i need to get to bed [03:31:23] well, guess I'll finish next week [03:31:31] have a good weekend eileen [03:32:09] (03CR) 10CI reject: [V: 04-1] WIP: Delete GlobalCollect [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/913977 (https://phabricator.wikimedia.org/T260725) (owner: 10Ejegg) [03:36:52] oh hey, you fixed the test scanner thing! And unearthed some test failures... [03:36:56] congrats [05:00:30] (03CR) 10CI reject: [V: 04-1] build: Updating eslint-config-wikimedia to 0.25.0 [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/916041 (owner: 10Libraryupgrader) [08:45:32] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/916210 (owner: 10L10n-bot) [09:02:35] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/916210 (owner: 10L10n-bot) [12:19:16] (03CR) 10Damilare Adedoyin: [C: 03+2] Remove unused EncodingMangler class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/915735 (owner: 10Ejegg) [12:35:09] (03Merged) 10jenkins-bot: Remove unused EncodingMangler class [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/915735 (owner: 10Ejegg) [15:42:47] (03PS1) 10Pcoombe: Remove country name messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/916520 [16:07:06] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising-Backlog: Remove code references to old contribution tracking from wmf_audit_get_contribution_tracking_data - https://phabricator.wikimedia.org/T335711 (10Cstone) a:03Cstone [16:09:49] 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog: India fundraising messages in Android app - https://phabricator.wikimedia.org/T335918 (10Pcoombe) [16:09:57] 10Wikimedia-Fundraising-Banners, 10Wikipedia-iOS-App-Backlog: India fundraising messages in iOS app - https://phabricator.wikimedia.org/T335919 (10Pcoombe) [17:39:42] (03CR) 10Wfan: [C: 03+2] "LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/914035 (https://phabricator.wikimedia.org/T324347) (owner: 10Cstone) [17:51:52] (03Merged) 10jenkins-bot: Change the log directory for the astropay audit to dlocal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/914035 (https://phabricator.wikimedia.org/T324347) (owner: 10Cstone) [17:57:38] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Update triggers to not save details for thank you letters - https://phabricator.wikimedia.org/T332074 (10AnnWF) @Dwisehaupt Hi Dallas, we are ready to update the trigger, and wh... [17:58:59] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-WMF-Audit: wmf_audit: get rid of 'test' and 'fakedb' options - https://phabricator.wikimedia.org/T187501 (10Cstone) a:03Cstone [18:00:56] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Update triggers to not save details for thank you letters - https://phabricator.wikimedia.org/T332074 (10Dwisehaupt) @AnnWF Sure thing, do we have a civi maintenance period plan... [18:01:40] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops, 10Patch-For-Review: Update triggers to not save details for thank you letters - https://phabricator.wikimedia.org/T332074 (10Dwisehaupt) [18:31:23] 10fundraising-tech-ops: Puppet CA certificate kafka_fundraising_client will expire soon - https://phabricator.wikimedia.org/T335667 (10Jgreen) I just reread the cergen documentation, and I believe what we need to do is: **On puppetmaster1001:** **Remove/revoke the old certificate from the puppet CA** `puppet c... [18:33:07] 10fundraising-tech-ops: Puppet CA certificate kafka_fundraising_client will expire soon - https://phabricator.wikimedia.org/T335667 (10Jgreen) [18:33:09] 10fundraising-tech-ops, 10Observability-Alerting: Puppet CA certificate kafka_fundraising_client is about to expire - https://phabricator.wikimedia.org/T335768 (10Jgreen) [18:33:25] 10fundraising-tech-ops: Puppet CA certificate kafka_fundraising_client will expire soon - https://phabricator.wikimedia.org/T335667 (10Jgreen) p:05Medium→03High [18:54:07] (03CR) 10Cstone: [C: 03+2] "thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/915816 (https://phabricator.wikimedia.org/T335992) (owner: 10Wfan) [18:54:38] Thanks Christine :) [18:54:42] 10fundraising-tech-ops: Q3:rack/setup/install frbast2002, frauth2002 - https://phabricator.wikimedia.org/T334505 (10Dwisehaupt) [18:56:43] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops, 10Patch-For-Review: Update triggers to not save details for thank you letters - https://phabricator.wikimedia.org/T332074 (10AnnWF) >>! In T332074#8830334, @Dwisehaupt wro... [19:06:35] (03Merged) 10jenkins-bot: Update the notification box position when toolbar been toggled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/915816 (https://phabricator.wikimedia.org/T335992) (owner: 10Wfan) [19:07:52] (03CR) 10Cstone: [C: 03+2] "Looks good, thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/903690 (https://phabricator.wikimedia.org/T324294) (owner: 10Wfan) [19:08:31] (03Merged) 10jenkins-bot: Add validate and collect part for direct upi bt [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/903690 (https://phabricator.wikimedia.org/T324294) (owner: 10Wfan) [19:09:10] (03CR) 10Damilare Adedoyin: [C: 03+2] Delete a couple of unused payment methods from mapper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910114 (owner: 10Ejegg) [19:21:48] (03Merged) 10jenkins-bot: Delete a couple of unused payment methods from mapper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910114 (owner: 10Ejegg) [20:41:52] (03PS1) 10Umherirrender: Fix casing for Mediawiki\Extension\LandingCheck namespace [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/916613 [21:16:57] (03CR) 10DannyS712: [C: 03+2] Fix casing for Mediawiki\Extension\LandingCheck namespace [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/916613 (owner: 10Umherirrender) [21:52:00] (03Merged) 10jenkins-bot: Fix casing for Mediawiki\Extension\LandingCheck namespace [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/916613 (owner: 10Umherirrender)