[00:27:37] (03PS2) 10Eileen: Add render test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/917960 [00:46:17] (03PS1) 10Eileen: Add additional currencies to examples [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/917969 (https://phabricator.wikimedia.org/T309349) [01:22:47] (03PS2) 10Ejegg: Validation error instead of failmail for bad CPF [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/917946 (https://phabricator.wikimedia.org/T336209) [01:23:13] (03CR) 10CI reject: [V: 04-1] Validation error instead of failmail for bad CPF [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/917946 (https://phabricator.wikimedia.org/T336209) (owner: 10Ejegg) [01:24:35] (03PS3) 10Ejegg: Validation error instead of failmail for bad CPF [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/917946 (https://phabricator.wikimedia.org/T336209) [01:32:09] (03PS4) 10Ejegg: Validation error instead of failmail for bad CPF [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/917946 (https://phabricator.wikimedia.org/T336209) [01:35:16] well, I guess I'm going to deploy that Ingenico change tomorrow and not today [01:36:29] (03PS1) 10Ejegg: Move TokenizaRecurringJob to Jobs folder [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/917975 [01:38:16] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal, and 2 others: Don't send failmail on invalid Dlocal fiscal number errors - https://phabricator.wikimedia.org/T336209 (10Ejegg) [01:44:54] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: email addresses in Adyen recurring donor name fields - https://phabricator.wikimedia.org/T326986 (10Ejegg) So the one I found just lately was a GPay recurring. It didn't get a token from the front end for some reason, so the initial... [01:50:40] (03PS1) 10Ejegg: Reformat dlocal test file [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917982 [01:52:17] (03CR) 10CI reject: [V: 04-1] Reformat dlocal test file [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917982 (owner: 10Ejegg) [02:03:44] (03PS2) 10Ejegg: Move TokenizaRecurringJob to Jobs folder [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/917975 [02:04:53] (03PS2) 10Ejegg: Reformat dlocal test file [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917982 [02:05:56] (03PS1) 10Ejegg: Add test for dlocal ValidationError [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917985 (https://phabricator.wikimedia.org/T336209) [02:29:08] (03PS1) 10Ejegg: Add type hints to PaymentResult [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917989 [02:29:36] (03PS1) 10Ejegg: Fix fiscal_number ValidationError message [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917990 (https://phabricator.wikimedia.org/T336209) [02:37:50] (03PS3) 10Ejegg: Move TokenizeRecurringJob to Jobs namespace [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/917975 [02:39:11] (03PS4) 10Ejegg: Move TokenizeRecurringJob to Jobs namespace [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/917975 [02:43:20] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal, and 2 others: Don't send failmail on invalid Dlocal fiscal number errors - https://phabricator.wikimedia.org/T336209 (10Ejegg) I was testing these by cloning the SmashPig patch into the payments vendor directory, then tryin... [04:16:06] (03PS1) 10Eileen: Switch Rendering to use the core function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/917996 [04:23:21] (03Abandoned) 10Eileen: Add test for Render code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/917961 (https://phabricator.wikimedia.org/T309349) (owner: 10Eileen) [04:24:22] (03Abandoned) 10Eileen: Render-wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/915031 (owner: 10Eileen) [04:25:13] (03Abandoned) 10Eileen: Remove some payment instruments that are not used [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910608 (owner: 10Eileen) [04:26:26] (03Abandoned) 10Eileen: Change name fields for the ones that we hit on tracking convert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910614 (https://phabricator.wikimedia.org/T334534) (owner: 10Eileen) [04:28:36] (03CR) 10CI reject: [V: 04-1] Switch Rendering to use the core function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/917996 (owner: 10Eileen) [04:36:45] (03PS2) 10Eileen: Update PaymentIntruments Managed file to name=>label [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910612 (https://phabricator.wikimedia.org/T334534) [04:38:04] (03PS3) 10Eileen: Update PaymentIntruments Managed file to name=>label [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910612 (https://phabricator.wikimedia.org/T334534) [05:16:18] (03PS1) 10Eileen: Use more realistic payment methods to reduce test noise [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918003 [05:28:56] (03CR) 10CI reject: [V: 04-1] Use more realistic payment methods to reduce test noise [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918003 (owner: 10Eileen) [05:33:36] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/918040 (owner: 10L10n-bot) [07:14:31] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/918040 (owner: 10L10n-bot) [12:04:00] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Don't retry DLocal API calls on http error 403 - https://phabricator.wikimedia.org/T335419 (10Damilare) a:03Damilare [13:55:33] (03PS1) 10Damilare Adedoyin: Don't retry DLocal API calls on http error 403 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/918485 (https://phabricator.wikimedia.org/T335419) [13:56:02] (03CR) 10CI reject: [V: 04-1] Don't retry DLocal API calls on http error 403 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/918485 (https://phabricator.wikimedia.org/T335419) (owner: 10Damilare Adedoyin) [13:56:41] (03PS2) 10Damilare Adedoyin: Don't retry DLocal API calls on http error 403 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/918485 (https://phabricator.wikimedia.org/T335419) [15:33:06] anyone else getting "token not found" error on dlocal BR locally [15:34:21] that is CC payment method I mean [15:38:07] oh ok looks like the smartfields key in config private was just different [15:44:44] damilare: oh man, and that's the error they give you? Confusing! [15:45:52] yhh [15:46:45] ah yeah it is a confusing error, I think the config private stuff is still looking at the test account? [15:46:52] quite misleading, is the smartfield key say for everyone [15:46:57] same** [15:47:14] oh is that it. Lemme update that then [15:48:46] cool, just updated it. Thanks for spotting that cstone [15:53:50] (03CR) 10Ejegg: [C: 04-1] "We would need to check before we charge, in the SmashPigRecurringProcessor - not at the point of importing the message into Civi in the Re" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910615 (https://phabricator.wikimedia.org/T335152) (owner: 10Wfan) [15:56:49] (03CR) 10Ejegg: [C: 04-1] "Looking pretty close! Can you add a default value for the new setting to main.yaml, and consult the member variable in the lookup function" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/910611 (https://phabricator.wikimedia.org/T335388) (owner: 10Wfan) [15:59:20] (03CR) 10Cstone: [C: 03+2] "Thanks for adding these tests!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904870 (https://phabricator.wikimedia.org/T324294) (owner: 10Wfan) [16:00:21] Thanks Christine:) [16:02:30] (03Merged) 10jenkins-bot: Add unit test and add ud to getPaymentMethodId [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/904870 (https://phabricator.wikimedia.org/T324294) (owner: 10Wfan) [16:31:03] now I have to listen to some Screaming Lord Sutch [16:31:39] jgleeson: since you're reviewing the ejegg's smashpig patch, I'd move ahead to review the DI part of it but would't +2 till yours is merged [16:32:09] damilare: if you were looking at it feel free to +2 it [16:32:45] do you mean the smashpig patch? [16:33:24] yeah [16:33:26] brb [16:35:05] cool tnx [16:41:30] back [17:03:33] (03CR) 10Damilare Adedoyin: [C: 03+2] Validation error instead of failmail for bad CPF (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/917946 (https://phabricator.wikimedia.org/T336209) (owner: 10Ejegg) [17:04:27] thanks damilare! [17:04:55] (03Merged) 10jenkins-bot: Validation error instead of failmail for bad CPF [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/917946 (https://phabricator.wikimedia.org/T336209) (owner: 10Ejegg) [17:05:05] thanks ejegg for working on that and including the test instructions [17:33:58] fr-tech did anyone else want to be invited to the meeting about the recurring upgrade form? [17:34:36] sure ejegg [17:43:49] ok, added [17:50:36] 10fundraising-tech-ops, 10Infrastructure Security, 10Infrastructure-Foundations, 10SRE, 10SRE-Access-Requests: As an FR-Tech SRE, we want to be able to designate a host for decommissioning - https://phabricator.wikimedia.org/T334154 (10Dwisehaupt) Thanks! I have verified that I can ssh to the puppetmaste... [17:53:43] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/918576 [17:53:47] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/918576 (owner: 10Ejegg) [17:54:37] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/918576 (owner: 10Ejegg) [17:55:06] oh boy... getting jitters before this deploy [17:58:29] well, I guess it can wait till after the meeting [18:12:55] (03PS4) 10Wfan: Add missing submethods pair for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/910611 (https://phabricator.wikimedia.org/T335388) [18:13:24] (03CR) 10CI reject: [V: 04-1] Add missing submethods pair for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/910611 (https://phabricator.wikimedia.org/T335388) (owner: 10Wfan) [18:16:43] (03PS5) 10Wfan: Add missing submethods pair for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/910611 (https://phabricator.wikimedia.org/T335388) [18:21:31] (03CR) 10Damilare Adedoyin: [C: 03+2] Fix fiscal_number ValidationError message [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917990 (https://phabricator.wikimedia.org/T336209) (owner: 10Ejegg) [18:21:56] (03CR) 10Damilare Adedoyin: [C: 03+2] Add test for dlocal ValidationError [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917985 (https://phabricator.wikimedia.org/T336209) (owner: 10Ejegg) [18:33:36] thanks again damilare ! [18:33:57] ok, gonna go inside to charge and do this DI deploiy [18:34:19] * ejegg hopes he cut the right wires [18:42:19] (03PS1) 10Ejegg: Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/918588 [18:42:25] (03CR) 10Ejegg: [C: 03+2] Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/918588 (owner: 10Ejegg) [18:43:49] !log payments-wiki upgraded from ec5a5e92 to 2125cea7 [18:43:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:45:40] test donation worked, logs look ok! [18:46:13] oops, the 'Redirecting for transaction' line is there twice [18:46:30] let's see [18:50:15] (03Merged) 10jenkins-bot: Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/918588 (owner: 10Ejegg) [19:02:41] (03PS1) 10Ejegg: Just log 'Redirect for transaction' once [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/918590 [19:05:07] 10fundraising-tech-ops, 10Infrastructure Security, 10Infrastructure-Foundations, 10SRE, 10SRE-Access-Requests: As an FR-Tech SRE, we want to be able to designate a host for decommissioning - https://phabricator.wikimedia.org/T334154 (10Dzahn) 05In progress→03Resolved Ok, thank you! Cool. At this poin... [19:07:05] 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Enable sending Civi contact checksums in Acoustic emails - https://phabricator.wikimedia.org/T333182 (10AnnWF) [19:11:09] (03CR) 10Jgleeson: [C: 03+2] "LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/918590 (owner: 10Ejegg) [19:27:56] (03Merged) 10jenkins-bot: Just log 'Redirect for transaction' once [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/918590 (owner: 10Ejegg) [19:51:35] 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Enable sending Civi contact checksums in Acoustic emails - https://phabricator.wikimedia.org/T333182 (10AnnWF) [20:06:16] 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Enable sending Civi contact checksums in Acoustic emails - https://phabricator.wikimedia.org/T333182 (10jgleeson) From tech-talk ` SELECT CONCAT(MD5(CONCAT(hash, '_', id, '_', UNIX_TI... [20:16:25] thanks for figuring out that query, jgleeson ! [20:17:16] (03CR) 10Ejegg: [C: 03+2] Reformat dlocal test file [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917982 (owner: 10Ejegg) [20:17:23] (03PS3) 10Ejegg: Reformat dlocal test file [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917982 [20:17:27] (03PS2) 10Ejegg: Add test for dlocal ValidationError [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917985 (https://phabricator.wikimedia.org/T336209) [20:17:29] (03CR) 10CI reject: [V: 04-1] Add test for dlocal ValidationError [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917985 (https://phabricator.wikimedia.org/T336209) (owner: 10Ejegg) [20:17:31] (03CR) 10CI reject: [V: 04-1] Fix fiscal_number ValidationError message [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917990 (https://phabricator.wikimedia.org/T336209) (owner: 10Ejegg) [20:17:33] (03PS2) 10Ejegg: Fix fiscal_number ValidationError message [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917990 (https://phabricator.wikimedia.org/T336209) [20:22:53] (03CR) 10Ejegg: [C: 03+2] Reformat dlocal test file [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917982 (owner: 10Ejegg) [20:24:40] (03Merged) 10jenkins-bot: Reformat dlocal test file [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917982 (owner: 10Ejegg) [20:24:42] (03Merged) 10jenkins-bot: Add test for dlocal ValidationError [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917985 (https://phabricator.wikimedia.org/T336209) (owner: 10Ejegg) [20:26:17] (03Merged) 10jenkins-bot: Fix fiscal_number ValidationError message [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917990 (https://phabricator.wikimedia.org/T336209) (owner: 10Ejegg) [20:30:00] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/918596 [20:30:02] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/918596 (owner: 10Ejegg) [20:30:37] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/918596 (owner: 10Ejegg) [20:52:12] 10Fundraising-Backlog: Handle Adyen refund IPNs - https://phabricator.wikimedia.org/T336439 (10Cstone) [20:52:48] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: adjust audit to catch Adyen script refunds? - https://phabricator.wikimedia.org/T334503 (10Cstone) ^ with the info Adyen sent back I created this ticket to handle refund ipns {T336439} This should hopefully get them into civi faster [20:58:36] !log payments-wiki upgraded from 2125cea7 to d1c5fefc [20:58:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:21:34] woo, just got the better message from a bad CPF on prod [21:22:06] nice ejegg [21:22:45] mbeat noticed some duplicates and is making a phab with them looks like a triple click type situation (not thats what happened but) separate Ids on dlocals end but the 3 of them same id on our end [21:26:27] ohh [21:27:03] dang, let's see if we're actually disabling the button after one click [21:29:46] oh wait, there was a failmail too still! [21:29:49] dang it [21:30:32] where do we send that then? [21:32:43] phooey, all the way down in the HttpStatusValidator [21:33:05] so we need to use a different subclass of that for dlocal [21:34:46] ok, back on the triple-click thing, we ARE disabling the card form when someone clicks Donate [21:39:57] 10Fundraising-Backlog, 10FR-dlocal, 10fr-donorservices: duplicate dLocal donations May 9th - https://phabricator.wikimedia.org/T336444 (10MBeat33) [21:40:49] 10Fundraising-Backlog, 10FR-dlocal, 10fr-donorservices: duplicate dLocal donations May 9th - https://phabricator.wikimedia.org/T336444 (10MBeat33) [21:44:52] (03PS1) 10Ejegg: Move Ingenico-specific code into Ingenco subclass [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/918601 [22:09:23] huh cstone, I looked at the logs because I was afraid our API retry logic might have made those dupes, but nope, it really does show three full requests within two seconds. [22:09:44] using the MS Edge browser I guess [22:10:16] ah hah one of those then! [22:10:22] Could our disablement overlay maybe not work on that one? [22:10:41] Suppose I could download an MS virtual machine to test [22:11:30] hah i can test on my windows box ejegg [22:12:44] 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 10fr-donorservices: Create new activity types for recurring upgrade accept / decline - https://phabricator.wikimedia.org/T335908 (10Ejegg) a:03Ejegg [22:19:02] heh, that would probably be faster [22:19:48] I guess you can set a breakpoint on your linux box to make it take its time responding, then hit it from your win box over the proxy? [22:24:35] just finished eating I'll try that ejegg [22:24:59] storms went right east of me local news has people just driving around haha [22:26:52] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10MediaWiki-extensions-DonationInterface, 10Technical-Debt: Convert PayPal EC adapter to use SmashPig for API calls - https://phabricator.wikimedia.org/T336449 (10Ejegg) [22:27:11] whew cstone [22:28:17] XenoRyet: this is the ticket to convert the PayPal adapter to move its business logic to SmashPig: https://phabricator.wikimedia.org/T336449 [22:32:01] hmm ejegg i was able to click 3 times but also in chrome [22:32:16] 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 10fr-donorservices: Create new activity types for recurring upgrade accept / decline - https://phabricator.wikimedia.org/T335908 (10Ejegg) [22:32:44] er make three donations [22:33:10] 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog, 10Recurring-Donations, 10fr-donorservices, 10FR-Email: Indicate in Acoustic export if a donor is eligible for monthly upgrade - https://phabricator.wikimedia.org/T335824 (10Ejegg) [22:33:49] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 10fr-donorservices: Update RecurringQueueConsumer to handle donation upgrades - https://phabricator.wikimedia.org/T335827 (10Ejegg) [22:34:23] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 10fr-donorservices: Update RecurringQueueConsumer to handle donation upgrade declines - https://phabricator.wikimedia.org/T335876 (10Ejegg) [22:35:02] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 10fr-donorservices: Update RecurringQueueConsumer to handle donation upgrade declines - https://phabricator.wikimedia.org/T335876 (10Ejegg) [22:35:30] 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog, 10Recurring-Donations, 10fr-donorservices, 10FR-Email: Indicate in Acoustic export if a donor is eligible for monthly upgrade - https://phabricator.wikimedia.org/T335824 (10Ejegg) [22:42:36] oh wow cstone, in chrome too! [22:42:46] ok, let's see if we can fix that overlay [22:42:54] (03PS2) 10Eileen: Use more realistic payment methods to reduce test noise [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918003 [22:43:02] were you able to replicate it ejegg ? i was just clicking as fast as i could on the donate button [22:45:26] (03PS3) 10Eileen: Add render test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/917960 [22:45:28] (03PS2) 10Eileen: Add additional currencies to examples [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/917969 (https://phabricator.wikimedia.org/T309349) [22:45:30] (03PS2) 10Eileen: Switch Rendering to use the core function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/917996 [22:46:04] ah no, i wasn't trying to click fast, I just was checking to see that the overlay popped up and stayed up till we returned from the server call [22:46:35] so I guess we could disable the click event too [22:46:58] as long as we're able to re-enable it in case of a validation error [22:54:26] (03PS1) 10Ejegg: Add new activity types for Recurring Upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918609 (https://phabricator.wikimedia.org/T335908) [22:57:42] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Do more to prevent multiple clicks of donate button - https://phabricator.wikimedia.org/T336455 (10Ejegg) [22:57:53] cstone there's a ticket for it ^^^ [22:58:10] I guess it should get a chaos tag [22:58:27] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Do more to prevent multiple clicks of donate button - https://phabricator.wikimedia.org/T336455 (10Ejegg) [22:59:24] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Do more to prevent multiple clicks of donate button - https://phabricator.wikimedia.org/T336455 (10Ejegg) See @MBeat33's report of duplicate dlocal donations: T336444 [22:59:50] ok, gonna relocate then I'll look at making another patch to really and truly quiet down that CPF failmail. [23:25:24] (03CR) 10Eileen: "I guess we didn't do it last activity but it would be kinda good to prefer more machine-link 'name' values - ie recurring_upgrade over Rec" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918609 (https://phabricator.wikimedia.org/T335908) (owner: 10Ejegg)