[05:42:47] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/919495 (owner: 10L10n-bot) [06:36:52] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919665 (owner: 10L10n-bot) [07:01:21] (03PS2) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919665 (owner: 10L10n-bot) [07:02:09] (03CR) 10Raimond Spekking: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919665 (owner: 10L10n-bot) [07:04:05] (03CR) 10Raimond Spekking: [C: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919665 (owner: 10L10n-bot) [12:46:25] (03PS4) 10Damilare Adedoyin: Do more to prevent multiple clicks of donate button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919326 (https://phabricator.wikimedia.org/T336455) [12:48:49] (03CR) 10CI reject: [V: 04-1] Do more to prevent multiple clicks of donate button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919326 (https://phabricator.wikimedia.org/T336455) (owner: 10Damilare Adedoyin) [12:50:25] (03PS5) 10Damilare Adedoyin: Do more to prevent multiple clicks of donate button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919326 (https://phabricator.wikimedia.org/T336455) [13:05:39] 10Fundraising-Backlog: Move some logic from the GatewayAdapter class to DonationData class - https://phabricator.wikimedia.org/T336667 (10Damilare) [13:08:39] (03CR) 10Damilare Adedoyin: [C: 03+1] "Thanks for rebasing wfan, looks good. One last thing 😊" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/876044 (https://phabricator.wikimedia.org/T140269) (owner: 10Wfan) [13:34:38] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Expose email-prefs-wiki to public - https://phabricator.wikimedia.org/T335793 (10DBu-WMF) I would remove "email" and "donors" from the subdomain because those words may create privacy concerns and potentially cyber attacks. I would recommend... [14:06:57] (03CR) 10Damilare Adedoyin: [C: 03+2] Use new mediawiki-apache2 image for email-pref-ctr [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/900745 (https://phabricator.wikimedia.org/T336541) (owner: 10Wfan) [14:07:07] (03CR) 10Damilare Adedoyin: [V: 03+2 C: 03+2] Use new mediawiki-apache2 image for email-pref-ctr [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/900745 (https://phabricator.wikimedia.org/T336541) (owner: 10Wfan) [14:09:24] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: globalcollect_gateway: should be replace to ingenico, needs replace the campaign link - https://phabricator.wikimedia.org/T334773 (10Damilare) @AnnWF is there any other action to be done on this task given @Pcoombe last comment? [14:44:31] (03PS1) 10Ejegg: Ignore CaptureFailed IPNs from Adyen [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/919855 [14:52:11] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [14:57:11] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [15:02:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [15:07:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [15:12:14] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [15:17:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [15:22:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [15:27:14] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [15:32:14] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [15:37:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [15:42:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [15:47:14] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [15:52:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [15:57:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [16:02:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [16:07:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [16:12:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [16:15:52] fr-tech I just pushed up some cleanup patches to the settings repo on frpm [16:16:25] no rush to deploy them but it'd be nice to get another pair of eyes on them [16:17:14] RECOVERY - check_mysql on frdb2003 is OK: Uptime: 1101854 Threads: 4 Questions: 226766719 Slow queries: 443 Opens: 5939 Open tables: 1806 Queries per second avg: 205.804 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [16:18:50] looking ejegg [16:20:04] that's a good list of changes [16:20:59] thanks jgleeson! [16:24:58] gonna go get some lunch [16:25:50] 293521f156bd37172c28794c0cc72d56bf32ff6e - good [16:33:56] 1c3b795c69c9ab74725e370fc44dc140ac667e94 - that's a huge patch ejegg|food so I'm less confident about +2in that after just scanning the diff even though it mostly looks fine. I guess if it's a copy of what's running live then that's a good enough vote of confidence. However, I noticed some banner impression jobs that were removed which I was curious about and there's also a specific report job [16:33:58] that refers to Pats which I'm guessing we might not need anymore. [16:40:28] 6e5fc8e7a808e63703cd1bdb1fe57e934a625cb9 - also a tad scary to +2 just in case anything is depending on those ancient settings. I can see us dropping '$wgGlobalCollectGatewayAvsMap' over '$fraudCountryMap' but I can't see that array in the diff. Did we define that earlier? [16:40:35] also going for food! [18:09:37] jgleeson: oh yeah, I think we don't actually use the three different capture queues for adyen either, so those jobs could use some further cleaning [18:10:22] I just was seeing some super-old stuff in the civi2001 directory when I was looking for globalcollect all through settings so I figured I would at least just bring it up to date [18:11:07] so for the payments-wiki settings there were only two of them that had us assigning the globalcollect one to another variable [18:11:16] those were the two filterfunctions things [18:11:34] and so it was easy enough to just directly assign those to the ingenico variable [18:12:03] the fraudCountryMap is still defined just the same way as it was before this patch [18:12:37] we assign that to at least a few different gateway-specific countrymap settings [18:13:21] i guess we should review whether that should just be defined at the $wgDonationInterface level or if there is really some benefit in having the gateway-specific vars [18:13:52] but the current change I think should not change effective settings for any other gateway [18:21:40] hmm [18:21:55] and the pats thing? [18:22:16] oh right, that's another process-control job that looks obsolete? [18:22:18] checking... [18:23:16] oh look, there are 2 jobs with Pats' name in them [18:24:31] jgleeson: following the link in those yamls to the civi page configuring the reports, it seems they are now going to spatton and emartin [18:24:42] so I guess someone is still getting them, whether or not they are reading them! [18:24:58] ah cool [18:25:00] looks like they would be useful for reconciliation [18:25:26] I could update the process-control yaml [18:28:12] ok, I updated those descriptions [18:43:26] (03PS4) 10Ejegg: Consolidate handling on contribution tags in ThankYou [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918621 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [18:43:41] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918621 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [18:56:36] (03Merged) 10jenkins-bot: Consolidate handling on contribution tags in ThankYou [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918621 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [19:11:03] (03Abandoned) 10Ejegg: DO NOT MERGE: paymentMethodResponse for testing CZ bt [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/904657 (https://phabricator.wikimedia.org/T328717) (owner: 10Ejegg) [19:17:47] (03PS3) 10Wfan: Check recurring if have cancel date before charge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910615 (https://phabricator.wikimedia.org/T335152) [19:29:40] lgtm ejegg. thanks [19:29:56] thank you [19:44:53] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Expose email-prefs-wiki to public - https://phabricator.wikimedia.org/T335793 (10AKanji-WMF) Thanks @DBu-WMF - we want to land on something that is somewhat specific to fundraising (e.g. preferences.wikimedia.org could be for editor preferen... [19:51:40] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog: CT-to-Civi-Phase 1.5 - Update code references to contribution_tracking - https://phabricator.wikimedia.org/T334537 (10Eileenmcnaughton) [19:58:17] (03PS2) 10Eileen: Minor cleanup - CRM_Core_Exception is an alias for api exception now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918997 [20:02:13] (03PS5) 10Eileen: Switch rendering to use the core function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918623 (https://phabricator.wikimedia.org/T325698) [20:03:18] (03PS4) 10Eileen: Add preview to thank you message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918998 (https://phabricator.wikimedia.org/T325698) [20:03:54] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, and 2 others: "Order id is duplicated" error from dlocal - https://phabricator.wikimedia.org/T334905 (10AKanji-WMF) [20:12:31] (03PS6) 10Eileen: Switch rendering to use the core function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918623 (https://phabricator.wikimedia.org/T325698) [20:16:35] 10Fundraising-Backlog: Move some logic from the GatewayAdapter class to DonationData class - https://phabricator.wikimedia.org/T336667 (10AKanji-WMF) Potentially needs larger parent task or initiative [20:21:17] (03PS1) 10Eileen: e-notice fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919897 [20:24:26] (03CR) 10CI reject: [V: 04-1] Switch rendering to use the core function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918623 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [20:44:48] (03PS7) 10Eileen: Switch rendering to use the core function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918623 (https://phabricator.wikimedia.org/T325698) [20:50:09] (03PS8) 10Eileen: Switch rendering to use the core function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918623 (https://phabricator.wikimedia.org/T325698) [21:12:46] (03PS1) 10Jdlrobson: jquery.cookie is deprecated [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/919909 (https://phabricator.wikimedia.org/T271995) [21:19:58] (03CR) 10Ejegg: [C: 03+2] Minor cleanup - CRM_Core_Exception is an alias for api exception now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918997 (owner: 10Eileen) [21:33:35] (03Merged) 10jenkins-bot: Minor cleanup - CRM_Core_Exception is an alias for api exception now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918997 (owner: 10Eileen) [21:42:26] !log payments-wiki upgraded from c0da741f to 8988a598 (and globalcollect settings deleted) [21:42:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:46:26] so far so good with the settings cleanup [21:50:29] nice [21:51:41] eileen: the interplay between the imported model, the @method getters & setters, and the explicit getters and setters is a bit tricky, but I think I've got a handle on it now. Are you feeling like that 'use core function' patch is still in flux, or should I review it now? [21:53:00] ejegg: yeah it's confusing - I have been consolidating a bit on putting them in contribution & contact - I could do a couple more - but it would be nice to get what is done merged & I can always build on it. I need to look at the Failed Recurring if I want to fulling kill the datatranslate [21:53:41] ok, cool, I'll do some debugging through PS8 and review [22:10:30] (03CR) 10Ejegg: [C: 03+2] "Looks like movement in the right direction!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918623 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [22:10:50] gonna relocate [22:10:57] ejegg: cool [22:10:59] and maybe get dinner [22:11:05] good idea [22:24:06] (03Merged) 10jenkins-bot: Switch rendering to use the core function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918623 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [22:33:02] anilk: i have migrated the fr-tech "how we use phab" doc from google to wikitech. i just pulled it over as it was, so feel free to edit it to make it match reality: https://wikitech.wikimedia.org/wiki/Fundraising/Team_processes/How_we_use_Phabricator [22:33:27] all of the screenshots should be present but let me know if we need additional ones. [23:33:54] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/919931 [23:34:53] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/919931 (owner: 10Eileen) [23:35:58] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/919931 (owner: 10Eileen) [23:37:55] !log civicrm upgraded from db6e8d69 to ef7b3822 [23:37:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:45:06] (03PS5) 10Eileen: Add preview to thank you message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/918998 (https://phabricator.wikimedia.org/T325698)