[01:08:40] 10Fundraising Sprint Fish HEAD^, 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Jealousy Driven Development, and 2 others: DLocal Audit - Test with new integration - https://phabricator.wikimedia.org/T324347 (10Cstone) Update on status: Refu... [04:27:17] (03PS1) 10Eileen: Switch RecurringFailed to use WorkflowMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919935 (https://phabricator.wikimedia.org/T325698) [04:31:11] (03PS2) 10Eileen: Switch RecurringFailed to use WorkflowMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919935 (https://phabricator.wikimedia.org/T325698) [04:37:02] (03PS1) 10Eileen: Stop enabling civi-data-translate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919937 (https://phabricator.wikimedia.org/T325698) [04:37:34] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Decommission `civi-data-translate` extension - https://phabricator.wikimedia.org/T325698 (10Eileenmcnaughton) a:03Eileenmcnaughton [04:49:04] (03CR) 10CI reject: [V: 04-1] Stop enabling civi-data-translate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919937 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [04:57:52] (03PS1) 10Cstone: WIP: Switch audit contribution tracking lookup to use new table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) [05:03:55] (03PS3) 10Eileen: Switch RecurringFailed to use WorkflowMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919935 (https://phabricator.wikimedia.org/T325698) [05:03:57] (03PS2) 10Eileen: Stop enabling civi-data-translate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919937 (https://phabricator.wikimedia.org/T325698) [05:04:00] (03PS1) 10Eileen: Fix regression - type hint being hit in preview as NULL is legit in preview [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919941 (https://phabricator.wikimedia.org/T325698) [05:04:56] cstone: any chance you could +2 that last one - it's a regression that no-one will likely spot but would be better to fix [05:05:35] Sure eileen [05:07:02] (03CR) 10Cstone: [C: 03+2] Fix regression - type hint being hit in preview as NULL is legit in preview [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919941 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [05:11:15] (03CR) 10CI reject: [V: 04-1] WIP: Switch audit contribution tracking lookup to use new table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) (owner: 10Cstone) [05:16:25] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/919989 (owner: 10L10n-bot) [05:16:53] (03CR) 10CI reject: [V: 04-1] Stop enabling civi-data-translate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919937 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [05:17:18] (03PS3) 10Eileen: Stop enabling civi-data-translate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919937 (https://phabricator.wikimedia.org/T325698) [05:17:20] (03PS1) 10Eileen: Use WorkFlowMessage::render for EOY [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920134 (https://phabricator.wikimedia.org/T325698) [05:19:41] (03Merged) 10jenkins-bot: Fix regression - type hint being hit in preview as NULL is legit in preview [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919941 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [05:27:42] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/920138 [05:27:55] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/920138 (owner: 10Eileen) [05:28:37] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/920138 (owner: 10Eileen) [05:30:23] (03CR) 10CI reject: [V: 04-1] Use WorkFlowMessage::render for EOY [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920134 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [05:30:26] (03CR) 10CI reject: [V: 04-1] Stop enabling civi-data-translate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919937 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [05:47:53] (03PS1) 10Eileen: Use WorkFlowMessage::render for EOY [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920141 (https://phabricator.wikimedia.org/T325698) [05:48:58] (03PS4) 10Eileen: Stop enabling civi-data-translate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919937 (https://phabricator.wikimedia.org/T325698) [06:17:25] (03PS1) 10Eileen: Remove send Receipt to reduce confusion [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920149 [06:17:46] (03Abandoned) 10Eileen: Use WorkFlowMessage::render for EOY [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920134 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [06:20:47] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920158 (owner: 10L10n-bot) [06:22:08] (03PS2) 10Eileen: Remove send Receipt to reduce confusion [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920149 [06:24:03] !log civicrm upgraded from ef7b3822 to d97a371e [06:24:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [06:33:25] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920158 (owner: 10L10n-bot) [06:36:39] 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Expose email-prefs-wiki to public - https://phabricator.wikimedia.org/T335793 (10MSuijkerbuijk_WMF) Hi @AKanji-WMF we agreed with Elliott that we can have 2 different ones (one for the Email Pref center and one for the Recurring self-serve/up... [06:50:06] !log civicrm: revision d97a371e, config 686d3cb4 [06:50:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [11:46:52] (03PS1) 10Damilare Adedoyin: Load contribution tracking info in Contribution pop up window [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920253 (https://phabricator.wikimedia.org/T336318) [11:47:50] (03PS2) 10Damilare Adedoyin: Load contribution tracking info in Contribution pop up window [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920253 (https://phabricator.wikimedia.org/T336318) [11:55:46] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, 10fr-donorservices: duplicate dLocal donations May 9th - https://phabricator.wikimedia.org/T336444 (10Damilare) [11:57:45] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, 10fr-donorservices: duplicate dLocal donations May 9th - https://phabricator.wikimedia.org/T336444 (10Damilare) [11:57:48] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Do more to prevent multiple clicks of donate button - https://phabricator.wikimedia.org/T336455 (10Damilare) [11:59:15] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Adyen: Bank dropdown spacing issues - https://phabricator.wikimedia.org/T336580 (10Damilare) [11:59:48] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Adyen: Bank dropdown spacing issues - https://phabricator.wikimedia.org/T336580 (10Damilare) a:03Damilare [12:42:14] "Crisp packet from 1960s found on beach" https://www.bbc.co.uk/news/uk-england-norfolk-65428452 British journalism back on form :) [14:39:28] (03PS1) 10Damilare Adedoyin: Fix bank dropdown spacing issues [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920297 (https://phabricator.wikimedia.org/T336580) [14:41:15] (03CR) 10CI reject: [V: 04-1] Fix bank dropdown spacing issues [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920297 (https://phabricator.wikimedia.org/T336580) (owner: 10Damilare Adedoyin) [14:43:26] (03PS2) 10Damilare Adedoyin: Fix bank dropdown spacing issues [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920297 (https://phabricator.wikimedia.org/T336580) [14:45:32] (03CR) 10CI reject: [V: 04-1] Fix bank dropdown spacing issues [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920297 (https://phabricator.wikimedia.org/T336580) (owner: 10Damilare Adedoyin) [14:46:45] (03PS3) 10Damilare Adedoyin: Fix bank dropdown spacing issues [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920297 (https://phabricator.wikimedia.org/T336580) [14:49:27] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: globalcollect_gateway: should be replace to ingenico, needs replace the campaign link - https://phabricator.wikimedia.org/T334773 (10Damilare) Awesome! I did a log dive today and didn't find any occurrence of the error. Thanks for all the work on this @An... [14:50:46] 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog: India fundraising messages in Android app - https://phabricator.wikimedia.org/T335918 (10Pcoombe) [14:50:55] 10Wikimedia-Fundraising-Banners, 10Wikipedia-iOS-App-Backlog, 10iOS Release FY2022-23: India fundraising messages in iOS app - https://phabricator.wikimedia.org/T335919 (10Pcoombe) [14:51:42] 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog: India fundraising messages in Android app - https://phabricator.wikimedia.org/T335918 (10Pcoombe) Hi, we've had to postpone our India fundraising campaigns. I'll update with new dates soon. [14:51:45] 10Wikimedia-Fundraising-Banners, 10Wikipedia-iOS-App-Backlog, 10iOS Release FY2022-23: India fundraising messages in iOS app - https://phabricator.wikimedia.org/T335919 (10Pcoombe) Hi, we've had to postpone our India fundraising campaigns. I'll update with new dates soon. [18:06:18] (03CR) 10Ejegg: "I like the debounce idea! The 'disabled' button attribute also looks like a good idea. Maybe we could just do that in the common form enab" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919326 (https://phabricator.wikimedia.org/T336455) (owner: 10Damilare Adedoyin) [18:08:07] (03PS2) 10Ejegg: Add silverpop_export column for upgrade activities [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919256 (https://phabricator.wikimedia.org/T335824) [18:08:09] (03PS1) 10Ejegg: Add eligibility for recurring upgrade to export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/920360 (https://phabricator.wikimedia.org/T335824) [18:08:15] (03CR) 10CI reject: [V: 04-1] Add silverpop_export column for upgrade activities [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919256 (https://phabricator.wikimedia.org/T335824) (owner: 10Ejegg) [18:08:17] (03CR) 10CI reject: [V: 04-1] Add eligibility for recurring upgrade to export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/920360 (https://phabricator.wikimedia.org/T335824) (owner: 10Ejegg) [18:15:34] 10Fundraising-Backlog: Change transaction descriptor to omit phone number reference - https://phabricator.wikimedia.org/T336779 (10greg) In discussion in officehours we thought "Wikimedia Foundation" would be helpful (vs "Wikimedia"). Waiting on confirmation.... [18:37:43] 10fundraising-tech-ops: Update fr-tech config to use current dns servers for NTP - https://phabricator.wikimedia.org/T336803 (10Dwisehaupt) [18:56:44] (03CR) 10Ejegg: [C: 04-1] "Can we add more logging to understand the problem before we change the behavior across all gateways? I'm worried this will break our handl" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917947 (https://phabricator.wikimedia.org/T334905) (owner: 10Jgleeson) [19:08:49] 10Fundraising-Backlog, 10fr-donorservices: Check box no longer available on merging screen! - https://phabricator.wikimedia.org/T336806 (10SHust) [20:28:30] (03PS6) 10Damilare Adedoyin: Do more to prevent multiple clicks of donate button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919326 (https://phabricator.wikimedia.org/T336455) [20:32:35] (03PS7) 10Damilare Adedoyin: Do more to prevent multiple clicks of donate button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919326 (https://phabricator.wikimedia.org/T336455) [20:34:10] (03PS8) 10Damilare Adedoyin: Do more to prevent multiple clicks of donate button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919326 (https://phabricator.wikimedia.org/T336455) [20:34:14] (03CR) 10CI reject: [V: 04-1] Do more to prevent multiple clicks of donate button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919326 (https://phabricator.wikimedia.org/T336455) (owner: 10Damilare Adedoyin) [20:41:24] (03CR) 10Damilare Adedoyin: "Thanks ejegg for the initial CR, I've made the recommended changes." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919326 (https://phabricator.wikimedia.org/T336455) (owner: 10Damilare Adedoyin) [20:41:43] (03CR) 10Damilare Adedoyin: "hanks ejegg for the initial CR, I've made the recommended changes." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919326 (https://phabricator.wikimedia.org/T336455) (owner: 10Damilare Adedoyin) [20:59:43] (03CR) 10Ejegg: "one question about the enablement, another about the .bind target" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919326 (https://phabricator.wikimedia.org/T336455) (owner: 10Damilare Adedoyin) [21:06:36] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 10fr-donorservices: Create patch for CiviProxy to support API4 - https://phabricator.wikimedia.org/T336816 (10Ejegg) [21:15:29] (03CR) 10Ejegg: "Looking really close! And the timing should be fine - I tried on staging and it only took 3 min 30 sec to get all those rows." [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919249 (https://phabricator.wikimedia.org/T333182) (owner: 10Wfan) [21:19:04] (03CR) 10Ejegg: Ignore CaptureFailed IPNs from Adyen (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/919855 (owner: 10Ejegg) [21:21:14] (03CR) 10Ejegg: "Sorry, I think I must have broken this with Idb23ed8755db1a0102ab8a5abb. There is no more #card-container, so you can delete that selector" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920297 (https://phabricator.wikimedia.org/T336580) (owner: 10Damilare Adedoyin) [21:24:05] (03PS4) 10Wfan: Add checksum email to silverpop csv [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919249 (https://phabricator.wikimedia.org/T333182) [21:27:16] (03PS3) 10Ejegg: Load contribution tracking info in Contribution pop up window [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920253 (https://phabricator.wikimedia.org/T336318) (owner: 10Damilare Adedoyin) [21:27:30] (03CR) 10Ejegg: [C: 03+2] "Looks good, works in local testing!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920253 (https://phabricator.wikimedia.org/T336318) (owner: 10Damilare Adedoyin) [21:30:24] (03PS1) 10Ejegg: Use xdebug3 config for email pref ctr [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/920380 [21:31:00] wfan: I added a follow-up patch for your patch to use the new bullseye image ^^^ [21:31:08] should help get debugging working again [21:31:39] Thanks ejegg :) looking [21:32:23] (03CR) 10Wfan: [C: 03+2] "ha, thanks!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/920380 (owner: 10Ejegg) [21:41:09] (03Merged) 10jenkins-bot: Load contribution tracking info in Contribution pop up window [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920253 (https://phabricator.wikimedia.org/T336318) (owner: 10Damilare Adedoyin) [21:51:14] sorry in advance if I flood the channel fr-tech - I'm going to push a bunch of upstream fixes to our CiviProxy repo [21:51:26] oh hmm, maybe I can just push and not review [22:03:10] ah shoot, it's not actually working for me locally. So I won't push or review just yet [22:05:22] anilk: I've discovered a new subtask for the recurring upgrade [22:07:19] turns out the security proxy we use to insulate us between the donor-facing site and CiviCRM only supports the old-style API requests [22:07:45] and wfan is writing things in the new style [22:08:34] so that new task T336816 would be good to have before creating the form [22:08:35] T336816: Create patch for CiviProxy to support API4 - https://phabricator.wikimedia.org/T336816 [22:08:49] I think I'll kick the form-creation task out to next sprint and pull that one in [22:09:43] 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 10fr-donorservices: Create patch for CiviProxy to support API4 - https://phabricator.wikimedia.org/T336816 (10Ejegg) [22:10:06] 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 10fr-donorservices: Create patch for CiviProxy to support API4 - https://phabricator.wikimedia.org/T336816 (10Ejegg) a:03Ejegg [22:10:19] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Recurring-Donations, 10fr-donorservices: Create recurring upgrade form - https://phabricator.wikimedia.org/T335795 (10Ejegg) [22:16:45] (03PS1) 10Wfan: Add contribution helper function to check if passed contact id and checksum valid for upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920384 (https://phabricator.wikimedia.org/T335788) [22:19:22] well, i'm going to relocate and keep trying to understand what broke when I pulled down the upstream updates [22:19:37] can't seem to debug into the civiproxy code unfortunately... [22:50:30] thanks ejegg|afk [22:52:17] wfan: on that patch you just put up - I think the validateChecksum function is really a contact helper [22:52:54] we will probably use it again so probably should be over there [22:53:26] ok, you mean move this func over to contact right> [23:06:17] (03PS1) 10Wfan: Add contribution helper function to check if passed contact id and checksum valid for upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920388 (https://phabricator.wikimedia.org/T335788) [23:07:38] (03PS2) 10Wfan: Add contribution helper function to check if passed contact id and checksum valid for upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920384 (https://phabricator.wikimedia.org/T335788) [23:07:57] (03Abandoned) 10Wfan: Add contribution helper function to check if passed contact id and checksum valid for upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920388 (https://phabricator.wikimedia.org/T335788) (owner: 10Wfan) [23:22:44] (03PS3) 10Wfan: Add contribution helper function to check if passed contact id and checksum valid for upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920384 (https://phabricator.wikimedia.org/T335788) [23:28:39] /nick ejegg [23:28:42] \/nick ejegg [23:28:48] derp [23:35:18] 10Fundraising-Backlog: Individual matching import issue - https://phabricator.wikimedia.org/T336609 (10Eileenmcnaughton) @MDemosWMF this is the contact he needs to be merged with to make those conflicts go away https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=21505 The contact doesn't have a rela... [23:53:27] oh huh, looks like /srv/config/exposed/ isn't actually mounted where I would expect it [23:54:23] 10fundraising-tech-ops: Update fr-tech config to use current dns servers for NTP - https://phabricator.wikimedia.org/T336803 (10Dwisehaupt) For dns servers we want to remove dns2001 and dns2002 and add in dns2004, dns2005 and dns2006. We should see if we could use the recdns.anycast.wmnet for NTP as we do for d... [23:54:42] 10fundraising-tech-ops: Update fr-tech config to use current dns servers for NTP - https://phabricator.wikimedia.org/T336803 (10Dwisehaupt) a:03Dwisehaupt [23:59:34] 10Fundraising-Backlog: Individual matching import issue - https://phabricator.wikimedia.org/T336609 (10Eileenmcnaughton) Actually this one too https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=1817332