[00:03:53] (03PS1) 10Ejegg: Mount config for civiproxy [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/920395 [00:31:36] 10Fundraising-Backlog: Individual matching import issue - https://phabricator.wikimedia.org/T336609 (10Eileenmcnaughton) @MDemosWMF interesingly there are also soft credits from more than one of the duplicates to https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=97346 - I guess there was some sort o... [01:31:51] (03CR) 10Ejegg: "There is a built-in function that validates checksums : CRM_Contact_BAO_Contact_Utils::validChecksum($id, $checksum)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920384 (https://phabricator.wikimedia.org/T335788) (owner: 10Wfan) [01:33:46] eileen so... the idea with Civiproxy is that the request structure should mirror the structure that's exposed internally, right? [01:34:33] i.e. for API4 we need to implement routing in Civiproxy to handle /civicrm/ajax/api4/Contact/get URLs ? [01:35:05] I guess I'll want to look at how that's implemented in core [01:44:20] (03PS1) 10Eileen: Fix handling where duplicate contacts being chosen between [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920398 (https://phabricator.wikimedia.org/T336609) [01:46:17] 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog, 10Patch-For-Review, 10Unplanned-Sprint-Work: Individual matching import issue - https://phabricator.wikimedia.org/T336609 (10Eileenmcnaughton) [01:58:31] i guess the general routing is handled by the framework, i.e. drupal [01:58:45] so I can add an htaccess file to civiproxy [01:59:09] maybe specifically for /api4/ urls [02:14:34] I thought the url was still that civicrm/ajax one [02:19:02] 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog, 10Patch-For-Review, 10Unplanned-Sprint-Work: Individual matching import issue - https://phabricator.wikimedia.org/T336609 (10Eileenmcnaughton) a:03Eileenmcnaughton [02:27:48] (03CR) 10Eileen: [C: 03+1] "You don't actually use active_count in the end do you? I'm assuming it it something you want for a later patch rather than a good intentio" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919223 (https://phabricator.wikimedia.org/T335926) (owner: 10Ejegg) [02:38:10] (03CR) 10Ejegg: "This fix is closer to where it needs to be, but it still has the same problem as the existing code. What happened to the donor in the tick" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/910615 (https://phabricator.wikimedia.org/T335152) (owner: 10Wfan) [02:43:09] (03CR) 10Ejegg: "This is looking pretty good, but there's one more twist we'll have to deal with. When multiple contacts share an email address we only exp" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920384 (https://phabricator.wikimedia.org/T335788) (owner: 10Wfan) [02:45:04] (03CR) 10Ejegg: "Thanks for the review, Eileen. active_count is indeed used in a later patch - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919223 (https://phabricator.wikimedia.org/T335926) (owner: 10Ejegg) [02:45:29] (03CR) 10Eileen: [C: 03+2] Export amount and currency of active recurring [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919223 (https://phabricator.wikimedia.org/T335926) (owner: 10Ejegg) [02:45:34] thanks! [02:45:43] now let's see if gerrit is happier with the next patch [02:47:09] (03Merged) 10jenkins-bot: Export amount and currency of active recurring [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919223 (https://phabricator.wikimedia.org/T335926) (owner: 10Ejegg) [02:48:39] (03CR) 10Ejegg: "recheck" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919256 (https://phabricator.wikimedia.org/T335824) (owner: 10Ejegg) [02:49:30] (03CR) 10Ejegg: [V: 03+2] Use xdebug3 config for email pref ctr [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/920380 (owner: 10Ejegg) [02:52:59] (03CR) 10CI reject: [V: 04-1] Add silverpop_export column for upgrade activities [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919256 (https://phabricator.wikimedia.org/T335824) (owner: 10Ejegg) [02:59:27] (03PS3) 10Ejegg: Add silverpop_export column for upgrade activities [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919256 (https://phabricator.wikimedia.org/T335824) [02:59:29] (03PS2) 10Ejegg: Add eligibility for recurring upgrade to export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/920360 (https://phabricator.wikimedia.org/T335824) [02:59:33] (03CR) 10CI reject: [V: 04-1] Add eligibility for recurring upgrade to export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/920360 (https://phabricator.wikimedia.org/T335824) (owner: 10Ejegg) [04:39:16] (03PS2) 10Eileen: Fix handling where duplicate contacts being chosen between [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920398 (https://phabricator.wikimedia.org/T336609) [05:16:23] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/920429 (owner: 10L10n-bot) [08:01:30] (03PS1) 10Eileen: Remove unused variable & hence function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920633 [11:15:39] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/919495 (owner: 10L10n-bot) [11:56:51] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Update the information on donation form for Netherlands: update the word from "uw" to "je" - https://phabricator.wikimedia.org/T336287 (10Damilare) [12:33:20] (03PS9) 10Damilare Adedoyin: Do more to prevent multiple clicks of donate button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919326 (https://phabricator.wikimedia.org/T336455) [12:36:05] (03CR) 10Damilare Adedoyin: "Thanks ejegg for the comments, those have been resolved." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919326 (https://phabricator.wikimedia.org/T336455) (owner: 10Damilare Adedoyin) [12:41:12] (03PS4) 10Damilare Adedoyin: Fix bank dropdown spacing issues [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920297 (https://phabricator.wikimedia.org/T336580) [12:43:36] (03CR) 10Damilare Adedoyin: "Thanks for the comments on this ejegg, done!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920297 (https://phabricator.wikimedia.org/T336580) (owner: 10Damilare Adedoyin) [12:44:57] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Update the information on donation form for Netherlands: update the word from "uw" to "je" - https://phabricator.wikimedia.org/T336287 (10Damilare) a:03Damilare [13:30:48] (03PS4) 10Jgleeson: Add method to log the rare order_id / ct_id mismatches [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917947 (https://phabricator.wikimedia.org/T334905) [13:36:22] (03CR) 10Jgleeson: "Thanks for the review @damilare and @ejegg. I've left comments inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917947 (https://phabricator.wikimedia.org/T334905) (owner: 10Jgleeson) [14:00:26] (03PS5) 10Damilare Adedoyin: Fix bank dropdown spacing issues [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920297 (https://phabricator.wikimedia.org/T336580) [14:02:20] (03CR) 10CI reject: [V: 04-1] Fix bank dropdown spacing issues [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920297 (https://phabricator.wikimedia.org/T336580) (owner: 10Damilare Adedoyin) [14:06:46] (03PS6) 10Damilare Adedoyin: Fix bank dropdown spacing issue [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920297 (https://phabricator.wikimedia.org/T336580) [14:08:46] (03PS1) 10Damilare Adedoyin: Update the information on donation form for Netherlands: update the word from "uw" to "je" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920701 (https://phabricator.wikimedia.org/T336287) [14:09:46] (03PS2) 10Damilare Adedoyin: Update the information on donation form for Netherlands: update the word from "uw" to "je" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920701 (https://phabricator.wikimedia.org/T336287) [14:11:38] (03CR) 10CI reject: [V: 04-1] Update the information on donation form for Netherlands: update the word from "uw" to "je" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920701 (https://phabricator.wikimedia.org/T336287) (owner: 10Damilare Adedoyin) [14:12:42] (03PS3) 10Damilare Adedoyin: Update the information on donation form for Netherlands: update the word from "uw" to "je" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920701 (https://phabricator.wikimedia.org/T336287) [14:28:31] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Civi\WMFHelpers\FinanceInstrument::getPaymentInstrument() must be the type string, null returned - https://phabricator.wikimedia.org/T334757 (10Damilare) a:03Damilare [14:31:45] (03CR) 10Ejegg: [C: 03+2] "Thanks! This should help us get to the bottom of it." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917947 (https://phabricator.wikimedia.org/T334905) (owner: 10Jgleeson) [14:33:15] (03PS10) 10Ejegg: Do more to prevent multiple clicks of donate button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919326 (https://phabricator.wikimedia.org/T336455) (owner: 10Damilare Adedoyin) [14:34:29] (03CR) 10Ejegg: [C: 03+2] "This looks great! Maybe we can add the debounce treatment to the Adyen click handlers next." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919326 (https://phabricator.wikimedia.org/T336455) (owner: 10Damilare Adedoyin) [14:35:45] (03PS7) 10Ejegg: Fix bank dropdown spacing issue [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920297 (https://phabricator.wikimedia.org/T336580) (owner: 10Damilare Adedoyin) [14:35:53] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920297 (https://phabricator.wikimedia.org/T336580) (owner: 10Damilare Adedoyin) [14:47:15] (03Merged) 10jenkins-bot: Add method to log the rare order_id / ct_id mismatches [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917947 (https://phabricator.wikimedia.org/T334905) (owner: 10Jgleeson) [14:47:18] (03Merged) 10jenkins-bot: Do more to prevent multiple clicks of donate button [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/919326 (https://phabricator.wikimedia.org/T336455) (owner: 10Damilare Adedoyin) [14:47:21] (03Merged) 10jenkins-bot: Fix bank dropdown spacing issue [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920297 (https://phabricator.wikimedia.org/T336580) (owner: 10Damilare Adedoyin) [15:32:03] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/920720 [15:32:05] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/920720 (owner: 10Ejegg) [15:44:45] (03PS2) 10Cstone: Switch audit contribution tracking lookup to use new table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) [15:50:11] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/920720 (owner: 10Ejegg) [15:58:40] (03CR) 10CI reject: [V: 04-1] Switch audit contribution tracking lookup to use new table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) (owner: 10Cstone) [16:05:10] 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog, 10Patch-For-Review, 10Unplanned-Sprint-Work: Individual matching import issue - https://phabricator.wikimedia.org/T336609 (10MDemosWMF) @Eileenmcnaughton I merged the two to CID 21505, but I'm not sure we can be certain that CID 21505... [17:20:11] 10Fundraising-Backlog: Data Axle project - New fields in Civi - https://phabricator.wikimedia.org/T336890 (10MDemosWMF) [17:29:03] (03CR) 10Ejegg: "The looks like it works! I wonder if we should re-use the existing 'donate_interface-rtbt-issuer_id' message though, and just edit the con" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920701 (https://phabricator.wikimedia.org/T336287) (owner: 10Damilare Adedoyin) [17:35:54] ejegg this locale seems to be worded differently in NL donate_interface-rtbt-issuer_id [17:37:05] damilare: yeah, I think we aren't using that one so we can edit it to match the desired text in en.json and nl.json [17:37:26] I believe it might have been in use for the old iDEAL form under Ingenico [17:37:34] Ohh ok, cool [17:37:53] but since it's basically the same prompt I think it's OK if the rest of the languages are using the old text for a while [17:40:28] whew, trying out Civi under PHP 8.2 and man are there a ton of 'dynamic property deprecated' warnings [17:40:28] (03PS4) 10Damilare Adedoyin: Update the information on donation form for Netherlands: update the word from "uw" to "je" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920701 (https://phabricator.wikimedia.org/T336287) [17:40:50] 10Fundraising-Backlog: Data Axle project - List pull from Civi - https://phabricator.wikimedia.org/T336891 (10MDemosWMF) [17:41:18] damilare: looks like you left a trailing comma in nl.json there [17:41:26] (03PS5) 10Damilare Adedoyin: Update the information on donation form for Netherlands: update the word from "uw" to "je" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920701 (https://phabricator.wikimedia.org/T336287) [17:41:37] ah and also in qqq.json [17:43:02] (03PS6) 10Damilare Adedoyin: Update the information on donation form for Netherlands: update the word from "uw" to "je" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920701 (https://phabricator.wikimedia.org/T336287) [17:43:04] (03CR) 10CI reject: [V: 04-1] Update the information on donation form for Netherlands: update the word from "uw" to "je" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920701 (https://phabricator.wikimedia.org/T336287) (owner: 10Damilare Adedoyin) [17:43:29] (03PS7) 10Damilare Adedoyin: Update the information on donation form for Netherlands: update the word from "uw" to "je" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920701 (https://phabricator.wikimedia.org/T336287) [17:43:36] thanks! ejegg fixed [17:44:07] (03PS8) 10Ejegg: Update the information on donation form for Netherlands: update the word from "uw" to "je" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920701 (https://phabricator.wikimedia.org/T336287) (owner: 10Damilare Adedoyin) [17:44:14] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920701 (https://phabricator.wikimedia.org/T336287) (owner: 10Damilare Adedoyin) [17:47:36] (03Merged) 10jenkins-bot: Update the information on donation form for Netherlands: update the word from "uw" to "je" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/920701 (https://phabricator.wikimedia.org/T336287) (owner: 10Damilare Adedoyin) [17:55:26] thanks for all the CR ejegg ! [17:55:43] any time! [18:11:55] 10Fundraising-Backlog: Change recurring rebilling logic from 'monthly' to 'on demand' in India through Dlocal - https://phabricator.wikimedia.org/T336893 (10EMartin) [18:15:39] 10Fundraising-Backlog: Error upon event import (Stripe) - https://phabricator.wikimedia.org/T336895 (10AKanji-WMF) [18:26:41] 10fundraising-tech-ops: Update fr-tech config to use current dns servers for NTP - https://phabricator.wikimedia.org/T336803 (10Dwisehaupt) [19:04:27] (03CR) 10Krinkle: [C: 03+2] "@Jdlrobson: Jon, beware that this repo is deployed differently from all other extensions (it does not ride the train, so make sure not to " [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/919909 (https://phabricator.wikimedia.org/T271995) (owner: 10Jdlrobson) [19:13:48] 10fundraising-tech-ops: Update fr-tech config to use current dns servers for NTP - https://phabricator.wikimedia.org/T336803 (10Dwisehaupt) [19:16:05] fr-tech if anyone is still around and wants to do tech-talk let me know [19:17:14] (03PS5) 10Ejegg: Add checksum email to silverpop csv [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919249 (https://phabricator.wikimedia.org/T333182) (owner: 10Wfan) [19:17:21] (03CR) 10CI reject: [V: 04-1] Add checksum email to silverpop csv [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919249 (https://phabricator.wikimedia.org/T333182) (owner: 10Wfan) [19:17:33] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919249 (https://phabricator.wikimedia.org/T333182) (owner: 10Wfan) [19:17:40] (03CR) 10CI reject: [V: 04-1] Add checksum email to silverpop csv [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919249 (https://phabricator.wikimedia.org/T333182) (owner: 10Wfan) [19:18:00] grr [19:20:04] ejegg: i think it's just you. dami was doing the chess thing during this time and everyone else is travelling iirc. [19:20:25] yep yep, seems to be the case [19:20:55] (03Merged) 10jenkins-bot: jquery.cookie is deprecated [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/919909 (https://phabricator.wikimedia.org/T271995) (owner: 10Jdlrobson) [19:21:00] well, I'll see if anyone from releng is around to help troubleshoot that spurious V-1 annoyance [19:40:14] (03CR) 10Ejegg: [C: 03+2] "Those V-1 failures are so strange. I've filed a ticket for the releng team: https://phabricator.wikimedia.org/T336902" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919249 (https://phabricator.wikimedia.org/T333182) (owner: 10Wfan) [19:42:14] (03PS4) 10Ejegg: Add silverpop_export column for upgrade activities [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919256 (https://phabricator.wikimedia.org/T335824) [19:42:16] (03PS3) 10Ejegg: Add eligibility for recurring upgrade to export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/920360 (https://phabricator.wikimedia.org/T335824) [19:42:21] (03CR) 10CI reject: [V: 04-1] Add silverpop_export column for upgrade activities [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919256 (https://phabricator.wikimedia.org/T335824) (owner: 10Ejegg) [19:42:23] (03CR) 10CI reject: [V: 04-1] Add eligibility for recurring upgrade to export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/920360 (https://phabricator.wikimedia.org/T335824) (owner: 10Ejegg) [19:43:04] (03CR) 10Ejegg: [C: 03+2] "recheck" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919249 (https://phabricator.wikimedia.org/T333182) (owner: 10Wfan) [19:45:04] (03Merged) 10jenkins-bot: Add checksum email to silverpop csv [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919249 (https://phabricator.wikimedia.org/T333182) (owner: 10Wfan) [19:45:19] oh nice [19:46:15] (03CR) 10Ejegg: "recheck" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/919256 (https://phabricator.wikimedia.org/T335824) (owner: 10Ejegg) [19:50:56] !log payments-wiki upgraded from 8988a598 to a7567c6a [19:50:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:00:30] 10Fundraising-Backlog, 10fr-donorservices: Check box no longer available on merging screen! - https://phabricator.wikimedia.org/T336806 (10AKanji-WMF) p:05Triage→03High @Eileenmcnaughton have checked with @SHust and this is moderately urgent [20:00:51] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Adyen, 10MW-1.41-notes (1.41.0-wmf.10; 2023-05-23): Bank dropdown spacing issues - https://phabricator.wikimedia.org/T336580 (10Ejegg) With Dami's patch deployed we get some space above it on mobile - no change to the spacing on desktop though. A... [20:46:05] 10Fundraising-Backlog: Issue with Paypal donations made on GiveLively for events - https://phabricator.wikimedia.org/T295726 (10Ejegg) Looks like they are no longer being duplicated, but donors are getting Civi TY emails when they should ideally just get emails from GiveLively. Looking at the IPN logs I see an... [21:00:40] 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog, 10Patch-For-Review, 10Unplanned-Sprint-Work: Individual matching import issue - https://phabricator.wikimedia.org/T336609 (10Eileenmcnaughton) @MDemosWMF yes - I just tried & it went through - I think there is a matching gifts issue r... [23:21:38] if anyone wants to hang out & look at some of that thank you stuff I know there is a quite a lot to work through on the review side....