[01:08:23] dang still running setup.sh... [01:08:50] what is donut [01:42:44] eileen in this context it's a wiki with the donatewiki content [01:42:52] and also the centralnotice extension [01:43:07] ah ok - well it did finish... [01:43:12] phew [01:43:24] yeah, the full repo for mediawiki is ginormous these days [01:43:41] I guess that must have been the delay? [01:44:16] there are also a thousand or more template and content pages to import on first setting up donatewiki [01:44:22] so i guess that's slow too [01:44:26] yeah - it failed on brivate bin too I think [01:44:33] & something or other [01:44:41] oh huh, i'd have thought that would be fast [01:45:04] just getting back to reviewing your patches [01:45:17] (03PS2) 10Ejegg: Update endowment text to live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/921092 (owner: 10Eileen) [01:45:34] (03CR) 10Ejegg: [C: 03+2] Update endowment text to live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/921092 (owner: 10Eileen) [01:57:35] (03Merged) 10jenkins-bot: Update endowment text to live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/921092 (owner: 10Eileen) [02:02:52] (03PS1) 10Eileen: Fix amount not showing in recurred example [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922179 (https://phabricator.wikimedia.org/T325698) [02:03:06] ejegg: I found the fix for amount [02:04:48] ah nice [02:05:11] oh jeez, magic comment [02:06:33] (03PS2) 10Ejegg: Fix amount not showing in recurred example [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922179 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [02:06:49] (03CR) 10Ejegg: [C: 03+2] "Spooky! But it works" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922179 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [02:07:14] (03PS3) 10Ejegg: Use WorkFlowMessage::render for EOY [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920141 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [02:07:34] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920141 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [02:11:11] (03CR) 10Ejegg: [C: 03+2] "Just noting a couple things unrelated to this patch - confusing comments and a potential recur status to add" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920141 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [02:12:57] (03PS6) 10Ejegg: Stop enabling civi-data-translate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919937 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [02:18:58] (03Merged) 10jenkins-bot: Fix amount not showing in recurred example [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922179 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [02:20:13] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/922182 [02:20:22] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/922182 (owner: 10Eileen) [02:20:40] (03Merged) 10jenkins-bot: Use WorkFlowMessage::render for EOY [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920141 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [02:21:28] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/922182 (owner: 10Eileen) [02:22:13] !log civicrm upgraded from 7eae24d5 to 3329155a [02:22:15] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:28:32] eileen: I'm not sure why but we seem to be rewriting the payment processor records over and over again [02:28:44] you are seeing that in the log table? [02:28:58] or at least calling the civicrm_api3_payment_processor_create a ton [02:29:19] no, I had a breakpoint in the payment processor constructor and realized it was being hit a dozen times on each pageload [02:29:20] hmm - perhaps we are not using apiv4-with-match in our Managed records? [02:29:28] even when they had nothing to do with payments [02:29:33] hmmm [02:29:36] it looks like they are set to update=always [02:30:08] let me try changing that [02:30:12] I just put one in & it wan't hit on the page I'm on [02:30:46] oddly the message render is working on staging but not prod [02:31:05] oh shoot! [02:31:07] cached? [02:31:31] I don't think so - my best guess is an exception - but it worked ok when I actually sent it [02:31:32] also, that's not messing with TY mails, is it? [02:31:41] oh the preview is what's broken? [02:31:47] dang [02:33:43] oh i got a stack trace of that 'is not of type String' error: https://phabricator.wikimedia.org/P48461 [02:34:21] ahh, that 165 looks likely [02:34:42] I bet it's the option value for the recurring upgrade [02:35:55] (03PS1) 10Eileen: Log if thankyou doesn't render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922183 [02:36:06] oh yeah that sounds right [02:36:19] ejegg: ^^ might help me find the error [02:36:30] huh, but the other one in that file (OptionValue_Thank_you_email) has an int for value and didn't give me issues [02:37:07] (03CR) 10Ejegg: [C: 03+2] Log if thankyou doesn't render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922183 (owner: 10Eileen) [02:38:32] yeah, CRM_Core_BAO_CustomOption::updateValue does expect a string for 'value' [02:41:19] hah, but changing doesn't help [02:41:29] now I see the string '165' in the backtrace [02:41:37] Oh I guess I can set a breakpoint at least [02:46:25] ahh it's the $oldValue [02:46:51] I guess it's just my own db being a bit screwy [02:48:12] oh hey, there's no specific 'update' set [02:48:29] I'll change that to 'unmodified' (on the payment processor mgd) [02:49:39] (03Merged) 10jenkins-bot: Log if thankyou doesn't render [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922183 (owner: 10Eileen) [02:55:28] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/922185 [02:56:38] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/922185 (owner: 10Eileen) [02:57:28] !log civicrm upgraded from 3329155a to 6642b602 [02:57:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:00:47] (03PS1) 10Ejegg: Don't rewrite processors so often [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922186 [03:03:44] (03CR) 10CI reject: [V: 04-1] Don't rewrite processors so often [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922186 (owner: 10Ejegg) [03:11:24] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922186 (owner: 10Ejegg) [03:11:45] (03PS2) 10Ejegg: Don't rewrite processors so often [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922186 [03:12:19] ejegg: it might be these that are causing that - making it log a notice before it's ready - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/915854/7/drupal/sites/default/civicrm/extensions/wmf-civicrm/Managed/CustomGroups.php [03:13:20] (03PS7) 10Ejegg: Stop enabling civi-data-translate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919937 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [03:13:39] (03CR) 10Ejegg: [C: 03+2] "Everything still seems to work!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919937 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [03:14:44] (03CR) 10CI reject: [V: 04-1] Don't rewrite processors so often [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922186 (owner: 10Ejegg) [03:15:00] ah man, it got late here. Well, I'mma head to bed. Have a good rest of your day eileen ! [03:15:34] ah I should push up the dev-images patch for rewrite [03:21:30] (03PS2) 10Ejegg: WIP config changes for civiproxy [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/922175 (https://phabricator.wikimedia.org/T336816) [03:26:23] (03Merged) 10jenkins-bot: Stop enabling civi-data-translate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919937 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [03:27:59] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/922188 [03:28:12] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/922188 (owner: 10Eileen) [03:29:11] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/922188 (owner: 10Eileen) [03:34:58] (03PS1) 10Eileen: Fully remove civi-data-translate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922189 (https://phabricator.wikimedia.org/T325698) [03:35:25] those are uninstalled so the code can GO! [04:46:21] 10Fundraising Tech - Chaos Crew, 10Wikimedia-Fundraising-CiviCRM: Thank you job was disabled!!! - https://phabricator.wikimedia.org/T337281 (10Eileenmcnaughton) [04:48:14] 10Fundraising Tech - Chaos Crew, 10Wikimedia-Fundraising-CiviCRM: Thank you job was disabled!!! - https://phabricator.wikimedia.org/T337281 (10Eileenmcnaughton) on re-enable Lockfile found! Skipping this job run. The previous job (28755) is still running. Remove lockfile manually if in error: /tmp/thank_you_m... [04:50:07] 10Fundraising Tech - Chaos Crew, 10Wikimedia-Fundraising-CiviCRM: Thank you job was disabled!!! - https://phabricator.wikimedia.org/T337281 (10Eileenmcnaughton) Note the code is set to 'info' here ` if ($enabled === 'false') { \Civi::log('wmf')->info('thank_you: Thank You send job is disabled'); retu... [05:11:41] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/922232 (owner: 10L10n-bot) [05:22:32] 10Fundraising Tech - Chaos Crew, 10Wikimedia-Fundraising-CiviCRM: Thank you job was disabled!!! - https://phabricator.wikimedia.org/T337281 (10Eileenmcnaughton) OK from the logs it seems like maybe a cache clear or bus error or email connection issue similar followed by it trying & failing to send a fail mail... [10:35:40] 10fundraising-tech-ops, 10Documentation: Ensure all disaster recover documentation is in one central location - https://phabricator.wikimedia.org/T95841 (10jbond) [14:00:33] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Thank you job was disabled!!! - https://phabricator.wikimedia.org/T337281 (10greg) [15:23:06] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Thank you job was disabled!!! - https://phabricator.wikimedia.org/T337281 (10greg) p:05Triage→03High [15:40:06] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/920429 (owner: 10L10n-bot) [15:59:47] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/922232 (owner: 10L10n-bot) [16:42:18] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Use Initial Contribution country in Civi Recurring Payment - https://phabricator.wikimedia.org/T337061 (10AnnWF) Did some map like https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/911386 and https://gerrit.wikimedia.org/r/c/wikim... [16:43:11] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog: CT-to-Civi-Phase 1.5 Go through phab tasks & clean up relating to contribution tracking - https://phabricator.wikimedia.org/T334539 (10AnnWF) a:03AnnWF [16:54:16] (03CR) 10Wfan: [C: 03+2] Fully remove civi-data-translate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922189 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [16:56:45] 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog, 10Patch-For-Review, 10Unplanned-Sprint-Work: Individual matching import issue - https://phabricator.wikimedia.org/T336609 (10MDemosWMF) Hi Eileen! Ellen caught something else after the import. A few of the gifts imported twice - which... [17:07:22] 10Fundraising-Backlog, 10FR-Paypal, 10FR-Smashpig: Invalid PayPal message type: mp_cancel - https://phabricator.wikimedia.org/T337326 (10Ejegg) [17:08:07] (03Merged) 10jenkins-bot: Fully remove civi-data-translate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922189 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [17:18:27] (03CR) 10Ejegg: [C: 04-1] "It looks like this function's signature is now debounce: function ( func, wait, immediate ), though it does have some code to account for " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/922141 (https://phabricator.wikimedia.org/T324860) (owner: 10Damilare Adedoyin) [17:41:41] (03CR) 10Ejegg: [C: 04-1] "Almost there! A couple of suggestions inline." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920384 (https://phabricator.wikimedia.org/T335788) (owner: 10Wfan) [17:46:19] (03PS1) 10Ejegg: Add missing 'name' elements to phonetic fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922586 [17:52:35] (03PS3) 10Ejegg: Don't rewrite processors so often [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922186 [17:55:25] (03CR) 10CI reject: [V: 04-1] Don't rewrite processors so often [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922186 (owner: 10Ejegg) [17:57:37] (03Abandoned) 10Ejegg: Use new apache2 image for email-pref-ctr [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877281 (owner: 10Ejegg) [18:03:35] jgleeson: I've got a patch that changes the FR_DOCKER_SERVICE_NAME var for the civiproxy image to 'civiproxy' - do you remember if there was a reason it was initially set to 'civicrm'? [18:03:42] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/920395 [18:04:11] hi ejegg [18:04:36] hi jgleeson and welcome back! [18:04:53] sounds like you had a fun time at the hackathon? [18:04:56] welcome back jgleeson [18:05:07] hey damilare|brb ! [18:05:35] how was greece? [18:05:51] ejegg: it's been a while since I looked at that stuff so I can't say for sure. At first glance, I'd say it was an oversight [18:06:25] ah ok [18:06:38] damilare: it was good damilare. you were missed! [18:07:04] I spoke to Nicole from your toolhunt work [18:07:14] she was cool [18:08:30] aww, yh looks like you all had a good time going by the chat conv. [18:08:39] and yh Nicole is really cool [18:14:30] (03CR) 10Jgleeson: [C: 03+2] "LGTM" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/920395 (owner: 10Ejegg) [18:14:41] thanks jgleeson [18:14:56] PROBLEM - Host frbackup2002 is DOWN: PING CRITICAL - Packet loss = 100% [18:15:18] ah, jgleeson, I remember you were having problems with docker-pkg before the trip [18:15:20] np [18:15:29] yeah ejegg [18:15:34] I was trying to do some building and it failed for me too [18:15:42] ^^ that's me rebooting frbackup for kernel upgrade. [18:15:58] but just pulling the latest from the docker-pkg repo and then doing a python setup.py seemed to get it working again [18:16:14] oh right. I'll try that now [18:16:16] thanks [18:16:23] :) [18:17:12] RECOVERY - Host frbackup2002 is UP: PING OK - Packet loss = 0%, RTA = 30.26 ms [18:32:38] oh damn, ty mail send is still disabled? [18:32:51] I totally misread that email, I though eileen had re-enabled it [18:32:57] I'll turn it on [18:34:20] ok, it's turned back on [18:34:26] oh, I thought it did too? [18:34:28] oh, good [18:34:45] 10Fundraising-Backlog: Stock TY template not loading in Civi - https://phabricator.wikimedia.org/T337332 (10MDemosWMF) [18:35:37] ohh i see [18:35:38] civicrm.wmf.ALERT: thank_you: Can't even send failmail, disabling thank you job [18:35:43] so that's screwy [18:35:49] maybe we shouldn't fail that way [18:36:10] but in any case we should fix the failure to failmail [18:37:04] blugh [18:38:57] 10Fundraising-Backlog: Stock TY template not loading in Civi - https://phabricator.wikimedia.org/T337332 (10AKanji-WMF) Some convo/context [[ https://wikimedia.slack.com/archives/C03FU7XLTH8/p1684856497046309 | here ]] [18:38:59] dwisehaupt / Jeff_Green we could have an icinga alarm on the number (or proportion) of un-thanked donations in a particular time frame [18:39:56] ejegg: makes sense [18:41:52] Jeff_Green: I'll put a SQL query in the ticket about the TY job being turned off [18:42:03] ejegg: ok [18:42:53] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Thank you job was disabled!!! - https://phabricator.wikimedia.org/T337281 (10Ejegg) @Dwisehaupt or @Jgreen how about an icinga alert on the number (or proportion) of un-thanked donations in a time frame? `lang=sql selec... [18:43:18] so it's gone and disabled itself again due to the same failure to failmail [18:43:28] I'd say this has become an UBN [18:43:57] :( [18:52:47] (03PS1) 10Ejegg: Allow sending failmail via SMTPMailer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922594 (https://phabricator.wikimedia.org/T337281) [18:53:02] fr-tech that should let it at least get the failmail out ^^^ [18:53:38] let's see, we could also let the exception bubble up so it sends a failmail at the process-control level [18:54:35] jgleeson: ^ can you review? [18:55:17] sure [18:57:30] ejegg: if I sent a thank you email via the UI will it run through that code? [18:58:07] jgleeson only if there's an error that triggers a failmail [18:58:28] so the original failure that triggered the (failed) failmail was a missing rendered smarty template [18:58:34] I'm not sure how that happens [18:59:02] PHP Warning: include(): Failed opening '.....templates_c/en_US//%%CC/CCD/CCD559CC%%string%3A%7Beval+var%3D%24smartySingleUseString%7Csmarty%3Anodefaults%7D.php' for inclusion [18:59:21] oh hey, meeting time! [19:07:56] ejegg: is the 'to' blocking being set somewhere in our config [19:08:12] I'm guessing we're dropping failmail@ somewhere? [19:08:15] dropping in* [19:09:43] 10Fundraising-Backlog: Stock TY template not loading in Civi - https://phabricator.wikimedia.org/T337332 (10AKanji-WMF) + eileen - sounds like this is something we should be able to revert relatively quickly [19:10:33] sorry that was meant to be "is the 'to' block* being set somewhere" [19:17:23] 10Fundraising-Backlog: DM Appeal Missing in Civi - https://phabricator.wikimedia.org/T337051 (10AKanji-WMF) "I'm searching for a Direct Mail Appeal under Gift Data field for contributions. I know this was in Civi but I somehow can't find it anymore on the drop down or when I go and look at Custom fields where y... [19:19:43] jgleeson: https://civicrm.wikimedia.org/admin/config/wmf_common/configure [19:20:48] 10Fundraising-Backlog, 10FR-dlocal, 10Recurring-Donations, 10fr-donorservices: recurring dLocal “Wellness” check May 19th - https://phabricator.wikimedia.org/T337049 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF Have resolved {T336893} therefore this should be resolved too [19:27:35] (03PS6) 10Wfan: Add contribution helper function to check if passed contact id and checksum valid for upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920384 (https://phabricator.wikimedia.org/T335788) [19:33:16] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Check box no longer available on merging screen! - https://phabricator.wikimedia.org/T336806 (10XenoRyet) [19:35:21] 10Fundraising-Backlog: Change transaction descriptor to omit phone number reference - https://phabricator.wikimedia.org/T336779 (10AKanji-WMF) @EMartin confirming that this is for both recurring and OTGs? [19:40:15] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal: Dlocal: Use Initial Contribution country in Civi Recurring Payment - https://phabricator.wikimedia.org/T337061 (10Damilare) [19:44:44] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Determine maturity of Civi-standalone - https://phabricator.wikimedia.org/T337337 (10Eileenmcnaughton) [19:47:54] (03CR) 10Jgleeson: [C: 03+2] "Tested locally and LGTM! thanks" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922594 (https://phabricator.wikimedia.org/T337281) (owner: 10Ejegg) [19:50:13] 10Fundraising-Backlog, 10FR-dlocal, 10Recurring-Donations, 10fr-donorservices: recurring dLocal “Wellness” check May 19th - https://phabricator.wikimedia.org/T337049 (10MBeat33) Thank you, @AKanji-WMF [20:00:03] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Error upon event import (Stripe) - https://phabricator.wikimedia.org/T336895 (10greg) p:05Triage→03Medium [20:00:36] (03Merged) 10jenkins-bot: Allow sending failmail via SMTPMailer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922594 (https://phabricator.wikimedia.org/T337281) (owner: 10Ejegg) [20:05:49] (03CR) 10Eileen: [C: 03+2] Add missing 'name' elements to phonetic fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922586 (owner: 10Ejegg) [20:09:24] if we can get this out Melanie is waiting on it to do her next import https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/9 [20:12:42] broken link eileen [20:13:05] also. i deleted that meeting invite for tonight. not sure how it then invited you on November 8th [20:15:09] I've been trying to get to bed earlier in recent months so i can't make the 10:15pm slot. I did try and think of a work around but I couldn't figure it out [20:15:23] 10Fundraising-Backlog: dLocal India - Please change text on Payment Form - https://phabricator.wikimedia.org/T337343 (10AKanji-WMF) [20:17:35] eileen: are you planning on attending an of the civi events this year? [20:18:37] (03Merged) 10jenkins-bot: Add missing 'name' elements to phonetic fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922586 (owner: 10Ejegg) [20:27:29] thanks jgleeson|away and eileen [20:28:05] eileen: any ideas on the contribution tracking queue failmails? [20:29:18] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/922607 [20:29:40] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/922607 (owner: 10Ejegg) [20:30:51] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/922607 (owner: 10Ejegg) [20:37:47] !log civicrm upgraded from efe25c9b to 11538e23 [20:37:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:38:01] ok, let's try re-enabling that thank you mail again [20:38:32] re-enabled [20:38:39] now we'll see if we get failmail [20:45:47] 10Fundraising-Backlog: Stock TY template not loading in Civi - https://phabricator.wikimedia.org/T337332 (10MDemosWMF) @Eileenmcnaughton I think you're right - I just tested a stock gift TY on my record and it sent the correct stock template, which is great! Maybe there is a way to have the preview match the tem... [20:50:17] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Jealousy Driven Development, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Decommission `civi-data-translate` extension - https://phabricator.wikimedia.org/T325698 (10Eileenmcnaughton) 05Open→03Resolved It's done! [20:52:28] eileen: guessing you wanted review on this one? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/920398 [20:52:54] ejegg: yep - it will unblock Melanie [21:02:48] 10fundraising-tech-ops, 10FR-Email: Update Acoustic Unsubscribe landing page domain to be served by a secure wikimedia.org domain - https://phabricator.wikimedia.org/T336000 (10AKanji-WMF) Adding @KHaggard to weigh in [21:04:02] eileen: I'm not quite following why the if (count($possibleContacts) > 1) { ...loop... } is inside the foreach ($contacts as $contact) { } loop that builds the $possibleContacts array [21:05:17] ejegg: the number will have gone down due to unsetting I think [21:06:01] it should be in the if not the loop? [21:06:28] maybe a quick chat in the sprint planning meet link? [21:07:08] https://meet.google.com/ymj-ipvu-pbw [21:08:58] i don't see any reference to the outer loop's $contact in the inner loop [21:09:28] so I'm not sure why we would want to go through that inner loop for every additional run through the outer loop [21:10:32] that is, why not just 1) loop over $contacts to build up $possibleContacts then 2) loop over $possibleContacts (when n>1) [21:11:01] 10fundraising-tech-ops, 10FR-Email: Update Acoustic Unsubscribe landing page domain to be served by a secure wikimedia.org domain - https://phabricator.wikimedia.org/T336000 (10KHaggard) Hi @AKanji-WMF - this ticket is referring to what you and I were emailing about on May 3rd, where you mentioned that this is... [21:14:12] (03PS3) 10Eileen: Fix handling where duplicate contacts being chosen between [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920398 (https://phabricator.wikimedia.org/T336609) [21:26:56] !log payments-wiki upgraded from a7567c6a to e02bc7c5 [21:26:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:28:25] (03PS4) 10Ejegg: Fix handling where duplicate contacts being chosen between [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920398 (https://phabricator.wikimedia.org/T336609) (owner: 10Eileen) [21:28:36] (03CR) 10Ejegg: [C: 03+2] "Thanks, this looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920398 (https://phabricator.wikimedia.org/T336609) (owner: 10Eileen) [21:32:36] (03PS1) 10Damilare Adedoyin: Use matching country for currency in Civi Recurring UPI Payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/922612 (https://phabricator.wikimedia.org/T337061) [21:35:29] wfan and ejegg, I did some diggign and I realized the getPairedCountryFromCurrency was not used in the UPI recurring charge mapper. [21:35:46] explains why the error happens for upi and not card payments [21:36:14] The patch above should fix it ^ [21:36:24] ahhh thank you damilare [21:36:49] np [21:43:36] (03Merged) 10jenkins-bot: Fix handling where duplicate contacts being chosen between [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/920398 (https://phabricator.wikimedia.org/T336609) (owner: 10Eileen) [21:48:09] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/922615 [21:48:22] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/922615 (owner: 10Eileen) [21:49:21] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/922615 (owner: 10Eileen) [21:49:42] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Thank you job was disabled!!! - https://phabricator.wikimedia.org/T337281 (10Ejegg) This is working for now and shouldn't disabled the job on the next failmail. @dwisehaupt mentioned there is already a counter for missin... [21:51:18] fr-tech I'm going to head home so I'll be a bit late for the tech talk [21:57:32] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Thank you job was disabled!!! - https://phabricator.wikimedia.org/T337281 (10Dwisehaupt) @ejegg, it is both. the query for the prometheus collection is in modules/prometheus/files/collector/fundraising_query_collector:... [22:00:13] !log civicrm upgraded from 11538e23 to 4251dfa1 [22:00:16] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:11:37] ok, I'm in tech talk if anyone else wants to join fr-tech [22:12:14] (03PS3) 10Damilare Adedoyin: Add debounce to fix duplicate Adyen transactions in short sequence [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/922141 (https://phabricator.wikimedia.org/T324860) [22:22:23] (03PS2) 10Ejegg: Use matching country for currency in Civi Recurring UPI Payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/922612 (https://phabricator.wikimedia.org/T337061) (owner: 10Damilare Adedoyin) [22:22:40] (03CR) 10Ejegg: [C: 03+2] Use matching country for currency in Civi Recurring UPI Payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/922612 (https://phabricator.wikimedia.org/T337061) (owner: 10Damilare Adedoyin) [22:23:12] (03Merged) 10jenkins-bot: Use matching country for currency in Civi Recurring UPI Payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/922612 (https://phabricator.wikimedia.org/T337061) (owner: 10Damilare Adedoyin) [22:24:10] (03PS4) 10Eileen: Don't rewrite processors so often [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922186 (owner: 10Ejegg) [22:24:34] (03CR) 10Eileen: [C: 03+2] Don't rewrite processors so often [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922186 (owner: 10Ejegg) [22:27:11] (03CR) 10CI reject: [V: 04-1] Don't rewrite processors so often [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/922186 (owner: 10Ejegg) [22:27:19] (03CR) 10Eileen: "Not sure this is really a live thing - we have done other work since & I suspect it should be abandoned unless the request comes back - bu" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/854004 (https://phabricator.wikimedia.org/T319142) (owner: 10Damilare Adedoyin) [22:29:22] (03CR) 10Ejegg: [V: 03+2] Mount config for civiproxy [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/920395 (owner: 10Ejegg) [22:34:02] (03CR) 10Eileen: [V: 03+2 C: 03+2] Add eligibility for recurring upgrade to export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/920360 (https://phabricator.wikimedia.org/T335824) (owner: 10Ejegg) [22:40:52] (03CR) 10Eileen: [C: 03+2] Add type hints to PaymentResult [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917989 (owner: 10Ejegg) [22:52:22] https://localhost:9005/rest.php?entity=civiproxy&action=getpreferences&key=SITE_KEY&version=3&json=1&api_key=API_KEY&contact_id=204&checksum=56eb98d3d362996d0310262149ad8bba_1645567575_168 update the version to 4 right? what about the action? [22:54:11] (03Merged) 10jenkins-bot: Add type hints to PaymentResult [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/917989 (owner: 10Ejegg) [23:45:48] PROBLEM - Host frdb1004 is DOWN: PING CRITICAL - Packet loss = 100% [23:48:16] RECOVERY - Host frdb1004 is UP: PING OK - Packet loss = 0%, RTA = 0.49 ms