[05:55:28] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/926884 (owner: 10L10n-bot) [12:36:14] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_40) - 10https://gerrit.wikimedia.org/r/925391 (owner: 10L10n-bot) [12:38:20] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/926884 (owner: 10L10n-bot) [13:09:58] (03CR) 10Damilare Adedoyin: [C: 03+1] "Looks good to me, tested with a user locally and it returned the recurring amount and next schedule date. +1'ing to allow another pair of " [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/922171 (https://phabricator.wikimedia.org/T336816) (owner: 10Ejegg) [13:15:22] (03PS1) 10Damilare Adedoyin: WIP: RecurUpgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927178 [13:25:20] (03CR) 10Jgleeson: [C: 03+2] "LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/925057 (https://phabricator.wikimedia.org/T337800) (owner: 10Ejegg) [13:26:18] (03PS1) 10Jgleeson: Add test for user_limit_exceeded dlocal failure. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/927185 (https://phabricator.wikimedia.org/T337800) [13:51:37] (03CR) 10Ejegg: [C: 03+2] "Thanks for the test! This doesn't touch the code at the ResponseValidator layer that was written for the parent patch, but it's good to te" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/927185 (https://phabricator.wikimedia.org/T337800) (owner: 10Jgleeson) [13:53:38] (03PS1) 10Ejegg: Update SmashPig version dependency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927195 [13:53:40] (03CR) 10Ejegg: [C: 03+2] Update SmashPig version dependency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927195 (owner: 10Ejegg) [13:54:03] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/927196 [13:54:06] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/927196 (owner: 10Ejegg) [14:03:05] ahhh so there is a maintenance mode flag for civi1002 that stops the scheduled jobs from happening? [14:12:10] (03Merged) 10jenkins-bot: Update SmashPig version dependency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927195 (owner: 10Ejegg) [14:12:12] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/927196 (owner: 10Ejegg) [14:12:31] (03PS1) 10Ejegg: Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/927203 [14:12:41] (03CR) 10Ejegg: [C: 03+2] Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/927203 (owner: 10Ejegg) [14:21:11] (03Merged) 10jenkins-bot: Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/927203 (owner: 10Ejegg) [14:31:34] !log payments-wiki upgraded from c2f9f8b5 to 2b4203df [14:31:35] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:01:47] yeah ejegg. dallas fixed that late friday and we rerun the jobs for Katie [15:03:31] ejegg: yeah I couldn't see your new code being passed through when testing so I added a test for the raw response [15:03:51] did you manage to test it yourself and see it go through that path? [15:10:33] no, not this patch, but I had tested the previous one that changed code in the same place [15:10:46] and saw it go through there [15:11:36] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/918619 [15:13:03] ok I'll add a test to that suite too and confirm it passes through [15:16:06] (03CR) 10Ejegg: [C: 04-1] "Thank you for re-ordering this! It's much easier to see what has changed now. Some comments inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/911839 (https://phabricator.wikimedia.org/T335388) (owner: 10Wfan) [15:18:38] (03PS9) 10Ejegg: Add missing submethods pair for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/910611 (https://phabricator.wikimedia.org/T335388) (owner: 10Wfan) [15:19:20] (03CR) 10Ejegg: [C: 03+2] "Still feels a little funky to pass a 'codi_use_qr_code' parameter, but I can't think of a better way right now" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/910611 (https://phabricator.wikimedia.org/T335388) (owner: 10Wfan) [15:20:03] (03Merged) 10jenkins-bot: Add missing submethods pair for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/910611 (https://phabricator.wikimedia.org/T335388) (owner: 10Wfan) [15:36:59] oh darn it [15:37:12] just got another failmail for that user blacklisted [15:37:24] and I had just deployed the patch that was supposed to fix it [15:39:17] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, and 2 others: Create patch for CiviProxy to support API4 - https://phabricator.wikimedia.org/T336816 (10AnnWF) test locall: run docker-pkg From dev-image Check if requests is 2.28.1 (oth... [15:39:41] (03CR) 10Wfan: [C: 03+2] "Works find locally! Thanks" [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/922171 (https://phabricator.wikimedia.org/T336816) (owner: 10Ejegg) [15:40:43] (03CR) 10Wfan: [V: 03+2 C: 03+2] "Works good locally. thanks" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/922175 (https://phabricator.wikimedia.org/T335794) (owner: 10Ejegg) [15:46:44] (03CR) 10Wfan: [V: 03+2 C: 03+2] Proxy requests to API4 [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/922171 (https://phabricator.wikimedia.org/T336816) (owner: 10Ejegg) [16:18:10] fr-tech so it looks like we're not retrying that 'user blacklisted' error at least [16:18:42] but we're still sending a failmail at the API level [18:43:13] (03PS1) 10Jgleeson: Fix $errorCodes check on dlocal isPaymentDecline() [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/927249 (https://phabricator.wikimedia.org/T337800) [18:44:45] ejegg: I think that fixes the user limit exceeded failmail. I think there was a small oversight in the code checking if the error code was present in the $errorCodes array. I've added a test for the RestResponseValidator too. [18:48:49] that should also quiet down the 'User_blacklisted' errors too [18:51:19] (03PS2) 10Damilare Adedoyin: Create recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927178 (https://phabricator.wikimedia.org/T335795) [18:52:51] oh huh, I thought the issue was up in a different part of the code [18:52:58] (03CR) 10CI reject: [V: 04-1] Create recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927178 (https://phabricator.wikimedia.org/T335795) (owner: 10Damilare Adedoyin) [18:53:28] (03PS2) 10Jgleeson: Fix $errorCodes check on dlocal isPaymentDecline() [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/927249 (https://phabricator.wikimedia.org/T337800) [18:53:38] I just added an extra test for the 'User blacklisted' scenario [18:54:55] So I think the same thing is happening as when I fixed the last bug: the RestResponseValidator change makes it stop retrying and throwing down at that level, but there is another check up at the API level that is sending a failmail [18:55:11] (03PS3) 10Damilare Adedoyin: Create recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927178 (https://phabricator.wikimedia.org/T335795) [18:56:02] ejegg: it looks like those failmails are being sent in the curlwrapper execute when it calls the shouldRetry handler of the validator [18:56:49] (03CR) 10CI reject: [V: 04-1] Create recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927178 (https://phabricator.wikimedia.org/T335795) (owner: 10Damilare Adedoyin) [18:57:13] that's based on the 'Request returned (400) BAD REQUEST:' log prefix which seems to only appear in the HttpStatusValidator [18:57:26] ahh good catch [18:58:26] i'm still struccling to see the functional difference between old and new code in the ErrorMapper for that patch [18:58:41] if ( !in_array( $errorResponse['code'], self::$errorCodes ) ) [18:58:47] vs !isset( self::$errorCodes[$errorResponse['code']] ) [18:59:07] would be different if we had some null values [18:59:14] 10Fundraising Sprint Fish HEAD^, 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Keep ya HEAD(1) up, and 2 others: DLocal Audit - Test with new integration - https://phabricator.wikimedia.org/T324347 (10Cstone) Confirmed refund has new style ID [18:59:18] but nothing is mapped to null [18:59:43] (indeed it is) [19:00:01] derp [19:00:05] ky vs val [19:00:12] key* [19:00:17] i mean we don't have any ohhhh [19:00:17] dang, nice catch [19:00:36] (03CR) 10Ejegg: [C: 03+2] Fix $errorCodes check on dlocal isPaymentDecline() [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/927249 (https://phabricator.wikimedia.org/T337800) (owner: 10Jgleeson) [19:01:09] brb just gonna get some water for the call [19:01:14] (03Merged) 10jenkins-bot: Fix $errorCodes check on dlocal isPaymentDecline() [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/927249 (https://phabricator.wikimedia.org/T337800) (owner: 10Jgleeson) [19:02:07] (03PS4) 10Damilare Adedoyin: Create recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927178 (https://phabricator.wikimedia.org/T335795) [19:02:35] ty for review ejegg ! [19:06:00] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, and 2 others: Create patch for CiviProxy to support API4 - https://phabricator.wikimedia.org/T336816 (10AnnWF) @Ejegg I noticed that civitest.muslimehelfen.org crt gonna expires: Sunday,... [19:07:27] ty for the fix! [19:13:16] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising-Backlog, 10FR-Smashpig: Record CZ bank transfers from Adyen IPN messages - https://phabricator.wikimedia.org/T337260 (10XenoRyet) [19:13:48] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising-Backlog: Stock TY template not loading in Civi - https://phabricator.wikimedia.org/T337332 (10XenoRyet) [19:14:20] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet) [19:14:22] 10Fundraising Sprint Fish HEAD^, 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Keep ya HEAD(1) up, and 2 others: DLocal Audit - Test with new integration - https://phabricator.wikimedia.org/T324347 (10XenoRyet) 05Open→03Resolved [19:15:07] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Thank you job was disabled!!! - https://phabricator.wikimedia.org/T337281 (10XenoRyet) 05Open→03Resolved [19:15:29] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Change recurring rebilling logic from 'monthly' to 'on demand' in India through Dlocal - https://phabricator.wikimedia.org/T336893 (10XenoRyet) 05Open→03Resolved [19:15:31] 10Fundraising-Backlog, 10FR-dlocal, 10Recurring-Donations, 10fr-donorservices: recurring dLocal “Wellness” check May 19th - https://phabricator.wikimedia.org/T337049 (10XenoRyet) [19:16:05] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising-Backlog: Stock TY template not loading in Civi - https://phabricator.wikimedia.org/T337332 (10Eileenmcnaughton) 05Open→03Resolved shoulld be sorted now [19:21:49] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Brazil card donors routing to Adyen? - https://phabricator.wikimedia.org/T338038 (10Dwisehaupt) [19:24:15] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Email: Civi to Acoustic Export: Job Status Failed - https://phabricator.wikimedia.org/T338041 (10Dwisehaupt) [19:25:07] 10Fundraising-Backlog, 10Recurring-Donations, 10fr-donorservices, 10Epic: How can we enable upgrading of existing recurring donation amount? - https://phabricator.wikimedia.org/T325317 (10Dwisehaupt) [19:25:10] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising-Backlog, 10Recurring-Donations: Create API action to get active recurrings based on contact ID and checksum - https://phabricator.wikimedia.org/T335788 (10Dwisehaupt) 05Open→03Resolved [19:26:54] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising-Backlog, 10Recurring-Donations, 10fr-donorservices, 10FR-Email: Indicate in Acoustic export if a donor is eligible for monthly upgrade - https://phabricator.wikimedia.org/T335824 (10Ejegg) 05Open→03Resolved [19:26:58] 10Fundraising-Backlog, 10Recurring-Donations, 10fr-donorservices, 10Epic: How can we enable upgrading of existing recurring donation amount? - https://phabricator.wikimedia.org/T325317 (10Ejegg) [19:28:37] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising-Backlog, 10Recurring-Donations, 10fr-donorservices, 10FR-Email: Indicate in Acoustic export if a donor is eligible for monthly upgrade - https://phabricator.wikimedia.org/T335824 (10Ejegg) Note: have not implemented check for Dlocal non-India recurri... [19:49:25] (03PS1) 10Ejegg: Update SmashPig dependency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927256 [19:49:28] (03CR) 10Ejegg: [C: 03+2] Update SmashPig dependency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927256 (owner: 10Ejegg) [19:49:49] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/927257 [19:49:52] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/927257 (owner: 10Ejegg) [20:00:10] (03Merged) 10jenkins-bot: Update SmashPig dependency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927256 (owner: 10Ejegg) [20:00:12] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/927257 (owner: 10Ejegg) [20:25:52] 10Fundraising-Backlog: Investigation: Migrating historical SurveyMonkey data - https://phabricator.wikimedia.org/T337880 (10AKanji-WMF) Require ability for DR to review and remove data (e.g. for GDPR requests) globally for a supporter [20:34:32] (03CR) 10Wfan: [V: 03+2 C: 03+2] "nice to move duplicate code to checking php, thanks" [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/924613 (https://phabricator.wikimedia.org/T336816) (owner: 10Ejegg) [20:43:51] (03PS1) 10Ejegg: Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/927271 [20:43:53] (03CR) 10Ejegg: [C: 03+2] Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/927271 (owner: 10Ejegg) [20:47:46] !log payments-wiki upgraded from 2b4203df to f3b229c6 [20:47:47] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:52:52] (03Merged) 10jenkins-bot: Update composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/927271 (owner: 10Ejegg) [22:31:33] 10Fundraising Tech - Chaos Crew, 10MediaWiki-Language-converter, 10MediaWiki-extensions-CentralNotice, 10MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), and 5 others: LanguageConverter: Call to member function replace() on null - https://phabricator.wikimedia.org/T337427 (10Zabe) 05Open→03Resolved a:03Func