[11:08:56] (03PS9) 10Damilare Adedoyin: Handle submission of new recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/928066 (https://phabricator.wikimedia.org/T335796) [11:10:47] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/929216 (owner: 10L10n-bot) [11:10:53] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, and 2 others: Update RecurringQueueConsumer to handle donation upgrades - https://phabricator.wikimedia.org/T335827 (10Damilare) a:03Damilare [11:11:24] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/929216 (owner: 10L10n-bot) [11:56:53] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: DM Appeal Missing in Civi - https://phabricator.wikimedia.org/T337051 (10RLewis) @MDemosWMF - I can see the drop down option in Civi when searching. [12:15:21] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: DM Appeal Missing in Civi - https://phabricator.wikimedia.org/T337051 (10RLewis) @Eileenmcnaughton - all looks ok to me and the revenue looks like what it was in Civi for this DMA. Thank you! [13:00:54] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q1:rack/setup/install frbast1002, frmon1002, frpig1002 - https://phabricator.wikimedia.org/T319460 (10Papaul) @Dwisehaupt anything else we can do to help with this task? [13:31:05] (03PS3) 10Damilare Adedoyin: Update RecurringQueueConsumer to handle donation upgrades [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928885 (https://phabricator.wikimedia.org/T335827) [13:50:31] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: DM Appeal Missing in Civi - https://phabricator.wikimedia.org/T337051 (10MDemosWMF) I see it now! Thanks! [14:37:29] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog: CT-to-Civi-Phase 1.5 - Update code references to contribution_tracking - https://phabricator.wikimedia.org/T334537 (10Damilare) a:03Damilare [15:25:25] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Get proximity search working in Search kit - https://phabricator.wikimedia.org/T334153 (10JSimmons) @Eileenmcnaughton I tried using the custom searches - proximity search function today (June 12). I was trying to find contacts in a group within 96 km of a... [15:40:08] 10Fundraising-Backlog, 10FR-dlocal, 10Recurring-Donations: dLocal recurring INR success rates for 2nd month, post on-demand switch - https://phabricator.wikimedia.org/T338351 (10Cstone) I manually updated 2 scheduled to recur on the 15th to the 16th. I'm going to watch what happens to those two and will upda... [15:43:13] 10Fundraising-Backlog: Test dlocal India recurring ondemand 2nd charge - https://phabricator.wikimedia.org/T338812 (10Cstone) [16:14:10] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, and 2 others: Create patch for CiviProxy to support API4 - https://phabricator.wikimedia.org/T336816 (10Ejegg) Hmm @AnnWF I have never seen anything about that civitest... [16:17:51] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, and 2 others: Create patch for CiviProxy to support API4 - https://phabricator.wikimedia.org/T336816 (10Ejegg) Pull request for the upstream patch is here: https://gith... [17:56:23] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog: Data Axle project - List pull from Civi - https://phabricator.wikimedia.org/T336891 (10MDemosWMF) Hi @AnnWF! I just spoke with Erica and we have a question: - Could we get the the total of each list for segments 1 and 6? We also... [18:12:04] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, and 4 others: "Order id is duplicated" error from dlocal - https://phabricator.wikimedia.org/T334905 (10jgleeson) As I was drafting an em... [18:32:29] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q1:rack/setup/install frbast1002, frmon1002, frpig1002 - https://phabricator.wikimedia.org/T319460 (10Dwisehaupt) @Papaul Your side is all set. We have some switch overs scheduled for the end of the month to finish up our side of the task too. Thanks fo... [18:55:45] (03PS4) 10Damilare Adedoyin: Update RecurringQueueConsumer to handle donation upgrades [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928885 (https://phabricator.wikimedia.org/T335827) [19:06:40] (03PS5) 10Damilare Adedoyin: Update RecurringQueueConsumer to handle donation upgrades [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928885 (https://phabricator.wikimedia.org/T335827) [19:19:53] (03CR) 10CI reject: [V: 04-1] Update RecurringQueueConsumer to handle donation upgrades [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928885 (https://phabricator.wikimedia.org/T335827) (owner: 10Damilare Adedoyin) [19:23:30] (03PS4) 10Wfan: Fix India form text cosmetics before pretest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927768 (https://phabricator.wikimedia.org/T337520) [19:23:37] (03CR) 10Wfan: Fix India form text cosmetics before pretest (034 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927768 (https://phabricator.wikimedia.org/T337520) (owner: 10Wfan) [19:28:11] (03PS12) 10Wfan: Create recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927178 (https://phabricator.wikimedia.org/T335795) (owner: 10Damilare Adedoyin) [19:30:56] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-dlocal, 10Patch-For-Review: Add smashpig listener server config to allow Authorization header - https://phabricator.wikimedia.org/T332891 (10CodeReviewBot) jgleeson opened https://gitlab.wikimedia.org/repos/releng/dev-im... [19:31:05] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-dlocal, 10Patch-For-Review: Add smashpig listener server config to allow Authorization header - https://phabricator.wikimedia.org/T332891 (10CodeReviewBot) [19:40:04] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Get proximity search working in Search kit - https://phabricator.wikimedia.org/T334153 (10Eileenmcnaughton) I've just moved this back to triage so we look at it's priority in our meetings [19:53:01] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Update WMF_donor fields - https://phabricator.wikimedia.org/T331919 (10Eileenmcnaughton) @ERoden-WMF did you take a look at the fields - I need to write the script to update these this w... [19:54:45] 10Fundraising-Backlog: AMEX rejected transactions through Ingenico need to be ported to Adyen - https://phabricator.wikimedia.org/T338524 (10AKanji-WMF) 05Open→03Invalid I believe this is a duplicate of {T338523} - am resolving this one [19:56:06] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Recent donations not saved after merging of two CIDs - https://phabricator.wikimedia.org/T326583 (10XenoRyet) [20:01:29] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Recent donations not saved after merging of two CIDs - https://phabricator.wikimedia.org/T326583 (10Ejegg) @SHust It looks like the 'wrap each dedupe in a transaction' isn't quite what we need to do here. Eileen has suggested instead... [20:01:33] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Get proximity search working in Search kit - https://phabricator.wikimedia.org/T334153 (10JSimmons) Thanks! It looks like this is only affecting non-US proximity searches. [20:02:32] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: dLocal India - Please change text on Payment Form - https://phabricator.wikimedia.org/T337343 (10AnnWF) a:03AnnWF [20:03:08] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: dLocal India - Please change text on Payment Form - https://phabricator.wikimedia.org/T337343 (10AKanji-WMF) FYI internal discussion thread: https://wikimedia.slack.com/archives/C04NB1NSH62/p1683558420120999 [20:05:49] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Test dlocal India recurring ondemand 2nd charge - https://phabricator.wikimedia.org/T338812 (10AKanji-WMF) [20:10:58] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Get proximity search working in Search kit - https://phabricator.wikimedia.org/T334153 (10AKanji-WMF) @JSimmons - let's connect - sounds like we don't keep geo data for non US constituents [20:15:48] 10Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage, 10donate.wikimedia.org: donate.wikimedia.org landing pages don't have descriptions in search engine results - https://phabricator.wikimedia.org/T254808 (10AKanji-WMF) @greg reviewing [20:16:24] (03PS1) 10Cstone: Change pan explain text. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/929407 (https://phabricator.wikimedia.org/T337343) [20:16:44] (03PS5) 10Wfan: Fix India form text cosmetics before pretest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927768 (https://phabricator.wikimedia.org/T337520) [20:18:26] (03PS6) 10Wfan: Fix India form text cosmetics before pretest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927768 (https://phabricator.wikimedia.org/T337520) [20:19:08] 10Fundraising-Backlog: Civi Export: What to do with the MatchingGifts file and mystery fields - https://phabricator.wikimedia.org/T338259 (10AKanji-WMF) Thanks @KHaggard ; will add to an upcoming sprint [20:19:26] (03CR) 10Ejegg: [C: 03+2] Change pan explain text. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/929407 (https://phabricator.wikimedia.org/T337343) (owner: 10Cstone) [20:38:55] 10Fundraising-Backlog: Civi Export: What to do with the MatchingGifts file and mystery fields - https://phabricator.wikimedia.org/T338259 (10KHaggard) Thanks @AKanji-WMF ! I feel like I wrote a lot in my last comment so the over-communicator in me wants to just plainly restate for clarity: - We only need to stop... [20:46:53] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Update WMF_donor fields - https://phabricator.wikimedia.org/T331919 (10ERoden-WMF) Hi @Eileenmcnaughton thanks for the nudge. I think the ones you proposed look fine, but just confirming... [20:49:35] (03Merged) 10jenkins-bot: Change pan explain text. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/929407 (https://phabricator.wikimedia.org/T337343) (owner: 10Cstone) [20:54:18] (03PS7) 10Wfan: Fix India form text cosmetics before pretest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927768 (https://phabricator.wikimedia.org/T337520) [21:18:05] (03CR) 10Damilare Adedoyin: [C: 03+2] "Looks good to me, thanks for all the work on this." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927768 (https://phabricator.wikimedia.org/T337520) (owner: 10Wfan) [21:18:33] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Update WMF_donor fields - https://phabricator.wikimedia.org/T331919 (10Eileenmcnaughton) Erica - yes that is correct - however if the *only* use for the older year columns is for analyt... [21:19:30] ejegg: let me know if you want to hang out to look at that review chain [21:26:45] ok eileen, just looking at some DonationInterface patches first [21:26:52] cool [21:27:08] a hangout would probably be good in a bit, if you'll still be free in a little while [21:28:16] oh hey, looks like Damilare has actually +2ed the one I was about to comment on [21:28:25] will switch gears over to the CRM stuff [21:38:29] (03Merged) 10jenkins-bot: Fix India form text cosmetics before pretest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927768 (https://phabricator.wikimedia.org/T337520) (owner: 10Wfan) [21:39:24] 10fundraising-tech-ops: Issue new SSL Client Certificate for dkozlowski - https://phabricator.wikimedia.org/T338842 (10XenoRyet) [21:40:08] 10fundraising-tech-ops: Issue new SSL Client Certificate for dkozlowski - https://phabricator.wikimedia.org/T338842 (10XenoRyet) p:05Triage→03Medium [21:41:27] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Update WMF_donor fields - https://phabricator.wikimedia.org/T331919 (10ERoden-WMF) Got it, thanks @Eileenmcnaughton. Let me double check with major gifts if they use any of them when usi... [21:53:06] ejegg: yep happy to hang out [21:53:15] cstone: do you get a js error on this page? https://civicrm.wikimedia.org/civicrm/imports/templates [21:53:56] ionly see error with Permissions-Policy header: Origin trial controlled feature not enabled: 'interest-cohort'. eileen [21:54:01] (that is what I hit last time I started to look at the import & seeing it again but it hasn't been reported) [21:54:01] no like code error [21:55:10] what is the oirigin trial controlled thing? Is that because you got vaccinated & and now have the soros population control extension in your browser? [21:55:26] no js error for me in Firefox [21:55:31] hmm ok [21:55:41] lol eileen [21:55:44] actually it reloaed ok [21:55:59] wasn't that some flocking feature google tried to make replace cookies? [21:56:11] oh & now I have the interest cohort error [21:56:13] it keeps chrome virus free! [21:56:18] and spreads easily [21:56:18] the matrix is re-instated [21:56:19] haha [22:00:26] (03PS1) 10Cstone: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/929425 [22:01:27] lots of Azerbaijani translations in that chunk too [22:02:22] (03CR) 10Cstone: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/929425 (owner: 10Cstone) [22:02:59] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/929425 (owner: 10Cstone) [22:03:06] so far the CalculatedData patch is seeming pretty self-explanitory eileen :) [22:03:35] ejegg: yep I couldn't cut any corners explaining it with you probably out [22:04:17] fr-tech I'm going to deploy those India form changes [22:07:18] !payments-wiki upgraded from f3b229c6 to b1cf4f26 [22:07:21] er !log payments-wiki upgraded from f3b229c6 to b1cf4f26 [22:07:28] !log payments-wiki upgraded from f3b229c6 to b1cf4f26 [22:07:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:07:30] .... haha [22:07:32] :) [22:08:02] 10fundraising-tech-ops: Issue new SSL Client Certificate for dkozlowski - https://phabricator.wikimedia.org/T338842 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt Certificate renewed. Certificate sent via email. Password sent via SMS. [22:10:36] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MW-1.41-notes (1.41.0-wmf.13; 2023-06-13), 10Patch-For-Review: dLocal India - Please change text on Payment Form - https://phabricator.wikimedia.org/T337343 (10Cstone) a:05AnnWF→03Cstone This has been deployed. [22:10:47] this was posted in a civi channel (by bgm) [22:10:48] [22:10:49] bgm [22:10:49] 1:59 AM [22:10:52] I noticed that CiviCRM doesn't have many "stars" on Github (490), and .. while it's a completely silly metric, some people do use that to measure a project's popularity. If you have a Github account and enjoy using CiviCRM, please take a second to star the project: https://github.com/civicrm/civicrm-core/ (button on the upper-right corner of the screen) [22:11:13] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10MW-1.41-notes (1.41.0-wmf.13; 2023-06-13): Fix India form text cosmetics before pretest - https://phabricator.wikimedia.org/T337520 (10Cstone) This has been deployed [22:11:21] I'll star it! [22:11:26] :-) [22:11:27] heh, one of those stars is already me [22:14:56] 10fundraising-tech-ops: Fundraising access request for dpatel - https://phabricator.wikimedia.org/T338905 (10Dwisehaupt) [22:15:16] im gona go buy that hammer before it starts raining again ill be back in a bit [22:16:36] eileen: the one thing that i've snagged on a lil bit is that repeated change_XXXX_YYYY column. [22:17:00] so I guess we want to remove the repeated on in a later patch? [22:17:25] oh yeah that is super confusing - but I *think it removes the repeat even though it doesn't look like that in the gerrit comparison [22:19:34] ah ok.. but I mean, we would want to actually remove the extra custom fields too? [22:19:54] I think we are putting the wrong data into the existing field? [22:20:02] ohhhh [22:21:17] now I'm confused again - if you want to merge that one I'll relook at the top of the chain [22:22:02] what I can do is push it on live & regenerate the triggers on live & see the 'real' difference [22:22:15] ok, let me keep looking a bit [22:22:29] I also just noticed the AND latest.financial_type_id <> $endowmentFinancialType [22:22:35] in the join to latest [22:22:42] but not in the join to earliest or largest [22:22:51] and now I want to understand that too [22:22:53] that is unchanged though I think [22:22:57] yeah [22:23:07] I guess I should ignore that for now :) [22:27:30] 10fundraising-tech-ops: Fundraising access request for dpatel - https://phabricator.wikimedia.org/T338905 (10EMartin) Dhaval will need Superset and Civi access, please note. Evelyn Martin (She/Her) Sr. Manager Donation Processing | Wikimedia Foundation emartin@wikimedia.org | Wikimedia Foundation yeah - I'll def re-check the sql after I deploy that & commit the update [22:27:50] I think the financialType might be because the fields actually ARE different [22:28:28] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10MW-1.41-notes (1.41.0-wmf.13; 2023-06-13): Fix India form text cosmetics before pretest - https://phabricator.wikimedia.org/T337520 (10EMartin) Thank you FRTech (@Cstone @AKanji-WMF ). This helps us to put our best foot for... [22:58:26] 10fundraising-tech-ops: Fundraising access request for dpatel - https://phabricator.wikimedia.org/T338905 (10Dwisehaupt) [23:09:08] 10fundraising-tech-ops: Fundraising access request for dpatel - https://phabricator.wikimedia.org/T338905 (10Dwisehaupt) [23:14:49] 10fundraising-tech-ops: Fundraising access request for dpatel - https://phabricator.wikimedia.org/T338905 (10Dwisehaupt) a:03Dwisehaupt SSL client certificate created and sent via email. Password sent via SMS. Civi account created and set with random password. Superset account created and password sent via SMS... [23:54:57] eileen: is there any chance you have those 'before' and 'after' trigger versions flipped? [23:55:09] I finally see the bug in the before code [23:55:19] and it seems to match up with the 'after' trigger patch [23:55:33] ejegg: yeah - it looked different locally then in gerrit - it broke my brain [23:55:43] I guess it could be that [23:55:59] heh, ok, I'll +2 that patch now [23:56:14] sorry, was afk for a bit - lots of Naila's family was over here [23:59:03] (03PS4) 10Ejegg: Restructure CalculateData class such that the sql for fields is in the array declaration. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/927321 (https://phabricator.wikimedia.org/T336305) (owner: 10Eileen) [23:59:25] (03CR) 10Ejegg: [C: 03+2] "Looks good! I think it's more readable this way." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/927321 (https://phabricator.wikimedia.org/T336305) (owner: 10Eileen)