[00:17:36] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Pre-notification received although the recurring set up is canceled in Civi - India - https://phabricator.wikimedia.org/T338309 (10Cstone) Things I've checked so far, civicrm_contribution_recur_id of `1516663`: The donation mentioned is cancelled in civi... [00:59:06] (03PS1) 10Eileen: [not for merge] Performance testing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/929810 (https://phabricator.wikimedia.org/T336305) [01:11:19] (03CR) 10CI reject: [V: 04-1] [not for merge] Performance testing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/929810 (https://phabricator.wikimedia.org/T336305) (owner: 10Eileen) [01:32:19] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Review WMF donor triggers - https://phabricator.wikimedia.org/T339055 (10Eileenmcnaughton) [01:57:51] (03PS2) 10Eileen: [not for merge] Performance testing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/929810 (https://phabricator.wikimedia.org/T336305) [02:10:12] (03CR) 10CI reject: [V: 04-1] [not for merge] Performance testing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/929810 (https://phabricator.wikimedia.org/T336305) (owner: 10Eileen) [02:26:33] (03CR) 10Ejegg: [C: 03+2] "This is really impressive! I like the declarative way you managed to specify all the different segments and statuses. The label / descript" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/927966 (https://phabricator.wikimedia.org/T336305) (owner: 10Eileen) [02:28:01] ejegg: I am going out in 30 mins (for about 2 hours) & I'd really like to get the patch after that out - but I'd also like to chat with you on my performance testing [02:39:29] (03Merged) 10jenkins-bot: Add calculation for segment fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/927966 (https://phabricator.wikimedia.org/T336305) (owner: 10Eileen) [02:49:27] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Update WMF_donor fields - https://phabricator.wikimedia.org/T331919 (10Eileenmcnaughton) [02:49:29] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: WMF donor fields are running out - https://phabricator.wikimedia.org/T322176 (10Eileenmcnaughton) [02:49:47] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Update WMF_donor fields - https://phabricator.wikimedia.org/T331919 (10Eileenmcnaughton) [02:58:01] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Update WMF_donor fields - https://phabricator.wikimedia.org/T331919 (10Eileenmcnaughton) I'm documenting fr-tech steps in ca... [03:02:06] shooting out now - but will try to jump back on IRC while I'm out in 30 mins ish [03:04:05] (03CR) 10Ejegg: "Looks like nice enhancements. One comment in line that should have properly gone on the parent patch." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928184 (https://phabricator.wikimedia.org/T336305) (owner: 10Eileen) [03:04:47] eileen_: shoot, sorry I didn't see your earlier ping [03:04:55] I just found one lil thing to fix [03:05:06] I'll make a quick followup patch and +2 your existing one [03:12:33] (03PS1) 10Ejegg: Fix field filtering for :label and :description [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/929811 (https://phabricator.wikimedia.org/T336305) [03:20:37] (03CR) 10Ejegg: [C: 03+2] "Looks good! For ease of deployment I'll merge this now and have added a small follow-up patch to get the base fields automatically include" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928184 (https://phabricator.wikimedia.org/T336305) (owner: 10Eileen) [03:27:45] ejegg: cool - I'm online now but can't do hang out from here [03:28:10] ah well [03:28:51] does that look like the right place to get the base fields selected? [03:29:07] yeah - probably just checking [03:29:24] It seems to work to get the spurious 'Non-Donor' to go away [03:29:53] I guess the tldr is that [03:29:53] a) my high-estimate is that the donor segment fields cost 6% in performance and [03:29:53] b) my testing was massively messed up because on staging the joins slowed it to a crawl [03:29:53] - I created https://phabricator.wikimedia.org/T339055 [03:32:45] ahhh, so we need to purge between runs for those duplicate-ish donations to not mess things up [03:32:55] ejegg: I think I tried to do what your patch does in the GET class - but am assuming it isn't working in the current iteration [03:33:16] ejegg: yeah well the question is whether those duplicates + slowness are a canary or a diversion [03:33:31] (03Merged) 10jenkins-bot: Add segment calculation information to contact's contribution tab to support our QA efforts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928184 (https://phabricator.wikimedia.org/T336305) (owner: 10Eileen) [03:34:25] I think my recommendation is that we tentatively go ahead with the trigger approach but caveat that there might be a performance trade off & we should pick that up once the fields are populated & review along with the join fields [03:35:16] eileen_: OK, sounds worth trying. [03:35:37] so I'm just checking out your patch - I don't suppose you have a contact on staging that applies? [03:35:40] Any thoughts on recalculating donors whose data doesn't change but whose donations may slide out of the window? [03:35:54] eileen_: I was getting 'Non Donor' for everyone [03:36:04] since it wasn't ending up selecting anything [03:36:33] hmm - that wasn't the case on staging (although code seems to be on a diferent branch now) [03:36:37] tbh i'm not sure how staging is getting anything [03:37:00] yeah - I suspect that a rebase / conflict resolution brought in a change [03:37:00] oh let me look at where you were trying to do that in the Get class [03:37:19] oh I can't ssh from here [03:38:10] yep what I'm now seeing locally has changed [03:38:48] ohhh [03:38:51] I see [03:38:55] I'll fix my fix [03:39:06] you build up that $selectFields local var [03:39:15] but then you pass the instance property to the filter fn [03:39:19] ejegg: did I break it when I rebased here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/927966/14..15/drupal/sites/default/civicrm/extensions/wmf-civicrm/Civi/Api4/Action/WMFDonor/Get.php [03:39:56] that looks like an intentional change (remove a comment) + an accidental change - pass a different variable [03:40:38] (03PS2) 10Ejegg: Fix field filtering for :label and :description [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/929811 (https://phabricator.wikimedia.org/T336305) [03:40:59] ok, PS2 just restores your original intent there [03:41:34] derp, needs array_keys [03:42:17] (03PS3) 10Ejegg: Fix field filtering for :label and :description [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/929811 (https://phabricator.wikimedia.org/T336305) [03:42:38] ok, that makes it look like the pre-rebase [03:43:03] (03CR) 10Eileen: [C: 03+2] "Yep - lost this in a rebase! thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/929811 (https://phabricator.wikimedia.org/T336305) (owner: 10Ejegg) [03:43:42] ejegg: cool - are you able to deploy - port is blocked for me here [03:43:50] yep, I can do that [03:46:04] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/929812 [03:46:09] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/929812 (owner: 10Ejegg) [03:55:33] ejegg: thanks for merging all that - it's always nerve-wracking having such a big swath of code in the review queue [03:57:14] (03Merged) 10jenkins-bot: Fix field filtering for :label and :description [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/929811 (https://phabricator.wikimedia.org/T336305) (owner: 10Ejegg) [03:57:17] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/929812 (owner: 10Ejegg) [03:59:57] :) [04:01:09] !log civicrm upgraded from a675c2c9 to fd87e0df [04:01:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:01:25] woohoo [04:02:32] I think I found a bug.... in the wording or imploding really [04:02:32] "Consecutive - gave in last 12 months and 12 months prior - ie [04:02:32] at least $0.01 between 2022-06-14 16:01:45 and 2023-06-14 16:01:45 OR [04:02:32] at least $0.01 between 2021-06-14 16:01:45 and 2022-06-14 16:01:45" [04:02:36] hmm, might need a flush to get that new segments page showing [04:03:12] initiating menu rebuild (it's a url) [04:03:27] oh oops [04:03:34] i just initiated a full flush [04:04:16] well, the page shows up [04:04:50] :-) [04:06:02] it looks like I at least tried with consecutive - $clauses = implode(' AND ', $rangeClauses); [04:07:01] ok - I'm only imploding textClauses at the end but rangeClauses 'as I go' - hence the AND not OR there [04:07:07] ahh [04:07:10] in addCriteriaInterpretation [04:07:22] yep [04:07:26] (I can't fix that from here due the ssh port issue) [04:07:43] man, LYBUNT was kid stuff compared to this... [04:07:45] - unless I tunnel but I'll be gone by the time I sort that - [04:07:46] lol [04:08:05] I can take a stab at that OR fix, let me see [04:08:14] cool - I CAN +2 from here :-) [04:13:53] (03PS1) 10Ejegg: Fix 'multiple_range' text descriptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/929813 (https://phabricator.wikimedia.org/T336305) [04:13:59] let me just smoke test that [04:17:36] yep looks good locally [04:18:39] code looks good - there is a theoretical thing where we would mix & match the 'types' of criteria - in which case we would need to re-write to do that - but we aren't at this stage (& had already commented that too I think) [04:18:50] (03CR) 10Eileen: [C: 03+2] Fix 'multiple_range' text descriptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/929813 (https://phabricator.wikimedia.org/T336305) (owner: 10Ejegg) [04:19:01] ok - that is merging! [04:24:29] ejegg: it is still going to be crazy complicated to decide the WHERE clause for updates - ie UPDATE (insert calculated stuff here ) WHERE last_donation_date = x is the easy version & we can do that for 6 months ago, 1 year ago etc - but that won't cover them aging out of tiers... [04:24:47] or maybe it will - I guess I have to dig in [04:24:53] 10Fundraising-Backlog: Fixing recurring amounts fields to account for reactivating expired donations and downgrading amounts - https://phabricator.wikimedia.org/T338917 (10MSuijkerbuijk_WMF) Hi @Ejegg Please let me know once this field has been implemented also for lapsed recurring as agreed in our call. This al... [04:27:36] eileen_: yeah, that'll at least be possible to programatically determine based on the ranges in the declarative definitions of each field [04:28:15] and it would just be the status_id I guess - since the segment seems to always depend on things that would fire the triggers [04:29:53] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/929814 [04:29:56] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/929814 (owner: 10Ejegg) [04:32:40] (03Merged) 10jenkins-bot: Fix 'multiple_range' text descriptions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/929813 (https://phabricator.wikimedia.org/T336305) (owner: 10Ejegg) [04:32:42] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/929814 (owner: 10Ejegg) [04:33:19] hmm you can 'age out' of tiers [04:34:04] !log civicrm upgraded from fd87e0df to d61220cd [04:34:05] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:34:16] ah ok, so you'd need to update both then [04:36:40] worse than that - you need to know when their cumulative donation has fallen below x [04:37:04] oh man [04:37:23] also - they could 'bounce' - e.g gave 5000 in Jan & 5000 in June and 5000 in feb [04:37:46] that migh tnot be right - but there might be a time when the money falls as 10k & when it falls as 5k [04:40:23] hmm, so maybe you need to recalculate based on ANY donation passing one of the range markers? [04:41:38] err, recalculate a contact's segment based on any of that contact's donation passing a marker [04:42:49] hmm - I'm gonna try to flesh out some edge cases for the stakeholders on the phab cos I think it gets weirder than that [04:46:32] cool cool, i'm a bit too tired to quite wrap my head around it now [04:46:35] gonna head to bed [04:46:43] have a good rest of your day! [05:12:11] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/929845 (owner: 10L10n-bot) [05:38:20] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Investigate feasiblily of the queries for the contact coding - https://phabricator.wikimedia.org/T336305 (10Eileenmcnaughton) With @ejegg's help I got code out today onto... [05:45:03] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Backfill new segment fields - https://phabricator.wikimedia.org/T339066 (10Eileenmcnaughton) [05:45:17] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Backfill new segment fields - https://phabricator.wikimedia.org/T339066 (10Eileenmcnaughton) a:03Eileenmcnaughton [05:46:21] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog: Investigation: Scope Segmentation in Civi & Acoustic - https://phabricator.wikimedia.org/T335376 (10Eileenmcnaughton) [05:46:23] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Update WMF_donor fields - https://phabricator.wikimedia.org/T331919 (10Eileenmcnaughton) [05:48:33] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog: Add new wmf donor segment fields on prod - https://phabricator.wikimedia.org/T339067 (10Eileenmcnaughton) [05:50:52] 10Fundraising-Backlog: Figure out how to schedule crons to update contacts aging out of segments & statuses - https://phabricator.wikimedia.org/T339068 (10Eileenmcnaughton) [05:53:45] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Investigate feasiblily of the queries for the contact coding - https://phabricator.wikimedia.org/T336305 (10Eileenmcnaughton) (I've moved this to done as I think the work... [06:04:58] 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Juggalology 2022, 10Fundraising Sprint Kermit hopping principle, and 7 others: Currency code/currency symbol in Thank You emails received by Donors issu... - https://phabricator.wikimedia.org/T309349 [06:10:46] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add UK postcodes to geocoder DB - https://phabricator.wikimedia.org/T338965 (10Eileenmcnaughton) We should check the civi geocoder extension itself - I'm sure I merged something from a UK contributor but not sure the details [06:23:51] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog: Investigation: Scope Segmentation in Civi & Acoustic - https://phabricator.wikimedia.org/T335376 (10Eileenmcnaughton) Moving this to done since I think we are moving into s... [09:51:35] 10fundraising-tech-ops: Fundraising Access to Superset and Civi for Eliza White - https://phabricator.wikimedia.org/T339095 (10RLewis) [11:11:10] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/930066 (owner: 10L10n-bot) [14:11:59] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Adyen: we don't deal well with two responses on same merchant ID - https://phabricator.wikimedia.org/T183155 (10AKanji-WMF) @Ejegg think this is safe to close out? Not sure if this issue still occurs. [14:13:59] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Yellow hornets of kindness and healing, 10Fundraising Sprint Zeitgeistbusters, 10Fundraising-Backlog, and 2 others: As an email stats updater, I need to find results for a send that is missing ... - https://phabricator.wikimedia.org/T269811 [15:18:01] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Update WMF_donor fields - https://phabricator.wikimedia.org/T331919 (10greg) Per: > We need an outage to update these & nee... [15:35:39] (03PS1) 10Damilare Adedoyin: Update code references to contribution_tracking in recurring_get_contribution_tracking_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930204 (https://phabricator.wikimedia.org/T334537) [16:23:47] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/930066 (owner: 10L10n-bot) [16:47:09] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Update WMF_donor fields - https://phabricator.wikimedia.org/T331919 (10ERoden-WMF) Hi @Eileenmcnaughton I checked with Major... [16:57:11] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [17:02:11] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [17:07:11] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [17:12:11] RECOVERY - check_mysql on frdb2003 is OK: Uptime: 1202980 Threads: 5 Questions: 458942142 Slow queries: 492 Opens: 3975 Open tables: 1856 Queries per second avg: 381.504 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [17:19:51] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog: Update code references to contribution_tracking - recurring_get_contribution_tracking_id in recurring.module - https://phabricator.wikimedia.org/T339157 (10Damilare) [17:21:52] (03PS2) 10Damilare Adedoyin: Update code references to contribution_tracking in recurring_get_contribution_tracking_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930204 (https://phabricator.wikimedia.org/T339157) [17:23:16] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Patch-For-Review: CT-to-Civi-Phase 1.5 - Update code references to contribution_tracking - https://phabricator.wikimedia.org/T334537 (10Damilare) [17:24:01] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog: Update code references to Contribution tracking: wmf_civicrm_get_contribution_tracking in tracking.inc - https://phabricator.wikimedia.org/T339158 (10Damilare) [17:26:39] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Patch-For-Review: CT-to-Civi-Phase 1.5 - Update code references to contribution_tracking - https://phabricator.wikimedia.org/T334537 (10Damilare) [17:51:32] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Yellow hornets of kindness and healing, 10Fundraising Sprint Zeitgeistbusters, 10Fundraising-Backlog, and 2 others: As an email stats updater, I need to find results for a send that is missing ... - https://phabricator.wikimedia.org/T269811 [18:12:24] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Review CiviCRM indexes in order to reduce disk space & improve performance - https://phabricator.wikimedia.org/T126388 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF This appears to have been resolved - please re-open if... [18:14:54] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10FR-Email: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330 (10AKanji-WMF) @Ejegg checking to see if this relates to the current pref center work, or if it can be closed. [18:15:42] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert exchange rates module to an extension - https://phabricator.wikimedia.org/T270666 (10AKanji-WMF) Relates to moving Civi off Drupal - moving to "medium future" [18:17:00] (03PS1) 10Damilare Adedoyin: Update code references to Contribution tracking: wmf_civicrm_get_contribution_tracking in tracking.inc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930228 (https://phabricator.wikimedia.org/T339158) [18:17:11] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [18:19:38] (03PS3) 10Damilare Adedoyin: Update code references to contribution_tracking in recurring_get_contribution_tracking_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930204 (https://phabricator.wikimedia.org/T339157) [18:20:54] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog: Upddate code references to contribution_tracking: civicrm_api3_fredge_get in wmffraud/api/v3/Fredge/Get.php - https://phabricator.wikimedia.org/T339160 (10Damilare) [18:21:14] 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint Incantation optimisation, and 7 others: Syn group to Acoustic should remove any existing queues before c... - https://phabricator.wikimedia.org/T306855 [18:22:11] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [18:22:19] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Patch-For-Review: CT-to-Civi-Phase 1.5 - Update code references to contribution_tracking - https://phabricator.wikimedia.org/T334537 (10Damilare) [18:23:22] 10Fundraising Sprint Incantation optimisation, 10Fundraising Sprint Juggalology 2022, 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, and 2 others: Testmeister esMX email is different from what we have set up in th... - https://phabricator.wikimedia.org/T307704 [18:26:11] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Investigate keeping testmeister or re-creating it in civi - https://phabricator.wikimedia.org/T308262 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF Hi @CDenes_WMF - can we please connect about this task - I want to check in to see if this tool is... [18:27:11] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [18:32:11] RECOVERY - check_mysql on frdb2003 is OK: Uptime: 1207780 Threads: 5 Questions: 459458599 Slow queries: 511 Opens: 3982 Open tables: 1856 Queries per second avg: 380.415 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [18:32:38] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Yellow hornets of kindness and healing, 10Fundraising Sprint Zeitgeistbusters, 10Fundraising-Backlog, and 2 others: As an email stats updater, I need to find results for a send that is missing ... - https://phabricator.wikimedia.org/T269811 [18:49:03] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Check box no longer available on merging screen! - https://phabricator.wikimedia.org/T336806 (10Cstone) 05Open→03Resolved a:03Cstone I talked to @SHust about the current deduper rule to always keep opt-out as well as how once i... [19:25:23] (03PS10) 10Damilare Adedoyin: Handle submission of new recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/928066 (https://phabricator.wikimedia.org/T335796) [20:02:48] (03PS1) 10VolkerE: build: Update SVGO to v3.0.2 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/930241 (https://phabricator.wikimedia.org/T339162) [20:09:56] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Update WMF_donor fields - https://phabricator.wikimedia.org/T331919 (10Eileenmcnaughton) @ERoden-WMF - so they need calendar... [20:32:31] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add UK postcodes to geocoder DB - https://phabricator.wikimedia.org/T338965 (10Ejegg) Nice @Eileenmcnaughton it looks like they did the coding work and left instructions for importing the dataset in the readme: https://github.com/eileenmcnaughton/org.wiki... [20:37:56] not that excited to be away [20:40:10] anilk: looking at Rosie's question - the idea of gift offices getting emails when they receive certain amounts / other criteria is in the sk goals - although I think the first stage is quite small (budget wise) so it is mostly the underlying work (not much UI) - I haven't seen much so show COleman has started on it but not sure contract state [20:40:28] thanks eileen_ [20:40:45] I think if we're setting the foundations etc that's good [20:40:51] are you around tomorrow eileen_ or on a plane [20:41:26] yeah - I'm about - I don't normally work on (m y) Fridays but can make time [20:42:10] aw okay, thank you - just in case I can get a call with Erica and or follow up with Sheetal if they need it [20:44:47] sure - I have a meeting with CiviCRM core team at 9am my time but can be flexible other than that - but tbh I suspect Sheetal needs more time to process than 1 day [20:44:56] agreed [20:47:24] Hi eileen_,I have a new patch to update segment 1 for data axle if you got time :) thanks. [20:47:28] (03PS1) 10Eileen: Fix mid-tier to 5 years [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930255 (https://phabricator.wikimedia.org/T336305) [20:47:49] wfan: cool - yes I was going to check that - thanks for reminding me - I'll look now [20:48:04] Thanks 😊 [20:48:17] ejegg: see https://gerrit.wikimedia.org/r/930255 - this is where I thank past me cos it's a teeny patch [20:49:37] 10Fundraising Sprint Cheese String Theory, 10Fundraising Sprint Discworld reformatted as ntfs, 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint Incantation optimisation, and 7 others: Syn group to Acoustic should remove any existing queues before c... - https://phabricator.wikimedia.org/T306855 [20:51:35] anilk: the problem with the hold-meeting at 8am is that I have to set my alarm to get up for it & I don't know if there is a meeting or not [20:52:06] Sorry! Just waiting for Erica to get off a call- should know in 15 mins! [20:55:18] cool [21:03:28] looking eileen [21:04:07] and now i understand the bounciness you were mentioning yesterday [21:04:46] (03CR) 10Ejegg: [C: 03+2] Fix mid-tier to 5 years [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930255 (https://phabricator.wikimedia.org/T336305) (owner: 10Eileen) [21:05:46] ejegg: yeah it took a bit to articulate it [21:06:28] wfan: I'm gonna try your patch on staging. I don't know how sql will handle those subqueries but there is one way to find out... [21:10:07] ok - started running on staging [21:10:51] it ran! [21:14:18] (03CR) 10Eileen: [C: 03+2] "This ran through on staging & the one i spot checked looks right" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/929796 (https://phabricator.wikimedia.org/T336891) (owner: 10Wfan) [21:17:21] Thx Eileen [21:18:13] (03Merged) 10jenkins-bot: Fix mid-tier to 5 years [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930255 (https://phabricator.wikimedia.org/T336305) (owner: 10Eileen) [21:18:27] oh hey, https://wikitech.wikimedia.org/wiki/Fundraising/External-facing/CiviProxy is out of date - we DO have a working setup via setup.sh now [21:27:52] ok, that's roughly updated with the current state of things [21:28:18] oops, not quite [21:29:04] (03Merged) 10jenkins-bot: Data Axle project - update segment 1 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/929796 (https://phabricator.wikimedia.org/T336891) (owner: 10Wfan) [21:36:02] 10Fundraising-Backlog, 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-extensions-CentralNotice, 10Technical-Debt: [Maintenance request] CentralNotice should not use SkinTemplateNavigation hook to add special page tabs - https://phabricator.wikimedia.org/T315562 (10Jdlrobson) Could this be prioritized fund... [21:41:26] lol I filled out the DISC survey - I wonder how different the results would have been post-coffee [21:43:28] 10fundraising-tech-ops: Fundraising Access to Superset and Civi for Eliza White - https://phabricator.wikimedia.org/T339095 (10Dwisehaupt) SSL Certificate created and sent via email. Password sent via SMS. Civi account created and random password set. Superset account created and random password set. Instruction... [21:43:56] yeah. pre and post coffee personas are real. [21:50:07] (03CR) 10Eileen: [C: 03+2] "This makes me happy - kudos for including a test" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930228 (https://phabricator.wikimedia.org/T339158) (owner: 10Damilare Adedoyin) [21:54:57] 10Fundraising-Backlog, 10fundraising-tech-ops: Fr-Tech 2022q4 maintenance window - https://phabricator.wikimedia.org/T333485 (10Dwisehaupt) [21:57:06] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10FR-Email: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330 (10Ejegg) Hi @AKanji-WMF , this isn't directly related to the current Recurring Upgrade work, but it would be great to do... [21:58:30] heyy fr-tech any objections if I assign myself this one? T315562 [21:58:31] T315562: [Maintenance request] CentralNotice should not use SkinTemplateNavigation hook to add special page tabs - https://phabricator.wikimedia.org/T315562 [21:59:33] Sure AndyRussG|vol, as far as I'm concerned that seems like fair game for someone wearing a volunteer hat! [22:00:07] cool thx ejegg! [22:00:20] oh, and I see there is a nudge on the task too [22:00:24] thank you! [22:00:46] 10Fundraising-Backlog, 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-extensions-CentralNotice, 10Technical-Debt: [Maintenance request] CentralNotice should not use SkinTemplateNavigation hook to add special page tabs - https://phabricator.wikimedia.org/T315562 (10AndyRussG_volunteer) a:03AndyRussG_volun... [22:01:11] ;) [22:02:24] eileen_: so one difference between the spreadsheet ask and the current implementation that I can see being a sticking point is this: [22:02:44] someone who gives 10k 3 yrs ago, then $10 for the next two years [22:02:53] (03CR) 10Eileen: "I think there is an issue here with the array rather than id being potentially returned" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930204 (https://phabricator.wikimedia.org/T339157) (owner: 10Damilare Adedoyin) [22:03:13] would be considered lapsed by the spreadsheet but current by the implementation [22:04:57] ejegg: yeah - will see what they come back with the lapsed meaning bounces around. But, there are quite a few challenges on implementation still so I figure we can let those definition quibbles 'brew' a bit & work on figuring out how we would actually make it work. Switching to their definition adds a lot to the case statement so we need to figure out how that affects performance [22:06:56] although I'm not sure that my understanding of the spreadsheet is that they would be lapsed - you are suggesting the spreadsheet defines 'still a donor but not a major donor' as lapsed - that's not how I understand it -but I also find it hard to understand [22:07:17] right, I guess it makes sense [22:07:32] to know that someone who gave a lot once hasn't given a lot again [22:08:46] yeah - so that is what you think the spreadsheet is trying to get at? Cos that wasn't what I took from the conversation we had - but I also think the spreadsheet is really really hard to understand & open to multiple interpretations [22:09:47] yeah, I guess Sheetal's stressing the importance of the order on the spreadsheet made me understand it that way [22:10:11] i.e. they really care about the categorization of the people giving us the most money, so those criteria are at the top [22:10:25] (03Merged) 10jenkins-bot: Update code references to Contribution tracking: wmf_civicrm_get_contribution_tracking in tracking.inc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930228 (https://phabricator.wikimedia.org/T339158) (owner: 10Damilare Adedoyin) [22:10:34] which is why it becomes increasingly hard to process as you get further down.... [22:10:51] yeah, probably we could convince them to merge or revise the lower rows [22:11:49] I think the year band is problematic & something like 'gave > x over x years' is better than the within-a-year [22:12:34] or else 'once a major donor always a major donor & now it is just a question of how lapsed they are' [22:12:37] yep, sounds like Sheetal understood the potential bounciness there so hopefully they'll agree to that [22:13:19] i just wonder what's so wrong with using the fixed year (calendar or fiscal) windows [22:13:28] yeah - if they look at 'real donors' and flesh out use cases on them I think that will help [22:13:36] i guess that's got it's own bounciness though [22:13:56] yep yep agreed that the real world data will help [22:14:40] Re calendar of fiscal - yeah it bounces more but for a person looking at it they would be able to make sense of it rather than major gifts officer 'this is wrong', fr-tech: no it was calculated on 8 Aug and it was right on that day [22:15:17] bleck [22:16:15] I wonder if part of happened is they really cared about major & major-ish donors but then felt for completeness had to fill it right down to row 39 or whatever & in doing so created a monster that made it really prohibitive to do the bit they really cared about [22:16:17] well [22:16:42] or in a way that we can manage from a keeping it up-to-date pov [22:17:40] anyway - hopefully having a first cut will help us simplify where we can & flesh it out where it matters [22:19:13] yep yep [22:35:42] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Adyen: we don't deal well with two responses on same merchant ID - https://phabricator.wikimedia.org/T183155 (10Ejegg) 05Open→03Declined Thanks for flagging this @AKanji-WMF - we don't have to worry about this with the current integration. Th... [22:42:50] I like the idea of once a major donor always a major donor - unless they explicitly tell us they don't want to be seen that way [22:48:42] anilk: is ejegg around for that 8am meeting tomorrow? [22:56:18] I don't see an invite eileen_ [22:56:19] oooh I don't know - ejegg I'll invite you [22:56:46] - we don't have a session on it at the offsite do we? [22:56:59] rest of fr-tech, lemme know if you'd like to join, it's at 4pm ET [22:57:05] not AFAIK [23:38:41] ejegg: https://github.com/civicrm/civicrm-core/pull/26524 [23:39:11] along with https://github.com/civicrm/civicrm-core/pull/26507 [23:44:11] also - 2 easy merges - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/928964 & https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/929435 [23:57:54] (03PS1) 10Cstone: WIP: Add helpful and remove unhelpful logs from the smashpig recurring job [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930277 (https://phabricator.wikimedia.org/T239770)