[01:11:15] (03PS1) 10Eileen: Add new segment fields on dev rebuilds [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930285 (https://phabricator.wikimedia.org/T339066) [01:14:03] 10Fundraising-Backlog, 10Epic: India Recurring - Post launch issues epic - https://phabricator.wikimedia.org/T339180 (10Cstone) [01:14:28] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Test dlocal India recurring ondemand 2nd charge - https://phabricator.wikimedia.org/T338812 (10Cstone) [01:14:30] 10Fundraising-Backlog, 10Epic: India Recurring - Post launch issues epic - https://phabricator.wikimedia.org/T339180 (10Cstone) [01:14:32] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Notification issues on India recurring cancellations - https://phabricator.wikimedia.org/T338494 (10Cstone) [01:14:34] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Pre-notification received although the recurring set up is canceled in Civi - India - https://phabricator.wikimedia.org/T338309 (10Cstone) [01:15:42] 10Fundraising-Backlog, 10Epic: India Recurring - Post launch issues epic - https://phabricator.wikimedia.org/T339180 (10Cstone) [01:15:44] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, 10Recurring-Donations: dLocal recurring INR success rates for 2nd month, post on-demand switch - https://phabricator.wikimedia.org/T338351 (10Cstone) [01:18:52] 10Fundraising-Backlog: India Recurring - Figure out when to actually cancel donations - https://phabricator.wikimedia.org/T339181 (10Cstone) [01:19:15] 10Fundraising-Backlog, 10Epic: India Recurring - Post launch issues epic - https://phabricator.wikimedia.org/T339180 (10Cstone) [01:19:17] 10Fundraising-Backlog: India Recurring - Figure out when to actually cancel donations - https://phabricator.wikimedia.org/T339181 (10Cstone) [01:26:01] 10Fundraising-Backlog: Rows missing from contribution_tracking - https://phabricator.wikimedia.org/T339182 (10Cstone) [01:27:04] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: question re: Adyen audit file May 25th - https://phabricator.wikimedia.org/T337881 (10Cstone) @MBeat33 I made a task for the issue that caused this donation to not get imported {T339182}. Is it alright if I resolve this... [02:25:58] (03PS2) 10Ejegg: Update silverpop in vendor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928964 (owner: 10Eileen) [02:26:11] (03PS3) 10Ejegg: Update silverpop in vendor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928964 (owner: 10Eileen) [02:26:36] (03CR) 10Ejegg: [C: 03+2] Update silverpop in vendor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928964 (owner: 10Eileen) [02:33:51] (03CR) 10Ejegg: [C: 03+2] "Looks good, hit some more-or-less expected discrepancies running on local with custom field names. Curious whether the civicrm_oauth_* tab" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/929435 (https://phabricator.wikimedia.org/T336305) (owner: 10Eileen) [02:34:36] (03PS2) 10Ejegg: Updated generated triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/929435 (https://phabricator.wikimedia.org/T336305) (owner: 10Eileen) [02:40:00] (03Merged) 10jenkins-bot: Update silverpop in vendor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928964 (owner: 10Eileen) [02:41:06] (03PS1) 10Eileen: Add WMF_donor update function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930287 (https://phabricator.wikimedia.org/T339066) [02:48:43] (03PS2) 10Eileen: Add WMF_donor update function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930287 (https://phabricator.wikimedia.org/T339066) [02:57:15] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Update WMF_donor fields - https://phabricator.wikimedia.org/T331919 (10ERoden-WMF) @Eileenmcnaughton just FY, but I'm confir... [02:59:23] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Update WMF_donor fields - https://phabricator.wikimedia.org/T331919 (10Eileenmcnaughton) Thanks @ERoden-WMF - we currently h... [03:01:34] (03CR) 10CI reject: [V: 04-1] Add WMF_donor update function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930287 (https://phabricator.wikimedia.org/T339066) (owner: 10Eileen) [03:09:23] (03PS3) 10Eileen: Add WMF_donor update function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930287 (https://phabricator.wikimedia.org/T339066) [03:11:02] (03PS4) 10Eileen: Add WMF_donor update function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930287 (https://phabricator.wikimedia.org/T339066) [03:12:33] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, and 2 others: Update RecurringQueueConsumer to handle donation upgrades - https://phabricator.wikimedia.org/T335827 (10Ejegg) @JMando Sorry, I can't find my notes from... [03:18:44] (03CR) 10Ejegg: "Just took a quick glance, and it's looking pretty good! Had a random thought and noted it inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/928066 (https://phabricator.wikimedia.org/T335796) (owner: 10Damilare Adedoyin) [03:21:40] (03CR) 10Ejegg: "Looking pretty good at a first glance! Couple of thoughts about what we put in the activity record." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928885 (https://phabricator.wikimedia.org/T335827) (owner: 10Damilare Adedoyin) [03:23:55] (03CR) 10CI reject: [V: 04-1] Add WMF_donor update function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930287 (https://phabricator.wikimedia.org/T339066) (owner: 10Eileen) [03:25:19] (03PS5) 10Eileen: Add WMF_donor update function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930287 (https://phabricator.wikimedia.org/T339066) [03:29:18] (03CR) 10Ejegg: WIP: Add helpful and remove unhelpful logs from the smashpig recurring job (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930277 (https://phabricator.wikimedia.org/T239770) (owner: 10Cstone) [03:38:24] (03CR) 10CI reject: [V: 04-1] Add WMF_donor update function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930287 (https://phabricator.wikimedia.org/T339066) (owner: 10Eileen) [03:44:17] (03PS6) 10Eileen: Add WMF_donor update function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930287 (https://phabricator.wikimedia.org/T339066) [03:58:34] (03PS1) 10Eileen: Drop indexes on older WMFDonor fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930288 (https://phabricator.wikimedia.org/T331919) [05:10:28] (03PS2) 10Eileen: Add new segment fields on dev rebuilds [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930285 (https://phabricator.wikimedia.org/T339066) [05:10:30] (03PS2) 10Eileen: Drop indexes on older WMFDonor fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930288 (https://phabricator.wikimedia.org/T331919) [05:10:32] (03PS1) 10Eileen: Add upgrade to add new segment & year fields to wmf_donor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930289 (https://phabricator.wikimedia.org/T339067) [05:15:17] 10Fundraising-Backlog, 10fundraising-tech-ops: Fr-Tech 2022q4 maintenance window - https://phabricator.wikimedia.org/T333485 (10Eileenmcnaughton) [05:15:48] Just started running wmf donor fields update on staging - lets see how long it takes [05:17:46] that was quick - mostly cos it failed [05:25:12] (03PS1) 10Eileen: Enhanced error reporting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930290 (https://phabricator.wikimedia.org/T331919) [05:52:07] (03PS2) 10Eileen: Add upgrade to add new segment & year fields to wmf_donor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930289 (https://phabricator.wikimedia.org/T339067) [05:52:09] (03PS1) 10Eileen: Drop indexes on older WMFDonor fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930294 (https://phabricator.wikimedia.org/T331919) [05:52:11] (03PS1) 10Eileen: Fix bug where drush output is swallowed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930295 [05:57:49] ok - queries starting again now [06:01:01] well the triggers have run through already - but the add might take longer [06:05:38] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Patch-For-Review: Add new wmf donor segment fields on prod - https://phabricator.wikimedia.org/T339067 (10Eileenmcnaughton) a:03Eileenmcnaughton [06:05:56] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Update WMF_donor fields - https://phabricator.wikimedia.org/T331919 (10Eileenmcnaughton) a:03Eileenmcnaughton [06:07:22] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Backfill new segment fields - https://phabricator.wikimedia.org/T339066 (10Eileenmcnaughton) I've pushed this into review as the attached patches add a WMFDonor::update ap... [06:08:43] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Create update mechanism to Backfill new segment fields - https://phabricator.wikimedia.org/T339066 (10Eileenmcnaughton) [06:10:24] 10Fundraising-Backlog: Figure out how to schedule preliminary updating of segment data - https://phabricator.wikimedia.org/T339186 (10Eileenmcnaughton) [06:18:14] (03CR) 10Wfan: "Looks good, thanks Dami :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927178 (https://phabricator.wikimedia.org/T335795) (owner: 10Damilare Adedoyin) [06:19:26] (03CR) 10Wfan: Handle submission of new recurring upgrade form (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/928066 (https://phabricator.wikimedia.org/T335796) (owner: 10Damilare Adedoyin) [06:20:09] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Do a prune on detail data for activity records of type thank you - https://phabricator.wikimedia.org/T325123 (10Eileenmcnaughton) I tried to figure out what might indicate a deletable string = but querying that table, even with t... [06:22:38] (03Abandoned) 10Eileen: Drop indexes on older WMFDonor fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930288 (https://phabricator.wikimedia.org/T331919) (owner: 10Eileen) [06:22:53] (03Abandoned) 10Eileen: Enhanced error reporting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930290 (https://phabricator.wikimedia.org/T331919) (owner: 10Eileen) [06:38:53] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_40) - 10https://gerrit.wikimedia.org/r/930380 (owner: 10L10n-bot) [06:57:07] 10Fundraising-Backlog, 10fundraising-tech-ops: Fr-Tech 2022q4 maintenance window - https://phabricator.wikimedia.org/T333485 (10Eileenmcnaughton) [07:56:35] (03PS9) 10Wfan: Update RecurringQueueConsumer to handle donation upgrades [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928885 (https://phabricator.wikimedia.org/T335827) (owner: 10Damilare Adedoyin) [07:56:37] (03PS1) 10Wfan: Update recurring upgrade for consume and for getUpgradeable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930515 (https://phabricator.wikimedia.org/T335912) [08:00:57] (03PS11) 10Wfan: Handle submission of new recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/928066 (https://phabricator.wikimedia.org/T335796) (owner: 10Damilare Adedoyin) [08:00:59] (03PS1) 10Wfan: Cancel recurring upgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/929763 (https://phabricator.wikimedia.org/T335912) [08:01:05] (03CR) 10CI reject: [V: 04-1] Update RecurringQueueConsumer to handle donation upgrades [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928885 (https://phabricator.wikimedia.org/T335827) (owner: 10Damilare Adedoyin) [08:01:07] (03CR) 10CI reject: [V: 04-1] Update recurring upgrade for consume and for getUpgradeable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930515 (https://phabricator.wikimedia.org/T335912) (owner: 10Wfan) [12:03:05] (03PS12) 10Damilare Adedoyin: Handle submission of new recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/928066 (https://phabricator.wikimedia.org/T335796) [12:15:34] (03PS13) 10Damilare Adedoyin: Handle submission of new recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/928066 (https://phabricator.wikimedia.org/T335796) [12:19:03] (03CR) 10Damilare Adedoyin: "Thanks ejegg and wfan for the initial reviews, I just updated the patch with the recommended changes." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/928066 (https://phabricator.wikimedia.org/T335796) (owner: 10Damilare Adedoyin) [12:33:35] (03PS13) 10Damilare Adedoyin: Create recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927178 (https://phabricator.wikimedia.org/T335795) [12:40:24] (03PS14) 10Damilare Adedoyin: Create recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927178 (https://phabricator.wikimedia.org/T335795) [13:30:09] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Update WMF_donor fields - https://phabricator.wikimedia.org/T331919 (10ERoden-WMF) Hi @Eileenmcnaughton major gifts just needs FY (not c... [14:21:32] (03PS15) 10Damilare Adedoyin: Create recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927178 (https://phabricator.wikimedia.org/T335795) [14:24:05] (03PS14) 10Damilare Adedoyin: Handle submission of new recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/928066 (https://phabricator.wikimedia.org/T335796) [14:27:54] (03PS16) 10Damilare Adedoyin: Create recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927178 (https://phabricator.wikimedia.org/T335795) [14:28:24] (03PS15) 10Damilare Adedoyin: Handle submission of new recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/928066 (https://phabricator.wikimedia.org/T335796) [14:29:41] (03PS17) 10Damilare Adedoyin: Create recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927178 (https://phabricator.wikimedia.org/T335795) [14:29:49] (03CR) 10CI reject: [V: 04-1] Handle submission of new recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/928066 (https://phabricator.wikimedia.org/T335796) (owner: 10Damilare Adedoyin) [14:30:15] (03PS16) 10Damilare Adedoyin: Handle submission of new recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/928066 (https://phabricator.wikimedia.org/T335796) [14:37:03] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, and 2 others: Update RecurringQueueConsumer to handle donation upgrades - https://phabricator.wikimedia.org/T335827 (10JMando) @Ejegg I think so long as I can see that... [14:41:37] (03CR) 10Krinkle: [C: 03+2] "@Volker: Should we update the mw.o docs as well? The file comment points to https://www.mediawiki.org/wiki/Manual:Coding_conventions/SVG#E" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/930241 (https://phabricator.wikimedia.org/T339162) (owner: 10VolkerE) [14:42:43] (03CR) 10Krinkle: [C: 03+2] build: Update SVGO to v3.0.2 (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/930241 (https://phabricator.wikimedia.org/T339162) (owner: 10VolkerE) [14:55:30] (03Merged) 10jenkins-bot: build: Update SVGO to v3.0.2 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/930241 (https://phabricator.wikimedia.org/T339162) (owner: 10VolkerE) [15:18:46] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, and 2 others: Update RecurringQueueConsumer to handle donation upgrades - https://phabricator.wikimedia.org/T335827 (10Ejegg) @JMando there will be an activity for each... [15:46:24] 10Fundraising-Backlog: Enabling Direct Debit for France Campaign - https://phabricator.wikimedia.org/T339256 (10EMartin) [17:05:45] 10Fundraising-Backlog: India Recurring - Figure out when to actually cancel donations - https://phabricator.wikimedia.org/T339181 (10Cstone) [17:07:29] 10Fundraising-Backlog: India Recurring - Figure out when to actually cancel donations - https://phabricator.wikimedia.org/T339181 (10Cstone) [17:21:09] 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, and 2 others: Update RecurringQueueConsumer to handle donation upgrades - https://phabricator.wikimedia.org/T335827 (10JMando) @Ejegg That would be great! Thank you! [18:04:13] 10fundraising-tech-ops: Fundraising Access to Superset and Civi for Eliza White - https://phabricator.wikimedia.org/T339095 (10Dwisehaupt) [18:05:08] 10fundraising-tech-ops: Fundraising Access to Superset and Civi for Eliza White - https://phabricator.wikimedia.org/T339095 (10Dwisehaupt) 05Open→03Resolved Verified that logins are working for superset and civi. Closing. [18:40:09] 10Fundraising-Backlog, 10fr-donorservices: Dedupe Oddity - https://phabricator.wikimedia.org/T339288 (10SHust) [18:41:14] (03CR) 10Wfan: [C: 03+1] "LGTM, just one thing probably add No, "I'll leave it as is" as amount 0 to the form? otherwise I can add that to my cancel ticket~" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927178 (https://phabricator.wikimedia.org/T335795) (owner: 10Damilare Adedoyin) [18:42:51] (03CR) 10Wfan: [C: 03+2] "LGTM, will add the No, I'll leave it as is to that cancel patch, I think we should treat this selection as cancel instead of upgrade :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927178 (https://phabricator.wikimedia.org/T335795) (owner: 10Damilare Adedoyin) [18:43:11] (03CR) 10Wfan: [C: 03+2] "LGMT :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/928066 (https://phabricator.wikimedia.org/T335796) (owner: 10Damilare Adedoyin) [18:44:09] (03CR) 10Wfan: "Let's fix the test failed, could +2 once fixed :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928885 (https://phabricator.wikimedia.org/T335827) (owner: 10Damilare Adedoyin) [18:44:29] Yeah wfan, I think that route you requested for the 0 is the cancel route. Sorry I forgot to respond to the comments on that [18:44:31] patch [18:44:35] thanks for the CR [18:44:37] (03Merged) 10jenkins-bot: Create recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/927178 (https://phabricator.wikimedia.org/T335795) (owner: 10Damilare Adedoyin) [18:44:57] (03Merged) 10jenkins-bot: Handle submission of new recurring upgrade form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/928066 (https://phabricator.wikimedia.org/T335796) (owner: 10Damilare Adedoyin) [18:55:27] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: question re: Adyen audit file May 25th - https://phabricator.wikimedia.org/T337881 (10MBeat33) 05Open→03Resolved a:03MBeat33 Thanks @Cstone for adding the donor and making the followup Task [18:59:07] 10fundraising-tech-ops: Deactivate fundraising accounts for gpaumier - https://phabricator.wikimedia.org/T339047 (10Dwisehaupt) [18:59:30] 10fundraising-tech-ops: Deactivate fundraising accounts for gpaumier - https://phabricator.wikimedia.org/T339047 (10Dwisehaupt) 05Open→03Resolved [19:14:54] 10Fundraising-Backlog: Enabling Direct Debit for France Campaign - https://phabricator.wikimedia.org/T339256 (10EMartin) It was determined, after speaking with FRTech, that this is something that cannot be easily enabled, despite having it enabled in the Netherlands. In that market it is dovetailed in with the... [19:14:58] 10Fundraising-Backlog: Enabling Direct Debit for France Campaign - https://phabricator.wikimedia.org/T339256 (10EMartin) 05Open→03Resolved a:03EMartin [20:42:15] (03PS2) 10Wfan: Cancel recurring upgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/929763 (https://phabricator.wikimedia.org/T335912) [20:42:41] 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog: Update acoustic export to include new segment fields - https://phabricator.wikimedia.org/T339296 (10Eileenmcnaughton) [20:44:15] (03CR) 10CI reject: [V: 04-1] Cancel recurring upgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/929763 (https://phabricator.wikimedia.org/T335912) (owner: 10Wfan) [20:45:42] 10Fundraising-Backlog: Add field value to WMF donor list of statuses and segments - https://phabricator.wikimedia.org/T339297 (10Eileenmcnaughton) [20:46:15] (03PS3) 10Wfan: Cancel recurring upgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/929763 (https://phabricator.wikimedia.org/T335912) [20:48:13] (03CR) 10CI reject: [V: 04-1] Cancel recurring upgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/929763 (https://phabricator.wikimedia.org/T335912) (owner: 10Wfan) [20:51:32] 10Fundraising-Backlog: Add field value to WMF donor list of statuses and segments - https://phabricator.wikimedia.org/T339297 (10Eileenmcnaughton) e.g so when Katie looks at https://civicrm.wikimedia.org/civicrm/wmf-segment she sees the number that relates to the segment [21:05:00] (03PS4) 10Wfan: Cancel recurring upgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/929763 (https://phabricator.wikimedia.org/T335912) [21:05:32] (03PS2) 10Wfan: Update recurring upgrade for consume and for getUpgradeable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930515 (https://phabricator.wikimedia.org/T335912) [21:05:37] (03CR) 10CI reject: [V: 04-1] Cancel recurring upgrade [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/929763 (https://phabricator.wikimedia.org/T335912) (owner: 10Wfan) [21:19:50] (03CR) 10CI reject: [V: 04-1] Update recurring upgrade for consume and for getUpgradeable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930515 (https://phabricator.wikimedia.org/T335912) (owner: 10Wfan) [21:28:32] (03PS3) 10Wfan: Update recurring upgrade for consume and for getUpgradeable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930515 (https://phabricator.wikimedia.org/T335912) [21:43:31] (03CR) 10Ejegg: "no insight on the test failure yet, but I looked at the use of the 'date' field a bit and I think it would be best to keep returning that " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) (owner: 10Cstone) [21:48:33] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Pre-notification received although the recurring set up is canceled in Civi - India - https://phabricator.wikimedia.org/T338309 (10Cstone) Checked the other logs too, we have records of 175065211.5 and 175065211.6 which were in relation to the May recurri... [21:51:53] (03PS10) 10Wfan: Update RecurringQueueConsumer to handle donation upgrades [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928885 (https://phabricator.wikimedia.org/T335827) (owner: 10Damilare Adedoyin) [21:54:10] (03CR) 10Ejegg: Switch audit contribution tracking lookup to use new table (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) (owner: 10Cstone) [22:09:17] fr-tech I'm failing to get phpunit debugging tests within the IDE under docker, but I remember someone showing us how. Does anyone on now remember what the setup was? [22:11:42] oh look linkedin wants to tell me how :) [22:11:43] https://www.linkedin.com/pulse/phpstorm-docker-phpunit-xdebug-hernan-arregoces [22:13:54] (03CR) 10Wfan: [C: 03+2] "LGTM, update the suggestion from Elliott to at I0db96e9d64522ef78ceef4eb377ff64c3f734cdf" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928885 (https://phabricator.wikimedia.org/T335827) (owner: 10Damilare Adedoyin) [22:16:32] ejegg: looks right, and we have 9003 for xdebug3 like this xdebug.mode=debug [22:16:32] xdebug.idekey=PHPSTORM [22:16:32] ;for xdebug3 [22:16:32] xdebug.discover_client_host=1 [22:16:32] ;for xdebug3 [22:16:32] xdebug.client_port=9003 [22:16:32] ;do not want to turn to yes for cli like phpunit [22:16:33] xdebug.start_with_request=yes [22:16:33] xdebug.client_host=docker.for.mac.localhost [22:18:38] wfan so I've got the xdebug config working pretty well for normal debugging [22:19:04] but I'm trying to get the IDE config working so I can just debug a single test via the little green arrows on the left [22:19:40] and when I try to configure the php interpreter under docker it keeps telling me it's not installed and doesn't have any xdebug extension [22:19:57] oh that one I have not yet config (brand new dev setup here also....), but I remember jack had this set up before, let me find the note [22:19:59] this is under the Run/Debug configurations dialog [22:26:47] (03Merged) 10jenkins-bot: Update RecurringQueueConsumer to handle donation upgrades [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/928885 (https://phabricator.wikimedia.org/T335827) (owner: 10Damilare Adedoyin) [22:30:03] ejegg: I seem to be getting pings from google docs now - not sure if I want to engage but they seem to want a field updated when a recurring is cancelled automatically vs by DR - I wonder if we should just set the status to failed rather than cancelled in that case [22:31:46] (03PS4) 10Wfan: Update recurring upgrade for consume and for getUpgradeable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930515 (https://phabricator.wikimedia.org/T335912) [22:34:43] eileen_: shouldn't that be part of the cancel reason? [22:35:15] or rather, shouldn't those be different sets of options for the cancel-reason-as-dropdown ? [22:35:32] ejegg: see https://docs.google.com/document/d/1BYURwDLFkxjOz4_53fmYHI4g_AOAjivYVk1qUE88NSs/edit & yeah it could go there [22:35:57] I guess it just feels like they are saying 'cancelled by fail is materially different' [22:38:19] ejegg: anilk also see https://phabricator.wikimedia.org/T331919#8934843 [22:38:19] so that is like carte-blanche to remove a tranche of wmf donor fields - except I don't know that ONLY MG cares -i don't quite know how to procede - but reducing those fields might improve our performance &..... [22:40:10] eileen_: so that whole google doc I think is brainstorming the list of options for that cancel reason field, right? [22:40:58] eileen_: that would certainly make it a bit less mind-numbing to look at those lists [22:41:05] (the field removal) [22:47:02] (03CR) 10Ejegg: "Aha, the failure is due to that darn fakedb:" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) (owner: 10Cstone) [22:48:04] ejegg: yeah - I suspect future us will thank current us if we make it an additional custom field but not totally sure - maybe we just fake the options on the form [22:48:19] but if the form changes that will break [22:51:45] ejegg: example for civicrm phpunit test, I add the run/debug with phpunit -> defined in the configuration file, and from the interpreter, choose the one civicrm (add from docker compose, choose service civicrm) [22:52:51] https://usercontent.irccloud-cdn.com/file/Kg5346oP/Screen%20Shot%202023-06-15%20at%203.52.26%20PM.png [22:54:15] (03PS1) 10Ejegg: Reset audit runtime options for each test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930723 [22:55:14] wfan yeah, i'm trying to do the same thing, but when I scroll down in that popup and tell it the path to php it keeps saying php isn't installed [22:55:17] ehh [22:55:32] i have a patch i keep handy to make it possible to debug phpunit via the remote debug [22:58:45] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Reduce the year fields for WMF donor - https://phabricator.wikimedia.org/T339314 (10Eileenmcnaughton) [23:01:08] 10Fundraising Sprint Keep ya HEAD(1) up, 10Fundraising Sprint Last Christmas I gave you my donation, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Update WMF_donor fields - https://phabricator.wikimedia.org/T331919 (10Eileenmcnaughton) @ERoden-WMF I created a new phab to discuss fie... [23:02:02] wfan is that not working - looks right at first blush [23:02:24] what not working? [23:02:29] your screen shot [23:02:36] it works for me [23:02:48] oh cool [23:03:00] so I don't need to help you figure out why it isn't working :-) [23:04:04] I think elliott said his problem is "php not install" but mine's works fine without this warning so not sure what's wrong [23:04:21] anilk: I created https://phabricator.wikimedia.org/T339314 - I guess we can just send an email to ?? all of advancement??? inviting input (I get confused who gets which list) [23:05:20] (03CR) 10Eileen: "last time I saw those words 'fakedb' I found myself in a world of test-pain...." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) (owner: 10Cstone) [23:06:34] (03CR) 10Ejegg: "Rebasing on top of I22b1360f386286da6465d9391939b2fe74fc2b6c (or just squashing that change in) should hopefully fix the test failure" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) (owner: 10Cstone) [23:06:41] Hah ^ I was attempting the start of abandoning the fakedb with that test and yet it still causes issues ! [23:07:44] :) can't die soon enough [23:13:02] eileen_: heh, yeah, wfan was trying to help me with my issue debugging under docker in the IDE: https://phabricator.wikimedia.org/F37106011 [23:13:37] cstone: I have a feeling that I started on what you are doing & backed out cos the fakedb broke me [23:13:52] that 'PHP version: Not installed' and 'Debugger: Not installed' warning is making it not want to try to run tests [23:14:28] wfan this is what I see https://phabricator.wikimedia.org/F37106011 [23:15:18] Eileen I was trying to just write tests using an actual db and that fakedb could just go away hah yet it still causes issues [23:16:09] cstone: how radical of you [23:16:21] ejegg: I just have php in that box - not the path to it [23:16:38] yeah, i tried that first and same result [23:17:10] oh - that is the only obvious difference [23:17:15] ditto for /ust/bin/php7.3 [23:17:22] err /usr [23:37:55] hmm, https://usercontent.irccloud-cdn.com/file/DPGg9b1E/Screen%20Shot%202023-06-15%20at%204.37.15%20PM.png [23:38:15] my php from /etc/php/7.3/cli/php.ini [23:39:17] but also have the xdebug extension not detected, so can run the test with green arrow but can not debug it [23:40:59] eileen_ could I deploy civicrm upgrader to production for segment 1 of data axle? [23:42:09] wfan: I don't think my patches for next week are merged to it yet are they? If not then no blockers - if so they would need to be temporarily commented out [23:44:14] (03PS3) 10Ejegg: Add new segment fields on dev rebuilds [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930285 (https://phabricator.wikimedia.org/T339066) (owner: 10Eileen) [23:44:24] (03CR) 10Ejegg: [C: 03+2] "Works as advertised" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930285 (https://phabricator.wikimedia.org/T339066) (owner: 10Eileen) [23:44:49] (03PS2) 10Ejegg: Drop indexes on older WMFDonor fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930294 (https://phabricator.wikimedia.org/T331919) (owner: 10Eileen) [23:45:17] (03CR) 10Ejegg: [C: 03+2] "Looks good, lines up with the suggestions in the spreadsheet" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930294 (https://phabricator.wikimedia.org/T331919) (owner: 10Eileen) [23:45:56] fr-tech I'm going to take a half day today - see you all on Monday! [23:46:49] wfan: oops, yeah, you might want to do your merge to deployment from the commit before ^^^ those merge [23:47:52] ha, ok [23:57:44] (03Merged) 10jenkins-bot: Add new segment fields on dev rebuilds [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930285 (https://phabricator.wikimedia.org/T339066) (owner: 10Eileen) [23:58:12] (03Merged) 10jenkins-bot: Drop indexes on older WMFDonor fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/930294 (https://phabricator.wikimedia.org/T331919) (owner: 10Eileen) [23:59:54] (03PS1) 10Wfan: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/930729