[00:28:01] (03PS2) 10Eileen: Fix early return on no-records found [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/937193 (https://phabricator.wikimedia.org/T341633) [00:28:03] (03PS1) 10Eileen: Convert PaymentsFraud access to use apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/937201 (https://phabricator.wikimedia.org/T341633) [00:48:36] (03PS7) 10Wfan: Move fundraising-dev convenience scripts to /scripts [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/936714 (owner: 10Jgleeson) [00:48:54] (03CR) 10Wfan: [V: 03+2 C: 03+2] "make sense :)" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/936714 (owner: 10Jgleeson) [00:49:03] (03PS18) 10Wfan: Add config for new fundraising-tools service container [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/936103 (https://phabricator.wikimedia.org/T341017) (owner: 10Jgleeson) [00:49:44] (03PS19) 10Wfan: Add config for new fundraising-tools service container [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/936103 (https://phabricator.wikimedia.org/T341017) (owner: 10Jgleeson) [01:02:06] (03PS5) 10Cstone: Switch audit contribution tracking lookup to use new table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) [01:02:58] 10Fundraising Sprint Message in a JSON blob, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Civi Forget Me button error - https://phabricator.wikimedia.org/T341633 (10Eileenmcnaughton) [01:05:14] 10Fundraising Sprint Message in a JSON blob, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Civi Forget Me button error - https://phabricator.wikimedia.org/T341633 (10Eileenmcnaughton) I've put up a patch for this & it is on staging now. I also put up... [01:10:31] Hey - can someone check? if you look at https://phabricator.wikimedia.org/T309349#8992661 do you see the images he uploaded or just the placeholders? [01:15:29] (03CR) 10CI reject: [V: 04-1] Switch audit contribution tracking lookup to use new table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) (owner: 10Cstone) [01:17:13] cstone: ^^ ? [01:27:38] just placeholders for me eileen [01:27:46] thanks anilk - not just me thgn [01:27:57] https://usercontent.irccloud-cdn.com/file/BybWYxKg/image.png [01:33:06] yeah same eileen [01:33:17] thanks for confirming! [01:33:34] at least I can reply knowing I'm not imagining it [01:42:14] (03PS1) 10Eileen: Improve logging for thank you mailing creating [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/937205 (https://phabricator.wikimedia.org/T340064) [01:45:00] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Are we creating ANY CiviMail records from the TY mailer? - https://phabricator.wikimedia.org/T340064 (10Eileenmcnaughton) I took a look at the code and I think the issue is confusing logging rather... [01:47:12] (03PS6) 10Cstone: Switch audit contribution tracking lookup to use new table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) [01:49:56] hmm so something else... I don't see evidence of jobs running - specifically thank you - am I missing anything [01:56:03] hmm looks like there are just hardly any to go out [02:00:32] (03CR) 10CI reject: [V: 04-1] Switch audit contribution tracking lookup to use new table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) (owner: 10Cstone) [02:01:54] (03PS7) 10Cstone: Switch audit contribution tracking lookup to use new table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) [02:15:04] (03CR) 10CI reject: [V: 04-1] Switch audit contribution tracking lookup to use new table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) (owner: 10Cstone) [02:18:23] eileen: do you remember why the new contribution tracking tables date is called tracking_date? [02:18:53] I think just because it was 'what sort of date is this' ah it's the date of the contribution tracking entry [02:19:25] ahh okay there wasnt a date column before even just our favorite ts haha [02:22:04] oh right - is it autocreated now? [02:22:25] oh yeah - I'm having flashbacks [02:27:56] im just having confusion cause the audit code calls it date which it never was date in the db [02:30:25] haha [02:30:25] $idiotic_date_format = $result['ts']; [02:30:25] $real_timestamp = date_parse($idiotic_date_format); [02:30:57] lol [02:35:16] aw man and the audit date wants a unix timestamp now haha [02:41:46] (03PS8) 10Cstone: Switch audit contribution tracking lookup to use new table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) [02:50:07] (03CR) 10Cstone: Switch audit contribution tracking lookup to use new table (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) (owner: 10Cstone) [02:50:44] (03CR) 10Cstone: Switch audit contribution tracking lookup to use new table (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) (owner: 10Cstone) [02:52:06] eileen: ^ that code will fix one of your why just whys [02:52:53] cstone: yeah that looks better - is it all ready for review now? [02:53:18] yeah hopefully will pass CI now that I got unconfused on the date part [02:54:28] and then will have a way to actually get rid of fake db [02:54:54] woohoo [02:55:07] and woo passed CI [03:00:07] im gona head out have a good rest of your day eileen [03:01:39] c ya [03:14:28] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Are we creating ANY CiviMail records from the TY mailer? - https://phabricator.wikimedia.org/T340064 (10Eileenmcnaughton) Just looking into it I think these are being created OK - However, there is... [03:15:08] (03PS1) 10Eileen: Move CiviMailStore class from the module to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/937209 (https://phabricator.wikimedia.org/T340064) [03:28:00] (03CR) 10CI reject: [V: 04-1] Move CiviMailStore class from the module to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/937209 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [04:37:05] 10Fundraising Sprint Go Your Own Pay, 10Fundraising Sprint Istanbool (not Constantidouble), 10Fundraising Sprint Juggalology 2022, 10Fundraising Sprint Kermit hopping principle, and 7 others: Currency code/currency symbol in Thank You emails received by Donors issu... - https://phabricator.wikimedia.org/T309349 [04:38:31] (03PS2) 10Eileen: Move CiviMailStore class from the module to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/937209 (https://phabricator.wikimedia.org/T340064) [05:01:38] (03CR) 10Eileen: [C: 03+2] "This looks good to me - yay." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) (owner: 10Cstone) [05:07:59] (03PS1) 10Eileen: Follow up tweaks on wmf_audit patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/937213 (https://phabricator.wikimedia.org/T335711) [05:11:27] (03Abandoned) 10Eileen: Fix early return on no-records found [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/937194 (https://phabricator.wikimedia.org/T341633) (owner: 10Eileen) [05:15:24] (03Merged) 10jenkins-bot: Switch audit contribution tracking lookup to use new table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/919940 (https://phabricator.wikimedia.org/T335711) (owner: 10Cstone) [05:42:19] (03PS3) 10Eileen: Fix early return on no-records found [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/937193 (https://phabricator.wikimedia.org/T341633) [05:42:21] (03PS2) 10Eileen: Convert PaymentsFraud access to use apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/937201 (https://phabricator.wikimedia.org/T341633) [07:11:56] 10fundraising-tech-ops, 10Infrastructure Security, 10Infrastructure-Foundations, 10Patch-For-Review: Migrate jgreen out of the ops group and into the fr-tech-admins group - https://phabricator.wikimedia.org/T336231 (10MoritzMuehlenhoff) >>! In T336231#9005441, @Jgreen wrote: >>>! In T336231#9005345, @Morit... [07:12:23] 10fundraising-tech-ops, 10Infrastructure Security, 10Infrastructure-Foundations, 10Patch-For-Review: Migrate jgreen out of the ops group and into the fr-tech-admins group - https://phabricator.wikimedia.org/T336231 (10MoritzMuehlenhoff) a:03MoritzMuehlenhoff [08:58:47] 10fundraising-tech-ops, 10Infrastructure Security, 10Infrastructure-Foundations, 10Patch-For-Review: Migrate jgreen out of the ops group and into the fr-tech-admins group - https://phabricator.wikimedia.org/T336231 (10MoritzMuehlenhoff) >>! In T336231#9007768, @MoritzMuehlenhoff wrote: > Wrt the remaining... [13:43:48] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q3:rack/setup/install frav1003 - https://phabricator.wikimedia.org/T334400 (10Papaul) @Jclark-ctr there is another server connected to port 24 on the switch ` papaul@fasw-c-eqiad# run show interfaces ge-[0-1]/0/24 descriptions Interface Admin... [14:02:01] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q3:rack/setup/install frav1003 - https://phabricator.wikimedia.org/T334400 (10Jclark-ctr) @Papaul frdata1001 has been decom frav1003 is connected to port 24 [14:11:38] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q3:rack/setup/install frav1003 - https://phabricator.wikimedia.org/T334400 (10Papaul) @Jclark-ctr thnaks will setup the new server to use that port [14:39:38] 10fundraising-tech-ops, 10FR-Email: Update Acoustic Unsubscribe landing page domain to be served by a secure wikimedia.org domain - https://phabricator.wikimedia.org/T336000 (10EWilfong_WMF) Checking in on the status of this certificate. Thank you. [15:32:38] 10Fundraising Sprint Message in a JSON blob, 10Fundraising-Backlog, 10FR-Smashpig: Add parameters for Venmo payments to SmashPig Braintree provider - https://phabricator.wikimedia.org/T340799 (10AnnWF) a:03AnnWF [16:54:20] 10Fundraising Tech - Chaos Crew, 10MW-1.40-notes (1.40.0-wmf.21; 2023-01-30): Name changes required for Ingenico 3DS2.0 - https://phabricator.wikimedia.org/T312877 (10XenoRyet) p:05High→03Medium [17:15:14] 10fundraising-tech-ops, 10DC-Ops, 10SRE, 10ops-eqiad: Q3:rack/setup/install frav1003 - https://phabricator.wikimedia.org/T334400 (10Papaul) @Dwisehaupt i update the switch configurations. You should be good now. ` papaul@fasw-c-eqiad# show | compare [edit interfaces interface-range vlan-administration]... [17:52:39] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Cannot merge records with almost exact same information - https://phabricator.wikimedia.org/T341276 (10MDemosWMF) @Eileenmcnaughton Got it - this worked great! Now I know for future situations. Thanks! [18:25:28] 10Fundraising-Backlog, 10fr-donorservices: Investigation: Cancel Paypal Recurring doesn't always cancel on processor side - https://phabricator.wikimedia.org/T341346 (10AMJohnson) Came across another example today. Donor CID 48449038 (Zendesk ticket #1323637) in Civi it showed their recurring donation via Pay... [19:00:11] (03CR) 10Jgleeson: "The first thing I ran into when trying to upgrade my local version was:" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/935532 (https://phabricator.wikimedia.org/T341101) (owner: 10Eileen) [19:03:06] (03CR) 10Jgleeson: "Although I don't think that prevented me upgrading. After making sure composer install had been run to update any potential missing autolo" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/935532 (https://phabricator.wikimedia.org/T341101) (owner: 10Eileen) [19:03:26] (03CR) 10Eileen: "Arg sorry I forgot to spell it out - the next patch in the chain fixes that - all 3 need to run together" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/935532 (https://phabricator.wikimedia.org/T341101) (owner: 10Eileen) [19:05:29] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Cannot merge records with almost exact same information - https://phabricator.wikimedia.org/T341276 (10Eileenmcnaughton) 05Open→03Resolved a:03Eileenmcnaughton [19:05:35] (03CR) 10Jgleeson: Upgrade CiviCRM to 5.64rc (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/935532 (https://phabricator.wikimedia.org/T341101) (owner: 10Eileen) [19:22:11] PROBLEM - check_mysql on frdb2003 is CRITICAL: Access denied for user nagios@localhost https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [19:27:11] PROBLEM - check_mysql on frdb2003 is CRITICAL: Access denied for user nagios@localhost https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [19:32:13] RECOVERY - check_mysql on frdb2003 is OK: Uptime: 66 Threads: 3 Questions: 30974 Slow queries: 0 Opens: 1653 Open tables: 1646 Queries per second avg: 469.303 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [19:42:56] (03PS20) 10Jgleeson: Add config for new fundraising-tools service container [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/936103 (https://phabricator.wikimedia.org/T341017) [20:00:16] (03PS21) 10Jgleeson: Add config for new fundraising-tools service container [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/936103 (https://phabricator.wikimedia.org/T341017) [20:00:53] (03CR) 10Wfan: [C: 03+1] "Let wait for releng to update gitlab, then merge this~ Works great, thanks Jack~" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/936103 (https://phabricator.wikimedia.org/T341017) (owner: 10Jgleeson) [20:04:32] 10Fundraising Sprint Message in a JSON blob, 10Fundraising-Backlog, 10Patch-For-Review: Make acoustic development dev-friendly - https://phabricator.wikimedia.org/T341017 (10CodeReviewBot) jgleeson opened https://gitlab.wikimedia.org/repos/releng/dev-images/-/merge_requests/45 Add new image for fundraising-... [20:10:38] (03CR) 10Jgleeson: Add config for new fundraising-tools service container (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/936103 (https://phabricator.wikimedia.org/T341017) (owner: 10Jgleeson) [20:19:49] (03CR) 10Jgleeson: Add config for new fundraising-tools service container (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/936103 (https://phabricator.wikimedia.org/T341017) (owner: 10Jgleeson) [20:37:04] 10Fundraising-Backlog: Major Gifts team update - no auto Civi TYL suppression - https://phabricator.wikimedia.org/T341263 (10Eileenmcnaughton) I just checked & we are suppressing thank yous on - matching gifts imports / anything using the new / core import interface - benevity - stripe - citibank - trilogy [20:47:37] cstone: did you see my follow on to your patch that I merged? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/937213 [20:49:22] yeah eileen thanks for adding that [20:50:07] I just looked again & all that keep as thing could be avoided by just passing the correct return properties in the api call but whatever - another time [20:51:28] eileen: how did the editable fields with search kit get chosen? Im trying to hack back together a broken recurring [20:51:39] but not all the contribution_recur fields show up in search kit [20:54:19] so probably if you look in contributionrecur.xml they don't have an tag section ? [20:55:34] although they all seem to? [21:00:49] ooh sorry eileen its the contribution I want to edit [21:00:57] I need to tie the contribution to the recurring [21:01:29] although that has a html field too [21:01:31] tag [21:01:57] but maybe that readonly=true? [21:02:04] yeah that [21:02:12] okay thanks [21:02:13] because a normal user would have no good reason to edit [21:02:17] try api explorer? [21:02:18] yeah haha makes sense [21:03:31] what happened is the contribution_recur got into the db but not the contribution somehow [21:03:53] so when the charge job goes to charge it just hangs forever looking for the previous contribution (which also shouldnt be happening but was trying to fix the record first) [21:43:03] 10Fundraising-Backlog: Using Financial Type= Recurring Gifts for all recurring contributions in civi - https://phabricator.wikimedia.org/T341370 (10NNichols) @JMando @MSuijkerbuijk_WMF Would there be a benefit for either of you two to differentiate between the first recurring gift and all subsequent gifts? For... [21:51:35] (03CR) 10Jgleeson: [C: 03+2] "Using a fresh install of 5.61, this patch chain upgraded my local to 5.64. I had a click around and all looks good. logs look good too. I " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/935532 (https://phabricator.wikimedia.org/T341101) (owner: 10Eileen) [21:52:42] (03CR) 10Jgleeson: [C: 03+2] "Upgrade worked as expected! LGTM." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/936827 (https://phabricator.wikimedia.org/T341101) (owner: 10Eileen) [21:53:04] (03CR) 10Jgleeson: [C: 03+2] "Upgrade worked as expected! LGTM." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/936828 (https://phabricator.wikimedia.org/T341101) (owner: 10Eileen) [22:06:32] (03Merged) 10jenkins-bot: Upgrade CiviCRM to 5.64rc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/935532 (https://phabricator.wikimedia.org/T341101) (owner: 10Eileen) [22:08:44] (03Merged) 10jenkins-bot: Remove slow query from upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/936827 (https://phabricator.wikimedia.org/T341101) (owner: 10Eileen) [22:08:46] (03Merged) 10jenkins-bot: Fix upgrade to work around order bug [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/936828 (https://phabricator.wikimedia.org/T341101) (owner: 10Eileen) [22:14:58] 10Fundraising-Backlog: Using Financial Type= Recurring Gifts for all recurring contributions in civi - https://phabricator.wikimedia.org/T341370 (10Cstone) @NNichols thanks for the explanation, is gift just more widely used outside of WMF? We've just had some confusion on if a gift is just a contribution or not,... [22:23:23] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/937539 [22:23:45] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/937539 (owner: 10Eileen) [22:24:28] eileen: im going outside for a bit but ill have my phone if you need any help with the upgrade [22:24:33] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/937539 (owner: 10Eileen) [22:24:41] I've just merged from master to deployment so no other civi patches should be pushed out until I've done the civi upgrade. Includes your audit patch cstone [22:28:14] Ok [23:02:48] so there is one really great thing about school holidays ... the bit where they end [23:24:08] per my email - the outage list is here - https://etherpad.wikimedia.org/p/2023-13-07-civiupgrade-to-5.64 [23:57:23] !log config revision changed from 6ac88ea8 to c543419d [23:57:23] jobs disabled on civi1002 [23:57:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:57:31] hmm - getting confused - I need to do civi1001 too [23:59:16] !log config revision changed from c543419d to ccc33b1e [23:59:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:59:59] oh 2 commits to disable jobs on both civi1001 & 1002 - I think we still only needed the first? Anyway need to revert both when we re-enable