[00:06:14] I'll transfer ^^ to my end of day [00:10:13] cstone: wfan wondering if one of you can merge this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/946641 since it passes tests on Ci that should really be all we need & I'm about to do a composer update elsewhere that could conflict [00:10:51] (03CR) 10Wfan: [C: 03+2] Try upgrading phpunit higher... [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/946641 (owner: 10Eileen) [00:11:01] thanks wfan [00:11:05] Updated np :) [00:12:09] cool [00:12:43] I'm not sure where we are at re the php 7.4 update - I know the gitlab patch was merged but it might need publishing? [00:25:10] (03Merged) 10jenkins-bot: Try upgrading phpunit higher... [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/946641 (owner: 10Eileen) [00:46:17] (03CR) 10Wfan: [C: 03+2] "add ** after email, trigger the new error page, but we could optimize this validation before actually submit the form. while this looks a " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/932332 (https://phabricator.wikimedia.org/T340167) (owner: 10Ejegg) [00:48:41] eileen: I think jack ask someone to deploy gitlab already, but let's confirm with him tomorrow before we merge that patch here [00:49:13] cool - thanks wfan - I've added a note to ask my end of day [00:49:20] (unless you do it first) [00:49:48] I did not and tmr is a random US holiday haha so I will not join the standup [00:52:18] (03CR) 10Wfan: [C: 03+2] remove unwanted config [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/941435 (https://phabricator.wikimedia.org/T317422) (owner: 10Damilare Adedoyin) [00:52:50] (03Merged) 10jenkins-bot: remove unwanted config [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/941435 (https://phabricator.wikimedia.org/T317422) (owner: 10Damilare Adedoyin) [00:53:41] (03Merged) 10jenkins-bot: Add template for email prefs submit error [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/932332 (https://phabricator.wikimedia.org/T340167) (owner: 10Ejegg) [01:05:57] (03PS2) 10Wfan: Improve the name of mapping method. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/937937 (owner: 10Jgleeson) [01:06:26] (03CR) 10Wfan: [C: 03+2] "Looks reasonable~ :)" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/937937 (owner: 10Jgleeson) [01:06:59] (03Merged) 10jenkins-bot: Improve the name of mapping method. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/937937 (owner: 10Jgleeson) [02:46:41] 10Fundraising-Backlog: Acoustic Click-tracking - SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T318188 (10KHaggard) Yes @AKanji-WMF - this ticket was resolved last year. We have the cert and have had click tracking on for a handful of months. [05:32:45] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/947083 (owner: 10L10n-bot) [07:17:56] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/947237 (owner: 10L10n-bot) [07:20:56] (03PS1) 10Eileen: Add custom field to track snoozes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/947311 [07:20:58] (03PS1) 10Eileen: Add code to set snooze [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/947312 (https://phabricator.wikimedia.org/T340040) [07:35:42] (03CR) 10CI reject: [V: 04-1] Add code to set snooze [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/947312 (https://phabricator.wikimedia.org/T340040) (owner: 10Eileen) [11:20:24] 10Fundraising-Backlog, 10Wikipedia-iOS-App-Backlog: Thank you page loading on native application on iOS - https://phabricator.wikimedia.org/T343534 (10Pcoombe) See also T259312 which was the previous task for this [13:16:16] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/946068 (owner: 10L10n-bot) [13:18:15] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/946720 (owner: 10L10n-bot) [13:19:25] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/947083 (owner: 10L10n-bot) [13:20:41] thank you eileen [14:50:35] 10fundraising-tech-ops, 10Infrastructure Security, 10Infrastructure-Foundations, 10SRE, 10SRE-Access-Requests: As an FR-Tech SRE, we want to be able to designate a host for decommissioning - https://phabricator.wikimedia.org/T334154 (10MoritzMuehlenhoff) [14:50:38] 10fundraising-tech-ops, 10Infrastructure Security, 10Infrastructure-Foundations: Migrate jgreen out of the ops group and into the fr-tech-admins group - https://phabricator.wikimedia.org/T336231 (10MoritzMuehlenhoff) 05Open→03Resolved > @MoritzMuehlenhoff sounds good. I'm ok with closing this task. If an... [14:51:33] 10Fundraising-Backlog, 10fr-donorservices: Permission changed for DR agents - https://phabricator.wikimedia.org/T343899 (10SHust) [14:52:41] 10fundraising-tech-ops, 10Infrastructure Security, 10Infrastructure-Foundations: Migrate jgreen out of the ops group and into the fr-tech-admins group - https://phabricator.wikimedia.org/T336231 (10MoritzMuehlenhoff) [14:53:11] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10SRE, 10Patch-For-Review: Create a new group dns-admins - https://phabricator.wikimedia.org/T341440 (10MoritzMuehlenhoff) 05Open→03Resolved @Jgreen @Dwisehaupt AFAICT this should be resolved and you should be able to merge DNS changes just fine.... [15:26:59] (03CR) 10Damilare Adedoyin: [C: 03+1] "Thanks wfan for all the work on this. I added a comment in the "braintree" case statement, because it looks like we may need to discuss a " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/946588 (https://phabricator.wikimedia.org/T334430) (owner: 10Wfan) [15:44:48] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks for all the work on this wfan. LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/945015 (https://phabricator.wikimedia.org/T342594) (owner: 10Wfan) [15:55:34] (03Merged) 10jenkins-bot: Enable monthly convert from DI for braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/945015 (https://phabricator.wikimedia.org/T342594) (owner: 10Wfan) [21:53:35] (03PS1) 10Eileen: Update test to reflect phpunit deprecation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/947440 [21:58:26] (03PS1) 10Eileen: Replace deprecated phpunit function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/947442 [22:27:27] (03PS2) 10Eileen: Add code to set snooze [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/947312 (https://phabricator.wikimedia.org/T340040) [22:43:01] (03CR) 10CI reject: [V: 04-1] Add code to set snooze [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/947312 (https://phabricator.wikimedia.org/T340040) (owner: 10Eileen)