[02:27:30] (03PS1) 10Eileen: Fix MailingJob lookup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954761 (https://phabricator.wikimedia.org/T340064) [02:28:19] (03PS1) 10Eileen: Remove an unused function and variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954762 [02:28:55] (03PS1) 10Eileen: Remove some unused uses, an unnecesary parameter, fix comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954763 [02:29:15] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Are we creating ANY CiviMail records from the TY mailer? - https://phabricator.wikimedia.org/T340064 (10Eileenmcnaughton) 05Resolved→03Open [13:49:48] 10Fundraising Sprint Quit playing games with my Phab 🎶, 10Fundraising-Backlog, 10FR-tech-data-integrity: Making Gift Coding Changes to gifts in July - https://phabricator.wikimedia.org/T344012 (10NNichols) Adding some notes about what exactly this will become after all the other changes have taken place. T... [13:51:23] (03CR) 10Jgleeson: [C: 04-1] "Thanks Dami. I left some comments inline regarding some preexisting DonationInterface code and also linked to a preexisting method I think" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/954299 (https://phabricator.wikimedia.org/T307743) (owner: 10Damilare Adedoyin) [13:56:59] thanks jgleeson for the CR, the addition was because of the recurring charge flow, the DI part works for the initial payment through payments. Thanks for linking that method also, I missed it and for some reason it isn't called in the recurringcharge flow. I'm checking it out now. [13:57:53] np! thanks for the explanation [14:00:00] ok it wasn't implemented for card payments. I guess we'd be needing it there now that we aren't collecting the ids [14:01:12] gotta go pickup Oscar. Back soon! [14:44:05] (03PS4) 10Damilare Adedoyin: Disable Fiscal Number Field in Dlocal ZA [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/953594 (https://phabricator.wikimedia.org/T307743) [14:49:51] (03PS2) 10Damilare Adedoyin: Add Placeholder value in fiscal_number field for Dlocal ZA transactions [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/954299 (https://phabricator.wikimedia.org/T307743) [14:50:21] (03CR) 10CI reject: [V: 04-1] Add Placeholder value in fiscal_number field for Dlocal ZA transactions [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/954299 (https://phabricator.wikimedia.org/T307743) (owner: 10Damilare Adedoyin) [14:51:59] (03PS3) 10Damilare Adedoyin: Add Placeholder value in fiscal_number field for Dlocal ZA transactions [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/954299 (https://phabricator.wikimedia.org/T307743) [14:57:44] 10Fundraising Sprint Quit playing games with my Phab 🎶, 10Fundraising-Backlog, 10FR-tech-data-integrity: Making Gift Coding Changes to gifts in July - https://phabricator.wikimedia.org/T344012 (10JMando) Preferably all changes would only go back as far as July 1, 2023 so as to not require anymore reporting c... [15:19:07] 10Fundraising-Backlog: Data Axle project - New fields in Civi - https://phabricator.wikimedia.org/T336890 (10AKanji-WMF) Thanks! Moving back to triage so we can talk about it today. [16:07:30] 10Fundraising Sprint Quit playing games with my Phab 🎶, 10Fundraising-Backlog: Change non campaign markets from Ingenico to Adyen - https://phabricator.wikimedia.org/T328964 (10EMartin) @AnnWF That is correct. Keep Dlocal wherever it is assigned. Thank you! [18:36:57] (03PS1) 10Wfan: prefer adyen over ingenico for non-campain country and currencies [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/954983 (https://phabricator.wikimedia.org/T328964) [18:38:46] (03CR) 10CI reject: [V: 04-1] prefer adyen over ingenico for non-campain country and currencies [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/954983 (https://phabricator.wikimedia.org/T328964) (owner: 10Wfan) [18:56:03] (03PS2) 10Wfan: prefer adyen over ingenico for non-campain country and currencies [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/954983 (https://phabricator.wikimedia.org/T328964) [19:01:09] 10Fundraising Sprint Quit playing games with my Phab 🎶, 10Fundraising-Backlog: Implement Auto-Rescue retryable failure detection - https://phabricator.wikimedia.org/T340163 (10AnnWF) a:03AnnWF [19:16:11] 10Fundraising Sprint Quit playing games with my Phab 🎶, 10Fundraising-Backlog, 10Wikipedia-iOS-App-Backlog, 10iOS Release FY2023-24: As a donor I want to be able to make an easy and convenient donation via Apple Pay in the Wikipedia app - https://phabricator.wikimedia.org/T288285 (10jgleeson) [19:16:32] 10Fundraising Sprint 🐲 Phab the Magic Dragon, 10Fundraising-Backlog, 10Wikipedia-iOS-App-Backlog, 10iOS Release FY2023-24: fr-tech task: configure ObjectCache::getLocalClusterInstance() to use Memcached - https://phabricator.wikimedia.org/T344710 (10jgleeson) 05Declined→03Open We're bringing this one... [19:46:58] 10Fundraising-Backlog, 10Epic: India Recurring - Post launch issues epic - https://phabricator.wikimedia.org/T339180 (10XenoRyet) [19:47:12] 10Fundraising-Backlog, 10Wikipedia-iOS-App-Backlog, 10iOS Release FY2023-24: As a donor I want to be able to make an easy and convenient donation via Apple Pay in the Wikipedia app - https://phabricator.wikimedia.org/T288285 (10XenoRyet) [19:52:31] 10Fundraising-Backlog, 10Data-Engineering, 10MediaWiki-extensions-CentralNotice, 10Movement-Insights, and 2 others: Unique Devices seasonal trends on small projects - https://phabricator.wikimedia.org/T344381 (10AKanji-WMF) [20:05:03] (03PS1) 10Eileen: Do not update tax_amount to 0 - too slow.... [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954989 [20:14:17] 10Fundraising-Backlog, 10fundraising-tech-ops: Add CSP for Fundraiseup on DonateWiki - https://phabricator.wikimedia.org/T345379 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF Closing after discussion in triage; this is on donatewiki [20:17:54] dwisehaupt: does this look like the timeslot - https://www.timeanddate.com/worldclock/meetingdetails.html?year=2023&month=9&day=8&hour=0&min=0&sec=0&p1=4943&p2=240&p3=248&p4=179&p5=224&p6=136&p7=31 [20:18:48] that looks right to me. [20:30:08] 10Fundraising-Backlog: FR-Tech Systems Snapshot metric ideas - https://phabricator.wikimedia.org/T322266 (10AKanji-WMF) Would need to work on this in the new calendar year, in advance of December push. [20:30:16] (03PS1) 10Wfan: add platform version for m2 chip docker [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/955006 [20:33:05] (03PS2) 10Wfan: add platform version for m1 chip docker [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/955006 [20:36:33] 10Fundraising-Backlog: M1 chip docker setup errors - https://phabricator.wikimedia.org/T345662 (10AnnWF) [20:36:50] (03PS3) 10Wfan: add platform version for m1 chip docker [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/955006 (https://phabricator.wikimedia.org/T345662) [21:04:25] 10Fundraising-Backlog: Matching import - duplicate contribution error - https://phabricator.wikimedia.org/T345665 (10MDemosWMF) [21:05:50] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Matching import - duplicate contribution error - https://phabricator.wikimedia.org/T339050 (10MDemosWMF) I have created a separate, new phab task as advised here: https://phabricator.wikimedia.org/T345665 This can be closed out. @AKanji-WMF @Eileenmcnau... [21:05:59] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/954996 [21:06:32] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Matching import - duplicate contribution error - https://phabricator.wikimedia.org/T339050 (10Eileenmcnaughton) 05Open→03Resolved a:03Eileenmcnaughton [21:07:27] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/954996 (owner: 10Eileen) [21:08:05] damilare: just pushing out a few of your patches - the phabs might be 'done' with those done [21:09:05] !log config revision changed from c2f91f49 to e1c3b7fd [21:09:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:27:04] (03PS2) 10Eileen: Fix MailingJob lookup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954761 (https://phabricator.wikimedia.org/T340064) [21:27:06] (03PS2) 10Eileen: Remove an unused function and variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954762 [21:27:08] (03PS2) 10Eileen: Remove some unused uses, an unnecesary parameter, fix comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954763 [21:27:10] (03PS1) 10Eileen: Always use the same mailing for thank you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955003 (https://phabricator.wikimedia.org/T340064) [21:27:59] ejegg: ^^ switches us to just use one 'thank_you' mailing job - but once we are doing that I will follow up with upgrade script [21:29:13] looking [21:29:21] (03PS2) 10Eileen: Always use the same mailing for thank you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955003 (https://phabricator.wikimedia.org/T340064) [21:31:07] (03PS3) 10Eileen: Always use the same mailing for thank you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955003 (https://phabricator.wikimedia.org/T340064) [21:33:25] (03CR) 10Ejegg: "Looks like we can get rid of the templateName and revision arguments to those functions, too" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955003 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [21:34:04] ejegg: yeah - I think we can get rid of those & quite a bit more - if we just create the mailing via a managed entity then we don't need handling to create it [21:34:16] yep, that too [21:35:23] oh i need to start dinner prep, but i think i can be back in a bit [21:38:36] (03PS1) 10Eileen: Clean up signature on addMailing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955026 (https://phabricator.wikimedia.org/T340064) [21:44:15] (03CR) 10CI reject: [V: 04-1] Always use the same mailing for thank you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955003 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [21:45:50] (03PS1) 10Eileen: Clean up signature on getMailing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955027 (https://phabricator.wikimedia.org/T340064) [21:46:38] (03PS3) 10Eileen: Fix MailingJob lookup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954761 (https://phabricator.wikimedia.org/T340064) [21:53:36] (03PS3) 10Eileen: Remove an unused function and variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954762 (https://phabricator.wikimedia.org/T340064) [21:53:38] (03PS3) 10Eileen: Remove some unused uses, an unnecesary parameter, fix comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954763 (https://phabricator.wikimedia.org/T340064) [21:53:40] (03PS4) 10Eileen: Fix MailingJob lookup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954761 (https://phabricator.wikimedia.org/T340064) [21:53:43] (03PS4) 10Eileen: Always use the same mailing for thank you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955003 (https://phabricator.wikimedia.org/T340064) [21:53:44] 10Fundraising Sprint Quit playing games with my Phab 🎶, 10Fundraising-Backlog: Engage import update - Endowment files - https://phabricator.wikimedia.org/T344445 (10MDemosWMF) This has gone smoothly! No issues with the import and reflects accurately in Civi. Thanks @Eileenmcnaughton - @NNichols FYI I'm going... [21:53:47] (03PS1) 10Eileen: Reformat code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955029 (https://phabricator.wikimedia.org/T340064) [22:08:08] 10Fundraising Sprint Quit playing games with my Phab 🎶, 10Fundraising-Backlog: Engage import update - Endowment files - https://phabricator.wikimedia.org/T344445 (10Eileenmcnaughton) 05Open→03Resolved Great to know @MDemosWMF [22:08:11] 10Fundraising Sprint Quit playing games with my Phab 🎶, 10Fundraising-Backlog: Engage import update - Endowment files - https://phabricator.wikimedia.org/T344445 (10Eileenmcnaughton) [22:47:40] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: M1 chip docker setup errors - https://phabricator.wikimedia.org/T345662 (10AnnWF) [23:04:37] 10Fundraising-Backlog: Spike: Research and task out imports work required for FRUP pilot - https://phabricator.wikimedia.org/T345349 (10AKanji-WMF) [23:09:22] 10Fundraising Sprint Quit playing games with my Phab 🎶, 10Fundraising-Backlog: Review Export Methods for FRUP pilot; determine process and frequency for exports - https://phabricator.wikimedia.org/T345671 (10AKanji-WMF) p:05Triage→03Medium [23:10:28] 10Fundraising-Backlog: Spike: Research and task out imports work required for FRUP pilot - https://phabricator.wikimedia.org/T345349 (10AKanji-WMF) 05Open→03Invalid This task has been replaced by this spike: {T345671 } [23:13:36] (03Abandoned) 10Eileen: Clean up signature on addMailing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955026 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [23:19:03] (03Restored) 10Eileen: Clean up signature on addMailing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955026 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [23:19:14] (03Abandoned) 10Eileen: Clean up signature on getMailing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955027 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen)