[00:31:43] 10Fundraising Sprint Quit playing games with my Phab 🎶, 10Fundraising-Backlog, 10Patch-For-Review: India Recurring - Handle Wallet disabled status in IPNs - https://phabricator.wikimedia.org/T341300 (10Cstone) @jgleeson were you able to set up a test dlocal locally? I wasn't able to trigger an IPN for it. I... [01:16:38] (03CR) 10Cstone: Handle dLocal 'Wallet disabled' IPNs (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/952491 (https://phabricator.wikimedia.org/T341300) (owner: 10Jgleeson) [01:25:53] eileen: I keep getting Subcommand @composer compile returned with error code 1 [01:26:00] when trying to rebuild civi [01:26:03] have you seen that? [01:26:37] oh hmm, perhaps that's just in dmaster [01:26:55] or maybe it just happens once per site rebuild and the third time will be the charm [01:27:15] Argument 1 passed to Composer\EventDispatcher\Event::__construct() must be of the type string, null given, [01:27:18] called in /srv/civi-sites/dmaster/web/sites/all/modules/civicrm/vendor/civicrm/composer-compile-plugin/src/ [01:27:21] Event/CompileTaskEvent.php on line 55 [01:36:49] ok, happens every time but only on dmaster [01:36:57] i'll just comment that out for now in setup [02:02:42] ejegg: have you got the latest build kit - we did go through a rough patch with it [02:03:06] also there are updates to our docker since you went away [02:03:13] yep, i've pulled latest on all the repos [02:03:20] and it builds wmff just fine [02:03:54] so i can review those patches [02:07:06] hmm ok [02:24:43] (03CR) 10Ejegg: [C: 03+2] Remove an unused function and variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954762 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [02:27:21] (03CR) 10Ejegg: [C: 03+2] "Thanks for the updates! Guess the shifting params are a good reason to use APIs instead of Civi internal function calls" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954763 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [02:32:25] (03CR) 10Ejegg: [C: 03+2] "This works and the code looks simpler! I'm still scratching my head as to why the fetch() wasn't returning 1 on success as it proclaims it" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954761 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [02:33:10] (03CR) 10Ejegg: [C: 03+2] "oh i see, it was the job fetch that was failing!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954761 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [02:33:42] (03CR) 10Ejegg: [C: 03+2] Reformat code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955029 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [02:34:25] (03CR) 10Ejegg: [C: 03+2] Always use the same mailing for thank you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955003 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [02:36:54] (03CR) 10Ejegg: "looks good, but seems to need a manual rebase" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955026 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [02:37:53] * ejegg suddenly thinks of reasons to keep template_name... but oh well - maybe we record the ty type and language in the activity record? [02:38:17] ok, I need to head to bed! [02:39:21] (03Merged) 10jenkins-bot: Remove an unused function and variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954762 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [02:42:21] (03Merged) 10jenkins-bot: Remove some unused uses, an unnecesary parameter, fix comments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954763 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [02:47:37] (03Merged) 10jenkins-bot: Fix MailingJob lookup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/954761 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [02:49:09] (03Merged) 10jenkins-bot: Reformat code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955029 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [02:50:12] (03Merged) 10jenkins-bot: Always use the same mailing for thank you [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955003 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [03:24:39] (03PS2) 10Eileen: Clean up signature on addMailing, getMailing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955026 (https://phabricator.wikimedia.org/T340064) [03:26:35] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/955044 [03:26:47] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/955044 (owner: 10Eileen) [03:27:33] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/955044 (owner: 10Eileen) [04:07:33] !log civicrm upgraded from a6fd7d6b to 5a432b1e [04:07:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [06:45:22] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/955221 (owner: 10L10n-bot) [07:09:40] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/955221 (owner: 10L10n-bot) [08:08:53] 10Fundraising-Backlog, 10Wikimedia-Fundraising-Campaigns: Fundraise in China & Hong Kong - https://phabricator.wikimedia.org/T94286 (10Aklapper) [13:33:42] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Successful Adyen transactions not making it into CiviCRM - https://phabricator.wikimedia.org/T345736 (10jgleeson) [14:01:52] jgleeson|skrun: ^ that also happened before when it never got into contribution tracking there is a task for that if that's what's happening with those [14:31:47] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Successful Adyen transactions not making it into CiviCRM - https://phabricator.wikimedia.org/T345736 (10SHust) Adding one more example where several donations were rejected, however, a single larger donation made on the same day was automatically settled... [14:33:32] 10Fundraising-Backlog: Review using CNTCT reference in thank you emails. - https://phabricator.wikimedia.org/T333843 (10AKanji-WMF) AK to meet with DR on September 12/23 to review value [14:34:52] 10Fundraising-Backlog, 10FR-email-preference-center, 10MediaWiki-extensions-DonationInterface: Exception loading Email Preferences opt-in form - https://phabricator.wikimedia.org/T332338 (10AKanji-WMF) Moving to near future while I collect related preference center tasks for prioritization. [14:37:09] 10Fundraising-Backlog, 10FR-donorservices: Permission changed for DR agents - https://phabricator.wikimedia.org/T343899 (10AKanji-WMF) @SHust @Eileenmcnaughton is there documentation anywhere about the levels of permissions and what access they enable? Trying to figure out how to get the team their appropriate... [14:39:09] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Bad query on civicrm mailing dash board - https://phabricator.wikimedia.org/T335071 (10AKanji-WMF) We didn't get a chance to review this in Triage yesterday, @Eileenmcnaughton - trying to gauge how urgent this is and when we should find time to work on it. [14:40:51] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig: Implement cancelPayment for PayPal EC - https://phabricator.wikimedia.org/T324640 (10AKanji-WMF) @Ejegg if you had time to review the EC [[ https://phabricator.wikimedia.org/tag/fr-paypal-expresscheckout/ | workboard ]] and flag anything we s... [14:48:49] 10Fundraising-Backlog, 10Wikimedia-Fundraising-Campaigns: Fundraise in China & Hong Kong - https://phabricator.wikimedia.org/T94286 (10AKanji-WMF) @EMartin are you aware if this is a valid/current request , or should be declined? [14:56:10] 10Fundraising-Backlog, 10Wikimedia-Fundraising-Campaigns: Fundraise in China & Hong Kong - https://phabricator.wikimedia.org/T94286 (10EMartin) @AKanji-WMF The attempts to process here were aborted from my understanding. There is no current ambition to process in China and Hong Kong. [14:57:20] 10Fundraising-Backlog, 10Wikimedia-Fundraising-Campaigns: Fundraise in China & Hong Kong - https://phabricator.wikimedia.org/T94286 (10AKanji-WMF) 05Open→03Declined Thank you! [15:21:17] 10Fundraising-Backlog, 10FR-donorservices: Deduper and legacy merging overwriting issue - https://phabricator.wikimedia.org/T345206 (10AKanji-WMF) Sandra has flagged this is relatively urgent - moving to Sprint+1; cc @Eileenmcnaughton [15:23:07] (03CR) 10Ejegg: [C: 03+2] "Looks good, ->getBody has been deprecated since MW 1.24" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/954113 (https://phabricator.wikimedia.org/T345369) (owner: 10Jforrester) [15:24:56] thanks cstone I'll see if it's related [15:25:03] 10Fundraising Sprint Quit playing games with my Phab 🎶, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Patch-For-Review, 10Wikimedia-production-error: PHP Deprecated: Use of TablePager::getBody Called from SpecialCentralNoticeBanners::showBannerE... - https://phabricator.wikimedia.org/T345369 [15:26:15] (03Merged) 10jenkins-bot: Migrate calls to TablePager::getBody to ::getBodyOutput [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/954113 (https://phabricator.wikimedia.org/T345369) (owner: 10Jforrester) [15:29:15] (03CR) 10Ejegg: [C: 03+2] Clean up signature on addMailing, getMailing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955026 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [15:34:49] (03CR) 10Ejegg: [C: 04-1] "Maybe we just need the country_fields change in this codebase" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/953594 (https://phabricator.wikimedia.org/T307743) (owner: 10Damilare Adedoyin) [15:38:21] (03CR) 10Damilare Adedoyin: "thanks ejegg for the CR, I added a response inline. The former validation was causing a validation error." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/953594 (https://phabricator.wikimedia.org/T307743) (owner: 10Damilare Adedoyin) [15:40:56] 10Fundraising-Backlog, 10FR-donorservices: Permission changed for DR agents - https://phabricator.wikimedia.org/T343899 (10SHust) @AKanji-WMF I do not, however, I can create a spreadsheet with all the DR agents and their Civi permission needs if this helps you and the team. Please just let me know! [15:46:04] (03Merged) 10jenkins-bot: Clean up signature on addMailing, getMailing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/955026 (https://phabricator.wikimedia.org/T340064) (owner: 10Eileen) [15:48:55] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Successful Adyen transactions not making it into CiviCRM - https://phabricator.wikimedia.org/T345736 (10jgleeson) 191327632 is really interesting. It looks like the payment was accepted by Adyen after the donor was redirected to complete 3D Secure, but... [16:12:10] 10Fundraising-Backlog: Add new diagram to dlocal docs covering the new 'Wallet disabled' flow - https://phabricator.wikimedia.org/T345752 (10jgleeson) [16:30:21] 10Fundraising-Backlog: Edit formchooser to redirect Ingenico requests - https://phabricator.wikimedia.org/T345461 (10Dwisehaupt) [16:30:25] 10Fundraising-Backlog: Edit formchooser to redirect Ingenico requests - https://phabricator.wikimedia.org/T345461 (10AnnWF) [16:35:31] 10Fundraising-Backlog: Edit formchooser to redirect Ingenico requests - https://phabricator.wikimedia.org/T345461 (10Ejegg) If we need to also handle direct links to Special:IngenicoGateway we can probably rewire that url to use the Adyen classes via the extension.json "SpecialPages": { } block [16:36:44] hah fr-tech I just needed to press the 'start debugging' button in the ide. [16:36:49] it's slowly coming back to me... [16:42:44] ha ejegg [16:59:28] 10Fundraising Sprint Quit playing games with my Phab 🎶, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.41-notes (1.41.0-wmf.26; 2023-09-12), 10Wikimedia-production-error: PHP Deprecated: Use of TablePager::getBody Called from SpecialCentralN... - https://phabricator.wikimedia.org/T345369 [17:02:38] signs of a good break, [18:17:04] 10Fundraising Sprint Incantation optimisation, 10Fundraising Sprint Quit playing games with my Phab 🎶, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), 10Patch-For-Review: Disable ZA national ID field - https://phabricator.wikimedia.org/T307743 (10Ejegg) @Damilare With the new (dlocal)... [18:20:10] (03CR) 10Ejegg: [C: 04-1] Disable Fiscal Number Field in Dlocal ZA (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/953594 (https://phabricator.wikimedia.org/T307743) (owner: 10Damilare Adedoyin) [18:36:00] (03PS5) 10Damilare Adedoyin: Disable Fiscal Number Field in Dlocal ZA [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/953594 (https://phabricator.wikimedia.org/T307743) [18:52:34] (03PS1) 10Wfan: fix smashpig exception for May not add a required argument after optional arguments already in the stack [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/955381 [20:33:40] 10Fundraising-Backlog: Engage DAF import- duplicate issue - https://phabricator.wikimedia.org/T345773 (10MDemosWMF) [20:40:05] shoot, i guess I missed the whole fortnightly [20:40:11] how did it go? [20:45:26] 10Fundraising-Backlog, 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-extensions-CentralNotice, 10MW-1.41-notes (1.41.0-wmf.16; 2023-07-04), 10Technical-Debt: [Maintenance request] CentralNotice should not use SkinTemplateNavigation hook to add special page tabs - https://phabricator.wikimedia.org/T315562... [20:46:10] Just some random chat, nothing important ejegg [20:51:54] 10Fundraising Sprint Quit playing games with my Phab 🎶, 10Fundraising-Backlog: Measure donation processing rate (once we decide what that is) - https://phabricator.wikimedia.org/T342013 (10Ejegg) I think we have historically focused on 'Save to CRM' rate because that's where we do the most database activity, s... [21:16:41] (03CR) 10Ejegg: "How about for this patch we fix the ZA placeholder in PlaceholderFiscalNumber.php to fit the correct format rather than allowing invalid o" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/953594 (https://phabricator.wikimedia.org/T307743) (owner: 10Damilare Adedoyin) [23:21:33] 10Fundraising-Backlog, 10fundraising-tech-ops: Set up Community CiviCRM instance. - https://phabricator.wikimedia.org/T343486 (10Dwisehaupt) Making progress on the VM testing. Can repeatedly install drupal and civicrm in stock installs but not fully automated yet. Still need to work out some redirect rules to...