[00:05:48] online gift strikes back [00:09:57] hmmmm 'Online Gift\' is not a valid option for field custom_164 it wasn't in the managed files [00:12:03] eileen: is this from some older work ^ I was accidentally on an old civi patch for a while [00:12:47] damilare: added to CalculatedGroups recently-ish [00:13:38] sorry CustomGroups.php [00:14:01] 10Fundraising-Backlog: Internal test: for validate all dlocal submethods - https://phabricator.wikimedia.org/T346814 (10AnnWF) p.s: mercadopago already got removed for now, was added as bt for country AR, BR, CL, CO, MX, and per email, Evelyn want this on hold Below are the newly added types that might need ad... [00:14:02] if it is not in your DB you need to run that syncCustomFields command (I documented it recently in the civi updates) [00:14:08] cstone: [00:14:12] ahh okay the third option! thanks eileen [00:14:24] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Internal test: for validate all dlocal submethods - https://phabricator.wikimedia.org/T346814 (10AnnWF) [00:15:02] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Internal test: for validate all dlocal submethods - https://phabricator.wikimedia.org/T346814 (10AnnWF) a:03AnnWF [00:20:21] hmm its still doing it after running that eileen [00:20:37] so the option value isn't there? [00:21:30] online gift is the new one added? [00:22:02] ahh okay it isnt there [00:22:36] maybe just do a civibuild & grab it that way? [00:23:17] hah i was trying to avoid a rebuild but if thats the answer [00:23:37] i should never try and test anything quickly :P [00:24:16] but i dont think it got added to /dev and that why its not there? [00:24:54] well I dunno but I rebuild probably ever couple of days so it always seems like the first thing to me [00:25:02] hah [00:25:15] do we not have to add these to dev i thought i remembered you adding patches to it [00:25:32] does that rebuild redo the database too ? [00:25:51] so the file is CustomGroups.php - the options should be in there already? Unless I'm confused [00:26:46] ok i see it in there [00:27:20] but if the managed reconcile and sync custom fields dont fix it then just rebuild? [00:27:33] well yeah either than or debug why..... [00:29:20] my dataaa :P [00:29:21] hah okay [00:34:17] nuuu haha [00:34:28] what command do you run to rebuild eileen i just broke cause composer? [00:35:12] maybe i need to reclone the files do you do that a lot ? [00:47:18] cstone: ooh, did you get a composer compile error in rebuilding dmaster? [00:47:24] cause I keep getting that [00:47:32] and I just had to comment out the dmaster install for now [00:47:43] not sure if dmaster or civi but i just recloned the repos and seems ok so far [00:48:16] ah nice [00:49:01] wfan: I'm going to deploy that mercadopago thing [00:49:18] it looks like it will also deploy this: [00:49:19] 150fdc292 prefer adyen over ingenico for non-campain country and currencies [00:49:32] do you want to monitor that deploy? [00:49:46] i figure it should be safe enough [00:50:12] aw man now it just exited on Creating civicrm_* database tables in dmastercivicrm [00:50:12] [Setup:info] [Preboot.civi-setup.php] Load minimal (non-DB) services [00:50:48] ill try the comment out [00:50:50] oh, or I could wait for you to review that patch cstone [00:51:00] well LOL [00:51:03] yah, I still don't understand why dmaster keeps failing for me [00:51:06] everything is now broken [00:51:17] I was just trying to import a donation to review your patch haha [00:51:38] does your fail like Creating civicrm_* database tables in dmastercivicrm [00:51:39] [Setup:info] [Preboot.civi-setup.php] Load minimal (non-DB) services [00:52:12] not even that far - just dies in the composer setup [00:52:20] again, only for dmaster [00:52:30] hmm okay [00:52:43] which i thought used exactly the same civibuild tools as wmff [00:52:59] i can try again [00:53:25] im trying again too [00:54:05] unrelated but current broadway cast of sweeny todd's ablum is out [00:54:47] heh, i somehow missed the sweeny todd craze [00:55:03] as with most genres my musicals knowledge is really inconsistent [00:55:19] i could sing you anything from les miz or west side story [00:55:31] but i couldn't even name a tune from miss saigon or sweeny todd [00:55:33] so those ive never seen west side story and les miz only once haha [00:56:21] the music man? [00:56:30] nope I don't know that many I guess haha [00:56:59] i think i mostly know older ones [00:57:24] a lot of rogers and hammerstein [00:57:42] my high school did put on oklahoma [00:57:55] and REALLY old ones if you want to count gilbert and sullivan [00:57:59] and south pacific [00:58:27] were you in oklahoma? [00:58:36] i wasnt in any of them haha [00:58:40] but all my friends were [00:58:50] hah, so you saw it! [00:58:54] yep [00:58:57] and heard them practicing i bet [00:59:49] yeah ok mine exited in the same place of dmaster setup [01:00:01] oh right, i was going to reclone dmaster [01:00:08] and got into a musicals wikihole [01:00:09] sorry [01:00:43] haha no worries I started it [01:00:50] well its still breaking for me just not composery [01:01:17] im listening to surrey with the fringe on top now haha [01:03:15] i'm listening to 'wells fargo wagon' from 'the music man' [01:03:30] it's about waiting for your Amazon package [01:04:08] https://www.stlyrics.com/lyrics/themusicman/wellsfargowagon.htm [01:05:38] im currently waiting for some hay so perfect [01:05:46] oh ive heard this before [01:08:48] woo okay that finished with dmaster commented out [01:10:02] oh no what did i do i dont have our links haha [01:10:03] noooo [01:10:26] what links? [01:10:32] 10Fundraising Sprint Rasberry Pi Beret 👩🏽‍🎨, 10Fundraising-Backlog: Issue with Paypal donations made on GiveLively for events - https://phabricator.wikimedia.org/T295726 (10Ejegg) > However, if it is easier to keep the existing automatic PayPal import, is there a way that I could pull a list of those PayPal gi... [01:10:47] oh the main page text? [01:11:12] scripts/payments-update-text.sh [01:11:15] yeah haha i must have accidentally hit no [01:11:20] jimmy quote is gone too [01:11:42] yep, that same .sh installs jimmyquote [01:11:48] wo okay [01:13:17] woo test donation in the db! [01:15:22] with appeal? [01:15:32] ooh, want to try a variant one? [01:15:51] should get both appeal and variant populated in the c_t table which wasn't possible before [01:16:04] ok well now that i cna import one at all haha [01:16:17] heh, that's definitely progress [01:17:14] i see appeal in there on master [01:17:59] yep, current state of things is if variant, that goes into appeal (but prefixed with v=) [01:18:09] and if no variant, the appeal goes into appeal [01:18:44] ahh okay [01:19:22] ohhhh i'm running the installer with debug start_with_request on for the cli [01:19:26] that's why it's taking forever [01:20:47] oh, this is a useful lil volunteer centralnotice patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/950725 [01:24:41] hmm my local is only creating a contribution tracking for every other donation [01:24:52] oh funky [01:26:24] hmmm [01:26:40] with the patch im not getting anything in contribution tracking [01:26:47] oh dang! [01:26:51] lets see [01:26:55] ok, I need to test again I guess [01:27:12] well, once my setup.sh finishes [01:30:26] i wonder if its on the civi patch [01:31:51] no its not putting anything on the queue what [01:33:07] hmm, try switching gateway? [01:33:25] or deleting payments_session cookie? [01:34:17] i switched back to master and its doing what i expect I just dont understand why its breaking this way [01:34:32] trying to get it to go to a breakpoint [01:34:39] (03PS1) 10Eileen: Fix string wrangling bug [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959368 [01:35:18] argh - we should merge ^^ before it confuses anyone else [01:35:23] (03CR) 10Ejegg: [C: 03+2] "lol" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959368 (owner: 10Eileen) [01:36:09] ejegg: ok, will do the test for that adyen [01:36:34] wfan actually I think I'm going to wait till tomorrow morning [01:36:43] and try to get the c_t deconcatenate thing out too [01:36:58] once we get it passing smoke tests locally [01:37:45] Ah, make sense, thanks, and good to know btw, here is the result for all newly added dlocal submethods: https://phabricator.wikimedia.org/T346814#9185509 still got some payment methods untested [01:37:53] thanks! [01:38:07] already @Evelyn for internal tester or on hold for now [01:38:08] i think its me ejegg not your patch [01:40:13] hmm, ok. I do see it queueing messages locally [01:40:25] i saw it queued then it imported to blank [01:40:29] ahh [01:40:38] ok, I need to rebuild without debug on [01:41:04] it just got a core dump while adding the permissions for the civicrm admin on wmff [01:42:36] (03CR) 10Wfan: Break up payments_form and form_amount in c_t messages (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/955957 (https://phabricator.wikimedia.org/T334904) (owner: 10Ejegg) [01:43:20] wfan: ^ did you test that locally do you see records getting into civi [01:43:28] i cant tell if its me or not haha [01:44:09] no just take a glance of the code haha [01:45:30] ok, rebuilt, will try importing [01:46:17] nice to see progress on making ct handling better [01:47:04] ...and finishing up loose ends in a refactor before completely forgetting about them [01:47:25] cough.. wsdl... cough... [01:47:40] i'll make a push for getting rid of wsdl in adyen soon, i promise [01:48:01] rip wsdl [01:48:09] ok I see the variant in contirbutiont racking [01:48:12] 1) [01:48:12] "{\"id\":\"48233\",\"ts\":\"20230921014724\",\"amount\":\"7.17\",\"appeal\":\"JimmyQuote\",\"country\":\"US\",\"currency\":\"USD\",\"gateway\":\"adyen\",\"language\":\"en\",\"utm_source\":\"..cc\",\"payments_form_variant\":\"letswork\",\"payment_method_id\":\"cc\",\"source_name\":\"DonationInterface\",\"source_type\":\"payments\",\"source_host\":\"33ececac671a\",\"source_run_id\":236,\"source_version\":\"unknown\",\"source_enque [01:48:12] ued_time\":1695260844}" [01:48:55] says contribution_tracking: Successfully processed 1 contribution tracking message(s). [01:49:04] but then all the fields are blank [01:49:07] lemme debug civi side [01:49:32] ohhhh are you looking in the civicrm_contribution_tracking table? [01:50:14] yep [01:50:18] (03Merged) 10jenkins-bot: Fix string wrangling bug [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959368 (owner: 10Eileen) [01:50:18] hmmm no wait, i'm seeing the new fields blank too [01:50:27] so like utm_ stuff is still there [01:50:34] it's just not populating the new appeal etc fields [01:50:41] its not populating amount for me [01:50:46] or currency [01:50:49] or gateway [01:50:49] Def seems to need a fix on the civi side then [01:50:58] yep, i'm seeing the same [01:51:03] ok, diving in [01:54:11] ah it's the processMessage filter [01:54:19] fix in 5... [01:54:30] haha okay im failing at making ct records again [01:54:48] i wonder if this is that bug or my broken local [01:54:56] i see it incrementing on the donation [01:55:25] "contribution_tracking_id\":\"48235\ on the donations queue but no record in the ct queue for that [01:58:06] (03PS1) 10Ejegg: Stop filtering out new c_t fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959371 (https://phabricator.wikimedia.org/T334904) [01:59:50] ah drat, ^^^ crashes on the insert to the legacy table [02:00:11] yeah haha iwas just going to say [02:00:16] Unknown column 'amount' in 'field list' in /srv/civi-sites/wmff/drupal/includes/database/database.inc [02:00:36] ok, so the legacy insert still needs the restrictive filter [02:00:48] Column not found: 1054 Unknown column 'amount' in 'field list' [02:03:10] hmm, or i could just send the raw message to the helper [02:04:03] (03PS1) 10Eileen: Smash pig cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959372 [02:11:02] well beside the breaking the old one I do see the variant in there now hah [02:11:11] cstone: ok, I do need to fix another thing [02:11:16] but let me put up a PS2 [02:11:24] and not deploy anything tonight... [02:12:03] eileen: were you planning to deploy civi? [02:12:17] cstone: oh - I didn't have specific plans [02:12:33] just ct is currently slightly broken [02:12:40] I've been fighting unit tests .. https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/959372/ [02:13:20] (03PS2) 10Ejegg: Send un-filtered c_t message to helper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959371 (https://phabricator.wikimedia.org/T334904) [02:13:32] cstone OK ^^^ doesn't break legacy inserts [02:13:39] and does get variant and appeal [02:13:49] plus amount and currency on the new table [02:14:00] ok cool lets see if i can get a local message to behave [02:14:18] just those payment_method fields I should do differently [02:14:37] so I'll want to change those field names on the message I think [02:14:48] to drop the _id bits [02:14:54] since there is a lookup step here [02:16:48] so like payment_method instead of _id [02:17:11] it did put 0 in for braintree locally [02:18:38] ejegg: im not seeing amount and currency on the old table but are we using it at all even [02:18:49] (03CR) 10CI reject: [V: 04-1] Smash pig cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959372 (owner: 10Eileen) [02:21:01] cstone it's only in the old table concatenated into form_amount [02:21:15] ah yeah thats what i meant its blank [02:22:08] (03PS1) 10Ejegg: Fix payment_method and submethod c_t coding [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959375 (https://phabricator.wikimedia.org/T334904) [02:24:22] (03PS5) 10Ejegg: Break up payments_form and form_amount in c_t messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/955957 (https://phabricator.wikimedia.org/T334904) [02:24:54] cstone ohh good point I guess I should keep sending the legacy concatenated form_amount in the message for now? [02:25:02] till we're ready to get rid of the old table [02:25:09] yeah I just dont know if something secret is using it [02:25:24] hopefully not [02:25:28] but just so it matches [02:25:57] darn then it should be the same for the wierd payments_form crud [02:26:33] aw hah what you were trying to get rid of huh [02:26:52] yep, we should definitely put a drop-dead date on that old table [02:26:58] maybe January [02:27:46] ok, I gotta head to bed [02:28:04] will restore those relics in the morning [02:28:12] thanks for all your patience with this one cstone! [02:28:20] hah no worries night ejegg [02:29:52] eileen: ^ not sure if you were following along but the merged ct update patch causes some data loss and we didn't fully fix it yet, if you deploy civi later today can you pick around it? [02:30:28] cstone: yeah - I don't need to deploy today [02:30:53] thanks! [02:31:09] (03PS2) 10Eileen: Smash pig cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959372 [02:40:29] cstone so those two other civi patches should be ready to review with the master-branch DI [02:40:52] ok! [02:41:05] they should just keep populating everything as it was [02:41:33] and with the updated patch on DI they should get all the fields populated on the new table [02:41:46] k, thanks again. gnight! [02:49:55] phew my tests finally passed - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/959372/ [02:49:56] To be honest I think review on that might be a bit take it on trust since there is a lot of code change but it is only in the test classe [02:50:57] 10Fundraising-Backlog: Post-payment monthly convert donors need appropriate flag in Civi - https://phabricator.wikimedia.org/T346819 (10KHaggard) Hi @Ejegg - we use the custom fields in Acoustic. Specifically: AF_has_active_recurring_donation AF_recurring_latest_donation_date Sorry if it takes me a while to rep... [03:57:07] (03PS1) 10Eileen: Update Smashpig processor to set Gift Data fields on repeat contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959381 (https://phabricator.wikimedia.org/T345920) [03:57:11] (03Abandoned) 10Eileen: Update Smashpig processor to set Gift Data fields on repeat contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959177 (https://phabricator.wikimedia.org/T345920) (owner: 10Eileen) [04:09:13] (03PS3) 10Eileen: Smash pig cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959372 [04:12:14] (03CR) 10CI reject: [V: 04-1] Update Smashpig processor to set Gift Data fields on repeat contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959381 (https://phabricator.wikimedia.org/T345920) (owner: 10Eileen) [04:23:42] (03CR) 10CI reject: [V: 04-1] Smash pig cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959372 (owner: 10Eileen) [04:51:32] (03PS1) 10Eileen: Improve error handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959382 [05:13:58] (03PS2) 10Eileen: Improve error handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959382 [05:14:00] (03PS4) 10Eileen: Smash pig cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959372 [05:29:29] (03CR) 10CI reject: [V: 04-1] Smash pig cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959372 (owner: 10Eileen) [05:57:10] (03PS5) 10Eileen: Smash pig cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959372 [06:02:17] (03PS6) 10Eileen: Smash pig cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959372 [06:11:12] (03PS2) 10Eileen: Update Smashpig processor to set Gift Data fields on repeat contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959381 (https://phabricator.wikimedia.org/T345920) [06:27:58] (03CR) 10CI reject: [V: 04-1] Update Smashpig processor to set Gift Data fields on repeat contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959381 (https://phabricator.wikimedia.org/T345920) (owner: 10Eileen) [06:48:24] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_40) - 10https://gerrit.wikimedia.org/r/959441 (owner: 10L10n-bot) [07:36:12] (03PS7) 10Eileen: Smash pig cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959372 [07:38:57] (03PS8) 10Eileen: Smash pig cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959372 [07:42:10] (03PS3) 10Eileen: Update Smashpig processor to set Gift Data fields on repeat contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959381 (https://phabricator.wikimedia.org/T345920) [10:40:48] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_40) - 10https://gerrit.wikimedia.org/r/959441 (owner: 10L10n-bot) [13:38:59] music recomendations for the next three years: https://1001albumsgenerator.com/ [13:39:11] it gave me an Isley brothers album yesterday so that was a good start [13:39:23] (03PS3) 10Jforrester: build: Update MediaWiki requirement to 1.39 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/950496 [13:39:26] today it's suggesting ZZ top: Tres Hombres [13:49:03] (03PS6) 10Ejegg: Break up payments_form and form_amount in c_t messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/955957 (https://phabricator.wikimedia.org/T334904) [13:51:27] ok fr-tech, ^^^ should populate the new fields correctly and still leave the legacy fields in the old table [13:51:55] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/950496 (owner: 10Jforrester) [13:52:33] (03PS2) 10Ejegg: Make text translatable in the campaign editor [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/950725 (owner: 10Tacsipacsi) [13:52:38] 10Fundraising-Backlog: Changing User Permissions in Civi - https://phabricator.wikimedia.org/T347058 (10NNichols) [13:53:19] (03CR) 10Ejegg: [C: 03+2] "Code seems fine, works in local tests. Thanks for fixing this, @Tacsipacsi!" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/950725 (owner: 10Tacsipacsi) [13:55:24] bah, when i keep the legacy field, the consumer overwrites the variant [13:55:39] ok, i need to make one more fix to the consumer patch to prefer the new fields [14:01:35] (03PS2) 10Ejegg: Fix contribution_tracking helper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959375 (https://phabricator.wikimedia.org/T334904) [14:03:41] 10Fundraising Sprint Rasberry Pi Beret 👩🏽‍🎨, 10Fundraising-Backlog, 10FR-tech-data-integrity: Making Gift Coding Changes to gifts in July - https://phabricator.wikimedia.org/T344012 (10NNichols) @Eileenmcnaughton All of the recurring gifts will need to be updated to the financial type Recurring Gift (for the... [14:03:43] (03Merged) 10jenkins-bot: build: Update MediaWiki requirement to 1.39 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/950496 (owner: 10Jforrester) [14:03:47] (03Merged) 10jenkins-bot: Make text translatable in the campaign editor [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/950725 (owner: 10Tacsipacsi) [14:08:53] (03CR) 10Tacsipacsi: Make text translatable in the campaign editor (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/950725 (owner: 10Tacsipacsi) [14:28:41] (03PS7) 10Ejegg: Break up payments_form and form_amount in c_t messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/955957 (https://phabricator.wikimedia.org/T334904) [14:33:05] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Successful Adyen transactions not making it into CiviCRM - https://phabricator.wikimedia.org/T345736 (10SHust) Here's another CID 6510295 with a manually settled Adyen transaction from September 19th, that still not showing up in Civ... [14:37:05] (03PS8) 10Ejegg: Break up payments_form and form_amount in c_t messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/955957 (https://phabricator.wikimedia.org/T334904) [14:40:55] (03CR) 10Ejegg: Break up payments_form and form_amount in c_t messages (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/955957 (https://phabricator.wikimedia.org/T334904) (owner: 10Ejegg) [14:50:36] oh man, Tidal's daily playlist has Butthole Surfers and Afroman back to back. I think they might know how old I am. [14:51:39] phew... ALMOST all working with the contribution_tracking [14:51:54] just realized the submethod_id lookup is busted [14:52:32] but that's equally busted from before my patch so.... [14:52:41] ehh, I really should fix it while I'm in there [14:56:36] ok, so... that Pseudoconstant lookup has no way of associating rtbt_ideal [14:56:52] I think we need that FinanceInstrument helper [14:57:57] 10fundraising-tech-ops: Puppet 7.x support in Fundraising environment - https://phabricator.wikimedia.org/T345207 (10Jgreen) a:03Jgreen [14:59:40] (03PS3) 10Ejegg: Fix contribution_tracking helper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959375 (https://phabricator.wikimedia.org/T334904) [14:59:53] And that seems to do it! ^^^ [15:00:37] cstone: I finally got all the kinks ironed out of both sides of that patch ^^^ [15:01:36] I'm going to add one follow-on patch to simplify the consumer for the new table, so it doesn't look at the legacy fields [15:01:56] but that'll be for deployment later, after the DI patch [15:02:05] this current one can go out BEFORE the DI patch [15:04:07] 10fundraising-tech-ops: Puppet 7.x support in Fundraising environment - https://phabricator.wikimedia.org/T345207 (10Jgreen) 05Open→03Resolved p:05Triage→03Medium [15:04:09] 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen) [15:06:52] (03PS1) 10Ejegg: Don't use concatenated fields for new c_t table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959763 (https://phabricator.wikimedia.org/T334904) [15:06:57] ok, ^^^ is the new patch [15:07:50] lemme rebase those and put 'em on a topic branch [15:07:56] (03PS3) 10Ejegg: Send un-filtered c_t message to helper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959371 (https://phabricator.wikimedia.org/T334904) [15:07:58] (03PS4) 10Ejegg: Fix contribution_tracking helper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959375 (https://phabricator.wikimedia.org/T334904) [15:08:00] (03PS2) 10Ejegg: Don't use concatenated fields for new c_t table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959763 (https://phabricator.wikimedia.org/T334904) [15:13:30] Looking soon ejegg [15:14:41] 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen) [15:15:17] 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen) [15:15:42] (03CR) 10CI reject: [V: 04-1] Don't use concatenated fields for new c_t table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959763 (https://phabricator.wikimedia.org/T334904) (owner: 10Ejegg) [15:15:48] oops [15:15:53] let's see what that problem is [15:15:59] anyway, that's just the followup patch [15:16:09] not to be released yet [15:16:54] oh weird, 'This change depends on a change that failed to merge' [15:17:06] ehh, I'll look at something else for now [15:23:30] (03CR) 10CI reject: [V: 04-1] Don't use concatenated fields for new c_t table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959763 (https://phabricator.wikimedia.org/T334904) (owner: 10Ejegg) [15:24:13] 10Wikimedia-Fundraising-Banners, 10Wikipedia-iOS-App-Backlog, 10iOS Release FY2023-24: India fundraising messages in iOS app - https://phabricator.wikimedia.org/T335919 (10Pcoombe) 05Open→03Resolved All done, final results are in [this sheet](https://docs.google.com/spreadsheets/d/1wcV01ouNaDJLh_ELDX7zb_... [15:24:37] 10Fundraising-Backlog: Post-payment monthly convert donors need appropriate flag in Civi - https://phabricator.wikimedia.org/T346819 (10Ejegg) Thanks @KHaggard ! So for the monthly convert donors who haven't yet made their first recurring installment (and thus has status pending), I guess AF_has_active_recurring... [15:33:22] 10Fundraising-Backlog: Post-payment monthly convert donors need appropriate flag in Civi - https://phabricator.wikimedia.org/T346819 (10Ejegg) So fr-tech: the pending donations are being excluded by this INNER JOIN on civicrm_contributions. We could just change it to a LEFT JOIN and get the pending rows. Only dr... [15:43:18] (03PS1) 10Ejegg: Include pending in has_active_recurring [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/959796 (https://phabricator.wikimedia.org/T346819) [15:49:43] pcoombe: it looks like we need to fill out a form to get an application security review for the Fundraise Up scripts. [15:50:18] Do you want to fill out the form at https://phabricator.wikimedia.org/maniphest/task/edit/form/79/ ? Or would you prefer that fr-tech do that? [15:50:26] ejegg: theres something up with venmo/braintree that it doesn't get a payment method id in ct tracking but that is an issue outside of these patches [15:50:51] not sure if peter checks here often ejegg slack might be better I think he said that last time we talked [15:51:17] cstone ok, i think that a value needs to be added to an option group to get that venmo coding working [15:53:04] (03CR) 10Cstone: [C: 03+2] "Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959371 (https://phabricator.wikimedia.org/T334904) (owner: 10Ejegg) [15:53:37] (03CR) 10Cstone: [C: 03+2] "Looks good, things aren't missing!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959375 (https://phabricator.wikimedia.org/T334904) (owner: 10Ejegg) [15:54:29] (03CR) 10Cstone: [C: 03+2] "Looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/955957 (https://phabricator.wikimedia.org/T334904) (owner: 10Ejegg) [15:54:46] some construction somewhere (I hope) making really creepy noises today [15:56:44] woohoo, thanks cstone! [16:10:17] (03Merged) 10jenkins-bot: Send un-filtered c_t message to helper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959371 (https://phabricator.wikimedia.org/T334904) (owner: 10Ejegg) [16:11:38] (03Merged) 10jenkins-bot: Fix contribution_tracking helper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959375 (https://phabricator.wikimedia.org/T334904) (owner: 10Ejegg) [16:22:40] (03PS1) 10Ejegg: Add Venmo to the payment_method option group [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959806 [17:19:08] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/959816 [17:19:11] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/959816 (owner: 10Ejegg) [17:20:06] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/959816 (owner: 10Ejegg) [17:29:59] !log disabled contribution_tracking queue consumer for Civi update [17:30:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:30:52] !log civicrm upgraded from f0e9d3f6 to 9efea665 [17:30:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:31:53] d'oh, bad slow-start command config [17:33:29] whew, test run of 1000 [17:33:46] :) [17:34:53] well, looks fine on the old-style message [17:35:12] let's turn that on again [17:35:55] !log re-enabled contribution tracking queue consumer [17:35:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:36:11] and now to get the sending side ready to deploy [17:37:13] (03PS9) 10Ejegg: Break up payments_form and form_amount in c_t messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/955957 (https://phabricator.wikimedia.org/T334904) [17:37:34] oh hmm, needs zuul kick [17:55:43] (03CR) 10Ejegg: [C: 03+2] "resubmit" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/955957 (https://phabricator.wikimedia.org/T334904) (owner: 10Ejegg) [17:57:17] (03Merged) 10jenkins-bot: Break up payments_form and form_amount in c_t messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/955957 (https://phabricator.wikimedia.org/T334904) (owner: 10Ejegg) [18:02:27] hah, that security review wants me to run a go-based tool on the FRUP codebase. Guess I need to install a new language and learn a thing or two about it :) [18:02:49] suppose I should finish that deploy first though [18:03:17] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/959832 [18:03:21] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/959832 (owner: 10Ejegg) [18:03:59] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/959832 (owner: 10Ejegg) [18:07:24] (03PS7) 10Damilare Adedoyin: Added Fundraiseup code to DonateWiki Head. Still need to confirm from Peter if the form-template is a good enough flag to use. [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/959347 (https://phabricator.wikimedia.org/T346975) [18:09:55] (03PS8) 10Damilare Adedoyin: Added Fundraiseup code to DonateWiki Head. [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/959347 (https://phabricator.wikimedia.org/T346975) [18:10:50] ok so this ready for review now ^^ [18:17:32] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/959835 [18:17:38] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/959835 (owner: 10Ejegg) [18:17:54] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Application Security Reviews, 10secscrum, 10Patch-For-Review: Add CSP for Fundraiseup on DonateWiki - https://phabricator.wikimedia.org/T345379 (10Ejegg) Application Security Review ticket submitted at https://phabricator.wikimedia.org/T347104 [18:20:19] 10Fundraising Sprint Rasberry Pi Beret 👩🏽‍🎨, 10Patch-For-Review: Add Fundraiseup JS Script to DonateWiki Head - https://phabricator.wikimedia.org/T346975 (10Damilare) @Pcoombe recommended we use a separate parameter `fundraiseupScript=1`, since we might want to test different variants of the form-template. Thi... [18:25:52] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/959835 (owner: 10Ejegg) [18:26:47] heh [18:26:58] (re installing the security tool) [18:27:44] oh hey, our widget JS seems to load a bunch of text that's definitely not relevant to us [18:28:55] "You can rush emergency relief to children..." [18:29:18] "Help our state-of-the-art hospital ships provide free surgeries that save and transform lives..." [18:32:12] yh I believe pcoombe and DR are working on those. [18:34:25] ah ok, thanks. I just flagged it in the slack channel too [18:34:49] ok, that donationinterface upgrade is ready to deploy [18:34:59] wfan: I'm going to push out those changes now [18:36:07] cool will keep an eye on that thanks [18:37:14] 10Fundraising-Backlog: Spike: Research potential iframe solutions for PaymentsWiki - https://phabricator.wikimedia.org/T346393 (10EMartin) @greg @ERoden-WMF @AKanji-WMF @XenoRyet @spatton Hi everyone, further to the recent meeting to discuss this topic, as agree, I have followed through on the write up and the a... [18:47:08] !log payments-wiki upgraded from 9cd3e4cd to 5596c7fd [18:47:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:47:13] wfan: ok, that's out [18:47:43] ok testing those non-champion one :) [18:51:19] https://payments.wikimedia.org/index.php?title=Special:GatewayChooser&uselang=en&language=en¤cy=XCD&amount=10&country=AG&recurring=false&payment_method=cc USE ADYEN NOW [18:51:26] Looks fine~ [18:52:47] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Patch-For-Review, and 2 others: &banner causes CSP warning - https://phabricator.wikimedia.org/T199055 (10Ejegg) @AKanji-WMF I think we can decline this - it's working as expected, warning banner designers about... [18:53:31] 10Fundraising Tech - Chaos Crew: dlocal miss wallet as payment - https://phabricator.wikimedia.org/T344365 (10Ejegg) [18:53:33] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, 10MW-1.41-notes (1.41.0-wmf.28; 2023-09-26): Dlocal payments with method MP fail with missing wallet parameter - https://phabricator.wikimedia.org/T346650 (10Ejegg) [18:57:57] (03CR) 10Cstone: [C: 03+2] "thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959806 (owner: 10Ejegg) [19:08:51] (03PS3) 10Ejegg: Move archived campaigns to a new subaction of Special:CentralNotice [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/952489 (https://phabricator.wikimedia.org/T328424) (owner: 10Pcoombe) [19:09:13] (03CR) 10Ejegg: "PS3: manual rebase around a couple merged patches" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/952489 (https://phabricator.wikimedia.org/T328424) (owner: 10Pcoombe) [19:12:51] (03Merged) 10jenkins-bot: Add Venmo to the payment_method option group [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959806 (owner: 10Ejegg) [19:14:28] (03CR) 10Cstone: [V: 03+2 C: 03+2] "thanks!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/959341 (owner: 10Wfan) [19:26:45] ok, concentration on code is fading. gonna switch to watching that eileen / tim video [19:38:50] ejegg: there's a notes doc that roughly goes over the agenda [19:39:09] yep, thanks! [20:14:50] 10Fundraising-Backlog, 10Patch-For-Review: Post-payment monthly convert donors need appropriate flag in Civi - https://phabricator.wikimedia.org/T346819 (10KHaggard) Hi @Ejegg - quick clarification, our emails targeted AF_has_active_recurring_donation = No. So the 'pending' donors have "No" as they're value cu... [20:25:54] 10Fundraising-Backlog, 10Patch-For-Review: Post-payment monthly convert donors need appropriate flag in Civi - https://phabricator.wikimedia.org/T346819 (10Ejegg) >>! In T346819#9189156, @KHaggard wrote: > Hi @Ejegg - quick clarification, our emails targeted AF_has_active_recurring_donation = No. So the 'pendi... [20:36:01] 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen) [20:49:42] (03PS2) 10Damilare Adedoyin: WIP: Create Fundraiseup Audit Processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959346 (https://phabricator.wikimedia.org/T346620) [21:05:40] (03CR) 10CI reject: [V: 04-1] WIP: Create Fundraiseup Audit Processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959346 (https://phabricator.wikimedia.org/T346620) (owner: 10Damilare Adedoyin) [21:09:59] 10Fundraising-Backlog: Spike: Research and task out imports work required for FRUP pilot - https://phabricator.wikimedia.org/T345349 (10Dwisehaupt) [21:50:31] oh, we needed to do a standalone SmashPig deploy for something, right? [21:50:46] I could push that out now to have it before the weekend without a friday deploy [21:52:11] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/959877 [21:52:34] fr-tech do any of those patches need special monitoring ^^^ ? [21:53:24] Guess checking that the wallet disabled actually works [21:53:33] But not too special [21:53:58] k, cool [21:54:10] I'm going to update the libraries too [21:54:17] now that we're on 7.4 [21:54:23] ooh, yaml gets a big jump [21:55:36] (03PS1) 10Ejegg: Update libraries [wikimedia/fundraising/SmashPig/vendor] - 10https://gerrit.wikimedia.org/r/959878 [21:55:57] oh wait, I should do that on master first, then merge the composer.lock to deployment [21:57:18] (03PS1) 10Ejegg: Update libraries [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/959879 [21:57:28] (03CR) 10Ejegg: [C: 03+2] Update libraries [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/959879 (owner: 10Ejegg) [21:57:53] right, most of that was already merged [21:57:58] (03Merged) 10jenkins-bot: Update libraries [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/959879 (owner: 10Ejegg) [21:59:28] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/959880 [21:59:48] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Update libraries [wikimedia/fundraising/SmashPig/vendor] - 10https://gerrit.wikimedia.org/r/959878 (owner: 10Ejegg) [22:01:25] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/959880 (owner: 10Ejegg) [22:02:24] !log Standalone (listener) SmashPig upgraded from ca5b6218 to 2412df22 [22:02:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:02:36] well, logs are still looking good [22:04:32] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Post-payment monthly convert donors need appropriate flag in Civi - https://phabricator.wikimedia.org/T346819 (10Ejegg) [22:08:52] (03Abandoned) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/959877 (owner: 10Ejegg) [22:09:15] (03PS3) 10Ejegg: Don't use concatenated fields for new c_t table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959763 (https://phabricator.wikimedia.org/T334904) [22:24:02] (03CR) 10CI reject: [V: 04-1] Don't use concatenated fields for new c_t table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959763 (https://phabricator.wikimedia.org/T334904) (owner: 10Ejegg) [22:33:24] 10Fundraising-Backlog, 10Data-Engineering, 10MediaWiki-extensions-CentralNotice, 10Movement-Insights, 10WMDE-FUN-Sprint-2023-09-04: Unique Devices seasonal trends on small projects - https://phabricator.wikimedia.org/T344381 (10Mayakp.wiki) Thanks for confirming @kai.nissen ! I checked our dashboards an... [23:48:45] (03PS3) 10Damilare Adedoyin: Create Fundraiseup Audit parser class in Smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/958514 (https://phabricator.wikimedia.org/T346621) [23:49:14] (03CR) 10CI reject: [V: 04-1] Create Fundraiseup Audit parser class in Smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/958514 (https://phabricator.wikimedia.org/T346621) (owner: 10Damilare Adedoyin) [23:59:39] (03PS3) 10Damilare Adedoyin: WIP: Create Fundraiseup Audit Processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959346 (https://phabricator.wikimedia.org/T346620)