[01:14:00] (03PS1) 10Ejegg: Merge branch 'REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/961964 [01:15:25] (03CR) 10Jforrester: "+1" [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/961964 (owner: 10Ejegg) [01:16:59] oh looks like a lock file needs updating [01:19:33] (03PS2) 10Ejegg: Merge branch 'REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/961964 [01:20:04] (03CR) 10Ejegg: [C: 03+2] Merge branch 'REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/961964 (owner: 10Ejegg) [01:28:32] (03Merged) 10jenkins-bot: Merge branch 'REL1_39' into fundraising/REL1_39 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/961964 (owner: 10Ejegg) [01:40:29] !log payments-wiki upgraded from c4c9b938 to d6ad0376 [01:40:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:55:04] ejegg: did you see I tried a mini version of doing updates with coworker (followed by a bigger one) - seems to be running oK on staging - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/961492 [02:32:58] oh cool eileen ! [02:33:05] I will look at it in the morning [02:33:38] cool - that first patch is limited to 10k rows - just so we can play with it [02:34:15] thanks, it looks promising [07:50:21] (03PS16) 10Damilare Adedoyin: Create Fundraiseup Audit Processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959346 (https://phabricator.wikimedia.org/T346620) [08:12:04] (03PS17) 10Damilare Adedoyin: Create Fundraiseup Audit Processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959346 (https://phabricator.wikimedia.org/T346620) [08:13:19] (03PS18) 10Damilare Adedoyin: Create Fundraiseup Audit Processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/959346 (https://phabricator.wikimedia.org/T346620) [12:54:21] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Engage DAF import- duplicate issue - https://phabricator.wikimedia.org/T345773 (10jgleeson) a:03jgleeson [13:21:02] (03PS1) 10Damilare Adedoyin: Update contact fiscal_number on Monthly convert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/962039 (https://phabricator.wikimedia.org/T345346) [13:23:08] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Refund was in a different currency. Freaking out - https://phabricator.wikimedia.org/T347699 (10jgleeson) [15:20:48] 10Fundraising-Backlog, 10FR-donorservices: Venmo Security Check Loading Window - https://phabricator.wikimedia.org/T347503 (10AMJohnson) Just wanted to add that I came across this again while performing another test donation today via desktop using the same link: https://en.wikipedia.org/wiki/Wikipedia?country... [15:41:14] 10Fundraising-Backlog: Removing some WMF donor fields - https://phabricator.wikimedia.org/T347724 (10NNichols) [15:48:52] 10Fundraising Sprint Spacebar Oddity 👾, 10Fundraising-Backlog: AMEX rejected transactions through Ingenico are to be ported to Adyen - https://phabricator.wikimedia.org/T338523 (10Ejegg) a:03Ejegg [15:51:16] 10Fundraising-Backlog: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10EMartin) @Ejegg @XenoRyet @AKanji-WMF Note to this task that the Ingenico tokens are now being transferred as of 29 September 2023 25% of the tokens are now at Adyen and the rema... [15:52:25] 10Fundraising-Backlog: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10EMartin) Ingenico reports the following token counts are being transferred: These are the number of profiles per year. COUNT(1) YEAR ---------- ---- 9,592 - 2018 758,95... [16:24:42] 10Fundraising-Backlog, 10FR-donorservices: Venmo Security Check Loading Window - https://phabricator.wikimedia.org/T347503 (10AnnWF) btw, "Frame closed before tokenization could occur" is not an error just a hint that you closed the popup (if it's confusing, we can remove this error message), and already let A... [16:25:35] 10Fundraising Sprint Spacebar Oddity 👾, 10Fundraising-Backlog: Issue with Paypal donations made on GiveLively for events - https://phabricator.wikimedia.org/T295726 (10JSimmons) @Ejegg I reached out to GiveLively to request a custom data field to identify the event PayPal donations. I don't think it's possible... [16:56:23] 10Fundraising-Backlog: Enable Monthly Convert for Gpay - https://phabricator.wikimedia.org/T346841 (10Pcoombe) Ideally it would be the same countries, since those are the ones we have translations etc already set up [17:18:58] (03CR) 10Cstone: [V: 03+2 C: 03+2] Remove Astropay from main page [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/961176 (https://phabricator.wikimedia.org/T326594) (owner: 10Wfan) [17:30:44] 10Fundraising-Backlog: What should we do with recurring tokens that are active but not being used - https://phabricator.wikimedia.org/T347743 (10Cstone) [17:31:46] 10Fundraising-Backlog: What should we do with recurring tokens that are active but not being used - https://phabricator.wikimedia.org/T347743 (10Cstone) [18:12:38] 10Fundraising-Backlog: Enable Monthly Convert for Gpay - https://phabricator.wikimedia.org/T346841 (10EMartin) @Pcoombe Then let's just make it the same countries as cards given your point about translations. I'm on the record. [18:28:41] (03CR) 10Ejegg: "Looks like it works, but one suggestion for consistency with other WmfContact\Save code" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/962039 (https://phabricator.wikimedia.org/T345346) (owner: 10Damilare Adedoyin) [18:30:43] 10Wikimedia-Fundraising-Banners, 10Page-Previews, 10Reference Previews, 10Regression, 10Web-Team-Backlog (Tracking): [Regression] Not possible for logged in users to disable page previews - https://phabricator.wikimedia.org/T233037 (10WMDE-Fisch) [18:31:30] ah I just noticed the other place we're directly calling handleUpdate [18:31:48] 10Fundraising Tech - Chaos Crew, 10FR-Tech-Analytics: Recent Email Sends Have No Clicks - https://phabricator.wikimedia.org/T347406 (10Damilare) Hi @nisrael, having ran a test on the email, I noticed the contact_id parameter is empty, could it be the template isn't populating that field? This would explain th... [18:32:42] sorry damilare, I think I'll C+2 that patch as-is [18:32:57] now I understand the benefit of using that directly [18:33:15] thanks! [18:34:43] (03CR) 10Ejegg: [C: 03+2] "Oops, I guess I see the value in calling that handleUpdate function directly. Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/962039 (https://phabricator.wikimedia.org/T345346) (owner: 10Damilare Adedoyin) [18:44:48] 10fundraising-tech-ops: Fundraising access request for kmorrow - https://phabricator.wikimedia.org/T347619 (10Dwisehaupt) [18:45:20] 10fundraising-tech-ops: Fundraising access request for kmorrow - https://phabricator.wikimedia.org/T347619 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt Verified that cert and superset access is working. Closing. [18:50:02] (03Merged) 10jenkins-bot: Update contact fiscal_number on Monthly convert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/962039 (https://phabricator.wikimedia.org/T345346) (owner: 10Damilare Adedoyin) [18:50:44] 10Fundraising Tech - Chaos Crew, 10FR-Tech-Analytics: Recent Email Sends Have No Clicks - https://phabricator.wikimedia.org/T347406 (10Ejegg) Aha, you're missing an ampersand before the contact id! ... &contact_hash=%%CONTACT_HASH%%contact_id=%%CONTACTID%%& ... So it's just being tacked onto the value of the... [19:31:18] 10Fundraising-Backlog: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10EMartin) All tokens have been sent to Adyen for import. I have spoken to Adyen and they are now working on the import and providing a list of all the migrated tokens for us to val... [20:30:52] 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen) [20:34:05] 10Fundraising Sprint Spacebar Oddity 👾: Implement payment content if no client data return from client side for Venmo - https://phabricator.wikimedia.org/T347771 (10AnnWF) [21:14:40] ejegg: there should be a field - $createContact = !($dao->is_contact_creation_disabled_if_no_match); [21:50:08] eileen: yep, I guess we can set that in the db [21:50:30] yeah - not exposed huh? [21:50:43] only when usedFor == email to activity [21:50:52] hidden when usedFor == bounce processing [21:51:26] but I guess I wonder if bounce processors should ALWAYS assume that's true [21:51:36] since a bounce should always relate to an existing contact [21:51:42] yeah probably [21:51:58] if you do do a patch for that then target the 5.66 (rc) branch [21:52:16] k, i might not get to that till monday [21:52:30] thanks! [21:54:14] eileen: so I was all set to write a batch job for the adyen token migration along the lines of the ts importer [21:54:26] keeping track of the file offset in a setting [21:54:37] but perhaps I can use the new queue stuff [21:55:03] well, first things first, let me make sure this script for doing a tiny file in one run actually works [21:55:27] ejegg: yeah - have a play with that & once comfortable the follow on one [21:56:08] by the tiny one you mean https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/961492 - it doesn't actually do it in one run (although it could) [21:56:22] ah no, i have a patch I still haven't uploaded [21:56:27] but it does 1000 runs of 10.... [21:56:46] that takes the CSV from adyen and updates payment_token with the new tokens imported from Ingenico [21:58:17] also updates the payment_processor_id on civicrm_contribution_recur [21:58:59] and I /think/ that's all it needs to do [21:59:15] ah, i should look at exactly what gets copied over from the previous payment [22:00:36] yah, just payment_instrument, contact_id, invoice_id (incremented), and then the gift_data stuff [22:00:47] so nothing that should screw up on a processor switch [23:19:03] (03PS1) 10Ejegg: Migrate Ingenico tokens to Adyen [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/962097 (https://phabricator.wikimedia.org/T338523) [23:45:00] 10Fundraising-Backlog: Removing some WMF donor fields - https://phabricator.wikimedia.org/T347724 (10KHaggard) Just a quick little reminder, please hold off on deleting the few CY fields that are still in the export to Acoustic until we replace them with FY... and then we could blow them away after. :)