[00:22:23] (03PS3) 10Eileen: Remove temporary mailing update, replace with job to run through. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963401 (https://phabricator.wikimedia.org/T346194) [01:22:13] (03PS4) 10Eileen: Remove temporary mailing update, replace with job to run through. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963401 (https://phabricator.wikimedia.org/T346194) [02:11:31] (03PS5) 10Ejegg: Deal with 1:many token migration [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/962745 (https://phabricator.wikimedia.org/T338523) [02:11:33] (03PS1) 10Ejegg: Add batch and offset options to token migrator [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963424 (https://phabricator.wikimedia.org/T338523) [02:15:07] (03CR) 10Ejegg: [C: 03+2] Fix SQL default on Gift_Data.campaign (gift source) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963417 (https://phabricator.wikimedia.org/T344012) (owner: 10Eileen) [02:30:45] (03Merged) 10jenkins-bot: Fix SQL default on Gift_Data.campaign (gift source) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963417 (https://phabricator.wikimedia.org/T344012) (owner: 10Eileen) [02:42:13] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/963425 [02:42:26] (03PS14) 10Cstone: Add submitPayment api [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/959068 (https://phabricator.wikimedia.org/T344774) [02:44:06] (03CR) 10CI reject: [V: 04-1] Add submitPayment api [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/959068 (https://phabricator.wikimedia.org/T344774) (owner: 10Cstone) [02:44:52] (03PS15) 10Cstone: Add submitPayment api [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/959068 (https://phabricator.wikimedia.org/T344774) [02:45:47] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/963425 (owner: 10Eileen) [02:50:09] !log civicrm upgraded from 44800fc0 to 05545fbc [02:50:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:02:08] (03PS1) 10Eileen: Add unit test check to trace wrong types on recurring contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963428 (https://phabricator.wikimedia.org/T345919) [03:17:29] (03CR) 10CI reject: [V: 04-1] Add unit test check to trace wrong types on recurring contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963428 (https://phabricator.wikimedia.org/T345919) (owner: 10Eileen) [04:41:28] (03PS2) 10Eileen: Add unit test check to trace wrong types on recurring contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963428 (https://phabricator.wikimedia.org/T345919) [04:55:22] (03CR) 10Cstone: [C: 03+2] "Thanks for all this, looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/962745 (https://phabricator.wikimedia.org/T338523) (owner: 10Ejegg) [04:56:42] (03CR) 10CI reject: [V: 04-1] Add unit test check to trace wrong types on recurring contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963428 (https://phabricator.wikimedia.org/T345919) (owner: 10Eileen) [05:11:15] (03Merged) 10jenkins-bot: Deal with 1:many token migration [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/962745 (https://phabricator.wikimedia.org/T338523) (owner: 10Ejegg) [05:25:52] (03PS3) 10Eileen: Add unit test check to trace wrong types on recurring contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963428 (https://phabricator.wikimedia.org/T345919) [05:27:58] (03PS4) 10Eileen: Add unit test check to trace wrong types on recurring contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963428 (https://phabricator.wikimedia.org/T345919) [05:42:36] (03CR) 10CI reject: [V: 04-1] Add unit test check to trace wrong types on recurring contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963428 (https://phabricator.wikimedia.org/T345919) (owner: 10Eileen) [06:07:59] (03PS5) 10Eileen: Add unit test check to trace wrong types on recurring contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963428 (https://phabricator.wikimedia.org/T345919) [06:23:35] (03CR) 10CI reject: [V: 04-1] Add unit test check to trace wrong types on recurring contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963428 (https://phabricator.wikimedia.org/T345919) (owner: 10Eileen) [06:28:20] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_40) - 10https://gerrit.wikimedia.org/r/963524 (owner: 10L10n-bot) [08:08:22] (03PS6) 10Eileen: Add unit test check to trace wrong types on recurring contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963428 (https://phabricator.wikimedia.org/T345919) [10:42:34] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: Donation amount in Civi does not match the donation amount received at dLocal - https://phabricator.wikimedia.org/T346101 (10Damilare) I may have been able to reproduce this bug locally and it seems to be caused by session stickiness... [11:28:45] (03PS1) 10Thiemo Kreuz (WMDE): Drop misleading boolean comparisons with "1" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/963702 [11:31:00] (03PS2) 10Thiemo Kreuz (WMDE): Drop misleading boolean comparisons with "1" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/963702 [11:32:09] (03PS1) 10Thiemo Kreuz (WMDE): Use upstream selectField where appropriate [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/963704 [11:47:17] PROBLEM - check_redis on frqueue1004 is CRITICAL: CRITICAL: recurring is 9568 9500 - REDIS 6.0.16 on 127.0.0.1:6379 has 1 databases (db0) with 13 keys, up 54 days 19 hours - memory use is 7.50M (peak 28.06M, 0.18% of max, fragmentation 1.92%), connected_slaves is 3, donations is 62, jobs is 0, jobs-adyen is 0, jobs-dlocal is 0, jobs-paypal is 5, payments-antifraud is 9, payments-init is 1, pending is 0, refund is 0, unsubscribe is 9 http [11:47:17] a.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_redis [11:52:17] PROBLEM - check_redis on frqueue1004 is CRITICAL: CRITICAL: recurring is 9597 9500 - REDIS 6.0.16 on 127.0.0.1:6379 has 1 databases (db0) with 15 keys, up 54 days 19 hours - memory use is 7.52M (peak 28.06M, 0.17% of max, fragmentation 1.90%), connected_slaves is 3, donations is 88, jobs is 0, jobs-adyen is 35, jobs-dlocal is 0, jobs-paypal is 1, payments-antifraud is 6, payments-init is 22, pending is 1, refund is 0, unsubscribe is 10 h [11:52:17] inga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_redis [11:57:15] PROBLEM - check_redis on frqueue1004 is CRITICAL: CRITICAL: recurring is 9633 9500 - REDIS 6.0.16 on 127.0.0.1:6379 has 1 databases (db0) with 14 keys, up 54 days 19 hours - memory use is 7.48M (peak 28.06M, 0.17% of max, fragmentation 1.87%), connected_slaves is 3, donations is 74, jobs is 0, jobs-adyen is 18, jobs-dlocal is 5, jobs-paypal is 2, payments-antifraud is 3, payments-init is 0, pending is 0, refund is 0, unsubscribe is 12 ht [11:57:15] nga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_redis [12:32:13] RECOVERY - check_redis on frqueue1004 is OK: OK: REDIS 6.0.16 on 127.0.0.1:6379 has 1 databases (db0) with 14 keys, up 54 days 19 hours - memory use is 6.65M (peak 28.06M, 0.16% of max, fragmentation 1.95%), connected_slaves is 3, donations is 106, jobs is 0, jobs-adyen is 0, jobs-dlocal is 10, jobs-paypal is 1, payments-antifraud is 4, payments-init is 24, pending is 0, recurring is 7845, refund is 0, unsubscribe is 14 https://icinga.wi [12:32:13] rg/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_redis [13:47:08] let's see, should we run that recurring queue consumer more frequently now? [14:17:18] 10Fundraising-Backlog: Indian donor charged twice for second installment of recurring donation - https://phabricator.wikimedia.org/T348258 (10krobinson) [14:30:55] 10Fundraising-Backlog, 10FR-donorservices: Indian donor charged twice for second installment of recurring donation - https://phabricator.wikimedia.org/T348258 (10MBeat33) Oct 1 Invoice ref. 191104808.2|dup-1696263975 Sep 30 invoice ref. 191104808.2 [15:50:28] (03CR) 10Ejegg: [C: 03+2] "I agree, this looks clearer." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/963702 (owner: 10Thiemo Kreuz (WMDE)) [16:07:22] (03Merged) 10jenkins-bot: Drop misleading boolean comparisons with "1" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/963702 (owner: 10Thiemo Kreuz (WMDE)) [17:54:13] (03CR) 10Ejegg: "Looking promising. Some suggestions inline (many just stylistic)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/959068 (https://phabricator.wikimedia.org/T344774) (owner: 10Cstone) [17:58:06] thanks ejegg [17:58:25] :) [19:16:13] (03PS7) 10Eileen: Fix recurring contributions being given wrong type on subsequent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963428 (https://phabricator.wikimedia.org/T345919) [19:29:19] so we were giving recurring contributions the wrong financial type in some cases - if we deploy this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/963428 we can fix up the ones that are wrong & then monitor for a bit [20:24:19] (03CR) 10Ejegg: [C: 04-1] "assertPostConditions was a really clever way of catching those! Some feedback inline. Guessing that extra isFirst() lookup won't add much " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963428 (https://phabricator.wikimedia.org/T345919) (owner: 10Eileen) [20:26:48] (03CR) 10Ejegg: [C: 03+2] "Looks good! Might be worth adding a ReferenceData class for these lookups later in case we need the same mapping anywhere in the Civi code" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963329 (https://phabricator.wikimedia.org/T346620) (owner: 10Damilare Adedoyin) [20:27:22] (03Merged) 10jenkins-bot: Add venmo to list of supported payment_methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963329 (https://phabricator.wikimedia.org/T346620) (owner: 10Damilare Adedoyin) [20:28:17] (03PS8) 10Eileen: Fix recurring contributions being given wrong type on subsequent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963428 (https://phabricator.wikimedia.org/T345919) [20:28:25] (03CR) 10Eileen: "thanks ejegg - I made those tweaks" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963428 (https://phabricator.wikimedia.org/T345919) (owner: 10Eileen) [20:33:23] (03PS9) 10Ejegg: Fix recurring contributions being given wrong type on subsequent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963428 (https://phabricator.wikimedia.org/T345919) (owner: 10Eileen) [20:33:34] (03CR) 10Ejegg: [C: 03+2] "Thanks, looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963428 (https://phabricator.wikimedia.org/T345919) (owner: 10Eileen) [20:41:37] 10Fundraising-Backlog, 10FR-donorservices: Indian donor charged twice for second installment of recurring donation - https://phabricator.wikimedia.org/T348258 (10EMartin) @fr-tech. I see ~400 double billed donors from 9/30 and then again on 10/1. It seems to be isolated to PayTM/UPI recurring in India. I w... [20:49:42] (03Merged) 10jenkins-bot: Fix recurring contributions being given wrong type on subsequent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963428 (https://phabricator.wikimedia.org/T345919) (owner: 10Eileen) [20:52:10] 10Fundraising-Backlog, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog (Design): JSON for new app fundraising banners (multilingual, Italy and Netherlands) - https://phabricator.wikimedia.org/T348278 (10spatton) [20:52:29] 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog (Design): JSON for new app fundraising banners (multilingual, Italy and Netherlands) - https://phabricator.wikimedia.org/T348278 (10spatton) [20:53:27] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/963829 [20:54:40] cstone: anything to be aware of deploying the token part of this? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/963829 [20:55:15] no eileen its a script and the currently deployed one has the bug [20:55:18] er like a script we run [20:55:26] ok - cool - will push out [20:55:44] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/963829 (owner: 10Eileen) [20:57:33] !log civicrm upgraded from 05545fbc to 4329014b [20:57:35] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:02:23] (03CR) 10Wfan: [C: 03+2] Add batch and offset options to token migrator [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963424 (https://phabricator.wikimedia.org/T338523) (owner: 10Ejegg) [21:03:48] (03PS4) 10Wfan: Remove Astropay from DI [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/960675 (https://phabricator.wikimedia.org/T326594) [21:03:56] (03CR) 10CI reject: [V: 04-1] Remove Astropay from DI [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/960675 (https://phabricator.wikimedia.org/T326594) (owner: 10Wfan) [21:05:24] (03PS5) 10Wfan: Remove Astropay from DI [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/960675 (https://phabricator.wikimedia.org/T326594) [21:19:03] (03Merged) 10jenkins-bot: Add batch and offset options to token migrator [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963424 (https://phabricator.wikimedia.org/T338523) (owner: 10Ejegg) [21:19:44] (03PS1) 10Wfan: Change hard code wikimedia Foundation to description [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963834 (https://phabricator.wikimedia.org/T347537) [21:20:09] (03CR) 10CI reject: [V: 04-1] Change hard code wikimedia Foundation to description [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963834 (https://phabricator.wikimedia.org/T347537) (owner: 10Wfan) [21:29:49] (03PS2) 10Wfan: use description for descriptor otherwise Wikimedia Foundation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963834 (https://phabricator.wikimedia.org/T347537) [21:30:08] 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog (Design): JSON for new app fundraising banners (multilingual, Italy and Netherlands) - https://phabricator.wikimedia.org/T348278 (10Tsevener) > I'll call out that we added a new property that we called confirmation... [21:39:48] thanks wfan [21:41:21] np, I also made a small patch to use description as venmo descriptor, since you merged that descriptor update ticket, https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/963834/ then this can move to pending deploy ~:) [21:46:13] 10Fundraising-Backlog, 10FR-donorservices: Indian donor charged twice for second installment of recurring donation - https://phabricator.wikimedia.org/T348258 (10Cstone) I think there was some time math issue on our end where we didn't calculate the next_sched_contribution_date right, looking into this now. c... [21:46:46] ejegg: ^ there's some recurring india bug going on, seems to be contained to just ones started on 9/1 but I guess we never fixed that date offset stuff huh [21:48:26] and our dont charge twice in 23 days logic is thwarted by ipns and it being delayed a day (I think need to confirm that but the 2nd charge might have been sent out before the first one was recived) [21:48:28] oh darn [21:48:43] should we disable something right now? [21:48:58] it iddnt happen on 9/2 or forwards so I dont think every charge is doing it [21:49:10] it was just something with the math on 9/1 [21:49:16] I'm about to head out to a parent's night and then a Honk thing... [21:49:39] ah yeah hah I'm about to leave too! yeah I don't think its urgent [21:50:06] k, we can look at it first thing tomorrow [21:50:21] i'll put whatever notes I get on the task [21:54:44] thanks cstone [21:58:45] 10Fundraising-Backlog, 10FR-donorservices: Indian donor charged twice for second installment of recurring donation - https://phabricator.wikimedia.org/T348258 (10Cstone) For refunds we don't have the script made yet task here {T334311} [22:21:12] wfan: ^ looks like we will need that dlocal batch refund sooner than later, do you remember if there was a straightforward api call on dlocals end [22:21:44] I believe so let me check [22:22:55] https://docs.dlocal.com/reference/make-a-refund [22:23:16] 10Fundraising-Backlog, 10FR-dlocal: dlocal refund and script to batch refund csv files - https://phabricator.wikimedia.org/T334311 (10AnnWF) [22:24:00] thanks for looking at that wfan ! [22:25:09] np ~ yeah, refund is always useful when it's needed 😂 [22:36:17] (pretend I'm positively emoji-reacting to all ya'll's points)