[00:38:23] (03PS3) 10Cstone: Add more error handling and actually send through recurring token [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/965606 (https://phabricator.wikimedia.org/T344774) [00:39:27] no linterr!! haha [00:39:59] (03PS4) 10Cstone: Add more error handling and actually send through recurring token [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/965606 (https://phabricator.wikimedia.org/T344774) [00:40:04] (03CR) 10CI reject: [V: 04-1] Add more error handling and actually send through recurring token [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/965606 (https://phabricator.wikimedia.org/T344774) (owner: 10Cstone) [00:41:47] (03CR) 10CI reject: [V: 04-1] Add more error handling and actually send through recurring token [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/965606 (https://phabricator.wikimedia.org/T344774) (owner: 10Cstone) [00:42:58] (03PS5) 10Cstone: Add more error handling and actually send through recurring token [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/965606 (https://phabricator.wikimedia.org/T344774) [00:43:30] oh linter being helpful [00:44:52] (03CR) 10CI reject: [V: 04-1] Add more error handling and actually send through recurring token [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/965606 (https://phabricator.wikimedia.org/T344774) (owner: 10Cstone) [00:46:08] (03PS6) 10Cstone: Add more error handling and actually send through recurring token [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/965606 (https://phabricator.wikimedia.org/T344774) [00:47:47] (03CR) 10CI reject: [V: 04-1] Add more error handling and actually send through recurring token [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/965606 (https://phabricator.wikimedia.org/T344774) (owner: 10Cstone) [00:48:27] (03PS7) 10Cstone: Add more error handling and actually send through recurring token [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/965606 (https://phabricator.wikimedia.org/T344774) [00:56:12] (03CR) 10Ejegg: [C: 03+1] "Looks good, maybe one simplification possible" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/965606 (https://phabricator.wikimedia.org/T344774) (owner: 10Cstone) [00:56:53] oh hoo thinking too hard [00:59:04] (03PS8) 10Cstone: Add more error handling and actually send through recurring token [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/965606 (https://phabricator.wikimedia.org/T344774) [01:03:52] (03PS9) 10Ejegg: Add more error handling and actually send through recurring token [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/965606 (https://phabricator.wikimedia.org/T344774) (owner: 10Cstone) [01:04:02] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/965606 (https://phabricator.wikimedia.org/T344774) (owner: 10Cstone) [01:04:10] thanks so much ejegg ! [01:04:16] :) [01:07:33] (03Merged) 10jenkins-bot: Add more error handling and actually send through recurring token [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/965606 (https://phabricator.wikimedia.org/T344774) (owner: 10Cstone) [01:09:26] (03PS1) 10Cstone: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/965607 [01:09:46] oh wow a new language? [01:10:00] Kalmyk Oirat [01:10:07] (03CR) 10Cstone: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/965607 (owner: 10Cstone) [01:10:25] ahh just for the api! haha [01:10:41] huh, related to Mongolian [01:10:44] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/965607 (owner: 10Cstone) [01:11:00] (03PS8) 10Wfan: Add cancel authorize process from auto rescue end process's webhook message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/958999 (https://phabricator.wikimedia.org/T340159) [01:11:34] (03CR) 10CI reject: [V: 04-1] Add cancel authorize process from auto rescue end process's webhook message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/958999 (https://phabricator.wikimedia.org/T340159) (owner: 10Wfan) [01:11:52] !log payments-wiki upgraded from aa5cd24d to 7f4da789 [01:11:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:12:38] (03PS9) 10Wfan: Add cancel authorize process from auto rescue end process's webhook message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/958999 (https://phabricator.wikimedia.org/T340159) [01:58:05] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices, 10Patch-For-Review: URGENT: Recent Paypal donations without an email address in Civi! - https://phabricator.wikimedia.org/T348760 (10Ejegg) @jgleeson this is messier than we thought. I actually only see 25 rows for people where the... [01:59:46] (03PS1) 10Ejegg: Log PayPal messages as JSON not print_r [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965609 [02:00:33] (03PS2) 10Ejegg: Log PayPal messages as JSON not print_r [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965609 [03:56:39] (03CR) 10Cstone: [C: 03+2] Log PayPal messages as JSON not print_r [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965609 (owner: 10Ejegg) [03:57:09] (03Merged) 10jenkins-bot: Log PayPal messages as JSON not print_r [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965609 (owner: 10Ejegg) [10:20:03] (03PS1) 10Damilare Adedoyin: Contribution recur rows created from the donation import do not set the payment processor id column, making it a bit difficult to search by processor in the ContributionRecurTable. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/965685 [13:15:59] 10Fundraising-Backlog, 10FR-Smashpig, 10Recurring-Donations: Use auto-capture when authorizing recurring charges - https://phabricator.wikimedia.org/T348858 (10Ejegg) [13:33:22] (03CR) 10Jgleeson: [C: 03+2] "This looks fine, thanks! This class is a sure candidate for some refactoring and moving duplicate bits into small fns." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/965685 (owner: 10Damilare Adedoyin) [13:53:51] (03Merged) 10jenkins-bot: Contribution recur rows created from the donation import do not set the payment processor id column, making it a bit difficult to search by processor in the ContributionRecurTable. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/965685 (owner: 10Damilare Adedoyin) [15:27:08] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-PayPal-ExpressCheckout: PayPal EC: Error code 10419 returned: 'Express Checkout PayerID is missing.' - https://phabricator.wikimedia.org/T204289 (10Ejegg) 05Open→03Resolved a:03Ejegg I think we fixed this a while back [15:49:05] 10Fundraising Sprint This LAN is your LAN , 10Fundraising-Backlog: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10Ejegg) OK, I have the files. I am uploading them to Civi and I'll try importing a small batch. [15:53:10] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices, 10Patch-For-Review: URGENT: Recent Paypal donations without an email address in Civi! - https://phabricator.wikimedia.org/T348760 (10jgleeson) >>! In T348760#9247897, @SHust wrote: > @jgleeson Thanks for the update! Does this mean... [15:59:00] 10Fundraising Sprint This LAN is your LAN , 10Fundraising-Backlog: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10Ejegg) Already raising some data quality questions - 32k rows in the first 800k line file have a blank field for the 'echodata' where... [16:11:32] (03PS1) 10Wfan: Remove astropay from smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965774 (https://phabricator.wikimedia.org/T326218) [16:12:02] (03CR) 10CI reject: [V: 04-1] Remove astropay from smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965774 (https://phabricator.wikimedia.org/T326218) (owner: 10Wfan) [16:13:30] (03PS2) 10Wfan: Remove astropay from smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965774 (https://phabricator.wikimedia.org/T326218) [16:13:57] (03CR) 10CI reject: [V: 04-1] Remove astropay from smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965774 (https://phabricator.wikimedia.org/T326218) (owner: 10Wfan) [16:15:13] (03PS3) 10Wfan: Remove astropay from smashpig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965774 (https://phabricator.wikimedia.org/T326218) [16:20:59] 10fundraising-tech-ops, 10FR-Tech-Analytics: ??? showing up in email names with ZB in Superset - https://phabricator.wikimedia.org/T348882 (10Dwisehaupt) [16:23:32] 10Fundraising Sprint This LAN is your LAN , 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Bad query on civicrm mailing dash board - https://phabricator.wikimedia.org/T335071 (10AnnWF) [16:28:07] 10Fundraising-Backlog: Unexpected $0 auths through Adyen - https://phabricator.wikimedia.org/T348715 (10EMartin) f it's helpful to know we had another donor reach out in #1372985/CID 29712748 where they donated CA$26.00 as a one-time donation (and they don't have any future recurring donations) and they've also... [17:14:21] 10Fundraising Sprint This LAN is your LAN , 10Fundraising-Backlog: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10EMartin) I emailed Pim at Ingenico today to understand why this field would be blank. [17:36:43] 10Fundraising-Backlog: Unexpected $0 auths through Adyen - https://phabricator.wikimedia.org/T348715 (10EMartin) I found that one donor complained about seeing Wikimedia Foundation, St. Louis in the descriptor which is suspect and ties to another issue that is possibly fraud @MBeat33 saw through Stripe associate... [17:37:06] 10Fundraising-Backlog: Unexpected $0 auths on donor statements - https://phabricator.wikimedia.org/T348715 (10EMartin) [18:48:00] 10Fundraising-Backlog: Unexpected $0 auths on donor statements - https://phabricator.wikimedia.org/T348715 (10EMartin) Update here is that this may be tied to some Operations testing by a third party provider Delve. FRTech - I do not believe this concerns you. I am confirming this and will close out this task o... [18:49:34] 10Fundraising-Backlog: Unexpected $0 auths on donor statements - https://phabricator.wikimedia.org/T348715 (10greg) Can you say more about what Delve is providing for us? So that we can stay in the loop on any future issues. [19:27:51] 10Fundraising Sprint This LAN is your LAN , 10Fundraising-Backlog: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10Ejegg) Thanks, Evelyn. I have done some database queries, and it looks like of those 32,118 blank rows in the first file, 3934 donors... [19:39:33] 10Fundraising Sprint This LAN is your LAN , 10Fundraising-Backlog: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10Ejegg) @EMartin There are also some rows where the echodata (the Ingenico token) is partially replaced with *** characters. I've check... [19:41:21] (03CR) 10Ejegg: [C: 03+2] "As discussed in IRC, comment updates can come at the end of the chain." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963401 (https://phabricator.wikimedia.org/T346194) (owner: 10Eileen) [19:47:00] (03PS7) 10Ejegg: Remove temporary mailing update, replace with job to run through. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963401 (https://phabricator.wikimedia.org/T346194) (owner: 10Eileen) [19:47:15] (03CR) 10Ejegg: [C: 03+2] "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/963401 (https://phabricator.wikimedia.org/T346194) (owner: 10Eileen) [19:47:32] (03CR) 10Ejegg: [C: 03+2] "Looks good" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964608 (https://phabricator.wikimedia.org/T335070) (owner: 10Eileen) [19:48:00] (03CR) 10Ejegg: [C: 03+2] "clever!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964621 (https://phabricator.wikimedia.org/T335070) (owner: 10Eileen) [19:52:16] 10Fundraising Sprint This LAN is your LAN , 10Fundraising-Backlog: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10EMartin) @Ejegg Thanks Elliott! Then from Pim we want: - the 32,118 blank rows in the first file (1a.csv) Echodata field populated fu... [19:53:37] 10Fundraising Sprint This LAN is your LAN , 10Fundraising-Backlog: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10Ejegg) No, the other files have the same problems - I was just using the first file to get an idea of what percentage of rows were aff... [19:55:16] (03CR) 10Ejegg: [C: 03+2] "On second thought, for a deletion this straightforward, would it make sense to just run a single delete query during the maintenance windo" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964621 (https://phabricator.wikimedia.org/T335070) (owner: 10Eileen) [19:57:37] (03CR) 10CI reject: [V: 04-1] Add step to delete mailing_job rows once orphaned [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964608 (https://phabricator.wikimedia.org/T335070) (owner: 10Eileen) [19:57:39] (03CR) 10CI reject: [V: 04-1] Insert step (with special before magic) to remove old queue items [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964621 (https://phabricator.wikimedia.org/T335070) (owner: 10Eileen) [20:05:45] (03PS8) 10Wfan: Add declineMonthlyConvert as param for post Monthly Convert donation api [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/963970 (https://phabricator.wikimedia.org/T347606) [20:06:21] (03PS3) 10Ejegg: Add step to delete mailing_job rows once orphaned [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964608 (https://phabricator.wikimedia.org/T335070) (owner: 10Eileen) [20:06:53] (03PS5) 10Wfan: Add api to remove recuring payment token then delete customer from venmo vault for one-time donor [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963853 (https://phabricator.wikimedia.org/T347606) [20:07:00] (03CR) 10CI reject: [V: 04-1] Add declineMonthlyConvert as param for post Monthly Convert donation api [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/963970 (https://phabricator.wikimedia.org/T347606) (owner: 10Wfan) [20:09:53] 10Fundraising Sprint This LAN is your LAN , 10Fundraising-Backlog: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10EMartin) Ok, I have submitted the problem to Pim in email. I assume that means he will have to re supply all of the files to Adyen wi... [20:13:57] (03PS9) 10Wfan: Add declineMonthlyConvert as param for post Monthly Convert donation api [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/963970 (https://phabricator.wikimedia.org/T347606) [20:14:02] 10Fundraising Sprint This LAN is your LAN , 10Fundraising-Backlog: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10Ejegg) Oh sorry, I didn't realize Pim was with Ingenico. I was thinking the problem was on Adyen's side, that they had mistakenly omit... [20:15:19] (03CR) 10Ejegg: [C: 03+2] "Looks good" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964608 (https://phabricator.wikimedia.org/T335070) (owner: 10Eileen) [20:15:24] (03PS5) 10Ejegg: Insert step (with special before magic) to remove old queue items [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964621 (https://phabricator.wikimedia.org/T335070) (owner: 10Eileen) [20:21:01] 10Fundraising Sprint This LAN is your LAN , 10Fundraising-Backlog: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10Ejegg) Let's ask our Adyen contact to take a look at some of those rows (including the very first data row in the first file - it has... [20:21:45] 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog (Android Release - FY2023-24), 10Wikipedia-iOS-App-Backlog (Design), 10iOS Release FY2023-24: JSON for new app fundraising banners (multilingual, Italy and Netherlands) - https://phabricator.wikimedia.org/T348278 (10ABorbaWMF) Looks good to m... [20:22:16] 10Fundraising-Backlog: Unexpected $0 auths on donor statements - https://phabricator.wikimedia.org/T348715 (10EMartin) It turns out that this does NOT involve Delve and we have an issue still where $0 auths are being performed from somewhere and showing up on donor statements as Wikimedia Foundation St. Louis.... [20:31:00] (03Merged) 10jenkins-bot: Add step to delete mailing_job rows once orphaned [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964608 (https://phabricator.wikimedia.org/T335070) (owner: 10Eileen) [20:33:50] 10Fundraising Sprint This LAN is your LAN , 10Fundraising-Backlog: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10Ejegg) >>! In T344645#9250946, @EMartin wrote: > Ok, I have submitted the problem to Pim in email. I assume that means he will have t... [20:42:29] 10Fundraising Sprint This LAN is your LAN , 10Fundraising-Backlog: AMEX rejected transactions through Ingenico are to be ported to Adyen - https://phabricator.wikimedia.org/T338523 (10Ejegg) 05Open→03Resolved [21:20:01] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/965806 [21:20:04] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/965806 (owner: 10Ejegg) [21:20:51] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/965806 (owner: 10Ejegg) [21:22:25] 10Fundraising Sprint This LAN is your LAN , 10Fundraising-Backlog, 10Patch-For-Review: Issue with Paypal donations made on GiveLively for events - https://phabricator.wikimedia.org/T295726 (10Ejegg) a:03Ejegg [21:24:17] 10Fundraising Sprint This LAN is your LAN , 10Fundraising-Backlog: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10EMartin) Thanks. Understood. [22:21:00] !log fundraising civicrm upgraded from c5f54d97 to e71ccffb [22:21:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:39:20] 10Fundraising Sprint This LAN is your LAN , 10Fundraising-Backlog: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10Ejegg) (technical musings...) Starting to think that the batch job is not the way to catch all the edge cases in the csvs and in our d... [23:13:16] (03CR) 10Cstone: Add declineMonthlyConvert as param for post Monthly Convert donation api (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/963970 (https://phabricator.wikimedia.org/T347606) (owner: 10Wfan) [23:27:05] (03PS3) 10Cstone: UPI: stop setting early next_sched_contribution_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964074 (https://phabricator.wikimedia.org/T348258) (owner: 10Ejegg) [23:37:06] (03CR) 10Cstone: "I agree with just deleting the whole date manipulation part but there are still ~600 donations still on the MONTHLY style contract. We don" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964074 (https://phabricator.wikimedia.org/T348258) (owner: 10Ejegg) [23:53:18] thanks cstone! [23:54:06] yeah I had forgotten about that part when we were talking about it before [23:54:40] hmm, so will we actually be in danger of trying to charge them twice in a month this way? [23:54:54] hmmmm [23:55:02] I thought the date would always err on the side of one day LATER after this change [23:55:04] what did I do I pushed their dates all forward a day [23:55:17] did i think about it backwards [23:55:32] so at worst we would miss the chance to charge them in some given month [23:56:14] they start september 1 we do no time match normal everything next sched nov 1 [23:56:22] and then okay the prenotifcation would go out on the 1 [23:56:24] charge on the 2 [23:56:27] ok yeah sorry ejegg ! [23:56:36] cool cool! [23:57:18] oh I think this change is specifically for new contribution_recur rows, too [23:57:33] it's down in the insertContributionRecur function, anyway [23:58:04] hmm, so, I think we still might have to fix some next_sched_ dates in the db after this though [23:58:46] if there are any more where the next_sched_ date is end-of-month-ish and the cycle_day is 1 [23:59:05] ok we can hunt with searchkit for those [23:59:58] cool cool