[00:04:42] rip dlocal sandbox console must break every friday [00:04:48] it was broken last friday too [00:17:58] (03CR) 10Cstone: [C: 03+2] "Thanks for this! Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964074 (https://phabricator.wikimedia.org/T348258) (owner: 10Ejegg) [00:22:35] ejegg: not actually too many with the next sched cycle day 4 on october 31 that I'll fix [00:23:39] ok, great [00:24:46] (03CR) 10Wfan: Add declineMonthlyConvert as param for post Monthly Convert donation api (032 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/963970 (https://phabricator.wikimedia.org/T347606) (owner: 10Wfan) [00:25:17] wfan: ^ yeah it just doesnt do anything until I click on it again [00:26:42] just wait a bit like you wait for venmo to close the modal haha [00:27:07] its just when its not like that it closes immediately [00:28:34] yeah, since it's a close model function, it is annoying to not see it perform immediately~ [00:28:35] i just see it causing issues for DR if we have to wait that long for it to close [00:28:42] people will get confused [00:29:34] let me see what else I can do, since we must bind the function with no and closebutton [00:32:48] wfan and for the people that just close the browser window? [00:33:18] I do not think I have this handled [00:33:20] should we be doing the cleanup from the backend instead? [00:33:37] you mean doing this afterward? [00:33:39] (03Merged) 10jenkins-bot: UPI: stop setting early next_sched_contribution_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/964074 (https://phabricator.wikimedia.org/T348258) (owner: 10Ejegg) [00:35:26] wfan yeah, maybe the close or whatever button could just send a job to a queue [00:35:40] so the donor doesn't have to wait for us to make an API call out [00:36:01] though that still doesn't catch the ppl who just close the window [00:36:01] ok, but that still not going to cover close the browser [00:36:20] would need something like the pending txn resolver [00:36:53] that keeps a list of vaulted tokens, then after a day deletes them if they haven't got a matching contribution_recur row [00:37:35] while since we do not store the recurring token to our db until they agree post monthly convert, we have no idea if those users got tokenized or not, or I can [00:38:05] let all transactions go over that and add a check if they do not have recurring token [00:38:11] created the first place [00:38:24] then we can cover those users that close the browser~ [00:38:27] i wonder if we can just get donor relations to accept all the vaults vs all this work/situations? [00:39:09] yeah, how important is it to them? [00:39:39] I think it's important for Rakhi for understand how many of those are one-time donor [00:39:53] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices, 10Patch-For-Review: Indian donor charged twice for second installment of recurring donation - https://phabricator.wikimedia.org/T348258 (10Cstone) There were 4 donors that had this situation set up for october 31, I manually fixed... [00:40:29] (i'm kind-of wishing we had had a token cleanup process for ingenico right now as most of the 4 million + csv rows don't actually have a recurring ) [00:42:02] yeah wow [00:42:02] Yeah, the original plan is to have this recurring token clean up for all gateways but that's just ideal not something DR needed immediately, so I think the queue stuff works better, since we want to clean them all, just then we need a bit more time for venmo to get this function out~ [00:42:14] big argument to start with cleanup there then [00:45:59] but if we do that from backend by checking if they have recurring token but not have a matching contribution_recur row, we can return regular ty for this Modal's cancel and close. Let me at update this for a better customer behavior, thanks elloitt~ [00:46:08] tle really getting immortalized in our paypal code :P [00:47:59] hmm, but that might have some limitation for other payment gateways if they do not have api to check recurring token afterward~ [00:54:34] (03CR) 10Cstone: [C: 03+2] "I like having the config value as this does seem like something that would randomly change" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965559 (https://phabricator.wikimedia.org/T295726) (owner: 10Ejegg) [00:55:05] (03Merged) 10jenkins-bot: Ignore IPNs for likely GiveLively donations [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/965559 (https://phabricator.wikimedia.org/T295726) (owner: 10Ejegg) [00:59:30] thanks cstone [00:59:43] do i want to know why the audit is called trr [01:01:44] (03CR) 10Cstone: [C: 03+2] "Looks good!" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/965564 (https://phabricator.wikimedia.org/T295726) (owner: 10Ejegg) [01:02:36] (03PS4) 10Cstone: Donation amount in Civi does not match the donation amount received at dLocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/964015 (https://phabricator.wikimedia.org/T346101) (owner: 10Damilare Adedoyin) [01:02:54] (03Merged) 10jenkins-bot: Ignore likely GiveLively lines in PayPal audit [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/965564 (https://phabricator.wikimedia.org/T295726) (owner: 10Ejegg) [01:16:13] (03CR) 10Cstone: [C: 03+2] "Nice! Fixes it and matches the params that the ty page gets without a redirect" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/964015 (https://phabricator.wikimedia.org/T346101) (owner: 10Damilare Adedoyin) [01:17:35] im gona head out, have a good weekend everyone [01:18:05] (03Merged) 10jenkins-bot: Donation amount in Civi does not match the donation amount received at dLocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/964015 (https://phabricator.wikimedia.org/T346101) (owner: 10Damilare Adedoyin) [02:27:57] (03PS1) 10Ejegg: Scripts for doing token migration in the db [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/965844 (https://phabricator.wikimedia.org/T344645) [02:34:23] (03PS2) 10Ejegg: Scripts for doing token migration in the db [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/965844 (https://phabricator.wikimedia.org/T344645)