[00:00:42] cstone: you can try adding to dasboard - https://usercontent.irccloud-cdn.com/file/prxATxQz/image.png [00:01:34] on the home screen? [00:03:03] 10Fundraising Sprint This LAN is your LAN, 10Fundraising-Backlog, 10FR-donorservices: Unable to transfer donations from one CID to another after accidental CID merge. - https://phabricator.wikimedia.org/T330539 (10Eileenmcnaughton) [00:17:50] oooh nice eileen [00:19:10] eileen: the recorded tech talk today dallas explained some of the graphs we were looking at last week [00:25:50] cstone: you have to add it to get it to the dashboard - there is a thingee [00:25:58] yeah i got it eileen [00:26:05] and searched it was quick! [01:32:47] (03PS1) 10Eileen: Add move contribution to search kit actions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/966940 (https://phabricator.wikimedia.org/T330539) [01:40:43] cool cool [01:43:17] 10Fundraising Sprint This LAN is your LAN, 10Fundraising-Backlog, 10FR-donorservices: Unable to transfer donations from one CID to another after accidental CID merge. - https://phabricator.wikimedia.org/T330539 (10Eileenmcnaughton) It seems this needs the contributions moved before closing - will try to get... [01:47:44] eileen: do you think we should add something to that extension to move contribution_recur rows? [01:48:14] It does let us move the individual contributions in a recur [01:48:21] ejegg: hmm - I mean we could - it wouldn't be totally trivial cos it involves Quick form [01:48:41] and leaves them pointed to a recur row owned by another contact [01:49:17] yeah... [01:49:28] yeah, we would maybe have to move payment tokens too if we started moving recur rows [01:50:42] and those can be used for multiple recurs... [01:50:55] ok, maybe we don't open that can of worms just now [01:51:14] hmm [01:51:39] I did open a small wormy can - adding the action to search kit but that has a PR & I'm trying to put a lid back on it now [01:51:46] :) [01:52:20] this was my minor foray into wormville - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/966940 [02:02:02] hmm i wasnt meaning to look this up but since we were talkinga bout it earlier, we are saving fee info for paypal recurrings but not paypal one times [02:07:56] that makes sense cstone [02:09:24] we send one-time paypal donations to the queue from payments-wiki [02:09:36] hah and some of these paypal no emails were people who had data deletion requests [02:09:37] and we're not pulling the fee from the DoExpressCheckoutPayment result [02:09:46] oho, but it is there! [02:09:54] oooh [02:10:03] https://developer.paypal.com/api/nvp-soap/do-express-checkout-payment-nvp/ [02:10:14] gotta scroll way down to find the response fields [02:10:22] but there's a PAYMENTINFO_n_FEEAMT [02:10:55] also PAYMENTINFO_n_SETTLEAMT and PAYMENTINFO_n_SETTLEMENTFEEAMOUNT [02:11:09] to tell us the actual conversion rate used [02:11:13] do we add those fee amounts together for recurring? [02:12:27] it looks like FEEAMT is the total fee in the currency seen by the donor [02:12:45] and SETTLEMENTFEEAMT is the total fee in the settled currency (for us, USD) [02:13:00] ahhh i see [02:14:01] err, or i could be mistaken - says the SETTLEMENT one is ' Applicable only for use cases where the PayPal fee is charged in the settlement currency' [02:14:30] anyway, for recurring paypal we only send the pending message from the front-end [02:14:50] and we wait for the IPN to send the recurring queue message s [02:14:52] yeah we are getting the fee in the audit too but then ignoring [02:15:18] T152249 is the ticket to do something with it [02:15:19] T152249: Update Civi record with additional data from audit files - https://phabricator.wikimedia.org/T152249 [02:16:11] wouldl be nice to have that now, to easily compare fees between payments + FRUP [02:16:24] haha i was going to ask what the superman scenario is [02:21:01] hah, I wonder if DStrine was thinking of Office Space? [02:21:20] stealing pennies here and there from each transaction [02:22:11] This January they caught a guy doing just that at Zulily: https://www.boston.com/news/crime/2023/01/04/office-space-movie-inspired-employee-to-steal-302278-police-say/ [02:23:19] "the company’s director of cybersecurity, reported that he’d found a document on the laptop titled “OfficeSpace project,” which allegedly laid out the scheme to steal the shipping fees" [02:23:31] EvilPlan.ppt [02:23:43] ok, I gotta get to bed [02:23:48] hah wow [02:25:05] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-WMF-Audit: Update Civi record with additional data from audit files - https://phabricator.wikimedia.org/T152249 (10Cstone) Maybe email too? That would also help with the paypal situation in {T348760} [02:27:01] omg the end of that article [02:27:09] “He clarified that he had used the money to invest in stock options, particularly GameStop stock options,” the detective said in the affidavit, “and reiterated that all the money was now gone.” [02:27:47] nooo haha not GME [02:28:28] galaxy brain, there [02:29:02] hmm, so email would mean more db impact unfortunately. we could check [02:29:50] we are already fetching the whole contribution and contribution_extra row in the audit processor, just to check if it exists [02:30:23] so we can compare all that data with what's in the audit row and just send the new stuff [02:30:31] hmm [02:31:31] fetching email would just be one more join, i guess [02:33:29] k, done for real. gnight! [02:33:34] night [03:17:05] 10Fundraising Sprint This LAN is your LAN, 10Fundraising-Backlog: Data Axle project - New fields in Civi - https://phabricator.wikimedia.org/T336890 (10Eileenmcnaughton) @MDemosWMF I'm just looking to start creating these fields - it seems we have 2 'types' of fields 1) Data Axel specific - these have no exis... [04:15:52] (03PS1) 10Eileen: Add new DataAxle fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/966942 (https://phabricator.wikimedia.org/T336890) [04:18:20] (03CR) 10CI reject: [V: 04-1] Add new DataAxle fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/966942 (https://phabricator.wikimedia.org/T336890) (owner: 10Eileen) [04:25:17] (03PS2) 10Eileen: Add new DataAxle fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/966942 (https://phabricator.wikimedia.org/T336890) [04:27:38] (03CR) 10CI reject: [V: 04-1] Add new DataAxle fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/966942 (https://phabricator.wikimedia.org/T336890) (owner: 10Eileen) [04:28:17] (03PS3) 10Eileen: Add new DataAxle fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/966942 (https://phabricator.wikimedia.org/T336890) [06:06:59] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_40) - 10https://gerrit.wikimedia.org/r/966978 (owner: 10L10n-bot) [06:40:27] (03PS1) 10Wfan: Use latest cid is_opt_id option as default [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/967066 [06:56:33] (03CR) 10CI reject: [V: 04-1] Use latest cid is_opt_id option as default [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/967066 (owner: 10Wfan) [07:00:12] (03PS2) 10Wfan: Use latest cid is_opt_id option as default [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/967066 [08:14:12] 10Fundraising-Backlog, 10FR-donorservices: Snoozed donor received fundraising email - https://phabricator.wikimedia.org/T349277 (10krobinson) [08:19:34] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: Snoozed donor received fundraising email - https://phabricator.wikimedia.org/T349277 (10Damilare) [11:34:50] 10Fundraising-Backlog, 10Data Engineering and Event Platform Team, 10Data-Engineering, 10MediaWiki-extensions-EventLogging, and 2 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10matmarex) [12:21:58] 10fundraising-tech-ops: Backfill logs for 2023-10-11 to 2023-11-18 into fundraising banner stats. - https://phabricator.wikimedia.org/T349253 (10Jgreen) [12:24:29] 10fundraising-tech-ops: Backfill logs for 2023-10-11 to 2023-11-18 into fundraising banner stats. - https://phabricator.wikimedia.org/T349253 (10Jgreen) 05Open→03In progress p:05Triage→03Medium a:03Jgreen [13:07:10] 10Fundraising-Backlog, 10Data Engineering and Event Platform Team, 10Data-Engineering, 10MediaWiki-extensions-EventLogging, and 2 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10Ottomata) [14:53:51] 10Fundraising-Backlog, 10fundraising-tech-ops: process control jobs now running wiredness - https://phabricator.wikimedia.org/T349242 (10Jgreen) [15:24:02] 10Fundraising-Backlog, 10fundraising-tech-ops: process control jobs now running wiredness - https://phabricator.wikimedia.org/T349242 (10Jgreen) The missing jobs ran in a few seconds, and were just missed by the prometheus sampling interval. There's no good way to store timestamps in prometheus, metrics are s... [15:41:24] 10fundraising-tech-ops: Backfill logs for 2023-10-11 to 2023-11-18 into fundraising banner stats. - https://phabricator.wikimedia.org/T349253 (10Jgreen) 05In progress→03Resolved "Numbers look more than plausible." done! [15:43:58] (03PS1) 10Ejegg: PayPal: Tag rather than discard GiveLively IPNs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/967238 (https://phabricator.wikimedia.org/T295726) [16:25:29] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Internal test: for validate all dlocal submethods - https://phabricator.wikimedia.org/T346814 (10AnnWF) >>! In T346814#9259104, @RKumar_WMF wrote: > For CL - When donor is trying to use Bank transfer, he is facing below issue: > > "Hi! I've tried, but it... [16:29:27] (03PS1) 10Ejegg: PayPal: Tag rather than discard GiveLively audit rows [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/967250 (https://phabricator.wikimedia.org/T295726) [16:55:48] 10Fundraising-Backlog: Venmo non-native browser flow posing checkout issues for donors - https://phabricator.wikimedia.org/T348699 (10EMartin) [17:28:06] 10Fundraising-Backlog: Venmo non-native browser flow posing checkout issues for donors - https://phabricator.wikimedia.org/T348699 (10EMartin) Meeting held 19 Oct to discuss. Conclusion on approach: Peter will attempt to pull portions of the Venmo library into the flow to attempt detection of the non-supported... [17:51:39] 10Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, 10Fundraising Sprint This LAN is your LAN, 10Fundraising-Backlog: investigate: Record user agent in contribution_tracking - https://phabricator.wikimedia.org/T182039 (10Ejegg) a:03Ejegg [18:05:12] fr-tech can someone remind me how we dealt with the problem using getallheaders() ? [18:05:43] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Patch-For-Review: Set up Community CiviCRM instance. - https://phabricator.wikimedia.org/T343486 (10Dwisehaupt) @LSobanski We have come to the point where we are ready to get review on the community crm module for the production puppet. Is there someone specif... [18:07:35] aha, it was in SmashPig [18:07:59] hmm, and we got around it by using the symfony wrapper, which we're not here [18:08:08] err, which we're not using in DonationInterface [18:08:31] let's see what MW core has [18:17:16] ok, $headers = RequestContext::getMain()->getRequest()->getAllHeaders(); [18:17:32] let's see if the parser library likes that [18:32:17] (03PS1) 10Damilare Adedoyin: Handle Adyen refund IPNs for non-USD donations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/967264 (https://phabricator.wikimedia.org/T347422) [18:33:28] (03PS1) 10Ejegg: Add user-agent info to contribution_tracking [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/967266 (https://phabricator.wikimedia.org/T182039) [18:35:32] (03CR) 10CI reject: [V: 04-1] Add user-agent info to contribution_tracking [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/967266 (https://phabricator.wikimedia.org/T182039) (owner: 10Ejegg) [18:36:43] i don't like when spell check tells me a word is misspelled but then does not give me any further information [18:45:25] about to start a payments deploy to clear off cc pending block [18:46:08] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/967270 [18:46:43] (03PS1) 10Ejegg: Save user-agent info to contribution_tracking table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/967271 (https://phabricator.wikimedia.org/T182039) [18:46:59] (03CR) 10Damilare Adedoyin: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/967270 (owner: 10Damilare Adedoyin) [18:47:31] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/967270 (owner: 10Damilare Adedoyin) [19:10:30] ejegg: you mean the actual fix or the workaround [19:10:40] do* [19:14:30] jgleeson: ah, I figured it out, thanks! [19:46:25] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Internal test: for validate all dlocal submethods - https://phabricator.wikimedia.org/T346814 (10EMartin) @AnnWF @RKumar_WMF The Latam pretest is scheduled now for 7 February 2024 [20:19:44] (03PS2) 10Ejegg: Add user-agent info to contribution_tracking [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/967266 (https://phabricator.wikimedia.org/T182039) [20:50:21] (03CR) 10Jforrester: [C: 03+2] "False positive." [extensions/DonationInterface] (REL1_40) - 10https://gerrit.wikimedia.org/r/966978 (owner: 10L10n-bot) [20:50:31] (03CR) 10Jforrester: [C: 03+2] "False positive." [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/966704 (owner: 10L10n-bot) [21:12:15] (03CR) 10Ejegg: [C: 03+1] "This seems to work! I'm a little queasy about leaving the original_amount mismatching the original_currency, even though we don't currentl" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/967264 (https://phabricator.wikimedia.org/T347422) (owner: 10Damilare Adedoyin)