[00:07:32] <dwisehaupt>	 eileen: i think then changes for https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/969972 look good so far. let me know if you move it out of WIP and want it approved.
[00:07:52] <dwisehaupt>	 the changes even.
[00:08:22] <eileen>	 dwisehaupt: ok - I guess I just need to make sure I have the main English strings - for the bulk
[00:09:34] <eileen>	 I think there is a question how we run it - ie will the job get there eventually or did the sql keep degrading to the point it will kinda suck now
[00:10:02] <wikibugs>	 (03PS1) 10Eileen: wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969983
[00:10:09] <eileen>	 but I guess we could put out as is & run a bit - I added to it such that run with -vv it outputs usable sql
[00:10:18] <eileen>	 well somewhat usable
[00:10:33] <ejegg>	 dwisehaupt: you all have privatebin running on bullseye / php7.4 at this point, right?
[00:10:51] <ejegg>	 I'm just realizing we have a couple old buster images still running in dev
[00:13:46] <dwisehaupt>	 ejegg: yeah, it's running on the same as donorwiki.
[00:14:07] <ejegg>	 k, I'll update that dev image too
[00:14:19] <ejegg>	 and then we can clear out all the fundraising-buster stuff from dev-images
[00:14:35] <dwisehaupt>	 yeah, the only thing we still have on buster are the pay-lvs hosts.
[00:14:42] <dwisehaupt>	 everything else is bullseye at this point.
[00:15:10] <ejegg>	 great
[00:15:28] <dwisehaupt>	 eileen: cool. i have to head up and corral kids and get dinner going but can stop back in after ~2 hours or so.
[00:15:41] <eileen>	 ok cool
[00:24:49] <ejegg>	 ahh right, we maybe could use the same mediawiki image
[00:25:38] <ejegg>	 that's right, since we moved the apache config out of the docker container and read it from the host, we are already re-using the mw image for SmashPig
[00:25:47] <ejegg>	 k, guess I'll try that
[00:28:02] <cstone>	 ejegg: do you remember why fundraiseup sends things to the recurring queue?
[00:29:52] <ejegg>	 cstone there is one export for donations and one for new recurring plans, i think
[00:30:05] <cstone>	 yeah but donations queue usually handles new recurrings?
[00:30:07] <ejegg>	 and maybe one for cancelled recurring plans
[00:31:47] <cstone>	 but i gues cause its acting like paypal ?
[00:31:57] <ejegg>	 hmm, looking in the RecurringImport.php, I don't see much that wouldn't be in the DonationsImport
[00:32:11] <ejegg>	 yeah, acting like paypal sounds right
[00:32:37] <ejegg>	 so theoretically the Recurring Frequency would only be in the RecurringImport
[00:32:45] <ejegg>	 but I think we're only allowing monthly there too
[00:33:26] <ejegg>	 eh, they have next donation date too but that's not a big thing for a processor-scheduled recur
[00:33:51] <ejegg>	 cstone: are you finding that ones created from the recur import are the ones missing the utm_ fields?
[00:34:45] <cstone>	 no
[00:34:49] <cstone>	 I was just curious 
[00:35:14] <cstone>	 utm thing is weird its really front loaded like the first 40 donations didnt have it then like 4 have it missing afterwards
[00:38:16] <ejegg>	 Had to train the AI to pass the params along?
[00:42:51] <cstone>	 yeah i dont know data checking 
[00:43:36] <cstone>	 i think the data is there in the spreadsheet but not in civi for those first 40 trying to find if anything changed
[00:59:09] <wikibugs>	 (03CR) 10Wfan: [C: 03+2] "yeah drush @wmff cvapi extension.upgrade is the right commend, looks good thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969388 (https://phabricator.wikimedia.org/T349158) (owner: 10Ejegg)
[01:01:15] <ejegg>	 thank you wfan 
[01:04:05] <wfan>	 thanks ejegg, will update my patch accordingly :)
[01:06:34] <cstone>	 hmm what did we do so fundraise up ignores logs 
[01:08:54] <eileen>	 hey I just pushed up updated strings to remove for thank yous- it might not be quite final - but I'll only add a few more strings now as they are getting slower to find so would be good to get reviewed
[01:09:31] <eileen>	 - ie then Dallas can finalise any last ones 
[01:09:32] <eileen>	 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/969972
[01:15:45] <wikibugs>	 (03Merged) 10jenkins-bot: Rename External_Identifiers table to wmf_external_contact_identifiers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969388 (https://phabricator.wikimedia.org/T349158) (owner: 10Ejegg)
[01:18:54] <ejegg>	 cstone: the log ignoring is by overriding the whole log_hunt_and_send function in the audit processor subclass
[01:19:09] <cstone>	 ah yeah but its looking for it when i try and run it locally
[01:19:11] <ejegg>	 which makes sense, cause there are no paymentswiki logs for frup
[01:19:23] <ejegg>	 ahh, it's looking for the folders, right?
[01:19:26] <cstone>	 im getting an error cause it cant find the log dir
[01:19:33] <cstone>	 yeah even though the folder is there
[01:19:37] <ejegg>	 yeah, we just need to set a dummy variable
[01:19:39] <ejegg>	 oh weird
[01:19:47] <ejegg>	 is there something silly like a - or no -
[01:19:48] <ejegg>	 ?
[01:19:54] <cstone>	 haha i changed that like 30000 times
[01:19:56] <ejegg>	 I think I remember a glitch like that ocally
[01:20:01] <cstone>	 i think we should fix that naming...
[01:20:04] <ejegg>	 yarp
[01:20:28] <cstone>	 i have the right - situation because it can find incoming and completed
[01:20:35] <ejegg>	 well huh
[01:20:36] <cstone>	 but then errors out on MISSING_DIR_LOG_WORKING
[01:20:45] <ejegg>	 oh, there's a drupal var to set too maybe
[01:20:46] <ejegg>	 ?
[01:20:50] <cstone>	 fundraise up doesnt have a drupal log line but how is it working on live?
[01:20:57] <cstone>	 er log var
[01:21:06] <ejegg>	 oh i thought we had to set it there
[01:21:13] <ejegg>	 just with drush vset
[01:21:29] <cstone>	 so it doesnt show up in the UI?
[01:21:33] <ejegg>	 maybe not
[01:21:43] <cstone>	 hmmmmmm i think we should make that match the others too then
[01:21:47] <ejegg>	 orrr wait, are the log dirs even per-processor?
[01:21:51] <cstone>	 yes
[01:22:00] <ejegg>	 right, the filtered / 'working' dirs
[01:22:18] <ejegg>	 we should ideally just stop it looking for that dir if it's never gonna need it
[01:22:28] <cstone>	 but even on live fundraise up doesnt have the drupal var for logs in the UI
[01:22:41] <ejegg>	 yah i think we just vset it
[01:23:32] <ejegg>	 fundraiseup_audit_working_log_dir: /var/log/fundraising/fundraise-up/
[01:25:11] <cstone>	 how did the ui get there hmm
[01:28:46] <wikibugs>	 (03PS1) 10Ejegg: Use bullseye for civiproxy [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/970006
[01:29:16] <cstone>	 ok now how to get a new variable hmm
[01:29:17] <ejegg>	 ^^^ was surprisingly easy
[01:29:32] <ejegg>	 cstone you can just drush vset fundraiseup_audit_working_log_dir /var/log/fundraising/fundraise-up/
[01:29:49] <cstone>	 i know but future me isnt oging to remmeber and get trapped again
[01:30:07] <ejegg>	 ahh i think it's actually set in some setup.sh subprocess
[01:30:16] <ejegg>	 so it shouldn't be a problem after the next rebuild
[01:30:29] <ejegg>	 i think our civibuild config makes all of those?
[01:31:17] <ejegg>	 https://github.com/civicrm/civicrm-buildkit/blob/master/app/config/wmff/install.sh#L133
[01:31:30] <cstone>	 i have a fresh install and its not there though
[01:31:45] <ejegg>	 ah needs civibuild git update then
[01:31:51] <cstone>	 hmmm okay
[01:32:55] <ejegg>	 ok, so I think the civi user that has the api key just isn't registering as having the 'authenticate with api key' permission under authx
[01:33:04] <cstone>	 i would like to see the UI to know that it exists even if it isn't used since if its not there it breaks
[01:33:42] <ejegg>	 hmm, i guess
[01:34:05] <ejegg>	 or let's see if that check is easy to extract into something we can override to make it not break
[01:34:33] <cstone>	 i think its ok ejegg if I had everything updated
[01:34:41] <cstone>	 just the UI to show me that that variable was never set
[01:35:19] <cstone>	 now the - is hating me haha
[01:36:49] <wikibugs>	 (03PS1) 10Ejegg: Stop checking for FRUP working log dir [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970007
[01:36:56] <ejegg>	 cstone: ^^^
[01:37:01] <cstone>	 haha not the oppposite
[01:38:08] <cstone>	 solves my problem of where to put the - haha
[01:38:24] <cstone>	 wooo ran the audit
[01:38:55] <ejegg>	 :)
[01:39:05] <wikibugs>	 (03PS4) 10Eileen: Add some more strings for deleting activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969972 (https://phabricator.wikimedia.org/T325123)
[01:41:54] <cstone>	 i dont understand what happened with the utms the csv all looks the same but the first 17 just didn't get inserted and the rest did
[01:42:10] <cstone>	 then its been fine since
[01:42:50] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Fundraiseup new recurring missing utm_* fields in Contribution Tracking table - https://phabricator.wikimedia.org/T350063 (10Cstone) Looks like this issue was with the first 17 recurring donations imported, the data is there in the csv but it didn't get i...
[01:46:03] <ejegg>	 and they're not fishy-looking utm_ values with SQL statements in them I guess?
[01:46:52] <ejegg>	 whew, ok, time for me to hang it up for the night
[01:46:58] <cstone>	 nope
[01:47:00] <ejegg>	 have a good one all, see you tomorrow
[01:47:06] <cstone>	 night ejegg|away 
[01:49:25] <wikibugs>	 (03PS6) 10Wfan: Save contact external_identifier for venmo as venmo user name in Custom field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/968790 (https://phabricator.wikimedia.org/T303422)
[01:49:51] <wikibugs>	 (03PS5) 10Eileen: Add some more strings for deleting activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969972 (https://phabricator.wikimedia.org/T325123)
[02:06:19] <wikibugs>	 (03CR) 10Cstone: [C: 03+2] "Thanks for this, helps from being trapped with no log variable set" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970007 (owner: 10Ejegg)
[02:14:47] <wikibugs>	 (03CR) 10Cstone: [C: 03+2] "this also tricked me!!!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/969394 (owner: 10Ejegg)
[02:24:55] <wikibugs>	 (03Merged) 10jenkins-bot: Stop checking for FRUP working log dir [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970007 (owner: 10Ejegg)
[02:24:57] <wikibugs>	 (03Merged) 10jenkins-bot: Drop trailing space on missing method message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/969394 (owner: 10Ejegg)
[02:42:02] <wikibugs>	 (03PS6) 10Eileen: Add some more strings for deleting activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969972 (https://phabricator.wikimedia.org/T325123)
[02:51:51] <dwisehaupt>	 eileen: i'm back if you needed more review.
[02:54:32] <dwisehaupt>	 that's quite a shift
[03:10:24] <eileen>	 dwisehaupt: you mean in the amount of code strings?
[03:10:58] <wikibugs>	 (03PS7) 10Eileen: Add some more strings for deleting activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969972 (https://phabricator.wikimedia.org/T325123)
[03:14:34] <wikibugs>	 (03PS8) 10Eileen: Add some more strings for deleting activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969972 (https://phabricator.wikimedia.org/T325123)
[03:14:46] <eileen>	 I've been trying to find the common strings
[03:17:09] <eileen>	 realistically we don't really email non-automated messages in non-English to speak of
[03:22:01] <eileen>	 dwisehaupt: I have to leave soon for kids prize giving - so if you don't feel you can review we should leave for tomorrow
[03:32:56] <wikibugs>	 (03PS9) 10Eileen: Add some more strings for deleting activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969972 (https://phabricator.wikimedia.org/T325123)
[03:33:48] <eileen>	 ok - I'm not gonna add more - the remaining ones might clean up a couple of hundred k rows more but I think that's probably not worth pursuing
[03:44:06] <dwisehaupt>	 cool. yeah, i think it's best for someone to review tomorrow.
[03:44:15] <dwisehaupt>	 time to collect the kid
[03:45:49] <eileen>	 ok - sending EOD
[03:48:03] <wikibugs>	 (03PS10) 10Eileen: Add some more strings for deleting activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969972 (https://phabricator.wikimedia.org/T325123)
[06:27:39] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/970069 (owner: 10L10n-bot)
[09:02:28] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Enable monthly convert on Apple and Google payment methods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/970271 (https://phabricator.wikimedia.org/T346841)
[09:04:12] <damilare>	 ^^ do we do anything else to specify countries for specific payment method. re: https://phabricator.wikimedia.org/T346841#9211656
[09:05:45] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Patch-For-Review: Enable Monthly Convert for Apple Pay - https://phabricator.wikimedia.org/T346840 (10Damilare) a:03Damilare
[09:06:02] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Patch-For-Review: Enable Monthly Convert for Apple Pay - https://phabricator.wikimedia.org/T346840 (10Damilare) Related patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/970271/
[09:06:06] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Patch-For-Review: Enable Monthly Convert for Gpay - https://phabricator.wikimedia.org/T346841 (10Damilare) a:03Damilare
[09:09:08] <wikibugs>	 (03PS3) 10Damilare Adedoyin: Add wmf_civicrm_remove_recurring_token to handle recurring token delete from donation queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/967975 (https://phabricator.wikimedia.org/T347606) (owner: 10Wfan)
[09:09:25] <wikibugs>	 (03PS11) 10Damilare Adedoyin: Add api to remove recuring payment token then delete customer from venmo vault for one-time donor [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963853 (https://phabricator.wikimedia.org/T347606) (owner: 10Wfan)
[09:09:32] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Add wmf_civicrm_remove_recurring_token to handle recurring token delete from donation queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/967975 (https://phabricator.wikimedia.org/T347606) (owner: 10Wfan)
[09:09:55] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Add api to remove recuring payment token then delete customer from venmo vault for one-time donor [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963853 (https://phabricator.wikimedia.org/T347606) (owner: 10Wfan)
[09:26:30] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C: 04-1] "Finally got CI to run on this patch by fixing the cyclic dependency between the Civi patch and DI patch. The CI run showed some potential " [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963853 (https://phabricator.wikimedia.org/T347606) (owner: 10Wfan)
[09:27:03] <wikibugs>	 (03CR) 10Damilare Adedoyin: "rechceck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/963970 (https://phabricator.wikimedia.org/T347606) (owner: 10Wfan)
[09:28:22] <wikibugs>	 (03CR) 10Damilare Adedoyin: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/963970 (https://phabricator.wikimedia.org/T347606) (owner: 10Wfan)
[13:01:27] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage, 10donate.wikimedia.org, 10MW-1.42-notes (1.42.0-wmf.3; 2023-10-31): donate.wikimedia.org landing pages don't have descriptions in search engine results - https://phabricator.wikimedia.org/T254808 (10MSui...
[13:21:36] <wikibugs>	 (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/970069 (owner: 10L10n-bot)
[13:28:22] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage, 10donate.wikimedia.org, 10MW-1.42-notes (1.42.0-wmf.3; 2023-10-31): donate.wikimedia.org landing pages don't have descriptions in search engine results - https://phabricator.wikimedia.org/T254808 (10Ejeg...
[13:33:01] <ejegg>	 fr-tech I'd like to deploy the change to move the External_Identifiers table
[13:33:16] <ejegg>	 damilare: the frup run should be done by now, right?
[13:33:31] <ejegg>	 I'm thinking I can deploy that without stopping queues
[13:39:15] <wikibugs>	 (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970380
[13:39:18] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970380 (owner: 10Ejegg)
[13:41:13] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970380 (owner: 10Ejegg)
[13:42:35] <damilare>	 yep ejegg, the run must have finished around midnight
[13:44:41] <ejegg>	 thanks!
[13:49:01] <ejegg>	 !log fundraising civicrm upgraded from 71d26d3b to 5862a3fc
[13:49:05] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[13:51:30] <ejegg>	 ok, looks like it got all the data over there
[13:52:16] <ejegg>	 I'll just write a cleanup patch to drop the old tables
[13:56:16] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "It's working great for me. On the prospect tab, I see the new fields and updated old fields. I stepped through the code, which took about " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/966942 (https://phabricator.wikimedia.org/T336890) (owner: 10Eileen)
[14:13:00] <wikibugs>	 (03Merged) 10jenkins-bot: Add new DataAxle fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/966942 (https://phabricator.wikimedia.org/T336890) (owner: 10Eileen)
[14:19:01] <wikibugs>	 (03PS1) 10Ejegg: Clean up unused civi tables [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970385
[14:37:39] <wikibugs>	 (03CR) 10Jgleeson: [C: 04-1] "Everything looks good. Just some small tidy-up requests." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969972 (https://phabricator.wikimedia.org/T325123) (owner: 10Eileen)
[14:42:35] <ejegg>	 ok, so the civi admin user locally has no matching drupal user?
[14:42:43] <ejegg>	 {"error_message":"FATAL: Cannot login. No matching user is available.","is_error":1}
[14:43:00] <ejegg>	 I wonder why that wasn't a problem for the API3 proxied calls
[14:43:17] <ejegg>	 aha, it IS a problem now
[14:43:27] <ejegg>	 so... ok, let's fix that
[14:47:53] <wikibugs>	 (03CR) 10Jgleeson: [C: 04-1] "Can we upgrade the civiproxy image? I don't think it's a good idea to point the civiproxy app to an image with Mediawiki in its name if it" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/970006 (owner: 10Ejegg)
[14:55:08] <wikibugs>	 (03CR) 10Ejegg: "We can indeed upgrade it jgleeson (see https://gitlab.wikimedia.org/repos/releng/dev-images/-/merge_requests/53)! And then we can pull the" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/970006 (owner: 10Ejegg)
[14:55:27] <ejegg>	 jgleeson: hehe, that was my first thought too
[14:55:40] <ejegg>	 so I think we're about ready to clean up a whole lot of unused dev-images
[14:56:21] <ejegg>	 after civiproxy we'll only have rsyslog and the queues on buster
[14:56:48] <ejegg>	 and neither of them on our own special buster image
[14:57:41] <jgleeson>	 back soon
[15:05:12] <ejegg>	 fr-tech can anyone check to see if they have a row in civicrm_uf_match for the admin@example.com user?
[15:15:43] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations: Get CiviProxy -> CiviCRM auth working in production for API4 calls - https://phabricator.wikimedia.org/T349946 (10Ejegg) a:03Ejegg
[15:18:02] <ejegg>	 I guess it's time for a local rebuild
[15:20:23] <ejegg>	 this line should create the uf_match link: drush -y civicrm-sync-users-contacts
[15:20:39] <ejegg>	 and it seems to create the civi contact just fine
[15:21:16] <ejegg>	 but when i run it again it creates a second civi contact with that same email
[15:54:58] <jgleeson>	 I see admin@example.com ejegg 
[15:56:14] <wikibugs>	 (03CR) 10Jgleeson: [C: 04-1] Use bullseye for civiproxy (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/970006 (owner: 10Ejegg)
[15:56:35] <jgleeson>	 damn I missed the halloween social 
[15:56:58] <jgleeson>	 daylight confusion time
[15:58:20] <dwisehaupt>	 definitely confusion for sure.
[16:02:01] <wikibugs>	 (03PS2) 10Ejegg: Clean up unused civi tables [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970385 (https://phabricator.wikimedia.org/T349158)
[16:02:34] <wikibugs>	 (03PS3) 10Ejegg: Clean up unused civi tables [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970385 (https://phabricator.wikimedia.org/T349158)
[16:03:25] <wikibugs>	 (03PS7) 10Ejegg: Save venmo user name in Custom field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/968790 (https://phabricator.wikimedia.org/T303422) (owner: 10Wfan)
[16:05:20] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Save venmo user name in Custom field (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/968790 (https://phabricator.wikimedia.org/T303422) (owner: 10Wfan)
[16:23:06] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "This looks good! thanks" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/969398 (owner: 10Ejegg)
[16:25:26] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/969394 (owner: 10Ejegg)
[16:27:21] <wikibugs>	 (03Merged) 10jenkins-bot: Save venmo user name in Custom field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/968790 (https://phabricator.wikimedia.org/T303422) (owner: 10Wfan)
[16:27:23] <wikibugs>	 (03Merged) 10jenkins-bot: Add normalized property for auto-rescue scheduled [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/969398 (owner: 10Ejegg)
[16:28:58] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "Makes sense!" [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/969222 (owner: 10Ejegg)
[16:30:51] <ejegg>	 thanks jgleeson 
[16:33:21] <ejegg>	 i'm working on a followup to add site_key which i think is the last thing we need to get that operational in production
[16:40:20] <ejegg>	 spooopy
[16:44:01] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops, 10Patch-For-Review: Set up Community CiviCRM instance. - https://phabricator.wikimedia.org/T343486 (10Dwisehaupt) The temporary home for this has been spun up in the cloud VPS and qgil has been given access to start prep work. Once the production VPS is spun up...
[16:49:04] <wikibugs>	 (03PS1) 10Ejegg: Pass through site_key in config copy of civiproxy [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/970411 (https://phabricator.wikimedia.org/T349946)
[16:49:20] <wfan>	 Thanks damilare and ejegg for the review :)
[16:49:30] <ejegg>	 sure thing!
[16:49:41] <ejegg>	 I'm going to deploy the crm-side patch now to make that extra column
[16:50:28] <ejegg>	 wfan oh, do you want to look at this cleanup patch before I do that deploy? https://gerrit.wikimedia.org/r/970385
[16:51:42] <wfan>	 sure
[16:52:05] <damilare>	 np wfan
[16:52:44] <wikibugs>	 (03CR) 10Wfan: [C: 03+2] Clean up unused civi tables [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970385 (https://phabricator.wikimedia.org/T349158) (owner: 10Ejegg)
[16:53:03] <wfan>	 looks good, thanks ejegg for the table clean up
[16:54:35] <ejegg>	 :)
[17:09:57] <wikibugs>	 (03Merged) 10jenkins-bot: Clean up unused civi tables [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970385 (https://phabricator.wikimedia.org/T349158) (owner: 10Ejegg)
[17:13:46] <damilare>	 cstone the missing contribution tracking rows could be due to the subscription signups. This process doesn't create a contribution tracking field.drupal/sites/all/modules/queue2civicrm/recurring/RecurringQueueConsumer.php:393
[17:14:08] <cstone>	 it was interesting cause in the recurring file the rest all did it fine though?
[17:14:29] <damilare>	 fundraiseup creates a new recurring without attaching to a contribution on monthly convert
[17:14:47] <cstone>	 hmm
[17:15:16] <damilare>	 so some contributions would have a subscr_id that match with a new recurring row
[17:15:48] <damilare>	 and the recurring row from a mc may not have a contribution, so no ct row
[17:16:15] <cstone>	 but why would the first 17 be mc only it seemed suspicous that it was just the last 17 imported, but I'll check the data
[17:16:35] <damilare>	 yh that part is weird
[17:17:25] <damilare>	 please can you share the subscr_id of a recur row with ct and one without ct?
[17:17:54] <cstone>	 is subscr_id our id or frups id?
[17:19:21] <damilare>	 ours
[17:19:42] <cstone>	 want to just meet after this call ends damilare ?
[17:19:50] <damilare>	 sure
[17:21:43] <damilare>	 sorr trxn_id not subscr_id
[17:27:25] <damilare>	 cstone should we use the tech talk link?
[17:27:28] <cstone>	 haha your messages arent time travelled and mine are
[17:27:29] <cstone>	 sure
[17:36:09] <ejegg>	 there shouldn't be any MC from FRUP yet, right? So far they weren't going to enable that
[17:41:56] <cstone>	 yeah these ones look to be one time donations
[17:42:16] <cstone>	 im going to make a mini audit csv with one of the affected and rerun it and see if it goes in properly, and if so delete the original bad donation
[17:42:30] <cstone>	 er not one time donations
[17:42:33] <cstone>	 non mc recurring
[17:54:38] <cstone>	 noo frup not behaving locally again why
[17:55:35] <cstone>	 oh i know
[18:03:25] <wikibugs>	 (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970423
[18:03:49] <ejegg>	 ok, i /think/ that's all the things we need to deploy before regenerating triggers ^^^
[18:04:26] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970423 (owner: 10Ejegg)
[18:05:28] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970423 (owner: 10Ejegg)
[18:10:33] <ejegg>	 !log fundraising civicrm upgraded from 5862a3fc to a458c2bb
[18:10:36] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[18:17:47] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: Snoozed donor received fundraising email - https://phabricator.wikimedia.org/T349277 (10AKanji-WMF) p:05Triage→03High
[18:20:40] <ejegg>	 dang, this syncCustomFields api call has been hanging for a while up on prod
[18:20:53] <ejegg>	 no failmails yet though
[18:21:25] <ejegg>	 ahh, but of course it'll be a long call... it's a bunch of alters to the wmf_donor table
[18:21:40] <ejegg>	 ok, I'mma bring queues down
[18:21:50] <ejegg>	 sorry I didn't think about that first
[18:23:40] <ejegg>	 hmm, that 'disable' script should add an extra space after the # to make the yaml linter happy
[18:24:17] <ejegg>	 !log disabled fundraising scheduled jobs for table alter
[18:24:20] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[18:26:23] <ejegg>	 ok, that's the table alter done
[18:26:32] <ejegg>	 let's drop those obsolete ones
[18:27:05] <ejegg>	 done
[18:28:43] <ejegg>	 ah not the wmf_donor table, the prospect table
[18:29:22] <ejegg>	 ok, those look like they exist fine
[18:30:25] <ejegg>	 right, so let's dump triggers
[18:33:09] <ejegg>	 drush @wmff cvapi -v -v System.flush triggers=1 I think?
[18:38:34] <ejegg>	 looks pretty good, got those fields to be removed out of the triggers as far as I can tell
[18:39:03] <wikibugs>	 (03PS1) 10Ejegg: Update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970429
[18:39:47] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q2 maintenance window - https://phabricator.wikimedia.org/T337579 (10Ejegg)
[18:40:05] <cstone>	 fr-tech tech-talk?
[18:40:16] <ejegg>	 ooh yep
[18:40:19] <ejegg>	 sorry cstone 
[18:47:26] <wikibugs>	 (03CR) 10Ejegg: [V: 03+2] URLEncode api_key for API4 [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/969222 (owner: 10Ejegg)
[18:50:15] <ejegg>	 !log restarted fundraising scheduled jobs
[18:50:18] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[19:34:54] <wikibugs>	 (03CR) 10Eileen: "ejegg - this has a double copy of them - not sure whether I normally do something different or delete the repeat..." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970429 (owner: 10Ejegg)
[19:36:45] <wikibugs>	 (03CR) 10Eileen: "jgleeson - the info really is for info - ie if running via batch is too sluggish we can run using info to get the sql to run another way (" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969972 (https://phabricator.wikimedia.org/T325123) (owner: 10Eileen)
[19:40:48] <wikibugs>	 (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/970434
[19:41:06] <wikibugs>	 (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/970434 (owner: 10Eileen)
[19:41:33] <wikibugs>	 (03Abandoned) 10Eileen: wip [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969983 (owner: 10Eileen)
[19:41:38] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/970434 (owner: 10Eileen)
[19:55:37] <wikibugs>	 (03PS2) 10Ejegg: Update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970429
[19:59:25] <wikibugs>	 (03CR) 10Eileen: [C: 03+2] Update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970429 (owner: 10Ejegg)
[20:00:06] <eileen>	 jgleeson: do you want to check in on https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/969972
[20:03:49] <wikibugs>	 (03CR) 10Eileen: Add some more strings for deleting activities (035 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969972 (https://phabricator.wikimedia.org/T325123) (owner: 10Eileen)
[20:07:54] <jgleeson>	 eileen: do you mean this thing is never going to be run again?
[20:08:58] <eileen>	 jgleeson: it might get another round of the command running - but we added a new activity_type_id for thank you emails - so in future we will just delete by activity type (once that has aged in)
[20:10:58] <jgleeson>	 hmm
[20:13:29] <eileen>	 we actually phased in the activity type id in feb - so if we opened up the dates we could probably clean these out right through to then & then dump most of those strings
[20:14:34] <jgleeson>	 I have a feelings on this
[20:14:40] <wikibugs>	 (03Merged) 10jenkins-bot: Update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970429 (owner: 10Ejegg)
[20:15:15] <jgleeson>	 firstly, I feel like we should be prioritising code readability over output to logs, albeit it's a bit more work
[20:15:57] <jgleeson>	 second, the SQL queries can be really easily extracted out to make the whole thing much easier to follow
[20:16:16] <eileen>	 jgleeson: ok - well I'll extract those 2 functions for you for that - but the readability of the output is actually the point of that code - cos it allows us to capture the sql that is being run - so dallas can run them a different way if need be for performance 
[20:17:01] <jgleeson>	 third, even if we think it will never be used again, it's still getting committed to our code base so we still have to maintain it until it's deleted so I don't think that gives us a pass on holding it to the same standard as our other code
[20:17:46] <jgleeson>	 fourth, sorry :)
[20:17:59] <wikibugs>	 (03PS11) 10Eileen: Add some more strings for deleting activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969972 (https://phabricator.wikimedia.org/T325123)
[20:18:30] <eileen>	 jgleeson: ok - I've extracted them to separate functions
[20:19:21] <wikibugs>	 (03PS12) 10Eileen: Add some more strings for deleting activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969972 (https://phabricator.wikimedia.org/T325123)
[20:22:43] <jgleeson>	 eileen: so having this AND part of the string gives us a visual benefit in the logs? is that what you mean https://gerrit.wikimedia.org/g/wikimedia/fundraising/crm/+/refs/changes/72/969972/12/drupal/sites/default/civicrm/extensions/wmf-civicrm/Civi/Api4/Action/WMFDataManagement/ArchiveThankYou.php#331
[20:23:28] <eileen>	 jgleeson: you mean the carriage return between SQL clauses not the AND don't you?
[20:24:35] <eileen>	 without the carriage return the line is so long it can't be copied from the console so the sql is broken
[20:24:49] <jgleeson>	 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/969972/comments/ebc15082_b9ffa487
[20:25:53] <jgleeson>	 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/969972/10..12/drupal/sites/default/civicrm/extensions/wmf-civicrm/Civi/Api4/Action/WMFDataManagement/ArchiveThankYou.php#b84
[20:26:54] <jgleeson>	 oh I see what you mean
[20:27:06] <jgleeson>	 you're using a newline 
[20:27:13] <jgleeson>	 not a '\r'
[20:27:49] <eileen>	 yeah - the quotes are single not double - I think the difference between a 
[20:27:49] <eileen>	  
[20:27:49] <eileen>	 in a single vs "\n" is subjective 
[20:29:05] <jgleeson>	 so would this be the same implode('\r AND ', $excludeSubjects)
[20:29:29] <jgleeson>	 or is that treated literally 
[20:29:41] <jgleeson>	 could we use double quotes if so?
[20:31:06] <eileen>	 jgleeson: yeah - I mean from my pov I'm very slightly in preference of the single quote approach but they are much the same. I can change if you want but let me finish my current debug first
[20:33:52] <jgleeson>	 I think \n is the one we want also right?
[20:34:38] <jgleeson>	 or did you specifically want a carriage return over a new line
[20:35:07] <eileen>	 jgleeson: well - that's subjective - what is there works well in the output but I can change it
[20:36:14] <jgleeson>	 80% of the tidy up was extracting out the SQL. I can live with the generated AND conditions not being on a single line to improve the readability of the code if you'd rather leave it
[20:36:40] <eileen>	 jgleeson: yeah probably - 
[20:38:02] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "thanks for the updates" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969972 (https://phabricator.wikimedia.org/T325123) (owner: 10Eileen)
[20:39:35] <eileen>	 thanks jgleeson 
[20:41:17] <wikibugs>	 (03PS1) 10Eileen: Add upgrade to remove the wmf-donor fields to go [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970440 (https://phabricator.wikimedia.org/T347724)
[20:43:50] <wikibugs>	 (03PS2) 10Eileen: Add upgrade to remove the wmf-donor fields to go [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970440 (https://phabricator.wikimedia.org/T347724)
[20:44:09] <wikibugs>	 (03PS1) 10Eileen: Notice fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970441
[20:44:16] <wikibugs>	 (03PS1) 10Ejegg: Fix WS inconsistencies [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/970442
[20:44:18] <wikibugs>	 (03PS1) 10Ejegg: Pass site key through to CiviCRM [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/970443 (https://phabricator.wikimedia.org/T349946)
[20:45:53] <wikibugs>	 (03PS2) 10Ejegg: Pass through site_key in config copy of civiproxy [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/970411 (https://phabricator.wikimedia.org/T349946)
[20:50:41] <wikibugs>	 (03PS3) 10Eileen: Add upgrade to remove the wmf-donor fields to go [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970440 (https://phabricator.wikimedia.org/T347724)
[20:50:43] <wikibugs>	 (03PS2) 10Eileen: Notice fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970441
[20:52:19] <wikibugs>	 (03PS4) 10Ejegg: Add upgrade to remove the wmf-donor fields to go [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970440 (https://phabricator.wikimedia.org/T347724) (owner: 10Eileen)
[20:52:21] <wikibugs>	 (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970448
[20:52:33] <wikibugs>	 (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970448 (owner: 10Eileen)
[20:52:44] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Add upgrade to remove the wmf-donor fields to go [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970440 (https://phabricator.wikimedia.org/T347724) (owner: 10Eileen)
[20:52:51] <wikibugs>	 (03PS3) 10Ejegg: Notice fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970441 (owner: 10Eileen)
[20:53:04] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] "Thanks! That was bugging me." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970441 (owner: 10Eileen)
[20:53:26] <ejegg>	 gonna head out eileen 
[20:53:54] <ejegg>	 the two civiproxy patches are up : https://gerrit.wikimedia.org/r/970443 and https://gerrit.wikimedia.org/r/970411 
[20:54:03] <wikibugs>	 (03Merged) 10jenkins-bot: Add some more strings for deleting activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969972 (https://phabricator.wikimedia.org/T325123) (owner: 10Eileen)
[20:54:06] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970448 (owner: 10Eileen)
[21:07:48] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Fundraiseup new recurring missing utm_* fields in Contribution Tracking table - https://phabricator.wikimedia.org/T350063 (10Cstone) Okay I deleted the 17 donations with missing data then reimported them, they all have contribution tracking rows now.  The...
[21:08:31] <wikibugs>	 (03Merged) 10jenkins-bot: Add upgrade to remove the wmf-donor fields to go [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970440 (https://phabricator.wikimedia.org/T347724) (owner: 10Eileen)
[21:08:33] <wikibugs>	 (03Merged) 10jenkins-bot: Notice fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970441 (owner: 10Eileen)
[21:16:11] <eileen>	 !log civicrm upgraded from a458c2bb to 86a08564
[21:16:14] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[21:16:21] <eileen>	 dwisehaupt: I just pushed out the triggers to reload
[21:16:32] <eileen>	 once you have reloaded them I'm gonna drop some fields
[21:17:01] <dwisehaupt>	 ok. starting the update dance.
[21:17:19] <wikibugs>	 (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970450
[21:17:30] <wikibugs>	 (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970450 (owner: 10Eileen)
[21:17:44] <eileen>	 cool dwisehaupt 
[21:18:19] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970450 (owner: 10Eileen)
[21:19:04] <dwisehaupt>	 hmmm... did the sql bits of that move somewhere? with my normal commands i'm only seeing 4 drush.inc files
[21:20:44] <wikibugs>	 (03PS12) 10Wfan: Add api to remove recuring payment token then delete customer from venmo vault for one-time donor [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963853 (https://phabricator.wikimedia.org/T347606)
[21:21:09] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Add api to remove recuring payment token then delete customer from venmo vault for one-time donor [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963853 (https://phabricator.wikimedia.org/T347606) (owner: 10Wfan)
[21:22:09] <eileen>	 dwisehaupt: this is what was merged - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/970448- at some point it moved I think - not sure when
[21:22:46] <dwisehaupt>	 ok. looking and adjusting docs as needed.
[21:23:24] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Civi's preview of receipt: Recurring donations displayed as one-time - https://phabricator.wikimedia.org/T342081 (10Eileenmcnaughton) @KHancock99 ok to close?
[21:26:24] <wikibugs>	 (03PS13) 10Wfan: Add api to remove recuring payment token then delete customer from venmo vault for one-time donor [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963853 (https://phabricator.wikimedia.org/T347606)
[21:26:57] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Add api to remove recuring payment token then delete customer from venmo vault for one-time donor [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963853 (https://phabricator.wikimedia.org/T347606) (owner: 10Wfan)
[21:28:29] <wikibugs>	 (03PS14) 10Wfan: Add api to remove recuring payment token then delete customer from venmo vault for one-time donor [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963853 (https://phabricator.wikimedia.org/T347606)
[21:28:57] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Add api to remove recuring payment token then delete customer from venmo vault for one-time donor [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963853 (https://phabricator.wikimedia.org/T347606) (owner: 10Wfan)
[21:29:53] <wikibugs>	 (03PS15) 10Wfan: Add api to remove recuring payment token then delete customer from venmo vault for one-time donor [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963853 (https://phabricator.wikimedia.org/T347606)
[21:31:18] <dwisehaupt>	 ok. sorry for the delay, quite a diff to compare. 
[21:31:23] <dwisehaupt>	 trigger diff looks good.
[21:31:44] <dwisehaupt>	 anything you need to test before i reenable replication on the 2 hosts that were staged in case of an isue?
[21:32:08] <icinga-wm>	 PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_mysql
[21:32:58] <eileen>	 trigger part should be OK - but once loaded I'm gonna drop some fields that were previously refered to in the trigger - do you want me to do that first? Then I would check we can save a donation with that part done
[21:33:14] <icinga-wm>	 PROBLEM - check_mysql on frdb1004 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql
[21:33:24] <dwisehaupt>	 sure go ahead. i'll be just in case. i'll ack those alerts
[21:34:09] <icinga-wm>	 ACKNOWLEDGEMENT - check_mysql on frdb1004 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) Dwisehaupt known for db work. https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql
[21:34:09] <icinga-wm>	 ACKNOWLEDGEMENT - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) Dwisehaupt known for db work. https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_mysql
[21:34:25] <eileen>	 !log civicrm upgraded from 86a08564 to 31d53b57
[21:34:27] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[21:36:01] <eileen>	 the upgrade is running
[21:36:15] <eileen>	 it ran
[21:38:28] <eileen>	 dwisehaupt: just imported 6 donations so seems all good
[21:38:44] <dwisehaupt>	 ok. sounds good. i'll restart replication.
[21:38:47] <eileen>	 ok
[21:39:20] <dwisehaupt>	 all caught up.
[21:42:10] <icinga-wm>	 RECOVERY - check_mysql on frdb2001 is OK: Uptime: 1741324 Threads: 6 Questions: 375726483 Slow queries: 870 Opens: 3770 Open tables: 1087 Queries per second avg: 215.770 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_mysql
[21:43:14] <icinga-wm>	 RECOVERY - check_mysql on frdb1004 is OK: Uptime: 1729462 Threads: 5 Questions: 373066546 Slow queries: 893 Opens: 3765 Open tables: 1093 Queries per second avg: 215.712 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql
[21:47:18] <wikibugs>	 (03PS1) 10Eileen: Run the recurring gift financial type fix once more [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970455 (https://phabricator.wikimedia.org/T345919)
[21:48:07] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog: Bug with new Recurring Financial Types - https://phabricator.wikimedia.org/T345919 (10Eileenmcnaughton) Pushed up a patch to run the upgrade once more as 1550 still to do (seems like no new ones have happened since 26 Oct so hopefully this will be the en...
[21:53:27] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Do a prune on detail data for activity records of type thank you - https://phabricator.wikimedia.org/T325123 (10Eileenmcnaughton) Here is the compiled criteria to delete from civicrm_activity & log_civicrm_activity  We could prob...
[21:56:40] <dwisehaupt>	 eileen: is that query ready to run? if so i can fire that up. unless we want to try the p-c job route knowing it will go slower.
[21:57:16] <eileen>	 dwisehaupt: either way is fine - I have tried to kick off a batch of 50k via process control but it is slow
[21:57:34] <eileen>	 you saw the update in the phab?
[21:57:57] <dwisehaupt>	 yeah.
[21:58:20] <dwisehaupt>	 i can just fire it off in a screen session and then do a table compaction after.
[22:00:04] <eileen>	 oh sure - it should be from civicrm_activity & log_civicrm_activity the removal. just make sure my running query ends first (or you can kill it). 
[22:00:22] <dwisehaupt>	 i can wait.
[22:00:43] <dwisehaupt>	 it says it's "starting cleanup" :)
[22:00:53] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q2 maintenance window - https://phabricator.wikimedia.org/T337579 (10Eileenmcnaughton)
[22:03:20] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q2 maintenance window - https://phabricator.wikimedia.org/T337579 (10Eileenmcnaughton)
[22:03:39] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q2 maintenance window - https://phabricator.wikimedia.org/T337579 (10Eileenmcnaughton)
[22:04:19] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q2 maintenance window - https://phabricator.wikimedia.org/T337579 (10Eileenmcnaughton)
[22:04:57] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q2 maintenance window - https://phabricator.wikimedia.org/T337579 (10Eileenmcnaughton)
[22:07:01] <eileen>	 dwisehaupt: I mentioned in the phab - we rolled out the new activity type id in Feb - so if we want to remove up to March then going forwards we could probably make it run as part of ongoing clean up as the query should be more efficient
[22:10:50] <dwisehaupt>	 i'm fine removing up to where ever you want. as long as we are ok with the data going.
[22:13:52] <eileen>	 yeah - let's go for the end of Feb this year - I think a year was always conservative & it will simplify in future
[22:17:03] <dwisehaupt>	 ok. i'll update.
[22:18:42] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Do a prune on detail data for activity records of type thank you - https://phabricator.wikimedia.org/T325123 (10Dwisehaupt) Going to run the query directly but using the date of `AND activity_date_time < "2023-02-28"`
[22:20:32] <dwisehaupt>	 alright. looks like it's moved on to your log table portions.
[22:22:44] <dwisehaupt>	 debating holding the query until the log table updates are done.
[22:28:13] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: "Typed card number does not match card brand" errors - https://phabricator.wikimedia.org/T349600 (10Cstone) @RKumar_WMF did you send over any of the bin numbers mentioned in the top of the ticket? There's at least 5402. We don't save...
[22:28:27] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: "Typed card number does not match card brand" errors - https://phabricator.wikimedia.org/T349600 (10Cstone) a:03Cstone
[22:28:48] <dwisehaupt>	 eileen: ok. going to start the query.
[22:28:55] <eileen>	  cool
[22:29:17] <dwisehaupt>	 this is gonna hammer the db for a while.
[22:30:21] <dwisehaupt>	 ok. it's running good and doing the needful. the dog is staring daggers at me so i'm going to get him outside.
[22:30:25] <dwisehaupt>	 back in a little.
[22:39:26] <wikibugs>	 10Fundraising Tech - Chaos Crew: Adyen checkout/v68/paymentMethods returning 404 for iOS app payment sessions - https://phabricator.wikimedia.org/T349945 (10Cstone) a:03Cstone
[22:40:12] <wikibugs>	 (03PS1) 10Jgleeson: Contribution Import Refactor: remove old code and group recurring behaviour [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970458 (https://phabricator.wikimedia.org/T240581)
[22:40:38] <wikibugs>	 (03PS16) 10Wfan: Add api to remove recuring payment token then delete customer from venmo vault for one-time donor [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963853 (https://phabricator.wikimedia.org/T347606)
[22:41:32] <wikibugs>	 (03PS2) 10Jgleeson: Contribution Import Refactor: remove old code and group recurring behaviour [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970458 (https://phabricator.wikimedia.org/T240581)
[22:42:03] <wikibugs>	 (03CR) 10Wfan: Add api to remove recuring payment token then delete customer from venmo vault for one-time donor (033 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/963853 (https://phabricator.wikimedia.org/T347606) (owner: 10Wfan)
[22:43:13] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Do a prune on detail data for activity records of type thank you - https://phabricator.wikimedia.org/T325123 (10Eileenmcnaughton) Pre-cleanup query  select YEAR(activity_date_time),IF(ISNULL(details),'no text', 'has text') as tex...
[22:49:42] <wikibugs>	 (03PS4) 10Wfan: Add wmf_civicrm_remove_recurring_token to handle recurring token delete from donation queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/967975 (https://phabricator.wikimedia.org/T347606)
[22:55:03] <wikibugs>	 (03PS1) 10Jgleeson: Contribution Import Refactor: inline calls to ImportStatsCollector::getInstance() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970460 (https://phabricator.wikimedia.org/T240581)
[22:56:40] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Contribution Import Refactor: remove old code and group recurring behaviour [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970458 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson)
[23:02:37] <dwisehaupt>	 ok. looks like there are a lot of queries backed up behind mine.
[23:08:40] <eileen>	 :-)
[23:10:09] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Contribution Import Refactor: inline calls to ImportStatsCollector::getInstance() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970460 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson)
[23:10:23] <icinga-wm>	 PROBLEM - check_load on frdb1005 is CRITICAL: CRITICAL - load average: 24.05, 25.18, 17.85 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1005&service=check_load
[23:15:51] <wikibugs>	 (03PS3) 10Jgleeson: Contribution Import Refactor: remove old code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970458 (https://phabricator.wikimedia.org/T240581)
[23:15:55] <wikibugs>	 (03PS2) 10Jgleeson: Contribution Import Refactor: inline calls to ImportStatsCollector::getInstance() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970460 (https://phabricator.wikimedia.org/T240581)
[23:15:59] <wikibugs>	 (03PS1) 10Jgleeson: Contribution Import Refactor: Move main timer naming to fn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970462 (https://phabricator.wikimedia.org/T240581)
[23:16:50] <dwisehaupt>	 ^^^ that load alert is from some backed up queries.
[23:17:12] <dwisehaupt>	 it should be normalizing now.
[23:18:24] <eileen>	 cool
[23:20:29] <dwisehaupt>	 the big query is still rolling right along.
[23:28:13] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: endowment fiscal & calendar year totals are transposed - https://phabricator.wikimedia.org/T349160 (10Eileenmcnaughton) So far the only contact I found with the incorrect value for endowment total 2023 is https://civicr...
[23:29:59] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Contribution Import Refactor: remove old code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970458 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson)
[23:40:53] <wikibugs>	 (03CR) 10Eileen: Contribution Import Refactor: Move main timer naming to fn (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970462 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson)
[23:45:22] <wikibugs>	 (03PS4) 10Jgleeson: Contribution Import Refactor: remove old code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970458 (https://phabricator.wikimedia.org/T240581)
[23:45:30] <wikibugs>	 (03PS3) 10Jgleeson: Contribution Import Refactor: inline calls to ImportStatsCollector::getInstance() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970460 (https://phabricator.wikimedia.org/T240581)
[23:45:36] <wikibugs>	 (03PS2) 10Jgleeson: Contribution Import Refactor: Move main timer naming to fn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970462 (https://phabricator.wikimedia.org/T240581)
[23:45:50] <dwisehaupt>	 eileen: is the query on the maint week task the only thing that is needed for the tax_amount portion of the task?
[23:46:38] <eileen>	 yep - it's just setting the values in tax_amount to 0 rather than NULL on those 2 tables
[23:46:48] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Civi's preview of receipt: Recurring donations displayed as one-time - https://phabricator.wikimedia.org/T342081 (10KHancock99) Sorry I missed that first ping, @Eileenmcnaughton. Thank you for your fix. Good to wrap here.
[23:47:07] <dwisehaupt>	 ok. i'll run that either later tonight or tomorrow depending on when this other query wraps up.
[23:54:11] <eileen>	 cool
[23:55:18] <icinga-wm>	 RECOVERY - check_load on frdb1005 is OK: OK - load average: 3.15, 3.92, 4.88 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1005&service=check_load
[23:59:48] <wikibugs>	 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: endowment fiscal & calendar year totals are transposed - https://phabricator.wikimedia.org/T349160 (10Eileenmcnaughton) I dug into this & really only found one incorrect one with this query - which I fixed manually - I...