[00:00:07] ejegg: so staging has 5.68 on it [00:02:38] oops, we have one place in the ty batch job still looking for the old drush var thank_you_days [00:02:47] which we've torn out of the UI [00:04:21] (03CR) 10CI reject: [V: 04-1] Remove upgrade to mailing_event_queue table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970479 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [00:04:49] (03CR) 10CI reject: [V: 04-1] CiviCRM 5.68-rc (stock) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970478 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [00:06:25] ejegg: those fails should sort themselves out with the last patch in the queue [00:07:36] (03PS1) 10Ejegg: Use thank_you_days from Civi setting not drupal var [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970880 [00:09:12] oops, syntax error [00:10:16] (03PS2) 10Ejegg: Use thank_you_days from Civi setting not drupal var [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970880 [00:12:12] (03PS1) 10Eileen: Extension update - rpow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970881 (https://phabricator.wikimedia.org/T350208) [00:12:16] oh hey, damaged message queue browser doesn't work locally [00:12:43] oh dang [00:12:47] just missing a connection string in settings though [00:12:53] nothing to do with 5.68 [00:13:08] i had sent a donation to the queue with an employer ID [00:13:32] but the employer list I have on local payments-wiki has some IDs that aren't actually existing organizations in local civi [00:13:56] anyway, just sent some failmail [00:14:02] (to the local mailcatcher) [00:16:11] PROBLEM - check_mysql on frdb1006 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 12876 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1006&service=check_mysql [00:16:11] PROBLEM - check_mysql on frdb2002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 12874 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2002&service=check_mysql [00:17:11] PROBLEM - check_mysql on frdb2001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 12932 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_mysql [00:18:17] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 12999 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [00:21:11] PROBLEM - check_mysql on frdb2002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 13175 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2002&service=check_mysql [00:21:13] PROBLEM - check_mysql on frdb1006 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 13176 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1006&service=check_mysql [00:22:34] (03PS1) 10Eileen: Extension update activity assignee [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970882 (https://phabricator.wikimedia.org/T350208) [00:22:53] ejegg: is it blocking or just whatever? [00:23:33] ejegg: could you do a test live dlocal donation when you get a chance? we deployed the remove astropay code earlier and I got fraud blocked on my test donation [00:24:08] oh odd [00:24:38] ejegg: ah I don't remember if it was working previously, so that's not a blocker [00:24:57] eileen: I can't load the contributions page of a contact though, so I'm just trying to understand that [00:25:05] can you load those fine on staging? [00:25:10] ejegg: hmm - checking [00:25:12] cstone: OK, sure [00:25:57] eileen: this is the error I see: [00:25:57] ejegg: the tab on the contact record? [00:26:12] TypeError: Argument 1 passed to Civi\Api4\Service\Spec\SpecGatherer::getSpec() must be of the type string, null given, called in /srv/civi-sites/wmff/drupal/sites/all/modules/civicrm/Civi/Api4/Service/Schema/Joinable/Joinable.php on line 312 in Civi\Api4\Service\Spec\SpecGatherer->getSpec() (line 46 of [00:26:17] /srv/civi-sites/wmff/drupal/sites/all/modules/civicrm/Civi/Api4/Service/Spec/SpecGatherer.php). [00:26:20] right eileen [00:26:34] hmm - I don't see it on staging [00:26:50] let me make sure I've got everything upgraded right [00:27:06] ie https://civicrm.frdev.wikimedia.org/civicrm/contact/view?reset=1&cid=28019671&selectedChild=contribute [00:27:23] hmm, maybe I need to clear more caches? [00:27:30] I ran the cvupdb [00:36:09] sorry, being distracted with kid stuff right nnow, but if it's loading on staging the problem has to be with something in my local db [00:36:23] it's a pretty recent rebuild - just yesterday [00:36:59] yeah - is there a fulller backtrace? (also extension.upgrade all run?) [00:37:56] 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q2 maintenance window - https://phabricator.wikimedia.org/T337579 (10Dwisehaupt) Tax amount queries complete: ` UPDATE civicrm_contribution SET tax_amount = 0 WHERE tax_amount IS NULL; Query OK, 60335508 rows aff... [00:39:13] 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q2 maintenance window - https://phabricator.wikimedia.org/T337579 (10Dwisehaupt) [00:41:05] (03PS1) 10Eileen: Extension update wmf-audit, exchange rates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970883 (https://phabricator.wikimedia.org/T350208) [00:44:14] ok, i've been able to debug into the spot where it passes a null in there [00:45:18] cool [00:47:27] weird, it's things with the price and membership tables [00:47:35] definitely nothing we customize locally [00:48:09] baseTable=civicrm_price_field_value, baseColumn=membership_type_id, targetTable=civicr_membership_type [00:48:24] and entity=null (which causes the exception) [00:48:56] So it's in an Api4SelectQuery [00:49:22] from deep inside ContributionRecur::getTemplateContribution() [00:50:42] so that's confusing, I didn't think there would be a template there [00:51:06] ahh, it's 'old style' meaning it's just the first contribution with that recur id [00:51:36] let's look at a recurring on staging [00:52:51] ok, cstone's record is breaking on staging too [00:52:55] https://civicrm.frdev.wikimedia.org/civicrm/contact/view?reset=1&cid=165749&selectedChild=contribute [00:52:58] eileen: ^^^ [00:54:07] ejegg: is the type hint new? if so we can remove it temporarily while we address [00:55:34] let's see [00:56:07] I have replicated [00:56:15] nope, type hint has been there for a while [00:57:17] oh $spec = $gatherer->getSpec($this->entity, 'get', FALSE); [00:57:35] yeah [00:58:08] so I'm trying to understand how it gets a joinPath segment with entity=null [00:58:46] foreach ($joinPath as $joinName => $link) { [00:58:48] ... [00:59:02] foreach ($link->getEntityFields() as $fieldObject) [00:59:23] And it's in that $link->getEntityFields() that it calls the bad getSpec [00:59:43] (this is up in Api4SelectQuery, which I think HAS seen some change since 5.66 [00:59:46] ) [01:00:27] hmm, recent change seems to just be aclStack stuff though [01:01:05] ejegg: OK - I have an answer [01:01:39] oho, quick work! [01:02:58] (03PS1) 10Eileen: Quick & dirty fix for fail on recur loading [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970885 (https://phabricator.wikimedia.org/T350208) [01:03:12] ejegg: it's on the end of the chain - but can be rebased out once the upgrade is merged [01:03:55] aha, yeah, i see the recent changes in that fn [01:04:44] ok, so that's fine for us locally because we don't care about joining those tables [01:04:57] but might end up with a different fix upstream? [01:07:42] 10Fundraising Sprint Uptown cURL, 10Wikimedia-Fundraising-CiviCRM, 10FR-Braintree-Integration, 10MW-1.42-notes (1.42.0-wmf.4; 2023-11-07): Store Venmo username and send it in receipt - https://phabricator.wikimedia.org/T303422 (10Cstone) Just deployed the saving the username and I see it in civi after a do... [01:08:16] ejegg: yep [01:14:33] hmm, I just got createPayment failed trying to charge a test recurring locally [01:14:39] though that was an ingenico one [01:14:44] lemme try with an adyen one [01:15:25] (03PS1) 10Eileen: Upgrade deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970887 (https://phabricator.wikimedia.org/T350208) [01:16:39] ok, the adyen one worked [01:16:50] let me debug into the ingenico one and see the raw fail code [01:26:36] ah i see [01:26:49] just an order id collision [01:27:04] since i forgot to reset my c_t seed to something high [01:27:15] ok, no blockers I can find eileen [01:27:30] (03PS1) 10Eileen: Run civix upgrade on omnimail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970888 (https://phabricator.wikimedia.org/T350208) [01:27:35] ejegg: yay [01:27:48] yeah ejegg we need to save those ctids on rebuild [01:31:12] (03CR) 10Ejegg: [C: 03+2] CiviCRM 5.68-rc (stock) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970478 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:31:19] (03CR) 10Ejegg: [C: 03+2] Remove upgrade to mailing_event_queue table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970479 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:31:24] (03CR) 10Ejegg: [C: 03+2] Adjust test for change in html 2 text library [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970481 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:31:33] (03CR) 10Ejegg: [C: 03+2] Add 2 new stock fields - quantity & ticker [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970879 (https://phabricator.wikimedia.org/T350313) (owner: 10Eileen) [01:31:34] dwisehaupt: we are ok to go with the civi upgrade - but are you about to disable triggers? [01:31:49] (03CR) 10Ejegg: [C: 03+2] Extension update - rpow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970881 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:31:53] (03CR) 10Ejegg: [C: 03+2] Extension update activity assignee [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970882 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:32:19] (03CR) 10Ejegg: [C: 03+2] "Hah, with all that code moved to mixins there's almost nothing left!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970883 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:32:35] (03CR) 10Ejegg: [C: 03+2] "It'll work for our non-membership site, anyway!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970885 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:32:56] ejegg: I have something to check on the deduper one (it's givng notices) so skip that one for now [01:33:48] (03CR) 10Ejegg: [C: 03+2] Upgrade deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970887 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:33:57] (03CR) 10Ejegg: [C: 03+2] Run civix upgrade on omnimail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970888 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:34:05] ooop [01:34:14] removed [01:34:44] notices with smarty3? [01:34:47] or smarty2? [01:36:12] nah php - something odd - not too sure - [01:36:37] I'm not gonna enable smarty3 now - but just trying locally with [01:36:38] if (!defined('CIVICRM_SMARTY3_AUTOLOAD_PATH')) { [01:36:38] define('CIVICRM_SMARTY3_AUTOLOAD_PATH', $civicrm_root . '/packages/smarty3/vendor/autoload.php'); [01:36:38] } [01:37:44] eileen: sorry was cooking. [01:38:20] i was just doing the table compaction. wasn't doing anything with triggers. [01:38:28] will you need me to update triggers? [01:38:45] (sorry, haven't been following along) [01:38:57] there are at least 2 new fields about to go out [01:39:00] so probably? [01:39:09] (03PS1) 10Eileen: Civix upgrade mailing stats [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970890 (https://phabricator.wikimedia.org/T350208) [01:39:24] dwisehaupt: yeah - need triggers off to deploy & then reload them [01:40:33] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Do a prune on detail data for activity records of type thank you - https://phabricator.wikimedia.org/T325123 (10Dwisehaupt) Down from 290G to 76G, ish. ` Alter complete in: 1406 seconds AKA: 23 minutes and 26 seconds Change in... [01:41:01] ok. i can do the work. do we have an upgrade checklist like normal? i can grab my parts. [01:41:23] as soon as i find where i set my yubikey down. [01:41:40] (03PS2) 10Eileen: Run civix upgrade on omnimail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970888 (https://phabricator.wikimedia.org/T350208) [01:41:42] (03PS2) 10Eileen: Civix upgrade mailing stats [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970890 (https://phabricator.wikimedia.org/T350208) [01:41:44] (03PS1) 10Eileen: Update contacteditor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970891 (https://phabricator.wikimedia.org/T350208) [01:43:06] (03PS1) 10Eileen: Upgrade civitoken [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970892 (https://phabricator.wikimedia.org/T350208) [01:44:13] ok. found it. [01:45:07] (03CR) 10CI reject: [V: 04-1] Upgrade civitoken [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970892 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:46:36] (03CR) 10CI reject: [V: 04-1] CiviCRM 5.68-rc (stock) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970478 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:46:38] (03PS1) 10Eileen: Update extended reports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970893 (https://phabricator.wikimedia.org/T350208) [01:46:40] (03CR) 10CI reject: [V: 04-1] Remove upgrade to mailing_event_queue table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970479 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:46:42] (03CR) 10CI reject: [V: 04-1] Adjust test for change in html 2 text library [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970481 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:46:44] (03CR) 10CI reject: [V: 04-1] Add 2 new stock fields - quantity & ticker [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970879 (https://phabricator.wikimedia.org/T350313) (owner: 10Eileen) [01:46:46] (03CR) 10CI reject: [V: 04-1] Extension update - rpow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970881 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:46:48] (03CR) 10CI reject: [V: 04-1] Extension update activity assignee [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970882 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:46:50] (03CR) 10CI reject: [V: 04-1] Extension update wmf-audit, exchange rates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970883 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:46:52] (03CR) 10CI reject: [V: 04-1] Quick & dirty fix for fail on recur loading [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970885 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:46:54] (03CR) 10CI reject: [V: 04-1] Upgrade deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970887 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:47:00] ug everything is failing now [01:47:24] this passed https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/970481 [01:47:29] but now no change & it fails [01:47:38] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970481 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:48:09] ah is it just that gate-and-submit complains because of the parent patch fails? This change depends on a change that failed to merge. [01:48:19] maybe we just force the parent two and that will be OK [01:48:24] ok [01:48:34] (03CR) 10Eileen: [V: 03+2] CiviCRM 5.68-rc (stock) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970478 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:48:48] yeah, the only fails in those parent two are fixed in that one [01:48:54] (03CR) 10Eileen: [C: 03+2] Remove upgrade to mailing_event_queue table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970479 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:49:17] (03CR) 10Eileen: [V: 03+2 C: 03+2] Remove upgrade to mailing_event_queue table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970479 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:49:21] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Remove upgrade to mailing_event_queue table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970479 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:49:54] ok - I forced those 2 - gonna go ahead & do a merge to deploy as the rest can go out as resolve [01:50:04] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970481 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:50:42] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970894 [01:50:51] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970894 (owner: 10Eileen) [01:53:24] dwisehaupt: here is an etherpad https://etherpad.wikimedia.org/p/iTU2T9rOAvV-vBGzJ8kr [01:53:49] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Adjust test for change in html 2 text library [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970481 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [01:54:00] but I think we can skip some steps this time [01:54:24] ok. pulling it up. [01:54:25] anyway - all merged now so ready to start [01:55:11] ok. let me stop the p-c jobs. [01:56:34] cool [01:58:29] ok. p-c jobs are stopped. do we want civi in maint mode? i just realized that wasn't in there. [01:58:53] I just did drupal mtce mode [01:59:00] since we don't need to put payments in maint mode since the queues are stopped. [01:59:03] ok cool. [01:59:25] we still have a pending and recurring job runing [01:59:44] let's let the recurring one finish [01:59:52] pending one doesn't actually touch any civi stuff [02:00:22] ok - am ready to go re pushing out the code [02:01:06] recurring should wrap up in a minute [02:01:13] i've captured the triggers as normal. [02:02:50] ok - let me know when to push out [02:03:20] recurring one wont finish till like 15? [02:03:33] or diffrent recurring one [02:04:21] yeah. i was just checking the timing. it has about a bit to go. i thought at first glance that it was one that ran every 10 mins. [02:04:44] looks like they generally run for ~25 mins and it started at xx:51 [02:04:48] smashpig recurrings yeah [02:04:57] it runs at :51 and :21 [02:05:27] is there a contribution tracking graph somewhere [02:06:02] i think thats the answer to my mystery [02:12:32] oh scroll barrrr [02:12:34] haha [02:13:47] more scroll more fun. :) [02:15:41] i'm confused about the drop trigger step. i don't remember doing that and i am not finding it in our normal runbooks. [02:16:29] trying to find where it was referenced. [02:17:22] oh right - I mean maybe we haven't been doing that? [02:18:00] ok no jobs running now [02:18:01] !log civicrm upgraded from 770b114c to 60bdd8d3 [02:18:03] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:18:10] yeah. usually i just capture them and do the diff. [02:18:26] ok - I'll kick off the upgrade [02:19:18] k, I've got to head to bed for the night. Have fun with the upgrade [02:23:05] script all finished [02:24:39] (03CR) 10Eileen: [V: 03+2] Add 2 new stock fields - quantity & ticker [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970879 (https://phabricator.wikimedia.org/T350313) (owner: 10Eileen) [02:26:02] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970895 [02:26:12] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970895 (owner: 10Eileen) [02:26:31] (03CR) 10Eileen: [V: 03+2 C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970895 (owner: 10Eileen) [02:27:11] !log civicrm upgraded from 60bdd8d3 to bcfd8a7e [02:27:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:32:22] (03PS1) 10Eileen: Update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970896 (https://phabricator.wikimedia.org/T350208) [02:46:20] (03PS1) 10Eileen: Updated triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970897 (https://phabricator.wikimedia.org/T350313) [02:46:38] (03Abandoned) 10Eileen: Update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970896 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [02:48:19] dwisehaupt: I pushed up the triggers - the deleted lines seem to have been duplicated [02:50:38] deleted lines as in the "drop trigger" lines? [02:51:27] yeah - at the end of the file there are lines removed - but I think they were in the file elsewhere [02:52:45] (03Merged) 10jenkins-bot: Extension update - rpow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970881 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [02:53:06] (03Merged) 10jenkins-bot: Extension update activity assignee [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970882 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [02:54:31] oh. that's fine. i see them elsewhere. [02:54:36] (03CR) 10Eileen: [V: 03+2] Quick & dirty fix for fail on recur loading [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970885 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [02:55:02] (03CR) 10Eileen: [V: 03+2] Extension update wmf-audit, exchange rates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970883 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [02:55:23] the trigger diff looks good. need me to +2 it? [02:56:24] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970898 [02:56:26] yes please [02:56:31] kk [02:56:37] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970898 (owner: 10Eileen) [02:56:51] (03CR) 10Dwisehaupt: [C: 03+2] "lgtm." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970897 (https://phabricator.wikimedia.org/T350313) (owner: 10Eileen) [02:56:57] (03Abandoned) 10Eileen: CiviCRM 5.67-rc (stock) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/960722 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [02:57:08] (03Abandoned) 10Eileen: Remove upgrade to mailing_event_queue table [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970477 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [02:57:11] oh. did i need to v+2 also? [02:58:24] (03PS2) 10Eileen: Updated triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970897 (https://phabricator.wikimedia.org/T350313) [02:58:27] (03PS1) 10Eileen: Revert "Remove upgrade to mailing_event_queue table" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970899 [02:59:50] dwisehaupt: can you also +2 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/970899 - now we have run the upgrade it means people won't miss them on the local installs [03:00:43] (03CR) 10Dwisehaupt: [C: 03+2] Revert "Remove upgrade to mailing_event_queue table" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970899 (owner: 10Eileen) [03:00:44] in theory we wait for it to v+2 - but can be very slow [03:00:51] ah. ok. [03:01:00] (03CR) 10Eileen: [V: 03+2] Updated triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970897 (https://phabricator.wikimedia.org/T350313) (owner: 10Eileen) [03:01:17] RECOVERY - check_mysql on frdb1006 is OK: Uptime: 29501 Threads: 13 Questions: 1331831 Slow queries: 64913 Opens: 1947 Open tables: 1606 Queries per second avg: 45.145 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1006&service=check_mysql [03:02:23] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970900 [03:02:32] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/970900 (owner: 10Eileen) [03:03:47] !log civicrm upgraded from bcfd8a7e to 86b620ef [03:03:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:03:57] dwisehaupt: new trigger file should be out (in the new location) [03:05:18] oh. new location fun. [03:06:51] is this going to be the new location for triggers going forward? just thinking about updating docs for future me. [03:07:36] yep it is [03:08:04] cool. i'll update the docs after then. [03:10:59] waiting on the trigger upload. [03:12:22] hmmm... i got no diff in the triggers. [03:12:58] oh - there should be new fields in the table civicrm_value_1_stock_information_10 [03:13:13] yeah. they are the same on disk. [03:13:33] try now [03:13:35] !log civicrm upgraded from 86b620ef to 84ec2957 [03:13:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:13:41] (just wasn't pushed) [03:13:46] ha. :) [03:15:04] that looks correct. [03:15:55] ok so I think we just need to bring stuff up [03:18:16] actually, that was the dir we are already using. so it's ok. at least when i compared to what we have now. [03:18:30] ok. do you want me to re-enable p-c/coworker? [03:19:34] sure [03:19:59] ok. doing so. [03:21:11] RECOVERY - check_mysql on frdb2002 is OK: Uptime: 1847820 Threads: 5 Questions: 388682967 Slow queries: 916 Opens: 6447 Open tables: 1007 Queries per second avg: 210.346 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2002&service=check_mysql [03:22:11] RECOVERY - check_mysql on frdb2001 is OK: Uptime: 1848124 Threads: 6 Questions: 388818923 Slow queries: 917 Opens: 6444 Open tables: 1005 Queries per second avg: 210.385 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_mysql [03:22:24] they are back up and i verified that the p-c cron file was properly created. [03:25:15] 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10FR-donorservices: Permission changed for DR agents - https://phabricator.wikimedia.org/T343899 (10Eileenmcnaughton) @shust I just pushed out an update on this - it might be in a different place in the menu now.... {F41431237} [03:26:14] 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10fundraising-tech-ops, 10Patch-For-Review: CiviCRM point release - https://phabricator.wikimedia.org/T350208 (10Eileenmcnaughton) [03:26:47] 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10fundraising-tech-ops, 10Patch-For-Review: CiviCRM point release - https://phabricator.wikimedia.org/T350208 (10Eileenmcnaughton) a:03Eileenmcnaughton upgraded to 5.68 [03:27:02] 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Create 2 new stock fields - quantity & ticker - https://phabricator.wikimedia.org/T350313 (10Eileenmcnaughton) a:03Eileenmcnaughton @mdemos the fields are there now - but I'll create a separate phab for the thank you... [03:27:31] 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Update thank you main & endowment mail to use new stock fields - https://phabricator.wikimedia.org/T350331 (10Eileenmcnaughton) [03:28:03] 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Unplanned-Sprint-Work: Create 2 new stock fields - quantity & ticker - https://phabricator.wikimedia.org/T350313 (10Eileenmcnaughton) [03:29:06] no flood of failmail [03:29:30] wow. we may have just about completed everything on the current schedule. [03:29:36] cool [03:29:43] still some followup around the ssl connections for db users. [03:29:53] but i think all the major bits are looking good. [03:30:02] maybe i'll get a break this week. :) [03:31:29] 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2324Q2 maintenance window - https://phabricator.wikimedia.org/T337579 (10Eileenmcnaughton) [03:31:46] cool [03:31:55] oh. i sent my email before adding in the stock field bit. [03:32:02] i'll add that in tomorrow's email [03:32:20] dwisehaupt: oh wow - 220GB reclaimed! [03:33:05] yeah. i need to verify that trickled down to the replicas. if not, i'll reclaim on all of them tomorrow. [03:33:22] cool [03:33:47] 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog: Bug with new Recurring Financial Types - https://phabricator.wikimedia.org/T345919 (10Eileenmcnaughton) both queries ran clean - I think this is done! [03:33:51] but for now, i need to stretch a bit. will check in later on the replication for the last few dbs just to make sure the downtime is set properly. [03:33:58] 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog: Bug with new Recurring Financial Types - https://phabricator.wikimedia.org/T345919 (10Eileenmcnaughton) [03:34:12] 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog: Bug with new Recurring Financial Types - https://phabricator.wikimedia.org/T345919 (10Eileenmcnaughton) 05Open→03Resolved [04:20:42] (03Merged) 10jenkins-bot: Revert "Remove upgrade to mailing_event_queue table" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970899 (owner: 10Eileen) [05:58:17] RECOVERY - check_mysql on frdb1004 is OK: Uptime: 40194 Threads: 4 Questions: 2670903 Slow queries: 6 Opens: 3621 Open tables: 1079 Queries per second avg: 66.450 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [07:41:52] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: "Typed card number does not match card brand" errors - https://phabricator.wikimedia.org/T349600 (10RKumar_WMF) I am unable to send BIN since the donation has not come through. But I am checking if sending previous donation BIN would... [08:41:25] 10Fundraising Sprint Uptown cURL: Enable all payment methods for LATAM pre-test in Q2 - https://phabricator.wikimedia.org/T349857 (10RKumar_WMF) I tried to update the URL with recurring =1 but it did not show up. Can you please update this sheet row numnber 34 onwards: https://docs.google.com/spreadsheets/d/1QbX... [12:31:53] (03CR) 10Jgleeson: "I agree with Elliott. We're way down the rabbit hole of coupling this class to Adyen and even Dlocal with UPI checks. Tying in a generalis" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/958563 (https://phabricator.wikimedia.org/T340159) (owner: 10Wfan) [12:45:14] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Slow query killer for CiviCRM - https://phabricator.wikimedia.org/T340773 (10Jgreen) [12:46:31] (03CR) 10Jgleeson: "Ignore that last suggestion. Let's not introduce processor-specific classes into what should be a generic CiviCRM extension allowing Smash" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/958563 (https://phabricator.wikimedia.org/T340159) (owner: 10Wfan) [12:47:36] (03CR) 10Jgleeson: Add log and cancel_reason to indicate the failed reason (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/958563 (https://phabricator.wikimedia.org/T340159) (owner: 10Wfan) [12:47:49] (03CR) 10Jgleeson: [C: 04-1] Add log and cancel_reason to indicate the failed reason [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/958563 (https://phabricator.wikimedia.org/T340159) (owner: 10Wfan) [12:47:51] 10Fundraising-Backlog: Modify fundstatgen.py to use mysql connection encryption. - https://phabricator.wikimedia.org/T350067 (10Jgreen) [13:17:02] facepalm [13:17:51] ugh...another rushed morning to get kiddo to preschool, i get to the library and open my bag and...no compy [13:18:06] well,back on the bike [13:24:41] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Email: Civi to Acoustic Export: Job Status Failed - https://phabricator.wikimedia.org/T350386 (10LMedley-WMF) [13:24:48] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fundraising-tech-ops: Tools for Analyzing MySQL Slow Query Log - https://phabricator.wikimedia.org/T349565 (10Jgreen) 05Open→03Resolved a:03Jgreen This is done. Note that rsyslog adds a couple fields and might truncate extremely long lines (MaxM... [13:28:41] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Slow query killer for CiviCRM - https://phabricator.wikimedia.org/T340773 (10Jgreen) [13:29:06] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Email: Civi to Acoustic Export: Job Status Failed - https://phabricator.wikimedia.org/T350386 (10LMedley-WMF) [13:29:12] ah no ejegg|away [13:29:37] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Email: Civi to Acoustic Export: Job Status Failed - https://phabricator.wikimedia.org/T350386 (10LMedley-WMF) [13:29:37] thanks Jeff_Green ! [13:30:45] jgleeson: np! [13:40:47] heh, ok, I'm back home with the lappy. it's cold out - think I'll just work from here today [13:43:00] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Slow query killer for CiviCRM - https://phabricator.wikimedia.org/T340773 (10Jgreen) I emailed fr-tech about a prototype script on civi1002 named civicrm_query_killer. Also, it would be worth looking into MAX_STATEMENT_TIME whic... [13:44:59] (03CR) 10Jgleeson: [C: 04-1] "Thanks for the updates. This looks really close. Just one small request before merging." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/958999 (https://phabricator.wikimedia.org/T340159) (owner: 10Wfan) [13:51:00] 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen) [13:51:01] 10fundraising-tech-ops: Puppet 7.x support in Fundraising environment - https://phabricator.wikimedia.org/T345207 (10Jgreen) 05In progress→03Resolved [13:55:41] 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10FR-donorservices: Permission changed for DR agents - https://phabricator.wikimedia.org/T343899 (10SHust) @Eileenmcnaughton Thank you! I'll have the team test it out, and I'll ping you if they can’t access it. [14:01:50] (03CR) 10Jgleeson: [C: 04-1] "Looks good! two suggestions" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/968725 (https://phabricator.wikimedia.org/T348544) (owner: 10Damilare Adedoyin) [14:03:16] ejegg: I also poked my nose into that patch which you'd already started review on. I'm gonna move the ticket to "being reviewed" [14:03:38] ready for review is now empty! [14:15:40] (03CR) 10Jgleeson: Contribution Import Refactor: inline calls to ImportStatsCollector::getInstance() (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970460 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [14:21:23] (03CR) 10Jgleeson: Contribution Import Refactor: inline calls to ImportStatsCollector::getInstance() (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970460 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [14:26:58] (03PS1) 10Jgleeson: Contribution Import Refactor: extract out the timer start/end pepperings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971206 (https://phabricator.wikimedia.org/T240581) [14:31:28] (03PS1) 10Jgleeson: Contribution Import Refactor: be consistent with internal method names [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971208 [14:32:48] (03CR) 10Jgleeson: "I've just updated this in https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/971208/ to be consistent with the other new method" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970460 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [14:33:32] now for the tricky bit, the recurring code [14:41:08] thanks jgleeson [14:51:39] (03PS1) 10Jgleeson: WIP: Contribution Import Refactor: combine and simplify the recurring logic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971212 (https://phabricator.wikimedia.org/T240581) [14:51:58] thank you ejegg for review/feedback! [15:07:29] (03CR) 10CI reject: [V: 04-1] WIP: Contribution Import Refactor: combine and simplify the recurring logic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971212 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [15:13:31] (03PS3) 10Pcoombe: Change page title for clarity [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/929790 [15:15:06] (03PS3) 10Ejegg: Pass through site_key in config copy of civiproxy [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/970411 (https://phabricator.wikimedia.org/T349946) [15:29:28] I tried to make this trivial language edit a while ago, but it got stuck due to some issue with jenkins and the extension. Was just reminded of it, rebased and it worked this time. Would anyone mind giving code review? https://gerrit.wikimedia.org/r/929790 [15:29:47] (03PS2) 10Ejegg: Pass site key through to CiviCRM [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/970443 (https://phabricator.wikimedia.org/T349946) [15:30:49] (03PS3) 10Ejegg: Pass site key through to CiviCRM [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/970443 (https://phabricator.wikimedia.org/T349946) [15:31:14] will do pcoombe ! [15:31:26] FR-tech, i'm feeling pretty good about that last civiproxy patch [15:31:37] I think it's probably ready to send back upstream to try to get merged there [15:31:54] but i'd appreciate some local review first! [15:33:08] It's working for me with the recurUpgrade page [15:34:46] Ah, let me add instructions for getting a good recurUpgrade link [15:41:35] 10Fundraising-Backlog: Creating an new import for Overflow.co for Stock and DAF gifts - https://phabricator.wikimedia.org/T349930 (10MDemosWMF) Related work happening here for stock import T350313 - new stock fields T350331 - TY template updates [15:50:03] (03CR) 10Cstone: [C: 03+2] Change page title for clarity [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/929790 (owner: 10Pcoombe) [15:50:23] thanks cstone ! [15:51:23] yes, thanks cstone! [15:54:28] (03PS8) 10Ejegg: Contribution Import Refactor: inline calls to ImportStatsCollector::getInstance() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970460 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [15:54:33] (03CR) 10Ejegg: [C: 03+2] Contribution Import Refactor: inline calls to ImportStatsCollector::getInstance() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970460 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [15:58:46] (03PS7) 10Ejegg: Contribution Import Refactor: Move main timer naming to fn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970462 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [15:58:50] (03CR) 10Ejegg: [C: 03+2] Contribution Import Refactor: Move main timer naming to fn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970462 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [15:59:41] (03CR) 10CI reject: [V: 04-1] Change page title for clarity [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/929790 (owner: 10Pcoombe) [16:00:14] :( [16:03:54] (03PS2) 10Ejegg: Contribution Import Refactor: extract out the timer start/end pepperings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971206 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [16:04:04] (03CR) 10Ejegg: [C: 03+2] Contribution Import Refactor: extract out the timer start/end pepperings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971206 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [16:04:29] (03PS2) 10Ejegg: Contribution Import Refactor: be consistent with internal method names [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971208 (owner: 10Jgleeson) [16:04:36] (03CR) 10Ejegg: [C: 03+2] Contribution Import Refactor: be consistent with internal method names [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971208 (owner: 10Jgleeson) [16:05:22] SpecialPageFatalTest::testSpecialPageDoesNotFatal [16:05:23] 11:52:27 str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated [16:05:26] hmmm [16:05:43] wow, weird [16:08:34] just an i18n change doing that? [16:09:04] (03CR) 10Ejegg: "recheck" [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/929790 (owner: 10Pcoombe) [16:09:18] oh, and only on gate-and-submit [16:10:07] passed the same exact test on the initial validation test suite: https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php74-noselenium-docker/40233/console [16:11:00] (03Merged) 10jenkins-bot: Contribution Import Refactor: inline calls to ImportStatsCollector::getInstance() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970460 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [16:14:45] (03Merged) 10jenkins-bot: Contribution Import Refactor: Move main timer naming to fn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970462 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [16:18:52] (03Merged) 10jenkins-bot: Contribution Import Refactor: extract out the timer start/end pepperings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971206 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [16:20:31] pcoombe: gerrit didn't trigger a new gate-and-submit round after V+2-ing it that time, so I just clicked the 'submit' button [16:20:49] (03Merged) 10jenkins-bot: Contribution Import Refactor: be consistent with internal method names [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971208 (owner: 10Jgleeson) [16:21:49] thanks ejegg ! [16:30:50] (03CR) 10Wfan: Add cancel authorize process from auto rescue end process's webhook message (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/958999 (https://phabricator.wikimedia.org/T340159) (owner: 10Wfan) [16:51:25] hmm fr-tech I have 3 meetings starting in 10 min [16:51:41] I think I need to skip autopsy and alerts retro today [16:53:01] so here's my IRC update: I got another email from Ingenico - looks like they found some more tokens and need to export again. Some don't have an invoice_id in their system but I will export a csv with tokens and invoice IDs that Adyen can use to create shopperReferences for those rows [16:53:46] I updated the patch sets for CiviProxy and now it should handle multiple API4 flows for both the external and internal API calls [16:54:15] I've reviewed a couple of jgleeson's patches and will look at some more [17:01:58] (03PS11) 10Wfan: Add cancel authorize process from auto rescue end process's webhook message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/958999 (https://phabricator.wikimedia.org/T340159) [17:05:01] (03PS8) 10Wfan: Add log and cancel_reason to indicate the failed reason [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/958563 (https://phabricator.wikimedia.org/T340159) [17:09:54] 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage, 10donate.wikimedia.org, 10MW-1.42-notes (1.42.0-wmf.3; 2023-10-31): donate.wikimedia.org landing pages don't have descriptions in search engine results - https://phabricator.wikimedia.org/T254808 (10Pcoo... [17:10:58] 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Patch-For-Review: Upgrade recur amount when donor upgrades their recurring in Fundraiseup - https://phabricator.wikimedia.org/T348544 (10Damilare) This has now been deployed. cc @Pcoombe [17:11:33] 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.4; 2023-11-07): Enable Monthly Convert for Apple Pay - https://phabricator.wikimedia.org/T346840 (10Damilare) This has now been deployed. Thanks @Pcoombe [17:13:31] 10Fundraising Sprint Uptown cURL: Enable all payment methods for LATAM pre-test in Q2 - https://phabricator.wikimedia.org/T349857 (10AnnWF) >>! In T349857#9300645, @RKumar_WMF wrote: > I tried to update the URL with recurring =1 but it did not show up. Can you please update this sheet row numnber 34 onwards: htt... [17:46:11] hah, i just demo-ed the recurring upgrade form, and after submitting and processing queues we somehow had two contributions listed [17:46:57] it upgraded from 1 to 2. success. :) [17:47:54] ahh i see, that had nothing to do with the upgrade [17:48:28] it was the initial donation I created last night to test the civi upgrade, then I tried charging a recurring contribution on the same recur a minute later to make sure that job worked too [17:48:46] ok, just a case of reusing slightly odd test data for the demo [17:48:48] oh well [17:52:45] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Review & fix CiviCRM log file management - https://phabricator.wikimedia.org/T247378 (10Jgreen) We have a directory outside of the web tree that we used to log to: /srv/org.wikimedia.civicrm-logs -- however the last logs there were in June. [17:56:41] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Review & fix CiviCRM log file management - https://phabricator.wikimedia.org/T247378 (10Jgreen) >>! In T247378#9302943, @Jgreen wrote: > We have a directory outside of the web tree that we used to log to: /srv/org.wikimedia.civicrm-logs -- however the las... [18:01:25] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Email: Civi to Acoustic Export: Job Status Failed - https://phabricator.wikimedia.org/T350386 (10Cstone) Thanks for such a detailed report! It really helps figure things out! The jobs were turned off last night while we did upgrade work on civi. T... [18:19:56] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Review & fix CiviCRM log file management - https://phabricator.wikimedia.org/T247378 (10Jgreen) Can we just replace the default logger with the monolog extension https://lab.civicrm.org/extensions/monolog and configure that output everything to syslog? [18:21:20] (03PS3) 10Ejegg: Civix upgrade mailing stats [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970890 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [18:21:27] (03CR) 10Ejegg: [C: 03+2] Civix upgrade mailing stats [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970890 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [18:39:52] (03Merged) 10jenkins-bot: Civix upgrade mailing stats [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970890 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [19:02:18] (03PS2) 10Ejegg: Update contacteditor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970891 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [19:02:28] (03CR) 10Ejegg: [C: 03+2] Update contacteditor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970891 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [19:03:02] (03PS2) 10Ejegg: Upgrade civitoken [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970892 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [19:19:56] huh, just got two emails from slack with notifications from messages from last week [19:20:04] (03Merged) 10jenkins-bot: Update contacteditor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970891 (https://phabricator.wikimedia.org/T350208) (owner: 10Eileen) [19:20:08] I definitely haven't changed any notification settings [19:22:06] 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage, 10donate.wikimedia.org, 10MW-1.42-notes (1.42.0-wmf.3; 2023-10-31): donate.wikimedia.org landing pages don't have descriptions in search engine results - https://phabricator.wikimedia.org/T254808 (10Ejeg... [19:39:51] (03PS2) 10Eileen: Upgrade deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970887 (https://phabricator.wikimedia.org/T350208) [19:41:44] (03PS1) 10Ejegg: Fix robots meta tag to allow indexing [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/971277 (https://phabricator.wikimedia.org/T254808) [19:41:58] OK ^^^ should fix the meta tag [19:43:03] Looks like there's just one single robots.txt for the whole production cluster, with special patterns for lots of different wikis [19:43:18] so I guess I'll just add an overriding Allow: rule there [19:51:30] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Email: Civi to Acoustic Export: Job Status Failed - https://phabricator.wikimedia.org/T350386 (10KHaggard) Thanks @Cstone :) Figured it was related to upgrade work as usual with the maintenance weeks but I appreciate you for confirming and @LMedley... [19:51:51] (03PS3) 10Eileen: Upgrade civitoken [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970892 (https://phabricator.wikimedia.org/T350208) [19:51:53] (03PS2) 10Eileen: Update extended reports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970893 (https://phabricator.wikimedia.org/T350208) [19:51:55] (03PS1) 10Eileen: Civix upgrade on RIP extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971280 [19:52:51] (03PS1) 10Eileen: Civix upgrade on matching gifts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971282 [19:53:29] hi eileen ! [19:54:06] I think I've got a fairly solid civiproxy patch up here: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civiproxy/+/970443 [19:54:20] huh, merge conflict? [19:54:34] oh right, zuul is unhappy with civiproxy repo for some reason [19:54:49] (03PS2) 10Ejegg: Fix WS inconsistencies [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/970442 [19:55:08] oh, or there really IS a merge conflict [19:55:12] ok, lemme sort that out [19:57:48] (03PS1) 10Eileen: Upgrade civix on unsubscribe [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971283 [20:02:28] (03PS3) 10Ejegg: Fix WS inconsistencies [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/970442 [20:02:30] (03PS4) 10Ejegg: Pass site key through to CiviCRM [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/970443 (https://phabricator.wikimedia.org/T349946) [20:03:19] (03PS1) 10Eileen: Update civix on export permission [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971285 [20:03:25] ok eileen ^^^ is maybe ready to send upstream [20:03:44] I just would like to run it by you first if you have some time [20:07:07] (03PS1) 10Eileen: Run civix on forgetme [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971306 [20:07:37] ejegg: do you want to hang out? [20:14:17] sure eileen [20:14:39] https://meet.google.com/ksg-mnkt-buh?authuser=0 [20:19:15] (03PS5) 10Ejegg: Pass site key through to CiviCRM [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/970443 (https://phabricator.wikimedia.org/T349946) [20:32:43] wfan: arg just found out my civi meeting in 90 mins is now in 30 mins & clashes with the time with you now [20:35:25] You can choose other time if you want haha [20:35:54] Make a time suggestion I can move :) [20:37:38] how late are you on? would a couple of hours later be ok? [20:42:15] (03PS1) 10Eileen: Run civix upgrade to support smarty 3 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971313 [20:45:58] Sure [20:46:34] Just updated to 3 hrs later haha [20:46:56] (03PS1) 10Eileen: Run civix upgrade on datachecks [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971314 [20:49:13] eileen: we tried adding the ssl cert and pdo cert stuff for mysql connections to prod that is running on frdev but it failed right out. may be good to get some time with you to try and sort that out if we can. [20:50:55] (03PS1) 10Eileen: Civix upgrade on ckeditor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971315 [20:51:26] dwisehaupt: ok - I have a civi call in 9 mins that will take about an hour (its a weekly thing) [20:51:51] so this is stuff already running on frdev but failed on prod [20:52:04] nothing different in civicrm.settings.php or settings.php? [20:55:45] (03PS1) 10Eileen: Update civix on relationship block [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971317 [20:58:13] (03PS2) 10Eileen: Update civix on relationship block [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971317 [21:01:35] (03PS3) 10Eileen: Update civix on relationship block [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971317 [21:01:37] (03PS1) 10Eileen: Update to latest contact layout editor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971319 [21:06:03] (03PS1) 10Eileen: Increment version [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971320 [21:06:03] correct. this was just adding the dsn and pdo updates that are already in dev. you can see the revert in the latest commit in localsettings. [21:09:14] (03PS3) 10Eileen: Upgrade deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/970887 (https://phabricator.wikimedia.org/T350208) [21:31:16] (03PS5) 10Damilare Adedoyin: Upgrade recur amount when donor upgrades their recurring in Fundraiseup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/968725 (https://phabricator.wikimedia.org/T348544) [21:31:25] (03CR) 10CI reject: [V: 04-1] Upgrade recur amount when donor upgrades their recurring in Fundraiseup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/968725 (https://phabricator.wikimedia.org/T348544) (owner: 10Damilare Adedoyin) [21:37:31] (03PS6) 10Damilare Adedoyin: Upgrade recur amount when donor upgrades their recurring in Fundraiseup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/968725 (https://phabricator.wikimedia.org/T348544) [21:40:26] (03PS7) 10Damilare Adedoyin: Upgrade recur amount when donor upgrades their recurring in Fundraiseup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/968725 (https://phabricator.wikimedia.org/T348544) [21:42:50] (03PS8) 10Damilare Adedoyin: Upgrade recur amount when donor upgrades their recurring in Fundraiseup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/968725 (https://phabricator.wikimedia.org/T348544) [21:45:00] (03CR) 10Damilare Adedoyin: "Thanks jgleeson and ejegg for the code review, made the recommended changes." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/968725 (https://phabricator.wikimedia.org/T348544) (owner: 10Damilare Adedoyin) [21:59:06] (03CR) 10CI reject: [V: 04-1] Upgrade recur amount when donor upgrades their recurring in Fundraiseup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/968725 (https://phabricator.wikimedia.org/T348544) (owner: 10Damilare Adedoyin) [22:01:00] (03PS9) 10Damilare Adedoyin: Upgrade recur amount when donor upgrades their recurring in Fundraiseup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/968725 (https://phabricator.wikimedia.org/T348544) [22:16:25] (03CR) 10CI reject: [V: 04-1] Upgrade recur amount when donor upgrades their recurring in Fundraiseup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/968725 (https://phabricator.wikimedia.org/T348544) (owner: 10Damilare Adedoyin) [22:46:26] (03PS1) 10Ejegg: Alphabetize currencies in MC settings [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/971328 [22:48:35] (03PS1) 10Ejegg: Add monthly convert amount config for BRL [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/971329 (https://phabricator.wikimedia.org/T303778) [22:57:35] (03PS6) 10Ejegg: Support site_key and multiple auth flows [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/970443 (https://phabricator.wikimedia.org/T349946) [23:00:31] (03PS4) 10Ejegg: Pass through site_key in config copy of civiproxy [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/970411 (https://phabricator.wikimedia.org/T349946) [23:02:12] wfan: I thought it was now we were gonna chat - but it is in another hour? [23:02:52] 10Fundraising-Backlog: Rename fr-dev 'mediawiki' docker image - https://phabricator.wikimedia.org/T350442 (10Ejegg) [23:03:56] Hahahaha I can do it now if you are ready [23:04:17] (03CR) 10Ejegg: "Jgleeson, I've added a phab task to rename the image: https://phabricator.wikimedia.org/T350442 . Do you think we can go with this change " [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/970006 (owner: 10Ejegg) [23:06:05] sure [23:06:36] ejegg|skrun: this is the link - if you are about https://meet.google.com/rgh-eunz-foh?authuser=0 [23:16:27] (03PS10) 10Damilare Adedoyin: Upgrade recur amount when donor upgrades their recurring in Fundraiseup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/968725 (https://phabricator.wikimedia.org/T348544) [23:36:26] https://usercontent.irccloud-cdn.com/file/Hvns5aN1/Screenshot%202023-11-02%20at%204.36.14%20PM.png [23:37:03] https://usercontent.irccloud-cdn.com/file/7NR6W6Of/Screenshot%202023-11-02%20at%204.36.54%20PM.png