[00:23:38] 10Fundraising Sprint Uptown cURL, 10Fundraising Sprint vvv - tell me more, 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.3; 2023-10-31): Send browser data to Adyen on CC transactions so we can optionally toggle on/off 3DS on demand - https://phabricator.wikimedia.org/T341299 (10Ejegg) Sure thing, it's... [00:34:45] (03PS4) 10Cstone: Calculate the next_sched_contribution date like smashpig recurring is [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/973271 (https://phabricator.wikimedia.org/T350711) [00:35:35] 10Fundraising Sprint Uptown cURL, 10Fundraising Sprint vvv - tell me more, 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.3; 2023-10-31): Send browser data to Adyen on CC transactions so we can optionally toggle on/off 3DS on demand - https://phabricator.wikimedia.org/T341299 (10EMartin) Now on the cal... [00:43:49] (03CR) 10Cstone: Calculate the next_sched_contribution date like smashpig recurring is (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/973271 (https://phabricator.wikimedia.org/T350711) (owner: 10Cstone) [02:17:48] (03CR) 10Eileen: [C: 03+1] "This works but only partially" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/973874 (https://phabricator.wikimedia.org/T350680) (owner: 10Damilare Adedoyin) [02:23:00] (03PS3) 10Eileen: Coworker: Bump failing tasks to a damaged queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/973874 (https://phabricator.wikimedia.org/T350680) (owner: 10Damilare Adedoyin) [02:23:02] (03PS1) 10Eileen: Set outcome to retry to avoid the queue being set to aborted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974292 (https://phabricator.wikimedia.org/T350680) [02:26:24] (03CR) 10Eileen: [C: 03+2] Truncate Name to unblock contribution msg import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/972919 (https://phabricator.wikimedia.org/T350831) (owner: 10Wfan) [02:42:28] (03Merged) 10jenkins-bot: Truncate Name to unblock contribution msg import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/972919 (https://phabricator.wikimedia.org/T350831) (owner: 10Wfan) [03:06:10] (03CR) 10Ejegg: [V: 03+2] Fix WS inconsistencies [wikimedia/fundraising/crm/civiproxy] - 10https://gerrit.wikimedia.org/r/970442 (owner: 10Ejegg) [03:19:23] (03PS1) 10Cstone: Only country is required for getPaymentMethods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974295 [03:49:15] (03CR) 10Cstone: [V: 03+2 C: 03+2] Use PredisCache for SmashPig [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/974270 (owner: 10Ejegg) [05:08:29] (03CR) 10Cstone: [C: 03+2] "Looks good!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974277 (https://phabricator.wikimedia.org/T318638) (owner: 10Ejegg) [05:09:02] (03Merged) 10jenkins-bot: Handle arrays in Predis cache [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974277 (https://phabricator.wikimedia.org/T318638) (owner: 10Ejegg) [05:09:04] (03CR) 10Cstone: [C: 03+2] "Nice, see all the caches when trying different currencies." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974278 (owner: 10Ejegg) [05:09:43] (03Merged) 10jenkins-bot: Adyen GetPaymentMethods: just cache RawResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974278 (owner: 10Ejegg) [05:11:04] (03PS2) 10Cstone: Only country is required for getPaymentMethods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974295 [06:40:01] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/974339 (owner: 10L10n-bot) [06:55:36] (03CR) 10Jgleeson: [C: 03+2] "This looks good to me! thanks for the updates." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/973237 (https://phabricator.wikimedia.org/T350919) (owner: 10Cstone) [06:56:37] jgleeson sleeps not? [06:57:02] hmm I guess it is morning there ;) [06:57:25] (03Merged) 10jenkins-bot: Add catch to change utm_source from non banner app donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/973237 (https://phabricator.wikimedia.org/T350919) (owner: 10Cstone) [07:37:00] (03PS3) 10Jgleeson: Tighten up recurring checks in wmf_civicrm_contribution_message_import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/973850 [07:37:02] (03PS9) 10Jgleeson: Contribution Import Refactor: combine recurring processing code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971212 (https://phabricator.wikimedia.org/T240581) [07:37:53] hey AndyRussG|vol ! yeah early start today [07:38:13] with the hope of an early finish! [07:38:16] how are things? [07:38:26] heyyy jgleeson [07:38:36] not bad, actually just about to go to sleep here heheh [07:38:59] good good. ah right, well I hope you sleep well! [07:39:06] was just up late writing an e-mail to a prof at a university for advice about future studies in mathematics [07:39:19] oh wow, nice [07:40:08] ahh heheh thanks yeah it's a fun plan, not sure if the fact that I got like 2 out of 10 on my last math exam will throw a wrnech into the works [07:40:58] hope you and your family and also everyone at WMF are well!!!!! super happy for these pings, giant hug, hope to tty soon!!! [07:41:27] I think when you learn something with interest in passion, which I imagine you would, it makes it easier! :) [07:41:39] good to talk to you also, hopefully talk more soon! take it easy [07:42:00] normally eileen is kicking about at this time but she might have dropped off [07:42:55] interest and* passion. caffeine not kicked in... :) [07:44:15] ;) aaa thanks!!! giant hug again :) [07:45:16] :> [07:49:03] (03CR) 10Jgleeson: "I rebased this one again. It rearranges a lot of stuff, so it would be good to get looked at soon and avoid further merge conflicts and he" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971212 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [10:29:52] 10Fundraising-Backlog: No 2023-11-14 Fundraise Up donations in Civi - https://phabricator.wikimedia.org/T351295 (10Pcoombe) [11:47:47] (03CR) 10Jgleeson: "This change is ready for review." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/556829 (https://phabricator.wikimedia.org/T240581) (owner: 10Ejegg) [11:48:10] (03CR) 10Jgleeson: [C: 04-1] "Not ready yet but being tested" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/556829 (https://phabricator.wikimedia.org/T240581) (owner: 10Ejegg) [13:15:20] (03CR) 10Jgleeson: [C: 03+2] "I love the new test! Thanks. I'm happy to +2 this, but I am now wondering whether we should relocate the utility method CRM_Core_Payment_S" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/973271 (https://phabricator.wikimedia.org/T350711) (owner: 10Cstone) [13:33:31] (03Merged) 10jenkins-bot: Calculate the next_sched_contribution date like smashpig recurring is [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/973271 (https://phabricator.wikimedia.org/T350711) (owner: 10Cstone) [15:16:28] (03CR) 10Ejegg: [C: 03+2] Only country is required for getPaymentMethods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974295 (owner: 10Cstone) [15:17:01] (03Merged) 10jenkins-bot: Only country is required for getPaymentMethods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/974295 (owner: 10Cstone) [15:26:18] 10Fundraising-Backlog, 10FR-Adyen: Enable Vipps through Adyen - https://phabricator.wikimedia.org/T339937 (10AKanji-WMF) March may be tight, I will review against the other priorities - there's several things we want to hit the ground running with after code freeze. An aside - do we anticipate any issues gath... [16:27:00] 10Fundraising-Backlog, 10Epic: Rename utm_ URL parameters through donatewiki and paymentswiki - https://phabricator.wikimedia.org/T351325 (10Ejegg) [16:31:03] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Accept wmf_ versions of utm_* parameters in DonationInterface - https://phabricator.wikimedia.org/T351326 (10Ejegg) [16:32:20] (03PS1) 10Ejegg: Accept wmf_ versions of all utm_* parameters [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/974625 (https://phabricator.wikimedia.org/T351326) [16:34:13] (03CR) 10CI reject: [V: 04-1] Accept wmf_ versions of all utm_* parameters [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/974625 (https://phabricator.wikimedia.org/T351326) (owner: 10Ejegg) [16:39:43] (03PS2) 10Ejegg: Accept wmf_ versions of all utm_* parameters [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/974625 (https://phabricator.wikimedia.org/T351326) [18:02:08] 10Fundraising Sprint vvv - tell me more, 10Fundraising-Backlog, 10Recurring-Donations: Auto-Rescue Edge Cases - https://phabricator.wikimedia.org/T350501 (10Cstone) [18:20:23] 10Fundraising Sprint vvv - tell me more, 10Fundraising-Backlog, 10Recurring-Donations: Auto-Rescue Edge Cases - https://phabricator.wikimedia.org/T350501 (10Cstone) [18:22:29] 10Fundraising Sprint vvv - tell me more, 10Fundraising-Backlog, 10Recurring-Donations: Auto-Rescue Edge Cases - https://phabricator.wikimedia.org/T350501 (10Cstone) [18:28:26] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Smashpig, 10Recurring-Donations: Cancel auto-rescue at Adyen when donor cancels recurring donation in Civi - https://phabricator.wikimedia.org/T351338 (10Ejegg) [18:28:48] ok fr-tech there's the ticket for the auto-rescue 'cancel' API call ^^^ [18:43:02] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: Venmo donations without customer information in Civi - https://phabricator.wikimedia.org/T350733 (10AnnWF) We are not logging the data after fetch will add it, also I will write a script to recover those customer info and fill them b... [18:58:51] 10Fundraising-Backlog, 10Recurring-Donations: Limit auto rescue to credit cards - https://phabricator.wikimedia.org/T351340 (10Cstone) [18:59:05] (03PS4) 10Ejegg: Tighten up recurring checks in wmf_civicrm_contribution_message_import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/973850 (owner: 10Jgleeson) [18:59:11] (03CR) 10Ejegg: [C: 03+2] Tighten up recurring checks in wmf_civicrm_contribution_message_import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/973850 (owner: 10Jgleeson) [18:59:24] 10Fundraising Sprint vvv - tell me more, 10Fundraising-Backlog, 10Recurring-Donations: Auto-Rescue Edge Cases - https://phabricator.wikimedia.org/T350501 (10Cstone) [19:14:18] 10Fundraising-Backlog: We still have an issue with Paypal CID gran donations coming in through blocked CIVI CID - https://phabricator.wikimedia.org/T351342 (10EMartin) [19:15:16] (03Merged) 10jenkins-bot: Tighten up recurring checks in wmf_civicrm_contribution_message_import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/973850 (owner: 10Jgleeson) [19:16:07] 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen) [19:16:57] 10fundraising-tech-ops: Fundraising environment support for Debian 12 (Bookworm) - https://phabricator.wikimedia.org/T344290 (10Jgreen) [19:53:05] 10Fundraising Tech - Chaos Crew: fundraiseup_id is miss placed to venmo_user_name - https://phabricator.wikimedia.org/T351345 (10AnnWF) [20:00:46] wfan can you help me understand where we use this phone field? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/972889 [20:01:31] we do not use it now at our end yet, it's show on Braintree console. [20:02:06] Just some additional info that is pulling from customer data if provided by Braintree [20:08:23] 10Fundraising Tech - Chaos Crew: fundraiseup_id is miss placed to venmo_user_name - https://phabricator.wikimedia.org/T351345 (10Ejegg) Could this change be the cause? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/968790 It seems right, but those ternary conditions can be tricky. Maybe let's rewr... [20:25:06] 10Fundraising Tech - Chaos Crew: fundraiseup_id is miss placed to venmo_user_name - https://phabricator.wikimedia.org/T351345 (10AnnWF) Oh we have venmo under fundraiseup, that's the issue, we need to add additional check if the gateway is fundraise up then ignore the check for venmo_user_name https://civicrm.wi... [21:03:57] (03CR) 10Damilare Adedoyin: [C: 03+2] Set outcome to retry to avoid the queue being set to aborted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974292 (https://phabricator.wikimedia.org/T350680) (owner: 10Eileen) [21:04:17] (03CR) 10Eileen: [C: 03+2] Coworker: Bump failing tasks to a damaged queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/973874 (https://phabricator.wikimedia.org/T350680) (owner: 10Damilare Adedoyin) [21:05:30] 10Fundraising-Backlog, 10FR-Japan, 10FR-donorservices: Japanese language form & TY page, but English TY email: recent tests - https://phabricator.wikimedia.org/T284608 (10AKanji-WMF) [21:06:34] 10Fundraising-Backlog, 10FR-Japan: Convert all encoded HTML name data for JP to UTF-8 - https://phabricator.wikimedia.org/T174190 (10AKanji-WMF) [21:07:22] 10Fundraising-Backlog, 10FR-Civi-Dedupe: Alternate name field for donors with different alphabet characters - https://phabricator.wikimedia.org/T275678 (10AKanji-WMF) FYI Moved to Sprint +2 based on upcoming Japan campaigns. Probably worth reviewing other Japanese-form specific issues - let us know @EMartin if... [21:15:43] 10Fundraising-Backlog, 10FR-Japan: Make the Japan "V1" payment wiki variant the new control - https://phabricator.wikimedia.org/T329807 (10HNordeenWMF) From looking at the [[ https://payments.wikimedia.org/index.php?title=Special:AdyenCheckoutGateway&appeal=JimmyQuote&country=JP¤cy=JPY&payment_method=cc&... [21:19:04] 10Fundraising-Backlog, 10FR-Japan: Make the Japan "V1" payment wiki variant the new control - https://phabricator.wikimedia.org/T329807 (10AKanji-WMF) Thanks for the ping, I was just reviewing the nickname question too. Moving to Sprint +2 for review. [21:19:53] (03Merged) 10jenkins-bot: Coworker: Bump failing tasks to a damaged queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/973874 (https://phabricator.wikimedia.org/T350680) (owner: 10Damilare Adedoyin) [21:19:55] (03Merged) 10jenkins-bot: Set outcome to retry to avoid the queue being set to aborted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974292 (https://phabricator.wikimedia.org/T350680) (owner: 10Eileen) [21:27:57] 10Fundraising Tech - Chaos Crew: fundraiseup_id is miss placed to venmo_user_name - https://phabricator.wikimedia.org/T351345 (10Ejegg) @AnnWF can we check the other way? So only if the gateway is Braintree and the method is venmo we use venmo_user_name, otherwise _id [21:45:44] dwisehaupt: I think we need to update staging - maybe over the weekend? [21:50:15] hmmm... ok. do you have a time when it can be done? i have a mix of different things going this weekend. [22:53:44] eileen: I'll be here for like 15 min more now, then will probably be back on in a few hours [23:20:05] dwisehaupt: it's not super heavily used so when it suits you is the best time [23:22:23] is there a date after which we need to wait? ie: is it possible to do thursday afternoon my time / friday morning your time? [23:22:57] i don't think there is much of an issue with taking staging for updates. [23:24:05] otherwise, i could probably do sometime around or after https://zonestamp.toolforge.org/1700346600 [23:39:51] dwisehaupt: that sounds fine - you could probably kick it off now if you wanted [23:40:29] oh. sure. that works. wasn't sure if there was something released later that we were waiting for. [23:47:27] nah - just might as well get us all in sync now [23:47:50] wfan: are you reviewing https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/973240 [23:48:22] checking [23:49:52] Oh right I was about to review that, but then cut off by that venmo customer data thing, do you need this to be review asap? [23:49:56] oh. i see. you are talking about a restore to the staging db. [23:50:14] yeah, we can kick that off to run over the weekend. [23:50:27] my brain was totally somewhere else on what was updating. [23:52:33] wfan: no - I poked around & thought about reviewing it & then saw that you might be [23:52:53] dwisehaupt: oh right - what were you thinking we were updating [23:53:27] i've just been so into testing the civi code updates on the community crm i was thinking it was a code update. :) [23:53:40] eileen: cool, I think you can review that if you want, also if you do not mind this is a fairly small update https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/973266 [23:53:46] my brain is tired today. too little sleep these last few weeks. [23:54:07] (03CR) 10Eileen: [C: 03+2] Do not use decline-recurring for logprefix, use donation_queue_process_message [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/973266 (https://phabricator.wikimedia.org/T350831) (owner: 10Wfan) [23:54:14] thx eileen [23:55:02] wfan: cool - I don't think your fix here quite worked https://github.com/civicrm/civicrm-core/pull/28069 - seems to have gone up to 6 commits & reverted the PR title :-) [23:55:33] maybe do a git pull --rebase origin/master & then git rebase -i origin/master [23:55:35] ah, yeah still try to figure our how to squash at civi-core pull cause I had mine's merged at my repo already [23:56:29] yeah 2 ways to squash really - either just reset to origin/master & re-do the commit or use git rebase -i origin/master - but best in both cases to do git pull --rebase origin master first [23:56:36] then you have to push with git push -f