[00:30:05] cstone: Coleman says this would fix you sk issue https://github.com/civicrm/civicrm-core/pull/28132 [00:30:34] Oh nice! I hadn't gotten back to messing around with the label [00:36:46] cstone: if you have a chance to test it & feed back on the PR it would encourage him to be this helpful next time :-) [00:42:00] back for a couple hrs of work at least [00:42:09] gonna deploy that civiproxy update [00:48:04] !log fundraising civiproxy upgraded from c000fc1e to 6625c844 [00:48:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:12:13] cool eileen I'll take a look [01:14:12] (03PS1) 10Cstone: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/975103 [01:15:54] (03CR) 10Cstone: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/975103 (owner: 10Cstone) [01:17:13] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/975103 (owner: 10Cstone) [01:19:00] !log payments-wiki upgraded from eae2f35e to 56790715 [01:19:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:23:31] 10Fundraising Sprint vvv - tell me more, 10Fundraising-Backlog, 10Wikipedia-iOS-App-Backlog, 10MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), and 2 others: Standardize utm_source from app donations without a banner and clean up old data - https://phabricator.wikimedia.org/T350919 (10Cstone) Talked to @JMando to... [01:24:38] ejegg: do you remember where the payment method ids in contribution_tracking are coming from, I can look too when I get back [01:24:49] Joseph was mentioning they weren't the ids he was expecting [02:10:02] (03PS1) 10Ejegg: Add recur upgrade link, shorten display [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975105 [02:10:04] (03PS1) 10Ejegg: Loosen up GetUpgradableRecur checks [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975106 [02:10:16] cstone: oh let me see [02:10:24] sorry, didn't see my pings [02:12:35] hmm, i see payment_method [02:13:01] that's in drupal/sites/default/civicrm/extensions/wmf-civicrm/xml/schema/CRM/Wmf/ContributionTracking.xml [02:13:31] so I'd check for a civicrm_option_group where name='payment_method'; [02:14:39] ok, I see that defined in extensions/wmf-civicrm/Managed/ContributionTrackingOptions.mgd.php [02:15:36] argh, jmando used to hang out in IRC [02:16:13] so... this discussion is somewhere in the twisty labyrinth of slack, i guess? [02:17:01] from https://phabricator.wikimedia.org/diffusion/WFCG/browse/master/drupal/sites/default/civicrm/extensions/wmf-civicrm/Managed/ContributionTrackingOptions.mgd.php$9 [02:17:06] down to line 240 [02:17:10] are the methods [02:17:48] and the values that show up in c_t table are the 'value' properties there [03:17:04] (03CR) 10Ejegg: "Thanks! Would you mind making this easier to read by spreading the conditions out across two or three lines?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974724 (https://phabricator.wikimedia.org/T351345) (owner: 10Wfan) [03:20:22] cstone: I think we need to make one more config change to /etc/smashpig/main.yaml to have the getPaymentMethods call actually be cached under redis, right? [03:20:44] since it's still using the LocalClusterCache [03:20:49] on paymentswiki [03:21:03] Oh hmm I saw it calming down once we deployed [03:21:07] ohhh [03:21:24] so I guess that LocalClusterCache actually is caching things [03:21:48] I guess I need to test locally with CACHE_ACCEL as we have in prod [03:22:00] to see how it's actually working when APCu isn't there [03:24:06] cstone: this might be a better link to share with jmando: https://civicrm.wikimedia.org/civicrm/admin/options?gid=162&reset=1 [08:06:58] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10SRE, 10vm-requests, 10Patch-For-Review: eqiad: 1 VM requested for community-crm - https://phabricator.wikimedia.org/T349402 (10MoritzMuehlenhoff) p:05Triage→03Medium [08:07:31] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10SRE, 10vm-requests, 10Patch-For-Review: eqiad: 1 VM requested for community-crm - https://phabricator.wikimedia.org/T349402 (10MoritzMuehlenhoff) [08:08:03] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10SRE, 10vm-requests, 10Patch-For-Review: eqiad: 1 VM requested for community-crm - https://phabricator.wikimedia.org/T349402 (10MoritzMuehlenhoff) [08:25:30] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10SRE, 10vm-requests, 10Patch-For-Review: eqiad: 1 VM requested for community-crm - https://phabricator.wikimedia.org/T349402 (10ops-monitoring-bot) Cookbook cookbooks.sre.hosts.reimage was started by jmm@cumin1001 for host crm2001.codfw.wmnet with OS... [09:01:22] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10SRE, 10vm-requests: eqiad: 1 VM requested for community-crm - https://phabricator.wikimedia.org/T349402 (10ops-monitoring-bot) Cookbook cookbooks.sre.hosts.reimage started by jmm@cumin1001 for host crm2001.codfw.wmnet with OS bookworm completed: - crm... [10:25:51] 10Fundraising-Backlog: No 2023-11-14 Fundraise Up donations in Civi - https://phabricator.wikimedia.org/T351295 (10Pcoombe) Great, thanks @Damilare! [10:27:48] 10Fundraising Sprint vvv - tell me more, 10Fundraising-Backlog, 10Wikipedia-iOS-App-Backlog, 10MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), and 2 others: Standardize utm_source from app donations without a banner and clean up old data - https://phabricator.wikimedia.org/T350919 (10Pcoombe) Sounds good to me,... [11:11:49] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10SRE, 10vm-requests, 10Patch-For-Review: eqiad: 1 VM requested for community-crm - https://phabricator.wikimedia.org/T349402 (10MoritzMuehlenhoff) 05Open→03Resolved a:03MoritzMuehlenhoff crm2001.codfw.wmnet has been created and configured to al... [12:44:54] (03CR) 10Jgleeson: [C: 03+2] Contribution Import Refactor: combine recurring processing code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971212 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [12:45:21] oops clicked the wrong button. that was meant to be rebase :) [12:45:26] let's undo that [14:35:44] (03PS10) 10Jgleeson: Contribution Import Refactor: combine recurring processing code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971212 (https://phabricator.wikimedia.org/T240581) [14:44:42] (03PS1) 10Jgleeson: Recurring Queue restructure: Move subscription handling to a separate class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975286 (https://phabricator.wikimedia.org/T240581) [14:44:44] (03PS1) 10Jgleeson: Recurring Queue restructure: Move contribution import to a separate class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975287 (https://phabricator.wikimedia.org/T240581) [14:44:46] (03PS1) 10Jgleeson: Recurring Queue restructure: Return types and method reordering [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975288 (https://phabricator.wikimedia.org/T240581) [14:57:00] 10Fundraising-Backlog: Community CRM - Make full list of languages available to custom fields - https://phabricator.wikimedia.org/T351533 (10AKanji-WMF) [14:57:33] 10Fundraising-Backlog: Community CRM - Make full list of languages available to custom fields - https://phabricator.wikimedia.org/T351533 (10AKanji-WMF) p:05Triage→03High [15:00:14] (03PS2) 10Jgleeson: Recurring Queue restructure: Move contribution import to a separate class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975287 (https://phabricator.wikimedia.org/T240581) [15:00:16] (03PS2) 10Jgleeson: Recurring Queue restructure: Return types and method reordering [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975288 (https://phabricator.wikimedia.org/T240581) [16:07:04] (03PS2) 10Jgleeson: Recurring Queue restructure: Move subscription handling to a separate class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975286 (https://phabricator.wikimedia.org/T240581) [16:07:06] (03PS3) 10Jgleeson: Recurring Queue restructure: Move contribution import to a separate class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975287 (https://phabricator.wikimedia.org/T240581) [16:07:08] (03PS3) 10Jgleeson: Recurring Queue restructure: Return types and method reordering [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975288 (https://phabricator.wikimedia.org/T240581) [16:13:52] (03PS3) 10Jgleeson: Recurring Queue restructure: Move subscription handling to a separate class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975286 (https://phabricator.wikimedia.org/T240581) [16:13:54] (03PS4) 10Jgleeson: Recurring Queue restructure: Move contribution import to a separate class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975287 (https://phabricator.wikimedia.org/T240581) [16:13:56] (03PS4) 10Jgleeson: Recurring Queue restructure: Return types and method reordering [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/975288 (https://phabricator.wikimedia.org/T240581) [16:49:32] 10Fundraising-Backlog: Edit post-payments monthly convert threshold for USD/CAD/AUD/NZD - https://phabricator.wikimedia.org/T351553 (10Pcoombe) [16:54:09] (03PS1) 10Pcoombe: Change USD (and CAD etc) monthly convert threshold to $3 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/975338 (https://phabricator.wikimedia.org/T351553) [16:55:26] fr-tech: ^ hopefully a nice simple one for somebody, would be great if we can get that done before Big English. thanks! [16:55:38] looking pcoombe [16:56:54] (03CR) 10Jgleeson: [C: 03+2] "Looks good to me! thanks" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/975338 (https://phabricator.wikimedia.org/T351553) (owner: 10Pcoombe) [16:59:46] (03PS14) 10Jgleeson: WIP: Donation Queue Updates: Process recurring payments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969975 (https://phabricator.wikimedia.org/T240581) [17:07:23] (03PS2) 10Wfan: For fundraiseup venmo, save fundraiseup_id instead of venmo_user_name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974724 (https://phabricator.wikimedia.org/T351345) [17:12:58] (03Merged) 10jenkins-bot: Change USD (and CAD etc) monthly convert threshold to $3 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/975338 (https://phabricator.wikimedia.org/T351553) (owner: 10Pcoombe) [17:17:06] (03CR) 10CI reject: [V: 04-1] WIP: Donation Queue Updates: Process recurring payments [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/969975 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [18:04:10] (03CR) 10Wfan: For fundraiseup venmo, save fundraiseup_id instead of venmo_user_name (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974724 (https://phabricator.wikimedia.org/T351345) (owner: 10Wfan) [18:29:44] (03CR) 10Jgleeson: "Thanks for this. I've suggested a slight tweak to your update. Lemme know what you think!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974724 (https://phabricator.wikimedia.org/T351345) (owner: 10Wfan) [18:32:55] (03PS3) 10Wfan: For fundraiseup venmo, save fundraiseup_id instead of venmo_user_name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974724 (https://phabricator.wikimedia.org/T351345) [18:33:28] (03CR) 10Wfan: For fundraiseup venmo, save fundraiseup_id instead of venmo_user_name (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974724 (https://phabricator.wikimedia.org/T351345) (owner: 10Wfan) [18:41:44] (03CR) 10Jgleeson: [C: 03+2] "Thanks! this looks good to me :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974724 (https://phabricator.wikimedia.org/T351345) (owner: 10Wfan) [18:50:45] Thanks Jack :) [18:58:21] (03Merged) 10jenkins-bot: For fundraiseup venmo, save fundraiseup_id instead of venmo_user_name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/974724 (https://phabricator.wikimedia.org/T351345) (owner: 10Wfan) [19:51:37] 10Fundraising-Backlog: Community CRM - Make full list of languages available to custom fields - https://phabricator.wikimedia.org/T351533 (10AKanji-WMF) @Eileenmcnaughton could you please have a look next week and help us determine the steps to address? cc: @Dwisehaupt [20:00:24] 10Fundraising-Backlog: Community CRM - Make full list of languages available to custom fields - https://phabricator.wikimedia.org/T351533 (10Dwisehaupt) @Qgil When looking at the related civi issue (https://lab.civicrm.org/dev/core/-/issues/4404) it appears we may be able to do this using sql directly. Do you ha... [22:10:07] 10Fundraising Sprint vvv - tell me more, 10Fundraising-Backlog: Creating an new import for Overflow.co for Stock and DAF gifts - https://phabricator.wikimedia.org/T349930 (10MDemosWMF) I've got WMF and END stock import templates saved in Civi. There area few things I've noticed: - Can we set the rules at t... [23:40:27] (03CR) 10Ejegg: "I've just started to look this over. Mostly seems good (and easier to follow!) but I have one concern about the $is_initial_recurring_cont" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/971212 (https://phabricator.wikimedia.org/T240581) (owner: 10Jgleeson) [23:49:16] 10Fundraising Sprint Uptown cURL, 10Fundraising Sprint vvv - tell me more, 10Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations: Get CiviProxy -> CiviCRM auth working in production for API4 calls - https://phabricator.wikimedia.org/T349946 (10Ejegg) Oops, now in production we're getting "SECU...