[00:21:49] 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.9; 2023-12-12): Venmo monthly convert showing new screen - https://phabricator.wikimedia.org/T352341 (10Cstone) [00:57:21] 10Fundraising-Backlog: Move payment method monthly convert config into actual config - https://phabricator.wikimedia.org/T352351 (10Cstone) [02:45:44] 10Fundraising-Backlog, 10Wikipedia-iOS-App-Backlog, 10iOS Release FY2023-24: Don't show in-app apple pay banners when apple pay region is CN - https://phabricator.wikimedia.org/T352180 (10Ejegg) Hi @Tsevener, I think the geoIP targeting is working as intended, otherwise we'd probably see a lot more of these... [03:19:08] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: We still have an issue with Paypal CID gran donations coming in through blocked CIVI CID - https://phabricator.wikimedia.org/T351342 (10Ejegg) Hi @MDemosWMF I'm afraid I don't see any results on that search link - I think it only worked for your login ses... [03:21:52] 10Fundraising Sprint - Wake me up when December ends, 10Fundraising Sprint Uptown cURL, 10Fundraising Sprint vvv - tell me more, 10Fundraising-Backlog, and 4 others: donate.wikimedia.org landing pages don't have descriptions in search engine results - https://phabricator.wikimedia.org/T254808 (10Ejegg) I g... [03:26:54] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: donation amount discrepancy between Adyen + Civi - https://phabricator.wikimedia.org/T352063 (10Ejegg) Hi @MBeat33 we found the bug and I think we've fixed it. So it looks like the donor had initially chosen 36.80, but the code to s... [03:55:39] looks like queue load isn't soo crazy right now. I might re-run the adyen audit parser to see if it can clear out the other file that had the extra column [04:03:33] 10Fundraising Sprint - Wake me up when December ends, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.42-notes (1.42.0-wmf.7; 2023-11-28): Accept wmf_ versions of utm_* parameters in DonationInterface - https://phabricator.wikimedia.org/T351326 (10Ejegg) This was deployed last week. [04:04:22] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: donation amount discrepancy between Adyen + Civi - https://phabricator.wikimedia.org/T352063 (10MBeat33) Many thanks for the context and the patch, @Ejegg > the problem will only show up with a few oddly specific amounts that migh... [07:51:32] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_40) - 10https://gerrit.wikimedia.org/r/978784 (owner: 10L10n-bot) [14:13:22] 10Fundraising Sprint - Wake me up when December ends, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Form variant with lock icon next to credit card number label - https://phabricator.wikimedia.org/T348339 (10Damilare) a:03Damilare [14:14:19] 10Fundraising-Backlog, 10Wikipedia-iOS-App-Backlog, 10iOS Release FY2023-24: Don't show in-app apple pay banners when apple pay region is CN - https://phabricator.wikimedia.org/T352180 (10Tsevener) a:03Tsevener [14:14:36] 10Fundraising-Backlog, 10WMF-NDA, 10acl*WMF-FR: Community CRM - Location fields in Contact Layout Summary give error or don't save data - https://phabricator.wikimedia.org/T351841 (10Qgil) Just to confirm that I still can reproduce this bug. As described, it doesn't throw any errors as admin. This is what I... [15:12:27] 10Fundraising-Backlog, 10Wikipedia-iOS-App-Backlog, 10iOS Release FY2023-24: Don't show in-app apple pay banners when apple pay region is CN - https://phabricator.wikimedia.org/T352180 (10Tsevener) https://github.com/wikimedia/wikipedia-ios/pull/4686 [15:52:21] 10Fundraising Sprint - Wake me up when December ends, 10Fundraising Sprint Uptown cURL, 10Fundraising Sprint vvv - tell me more, 10Fundraising-Backlog, and 4 others: donate.wikimedia.org landing pages don't have descriptions in search engine results - https://phabricator.wikimedia.org/T254808 (10Pcoombe) S... [15:53:34] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: We still have an issue with Paypal CID gran donations coming in through blocked CIVI CID - https://phabricator.wikimedia.org/T351342 (10MDemosWMF) @Ejegg Ah sorry about that! If you search that CIDs last name, first name in Civi you will see a bunch of d... [16:25:21] (03PS1) 10Damilare Adedoyin: Form variant with lock icon next to credit card number label [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979128 (https://phabricator.wikimedia.org/T348339) [16:27:18] (03CR) 10CI reject: [V: 04-1] Form variant with lock icon next to credit card number label [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979128 (https://phabricator.wikimedia.org/T348339) (owner: 10Damilare Adedoyin) [16:29:57] (03PS2) 10Damilare Adedoyin: Form variant with lock icon next to credit card number label [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979128 (https://phabricator.wikimedia.org/T348339) [16:32:35] (03CR) 10CI reject: [V: 04-1] Form variant with lock icon next to credit card number label [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979128 (https://phabricator.wikimedia.org/T348339) (owner: 10Damilare Adedoyin) [16:33:26] (03PS3) 10Damilare Adedoyin: Form variant with lock icon next to credit card number label [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979128 (https://phabricator.wikimedia.org/T348339) [16:40:49] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: We still have an issue with Paypal CID gran donations coming in through blocked CIVI CID - https://phabricator.wikimedia.org/T351342 (10Ejegg) OK, I found the lines in the audit file that are creating those duplicates. They've dropped the email address, b... [16:53:23] 10Fundraising-Backlog: Uncaught TypeError: Cannot read properties of undefined (reading 'origin') - https://phabricator.wikimedia.org/T352458 (10jgleeson) [16:53:57] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: We still have an issue with Paypal CID gran donations coming in through blocked CIVI CID - https://phabricator.wikimedia.org/T351342 (10Ejegg) OK, added that payer ID to the block list. [16:54:55] 10Fundraising Sprint - Wake me up when December ends, 10Fundraising Sprint Uptown cURL, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Matching EFT imports - not creating employer/employee relationship - https://phabricator.wikimedia.org/T349550 (10MDemosWMF) @AKanji-WMF @Eileenmcnaughton This is... [17:01:49] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Uncaught ERROR: One or more securedFields has just loaded new content. This should never happen (but it did, 10 times) - https://phabricator.wikimedia.org/T352459 (10jgleeson) [17:06:31] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Uncaught ERROR: One or more securedFields has just loaded new content. This should never happen (but it did, 10 times) - https://phabricator.wikimedia.org/T352459 (10jgleeson) I scanned across our code to see if this is something we added, and I don't thi... [17:06:33] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: We still have an issue with Paypal CID gran donations coming in through blocked CIVI CID - https://phabricator.wikimedia.org/T351342 (10MDemosWMF) Thanks Elliott! I have deleted all of the duplicate records as well. [17:24:42] 10Fundraising-Backlog: Uncaught TypeError: Cannot read properties of undefined (reading 'origin') - https://phabricator.wikimedia.org/T352458 (10AKanji-WMF) p:05Triage→03Low [17:30:51] 10Fundraising-Backlog: Move payment method monthly convert config into actual config - https://phabricator.wikimedia.org/T352351 (10Cstone) [17:31:44] 10Fundraising-Backlog: Move payment method monthly convert config into actual config - https://phabricator.wikimedia.org/T352351 (10AKanji-WMF) linked to https://phabricator.wikimedia.org/T352340 [17:34:29] 10Fundraising-Backlog: Move payment method monthly convert config into actual config - https://phabricator.wikimedia.org/T352351 (10Cstone) [17:34:32] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Monthly convert at a payment method level should be configured in yaml - https://phabricator.wikimedia.org/T352340 (10Cstone) [17:42:31] 10Fundraising-Backlog: Cannot update the option value of a custom field - https://phabricator.wikimedia.org/T352343 (10AKanji-WMF) p:05Triage→03Medium We talked about this in triage @Eileenmcnaughton , happy to catch you up [17:47:30] 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.9; 2023-12-12): Venmo monthly convert - new screen when accepting and email when decliing - https://phabricator.wikimedia.org/T352341 (10Cstone) [17:53:43] 10Fundraising Sprint - Wake me up when December ends, 10Fundraising Sprint Uptown cURL, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Matching EFT imports - not creating employer/employee relationship - https://phabricator.wikimedia.org/T349550 (10EMartin) @XenoRyet Per my Slack out reach. Please... [17:53:49] (03PS1) 10Wfan: Update params after refetch data to make sure queue get message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979139 (https://phabricator.wikimedia.org/T352235) [17:54:18] (03CR) 10CI reject: [V: 04-1] Update params after refetch data to make sure queue get message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979139 (https://phabricator.wikimedia.org/T352235) (owner: 10Wfan) [17:57:35] (03PS2) 10Wfan: Update params after refetch data to make sure queue get message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979139 (https://phabricator.wikimedia.org/T352235) [18:01:33] 10Fundraising-Backlog: Matching Check imports - not creating employer/employee relationship - https://phabricator.wikimedia.org/T349858 (10XenoRyet) Reopening as this is a different issue and not a duplicate. [18:01:42] 10Fundraising-Backlog: Matching Check imports - not creating employer/employee relationship - https://phabricator.wikimedia.org/T349858 (10XenoRyet) 05duplicate→03Open p:05Triage→03High [18:01:57] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Matching Check imports - not creating employer/employee relationship - https://phabricator.wikimedia.org/T349858 (10XenoRyet) [18:03:33] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Uncaught ERROR: One or more securedFields has just loaded new content. This should never happen (but it did, 10 times) - https://phabricator.wikimedia.org/T352459 (10XenoRyet) p:05Triage→03Low [18:48:10] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Test adding WMF logo to donation form on mobile - https://phabricator.wikimedia.org/T183574 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF As far as I can tell we now include this logo on mobile forms. Closing! [18:57:29] 10Fundraising-Backlog: Add logo & formatting to TY emails from Civi - https://phabricator.wikimedia.org/T352466 (10AKanji-WMF) [19:12:08] (03PS3) 10Wfan: Update params after refetch data to make sure queue get message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979139 (https://phabricator.wikimedia.org/T352235) [19:12:33] (03CR) 10CI reject: [V: 04-1] Update params after refetch data to make sure queue get message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979139 (https://phabricator.wikimedia.org/T352235) (owner: 10Wfan) [19:17:51] (03PS4) 10Wfan: Update params after refetch data to make sure queue get message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979139 (https://phabricator.wikimedia.org/T352235) [19:19:45] (03CR) 10Jgleeson: [C: 04-1] "This works! In the sense that it finds the email address if it's not set." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979139 (https://phabricator.wikimedia.org/T352235) (owner: 10Wfan) [19:31:59] (03PS1) 10Umherirrender: tests: Replace assertRegExp with assertMatchesRegularExpression [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979152 (https://phabricator.wikimedia.org/T320334) [19:33:42] (03CR) 10CI reject: [V: 04-1] tests: Replace assertRegExp with assertMatchesRegularExpression [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979152 (https://phabricator.wikimedia.org/T320334) (owner: 10Umherirrender) [19:39:53] (03PS2) 10Umherirrender: tests: Replace assertRegExp with assertMatchesRegularExpression [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979152 (https://phabricator.wikimedia.org/T320334) [19:41:19] (03PS3) 10Umherirrender: tests: Replace assertRegExp with assertMatchesRegularExpression [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979152 (https://phabricator.wikimedia.org/T320334) [19:42:36] (03PS4) 10Umherirrender: tests: Replace assertRegExp with assertMatchesRegularExpression [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979152 (https://phabricator.wikimedia.org/T320334) [19:56:12] (03PS5) 10Wfan: Update params after refetch data to make sure queue get message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979139 (https://phabricator.wikimedia.org/T352235) [19:56:39] (03CR) 10CI reject: [V: 04-1] Update params after refetch data to make sure queue get message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979139 (https://phabricator.wikimedia.org/T352235) (owner: 10Wfan) [20:03:41] (03CR) 10Ejegg: [C: 03+2] "Thanks, this works great" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979128 (https://phabricator.wikimedia.org/T348339) (owner: 10Damilare Adedoyin) [20:06:09] (03PS2) 10Ejegg: Ensure gross value is not empty in the refund messages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/978632 (https://phabricator.wikimedia.org/T351822) (owner: 10Damilare Adedoyin) [20:07:01] (03CR) 10Ejegg: [C: 03+2] "This looks like a good sanity check! Let's also see if we can catch the bad values even earler, right at the IPN processing job." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/978632 (https://phabricator.wikimedia.org/T351822) (owner: 10Damilare Adedoyin) [20:09:58] (03PS6) 10Wfan: Update params after refetch data to make sure queue get message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979139 (https://phabricator.wikimedia.org/T352235) [20:10:26] (03CR) 10CI reject: [V: 04-1] Update params after refetch data to make sure queue get message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979139 (https://phabricator.wikimedia.org/T352235) (owner: 10Wfan) [20:14:35] (03PS7) 10Wfan: Update params after refetch data to make sure queue get message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979139 (https://phabricator.wikimedia.org/T352235) [20:15:09] (03PS8) 10Wfan: Update params after refetch data to make sure queue get message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979139 (https://phabricator.wikimedia.org/T352235) [20:16:59] 10Fundraising Tech - Chaos Crew, 10Patch-For-Review: Ensure gross value is not empty in the refund messages - https://phabricator.wikimedia.org/T351822 (10Ejegg) Ah, looks like we're parsing the correct one out of the settlement_detail batch and the incorrect one out of the payments_accounting batch [20:20:37] (03Merged) 10jenkins-bot: Form variant with lock icon next to credit card number label [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979128 (https://phabricator.wikimedia.org/T348339) (owner: 10Damilare Adedoyin) [20:23:37] (03Merged) 10jenkins-bot: Ensure gross value is not empty in the refund messages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/978632 (https://phabricator.wikimedia.org/T351822) (owner: 10Damilare Adedoyin) [21:11:30] ugh weird timezone issue with date in adyen report? [21:44:12] wfan do you mind if I just edit the commit message headline on that patch? [21:44:26] sure [21:45:10] go ahead ~ Thanks elloitt~ [21:46:28] (03PS9) 10Ejegg: Refactor code to fetch missing email for Venmo [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979139 (https://phabricator.wikimedia.org/T352235) (owner: 10Wfan) [21:48:18] (03CR) 10Ejegg: [C: 03+2] Refactor code to fetch missing email for Venmo [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979139 (https://phabricator.wikimedia.org/T352235) (owner: 10Wfan) [21:48:50] (03Merged) 10jenkins-bot: Refactor code to fetch missing email for Venmo [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979139 (https://phabricator.wikimedia.org/T352235) (owner: 10Wfan) [21:49:00] thx~ I will do the smashpig update and deploy after that [21:49:52] actually for di we do not need to update smashpig [21:50:03] haha, so just deploy smashpig, then di will use the new code [21:51:18] hmm do we need to bump the smashpig version in DI though? [21:51:53] cstone want to take a quick look at https://gerrit.wikimedia.org/r/979166 once i update the date in that test? [21:52:03] sure ejegg [21:52:06] if we're going to cut a new version [21:54:07] do these missing info chargebacks not show up in the weekly one? [21:54:25] oh i see on the phav [21:54:26] b [21:54:35] (03PS2) 10Ejegg: Fix chargeback parsing in Adyen accounting report [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979166 (https://phabricator.wikimedia.org/T351822) [21:54:59] (03CR) 10CI reject: [V: 04-1] Fix chargeback parsing in Adyen accounting report [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979166 (https://phabricator.wikimedia.org/T351822) (owner: 10Ejegg) [21:55:42] eww, 13.430000000000001 /is/ gross [21:58:21] (03PS3) 10Ejegg: Fix chargeback parsing in Adyen accounting report [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/979166 (https://phabricator.wikimedia.org/T351822) [21:58:23] looks like an office space bug [21:59:13] (03PS1) 10Wfan: Update required version of SmashPig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/978660 [22:00:14] ah did you already tag a new version wfan? [22:00:34] ok, no rush on that audit thing then [22:00:54] oh if you want to catch the deployment we can tag a new one~ [22:01:06] I have not yet merge this smashpig tag in di [22:01:09] ah okay well I made a test file I'll see what I can done before I have to leave [22:01:55] but if no rush, then we do deploy later, I will plus 2 this one first [22:02:05] (03CR) 10Wfan: [C: 03+2] Update required version of SmashPig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/978660 (owner: 10Wfan) [22:05:09] wfan no need, my patch would be used under the crm not di anyway [22:05:19] ok [22:10:43] (03PS1) 10Wfan: Update DonationInterface and vendor submodules [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/979171 [22:18:45] (03Merged) 10jenkins-bot: Update required version of SmashPig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/978660 (owner: 10Wfan) [22:27:36] (03CR) 10Wfan: [C: 03+2] Update DonationInterface and vendor submodules [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/979171 (owner: 10Wfan) [22:36:06] (03Merged) 10jenkins-bot: Update DonationInterface and vendor submodules [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/979171 (owner: 10Wfan) [22:44:49] 10Fundraising Sprint - Wake me up when December ends, 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Update thank you main & endowment mail to use new stock fields - https://phabricator.wikimedia.org/T350331 (10MDemosWMF) @Eileenmcnaughton th... [22:46:12] !log payments-wiki upgraded from 7feabffe to b37ab50e [22:46:16] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log