[01:41:10] 10Fundraising Sprint - Wake me up when December ends, 10Fundraising Sprint Uptown cURL, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Matching EFT imports - not creating employer/employee relationship - https://phabricator.wikimedia.org/T349550 (10Eileenmcnaughton) @MDemosWMF the relationship cre... [06:35:55] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/978233 (owner: 10L10n-bot) [06:42:28] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_40) - 10https://gerrit.wikimedia.org/r/978784 (owner: 10L10n-bot) [15:49:36] 10Fundraising Sprint - Wake me up when December ends, 10Fundraising Sprint Uptown cURL, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Matching EFT imports - not creating employer/employee relationship - https://phabricator.wikimedia.org/T349550 (10MDemosWMF) @Eileenmcnaughton the IDs for the chec... [17:17:06] 10Fundraising-Backlog: Add logo & formatting to TY emails from Civi - https://phabricator.wikimedia.org/T352466 (10AKanji-WMF) These would now be edited in the messaging template area in Civi - could potentially test out templates and what's possible in terms of editing. [19:35:53] Got it https://usercontent.irccloud-cdn.com/file/wc75dNsH/1701459345.JPG [19:36:01] Oh wrong channel [19:48:11] 10Fundraising-Backlog: Cannot update the option value of a custom field - https://phabricator.wikimedia.org/T352343 (10MDemosWMF) @Anil1956 I was just notified by @JAdams that the gift source Realized Bequest is now removed from all gifts that previously had that gift source. Is there work being done related to... [19:49:33] 10Fundraising-Backlog: Cannot update the option value of a custom field - https://phabricator.wikimedia.org/T352343 (10MDemosWMF) @AKanji-WMF I was just notified by @JAdams that the gift source Realized Bequest is now removed from all gifts that previously had that gift source. Is there work being done related t... [20:02:11] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Matching Check imports - not creating employer/employee relationship - https://phabricator.wikimedia.org/T349858 (10Ejegg) @MDemosWMF I'm coming into this with a little bit less familiarity than @Eileenmcnaughton . Can you confirm that this ticket is rega... [20:02:55] fr-tech does anyone else see results from those two search displays linked on the matching check imports phab? ^^^ [20:03:22] I click either one and just get a blank-ish screen (i/drupal.e. just civi menus) [20:03:46] should have read (i.e. just civi/drupal menus) [20:04:30] Yeah same I see blackish screen [20:04:38] Blank [20:05:33] hmm ok [20:07:48] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Matching Check imports - not creating employer/employee relationship - https://phabricator.wikimedia.org/T349858 (10MDemosWMF) @Ejegg No these are using the import mapping tool. They're check matching gifts processed through Engage not the Benevity gifts... [20:09:14] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Matching Check imports - not creating employer/employee relationship - https://phabricator.wikimedia.org/T349858 (10Ejegg) Thanks @MDemosWMF , that shows me where to start looking. [20:19:03] cstone huh at first glance that looks like it should use the same code to make the employer relationship as the other import which Eileen fixed [20:19:13] I guess I need to look at some data [20:20:02] ejegg: yeah - I tried to check the soft credit type in use on the other ticket [20:20:38] ah ok you're already looking into it? [20:20:58] so would that soft credit type depend on an entry in the uploaded spreadsheet? [20:21:00] No - I only commented on the other phab to try to check the type - but if it is benevity I guess it's in-code [20:21:35] eileen: so it's not benevity, it's the other 'core' import with the ' import_Matching Gifts Individuals ' template [20:21:48] as i understand mdemos' last comment on the ticket [20:25:39] yeah - the phab is confusing cos it links to 2 imports that were done before the fix I think [20:27:03] so one thing to try (if she hasn't deleted the soft credit) is editing it & seeing if that triggers the post hook to create the relationship [20:30:10] it didn't seem to [20:35:31] (03PS1) 10Ejegg: Don't always send multi_use for Venmo [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979413 (https://phabricator.wikimedia.org/T352341) [20:35:45] cstone: so something like this? ^^^ [20:36:11] i was able to replicate the screen locally ejegg but looks like that doesn't fix it or well trying to debug now [20:36:13] * ejegg still hasn't tested a venmo payment :S [20:36:23] not sure if its cached [20:37:09] eileen: ok, so you are also under the impression that the check import should be creating the relationships via the same hook as the EFT import? [20:37:32] ejegg: yep [20:38:21] 10fundraising-tech-ops: Test task for automation - https://phabricator.wikimedia.org/T324628 (10Dwisehaupt) [20:38:23] 10fundraising-tech-ops: Test task for automation - https://phabricator.wikimedia.org/T324628 (10Dwisehaupt) [20:38:25] 10fundraising-tech-ops: Test task for automation - https://phabricator.wikimedia.org/T324628 (10Dwisehaupt) [20:38:27] 10fundraising-tech-ops: Test task for automation - https://phabricator.wikimedia.org/T324628 (10Dwisehaupt) [20:38:29] 10fundraising-tech-ops: Test task for automation - https://phabricator.wikimedia.org/T324628 (10Dwisehaupt) [20:53:47] (03CR) 10Cstone: [C: 03+2] "This works for flipping the language of the authorization screen" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979413 (https://phabricator.wikimedia.org/T352341) (owner: 10Ejegg) [20:54:04] ^ I'll deploy that and then make a follow up task to fix it for monthly convert [21:01:34] 10Fundraising-Backlog: Update post-payments monthly convert threshold - https://phabricator.wikimedia.org/T352575 (10spatton) [21:02:57] 10Fundraising-Backlog: Update post-payments monthly convert threshold - https://phabricator.wikimedia.org/T352575 (10spatton) [21:03:35] (03Merged) 10jenkins-bot: Don't always send multi_use for Venmo [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979413 (https://phabricator.wikimedia.org/T352341) (owner: 10Ejegg) [21:03:51] 10Fundraising-Backlog: Cannot update the option value of a custom field - https://phabricator.wikimedia.org/T352343 (10MDemosWMF) @JAdams opened a separate ticket for the issue here T352574 [21:09:34] (03PS1) 10Cstone: Lower monthly convert threshold to 2.74 for USD,AUD,CAD, and NZD [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979416 (https://phabricator.wikimedia.org/T352575) [21:11:53] fr-tech if someone wants to review ^ its a tiny change to monthly convert lowest amount, I'll get it out with the venmo fix [21:12:59] sure thing cstone [21:13:28] (03CR) 10Ejegg: [C: 03+2] Lower monthly convert threshold to 2.74 for USD,AUD,CAD, and NZD [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979416 (https://phabricator.wikimedia.org/T352575) (owner: 10Cstone) [21:13:36] thanks ejegg ! [21:20:01] (03Merged) 10jenkins-bot: Lower monthly convert threshold to 2.74 for USD,AUD,CAD, and NZD [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/979416 (https://phabricator.wikimedia.org/T352575) (owner: 10Cstone) [21:22:42] (03PS1) 10Cstone: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/979417 [21:23:38] hmm that has the smashpig bump in it was that supposed to go out yesterday? [21:24:26] (03CR) 10Cstone: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/979417 (owner: 10Cstone) [21:24:53] oh huh, looks like yesterday the vendor dir did go out [21:29:27] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/979417 (owner: 10Cstone) [21:31:00] hmm a bunch of tests got deleted on that deploy [21:31:03] but how did they get there [21:31:11] !log payments-wiki upgraded from b37ab50e to 5284fc99 [21:31:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:46:50] 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.9; 2023-12-12): Venmo monthly convert - new screen when accepting and email when decliing - https://phabricator.wikimedia.org/T352341 (10Cstone) We switched the setting venmo sends on create to only send multi_use for new recurrings. This setting is what contr... [22:06:11] cstone tests just in the vendor dir? Or in DI, I guess from a previous deployment merge ? [22:06:20] no big deal either way [22:06:40] yeah i guess curious how they got there [22:07:30] hmm, deployment branch of DI looks clean to me [22:07:46] if it's in the vendor dir, that's normal, we tag the SmashPig version on the master branch [22:08:22] ohhh, but someone tagged one of the smashpig versions from the deployment branch [22:09:09] wait, i'm confused [22:09:34] v0.8.9.3 shows up in my pretty git log on both master and deployment [22:10:07] seems to have tests when I explicitly check it out tho [22:10:09] shrug [22:41:15] 10Fundraising-Backlog: Cannot update the option value of a custom field - https://phabricator.wikimedia.org/T352343 (10Eileenmcnaughton) OK - in the database the value for that is `Realized_PG_Gift` MariaDB [civicrm]> select name,value,label FROM civicrm_option_value WHERE option_group_Id = 38; +---------------... [22:47:13] 10Fundraising-Backlog: Cannot update the option value of a custom field - https://phabricator.wikimedia.org/T352343 (10Eileenmcnaughton) @MDemosWMF we didn't take any action related to this ticket - so that is unrelated But, this is a feature not a bug - once the value is set it should not be changed - it's up... [23:12:11] (03PS1) 10Eileen: Fix option_value.value for Realized_Bequest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/979429 (https://phabricator.wikimedia.org/T352574)