[00:16:49] (03PS1) 10Eileen: Log if checksum rejected [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980513 [00:17:02] !log civicrm upgraded from 297a091d to d8238788 [00:17:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:30:46] (03CR) 10Cstone: [C: 03+2] Log if checksum rejected [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980513 (owner: 10Eileen) [00:30:48] (03PS1) 10Eileen: Add more logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980515 [00:32:21] (03PS2) 10Eileen: Add more logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980515 [00:33:22] (03CR) 10Cstone: [C: 03+2] Add more logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980515 (owner: 10Eileen) [00:33:34] (03CR) 10CI reject: [V: 04-1] Add more logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980515 (owner: 10Eileen) [00:35:24] (03CR) 10CI reject: [V: 04-1] Add more logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980515 (owner: 10Eileen) [00:37:00] (03PS3) 10Eileen: Add more logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980515 [00:47:57] (03Merged) 10jenkins-bot: Log if checksum rejected [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980513 (owner: 10Eileen) [00:51:54] cstone: I crashed out - should I jump back on [00:52:26] only if you want to I think I found my configandlog in buildkit? not sure if its old or not [00:52:39] :-) [00:53:06] oooh it is there [00:53:55] but thats the whole stack trace [00:54:05] ok well jenkins is happy [00:54:12] (03CR) 10Cstone: [C: 03+2] Add more logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980515 (owner: 10Eileen) [00:55:39] yay [01:29:23] cstone: I'm not seeing my updated error - gonna try to merge the 2 lines [01:30:46] (03PS1) 10Eileen: Try again with logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980518 [01:30:49] ^^ [01:37:35] or ejegg [02:02:30] 10Fundraising-Backlog: Matching Gift information link broken - https://phabricator.wikimedia.org/T352771 (10EMartin) @Ejegg Hi Elliott. I'm personally doing the matching right now with Rakhi (not Melanie) and it I think we should have the donor search again. I think send the emails with a less convenient link.... [02:03:05] back now eileen [02:04:02] (03CR) 10Cstone: [C: 03+2] Try again with logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980518 (owner: 10Eileen) [02:04:05] cool - [02:04:25] (03CR) 10Eileen: [V: 03+2] Try again with logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980518 (owner: 10Eileen) [02:06:57] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/980520 [02:07:07] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/980520 (owner: 10Eileen) [02:07:36] (03CR) 10Eileen: [V: 03+2 C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/980520 (owner: 10Eileen) [02:08:12] !log civicrm upgraded from 7fb98ee8 to 6bb8a67f [02:08:14] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:10:36] dang it truncates the exception back trace -#11 {main} = #0 /srv/org.wikimedia.civicrm/drupal/sites/all/modules/civicrm/Civi/API/Kernel.php(151): CRM_Core_Error::backtrace("API Request Authorization failedgetUpgradableRecur ContributionRecur\n#0 /srv...", TRUE) [02:16:28] (03PS1) 10Eileen: OK - more better trace [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980521 [02:16:35] cstone: still trying [02:16:37] ^^ [02:19:07] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog: Import bug - https://phabricator.wikimedia.org/T352720 (10AKanji-WMF) [02:19:09] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Suppress failmail on contribution tracking contraint violations - https://phabricator.wikimedia.org/T352321 (10AKanji-WMF) [02:19:12] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog: Sprint W - Priorities - https://phabricator.wikimedia.org/T351767 (10AKanji-WMF) [02:19:14] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Test sending from staging with CiviMail & then on live using fr-tech as recipients - https://phabricator.wikimedia.org/T352138 (10AKanji-WMF) [02:19:16] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog: Have the iOS submitPayment endpoint save app version like the form front end does - https://phabricator.wikimedia.org/T351689 (10AKanji-WMF) [02:19:18] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.7; 2023-11-28): Test out the readiness of our backup payment processor. - https://phabricator.wikimedia.org/T351714 (10AKanji-WMF) [02:19:20] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog: WIP - Sprint V- Priorities - https://phabricator.wikimedia.org/T350639 (10AKanji-WMF) [02:19:22] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog: Investigation: Reduce number of clicks in donation flow through DonateWiki - https://phabricator.wikimedia.org/T351168 (10AKanji-WMF) [02:19:24] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10FR-Docker: Rename fr-dev 'mediawiki' docker image - https://phabricator.wikimedia.org/T350442 (10AKanji-WMF) [02:19:26] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10Recurring-Donations: Auto-Rescue Edge Cases - https://phabricator.wikimedia.org/T350501 (10AKanji-WMF) [02:19:28] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations: Get CiviProxy -> CiviCRM auth working in production for API4 calls - https://phabricator.wikimedia.org/T349946 (10AKanji-WMF) [02:19:30] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Smashpig, and 2 others: Cancel auto-rescue at Adyen when donor cancels recurring donation in Civi - https://phabricator.wikimedia.org/T351338 (10AKanji-WMF) [02:19:32] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Update thank you main & endowment mail to use new stock fields - https://phabricator.wikimedia.org/T350331 (10AKanji-WMF) [02:19:34] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Get CiviProxy API4 patch merged upstream - https://phabricator.wikimedia.org/T349762 (10AKanji-WMF) [02:19:36] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Coworker - send fail mail when a queue aborts - https://phabricator.wikimedia.org/T349751 (10AKanji-WMF) [02:19:38] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Coworker - figure out how to direct log information better - https://phabricator.wikimedia.org/T349754 (10AKanji-WMF) [02:19:40] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog: Remove the recurring queue threshold alerts - https://phabricator.wikimedia.org/T348533 (10AKanji-WMF) [02:19:42] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Follow up on coworker - do some testing with queue_pause & busy on prod - https://phabricator.wikimedia.org/T348704 (10AKanji-WMF) [02:19:44] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog: Import and verify small batch of Ingenico tokens from Adyen CSVs - https://phabricator.wikimedia.org/T348771 (10AKanji-WMF) [02:19:46] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.5; 2023-11-14): Edit configuration to send explicit Ingenico requests to Adyen - https://phabricator.wikimedia.org/T345461 (10AKanji-WMF) [02:19:48] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Fix import date handling to deal with truncated time - https://phabricator.wikimedia.org/T342716 (10AKanji-WMF) [02:19:50] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog: Data Axle Project - Re-import to Civi - https://phabricator.wikimedia.org/T341902 (10AKanji-WMF) [02:19:52] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog: India Recurring - Figure out when to actually cancel donations - https://phabricator.wikimedia.org/T339181 (10AKanji-WMF) [02:19:54] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Patch-For-Review: All Ingenico/Worldline active tokens will be migrated to Adyen - https://phabricator.wikimedia.org/T344645 (10AKanji-WMF) [02:19:56] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10FR-AutoTY-Email, 10FR-donorservices: EoY receipt email donation format issue 2023 - https://phabricator.wikimedia.org/T332232 (10AKanji-WMF) [02:19:58] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10FR-Japan: Make the Japan "V1" payment wiki variant the new control - https://phabricator.wikimedia.org/T329807 (10AKanji-WMF) [02:20:02] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising Sprint Uptown cURL, 10Fundraising Sprint vvv - tell me more, 10Fundraising-Backlog, and 4 others: donate.wikimedia.org landing pages don't have descriptions in search engine results - https://phabricator.wikimedia.org/T254808 (10AKanji-WMF) [02:20:06] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10FR-Smashpig, and 2 others: Remove old AstroPay code from SmashPig - https://phabricator.wikimedia.org/T326218 (10AKanji-WMF) [02:20:10] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog: Measure donation processing rate (once we decide what that is) - https://phabricator.wikimedia.org/T342013 (10AKanji-WMF) [02:20:14] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10Wikipedia-iOS-App-Backlog, 10MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), and 2 others: Standardize utm_source from app donations without a banner and clean up old data - https://phabricator.wikimedia.org/T350919 (10AKanji-WMF) [02:20:19] More better [02:20:20] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Send recurring payment notifications to the donations queue - https://phabricator.wikimedia.org/T240581 (10AKanji-WMF) [02:28:44] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 10Patch-For-Review: Civi shouldn't show "cancellation not supported" message for processors where we handle schedule - https://phabricator.wikimedia.org/T335712 (10AKanji-WMF) [02:31:34] ok - so replicating now & it is weird - if I am logged in in another browser then it works - even if I'm testing in an incognito window. Otherwise it doesn't [02:38:56] (03PS1) 10Eileen: Remove permission check in function called from getUpgradeableRecur [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980522 [02:39:35] (03PS1) 10Eileen: I think this is more correct [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980523 [02:40:08] ok cstone ejegg the first of those 2 patches fixes the permissions issue I think - but highlights that we need to figure out how to test this flow [02:41:50] (03CR) 10Cstone: [C: 03+2] OK - more better trace [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980521 (owner: 10Eileen) [02:42:35] I might not need that now - I think I figured it - finding the step through a bit disturbing in some ways though [02:58:15] (03Merged) 10jenkins-bot: OK - more better trace [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980521 (owner: 10Eileen) [03:47:10] wat: api key only works while login session is active???? [04:14:57] !log standalone (payments listener) SmashPig upgraded from f24afba3 to 83d509ed [04:14:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:40:25] eileen: is it really that authx depends on logged-in state even for api_key use? [04:46:15] (03CR) 10Ejegg: [C: 03+2] Remove permission check in function called from getUpgradeableRecur [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980522 (owner: 10Eileen) [04:46:52] (03CR) 10Ejegg: [C: 03+2] I think this is more correct [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980523 (owner: 10Eileen) [05:02:44] (03Merged) 10jenkins-bot: Remove permission check in function called from getUpgradeableRecur [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980522 (owner: 10Eileen) [05:03:05] (03Merged) 10jenkins-bot: I think this is more correct [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980523 (owner: 10Eileen) [05:04:09] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/980533 [05:04:13] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/980533 (owner: 10Ejegg) [05:05:17] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/980533 (owner: 10Ejegg) [05:09:40] !log fundraising civicrm upgraded from 6bb8a67f to 6ca683b2 [05:09:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [05:10:09] well shucks, that worked. Thanks a million, eileen! [07:20:30] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/980615 (owner: 10L10n-bot) [07:31:17] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: some FRU donations without country data in Civi - https://phabricator.wikimedia.org/T351773 (10jgleeson) Thanks @MBeat33. I'll focus on populating the Country field for now. @Damilare pointed out yesterday that we don't currently col... [08:35:37] 10Fundraising-Backlog, 10FR-Brazil, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Support PIX (DIRECT) in DLocal - https://phabricator.wikimedia.org/T324303 (10Farnoosh85A) a:03.Toon [12:08:08] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: some FRU donations without country data in Civi - https://phabricator.wikimedia.org/T351773 (10MSuijkerbuijk_WMF) Hi @Damilare as far as I recall, this is a known fact. During the first conversations with FRU, we already talked about... [12:20:37] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: some FRU donations without country data in Civi - https://phabricator.wikimedia.org/T351773 (10Pcoombe) There is an option in the FRU campaigns settings (in the "Supporter" section) to either request or require a postal address. We d... [12:43:46] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices: some FRU donations without country data in Civi - https://phabricator.wikimedia.org/T351773 (10Damilare) Unfortunately, I don't have that information @MSuijkerbuijk_WMF. Thanks @Pcoombe for sharing the screenshot looks like they've... [12:51:40] (03CR) 10Jgleeson: [C: 04-1] "This looks good to me. Just some small asks. Thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/972922 (https://phabricator.wikimedia.org/T339182) (owner: 10Ejegg) [14:40:32] (03PS1) 10Jgleeson: Add country fallback behaviour to FRUP audit code parser. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/980874 (https://phabricator.wikimedia.org/T351773) [14:48:06] (03PS2) 10Jgleeson: Add country fallback behaviour to FRUP audit code parser. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/980874 (https://phabricator.wikimedia.org/T351773) [14:51:26] (03PS1) 10Jgleeson: WIP: Add country fallback behaviour to FRUP recurring audit code parser. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/980876 (https://phabricator.wikimedia.org/T351773) [14:51:51] (03CR) 10CI reject: [V: 04-1] WIP: Add country fallback behaviour to FRUP recurring audit code parser. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/980876 (https://phabricator.wikimedia.org/T351773) (owner: 10Jgleeson) [14:59:02] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices, 10Patch-For-Review: some FRU donations without country data in Civi - https://phabricator.wikimedia.org/T351773 (10jgleeson) I decided to take the simplest option and retrieve the country from the donor's donation URL in https://ge... [15:02:31] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks for adding the tests, LGTM." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/977772 (https://phabricator.wikimedia.org/T351673) (owner: 10Ejegg) [15:02:36] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices, 10Patch-For-Review: some FRU donations without country data in Civi - https://phabricator.wikimedia.org/T351773 (10jgleeson) @MBeat33 @Damilare When working on this, I noticed that we only attempt to map country when processing th... [15:03:03] (03Merged) 10jenkins-bot: DLocal: handle 'CARD' ipn brand format [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/977772 (https://phabricator.wikimedia.org/T351673) (owner: 10Ejegg) [15:07:44] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-donorservices, 10Patch-For-Review: some FRU donations without country data in Civi - https://phabricator.wikimedia.org/T351773 (10Damilare) Yes that'd be a good addition too, thanks @jgleeson. [15:43:18] damilare: quick question re: adding country to recurring parser output [15:43:27] sure [15:43:41] will adding the new country field mapping break anything in the calling code that uses the result? [15:44:57] not really, but the tests would be affected [15:45:17] alongside your current patch on the donate part [15:45:42] ok cool I'll add the new field to the importMap and plugin in the fallback fn [15:45:55] -in [15:46:35] I believe adding the country field to the recurring message would update the contact [15:46:54] sure, thanks for working on that [15:47:38] is this one ready for review: [15:47:42] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/980874 [15:48:12] yep! thanks damilare [15:49:47] actually damilare I might add a test to confirm nothing breaks if the country param is not present in the URl [15:49:55] URL* [15:50:08] sounds good [15:50:16] I'd wait [15:50:22] thanks [15:51:48] thanks for the CR damilare and jgleeson ! [15:52:03] I'll upload another ps shortly on that audit patch [15:58:04] np [16:02:15] (03PS3) 10Jgleeson: Add country fallback behaviour to FRUP audit code parser. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/980874 (https://phabricator.wikimedia.org/T351773) [16:06:45] (03PS2) 10Jgleeson: WIP: Add country fallback behaviour to FRUP recurring audit code parser. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/980876 (https://phabricator.wikimedia.org/T351773) [16:07:05] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/980874 should be ready for review now damilare thanks [16:07:10] (03CR) 10CI reject: [V: 04-1] WIP: Add country fallback behaviour to FRUP recurring audit code parser. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/980876 (https://phabricator.wikimedia.org/T351773) (owner: 10Jgleeson) [16:07:27] the -1 is the recurring follow on [16:07:35] okk [16:07:44] CI doesn't like TDD [16:16:25] (03PS4) 10Ejegg: Audit: fill missing contribution_tracking rows [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/972922 (https://phabricator.wikimedia.org/T339182) [16:17:32] (03CR) 10Ejegg: "Thanks for the review wfan and jgleeson. Comments addressed in PS4" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/972922 (https://phabricator.wikimedia.org/T339182) (owner: 10Ejegg) [16:18:32] or maybe zuul loves giving V-1s and TDD lets them do it early and often? [16:18:51] ha [16:19:03] red(zuul), green, refactor [16:27:53] (03PS3) 10Jgleeson: Add country fallback behaviour to FRUP recurring audit code parser. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/980876 (https://phabricator.wikimedia.org/T351773) [16:29:36] hmm ejegg [16:29:56] did I break the var naming convention with that ask [16:30:16] maybe we should keep it snake_case [16:30:48] jgleeson: ehh, if it's all going to move to the Civi extension we might as we write all the new code in camelCase [16:30:58] ah ok [16:31:01] it'll make it easier to review the move later [16:31:14] makes sense [16:37:08] ejegg: one minor thing on that patch [16:37:29] I noticed that the test was returning 'date'=>false in the result [16:37:41] looks like it's trying to pass a unix timestamp into strtotime() [16:37:46] jgleeson: TIL about the @covers annotation, however it seems the classname::methodname syntax is not recommended from the docs here: https://docs.phpunit.de/en/8.5/annotations.html#covers:~:text=covers%20ClassName%3A%3AmethodName-,(not%20recommended),-Specifies%20that%20the [16:37:47] that might just be bad test data? [16:38:05] sorry for breaking your messages also :) [16:39:06] the patch looks good to me, unless you want to change that annotation, I'm happy to +2 as is [16:39:10] ah ok thanks for the info damilare. looks like I should go with ::getCountryFromDonationURL in that case [16:39:54] yh that's recommended too, why not classname though? [16:40:39] ohh I see, doesn't cover all methods in the class [16:40:39] hmm maybe to decouple it in the event that it moves to a super/other class [16:40:53] that makes sense [16:41:07] I'll update the patch now [16:44:34] (03CR) 10DannyS712: [C: 03+2] "false positive" [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/980615 (owner: 10L10n-bot) [16:45:22] (03PS5) 10Ejegg: Log card verification error with datetime and timezone [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/975934 (https://phabricator.wikimedia.org/T349600) (owner: 10Wfan) [16:45:31] (03CR) 10Ejegg: [C: 03+2] Log card verification error with datetime and timezone [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/975934 (https://phabricator.wikimedia.org/T349600) (owner: 10Wfan) [16:48:27] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/980905 [16:49:08] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/980905 (owner: 10Ejegg) [16:49:53] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/980905 (owner: 10Ejegg) [16:49:58] (03CR) 10Jgleeson: Audit: fill missing contribution_tracking rows (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/972922 (https://phabricator.wikimedia.org/T339182) (owner: 10Ejegg) [16:52:09] (03PS4) 10Jgleeson: Add country fallback behaviour to FRUP audit code parser. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/980874 (https://phabricator.wikimedia.org/T351773) [17:14:05] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10LandingCheck, 10Wikimedia-production-error: Remove calls to GeoIP 1 in Extension:LandingCheck - https://phabricator.wikimedia.org/T352247 (10greg) [17:43:11] 10Fundraising-Backlog: Sprint W - Priorities - https://phabricator.wikimedia.org/T351767 (10Ejegg) [17:44:31] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Suppress failmail on contribution tracking contraint violations - https://phabricator.wikimedia.org/T352321 (10Ejegg) p:05Triage→03Low a:03Ejegg [17:47:14] !log standalone SmashPig upgraded from 83d509ed to fc74ccca [17:47:16] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:51:45] (03PS5) 10Ejegg: Audit: fill missing contribution_tracking rows [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/972922 (https://phabricator.wikimedia.org/T339182) [17:52:53] (03CR) 10Ejegg: "Thanks @jgleeson, fixed in PS5" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/972922 (https://phabricator.wikimedia.org/T339182) (owner: 10Ejegg) [17:56:27] 10Fundraising-Backlog, 10FR-matching-gifts, 10MediaWiki-extensions-DonationInterface: Host matching gift info form on our domain - https://phabricator.wikimedia.org/T352898 (10Ejegg) [18:22:16] 10Fundraising-Backlog: Sprint X: Priorities - WIP - https://phabricator.wikimedia.org/T352901 (10AKanji-WMF) [18:22:30] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog: WIP - Sprint V- Priorities - https://phabricator.wikimedia.org/T350639 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF Closing and migrating relevant tasks to: https://phabricator.wikimedia.org/T352901 [18:24:14] 10Fundraising-Backlog: Sprint X: Priorities - WIP - https://phabricator.wikimedia.org/T352901 (10AKanji-WMF) [18:24:56] 10Fundraising-Backlog: Sprint W - Priorities - https://phabricator.wikimedia.org/T351767 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF Resolving and migrating priorities to {T352901} [19:19:38] 10Fundraising-Backlog: Matching Gift information link broken - https://phabricator.wikimedia.org/T352771 (10Ejegg) @nisrael and I just figured out that the full link is in the database rather than being dynamically generated in the Acoustic template. So I'll update those links in Civi and make sure that all the... [19:29:27] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Recurring-Donations: Error submitting recur upgrade form in production - https://phabricator.wikimedia.org/T352907 (10Ejegg) [19:43:49] (03PS1) 10Ejegg: Update matching_gifts_provider_info_url [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980930 (https://phabricator.wikimedia.org/T352771) [19:44:13] OK, let's see how long that update takes on staging [19:52:00] ejegg: weirdly, the screenshot you sent me hasn't come through yet! [19:53:13] oops, did i remember to press send? [19:53:35] nope, it was still in 'drafts' [19:53:46] just sent it for real anilk [19:54:11] hah! thanks! [20:20:29] (03CR) 10Cstone: [C: 03+2] "Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980930 (https://phabricator.wikimedia.org/T352771) (owner: 10Ejegg) [20:38:02] (03Merged) 10jenkins-bot: Update matching_gifts_provider_info_url [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/980930 (https://phabricator.wikimedia.org/T352771) (owner: 10Ejegg) [20:50:16] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10LandingCheck, 10Wikimedia-production-error: Remove calls to GeoIP 1 in Extension:LandingCheck - https://phabricator.wikimedia.org/T352247 (10Ejegg) Oops, we did this last March for Special:FundraiserLandingPage in {T301485} but didn't notice that La... [20:52:14] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/980942 [20:52:18] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/980942 (owner: 10Ejegg) [20:53:14] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/980942 (owner: 10Ejegg) [20:55:19] !log fundraising civicrm upgraded from 6ca683b2 to 8c107215 [20:55:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:07:12] PROBLEM - check_coworker on frdev1002 is CRITICAL: PROCS CRITICAL: 3 processes with args /srv/coworker/bin/coworker https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1002&service=check_coworker [21:10:11] ACKNOWLEDGEMENT - check_coworker on frdev1002 is CRITICAL: PROCS CRITICAL: 3 processes with args /srv/coworker/bin/coworker Dwisehaupt checking new service. https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1002&service=check_coworker [21:10:12] PROBLEM - check_coworker on civi1002 is CRITICAL: PROCS CRITICAL: 3 processes with args /srv/coworker/bin/coworker https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=civi1002&service=check_coworker [21:11:01] ACKNOWLEDGEMENT - check_coworker on civi1002 is CRITICAL: PROCS CRITICAL: 3 processes with args /srv/coworker/bin/coworker Dwisehaupt checking new service. https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=civi1002&service=check_coworker [21:12:12] PROBLEM - check_coworker on civi2001 is CRITICAL: PROCS CRITICAL: 0 processes with args /srv/coworker/bin/coworker https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=civi2001&service=check_coworker [21:14:06] ACKNOWLEDGEMENT - check_coworker on civi2001 is CRITICAL: PROCS CRITICAL: 0 processes with args /srv/coworker/bin/coworker Dwisehaupt checking new service https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=civi2001&service=check_coworker [21:29:37] 10Fundraising-Backlog: venmo placeholder - https://phabricator.wikimedia.org/T352916 (10AKanji-WMF) [21:29:54] 10Fundraising-Backlog: venmo placeholder - https://phabricator.wikimedia.org/T352916 (10AKanji-WMF) [21:30:32] this is pretty cool https://www.thehits.co.nz/the-latest/kiwi-students-stunning-cover-of-stairway-to-heaven-goes-viral/?fbclid=IwAR1AT2nP3p15L-AW2wbpbBH7W85yI4qf78Ny-nniHLx33H9LCvHtsyT6Yow [21:33:08] 10Fundraising-Backlog: Matching Gift information link broken - https://phabricator.wikimedia.org/T352771 (10Ejegg) OK, the data is updated in Civi and the associated donors have been marked as updated so they will go out with tonight's export. It'll be an extra 137k rows on top of the 870k ish rows that would no... [21:34:05] nice eileen [21:42:26] 10Fundraising-Backlog: Matching Gift information link broken - https://phabricator.wikimedia.org/T352771 (10EMartin) Great! Thanks @Ejegg [22:09:23] eileen: extra cool that they don't have in ear monitors for a click track or anything. shows the practice put in. [22:20:02] dwisehaupt: not something I picked up on [22:20:27] I just like the fact they are in school uniforms & have so many people involved but make such a professional sound [22:21:33] yeah. it's great. [22:21:48] they nailed it. [22:39:33] (no one can tell which kids were only allowed on stage cos their mum would be in principles ear otherwise) [22:41:59] greg-g: (or anyone else with the power) - possible to add Kristine H to the access group so she can collab on Amber's latest phab? [22:51:07] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Test sending from staging with CiviMail & then on live using fr-tech as recipients - https://phabricator.wikimedia.org/T352138 (10Eileenmcnaughton) [22:52:09] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog: Import bug - https://phabricator.wikimedia.org/T352720 (10Eileenmcnaughton) a:03Eileenmcnaughton [22:57:12] RECOVERY - check_coworker on civi2001 is OK: PROCS OK: 0 processes with args php /srv/coworker/bin/coworker https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=civi2001&service=check_coworker [22:57:12] RECOVERY - check_coworker on frdev1002 is OK: PROCS OK: 1 process with args php /srv/coworker/bin/coworker https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1002&service=check_coworker [23:00:12] RECOVERY - check_coworker on civi1002 is OK: PROCS OK: 1 process with args php /srv/coworker/bin/coworker https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=civi1002&service=check_coworker [23:02:27] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add unit tests for our preferences centre code using check-sum-authenticated, low permission user - https://phabricator.wikimedia.org/T352926 (10Eileenmcnaughton) [23:06:22] anilk: done [23:12:39] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Install `coworker` and `cv` on prod - https://phabricator.wikimedia.org/T324611 (10Dwisehaupt) [23:13:21] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Install `coworker` and `cv` on prod - https://phabricator.wikimedia.org/T324611 (10Dwisehaupt) Added icinga monitoring. It checks for the running process when it is enabled on a host and verifies that no processes are running if... [23:13:38] tx greg-g [23:37:21] 10Fundraising-Backlog, 10Recurring-Donations: fundraising-dev needs two redis instances - https://phabricator.wikimedia.org/T352928 (10Ejegg) [23:37:36] 10Fundraising-Backlog, 10FR-Docker, 10Recurring-Donations: fundraising-dev needs two redis instances - https://phabricator.wikimedia.org/T352928 (10Ejegg)