[06:54:20] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_40) - 10https://gerrit.wikimedia.org/r/982991 (owner: 10L10n-bot) [07:02:48] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-Docker: Upgrade to PHP 8 locally - https://phabricator.wikimedia.org/T349204 (10daniel) @jgleeson Can you update the task to make it clear who "we" is, and what "locally" refers to? I suppose this is about the environment we use for fundrais... [07:10:10] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-Docker: Upgrade Local Development Stack Fundraising-Dev Docker Images to use PHP 8 - https://phabricator.wikimedia.org/T349204 (10jgleeson) [07:10:42] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-Docker: Upgrade Local Development Stack Fundraising-Dev Docker Images to use PHP 8 - https://phabricator.wikimedia.org/T349204 (10jgleeson) @daniel done [07:11:26] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Docker: Upgrade Local Development Stack Fundraising-Dev Docker Images to use PHP 8 - https://phabricator.wikimedia.org/T349204 (10jgleeson) [07:13:04] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Docker: Upgrade Local Development Stack Fundraising-Dev Docker Images to use PHP 8 - https://phabricator.wikimedia.org/T349204 (10jgleeson) I've also removed that Mediawiki-Docker tag, which I think I've likely added by mistake, and instead tagged... [07:14:58] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Docker: Upgrade Local Development Stack Fundraising-Dev Docker Images to use PHP 8 - https://phabricator.wikimedia.org/T349204 (10daniel) >>! In T349204#9405658, @jgleeson wrote: > @daniel done Thank you! [13:52:27] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_40) - 10https://gerrit.wikimedia.org/r/982991 (owner: 10L10n-bot) [13:53:19] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising Sprint Uptown cURL, 10Fundraising-Backlog: Import and verify small batch of Ingenico tokens from Adyen CSVs - https://phabricator.wikimedia.org/T348771 (10Ejegg) Overnight failure rates: 4.09% failure for migrated tokens 3.17% failure for non-migrated... [14:53:55] (03PS1) 10Jgleeson: WIP: Handle Adyen SecondChargeback IPNs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/983202 (https://phabricator.wikimedia.org/T352035) [14:54:34] (03CR) 10CI reject: [V: 04-1] WIP: Handle Adyen SecondChargeback IPNs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/983202 (https://phabricator.wikimedia.org/T352035) (owner: 10Jgleeson) [15:00:37] (03PS2) 10Jgleeson: WIP: Handle Adyen SecondChargeback IPNs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/983202 (https://phabricator.wikimedia.org/T352035) [15:01:44] (03PS3) 10Jgleeson: WIP: Handle Adyen SecondChargeback IPNs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/983202 (https://phabricator.wikimedia.org/T352035) [15:03:32] (03PS4) 10Jgleeson: WIP: Handle Adyen SecondChargeback IPNs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/983202 (https://phabricator.wikimedia.org/T352035) [15:14:05] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10FR-Docker, 10Patch-For-Review: Rename fr-dev 'mediawiki' docker image - https://phabricator.wikimedia.org/T350442 (10CodeReviewBot) ejegg opened https://gitlab.wikimedia.org/repos/releng/dev-images/-/merge_requests/59 Rename fundraising... [15:30:55] 10Fundraising-Backlog: Move some logic from the GatewayAdapter class to DonationData class - https://phabricator.wikimedia.org/T336667 (10Ejegg) Let's definitely think more about this. While it's great to move code out of GatewayAdapter.php, I'm not a fan of all the stuff that's already in DonationData. Maybe d... [15:32:01] fr-tech i'm starting to brainstorm about what tech debt to focus on early next year. Want to put any requests here? https://etherpad.wikimedia.org/p/Early2024FrTechDebtPlan [15:55:16] (03PS1) 10Ejegg: Rename mediawiki image [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/983210 (https://phabricator.wikimedia.org/T350442) [15:58:28] jgleeson: lmk if you want any more info on the network segmentation patch - I replied with some test instructions https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/980974/5 [15:59:00] it's on my list to recap today ejegg thanks [15:59:50] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10FR-Docker, 10Patch-For-Review: Rename fr-dev 'mediawiki' docker image - https://phabricator.wikimedia.org/T350442 (10Ejegg) a:03Ejegg [16:01:36] ejegg: I just checked your techdebt list and noticed https://phabricator.wikimedia.org/T240581. I wanted to follow up on that and break up into smaller pieces and try and add in any missing tests to give us more confidence when reviewing it. [16:04:33] ok, sounds good [16:06:11] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10FR-Docker, 10Patch-For-Review: Rename fr-dev 'mediawiki' docker image - https://phabricator.wikimedia.org/T350442 (10CodeReviewBot) dancy merged https://gitlab.wikimedia.org/repos/releng/dev-images/-/merge_requests/59 Rename fundraising... [16:12:11] woot, dancy over in releng merged the image-rename patch [16:13:06] now we can test https://gerrit.wikimedia.org/r/983210 without needing to rebuild locally [16:16:18] ejegg: I noticed this after a quick scan https://gitlab.wikimedia.org/repos/releng/dev-images/-/blob/main/dockerfiles/fundraising-bullseye-php74-apache2/Dockerfile.template#L63 [16:17:08] looks like we override it in the docker-compose.yml [16:18:53] ah, ok, i wasn't sure it was always overridden so i left it [16:30:41] 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.9; 2023-12-12): Add Monthly Convert to Dlocal forms - https://phabricator.wikimedia.org/T303778 (10HNordeenWMF) Got it. thanks @Ejegg ! Confirming I'll set up the January 24 Pre-test test variants with Credit card, GPay and ApplePay pointing to variant=monthly... [16:31:49] (03PS5) 10Jgleeson: Handle Adyen SecondChargeback IPNs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/983202 (https://phabricator.wikimedia.org/T352035) [16:32:13] ejegg: thanks for the tech debt initiative! [16:35:42] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10FR-Japan, 10Patch-For-Review: Make the Japan "V1" payment wiki variant the new control - https://phabricator.wikimedia.org/T329807 (10HNordeenWMF) @Ejegg all forms with language ja! [16:35:53] ejegg: just to clarify, should I test on my current fun-dev master (doesn't include your patch) and a version of DI without the patch you linked in the comment here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/980974/5 [16:36:46] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10MW-1.42-notes (1.42.0-wmf.9; 2023-12-12): Enable variant with no matching gift field for GPay/ApplePay/Venmo - https://phabricator.wikimedia.org/T353064 (10HNordeenWMF) Thanks so much @Ejegg and @AnnWF ! We'll test this & let you know how i... [16:39:28] jgleeson: you can test on fun-dev master to see the old DI code work [16:39:53] then pull the fun-dev patch and d-c down && d-c up -d [16:40:06] to see the old DI code fail with the new segmentation [16:40:13] ah [16:40:26] then pull new DI code into email-pref-center [16:40:37] and see the new DI code work with the segmentation [16:40:51] if you really want to be thorough [16:41:10] fortunately you can do that all with just a single recurring contrib set up [16:41:46] ok thanks [16:53:08] (03CR) 10Damilare Adedoyin: [C: 03+2] Dont add Refund status contributions to EOY [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/982947 (https://phabricator.wikimedia.org/T332232) (owner: 10Cstone) [16:56:04] (03PS4) 10Wfan: Use ja_01A as default for all ja as language form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/981445 (https://phabricator.wikimedia.org/T329807) [16:58:57] (03PS2) 10Ejegg: Rename mediawiki image [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/983210 (https://phabricator.wikimedia.org/T350442) [16:59:58] ejegg: I can see the message now being pushed to recurring-upgrade. What consumer processes those messages now? [17:00:13] over on 'donorprefsqueues' [17:11:22] (03Merged) 10jenkins-bot: Dont add Refund status contributions to EOY [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/982947 (https://phabricator.wikimedia.org/T332232) (owner: 10Cstone) [17:25:36] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices: Civi: EoY recurring summary email - include CNTCT - https://phabricator.wikimedia.org/T353372 (10Cstone) a:03Cstone [17:33:35] (03PS6) 10Jgleeson: Handle Adyen SecondChargeback IPNs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/983202 (https://phabricator.wikimedia.org/T352035) [17:42:13] 10Fundraising Tech - Chaos Crew, 10Wikimedia-production-error: Error in fundraising banner: TypeError: Cannot read properties of undefined (reading 'style') - https://phabricator.wikimedia.org/T353475 (10Jdlrobson) [17:42:26] 10Fundraising Tech - Chaos Crew, 10Wikimedia-production-error: Error in fundraising banner: TypeError: Cannot read properties of undefined (reading 'style') - https://phabricator.wikimedia.org/T353475 (10Jdlrobson) [18:05:57] 10Fundraising Tech - Chaos Crew, 10Wikimedia-production-error: Error in fundraising banner: TypeError: Cannot read properties of undefined (reading 'style') - https://phabricator.wikimedia.org/T353475 (10Pcoombe) Weird. This error only occurs at midnights, from a single Chrome OS user agent. https://logstash.w... [18:06:27] jgleeson|food: for the consumer side, see https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/981419 [18:07:12] and https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/980967 [18:07:33] fr-tech are we doing alerts retro? [18:08:45] hmm, looks like it's been since September [18:12:27] 10Fundraising-Backlog, 10Wikipedia-iOS-App-Backlog, 10iOS Release FY2023-24: Don't show in-app apple pay banners when apple pay region is CN - https://phabricator.wikimedia.org/T352180 (10Tsevener) 05Open→03Resolved [18:53:56] https://xkcd.com/2867/ [18:58:10] ahh ^^ [18:58:53] what tz was ti/t2, what tz am I in, what tz are you in... maybe we don't need to know [19:01:50] what tz is my laptop accidentally in [19:03:54] thanks ejegg will check it out [19:06:39] AndyRussG|vol: lol. I clicked random and found this one which is pretty good too https://xkcd.com/1820/ [19:07:33] lol [19:07:37] o/ ;) [19:08:29] hope all's well with everyone, giant hugs all around ;) [19:10:17] same to you! [19:10:41] cat gifts? https://xkcd.com/325/ [19:28:25] damilare: that TypeError thing reminded me of this. Looks like Adyen JS was throwing errors at some point https://phabricator.wikimedia.org/T352458 [19:38:52] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: "contribution_id":8.8888888888888887e+21 - https://phabricator.wikimedia.org/T353318 (10jgleeson) 05Open→03Declined Thanks for the explanation @Ejegg. I'll close this one now. [19:40:59] (03CR) 10Jgleeson: [C: 03+2] "Thanks for adding this! made it much easier to review the other patch." [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/981419 (https://phabricator.wikimedia.org/T352907) (owner: 10Ejegg) [19:41:05] (03CR) 10Jgleeson: [V: 03+2 C: 03+2] Add recurring-upgrade to queue consume script [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/981419 (https://phabricator.wikimedia.org/T352907) (owner: 10Ejegg) [19:42:05] (03CR) 10Jgleeson: [V: 03+2 C: 03+2] "This is working well for me after doing the full test discussed here and over IRC. thanks!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/980974 (https://phabricator.wikimedia.org/T352928) (owner: 10Ejegg) [19:43:58] (03CR) 10Jgleeson: [V: 03+2 C: 03+2] "LGTM!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/982905 (owner: 10Ejegg) [19:49:35] (03CR) 10Jgleeson: [V: 03+2 C: 03+2] "New image downloaded as expected and everything worked as usual! Thanks" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/983210 (https://phabricator.wikimedia.org/T350442) (owner: 10Ejegg) [20:02:30] hey AndyRussG|vol [20:10:43] eileen: hii!! [20:10:48] jgleeson: ;) [20:11:45] (03CR) 10Jgleeson: [V: 03+2 C: 03+1] "I couldn't see the phone number coming back in my tests, but I can see the field name is valid https://graphql.braintreepayments.com/refer" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/972889 (owner: 10Wfan) [20:27:54] thanks for all the CR jgleeson [20:27:57] and hi AndyRussG|vol ! [20:28:03] hows' it all going? [20:28:48] ;) [20:29:16] not bad, thanks! apologies for the continued delays on replying to e-mails btw heheh [20:29:42] just finishing my semester with some only actual university-credit courses, final exam for Math is on Monday [20:29:50] *online [20:30:42] oh nice! [20:31:41] heeheh I've learned a lot, though probably it would have been easier if I hadn't just skipped calculus 8p [20:32:48] jgleeson: are you referring to the CN bug? [20:32:59] sorry was out for food also [20:33:08] hi AndyRussG|vol o// [20:33:25] yep damilare although it's not the one reported. ours is Adyen specific [20:33:38] I was just about to add |away :) [20:33:41] bye for now [20:33:43] yep, maybe it's browser related [20:33:50] always catching you at the nick of time [20:33:55] :> [20:34:24] heyyy damilare! :) :) [20:58:42] (03PS1) 10Ejegg: Update CurrencyRates [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/983264 (https://phabricator.wikimedia.org/T353027) [20:59:41] 10Fundraising Sprint - X gon' donate to ya, 10Fundraising-Backlog, 10Patch-For-Review: Update Smashpig currencies in January 2024 - https://phabricator.wikimedia.org/T353027 (10Ejegg) [21:21:57] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/983202 (https://phabricator.wikimedia.org/T352035) (owner: 10Jgleeson) [21:22:27] (03Merged) 10jenkins-bot: Handle Adyen SecondChargeback IPNs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/983202 (https://phabricator.wikimedia.org/T352035) (owner: 10Jgleeson) [21:32:18] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: Adyen SecondChargeback IPN causes refund queue failure - https://phabricator.wikimedia.org/T352035 (10Ejegg) @jgleeson 's patch here should fix the refund queue failure. Now we're just going to drop the chargeback when we ge... [21:53:26] new pretty pictures just dropped: https://medium.com/freely-sharing-the-sum-of-all-knowledge/birds-bugs-and-beauty-the-winners-of-wiki-loves-earth-2023-633d4a4e261f [22:17:47] (03CR) 10Ejegg: "Visually and functionally this looks great, I just worry that by using the same message fields we risk someone 'fixing' the Japanese trans" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/981445 (https://phabricator.wikimedia.org/T329807) (owner: 10Wfan) [22:23:28] (03CR) 10Wfan: Use ja_01A as default for all ja as language form (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/981445 (https://phabricator.wikimedia.org/T329807) (owner: 10Wfan) [22:24:31] (03PS1) 10Ejegg: WIP possible way to load ja message_replacements [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/983274 (https://phabricator.wikimedia.org/T329807) [22:26:21] (03CR) 10Ejegg: Use ja_01A as default for all ja as language form (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/981445 (https://phabricator.wikimedia.org/T329807) (owner: 10Wfan) [22:26:23] (03CR) 10CI reject: [V: 04-1] WIP possible way to load ja message_replacements [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/983274 (https://phabricator.wikimedia.org/T329807) (owner: 10Ejegg) [22:27:14] I see I will take a look :) Thanks ejegg~ [22:27:27] thank you ! [22:27:59] gonna head out for now. See you all Tuesday!